[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-21 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r189774748 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/JobStateManager.java #

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-21 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r189777512 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/ExecutorRegis

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-21 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r189777669 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/ExecutorRegis

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-21 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r189683185 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/BatchSingleJo

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-21 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r189775205 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/BatchSingleJo

[GitHub] seojangho opened a new pull request #22: [Nemo-68] Restrict the number of parallel connections between executors

2018-05-22 Thread GitBox
seojangho opened a new pull request #22: [Nemo-68] Restrict the number of parallel connections between executors URL: https://github.com/apache/incubator-nemo/pull/22 JIRA: [NEMO-68: Restrict the number of parallel connections between executors](https://issues.apache.org/jira/projects/NEMO

[GitHub] seojangho opened a new pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform

2018-05-22 Thread GitBox
seojangho opened a new pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform URL: https://github.com/apache/incubator-nemo/pull/23 JIRA: [NEMO-67: Support Beam CoGroupByKey transform](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-67) **Majo

[GitHub] johnyangk commented on issue #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-23 Thread GitBox
johnyangk commented on issue #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#issuecomment-391552787 @jeongyooneo Thanks! I've addressed your comments. This i

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-23 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r18975 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/JobStateManager.java #

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-23 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r190453736 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/BatchSingleJo

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-23 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r190453145 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/JobStateManager.java #

[GitHub] johnyangk commented on issue #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-23 Thread GitBox
johnyangk commented on issue #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#issuecomment-391575534 @jeongyooneo Good catch. I've update the branch to reflect your comments.

[GitHub] bgchun commented on issue #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-23 Thread GitBox
bgchun commented on issue #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#issuecomment-391582976 @johnyangk Do we have good tests to check the code in the `runtime.master` package?

[GitHub] johnyangk commented on issue #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-23 Thread GitBox
johnyangk commented on issue #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#issuecomment-391586301 @bgchun We have some good tests, but they can be improved. The `scheduler` package is covered relatively well. We also hav

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-23 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r190453736 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/BatchSingleJo

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-23 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r190453736 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/BatchSingleJo

[GitHub] jeongyooneo closed pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-23 Thread GitBox
jeongyooneo closed pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark

2018-05-23 Thread GitBox
wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18#discussion_r190471382 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/source/SparkDatasetBoundedSourceVe

[GitHub] wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark

2018-05-23 Thread GitBox
wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18#discussion_r189497103 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/SparkLauncher.java ## @@

[GitHub] sanha commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark

2018-05-23 Thread GitBox
sanha commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18#discussion_r190481637 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/SparkLauncher.java ## @@

[GitHub] sanha commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark

2018-05-24 Thread GitBox
sanha commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18#discussion_r190483000 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/source/SparkDatasetBoundedSourceVer

[GitHub] sanha commented on issue #18: [NEMO-45] Distributed Nemo-Spark

2018-05-24 Thread GitBox
sanha commented on issue #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18#issuecomment-391610537 @wonook Thanks for your review! Unfortunately, I cannot remove `SparkLauncher.java` because it is used in `SparkSession`. ---

[GitHub] wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark

2018-05-24 Thread GitBox
wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18#discussion_r190494100 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/SparkLauncher.java ## @@

[GitHub] wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark

2018-05-24 Thread GitBox
wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18#discussion_r190495764 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/sql/SparkSession.java ##

[GitHub] wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark

2018-05-24 Thread GitBox
wonook commented on a change in pull request #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18#discussion_r190495950 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/sql/SparkSession.java ##

[GitHub] sanha commented on issue #18: [NEMO-45] Distributed Nemo-Spark

2018-05-24 Thread GitBox
sanha commented on issue #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18#issuecomment-391627991 @wonook Thanks! Your comments are addressed. This is an automated message from the Apa

[GitHub] wonook closed pull request #18: [NEMO-45] Distributed Nemo-Spark

2018-05-24 Thread GitBox
wonook closed pull request #18: [NEMO-45] Distributed Nemo-Spark URL: https://github.com/apache/incubator-nemo/pull/18 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull requ

[GitHub] jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic

2018-05-24 Thread GitBox
jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r18975 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/JobStateManager.java #

[GitHub] jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors

2018-05-24 Thread GitBox
jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors URL: https://github.com/apache/incubator-nemo/pull/22#discussion_r190522859 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data

[GitHub] jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors

2018-05-24 Thread GitBox
jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors URL: https://github.com/apache/incubator-nemo/pull/22#discussion_r190579092 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data

[GitHub] jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors

2018-05-24 Thread GitBox
jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors URL: https://github.com/apache/incubator-nemo/pull/22#discussion_r190521924 ## File path: conf/src/main/java/edu/snu/nemo/conf/JobConf.java ## @@

[GitHub] jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors

2018-05-24 Thread GitBox
jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors URL: https://github.com/apache/incubator-nemo/pull/22#discussion_r190531465 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data

[GitHub] jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors

2018-05-24 Thread GitBox
jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors URL: https://github.com/apache/incubator-nemo/pull/22#discussion_r190526159 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data

[GitHub] jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors

2018-05-24 Thread GitBox
jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors URL: https://github.com/apache/incubator-nemo/pull/22#discussion_r190584189 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data

[GitHub] jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors

2018-05-24 Thread GitBox
jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors URL: https://github.com/apache/incubator-nemo/pull/22#discussion_r190584189 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data

[GitHub] jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors

2018-05-24 Thread GitBox
jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors URL: https://github.com/apache/incubator-nemo/pull/22#discussion_r190579092 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data

[GitHub] jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors

2018-05-24 Thread GitBox
jeongyooneo commented on a change in pull request #22: [NEMO-68] Restrict the number of parallel connections between executors URL: https://github.com/apache/incubator-nemo/pull/22#discussion_r190579092 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data

[GitHub] wonook commented on a change in pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform

2018-05-25 Thread GitBox
wonook commented on a change in pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform URL: https://github.com/apache/incubator-nemo/pull/23#discussion_r190807947 ## File path: compiler/frontend/beam/src/main/java/edu/snu/nemo/compiler/frontend/beam/N

[GitHub] wonook commented on a change in pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform

2018-05-25 Thread GitBox
wonook commented on a change in pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform URL: https://github.com/apache/incubator-nemo/pull/23#discussion_r190808251 ## File path: compiler/frontend/beam/src/main/java/edu/snu/nemo/compiler/frontend/beam/N

[GitHub] seojangho commented on a change in pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform

2018-05-27 Thread GitBox
seojangho commented on a change in pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform URL: https://github.com/apache/incubator-nemo/pull/23#discussion_r191112708 ## File path: compiler/frontend/beam/src/main/java/edu/snu/nemo/compiler/frontend/bea

[GitHub] seojangho commented on issue #22: [NEMO-68] Restrict the number of parallel connections between executors

2018-05-27 Thread GitBox
seojangho commented on issue #22: [NEMO-68] Restrict the number of parallel connections between executors URL: https://github.com/apache/incubator-nemo/pull/22#issuecomment-392423704 @jeongyooneo Thanks for the comment! Please check the updates.

[GitHub] wonook closed pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform

2018-05-28 Thread GitBox
wonook closed pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform URL: https://github.com/apache/incubator-nemo/pull/23 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provena

[GitHub] jeongyooneo closed pull request #22: [NEMO-68] Restrict the number of parallel connections between executors

2018-05-28 Thread GitBox
jeongyooneo closed pull request #22: [NEMO-68] Restrict the number of parallel connections between executors URL: https://github.com/apache/incubator-nemo/pull/22 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake o

[GitHub] johnyangk opened a new pull request #24: [NEMO-79] Clean up the legacy Task

2018-05-28 Thread GitBox
johnyangk opened a new pull request #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24 JIRA: [NEMO-79: Clean up the legacy Task](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-79) **Major changes:** - Removes the legacy Task int

[GitHub] johnyangk commented on issue #24: [NEMO-79] Clean up the legacy Task

2018-05-28 Thread GitBox
johnyangk commented on issue #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#issuecomment-392669064 @jeongyooneo Sorry, let me resolve the conflicts first. I'll let you know when the branch is ready to be reviewed. -

[GitHub] johnyangk commented on issue #24: [NEMO-79] Clean up the legacy Task

2018-05-29 Thread GitBox
johnyangk commented on issue #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#issuecomment-393010390 @jeongyooneo The branch is now ready for your review. 😄 This is an automated me

[GitHub] seojangho commented on issue #24: [NEMO-79] Clean up the legacy Task

2018-05-30 Thread GitBox
seojangho commented on issue #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#issuecomment-393052415 Hi @johnyangk, thanks for the work! It seems that changes in this PR makes the visualzer unable to display source information in physical plan

[GitHub] johnyangk commented on issue #24: [NEMO-79] Clean up the legacy Task

2018-05-30 Thread GitBox
johnyangk commented on issue #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#issuecomment-393058182 Thanks @seojangho! Yes, I'll see if I can come up with something better than `SourceVertex#clearInternalStates` to avoid attaching all of the inp

[GitHub] wonook commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task

2018-05-30 Thread GitBox
wonook commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#discussion_r191667494 ## File path: bin/json2dot.py ## @@ -64,8 +64,8 @@ def __init__(self, data): self.id = data['id']

[GitHub] wonook commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task

2018-05-30 Thread GitBox
wonook commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#discussion_r191672052 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/RuntimeIdGenerator.java ## @@ -76,36 +79

[GitHub] wonook commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task

2018-05-30 Thread GitBox
wonook commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#discussion_r191671729 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/RuntimeIdGenerator.java ## @@ -76,36 +79

[GitHub] johnyangk commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task

2018-05-30 Thread GitBox
johnyangk commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#discussion_r191732056 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/RuntimeIdGenerator.java ## @@ -76,36

[GitHub] johnyangk commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task

2018-05-30 Thread GitBox
johnyangk commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#discussion_r191733983 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/RuntimeIdGenerator.java ## @@ -76,36

[GitHub] johnyangk commented on issue #24: [NEMO-79] Clean up the legacy Task

2018-05-30 Thread GitBox
johnyangk commented on issue #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#issuecomment-393131163 @seojangho @wonook I've addressed your comments. The issue with the visualizer has been fixed. This visualization of MapReduceITCase shows

[GitHub] jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task

2018-05-31 Thread GitBox
jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#discussion_r192001641 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskExecutor.java ## @@ -246,64

[GitHub] jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task

2018-05-31 Thread GitBox
jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#discussion_r192001937 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskExecutor.java ## @@ -374,22

[GitHub] jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task

2018-05-31 Thread GitBox
jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#discussion_r192003647 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/BatchSingleJobScheduler.java #

[GitHub] jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task

2018-05-31 Thread GitBox
jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#discussion_r191996204 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/plan/physical/PhysicalPlanGenerator.java ###

[GitHub] jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task

2018-05-31 Thread GitBox
jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#discussion_r192000745 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskExecutor.java ## @@ -41,79

[GitHub] jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task

2018-05-31 Thread GitBox
jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#discussion_r192005437 ## File path: common/src/main/java/edu/snu/nemo/common/ir/vertex/SourceVertex.java ## @@ -34,4 +34,9 @@

[GitHub] jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task

2018-05-31 Thread GitBox
jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#discussion_r192001967 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskExecutor.java ## @@ -374,22

[GitHub] johnyangk commented on issue #24: [NEMO-79] Clean up the legacy Task

2018-05-31 Thread GitBox
johnyangk commented on issue #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#issuecomment-393720952 @jeongyooneo Thanks. I've addressed your comments. This is an automated message

[GitHub] johnyangk opened a new pull request #25: [Nemo-78] Rename PhysicalStage to Stage

2018-06-03 Thread GitBox
johnyangk opened a new pull request #25: [Nemo-78] Rename PhysicalStage to Stage URL: https://github.com/apache/incubator-nemo/pull/25 JIRA: [NEMO-78: Rename PhysicalStage to Stage](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-78) **Major changes:** - Remove the existi

[GitHub] johnyangk closed pull request #25: [Nemo-78] Rename PhysicalStage to Stage

2018-06-04 Thread GitBox
johnyangk closed pull request #25: [Nemo-78] Rename PhysicalStage to Stage URL: https://github.com/apache/incubator-nemo/pull/25 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] johnyangk opened a new pull request #26: [NEMO-78] Rename PhysicalStage to Stage

2018-06-04 Thread GitBox
johnyangk opened a new pull request #26: [NEMO-78] Rename PhysicalStage to Stage URL: https://github.com/apache/incubator-nemo/pull/26 JIRA: [NEMO-78: Rename PhysicalStage to Stage](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-78) **Major changes:** - Remove the existi

[GitHub] johnyangk opened a new pull request #27: [NEMO-49] Replace failed executor with a new executor

2018-06-04 Thread GitBox
johnyangk opened a new pull request #27: [NEMO-49] Replace failed executor with a new executor URL: https://github.com/apache/incubator-nemo/pull/27 JIRA: [NEMO-49: Replace failed executor with a new executor](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-49) **Major chan

[GitHub] sanha opened a new pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-04 Thread GitBox
sanha opened a new pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28 JIRA: [NEMO-12: Frontend support for Scala Spark](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-12) **Major changes:** - Implement Scala

[GitHub] jeongyooneo commented on a change in pull request #27: [NEMO-49] Replace failed executor with a new executor

2018-06-04 Thread GitBox
jeongyooneo commented on a change in pull request #27: [NEMO-49] Replace failed executor with a new executor URL: https://github.com/apache/incubator-nemo/pull/27#discussion_r192939528 ## File path: runtime/master/src/test/java/edu/snu/nemo/runtime/master/ContainerManagerTest.java

[GitHub] jeongyooneo commented on a change in pull request #27: [NEMO-49] Replace failed executor with a new executor

2018-06-04 Thread GitBox
jeongyooneo commented on a change in pull request #27: [NEMO-49] Replace failed executor with a new executor URL: https://github.com/apache/incubator-nemo/pull/27#discussion_r192939052 ## File path: runtime/master/src/test/java/edu/snu/nemo/runtime/master/ContainerManagerTest.java

[GitHub] jeongyooneo commented on a change in pull request #27: [NEMO-49] Replace failed executor with a new executor

2018-06-04 Thread GitBox
jeongyooneo commented on a change in pull request #27: [NEMO-49] Replace failed executor with a new executor URL: https://github.com/apache/incubator-nemo/pull/27#discussion_r192946662 ## File path: runtime/driver/src/main/java/edu/snu/nemo/driver/NemoDriver.java ## @@ -15

[GitHub] jeongyooneo commented on a change in pull request #27: [NEMO-49] Replace failed executor with a new executor

2018-06-04 Thread GitBox
jeongyooneo commented on a change in pull request #27: [NEMO-49] Replace failed executor with a new executor URL: https://github.com/apache/incubator-nemo/pull/27#discussion_r192936650 ## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/resource/ContainerManager.

[GitHub] jeongyooneo commented on a change in pull request #27: [NEMO-49] Replace failed executor with a new executor

2018-06-04 Thread GitBox
jeongyooneo commented on a change in pull request #27: [NEMO-49] Replace failed executor with a new executor URL: https://github.com/apache/incubator-nemo/pull/27#discussion_r192946662 ## File path: runtime/driver/src/main/java/edu/snu/nemo/driver/NemoDriver.java ## @@ -15

[GitHub] johnyangk commented on a change in pull request #27: [NEMO-49] Replace failed executor with a new executor

2018-06-04 Thread GitBox
johnyangk commented on a change in pull request #27: [NEMO-49] Replace failed executor with a new executor URL: https://github.com/apache/incubator-nemo/pull/27#discussion_r192950066 ## File path: runtime/driver/src/main/java/edu/snu/nemo/driver/NemoDriver.java ## @@ -153,

[GitHub] johnyangk commented on issue #27: [NEMO-49] Replace failed executor with a new executor

2018-06-04 Thread GitBox
johnyangk commented on issue #27: [NEMO-49] Replace failed executor with a new executor URL: https://github.com/apache/incubator-nemo/pull/27#issuecomment-394586994 @jeongyooneo I've addressed your comments. 😄 This is an aut

[GitHub] jeongyooneo closed pull request #27: [NEMO-49] Replace failed executor with a new executor

2018-06-04 Thread GitBox
jeongyooneo closed pull request #27: [NEMO-49] Replace failed executor with a new executor URL: https://github.com/apache/incubator-nemo/pull/27 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] johnyangk commented on issue #26: [NEMO-78] Rename PhysicalStage to Stage

2018-06-04 Thread GitBox
johnyangk commented on issue #26: [NEMO-78] Rename PhysicalStage to Stage URL: https://github.com/apache/incubator-nemo/pull/26#issuecomment-394589550 @jeongyooneo @wonook @seojangho I've resolved the conflicts. 😄 This is an

[GitHub] jeongyooneo commented on a change in pull request #26: [NEMO-78] Rename PhysicalStage to Stage

2018-06-05 Thread GitBox
jeongyooneo commented on a change in pull request #26: [NEMO-78] Rename PhysicalStage to Stage URL: https://github.com/apache/incubator-nemo/pull/26#discussion_r192966782 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/plan/StageEdge.java ## @@ -57,

[GitHub] johnyangk commented on a change in pull request #26: [NEMO-78] Rename PhysicalStage to Stage

2018-06-05 Thread GitBox
johnyangk commented on a change in pull request #26: [NEMO-78] Rename PhysicalStage to Stage URL: https://github.com/apache/incubator-nemo/pull/26#discussion_r192972809 ## File path: runtime/common/src/main/java/edu/snu/nemo/runtime/common/plan/StageEdge.java ## @@ -57,14

[GitHub] johnyangk commented on issue #26: [NEMO-78] Rename PhysicalStage to Stage

2018-06-05 Thread GitBox
johnyangk commented on issue #26: [NEMO-78] Rename PhysicalStage to Stage URL: https://github.com/apache/incubator-nemo/pull/26#issuecomment-394611019 @jeongyooneo Thanks! I've addressed your comment. This is an automated mess

[GitHub] jeongyooneo closed pull request #26: [NEMO-78] Rename PhysicalStage to Stage

2018-06-05 Thread GitBox
jeongyooneo closed pull request #26: [NEMO-78] Rename PhysicalStage to Stage URL: https://github.com/apache/incubator-nemo/pull/26 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a forei

[GitHub] johnyangk opened a new pull request #29: [NEMO-95] Rename ExecutableTask to Task

2018-06-05 Thread GitBox
johnyangk opened a new pull request #29: [NEMO-95] Rename ExecutableTask to Task URL: https://github.com/apache/incubator-nemo/pull/29 JIRA: [NEMO-95: Rename ExecutableTask to Task](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-95) **Major changes:** - Rename Executable

[GitHub] jeongyooneo closed pull request #29: [NEMO-95] Rename ExecutableTask to Task

2018-06-05 Thread GitBox
jeongyooneo closed pull request #29: [NEMO-95] Rename ExecutableTask to Task URL: https://github.com/apache/incubator-nemo/pull/29 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a forei

[GitHub] wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-06 Thread GitBox
wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193319477 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/transform/CollectTransfo

[GitHub] wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-06 Thread GitBox
wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193324652 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/core/SparkFrontendUtils.

[GitHub] wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-06 Thread GitBox
wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193322788 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/sql/Dataset.java ##

[GitHub] wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-06 Thread GitBox
wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193308930 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/core/rdd/PairRDDFunction

[GitHub] wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-06 Thread GitBox
wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193309027 ## File path: examples/spark/src/main/scala/edu/snu/nemo/examples/spark/SparkWordCount.scala ## @@ -0,0

[GitHub] wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-06 Thread GitBox
wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193308953 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/core/rdd/RDD.scala

[GitHub] wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-06 Thread GitBox
wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193322876 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/sql/Dataset.java ##

[GitHub] wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-06 Thread GitBox
wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193324461 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/core/SparkFrontendUtils.

[GitHub] sanha commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-06 Thread GitBox
sanha commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193611278 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/transform/CollectTransfor

[GitHub] sanha commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-06 Thread GitBox
sanha commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193612102 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/sql/Dataset.java ###

[GitHub] sanha commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-06 Thread GitBox
sanha commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193616828 ## File path: examples/spark/src/main/scala/edu/snu/nemo/examples/spark/SparkWordCount.scala ## @@ -0,0

[GitHub] sanha commented on issue #28: [NEMO-12] Frontend support for Scala Spark

2018-06-06 Thread GitBox
sanha commented on issue #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#issuecomment-395280900 @wonook Thanks for your review! I've addressed or answered to your comments.

[GitHub] wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-06 Thread GitBox
wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193639621 ## File path: examples/spark/src/main/scala/edu/snu/nemo/examples/spark/SparkWordCount.scala ## @@ -0,0

[GitHub] wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-07 Thread GitBox
wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193647591 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/core/SparkFrontendUtils.

[GitHub] wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-07 Thread GitBox
wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193647652 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/transform/CollectTransfo

[GitHub] wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-07 Thread GitBox
wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193641579 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/sql/Dataset.java ##

[GitHub] wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-07 Thread GitBox
wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193648153 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/sql/Dataset.java ##

[GitHub] wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark

2018-06-07 Thread GitBox
wonook commented on a change in pull request #28: [NEMO-12] Frontend support for Scala Spark URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193648971 ## File path: compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/sql/Dataset.java ##

<    1   2   3   4   5   6   7   8   9   10   >