Re: [OFBIZ-4959] Logout do not remove autoLogin

2018-02-19 Thread Michael Brohl
+1 We are discussing this over and over again. I wonder what's so difficult to stick to some basic rules of collaboration. Am 19.02.18 um 20:48 schrieb Taher Alkhateeb: Thank you for the work Jacques. I was hoping as stated earlier that you share the work before committing it since it is an

Re: Admin Login not working for Framework Trunk

2018-02-19 Thread Michael Brohl
Hi Sharan, it seems that you have not loaded the seed data. Did you run ./gradle loadAll ? Best regards, Michael Brohl ecomify GmbH www.ecomify.de Am 19.02.18 um 13:43 schrieb Sharan Foga: Hi All Not sure if this is related to any of the discussions happening, but I've just done a

Re: Deprecate properties in favour of SystemProperties

2018-02-18 Thread Michael Brohl
t. With this solution all the problems related to SystemProperties would vanish and most of the related Jira issues could be closed, maybe with some changes like for OFBIZ-7112, anyway the list is below If nobody disagree I'll look at it soon... Jacques Le 17/02/2018 à 12:01, Michael Broh

Re: Deprecate properties in favour of SystemProperties [ was Re: Sending mail from Ofbiz does not work]

2018-02-17 Thread Michael Brohl
ot want to use SystemProperty configurations. So in short: * -1 for file properties deprecation * +1 for consistently implementing SystemProperty reads where applicable/reasonable * additionally make SystemProperty reads configurable, off by default. Regards, Michael Brohl ecomify GmbH www.e

Re: svn commit: r1824294 - in /ofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/facility: facility/CountFacilityInventoryByProduct.groovy facility/ViewFacilityInventoryByProduct.groovy s

2018-02-15 Thread Michael Brohl
Hi Jacques, do you think that it is appropriate to present the user an error message to check the log? Normal users won't have access to the log in a productive environment I guess. The message should contain a qualified information what was wrong. The message is also not translated by UILab

Re: svn commit: r1824260 - in /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control: ExternalLoginKeysManager.java LoginWorker.java

2018-02-15 Thread Michael Brohl
myself to quickly check. I could give this information in the commit log, would it help you? What would you use for action done, improvement? Maybe completed? Jacques Le 14/02/2018 à 20:45, Michael Brohl a écrit : Jacques, please amend the commit message, thank you. Regards, Michael Am

Re: svn commit: r1824260 - in /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control: ExternalLoginKeysManager.java LoginWorker.java

2018-02-14 Thread Michael Brohl
Jacques, please amend the commit message, thank you. Regards, Michael > Am 14.02.2018 um 17:40 schrieb jler...@apache.org: > > Author: jleroux > Date: Wed Feb 14 16:40:19 2018 > New Revision: 1824260 > > URL: http://svn.apache.org/viewvc?rev=1824260&view=rev > Log: > No functional change, remo

Re: svn commit: r1823562 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ExternalLoginKeysManager.java

2018-02-08 Thread Michael Brohl
Hi Jacques, can you please use "Improved:..." for these commit messages? The "No functional change" message permanently requires extra work to sort out when we prepare the blog details. Thank you, Michael Am 08.02.18 um 16:01 schrieb jler...@apache.org: Author: jleroux Date: Thu Feb 8 15

Re: [jira] [Created] (COMDEV-269) GSOC 2018 OFBiz Extend AR/AP to support China accounting regulations

2018-02-07 Thread Michael Brohl
Hi Shi, I think it would be better to first discuss in the OFBiz developers list about the topics we want to address for GoC instead of directly filing them in the comdev Jira. Regards, Michael Am 08.02.18 um 03:49 schrieb Shi Jinghai (JIRA): Shi Jinghai created COMDEV-269: --

Re: [jira] [Created] (COMDEV-270) GSOC 2018 OFBiz Onpage help tool

2018-02-07 Thread Michael Brohl
The same applies to this topic, especially if you want to introduce new technology to the project. Regards, Michael Am 08.02.18 um 08:10 schrieb Shi Jinghai (JIRA): Shi Jinghai created COMDEV-270: -- Summary: GSOC 2018 OFBiz Onpage help tool

Re: [DISCUSSION] The Simple Map Processor Mini-Language

2018-02-07 Thread Michael Brohl
+1 Regards, Michael > Am 07.02.2018 um 10:13 schrieb Taher Alkhateeb : > > I propose a feature freeze on anything related to minilang. Let's just fix > bugs and try to slowly move out. > >> On Feb 7, 2018 11:36 AM, "Rishi Solanki" wrote: >> >> Jacques, >> As far as I remember when you raise

Re: svnUpHotdeploy.sh

2018-02-01 Thread Michael Brohl
+1 Michael Am 01.02.18 um 16:38 schrieb Jacques Le Roux: Hi, I think we should remove the svnUpHotdeploy.sh file from tools I'll do so in 1 week w/o negative opinions Jacques smime.p7s Description: S/MIME Cryptographic Signature

Re: [Proposal] Reducing the clean* operations in gradle

2018-01-31 Thread Michael Brohl
I don't see much benefit in removing those tasks, they provide some flexibility. If we want to reduce them though, I'm in favor of keeping cleanIndexes too. Regards, Michael Am 30.01.18 um 17:54 schrieb Taher Alkhateeb: Hi Jacques, Sure okay, we can keep cleanLogs and cleanFooterFiles. Any

Re: Oracle Java release model changes and consequences for the project

2018-01-31 Thread Michael Brohl
: I see. Hmm, then I'm not sure, but perhaps we have no choice but to go with the short term releases then. On Tue, Jan 30, 2018 at 8:32 PM, Michael Brohl wrote: The problem with LTS is that it is not free. If we stick to LTS, we won't support the users which use the public ver

Re: Oracle Java release model changes and consequences for the project

2018-01-30 Thread Michael Brohl
compatible with the platform we will choose (however, considering that backward compatibility is maintained in new Java releases this is not going to be a major concern). Jacopo On Mon, Jan 29, 2018 at 5:21 PM, Michael Brohl wrote: Hi devs, this is just an initial information and dicus

Re: svn commit: r1777451 - in /ofbiz/trunk: applications/content/src/main/java/org/apache/ofbiz/content/content/ applications/order/src/main/java/org/apache/ofbiz/order/order/ applications/party/src/m

2018-01-30 Thread Michael Brohl
Hi Jacques, this work breaks the proper rendering of html code. In our case, class attributes are stripped from the html content. Example:             src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg" alt="" />                                                           

Oracle Java release model changes and consequences for the project

2018-01-29 Thread Michael Brohl
Hi devs, this is just an initial information and dicussion starter to make everyone aware of this: the Oracle Java release model is changing from a feature based to a time based model [1]. One major drawback is that there will be no more public patch releases for older versions once a new re

Re: [Discussion] documentation framework for OFBiz

2018-01-28 Thread Michael Brohl
January 2018 at 19:53, Michael Brohl wrote: with a small modification: I don't think we'll need a two-folder structure /docs/asciidoc, only /docs should be sufficient, no? Hi Michael, We have streamlined the build system in other places by having folders for the source language: gro

Re: select your pdf document template from organizational party

2018-01-26 Thread Michael Brohl
+1 for the idea and a patch to better understand the solution.Thanks, Michael Am 25.01.18 um 12:13 schrieb Taher Alkhateeb: Hi Nicolas, The concept sounds interesting, but I'm having a bit of difficulty understanding the design from your explanation. Perhaps a JIRA with a PoC patch might help

Re: [Discussion] documentation framework for OFBiz

2018-01-26 Thread Michael Brohl
+1 with a small modification: I don't think we'll need a two-folder structure /docs/asciidoc, only /docs should be sufficient, no? Regards, Michael Am 25.01.18 um 15:00 schrieb Sharan Foga: Hi Taher The picture helps :-) I had to do a bit of a double-take but I get it now and a big +1 I

Re: OFBiz and Google Summer of Code (GsoC) 2018 ?

2018-01-26 Thread Michael Brohl
Hi Sharan, I think a participation in the GsoC is a good idea in general. I'm not sure if the proposed topics are suitable for such a program, especially if the students are not familiar with OFBiz. They need a lot of knowhow and learning before one can be productive and the mentors must spen

Themes: overwrite screen definitions for applications?

2018-01-24 Thread Michael Brohl
Hi Nicolas, all, we are working on a new theme on base of the new common theme mechanism. We have a way to overwrite the common theme's global screens like login, help etc. with new ones inside a theme (which is great!). We now want to improve also the usability of the applications which som

Re: Style tag for Widgets

2018-01-20 Thread Michael Brohl
+1 Inline CSS should be avoided. The HTML code should only contain the standard tags and css class/id attributes to decouple the page structure from the layout. Regards, Michael Am 20.01.18 um 07:23 schrieb Taher Alkhateeb: The widget system as I understand is a DSL for rendering user int

Re: svn commit: r1821226 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java

2018-01-16 Thread Michael Brohl
Hi Jacques, would you mind keeping our message template, it would help us to avoid a lot of unordered entries when we prepare the blog details. Thank you, Michael Am 16.01.18 um 11:25 schrieb jler...@apache.org: Author: jleroux Date: Tue Jan 16 10:25:41 2018 New Revision: 1821226 URL: htt

Re: Gradle cleanAll and eclipse tasks

2018-01-16 Thread Michael Brohl
Yes, you have to run "gradlew cleanAll eclipse ... " to regenerate the eclipse file. You'll get used to it after a while... Am 16.01.18 um 10:46 schrieb Jacques Le Roux: But then it's regenerated, right? Because, if I'm not wrong, the only trouble I have in Eclipse, and need to run the ecli

Re: svn commit: r1820848 - in /ofbiz/tools: documentation/BuildBot/BuildBot.md wiki-files/BuildBot/BuildBot.md.html

2018-01-11 Thread Michael Brohl
Interesting, ummhh, "log message"... Am 11.01.18 um 10:19 schrieb jler...@apache.org: Author: jleroux Date: Thu Jan 11 09:19:26 2018 New Revision: 1820848 URL: http://svn.apache.org/viewvc?rev=1820848&view=rev Log: Implemented: Improved: Documented: Completed: Reverted: Fixed: (OFBIZ-) Explana

Re: svn commit: r1820671 - in /ofbiz/tools: documentation/BuildBot/BuildBot.md wiki-files/BuildBot/BuildBot.md.html

2018-01-11 Thread Michael Brohl
Thank you, Jacques. Regards, Michael Am 11.01.18 um 10:19 schrieb Jacques Le Roux: OK OK, done :-D Thanks for your collaboration Jacques Le 11/01/2018 à 09:50, Michael Brohl a écrit : I think the (valid) point is that documentation should be written in a neutral form and not from a

Re: svn commit: r1820671 - in /ofbiz/tools: documentation/BuildBot/BuildBot.md wiki-files/BuildBot/BuildBot.md.html

2018-01-11 Thread Michael Brohl
I think the (valid) point is that documentation should be written in a neutral form and not from a personal perspective. They should also not express personal opinions by single persons. If we want to express opinions at all, they should be officially decided by the community explicitly. It f

Re: [jira] [Commented] (OFBIZ-8230) Disentangle platform specific entity engine schemas

2018-01-08 Thread Michael Brohl
+1 Michael Am 08.01.18 um 01:36 schrieb Scott Gray: I'm in favor of the status quo. It's useful to have them available out of the box to be able to pick the one you need and proceed without having to look elsewhere. The same goes for the fieldtype definitions. Regards Scott On 8/01/2018 6:26

Re: [ANNOUNCE] Apache OFBiz 16.11.04 released

2018-01-07 Thread Michael Brohl
Hi Jacopo, a little late but thank you for putting together the new release and thanks to all who contributed! Best regards, Michael Am 03.01.18 um 18:12 schrieb Jacopo Cappellato: The Apache OFBiz community is pleased to announce the new release "Apache OFBiz 16.11.04". Apache OFBiz® is an

Re: github and git repo still behind subversion

2018-01-07 Thread Michael Brohl
BTW, do we have documentation somewhere which explains who is responsible for these services, how they work, where to lokk what's wrong and who to inform if there are issues? To me this is not clear for some of the services (like publishing the website, fisheye, GitHub sync, ...) , but I admit

Re: [jira] [Commented] (OFBIZ-8230) Disentangle platform specific entity engine schemas

2018-01-07 Thread Michael Brohl
Hi everyone, please have a look at the issue mentioned below and express your opionion if we should remove the different schema configurations from the main entityengine.xml or if we should keep them. Thanks, Michael Am 07.01.18 um 11:23 schrieb Pierre Smits (JIRA): [ https://issues

Re: Proposal to remove the "Special Notice" section from the OFBiz download page

2018-01-05 Thread Michael Brohl
+1 I think we should also change the headline "Apache OFBiz 13.07 and earlier" to "Earlier Releases" or similar, so that we do not have to maintain this section when the releases change. Regards, Michael Am 05.01.18 um 11:02 schrieb Jacopo Cappellato: Hi all, I think we should now remove

Re: Variables created from properties should not be final

2018-01-05 Thread Michael Brohl
Hi Jacques, inline.. Am 05.01.18 um 08:31 schrieb Jacques Le Roux: Hi, We have roughly 3514 variables created from properties, either from properties files or from DB values. Among them 53 are declared final, this does not make sense to me. It might make sense depending on the business log

Re: svn commit: r1819730 [1/6] - in /ofbiz/ofbiz-framework/trunk/applications: content/src/main/java/org/apache/ofbiz/content/ content/src/main/java/org/apache/ofbiz/content/compdoc/ content/src/main/

2017-12-31 Thread Michael Brohl
I have not the time to look at this further now but some changes seem to change the business logic, e.g. by returning an "error" result in events where they did not before, same in services. It makes a difference in both the controller logic as well as in the service engine logic. This seems n

Re: Use getCombinedMap instead of getParameter

2017-12-29 Thread Michael Brohl
Hi Suraj, I think we should use different ways of getting parameters, attributes etc. depending on what is needed in the business logic. For example, if you only want to use request parameters in an event and don't need the overriding mechanism, using UtilHttp.getCombinedMap is unnecessary o

Re: Planning for the creation of the new 17.xx branch(es)

2017-12-28 Thread Michael Brohl
Regarding the website: 1. do we keep the 16.11 listed there as the stable release branch and add 17.12? 2. the repository path for 16.11 is wrong on the current website Regards, Michael Am 28.12.17 um 12:11 schrieb Jacopo Cappellato: We have now the release branches: https://svn.apache.o

Re: Planning for the creation of the new 17.xx branch(es)

2017-12-28 Thread Michael Brohl
Great, thank you, Jacopo! Regards, Michael Am 28.12.17 um 12:11 schrieb Jacopo Cappellato: We have now the release branches: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12/ https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12/ Please revie

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.04

2017-12-28 Thread Michael Brohl
Hi Jacques, you could simply use our verification script (verify-ofbiz-release.sh) in tools... it follows the process mentioned in the link ;-) Regards, Michael Am 28.12.17 um 10:44 schrieb Jacques Le Roux: MD5, tests and few UI interactions OK BTW what about http://markmail.org/message/ag

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.04

2017-12-24 Thread Michael Brohl
: Korrekte Signatur von "Jacopo Cappellato (CODE SIGNING KEY) " [uneingeschränkt] Build test: $ ./gradlew cleanAll loadDefault testIntegration ... BUILD SUCCESSFUL Thank you very much for the Christmas present Regards, Michael Brohl ecomify GmbH www.ecomify.de Am 24.12.17 um 10:

Re: Are we ready to publish a new release (16.11.04)?

2017-12-20 Thread Michael Brohl
Hi Jacques, are these bugs fixed in trunk and not just not backported? Else we should go on with a new release and backport once they are fixed in trunk. What makes you think that this would be the last 16.11 release? Regards, Michael Am 20.12.17 um 09:11 schrieb Jacques Le Roux: Hi Jaco

Re: Are we ready to publish a new release (16.11.04)?

2017-12-19 Thread Michael Brohl
+1 Thanks, Michael Am 19.12.17 um 16:43 schrieb Jacopo Cappellato: Hi all, we have published our last release mostly 6 months ago and since then we have merged several bug fixes to our 16.11 branch: I think it is time to publish a new one! If there are no objections I am going to prepare th

Re: Planning for the creation of the new 17.xx branch(es)

2017-12-19 Thread Michael Brohl
Your proposition is OK with me Jacques what are your opinions (please look at the Jiras and ML I don't want to rehash all here)? Also "I have" ideas for 2018, based on ideas from 2014, but that's another topic :) Thanks Jacques Le 18/12/2017 à 16:19, Michael Brohl a écrit

Re: Bootstrap 4 vs. 3, was: svn commit: r1818637 - in /ofbiz/ofbiz-plugins/trunk/ecommerce/template/customer: MessageDetail.ftl MessageList.ftl NewMsg.ftl

2017-12-19 Thread Michael Brohl
<http://www.hotwaxsystems.com/> On Tue, Dec 19, 2017 at 1:54 PM, Michael Brohl wrote: Hi Deepak, do we really want to make a switch to Bootsrap 4 now?? When I see it right, it is still in beta and it breaks existing Bootstrap 3 based UI because of some changes which are not backwards compatible. I think we

Bootstrap 4 vs. 3, was: svn commit: r1818637 - in /ofbiz/ofbiz-plugins/trunk/ecommerce/template/customer: MessageDetail.ftl MessageList.ftl NewMsg.ftl

2017-12-19 Thread Michael Brohl
Hi Deepak, do we really want to make a switch to Bootsrap 4 now?? When I see it right, it is still in beta and it breaks existing Bootstrap 3 based UI because of some changes which are not backwards compatible. I think we should make a decision about this move. I'd propose to wait for the f

Re: GitHub repository updates

2017-12-18 Thread Michael Brohl
wrote: Hi Michael, In such case we need to ask infra for a nudge Thanks Jacques Le 17/12/2017 à 22:51, Michael Brohl a écrit : Hi, how is the GitHub repository (https://github.com/apache/ofbiz-framework) updated? It shows the last commit is 27 days ago, seems a little bit outdated... R

Re: svn commit: r1818580 - in /ofbiz/ofbiz-framework/trunk: framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/ themes/common/webapp/common/js/jquery/plugins/jquery-jgrowl/ themes/co

2017-12-18 Thread Michael Brohl
Jacques, please check this commit, you have committed the Tomcat SSO stuff. The codebase cannot be compiled. Thanks, Michael Am 18.12.17 um 15:48 schrieb jler...@apache.org: Author: jleroux Date: Mon Dec 18 14:48:04 2017 New Revision: 1818580 URL: http://svn.apache.org/viewvc?rev=1818580&

Re: Planning for the creation of the new 17.xx branch(es)

2017-12-18 Thread Michael Brohl
Hi Jacopo, all, I've just finished committing all those FindBugs and refactoring issues so no more show stoppers from my side to create the next release branch :-) Thanks, Michael Am 28.11.17 um 17:03 schrieb Michael Brohl: Hi Jacopo, I am planning to do a bunch of FindBugs/refact

GitHub repository updates

2017-12-17 Thread Michael Brohl
Hi, how is the GitHub repository (https://github.com/apache/ofbiz-framework) updated? It shows the last commit is 27 days ago, seems a little bit outdated... Regards, Michael smime.p7s Description: S/MIME Cryptographic Signature

Re: buildbot failure in on ofbiz-trunk-framework-plugins

2017-12-17 Thread Michael Brohl
With so much hassle using buildbot, would it be possible to set up another build server like Jenkins? We use it here at ecomify and have none of these issues with OFBiz. Regards, Michael Am 17.12.17 um 21:06 schrieb Jacques Le Roux: Ah also, normally Buildbot should only send email when the

Re: svn commit: r1818007 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string: FlexibleStringExpander.java JuelConnector.java UelFunctions.java UelUtil.java

2017-12-17 Thread Michael Brohl
works ! Cheers, Nicolas Le 17/12/2017 à 19:10, Michael Brohl a écrit : Hi Nicolas, thanks for reporting! I guess that this is the reason why there was no logging at all. At r1818498 I added verbose logging. Thanks, Michael Am 17.12.17 um 18:00 schrieb Nicolas Malin: Hello Michael, Le 13

Re: svn commit: r1815119 - /ofbiz/ofbiz-framework/trunk/framework/start/src/main/java/org/apache/ofbiz/base/start/StartupControlPanel.java

2017-12-17 Thread Michael Brohl
Hi Jacques, if I see it right, you have not implemented a try-with-resources block but simply moved the stream declaration inside the try block and removed the finally block. Please check. Thanks, Michael Am 13.11.17 um 18:06 schrieb jler...@apache.org: Author: jleroux Date: Mon Nov 13 17

Re: svn commit: r1818007 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string: FlexibleStringExpander.java JuelConnector.java UelFunctions.java UelUtil.java

2017-12-17 Thread Michael Brohl
Hi Nicolas, thanks for reporting! I guess that this is the reason why there was no logging at all. At r1818498 I added verbose logging. Thanks, Michael Am 17.12.17 um 18:00 schrieb Nicolas Malin: Hello Michael, Le 13/12/2017 à 14:03, mbr...@apache.org a écrit : --- ofbiz/ofbiz-framework

Re: svn commit: r1818093 - /ofbiz/ofbiz-framework/trunk/README.md

2017-12-14 Thread Michael Brohl
I suggest to create an FAQ or "known issues" section in our wiki and have a section in the README.md like "further reading" or "additional infos" etc. which contain the links. Regards, Michael Am 14.12.17 um 09:12 schrieb Jacques Le Roux: I wonder, we had already at least 2 persons crossing

Re: Please add me as an Apache OFBiz Contributor

2017-12-12 Thread Michael Brohl
41683> Chief Executive Officer: Martin Becker, Michael Brohl> smime.p7s Description: S/MIME Cryptographic Signature

Re: Removal of trailing white spaces, was: Re: [jira] [Commented] (OFBIZ-9777) [FB] Package org.apache.ofbiz.product.imagemanagement

2017-12-12 Thread Michael Brohl
Am 12.12.17 um 14:38 schrieb Jacques Le Roux: I catch up to Jacques's comment, I prefer to separate the formating to the functional even if I was do the same in the past and I will do it by oversight in the future :) This was what David taught us and I found it reasonable Yes, and that's exac

Re: Removal of trailing white spaces, was: Re: [jira] [Commented] (OFBIZ-9777) [FB] Package org.apache.ofbiz.product.imagemanagement

2017-12-12 Thread Michael Brohl
Am 12.12.17 um 11:48 schrieb Jacques Le Roux: This is a bit out of subject, but while at it: As you can see at [3] I'm not against  removing trailing spaces. But experience told me one thing since. One of the most important things in version control is what happened  to a line, because you wil

Re: Removal of trailing white spaces, was: Re: [jira] [Commented] (OFBIZ-9777) [FB] Package org.apache.ofbiz.product.imagemanagement

2017-12-12 Thread Michael Brohl
g/message/lbwz5puicmaleb7s [2] https://en.wikipedia.org/wiki/List_of_tools_for_code_review [3] http://markmail.org/message/ir7cs2ofbzbzc53a Le 12/12/2017 à 10:27, Michael Brohl a écrit : Hi Jacques, I propose to do it the other way around: when reviewing diffs, you can configure the IDE to ignore t

Removal of trailing white spaces, was: Re: [jira] [Commented] (OFBIZ-9777) [FB] Package org.apache.ofbiz.product.imagemanagement

2017-12-12 Thread Michael Brohl
ents: product Affects Versions: Trunk Reporter: Julian Leichert Assignee: Michael Brohl Priority: Minor Fix For: Upcoming Release Attachments: OFBIZ-9777_org.apache.ofbiz.product.imagemanagement_bugfixes.patch smime.p7s Descriptio

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

2017-12-11 Thread Michael Brohl
mmits  (IIRW only in r1817748 and r1817750) Notably beware of "if (debug) {" in r1817748. Jacques Le 11/12/2017 à 12:39, Michael Brohl a écrit : Thanks, Taher! :-) Am 11.12.17 um 11:50 schrieb Taher Alkhateeb: On a side note to Michael kudos on the massive bug hunting effort late

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

2017-12-11 Thread Michael Brohl
Thanks, Taher! :-) Am 11.12.17 um 11:50 schrieb Taher Alkhateeb: On a side note to Michael kudos on the massive bug hunting effort lately. On Dec 11, 2017 1:33 PM, "Michael Brohl" wrote: I will see how I can handle this effectively without doing all my review work twice. There

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

2017-12-11 Thread Michael Brohl
hanks Jacques Le 11/12/2017 à 10:21, Michael Brohl a écrit : These are good points, I wasn't aware of this and just saw the (in my view) unnecessary extra lines of code. I will check my latest commits and change this back where it is reasonable (i.e. where we have concatenations).

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

2017-12-11 Thread Michael Brohl
These are good points, I wasn't aware of this and just saw the (in my view) unnecessary extra lines of code. I will check my latest commits and change this back where it is reasonable (i.e. where we have concatenations). Luckily, I just started this this morning and not during the heavier co

Re: [jira] [Commented] (OFBIZ-10032) Move the hhfacility application to Attic

2017-12-02 Thread Michael Brohl
Just a copy to dev to gain attention. I think such a move should be discussed here first. Thanks, Michael Am 02.12.17 um 11:24 schrieb Michael Brohl (JIRA): [ https://issues.apache.org/jira/browse/OFBIZ-10032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel

Re: OFBiz Version Info

2017-11-28 Thread Michael Brohl
-1 for storing the version in .properties. +1 for using a VERSION or RELEASE file in the root folder to store this information. It's easily accessible, you cannot overlook it and the content can be read by any functionality. It can also be automatically set by (custom) builds to be generated

Re: Planning for the creation of the new 17.xx branch(es)

2017-11-28 Thread Michael Brohl
Hi Jacopo, I am planning to do a bunch of FindBugs/refactoring commits in the coming days/weeks, hopefully all of the currently open issues. It would be great if we can move the release to December. @all: any help on the FindBugs/refactoring issues by fellow committers are greatly appreciate

Re: [Proposal] Extend facility entity

2017-11-25 Thread Michael Brohl
+1 for a timetable entity and linking it to facility This will give us much more flexibility and avoids adding more and more fields to the facility table. Thanks, Michael Am 25.11.17 um 11:39 schrieb Jacques Le Roux: Hi Vaibhav, That sounds reasonable to me. I notably like this feature wh

Re: Fwd: ISO Notifications

2017-11-24 Thread Michael Brohl
Hi Jacques, I think it is enough to report that there are changes from time to time or file an issue for it. If someone is interested in getting these notifications, he may subscribe himself to this newsletter. Thanks and regards, Michael Am 24.11.17 um 15:29 schrieb Jacques Le Roux: Hi

Re: [PROPOSAL] Environment variable configuration

2017-11-17 Thread Michael Brohl
493a@1213087551@%3Cdev.ofbiz.apache.org%3E Am 03.11.17 um 11:39 schrieb Jacques Le Roux: That's quite interesting Michael, Would you share in a Jira? Then we could get to merge all experiences and find a consensu. Jacques Le 03/11/2017 à 10:10, Michael Brohl a écrit : Just an upd

Re: Unable to Launch 16.11.x in Isolation

2017-11-17 Thread Michael Brohl
done :-) Am 14.11.17 um 17:15 schrieb Michael Brohl: Reminder to self: update the (great) README.md for this switch :-) Regards, Michael Am 14.11.17 um 16:33 schrieb Taher Alkhateeb: ./gradlew --offline This question is perhaps better suited for the user mailing list. On Nov 14, 2017 6

Coordinating the work on mini lang to groovy conversion

2017-11-17 Thread Michael Brohl
Hi devs, there seems to me more action in this task recently, which is great! To prevent working on the same services from different sides I strongly recommend to file a Jira BEFORE starting the work. What do you think? (will copy this to the umbrella issue also). Regards, Michael smi

Re: Service returning incorrect records

2017-11-15 Thread Michael Brohl
We already have 3 people in favor of removing, please take this into consideration. Thanks, Michael Am 15.11.17 um 11:23 schrieb Jacques Le Roux: Hi Pawan, Scott, We crossed on wire. I have already renamed the services. I think they can be useful in some situations. I see no reasons to rem

Re: Service returning incorrect records

2017-11-14 Thread Michael Brohl
Am 14.11.17 um 19:15 schrieb Jacques Le Roux: I see no reasons to drop those services if some find them useful. I get they do since someone wrote it, even with a misleading name. Not having them used OOTB is not a sufficient indication of removal. I do not agree. This functionality is not use

Re: Unable to Launch 16.11.x in Isolation

2017-11-14 Thread Michael Brohl
Reminder to self: update the (great) README.md for this switch :-) Regards, Michael Am 14.11.17 um 16:33 schrieb Taher Alkhateeb: ./gradlew --offline This question is perhaps better suited for the user mailing list. On Nov 14, 2017 6:21 PM, "Craig Parker" wrote: You're on a deserted isla

Re: Service returning incorrect records

2017-11-14 Thread Michael Brohl
Hi Suraj, this service seems not to be used anywhere in the system and the code looks... ämm..., strange. I'd propose to remove it from the codebase along with other resources like the UI labels referenced there (if not used anywhere else). I think it is worth to have a deeper look at the w

Re: svn commit: r1814402 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ExternalLoginKeysManager.java

2017-11-06 Thread Michael Brohl
Hi Jacques, this is the same solution pattern as we've discussed in [1]. I think we should discuss this general pattern for both cases. I will wait for other opinions in [1] and do my follow-up later. Thanks, Michael [1] https://lists.apache.org/thread.html/71a9b1d73246655753ef71abf9cdf530

Re: svn commit: r1814349 - in /ofbiz/ofbiz-framework/trunk: applications/securityext/src/main/java/org/apache/ofbiz/securityext/login/L oginEvents.java framework/security/config/security.properties

2017-11-05 Thread Michael Brohl
variables https://stackoverflow.com/questions/13991100/where-do-you- store-your-secret-key-in-a-java-web-application But it's up to you of course, if you are still OK to use this way I'm totally OK to revert it Jacques Le 05/11/2017 à 15:10, Michael Brohl a écrit : Hi Jacques, why d

Re: svn commit: r1814349 - in /ofbiz/ofbiz-framework/trunk: applications/securityext/src/main/java/org/apache/ofbiz/securityext/login/LoginEvents.java framework/security/config/security.properties

2017-11-05 Thread Michael Brohl
Hi Jacques, why don't we just discuss such changes before they got implemented? I don't think it is a valid solution to change the key in a versioned class file during compile time, that's a really strange proposal. The configuration through the properties was fine, every responsible person

Re: [PROPOSAL] Environment variable configuration

2017-11-03 Thread Michael Brohl
@%3Cdev.ofbiz.apache.org%3E Am 05.07.17 um 17:56 schrieb Michael Brohl: Hi Gil, we have similar challenges and modified OFBiz to deal with it easily. We offered to contribute this long time ago (2008) but it was decided against [1]. It was suggested to use patches instead but I think it's

Re: Properties "Y" or "true": confusing :/

2017-11-01 Thread Michael Brohl
Hi Jacques, as long as we are still able to uses Y/N and you just want to change the load data values it's ok for me (also not one of the things I would put high priority on). Regards, Michael Am 01.11.17 um 12:15 schrieb Jacques Le Roux: Hi, OOTB we have boolean properties with "Y" or "

Re: svn commit: r1813627 - /ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml

2017-10-30 Thread Michael Brohl
Hi Arun, thanks for your work. You could help us save some time by sticking to the commit message template. Please see my previous message to Rishi. In this case, the correct message would be formatted: === Fixed: Issue while creating new person in the party component. (OFBIZ-9653) Thanks

Re: svn commit: r1813726 - in /ofbiz/ofbiz-framework/trunk/applications: content/data/ party/data/ securityext/data/ workeffort/data/

2017-10-30 Thread Michael Brohl
Hi Rishi, thanks for your contributions! Can you please do me a favor and stick to the commit message template (see https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template)? In case of the last commits, it would be "Improved" instead of "Improvement" and "(OFBIZ-

Re: Using OFBiz as an Online Store for ASF Swag ?

2017-10-29 Thread Michael Brohl
could be a good starting point for a central platform for merchandising and more. Happy to help if I can. Best regards, Michael Brohl ecomify GmbH www.ecomify.de Am 29.10.17 um 17:18 schrieb Sharan Foga: Hi All I've had some initial positive feedback on this so I'd like to

Re: svn commit: r1813637 - in /ofbiz/ofbiz-framework/trunk/framework/datafile/src/main/java/org/apache/of biz/datafile: DataFile.java DataFile2EntityXml.java ModelDataFileReader.java Record.java Recor

2017-10-29 Thread Michael Brohl
-idea-code-formatting-rules-to-eclipse Maybe ultimately using CheckStyle as suggested? I remember being rebuffed a decade abo when I suggested to use Findbugs... I'm not strongly opinionated about that, but when I think about external mergings... Jacques Le 29/10/2017 à 10:53, Michael Br

Re: svn commit: r1813637 - in /ofbiz/ofbiz-framework/trunk/framework/datafile/src/main/java/org/apache/of biz/datafile: DataFile.java DataFile2EntityXml.java ModelDataFileReader.java Record.java Recor

2017-10-29 Thread Michael Brohl
Same thing as before. This is just produced by the formatter. Am 29.10.17 um 09:15 schrieb Jacques Le Roux: Le 28/10/2017 à 16:45, mbr...@apache.org a écrit : -    protected DataFile() {} +    protected DataFile() { +    } Hi Michael, Do we really prefer "this to that" ? Jacques smim

Re: svn commit: r1813637 - in /ofbiz/ofbiz-framework/trunk/framework/datafile/src/main/java/org/apache/of biz/datafile: DataFile.java DataFile2EntityXml.java ModelDataFileReader.java Record.java Recor

2017-10-29 Thread Michael Brohl
Same thing as before... Am 29.10.17 um 09:56 schrieb Jacques Le Roux: Le 28/10/2017 à 16:45, mbr...@apache.org a écrit :   /**    * little endian reader for 4 byte int.    */ -    public final int readLEInt(byte []byteArray) { -    return -    (byteArray[3])  << 24 | -    (byteA

Re: svn commit: r1813637 - in /ofbiz/ofbiz-framework/trunk/framework/datafile/src/main/java/org/apache/of biz/datafile: DataFile.java DataFile2EntityXml.java ModelDataFileReader.java Record.java Recor

2017-10-29 Thread Michael Brohl
I think this is just a formatting change becaused I used our formatter for Eclipse. Not really something worth a discussion, is it? Am 29.10.17 um 10:07 schrieb Jacques Le Roux: Le 28/10/2017 à 16:45, mbr...@apache.org a écrit : -    for (int i = 0; i < modelField.length; i++) - 

Re: svn commit: r1719660 - in /ofbiz/trunk/framework/webapp: config/requestHandler.properties dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHa

2017-10-24 Thread Michael Brohl
Hi Jacques, how can I configure a view so that no x-frame-options header is set? While it is great to have these security options and also have a secure default, there are cases where you might want to switch this header settings off. Thanks and regards, Michael Am 12.12.15 um 12:37 schri

Deprecation of XMLSerializer

2017-10-22 Thread Michael Brohl
Hi everyone, during my code review for the FindBugs work I saw this Javadoc notice about XMLSerializer being deprecated, but there is no @deprecated annotation: /**  * XmlSerializer class. This class is deprecated - new code should use the  * Java object marshalling/unmarshalling methods in

Re: [Discussion] documentation framework for OFBiz

2017-10-17 Thread Michael Brohl
Big +1 for this initiative! I have not much to add to Taher's proposal and Sharan's viewpoint. I assume that we can use any Asciidoc editor and need not to use Asciidoctor? I think we have to decide what we will do with our Wiki based documentation then. If we have up-to-date documentation i

Re: Change default Theme to Rainbow Saphir

2017-10-16 Thread Michael Brohl
+1 regards, Michael Am 16.10.17 um 14:56 schrieb Jacques Le Roux: Le 09/10/2017 à 14:16, Jacques Le Roux a écrit : Hi, I see that more and more the Rainbow theme is used in our demos. I guess it's because It has 2 advantages: 1. Being initially based on Flat Grey it handles RTL languages (

Re: [Proposal] Add a Redis plugin to codebase (OFBIZ-9829)

2017-10-16 Thread Michael Brohl
community first, and if enough people show interest and approval then we include the code. On Thu, Oct 12, 2017 at 1:11 PM, Michael Brohl wrote: Hi Jinghai, first of all thanks for your contribution. I appreciate your work, even if I do not agree with the process (see Jira issue). So please un

Re: svn commit: r1812225 - in /ofbiz/ofbiz-framework/trunk: applications/accounting/groovyScripts/agreement/ applications/content/template/survey/ applications/marketing/servicedef/ applications/produ

2017-10-15 Thread Michael Brohl
Hi Jacques, please check this, there are strange words in the first license header... Regards, Michael Am 15.10.17 um 19:41 schrieb jler...@apache.org: Author: jleroux Date: Sun Oct 15 17:40:59 2017 New Revision: 1812225 URL: http://svn.apache.org/viewvc?rev=1812225&view=rev Log: No function

Re: svn commit: r1811699 - /ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofb iz/service/config/model/ThreadPool.java

2017-10-12 Thread Michael Brohl
think? Jacques Le 12/10/2017 à 13:03, Michael Brohl a écrit : Hi Jacques, as you said, it's just a default and the value can be configured through "max-threads". I would leave it as is. Regards, Michael Am 11.10.17 um 07:58 schrieb Jacques Le Roux: MAX_THREADS = 5

Re: svn commit: r1811699 - /ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofb iz/service/config/model/ThreadPool.java

2017-10-12 Thread Michael Brohl
Hi Jacques, as you said, it's just a default and the value can be configured through "max-threads". I would leave it as is. Regards, Michael Am 11.10.17 um 07:58 schrieb Jacques Le Roux: MAX_THREADS = 5 smime.p7s Description: S/MIME Cryptographic Signature

Re: CodeNarc Gradle plugin

2017-10-12 Thread Michael Brohl
Hi Jacques, just stumbled over this while searching for a way to analyze Groovy code in OFBiz. Can you tell us what the problem was? Thanks, Michael Am 18.09.17 um 13:12 schrieb Jacques Le Roux: Hi, I wanted to test the CodeNarc Gradle plugin https://docs.gradle.org/current/userguide/co

Re: FindBugs for Groovy?

2017-10-12 Thread Michael Brohl
59 PM, "Michael Brohl" wrote: Hi all, we are heavily doing code analysis with FindBugs and made progress with the Java packages, see [1]. We have decided to convert mini lang to Groovy files and it seems that people start writing new services using the Groovy DSL. I see one drawback tha

Re: [Proposal] Add a Redis plugin to codebase (OFBIZ-9829)

2017-10-12 Thread Michael Brohl
Hi Jinghai, first of all thanks for your contribution. I appreciate your work, even if I do not agree with the process (see Jira issue). So please understand my critical questions as an attempt to assure a good process and quality for the project and not a refusal of your work or this plugin

FindBugs for Groovy?

2017-10-12 Thread Michael Brohl
Hi all, we are heavily doing code analysis with FindBugs and made progress with the Java packages, see [1]. We have decided to convert mini lang to Groovy files and it seems that people start writing new services using the Groovy DSL. I see one drawback that we cannot use static code analysi

Re: Tracking Data Model changes

2017-10-11 Thread Michael Brohl
+1 for tracking datamodel changes together with data migration scripts In our customer projects, we track every change in a simple text file in the source code repository. It contains description of the changes, references to issues or requirement documentation and SQL scripts for migrations.

<    1   2   3   4   5   6   7   8   9   10   >