Re: Review Request 70502: OOZIE-3265 properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to appear together

2019-07-17 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70502/ --- (Updated July 17, 2019, 11:47 a.m.) Review request for oozie and Andras

Re: Review Request 70502: OOZIE-3265 properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to appear together

2019-07-17 Thread Kinga Marton via Review Board
> On July 16, 2019, 8:44 a.m., Andras Salamon wrote: > > docs/src/site/markdown/DG_WorkflowReRun.md > > Lines 27-28 (original), 29-30 (patched) > > > > > > What is wfId? Probably the id after -rerun but it's not

Re: Review Request 70502: OOZIE-3265 properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to appear together

2019-07-15 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70502/ --- (Updated July 15, 2019, 12:14 p.m.) Review request for oozie and Andras

Re: Review Request 70964: OOZIE-3513 Migrate from Preconditions.checkNotNull and ParamChecker.notNull

2019-07-01 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70964/#review216267 --- Ship it! Ship It! - Kinga Marton On June 28, 2019, 8:57

Re: Review Request 70964: OOZIE-3513 Migrate from Preconditions.checkNotNull and ParamChecker.notNull

2019-06-27 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70964/#review216184 --- core/src/main/java/org/apache/oozie/util/ConfigUtils.java Lines

Re: Review Request 70762: OOZIE-3499 [Java 11] Fix TestLiteWorkflowAppParser

2019-05-31 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70762/ --- (Updated May 31, 2019, 12:30 p.m.) Review request for oozie and Andras

Re: Review Request 70762: OOZIE-3499 [Java 11] Fix TestLiteWorkflowAppParser

2019-05-31 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70762/ --- (Updated May 31, 2019, 11:28 a.m.) Review request for oozie and Andras

Review Request 70762: OOZIE-3499 [Java 11] Fix TestLiteWorkflowAppParser

2019-05-30 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70762/ --- Review request for oozie and Andras Salamon. Repository: oozie-git

Re: Review Request 70502: OOZIE-3265 properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to appear together

2019-04-26 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70502/ --- (Updated April 26, 2019, 2:47 p.m.) Review request for oozie and Andras

Review Request 70502: OOZIE-3265 properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to appear together

2019-04-18 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70502/ --- Review request for oozie and Andras Salamon. Repository: oozie-git

Re: Review Request 70155: OOZIE-3312 Add support for HSTS

2019-03-08 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70155/ --- (Updated March 8, 2019, 1:42 p.m.) Review request for oozie and Andras

Re: Review Request 70155: OOZIE-3312 Add support for HSTS

2019-03-08 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70155/ --- (Updated March 8, 2019, 10:02 a.m.) Review request for oozie and Andras

Re: Review Request 70072: Reduce warnings thrown while building

2019-03-01 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70072/#review213332 --- Ship it! Ship It! - Kinga Marton On March 1, 2019, 1:55

Re: Review Request 70072: Reduce warnings thrown while building

2019-02-28 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70072/#review213305 ---

Re: Review Request 69783: OOZIE-3409 - Oozie Server : Memory leak in EL evaluation

2019-02-28 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69783/#review213298 --- Ship it! Ship It! - Kinga Marton On Feb. 19, 2019, 4:24

Re: Review Request 69988: OOZIE-3395 Findbugs is no longer maintained

2019-02-22 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69988/ --- (Updated Feb. 22, 2019, 8:30 a.m.) Review request for oozie and Andras

Re: Review Request 69988: OOZIE-3395 Findbugs is no longer maintained

2019-02-20 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69988/ --- (Updated Feb. 20, 2019, 5:47 p.m.) Review request for oozie and Andras

Re: Review Request 69988: OOZIE-3395 Findbugs is no longer maintained

2019-02-20 Thread Kinga Marton via Review Board
> On Feb. 15, 2019, 10:02 a.m., Andras Salamon wrote: > > bin/test-patch-11-findbugs-diff > > Line 1 (original), 1 (patched) > > > > > > Can you please check the script with shellcheck I have left a few warnings,

Re: Review Request 69988: OOZIE-3395 Findbugs is no longer maintained

2019-02-20 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69988/ --- (Updated Feb. 20, 2019, 2:20 p.m.) Review request for oozie and Andras

Re: Review Request 69783: OOZIE-3409 - Oozie Server : Memory leak in EL evaluation

2019-02-11 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69783/#review212604 ---

Re: Review Request 69668: OOZIE 2949 - Escape quotes whitespaces in Sqoop field

2019-01-31 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69668/#review212494 --- Ship it! Ship It! - Kinga Marton On Jan. 30, 2019, 2:45

Re: Review Request 69668: OOZIE 2949 - Escape quotes whitespaces in Sqoop field

2019-01-29 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69668/#review212411 ---

Re: Review Request 69829: OOZIE 3243 - Flaky test TestCoordActionsKillXCommand#testActionKillCommandDate

2019-01-24 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69829/#review212274 --- Ship it! Ship It! - Kinga Marton On Jan. 24, 2019, 12:46

Re: Review Request 69771: OOZIE-3417 [FS Action] Optimize code about the command about chose fs action

2019-01-17 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69771/ --- (Updated Jan. 17, 2019, 8:03 a.m.) Review request for oozie and Andras

Review Request 69771: OOZIE-3417 [FS Action] Optimize code about the command about chose fs action

2019-01-16 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69771/ --- Review request for oozie and Andras Salamon. Repository: oozie-git

Re: Review Request 69668: OOZIE 2949 - Escape quotes whitespaces in Sqoop field

2019-01-07 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69668/#review211723 ---

Re: Review Request 69492: OOZIE-3389 Getting input dependency list on the UI throws NPE

2018-12-01 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69492/#review210999 --- Ship it! Ship It! - Kinga Marton On Dec. 1, 2018, 2:21

Re: Review Request 69437: OOZIE-3384 - [tests] TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky

2018-11-28 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69437/#review210923 --- Ship it! Ship It! - Kinga Marton On Nov. 28, 2018, 9:03

Re: Review Request 69437: OOZIE-3384 - [tests] TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky

2018-11-28 Thread Kinga Marton via Review Board
> On Nov. 28, 2018, 8:28 a.m., Kinga Marton wrote: > > core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java > > Lines 22 (patched) > > > > > > nit: unused iport *import - Kinga

Re: Review Request 69437: OOZIE-3384 - [tests] TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky

2018-11-28 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69437/#review210919 ---

Re: Review Request 69348: OOZIE-3381 [coordinator] Enhance logging of CoordElFunctions

2018-11-22 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69348/#review210789 --- Ship it! Ship It! - Kinga Marton On Nov. 20, 2018, 10:54

Re: Review Request 69348: OOZIE-3381 [coordinator] Enhance logging of CoordElFunctions

2018-11-15 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69348/#review210567 --- core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java

Re: Review Request 69298: OOZIE-3380 TestCoordMaterializeTransitionXCommand failure after DST change date

2018-11-12 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69298/#review210472 --- Ship it! Ship It! - Kinga Marton On Nov. 12, 2018, 2:03

Re: Review Request 69298: OOZIE-3380 TestCoordMaterializeTransitionXCommand failure after DST change date

2018-11-12 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69298/#review210465 ---

Re: Review Request 68628: OOZIE-2734 - Switch docs from twiki to markdown

2018-09-13 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68628/#review208586 --- docs/src/site/twiki/DG_CommandLineTool.twiki Line 265

Re: Review Request 68628: OOZIE-2734 - Switch docs from twiki to markdown

2018-09-12 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68628/#review208557 --- docs/src/site/twiki/AG_Install.twiki Line 768 (original), 797

Re: Review Request 68628: OOZIE-2734 - Switch docs from twiki to markdown

2018-09-11 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68628/#review208513 --- docs/src/site/twiki/BundleFunctionalSpec.twiki Line 39

Re: Review Request 68628: OOZIE-2734 - Switch docs from twiki to markdown

2018-09-11 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68628/#review208508 --- docs/src/site/twiki/WebServicesAPI.twiki Lines 583-586

Re: Review Request 68628: OOZIE-2734 - Switch docs from twiki to markdown

2018-09-10 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68628/#review208485 --- Checked pages: ENG_MiniOozie.html ENG_Custom_Authentication.html

Re: Review Request 68517: OOZIE 3210 - revision information is empty

2018-08-27 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68517/#review207980 --- Ship it! Ship It! - Kinga Marton On Aug. 27, 2018, 2:45

Re: Review Request 68517: OOZIE 3210 - revision information is empty

2018-08-27 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68517/#review207968 --- bin/create-release-artifact Lines 60-69 (patched)

Re: Review Request 68467: OOZIE-2684 Bad database schema error for WF_ACTIONS table

2018-08-27 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68467/ --- (Updated Aug. 27, 2018, 11:35 a.m.) Review request for oozie, András Piros and

Re: Review Request 68467: OOZIE-2684 Bad database schema error for WF_ACTIONS table

2018-08-24 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68467/ --- (Updated Aug. 24, 2018, 1:36 p.m.) Review request for oozie, András Piros and

Review Request 68467: OOZIE-2684 Bad database schema error for WF_ACTIONS table

2018-08-22 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68467/ --- Review request for oozie, András Piros and Andras Salamon. Bugs: OOZIE-2684

Re: Review Request 68180: OOZIE-3315 Datelist Java Main example fails

2018-08-03 Thread Kinga Marton via Review Board
> On Aug. 3, 2018, 8 a.m., Kinga Marton wrote: > > examples/src/main/java/org/apache/oozie/example/DateList.java > > Line 21 (original), 21 (patched) > > > > > > Please revove * import *remove :) - Kinga

Re: Review Request 68180: OOZIE-3315 Datelist Java Main example fails

2018-08-03 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68180/#review206837 --- examples/src/main/java/org/apache/oozie/example/DateList.java

Re: Review Request 68102: OOZIE-3193 Applications are not killed when submitted via subworkflow

2018-08-01 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68102/ --- (Updated Aug. 1, 2018, 1:44 p.m.) Review request for oozie, András Piros and

Re: Review Request 68102: OOZIE-3193 Applications are not killed when submitted via subworkflow

2018-08-01 Thread Kinga Marton via Review Board
> On July 30, 2018, 10:46 a.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java > > Lines 60-61 (patched) > > > > > > Isn't emitting another message also just

Re: Review Request 68102: OOZIE-3193 Applications are not killed when submitted via subworkflow

2018-08-01 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68102/ --- (Updated Aug. 1, 2018, 9:59 a.m.) Review request for oozie, András Piros and

Review Request 68102: OOZIE-3193 Applications are not killed when submitted via subworkflow

2018-07-30 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68102/ --- Review request for oozie, András Piros and Peter Cseh. Repository: oozie-git

Re: Review Request 67834: OOZIE-2829 Improve sharelib upload to accept multiple source folders

2018-07-25 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67834/ --- (Updated July 25, 2018, 8:48 a.m.) Review request for oozie, András Piros,

Re: Review Request 67834: OOZIE-2829 Improve sharelib upload to accept multiple source folders

2018-07-22 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67834/ --- (Updated July 22, 2018, 4 p.m.) Review request for oozie, András Piros, Peter

Re: Review Request 67834: OOZIE-2829 Improve sharelib upload to accept multiple source folders

2018-07-22 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67834/ --- (Updated July 22, 2018, 1:22 p.m.) Review request for oozie, András Piros,

Review Request 68008: OOZIE-2942 [examples] Fix Findbugs warnings

2018-07-22 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68008/ --- Review request for oozie, András Piros and Peter Cseh. Repository: oozie-git

Re: Review Request 67834: OOZIE-2829 Improve sharelib upload to accept multiple source folders

2018-07-22 Thread Kinga Marton via Review Board
> On July 6, 2018, 1:40 p.m., András Piros wrote: > > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java > > Lines 88 (patched) > > > > > > Problem is we can have ```hdfs://my/jar.jar#myjar.jar```

Re: Review Request 67834: OOZIE-2829 Improve sharelib upload to accept multiple source folders

2018-07-20 Thread Kinga Marton via Review Board
> On July 6, 2018, 1:40 p.m., András Piros wrote: > > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java > > Lines 88 (patched) > > > > > > Problem is we can have ```hdfs://my/jar.jar#myjar.jar```

Re: Review Request 67834: OOZIE-2829 Improve sharelib upload to accept multiple source folders

2018-07-19 Thread Kinga Marton via Review Board
> On July 6, 2018, 1:40 p.m., András Piros wrote: > > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java > > Lines 88 (patched) > > > > > > Problem is we can have ```hdfs://my/jar.jar#myjar.jar```

Re: Review Request 67834: OOZIE-2829 Improve sharelib upload to accept multiple source folders

2018-07-08 Thread Kinga Marton via Review Board
> On July 6, 2018, 1:40 p.m., András Piros wrote: > > tools/src/test/java/org/apache/oozie/tools/OozieSharelibFileOperations.java > > Lines 42-48 (original), 43-51 (patched) > > > > > > Could be extracted to a nested

Re: Review Request 67834: OOZIE-2829 Improve sharelib upload to accept multiple source folders

2018-07-08 Thread Kinga Marton via Review Board
> On July 6, 2018, 1:40 p.m., András Piros wrote: > > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java > > Lines 282-294 (patched) > > > > > > A log message about how parallel we are running would be

Re: Review Request 67834: OOZIE-2829 Improve sharelib upload to accept multiple source folders

2018-07-06 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67834/ --- (Updated July 6, 2018, 8:36 a.m.) Review request for oozie, András Piros,

Review Request 67834: OOZIE-2829 Improve sharelib upload to accept multiple source folders

2018-07-05 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67834/ --- Review request for oozie, András Piros, Peter Cseh, and Peter Bacsko.

Re: Review Request 66930: OOZIE-2791 ShareLib installation may fail on busy Hadoop clusters

2018-07-03 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66930/ --- (Updated July 3, 2018, 3:24 p.m.) Review request for oozie, András Piros and

Re: Review Request 66930: OOZIE-2791 ShareLib installation may fail on busy Hadoop clusters

2018-07-03 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66930/ --- (Updated July 3, 2018, 8:12 a.m.) Review request for oozie, András Piros and

Re: Review Request 66930: OOZIE-2791 ShareLib installation may fail on busy Hadoop clusters

2018-07-03 Thread Kinga Marton via Review Board
> On July 2, 2018, 2:01 p.m., Peter Bacsko wrote: > > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java > > Lines 256-259 (patched) > > > > > > To me this looks weird. The class is named

Re: Review Request 67766: OOZIE-2955 Fix Findbugs warnings related to reliance on default encoding in oozie-client

2018-07-02 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67766/ --- (Updated July 2, 2018, 8:06 a.m.) Review request for oozie and András Piros.

Re: Review Request 67763: OOZIE-2956 Fix Findbugs warnings related to reliance on default encoding in oozie-core

2018-07-01 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67763/ --- (Updated July 1, 2018, 10:47 a.m.) Review request for oozie and András Piros.

Re: Review Request 67766: OOZIE-2955 Fix Findbugs warnings related to reliance on default encoding in oozie-client

2018-07-01 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67766/ --- (Updated July 1, 2018, 10:19 a.m.) Review request for oozie and András Piros.

Re: Review Request 67766: OOZIE-2955 Fix Findbugs warnings related to reliance on default encoding in oozie-client

2018-07-01 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67766/ --- (Updated July 1, 2018, 10:02 a.m.) Review request for oozie and András Piros.

Re: Review Request 67766: OOZIE-2955 Fix Findbugs warnings related to reliance on default encoding in oozie-client

2018-06-28 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67766/ --- (Updated June 28, 2018, 8:58 a.m.) Review request for oozie and András Piros.

Review Request 67766: OOZIE-2955 Fix Findbugs warnings related to reliance on default encoding in oozie-client

2018-06-28 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67766/ --- Review request for oozie and András Piros. Repository: oozie-git Description

Review Request 67763: OOZIE-2956 Fix Findbugs warnings related to reliance on default encoding in oozie-core

2018-06-27 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67763/ --- Review request for oozie and András Piros. Repository: oozie-git Description

Re: Review Request 66930: OOZIE-2791 ShareLib installation may fail on busy Hadoop clusters

2018-06-18 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66930/ --- (Updated June 18, 2018, 10:03 a.m.) Review request for oozie, András Piros and

Re: Review Request 66930: OOZIE-2791 ShareLib installation may fail on busy Hadoop clusters

2018-06-06 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66930/ --- (Updated June 6, 2018, 12:34 p.m.) Review request for oozie, András Piros and

Re: Review Request 66930: OOZIE-2791 ShareLib installation may fail on busy Hadoop clusters

2018-06-05 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66930/ --- (Updated June 5, 2018, 8:37 a.m.) Review request for oozie, András Piros and

Re: Review Request 66930: OOZIE-2791 ShareLib installation may fail on busy Hadoop clusters

2018-06-04 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66930/ --- (Updated June 4, 2018, 1:55 p.m.) Review request for oozie, András Piros and

Re: Review Request 66930: OOZIE-2791 ShareLib installation may fail on busy Hadoop clusters

2018-05-10 Thread Kinga Marton via Review Board
> On May 3, 2018, 3:33 p.m., András Piros wrote: > > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java > > Lines 224-235 (patched) > > > > > > Please extract to another `static final class`, and add

Re: Review Request 66930: OOZIE-2791 ShareLib installation may fail on busy Hadoop clusters

2018-05-10 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66930/ --- (Updated May 10, 2018, 7:59 a.m.) Review request for oozie, András Piros and

Review Request 66930: OOZIE-2791 ShareLib installation may fail on busy Hadoop clusters

2018-05-03 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66930/ --- Review request for oozie, András Piros and Peter Cseh. Repository: oozie-git

Re: Review Request 65481: OOZIE-3134 - Potential inconsistency between the in-memory SLA map and the Oozie database

2018-03-23 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65481/ --- (Updated March 23, 2018, 7:28 a.m.) Review request for oozie, András Piros and

Re: Review Request 65481: OOZIE-3134 - Potential inconsistency between the in-memory SLA map and the Oozie database

2018-03-22 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65481/ --- (Updated March 22, 2018, 4:44 p.m.) Review request for oozie, András Piros and

Re: Review Request 65481: OOZIE-3134 - Potential inconsistency between the in-memory SLA map and the Oozie database

2018-02-19 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65481/ --- (Updated Feb. 19, 2018, 2:14 p.m.) Review request for oozie, András Piros and

Re: Review Request 65481: OOZIE-3134 - Potential inconsistency between the in-memory SLA map and the Oozie database

2018-02-13 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65481/ --- (Updated Feb. 13, 2018, 3:19 p.m.) Review request for oozie, András Piros and

Re: Review Request 65481: OOZIE-3134 - Potential inconsistency between the in-memory SLA map and the Oozie database

2018-02-13 Thread Kinga Marton via Review Board
> On Feb. 6, 2018, 4:15 p.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/util/db/ThreadVariables.java > > Lines 23-37 (patched) > > > > > > I don't see calling `setDbPredicate()` or

Re: Review Request 65481: OOZIE-3134 - Potential inconsistency between the in-memory SLA map and the Oozie database

2018-02-06 Thread Kinga Marton via Review Board
> On Feb. 2, 2018, 2:09 p.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/util/db/FailingHSQLDBDriverWrapper.java > > Lines 36-39 (patched) > > > > > > Usage of System#getProperty(String, String)

Re: Review Request 65481: OOZIE-3134 - Potential inconsistency between the in-memory SLA map and the Oozie database

2018-02-06 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65481/ --- (Updated Feb. 6, 2018, 2:43 p.m.) Review request for oozie, András Piros and

Review Request 65481: OOZIE-3134 - Potential inconsistency between the in-memory SLA map and the Oozie database

2018-02-02 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65481/ --- Review request for oozie, András Piros and Attila Sasvari. Repository:

***UNCHECKED*** Re: Review Request 65287: OOZIE-3157 - Setup truststore so that it also works in HTTP only mode

2018-01-26 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65287/ --- (Updated Jan. 26, 2018, 1:16 p.m.) Review request for oozie, András Piros,

Re: Review Request 65287: OOZIE-3157 - Setup truststore so that it also works in HTTP only mode

2018-01-26 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65287/ --- (Updated Jan. 26, 2018, 1:13 p.m.) Review request for oozie, András Piros,

Re: Review Request 65287: OOZIE-3157 - Setup truststore so that it also works in HTTP only mode

2018-01-26 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65287/ --- (Updated Jan. 26, 2018, noon) Review request for oozie, András Piros, Attila

Re: Review Request 65287: OOZIE-3157 - Setup truststore so that it also works in HTTP only mode

2018-01-24 Thread Kinga Marton via Review Board
> On Jan. 24, 2018, 1:54 p.m., Attila Sasvari wrote: > > server/src/main/java/org/apache/oozie/server/EmbeddedOozieServer.java > > Lines 169 (patched) > > > > > > What happens if a truststore password starts/ends

Re: Review Request 65287: OOZIE-3157 - Setup truststore so that it also works in HTTP only mode

2018-01-24 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65287/ --- (Updated Jan. 24, 2018, 3:53 p.m.) Review request for oozie, András Piros,

Re: Review Request 65287: OOZIE-3157 - Setup truststore so that it also works in HTTP only mode

2018-01-24 Thread Kinga Marton via Review Board
> On Jan. 23, 2018, 3:17 p.m., Attila Sasvari wrote: > > Please update documentation and mention truststore related things: it might > > be needed even for scenarios without HTTPS (if Oozie needs to talk with > > servers with self-signed certificates), config properties can be overriden > >

Re: Review Request 65287: OOZIE-3157 - Setup truststore so that it also works in HTTP only mode

2018-01-24 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65287/ --- (Updated Jan. 24, 2018, 12:19 p.m.) Review request for oozie, András Piros,

Re: Review Request 65287: OOZIE-3157 - Setup truststore so that it also works in HTTP only mode

2018-01-24 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65287/ --- (Updated Jan. 24, 2018, 12:17 p.m.) Review request for oozie, András Piros,

Review Request 65287: OOZIE-3157 - Setup truststore so that it also works in HTTP only mode

2018-01-23 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65287/ --- Review request for oozie, András Piros, Attila Sasvari, and Peter Cseh.

Re: Review Request 65177: >git status< should be clean after >mvn test< was called

2018-01-18 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65177/ --- (Updated Jan. 18, 2018, 11:35 a.m.) Review request for oozie, András Piros,

Review Request 65177: >git status< should be clean after >mvn test< was called

2018-01-16 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65177/ --- Review request for oozie, András Piros, Attila Sasvari, and Peter Cseh.

Re: Review Request 64808: OOZIE-3085 - Improve logging in ActionExecutors

2018-01-11 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64808/ --- (Updated Jan. 11, 2018, 4:02 p.m.) Review request for oozie and Attila

Re: Review Request 64808: OOZIE-3085 - Improve logging in ActionExecutors

2018-01-11 Thread Kinga Marton via Review Board
> On Dec. 28, 2017, 11:44 a.m., Attila Sasvari wrote: > > core/src/main/java/org/apache/oozie/action/control/ControlNodeActionExecutor.java > > Lines 52 (patched) > > > > > > What does ``getId()`` return for a

Re: Review Request 64808: OOZIE-3085 - Improve logging in ActionExecutors

2018-01-11 Thread Kinga Marton via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64808/ --- (Updated Jan. 11, 2018, 4:02 p.m.) Review request for oozie and Attila

  1   2   >