[GitHub] phoenix pull request: PHOENIX-852 Optimize child/parent foreign ke...

2014-08-18 Thread maryannxue
GitHub user maryannxue opened a pull request: https://github.com/apache/phoenix/pull/7 PHOENIX-852 Optimize child/parent foreign key joins You can merge this pull request into a Git repository by running: $ git pull https://github.com/maryannxue/phoenix master Alternatively

[GitHub] phoenix pull request: Phoenix-1580 union all impl

2015-03-05 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/39#discussion_r25923422 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java --- @@ -147,21 +169,146 @@ public QueryCompiler(PhoenixStatement

[GitHub] phoenix pull request: Phoenix-1580 union all impl

2015-03-05 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/39#discussion_r25924080 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java --- @@ -147,21 +169,146 @@ public QueryCompiler(PhoenixStatement

[GitHub] phoenix pull request: Phoenix-1580 union all impl

2015-03-05 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/39#discussion_r25924146 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java --- @@ -147,21 +169,146 @@ public QueryCompiler(PhoenixStatement

[GitHub] phoenix pull request: PHOENIX-2257 Fix broken integration test for...

2015-10-23 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/120#discussion_r42860245 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/DerivedTableIT.java --- @@ -313,21 +290,25 @@ public void testDerivedTableWithGroupBy

[GitHub] phoenix pull request: PHOENIX-2257 Fix broken integration test for...

2015-10-23 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/120#discussion_r42859436 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/DerivedTableIT.java --- @@ -313,21 +290,25 @@ public void testDerivedTableWithGroupBy

[GitHub] phoenix pull request: Phoenix-2405

2016-05-31 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/171#discussion_r65294053 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/BufferSegmentQueue.java --- @@ -0,0 +1,251 @@ +package org.apache.phoenix.iterate

[GitHub] phoenix pull request: Phoenix-2405

2016-05-31 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/171#discussion_r65293343 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/DeferredByteBufferSegmentQueue.java --- @@ -0,0 +1,123 @@ +package

[GitHub] phoenix pull request: Phoenix-2405

2016-05-31 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/171#discussion_r65293136 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/DeferredByteBufferSegmentQueue.java --- @@ -0,0 +1,123 @@ +package

[GitHub] phoenix pull request: Phoenix-2405

2016-05-31 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/171#discussion_r65294376 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/DeferredByteBufferSegmentQueue.java --- @@ -0,0 +1,123 @@ +package

[GitHub] phoenix pull request: Phoenix-2405

2016-05-31 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/171#discussion_r65293621 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/DeferredByteBufferSegmentQueue.java --- @@ -0,0 +1,123 @@ +package

[GitHub] phoenix pull request: Phoenix-2405

2016-05-31 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/171#discussion_r65294499 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java --- @@ -572,11 +569,11 @@ public MappedByteBufferTupleQueue(int

[GitHub] phoenix pull request: Phoenix-2405

2016-05-31 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/171#discussion_r65291859 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/ScanRegionObserver.java --- @@ -234,6 +234,12 @@ protected RegionScanner

[GitHub] phoenix pull request: PHOENIX-2722 support mysql limit,offset clau...

2016-03-30 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/154#discussion_r57993968 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/execute/CorrelatePlanTest.java --- @@ -172,17 +172,38 @@ public void

[GitHub] phoenix pull request: PHOENIX-2722 support mysql limit,offset clau...

2016-03-30 Thread maryannxue
Github user maryannxue commented on the pull request: https://github.com/apache/phoenix/pull/154#issuecomment-203722854 @ankitsinghal Some (maybe final) comments added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] phoenix pull request: PHOENIX-2722 support mysql limit,offset clau...

2016-03-30 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/154#discussion_r57993856 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/DerivedTableIT.java --- @@ -241,7 +241,7 @@ public void testDerivedTableWithWhere() throws

[GitHub] phoenix pull request: PHOENIX-2722 support mysql limit,offset clau...

2016-03-23 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/154#discussion_r57269271 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/SubselectRewriter.java --- @@ -202,14 +204,30 @@ private SelectStatement flatten

[GitHub] phoenix pull request: PHOENIX-2722 support mysql limit,offset clau...

2016-03-23 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/154#discussion_r57269833 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java --- @@ -324,10 +328,13 @@ protected QueryPlan compileJoinQuery

[GitHub] phoenix pull request: PHOENIX-2722 support mysql limit,offset clau...

2016-03-23 Thread maryannxue
Github user maryannxue commented on the pull request: https://github.com/apache/phoenix/pull/154#issuecomment-200637757 @ankitsinghal Thank you very much for the pull request! I am impressed by how many details you have taken into account in your commit. It took me quite a while

[GitHub] phoenix pull request: PHOENIX-2722 support mysql limit,offset clau...

2016-03-28 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/154#discussion_r57664500 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/LiteralResultIterationPlan.java --- @@ -85,6 +85,9 @@ public void close() throws

[GitHub] phoenix pull request: PHOENIX-2722 support mysql limit,offset clau...

2016-03-28 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/154#discussion_r57663883 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/DerivedTableIT.java --- @@ -233,6 +233,34 @@ public void testDerivedTableWithWhere() throws

[GitHub] phoenix pull request: PHOENIX-2722 support mysql limit,offset clau...

2016-03-28 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/154#discussion_r57664292 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/ScanPlan.java --- @@ -193,21 +194,32 @@ protected ResultIterator newIterator

[GitHub] phoenix pull request: PHOENIX-2722 support mysql limit,offset clau...

2016-03-28 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/154#discussion_r57663830 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryWithLimitIT.java --- @@ -20,6 +20,7 @@ package org.apache.phoenix.end2end

[GitHub] phoenix pull request: PHOENIX-2722 support mysql limit,offset clau...

2016-03-28 Thread maryannxue
Github user maryannxue commented on the pull request: https://github.com/apache/phoenix/pull/154#issuecomment-202671194 @ankitsinghal Thank you very much for making the suggested changes! Added a few more suggestions, most of them being minor. --- If your project is set up

[GitHub] phoenix pull request: PHOENIX-2722 support mysql limit,offset clau...

2016-04-04 Thread maryannxue
Github user maryannxue commented on the pull request: https://github.com/apache/phoenix/pull/154#issuecomment-205461513 Hi @ankitsinghal, sorry about the delay. I don't get github notification in mailbox... It looks good to me now. Thank you for all the work! @JamesRTaylor What do

[GitHub] phoenix pull request #175: PHOENIX-2405 Not for merge, just request a review...

2016-07-05 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/175#discussion_r69668752 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java --- @@ -45,10 +45,7 @@ import

[GitHub] phoenix pull request #175: PHOENIX-2405 Not for merge, just request a review...

2016-07-05 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/175#discussion_r69668052 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/SpoolingByteBufferSegmentQueue.java --- @@ -0,0 +1,357 @@ +/* + * Licensed

[GitHub] phoenix pull request #175: PHOENIX-2405 Not for merge, just request a review...

2016-07-05 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/175#discussion_r69668023 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/SpoolingByteBufferSegmentQueue.java --- @@ -0,0 +1,357 @@ +/* + * Licensed

[GitHub] phoenix pull request #175: PHOENIX-2405 Not for merge, just request a review...

2016-07-05 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/175#discussion_r69668528 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/AggregatePlan.java --- @@ -133,7 +134,10 @@ public PeekingResultIterator newIterator

[GitHub] phoenix pull request #175: PHOENIX-2405 Not for merge, just request a review...

2016-07-05 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/175#discussion_r69667743 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/SpoolingByteBufferSegmentQueue.java --- @@ -0,0 +1,357 @@ +/* + * Licensed

[GitHub] phoenix pull request #212: PHOENIX-3264 Allow TRUE and FALSE to be used as l...

2016-09-29 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/212#discussion_r81200946 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java --- @@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call

[GitHub] phoenix pull request #212: PHOENIX-3264 Allow TRUE and FALSE to be used as l...

2016-09-29 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/212#discussion_r81202889 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java --- @@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call

[GitHub] phoenix pull request #212: PHOENIX-3264 Allow TRUE and FALSE to be used as l...

2016-09-29 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/212#discussion_r81202299 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java --- @@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call

[GitHub] phoenix pull request #212: PHOENIX-3264 Allow TRUE and FALSE to be used as l...

2016-09-29 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/212#discussion_r81203125 --- Diff: phoenix-core/src/main/java/org/apache/calcite/sql/SqlOptionNode.java --- @@ -38,12 +41,10 @@ public SqlOptionNode(SqlParserPos pos

[GitHub] phoenix pull request #212: PHOENIX-3264 Allow TRUE and FALSE to be used as l...

2016-09-29 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/212#discussion_r81200246 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java --- @@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call

[GitHub] phoenix pull request #212: PHOENIX-3264 Allow TRUE and FALSE to be used as l...

2016-09-29 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/212#discussion_r81201327 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java --- @@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call

[GitHub] phoenix pull request #212: PHOENIX-3264 Allow TRUE and FALSE to be used as l...

2016-09-29 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/212#discussion_r81210515 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java --- @@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call

[GitHub] phoenix pull request #212: PHOENIX-3264 Allow TRUE and FALSE to be used as l...

2016-09-29 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/212#discussion_r81212867 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java --- @@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call

[GitHub] phoenix pull request #212: PHOENIX-3264 Allow TRUE and FALSE to be used as l...

2016-09-29 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/212#discussion_r81214035 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java --- @@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call

[GitHub] phoenix pull request #212: PHOENIX-3264 Allow TRUE and FALSE to be used as l...

2016-09-29 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/212#discussion_r81211365 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java --- @@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call

[GitHub] phoenix pull request #212: PHOENIX-3264 Allow TRUE and FALSE to be used as l...

2016-09-29 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/212#discussion_r81201783 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java --- @@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call

[GitHub] phoenix pull request #214: PHOENIX-3298 Single column primary key may not be...

2016-10-06 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/214#discussion_r82285685 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java --- @@ -1453,7 +1453,7 @@ public void testInvalidPrimaryKeyDecl

[GitHub] phoenix issue #214: PHOENIX-3298 Single column primary key may not be null

2016-10-06 Thread maryannxue
Github user maryannxue commented on the issue: https://github.com/apache/phoenix/pull/214 Sure. I'll do that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] phoenix pull request #213: PHOENIX-2827 Support OFFSET in Calcite-Phoenix

2016-09-30 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/213#discussion_r81418958 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/rel/PhoenixLimit.java --- @@ -76,20 +76,27 @@ public RelOptCost computeSelfCost

[GitHub] phoenix pull request #213: PHOENIX-2827 Support OFFSET in Calcite-Phoenix

2016-09-30 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/213#discussion_r81419366 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/rel/PhoenixLimit.java --- @@ -76,20 +76,27 @@ public RelOptCost computeSelfCost

[GitHub] phoenix pull request #213: PHOENIX-2827 Support OFFSET in Calcite-Phoenix

2016-09-30 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/213#discussion_r81419580 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/rel/PhoenixLimit.java --- @@ -76,20 +76,27 @@ public RelOptCost computeSelfCost

[GitHub] phoenix pull request #213: PHOENIX-2827 Support OFFSET in Calcite-Phoenix

2016-09-30 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/213#discussion_r81420342 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/ClientScanPlan.java --- @@ -106,12 +106,18 @@ public ExplainPlan getExplainPlan() throws

[GitHub] phoenix pull request #213: PHOENIX-2827 Support OFFSET in Calcite-Phoenix

2016-09-30 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/213#discussion_r81430086 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/ClientScanPlan.java --- @@ -106,12 +106,18 @@ public ExplainPlan getExplainPlan() throws

[GitHub] phoenix pull request #215: PHOENIX-3345 SQLException code's not propagating ...

2016-10-10 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/215#discussion_r82686793 --- Diff: phoenix-core/src/main/java/org/apache/calcite/jdbc/PhoenixCalciteFactory.java --- @@ -161,6 +162,29 @@ public Object apply

[GitHub] phoenix pull request #222: PHOENIX-3355 Register Phoenix built-in functions ...

2016-11-10 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/222#discussion_r87515224 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/parse/ParseNodeFactory.java --- @@ -181,6 +184,11 @@ public static BuiltInFunctionInfo get(String

[GitHub] phoenix pull request #222: PHOENIX-3355 Register Phoenix built-in functions ...

2016-11-10 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/222#discussion_r87512533 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/parse/PFunction.java --- @@ -18,14 +18,18 @@ package org.apache.phoenix.parse; --- End

[GitHub] phoenix pull request #222: PHOENIX-3355 Register Phoenix built-in functions ...

2016-11-10 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/222#discussion_r87512188 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/PhoenixScalarFunction.java --- @@ -90,6 +153,10 @@ public PFunction getFunctionInfo

[GitHub] phoenix pull request #222: PHOENIX-3355 Register Phoenix built-in functions ...

2016-11-10 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/222#discussion_r87515184 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/parse/ParseNodeFactory.java --- @@ -127,6 +129,7 @@ private static void addBuiltInFunction(Class

[GitHub] phoenix pull request #222: PHOENIX-3355 Register Phoenix built-in functions ...

2016-11-10 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/222#discussion_r87512477 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/parse/FunctionParseNode.java --- @@ -30,6 +30,7 @@ import java.util.List; --- End diff

[GitHub] phoenix pull request #220: PHOENIX-3394 Handle SequenceResolving through Con...

2016-11-02 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/220#discussion_r86287165 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/PhoenixSchema.java --- @@ -329,24 +333,14 @@ private TableRef fixTableMultiTenancy

[GitHub] phoenix pull request #220: PHOENIX-3394 Handle SequenceResolving through Con...

2016-11-02 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/220#discussion_r86287255 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/calcite/CalciteIT.java --- @@ -1315,6 +1315,17 @@ public void initTable() throws Exception

[GitHub] phoenix pull request #215: PHOENIX-3345 SQLException code's not propagating ...

2016-10-11 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/215#discussion_r82879380 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java --- @@ -1115,4 +1115,15 @@ public static Object convertSqlLiteral

[GitHub] phoenix pull request #223: PHOENIX-3488 Support COUNT(DISTINCT x) in Phoenix...

2016-11-29 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/223#discussion_r90119141 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/rules/PhoenixConverterRules.java --- @@ -899,9 +899,6 @@ public static boolean

[GitHub] phoenix pull request #224: PHOENIX-3477 Support sequence arithmetic in Calci...

2016-12-06 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/224#discussion_r91155610 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/rel/PhoenixClientProject.java --- @@ -73,13 +70,10 @@ public QueryPlan implement

[GitHub] phoenix pull request #224: PHOENIX-3477 Support sequence arithmetic in Calci...

2016-12-06 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/224#discussion_r91152331 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/calcite/CalciteIT.java --- @@ -1343,6 +1343,28 @@ public void initTable() throws Exception

[GitHub] phoenix pull request #224: PHOENIX-3477 Support sequence arithmetic in Calci...

2016-12-06 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/224#discussion_r91152478 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java --- @@ -1115,6 +1099,11 @@ public Void visitCall(RexCall call

[GitHub] phoenix pull request #224: PHOENIX-3477 Support sequence arithmetic in Calci...

2016-12-06 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/224#discussion_r91163250 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/calcite/CalciteIT.java --- @@ -1343,6 +1343,28 @@ public void initTable() throws Exception

[GitHub] phoenix issue #222: PHOENIX-3355 Register Phoenix built-in functions as Calc...

2016-12-01 Thread maryannxue
Github user maryannxue commented on the issue: https://github.com/apache/phoenix/pull/222 No differentiation between the regex functions (String based and Byte based) -- Let's just add support for this one? Invert and MD5 Function don't work (phoenix doesn't supply the correct

[GitHub] phoenix issue #222: PHOENIX-3355 Register Phoenix built-in functions as Calc...

2016-12-01 Thread maryannxue
Github user maryannxue commented on the issue: https://github.com/apache/phoenix/pull/222 2. We'll leave it then. I think the future solution can be either 1) add as built-in funcs in Calcite; or 2) add type derivation mechanism for UDFs in Calcite. 3. See "getAdjuste

[GitHub] phoenix pull request #228: PHOENIX-3355 Register Phoenix built-in functions ...

2016-12-20 Thread maryannxue
GitHub user maryannxue opened a pull request: https://github.com/apache/phoenix/pull/228 PHOENIX-3355 Register Phoenix built-in functions as Calcite functions You can merge this pull request into a Git repository by running: $ git pull https://github.com/maryannxue/phoenix

[GitHub] phoenix pull request #7: PHOENIX-852 Optimize child/parent foreign key joins

2016-12-27 Thread maryannxue
Github user maryannxue closed the pull request at: https://github.com/apache/phoenix/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] phoenix issue #281: PHOENIX-4288 Indexes not used when ordering by primary k...

2017-11-15 Thread maryannxue
Github user maryannxue commented on the issue: https://github.com/apache/phoenix/pull/281 Thank you for the review, @JamesRTaylor! These are very good comments. I'll update the PR accordingly. ---

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-27 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r153404439 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/CostBasedDecisionIT.java --- @@ -0,0 +1,176 @@ +package org.apache.phoenix.end2end

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-17 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151829519 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java --- @@ -91,8 +91,23 @@ public QueryPlan optimize(PhoenixStatement

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-16 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/281#discussion_r151580119 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java --- @@ -91,8 +91,23 @@ public QueryPlan optimize(PhoenixStatement

[GitHub] phoenix issue #281: PHOENIX-4288 Indexes not used when ordering by primary k...

2017-11-16 Thread maryannxue
Github user maryannxue commented on the issue: https://github.com/apache/phoenix/pull/281 @JamesRTaylor, I made all the changes suggested in your comments except one: "need more test cases" Thought I'd naturally go down this path as I start to tackle other issues under PH

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2017-11-07 Thread maryannxue
GitHub user maryannxue opened a pull request: https://github.com/apache/phoenix/pull/281 PHOENIX-4288 Indexes not used when ordering by primary key 1. Add class Cost. 2. Add method getCost() in QueryPlan. 3. Let QueryOptimizer choose the best plan based on Cost; meanwhile

[GitHub] phoenix pull request #278: PHOENIX-4322 DESC primary key column with variabl...

2017-10-25 Thread maryannxue
GitHub user maryannxue opened a pull request: https://github.com/apache/phoenix/pull/278 PHOENIX-4322 DESC primary key column with variable length does not work in SkipScanFilter Changes: Avoid adding an extra trailing separator to the key You can merge this pull request

[GitHub] phoenix pull request #301: PHOENIX-4728 The upsert select must project tuple...

2018-05-23 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/301#discussion_r190428434 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java --- @@ -549,7 +549,7 @@ public MutationPlan compile(UpsertStatement

[GitHub] phoenix pull request #281: PHOENIX-4288 Indexes not used when ordering by pr...

2018-07-27 Thread maryannxue
Github user maryannxue closed the pull request at: https://github.com/apache/phoenix/pull/281 ---

[GitHub] phoenix pull request #278: PHOENIX-4322 DESC primary key column with variabl...

2018-07-27 Thread maryannxue
Github user maryannxue closed the pull request at: https://github.com/apache/phoenix/pull/278 ---

[GitHub] phoenix pull request #228: PHOENIX-3355 Register Phoenix built-in functions ...

2018-07-27 Thread maryannxue
Github user maryannxue closed the pull request at: https://github.com/apache/phoenix/pull/228 ---

[GitHub] phoenix pull request #314: PHOENIX-4820

2018-07-30 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/314#discussion_r206377190 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java --- @@ -559,8 +559,16 @@ protected QueryPlan compileSingleFlatQuery

[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

2018-04-20 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/298#discussion_r183133375 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java --- @@ -314,7 +314,8 @@ protected QueryPlan compileJoinQuery

[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

2018-04-20 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/298#discussion_r183135634 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/HashJoinPlan.java --- @@ -488,11 +502,20 @@ public ServerCache execute(HashJoinPlan

[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

2018-04-20 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/298#discussion_r183128592 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/cache/TenantCacheImpl.java --- @@ -77,57 +153,164 @@ public MemoryManager getMemoryManager

[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

2018-04-20 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/298#discussion_r183133702 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java --- @@ -383,7 +384,7 @@ protected QueryPlan compileJoinQuery

[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

2018-04-20 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/298#discussion_r183136068 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/memory/GlobalMemoryManager.java --- @@ -159,6 +161,10 @@ protected void finalize() throws

[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

2018-04-20 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/298#discussion_r183127442 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/cache/ServerCacheClient.java --- @@ -216,22 +234,146 @@ public void close() throws SQLException

[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

2018-04-20 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/298#discussion_r183130270 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/cache/TenantCacheImpl.java --- @@ -77,57 +153,164 @@ public MemoryManager getMemoryManager

[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

2018-04-20 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/298#discussion_r183128249 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/cache/TenantCacheImpl.java --- @@ -77,57 +153,164 @@ public MemoryManager getMemoryManager

[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

2018-04-20 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/298#discussion_r183126183 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/join/HashJoinPersistentCacheIT.java --- @@ -0,0 +1,94 @@ +/* + * Licensed