Hi
+1 (binding)
I checked;
- signatures and hashes are fine
- LICENSE and NOTICE are good
- No unexpected binary files
- Source files have ASF headers
- Can compile from source
I also checked the download page links and all good.
I think the README ned to be updated re versions of java you
Hi,
I’ve nt taken a deep look at this but EPL licensed code isn’t allowed in a
source release. [1]
Thanks,
Justin
1. https://www.apache.org/legal/resolved.html#weak-copyleft-licenses
+1 a much better description of that branch
Hi,
Looks fine to me.
Thanks,
Justin
Hi,
+1 (binding)
I checked:
- signatures and hashes are fine
- LICENSE and NOTICE are good
- All source files have ASF headers
- No unexpected binary files
- Can compile from source
Thanks,
Justin
HI,
> It would really make sense to have this documented somewhere where everyone
> can read it.
I believe it on trademarks list to do.
Thanks,
Justin
Hi,
> But the text in the link actually says you have to be consistent ... not that
> all links have to be no-follow.
You need to rad elsewhere - see also this [1]
Justin
1.
Hi,
> Can you point to that policy?
See [1] also see recent conversation re shardingshpere and trademarks/branding.
Thanks,
Justin
1. https://www.apache.org/foundation/marks/linking#projectthanks
HI,
> [1] https://github.com/apache/airflow#who-uses-apache-airflow
Which as far as I can see doesn’t follow ASF policy - links need to be
no-follow for starters.
Thanks,
Justin
Hi,
> rather English Webinar (perhaps we have tot hink about timezones).
> English subtitle on live video will be tough... don’t know if anybody here
> can type that fast : D
Well I’ve given talks that have been simultaneous;ly translated into another
language live so it is possible.
Thanks,
Hi,
> I just had a look ... I couldn't find any code taken from the Milo project.
> All I found was usage of milo libraries.
> So as we are releasing sources, do we have to mention the Milo project in the
> NOTICE at all?
N you do not.
Thanks,
Justin
Hi,
> However for the ConfigKeys and Config classes I think we could simply change
> the header.
If the contributors agree then you can change the headers, but this is not the
major issue here, I’m more concerned by the Milo one.
> As Dominik, from whom most of that code came in via PR, is
Hi,
Sorry but’s it -1 due to license. notice and licensing issues. May need a
little discussion to sort out.
I checked:
- signatures and checksum fine
- NOTICE mentions “This product includes software developed at The Milo
project (https://github.com/eclipse/milo).” Why is this here? What
Hi,
See [1] and in particular [2]. Note also how druid is not in line with [3]
Thanks,
Justin
1. https://www.apache.org/foundation/marks/linking#projectthanks
2. https://www.apache.org/foundation/marks/linking#productsupport
3. https://www.apache.org/foundation/marks/linking#whoweare
Hi,
> as Lukas just opened up a discussion about mentioning commercial support on
> the (new) PLC4X Homepage.
> One Example where this is done is Apache Druid
> (https://druid.apache.org/community/ see Getting Help).
I dislike the Druid example as it shows who the committers are working for,
HI,
+1 (binding) but the NOTICE year still needs updating.
I checked:
- signatures and hashes are fine
- LICENSE is OK
- NOTICE still need year updating
- No unexpected binary files in the release
- All source files have ASF headers
- Can compile from source
Thanks,
Justin
Hi,
-1 (binding) as there is a compiled jar in the source release. [1]
Chris where have I see this same issue before :-)
I checked:
- signatures and hashes are fine
- LICENSE is OK
- NOTICE need year updating
- Unexpected binary fine in the release
- All source files have ASF headers
- Can
HI,
> Second thing is:
> Do we want to distribute Docker images of things that need it? And if yes,
> how do we do it correctly (Justin … this part of the question is generally
> directed to you ;) )
Best guidelines we currently have is [1]
Thanks,
Justin
1.
Hi,
+1 (binding)
I checked:
- hashes and signatures correct
- LICENSE and NOTICE file
- All source files have ASF headers
- No unexpected binary files
- Can compile from source
Thanks,
Justin
Hi,
-1 (binding) due to license issues.
I checked:
- signatures and hashes fine
- LICENSE is missing license for these two files [1][2]. Does it come form here
[3]?
- LICENSE is missing license for this file [4] (and rat clearly shows this)
- no unexpected binary files
- all source files have
Hi,
+1 binding
I checked:
- signatures and hashes are good
- LICENSE and NOTICE fine
- All source files have ASF headers
- No binary files
- can compile from source
The mvnw information belongs in LICENSE not NOTICE so is correct in this
release. In general all license information go in
Hi,
> But as far as I know there's no Netty in the plugin…
Then why is it mentioned in LICENSE?
Thanks,
Justin
Hi,
-1 (binding) as NOTICE file is missing information
I checked:
- signatures and hashes fine
- LICENSE is OK
- NOTICE need some more work(see below)
- No unexpected binary files
- All source files have ASF headers
- Can compile from source
Netty has a NOTICE file [1] so relevant portions of
HI,
+1 from me.
Thanks,
Justin
+1
HI,
> I just added a new board report draft here:
> https://cwiki.apache.org/confluence/display/PLC4X/2019-July
BTW Confluence now has a markdown plugin if you want to use that.
Justin
Hi,
> JMH is used to microbenchmark the protocol stack. Currently it is only
> implemented for ADS.
> As these licenses habe a classpath exception they should be safe to use.
> Pretty sure we checked this with legal back then (thus the XML commemts)
It’s an optional dependanc, that is seem no
Hi,
+1 (binding) I should of added.
Thanks,
Justin
Hi,
These ones from ./plc4j/protocols/benchmarks/pom.xml
Hi,
I checked:
- no incubating in name or DISCLAIMER file
- signatures and hashes correct
- LICENSE and NOTICE fine
- no unexpected binary files
- all source files have ASF headers
- can compile from source
One very minor thing copyright in [1] should be updated to 2019
Thanks,
Justin
1.
Hi,
I notice the pom includes GPL dependancies, it seems that they are optional and
only used for running the tests. Is this correct?
Thanks,
Justin
Hi,
Should src/site be in the release?
Thanks,
Justin
Hi,
Have fun and congratulations! Sorry but it’s a little far for me being in
Australia.
Thanks,
Justin
Hi,
> 2016 version of BACnet ASN.1 with comments, but not all enumerations is
> 4600 lines long. I'm writing all this to add additional edge cases which
> we will need to cover - with DFDL or any other tool. It won't be easy
> neither way!
I worked with ASN.1 (and BER) in the past. ASN
Hi,
> But, I guess we get rid of the discussion if we do the following
> - generate a PLC4X branch where all the development takes place (=>
> everything is ASF licensed)
> - keep the paper source in the separate repo and, if necessary, reference
> code snippets from PLC4X Repo (with clear
Hi,
> some clarification... this repo currently hosts two things... some code
> snippets (really messy) and the draft version for the paper (like really
> really early draft).
If any of the code appears in the paper and is not clearly licensed under a
compatible license then it’s unlikely
Hi,
> And for the private Repo... It also felt wrong for me to write this. And
> strictly speaking its not a PLC4X Paper but a Paper which "talks about"
> PLC4X. The main reason for the private repo are license concerns as the
> authors usually have to hand over several rights to the Publisher
Hi,
Given you've just graduated, congratulations are in order.
If you could take the time file to fill out this short questionnaire on your
incubator journey and how you think the incubating process could be improved it
would be greatly appreciated.
How do you think things could be improved?
Hi,
+1 (binding) + good luck!
Justin
Hi,
+1 to that.
Thanks,
Justin
Hi,
> Having gone through Justin's link to the Apache maturity model [1] I guess we
> are on an extremely good path (Keep in mind this is not a maturity model for
> incubator projects, but all Apache projects)
Also keep in mind that a) the maturity model is not a requirement to graduation
but
Hi,
You may want to fill out this [1] it ’s not required but can give you a good
idea if you are ready to graduate.
I'd also check the the website re trademarks and branding and that it has all
needed links. [2]
Thanks,
Justin
1.
Hi,
A -1 vote on a release is not a veto, you should wait and see what other PPMC
members think, you can also try and convince the person to change their vote.
Thanks,
Justin
Hi,
> I just checked the RELEASE_NOTES and saw that I never changed the
> "(Unreleased) 0.3.0".
> Is this a problem for the release and does this justify -1 vote?
No a hug issue IMO, just fix it in the next release.
Thanks,
Justin
Hi,
It’s develop for me as well and I’m upto date:
Here some more info on the error I’m seeing:
Caused by: org.apache.maven.plugin.MojoExecutionException: Unable to create
features.xml file: java.io.IOException: Is a directory
at
Hi,
> Are these fixed only in develop or also in the RC?
> And if so, do you think we are ready for an RC?
> Otherwise you or I could cherry pick your fixes over.
One of the steps required in reviewing a release is that the source package
need to compile suscessfully, if it doesn’t it may not
Hi,
I’m still seeing an issue on OSX but it’s getting further than before:
[INFO] Integrations: Apache Karaf: ADS FAILURE [ 1.144 s]
[ERROR] Failed to execute goal
org.apache.karaf.tooling:karaf-maven-plugin:4.2.1:features-generate-descriptor
(generate-features-file) on
Hi,
> I can see a lot of “Unable to instantiate connection to mock:scraper”
> messages. And a lot of PlcConnectionException with the message “stfu” (we
> should use a little milder wording here, I think)
What’s wrong with "Say, Thanks for Understanding”? :-)
Thanks,
Justin
Hi Chris,
here’s the failing test:
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test (default-test) on
project plc4j-driver-modbus: There are test failures.
[ERROR]
[ERROR] Please refer to
Hi,
Trying to build develop branch on OSX 10.14.1 Java 1.8.0_171-b11 Maven 3.3.9.
I’m getting a number of issues when trying to do this:
"mvn compile" gives:
[INFO] karaf-ads-feature .. FAILURE [ 0.369 s]
[ERROR] Failed to execute goal
Hi,
+1 (binding)
I checked:
- incubating in name
- signature and hashes good
- LICENSE and NOTICE have some issues than need to be fix in the next release
- No unexpected binary files
- All ASF files have ASF headers
You are missing LICENSE / NOTICE info for Netty [1][2][3][4][5]
I’m not sure
Hi,
> Is it safe/ok to "borrow" those images?
From a quick glance no, you would need to ask for permission.
Thanks,
Justin
Hi,
Having one header wrong is not the end of the world, and as an incubating
project you have a DISCLAIMER for that reason. I’d continue with the vote.
Thanks,
Justin
Congratulations and have a nice day PLC4X :-)
On Wed., 17 Oct. 2018, 12:40 am Christofer Dutz,
wrote:
> Happy birthday Toddy!
>
> Today, one year ago, I did the first commit and look at us now! Wow ...
> Going strong and stronger every day.
>
> So happy the days are over, where I was talking to
Hi,
Sorry I missed this, although I guess Is know the answer.
You neglected to answer this question in the report:
Have your mentors been helpful and responsive or are things falling through the
cracks? In the latter case, please list any open issues that need to be
addressed.
Can you please
Hi,
All good by me, a couple of (very) minor things below.
> Make our first release
You done this so no need to list it?
> While the community activity had been quite low since the beginning of the
> project, things changed in August.
> Then we noticed not only new names appearing on the
" :
>
> Yup ... I'm on it ...
>
> Just wanted to have the first release out the door and other things
> done first.
> Will take care of this in the next one or two days.
>
> Chris
>
> Am 30.09.18, 15:36 schrieb "Justin Mclean" :
&
Hi,
The incubator PMC would appreciated if you could complete the podling report on
time. It takes time to prepare the incubator report, have your mentors sign off
the report and for the board to review it, in order for all that to happen the
report is due on Wednesday.
Thanks,
Justin
Hi,
> * It looks as if plc4x-parent-0.1.0-rc2 was the git tag for the RC as it
> matches the source zip (which misses the .gitignore but includes an
> extra DEPDENDENCIES file, BTW). The name looks a little strange, is
> this going to be "fixed" for the final release?
As tags change be
Hi,
+1 (binding) IMO There’s some license/notice issues that need to be fixed for
the next release.
I checked:
- incubating in name
- signatures and hashes good
- DISCLAIMER exists
- LICENSE and NOTICE need some work (see below)
- No unexpected binary fines
- All source files have ASF headers
-
Hi,
Well strictly speaking it’s only the incubator PMC vote that are binding as you
vote on it here first and then the IPMC votes on it. Once you graduate then
there’s the PMC votes are binding.
Thanks,
Justin
Hi,
> And I just noticed, when writing the release-documentation we should do
> a PGP Keysigning session at the meetup.
Good idea.
> Apache Releases are built around PGP keys. However currently I would be the
> only one able to do a release as I'm the only one who has a key signed by
>
Hi,
> Thank you two very much for these great additions. As Veronika and Andrey
> both work for codecentric, they did this during their work hours and we have
> a signed CCLA, I think there is no need for any ICLA signing on her side (is
> that correct?)
CCLA is more for the company not the
I could be mistaken but I think anyone can join or be invited
On Wed., 29 Aug. 2018, 8:41 am Julian Feinauer, <
j.feina...@pragmaticminds.de> wrote:
> Hi Benedikt,
>
>
>
> I think ist a good idea to have a slack for communication but I agree that
> its a bit inelegant to require an apache email
Hi,
While looking through the incubator reports it’s come to my attention that this
podling hasn’t made a release yet and has been in the incubator for 250+ days.
"Release early and release often” should be the guideline to follow. What is
holding up this project making it first release?
Go for it
On Fri., 6 Jul. 2018, 7:43 pm Christofer Dutz,
wrote:
> Ok,
>
>
>
> I am interpreting the silence as consent and will do the changes I
> proposed.
>
>
>
> Chris
>
>
>
>
>
> Am 03.07.18, 13:57 schrieb "Christofer Dutz" :
>
>
>
> Hi all,
>
>
>
> now digging into the
Looks good to me
> On 29 Jun 2018, at 12:45 am, Christofer Dutz
> wrote:
>
> Hope I didn’t miss anything … also hope this time I didn’t put in things the
> board isn’t interested in.
>
>
> ---
>
> Apache
Hi,
> If you are interested in getting an account please respond to this thread.
> I’ll order the accounts some time at the beginning of next week.
Count me in!
Justin
Hi,
Sound like a great idea to me.
Thanks,
Justin
Hi,
Yep I’ve been following along as well :-)
Justin
Hi,
> today I bought the magazine with my Article and was totally amazed that it
> has become one of the cover-page articles :-)
They didn’t send you a free copy? :-) Congratulations, well done and keep up
the good work, any chance of an english translation?
Thanks,
Justin
Hi,
> I'd be inclined to do a bunch of the cleanup myself if I had some degree of
> confidence that the project was committed to their elimination. A project
> policy of not delivering code that adds more is sufficient IMO (not sure
> tooling enforcement is necessary). Can IntelliJ be
Hi,
> Sonar[1] reports 158 code smells but those don’t seem to include any of the
> categories of the 235 noted below. Not sure what to make of that.
It could be that some rules have been turned off? I’m also seeing some sonar
cube one that are legitimate issues but nothing too serious. Some
Hi,
> On the current “master” branch, Eclipse 4.6.3 (with std Error/Warning
> preference config) and java 1.8.0_161, Eclipse reports 235 warnings. The bulk
> of these seem to be Raw type and Type safety warnings. Are there plans for
> dealing with these?
I guess you are project the only
Hi,
> I extended the test with duplicated hex variants to better visualize the
> boundaries:
> @Test
> public void checkUnsignedBoundsLongHex() {
>// Hex representation to visualize valid bounds in bytes
>ByteValue.checkUnsignedBounds(0x0_00_00, 2);
>
Hi,
It looks to me that some of the tests are just here to increase coverage and we
seem to be missing unit test for some of the more simple classes. Perhaps
there’s a bit too much focus on the happy path and we’re not always checking
boundary conditions and the like. Obviously this is a good
Hi,
Was just looking at some of the new tests and just wondering if they are trying
to be a bit too clever? What do other people think?
For instance this:
@Test
public void testOfWintime() throws Exception {
assumeThat(clazz, isOneOf(TimeStamp.class));
{
Method ofMethod =
Hi,
> Even if I like the way AssertJ handles exceptions a bit more than the
> Hamcrest way, I never was particularly fond of never-ending fluent
> expressions. So I would opt for the Hamcrest version.
No strong view either way as any tests are good to have :-) But I have used
Hamcrest in the
Hi,
> thanks for finding that ... guess when porting all these thousands of
> statements, I must have missed one or two "replace: ' == ' with
> ').isEqualTo('” __
Yep I can imaging my brain zoning out when doing that :-)
> Well the main reason was probably, that I wanted to replace the
>
…but it does make for a good test passing rate :-)
Hi,
BTW any reason you use assertThat form AssertJ rather than the one built into
Junit 4? Just curious no strong views either way.
You might want to fix a couple of your assertThat’s for instance this:
assertThat(tpdu.getTpduCode() == TpduCode.CONNECTION_REQUEST);
Isn’t probably doing what
Hi,
Given the issues we’re currently seeing with Junit5 I’m +1 on this. But that
doesn’t mean we can’t revisit in the future once it’s kinks are worked out.
Thanks,
Justin
Hi,
Either way the PPMC can review, provide feedback on, modify etc etc before it
goes live. "Must not be advertisements” is the main thing.
Thanks,
Justin
Hi,
> Well the one thing I like with TestNG is the support for parametrized tests.
> With JUnit 4 this sucks greatly and it very easy with TestNG. I do think that
> we need parametrized tests as we do have a lot of options to test.
There are some existing parametrised tests and I've used it in
Hi,
> Pcap4j is licensed with a MIT license:
> https://github.com/kaitoy/pcap4j/#license
Pcap4j is MIT with bit of BSD and Apache 2.0 all good. (And their logo is
CC-BY-4.0 also ok)
> So, I guess we can use that. As the library requires libpcap, the license of
> that is the 3-clause BSD:
>
Hi,
> By the way … the link to ethercat. This is a different protocol. It’s more a
> real-time protocol where the PLC communicates with Drives, IOs and stuff like
> that.
No problem I was just looking at random links.
> I just contacted Beckhoff and simply asked them what we have to do in
Hi,
In writing a couple of bad code code I found that the the existing code would
NPE when doing switch of a TdpuCode of null. In order to get around this I add
a new enum of UNKNOWN and now have valueOF return that instead of null if the
tpdu code is not in the enum map. Anyone think this is
Hi,
> Note if PLC4X were setup to have its GitHub repo as its main repo, not this
> non-writeable mirror thing, merging a PR would involve a committer just
> pushing the PR’s merge button. Also we could use Github Issues.
With the current set up we can do both those things i.e. merge PRs and
Hi,
Ping?
Justin
Hi,
> Also it would be helpful if DEVELOPMENT.md were updated to capture the “how
> to run sonar locally” info below.
I you use intelliJ you can use the sonar lint plugin, eclipse may have a
similar plug in I’m not sure.
To run sonar locally (if you just want occasional use) it just a matter
Hi,
With this change here:
> DataTransportSize dataTransportSize =
> DataTransportSize.valueOf(userData.readByte());
> short length = (dataTransportSize.isSizeInBits()) ?
> -(short) Math.ceil(userData.readShort() / 8) :
Hi,
> clean install sonar:sonar -Dsonar.host.url=http://localhost:9000/
All good working for me as well.
Thanks,
Justin
Hi,
I've see you changed it so that running locally no longer works and it’s
publishing to Apache builds.
That’s great but how would I test my changes and run sonar locally before
having to commit changes?
Thanks,
Justin
Hi,
IsoTPProtocol has these properties:
private CalledTsapParameter calledTsapParameter;
private TpduSizeParameter tpduSizeParameter;
They are assigned but not accessed and could be local vars rather than fields.
Is there any reason for that? I assume the code just not been completed yet?
Hi,
Ah sorry my mistake only TLP currently use whimsy. It needs to be added here.
[1]
Infra seems to be having a few DNS issues at the moment I’ll submit when I get
a chance later today. We have a few days before it needs to be submitted
anywhere.
Thanks,
Justin
1.
Hi,
Looks good to me. It can be submitted here [1] (although only members and
officials have access to do so)
Thanks,
Justin
1. https://whimsy.apache.org/board/agenda/2018-01-17/
Hi,
I’d also add that the software grant was submitted.
Thanks,
Justin
] should also
be of help.
If you have any other questions about how the ASF works please ask on the
dev list and one of the mentors or other ASF members will answer any questions
you have.
Welcome aboard!
Justin Mclean
(as PLC4X mentor)
1. http://www.apache.org/foundation/how-it-works.html
2. http
Hi,
I just checked in some IsoTPProtocol tests and notice that he header size was
off in one case. [1] Someone mind double checking for me as I’m not familiar
with the protocol and was just going with what was in the code.
Thanks,
Justin
1.
Hi,
Looking good to me there’a couple of things I would add.
I’d add “Make our first release” as a point under "Most important issues to
address while moving towards graduation”
> Any Issues the Incubator PMC or ASF Board might wish/need to be aware of:
>
> * Still not all members of the
1 - 100 of 104 matches
Mail list logo
