Re: Review Request 74974: RANGER-4789: Admin audits for security-zone are blank for new and old value, when compression is enabled

2024-05-09 Thread Subhrat Chaudhary via Review Board
> On May 6, 2024, 10:54 p.m., Madhan Neethiraj wrote: > > > For the change only in security-zone resource name (resource count of the > > > zone is same), admin audit is not generated. > > Subhrat - instead of skipping admin audit in this scenario, I suggest audit > > to indicate that

Re: Review Request 74974: RANGER-4789: Admin audits for security-zone are blank for new and old value, when compression is enabled

2024-05-09 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74974/ --- (Updated May 9, 2024, 10:09 p.m.) Review request for ranger, Anand Nadar, Asit

Re: Review Request 74976: RANGER-4782: Implement best coding practices for validating service configs

2024-05-08 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74976/#review226422 ---

Review Request 74975: RANGER-4784: default tag-based policy is not created for the tag-service added to security zone

2024-05-06 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74975/ --- Review request for ranger, Anand Nadar, Asit Vadhavkar, Madhan Neethiraj,

Review Request 74974: RANGER-4789: Admin audits for security-zone are blank for new and old value, when compression is enabled

2024-05-03 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74974/ --- Review request for ranger, Anand Nadar, Asit Vadhavkar, Madhan Neethiraj,

Re: Review Request 74950: RANGER-4764: Update the policyName of associated policies when dataset/project name is modified

2024-04-03 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74950/#review226370 --- Ship it! Ship It! - Subhrat Chaudhary On April 3, 2024,

Re: Review Request 74949: RANGER-4763: Send user-friendly message if Test connection is not implemented for a service definition

2024-04-03 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74949/#review226367 --- Ship it! Ship It! - Subhrat Chaudhary On April 3, 2024,

Re: Review Request 74950: RANGER-4764: Update the policyName of associated policies when dataset/project name is modified

2024-04-03 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74950/#review226366 ---

Review Request 74927: RANGER-4727: When tagDef delete fails, error message is not returned

2024-03-04 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74927/ --- Review request for ranger, Anand Nadar, Asit Vadhavkar, Madhan Neethiraj,

Review Request 74850: RANGER-4669: checking users nested in roles and groups to get datasets shared with users

2024-01-22 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74850/ --- Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika

Review Request 74846: RANGER-4664: SQL Exception is thrown, if resource is null in POST sharedResource API

2024-01-19 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74846/ --- Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika

Re: Review Request 74839: RANGER-4658: updated GDS policy evaluation to fix handling of _any access

2024-01-18 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74839/#review226142 --- Ship it! Ship It! - Subhrat Chaudhary On Jan. 17, 2024,

Re: Review Request 74744: RANGER-4535: GET dataset API should return public:LIST in ACL if available

2023-11-29 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74744/ --- (Updated Nov. 29, 2023, 3:51 p.m.) Review request for ranger, Anand Nadar,

Re: Review Request 74744: RANGER-4535: GET dataset API should return public:LIST in ACL if available

2023-11-20 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74744/ --- (Updated Nov. 20, 2023, 10:06 p.m.) Review request for ranger, Anand Nadar,

Re: Review Request 74744: RANGER-4535: GET dataset API should return public:LIST in ACL if available

2023-11-20 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74744/ --- (Updated Nov. 20, 2023, 10:05 p.m.) Review request for ranger, Anand Nadar,

Review Request 74744: RANGER-4535: GET dataset API should return public:LIST in ACL if available

2023-11-20 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74744/ --- Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika

Review Request 74725: RANGER-4517: Sort param sortType is not considered if sortBy is not passed

2023-11-08 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74725/ --- Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika

Review Request 74715: RANGER-4432: Add a new new API for service lookup

2023-11-02 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74715/ --- Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika

Re: Review Request 74705: RANGER-4486: zone-v2 PUT API Partial update #2

2023-10-30 Thread Subhrat Chaudhary via Review Board
> On Oct. 31, 2023, 4:01 a.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSecurityZoneHelper.java > > Lines 147 (patched) > > > > > > Is a HashSet<>() needed here?

Re: Review Request 74705: RANGER-4486: zone-v2 PUT API Partial update #2

2023-10-30 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74705/ --- (Updated Oct. 31, 2023, 9:19 a.m.) Review request for ranger, Anand Nadar,

Re: Review Request 74705: RANGER-4486: zone-v2 PUT API Partial update #2

2023-10-30 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74705/ --- (Updated Oct. 30, 2023, 10:35 p.m.) Review request for ranger, Anand Nadar,

Review Request 74705: RANGER-4486: zone-v2 PUT API Partial update #2

2023-10-30 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74705/ --- Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika

Re: Review Request 74698: RANGER-4035: DB schema update to persist XXAccessTypeDef.category

2023-10-28 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74698/#review225901 --- Ship it! Ship It! - Subhrat Chaudhary On Oct. 26, 2023,

Re: Review Request 74699: RANGER-4497: updated service-defs to assign category to access-type-defs

2023-10-28 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74699/#review225900 ---

Re: Review Request 74690: RANGER-4266: gds info retrieval by plugins

2023-10-25 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74690/#review225894 --- Ship it! Ship It! - Subhrat Chaudhary On Oct. 23, 2023,

Re: Review Request 74690: RANGER-4266: gds info retrieval by plugins

2023-10-23 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74690/#review225885 ---

Re: Review Request 74686: RANGER-4486: ZoneV2 partial update allows duplicate principals and tagServices

2023-10-20 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74686/ --- (Updated Oct. 20, 2023, noon) Review request for ranger, Anand Nadar, Ankita

Review Request 74686: RANGER-4486: ZoneV2 partial update allows duplicate principals and tagServices

2023-10-19 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74686/ --- Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika

Re: Review Request 74674: RANGER:4475:Security-Zone summary API ranger Admin should have access for all zones

2023-10-16 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74674/#review225864 ---

Re: Review Request 74611: RANGER-4415: New API to add multiple datashares in a dataset

2023-10-14 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74611/ --- (Updated Oct. 14, 2023, 8:12 p.m.) Review request for ranger, Anand Nadar,

Re: Review Request 74666: RANGER:4428:Need a new API to get list of zones mapped to a service

2023-10-12 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74666/#review225855 ---

Re: Review Request 74665: RANGER-4440: added column x_security_zone.gz_jsonData to store compressed bytes - #3

2023-10-12 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74665/#review225854 --- Ship it! Ship It! - Subhrat Chaudhary On Oct. 12, 2023,

Review Request 74661: RANGER-4459: add filters for sharedResourceName and sharedResourceNamePartial in get sharedResource API #2

2023-10-11 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74661/ --- Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, and

Re: Review Request 74660: RANGER-4471: generate trxLog for dataset, project, dataShare, sharedResource

2023-10-11 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74660/#review225851 --- Ship it! Ship It! - Subhrat Chaudhary On Oct. 11, 2023,

Re: Review Request 74658: RANGER-4470: renamed defaultMasks to defaultTagMasks in RangerDataShare, subResourceNames to subResource in RangerSharedResource

2023-10-11 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74658/#review225850 --- Ship it! Ship It! - Subhrat Chaudhary On Oct. 10, 2023,

Re: Review Request 74658: RANGER-4470: renamed defaultMasks to defaultTagMasks in RangerDataShare, subResourceNames to subResource in RangerSharedResource

2023-10-11 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74658/#review225849 ---

Re: Review Request 74654: RANGER-4466: Update approver when request status is updated

2023-10-10 Thread Subhrat Chaudhary via Review Board
> On Oct. 10, 2023, 11:36 a.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > > Lines 1046 (patched) > > > > > > Should the approvar field be updated for any

Re: Review Request 74654: RANGER-4466: Update approver when request status is updated

2023-10-10 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74654/ --- (Updated Oct. 11, 2023, 1:54 a.m.) Review request for ranger and Madhan

Review Request 74659: RANGER-4469: Dataset summary API throws 403

2023-10-10 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74659/ --- Review request for ranger and Madhan Neethiraj. Bugs:

Review Request 74654: RANGER-4466: Update approver when request status is updated

2023-10-09 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74654/ --- Review request for ranger and Madhan Neethiraj. Bugs:

Review Request 74651: RANGER-4459: Need additional filter on GET sharedResource API

2023-10-09 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74651/ --- Review request for ranger and Madhan Neethiraj. Bugs:

Review Request 74650: RANGER-4464: New API to get DataShare Summary

2023-10-08 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74650/ --- Review request for ranger and Madhan Neethiraj. Bugs:

Re: Review Request 74648: RANGER-4463: PrincipalCount not getting updated in DatasetSummary

2023-10-08 Thread Subhrat Chaudhary via Review Board
> On Oct. 8, 2023, 6:56 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > > Line 1276 (original), 1275 (patched) > > > > > > Given getDatasetPolicies(datasetId)

Re: Review Request 74648: RANGER-4463: PrincipalCount not getting updated in DatasetSummary

2023-10-08 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74648/ --- (Updated Oct. 8, 2023, 8:51 p.m.) Review request for ranger and Madhan

Re: Review Request 74648: RANGER-4463: PrincipalCount not getting updated in DatasetSummary

2023-10-08 Thread Subhrat Chaudhary via Review Board
> On Oct. 7, 2023, 11:46 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > > Line 1263 (original), 1263 (patched) > > > > > > It will be efficient to use

Re: Review Request 74648: RANGER-4463: PrincipalCount not getting updated in DatasetSummary

2023-10-08 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74648/ --- (Updated Oct. 8, 2023, 5:37 p.m.) Review request for ranger and Madhan

Review Request 74649: RANGER-4446: Add description in dataset summary API response

2023-10-07 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74649/ --- Review request for ranger and Madhan Neethiraj. Bugs:

Review Request 74648: RANGER-4463: PrincipalCount not getting updated in DatasetSummary

2023-10-07 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74648/ --- Review request for ranger and Madhan Neethiraj. Bugs:

Re: Review Request 74646: RANGER-4462: dataShare update/delete should be allowed for users with service-admin/zone-admin privilege as well

2023-10-06 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74646/#review225830 --- Ship it! Ship It! - Subhrat Chaudhary On Oct. 6, 2023, 2:17

Re: Review Request 74643: RANGER-4440: when compression is enabled for x_security_zone.jsonData, store summary (not complete resource details) in trx log

2023-10-05 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74643/#review225826 --- Ship it! Ship It! - Subhrat Chaudhary On Oct. 6, 2023,

Re: Review Request 74631: RANGER-4445: new REST endpoints for dataset policies

2023-10-05 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74631/#review225824 ---

Re: Review Request 74639: RANGER-4447: Add GET API to get security-zone summary for current user

2023-10-04 Thread Subhrat Chaudhary via Review Board
> On Oct. 4, 2023, 11:01 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneDBStore.java > > Lines 261 (patched) > > > > > > Since zones could be filtered in-memory

Re: Review Request 74639: RANGER-4447: Add GET API to get security-zone summary for current user

2023-10-04 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74639/ --- (Updated Oct. 4, 2023, 11:58 p.m.) Review request for ranger and Madhan

Re: Review Request 74634: RANGER-4446: Need an API to return dataset summary

2023-10-04 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74634/ --- (Updated Oct. 4, 2023, 7:16 p.m.) Review request for ranger and Madhan

Review Request 74639: RANGER-4447: Add GET API to get security-zone summary for current user

2023-10-03 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74639/ --- Review request for ranger and Madhan Neethiraj. Bugs:

Re: Review Request 74634: RANGER-4446: Need an API to return dataset summary

2023-10-03 Thread Subhrat Chaudhary via Review Board
> On Oct. 3, 2023, 12:09 a.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java > > Lines 480 (patched) > > > > > > Consider using GdsPermission for

Re: Review Request 74634: RANGER-4446: Need an API to return dataset summary

2023-10-03 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74634/ --- (Updated Oct. 3, 2023, 2:40 p.m.) Review request for ranger and Madhan

Review Request 74634: RANGER-4446: Need an API to return dataset summary

2023-10-02 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74634/ --- Review request for ranger and Madhan Neethiraj. Bugs:

Re: Review Request 74630: RANGER-4435: Support cascade delete of datashare

2023-10-02 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74630/ --- (Updated Oct. 2, 2023, 3:41 p.m.) Review request for ranger and Madhan

Review Request 74630: RANGER-4435: Support cascade delete of datashare

2023-10-01 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74630/ --- Review request for ranger and Madhan Neethiraj. Bugs:

Re: Review Request 74621: RANGER-4426: Add approver in GDS request entities

2023-10-01 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74621/ --- (Updated Oct. 1, 2023, 2:04 p.m.) Review request for ranger, Anand Nadar,

Re: Review Request 74621: RANGER-4426: Add approver in GDS request entities

2023-10-01 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74621/ --- (Updated Oct. 1, 2023, 2:01 p.m.) Review request for ranger, Anand Nadar,

Re: Review Request 74621: RANGER-4426: Add approver in GDS request entities

2023-10-01 Thread Subhrat Chaudhary via Review Board
> On Sept. 30, 2023, 3:14 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetInProjectService.java > > Lines 228 (patched) > > > > > > findByLoginId() can return

Re: Review Request 74611: RANGER-4415: New API to add multiple datashares in a dataset

2023-10-01 Thread Subhrat Chaudhary via Review Board
> On Sept. 30, 2023, 1:51 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > > Lines 674 (patched) > > > > > > Is parameter datasetId necessary, given each object

Re: Review Request 74611: RANGER-4415: New API to add multiple datashares in a dataset

2023-10-01 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74611/ --- (Updated Oct. 1, 2023, 1:37 p.m.) Review request for ranger, Anand Nadar,

Re: Review Request 74621: RANGER-4426: Add approver in GDS request entities

2023-09-30 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74621/ --- (Updated Sept. 30, 2023, 1:48 p.m.) Review request for ranger, Anand Nadar,

Re: Review Request 74610: RANGER-4323: New API to get Dataset header info for Dataset listing page

2023-09-29 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74610/ --- (Updated Sept. 29, 2023, 1:38 p.m.) Review request for ranger, Anand Nadar,

Re: Review Request 74621: RANGER-4426: Add approver in GDS request entities

2023-09-28 Thread Subhrat Chaudhary via Review Board
> On Sept. 28, 2023, 10:13 a.m., Madhan Neethiraj wrote: > > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql > > Lines 1831 (patched) > > > > > > To be consistent with added_by_id and upd_by_id,

Re: Review Request 74621: RANGER-4426: Add approver in GDS request entities

2023-09-28 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74621/ --- (Updated Sept. 28, 2023, 2:56 p.m.) Review request for ranger, Anand Nadar,

Review Request 74626: RANGER-4439: Duplicate resource IDs are create while updating security zone

2023-09-27 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74626/ --- Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, and

Re: Review Request 74610: RANGER-4323: New API to get Dataset header info for Dataset listing page

2023-09-26 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74610/ --- (Updated Sept. 26, 2023, 10:50 p.m.) Review request for ranger, Anand Nadar,

Re: Review Request 74621: RANGER-4426: Add approver in GDS request entities

2023-09-25 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74621/ --- (Updated Sept. 26, 2023, 9:53 a.m.) Review request for ranger, Anand Nadar,

Review Request 74621: RANGER-4426: Add approver in GDS request entities

2023-09-25 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74621/ --- Review request for ranger, Anand Nadar, Madhan Neethiraj, Monika Kachhadiya,

Re: Review Request 74611: RANGER-4415: New API to add multiple datashares in a dataset

2023-09-24 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74611/ --- (Updated Sept. 25, 2023, 9:51 a.m.) Review request for ranger, Anand Nadar,

Re: Review Request 74611: RANGER-4415: New API to add multiple datashares in a dataset

2023-09-24 Thread Subhrat Chaudhary via Review Board
> On Sept. 21, 2023, 9:17 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java > > Lines 835 (patched) > > > > > > In case of failure in adding any datashare (like due

Review Request 74617: RANGER-4423: Add support for filter by service and zone name in get datashare API

2023-09-21 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74617/ --- Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, and

Review Request 74611: RANGER-4415: New API to add multiple datashares in a dataset

2023-09-19 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74611/ --- Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika

Review Request 74610: RANGER-4323: New API to get Dataset header info for Dataset listing page

2023-09-19 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74610/ --- Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika

Re: Review Request 74604: RANGER-4413: Fix pagination for GDS APIs

2023-09-15 Thread Subhrat Chaudhary via Review Board
> On Sept. 15, 2023, 9:24 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > > Lines 227 (patched) > > > > > > Consider avoiding duplicate code in

Re: Review Request 74604: RANGER-4413: Fix pagination for GDS APIs

2023-09-15 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74604/ --- (Updated Sept. 15, 2023, 10:35 p.m.) Review request for ranger, Anand Nadar,

Review Request 74604: RANGER-4413: Fix pagination for GDS APIs

2023-09-15 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74604/ --- Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika

Re: Review Request 74598: RANGER-4324: Implementing Acl for RangerDataSet

2023-09-13 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74598/ --- (Updated Sept. 13, 2023, 11:33 a.m.) Review request for ranger, Anand Nadar,

Re: Review Request 74598: RANGER-4324: Implementing Acl for RangerDataSet

2023-09-12 Thread Subhrat Chaudhary via Review Board
> On Sept. 12, 2023, 9:47 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > > Line 251 (original), 251 (patched) > > > > > > User having only LIST permission

Re: Review Request 74598: RANGER-4324: Implementing Acl for RangerDataSet

2023-09-12 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74598/ --- (Updated Sept. 13, 2023, 12:33 a.m.) Review request for ranger, Anand Nadar,

Review Request 74598: RANGER-4324: Implementing Acl for RangerDataSet

2023-09-12 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74598/ --- Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika

Review Request 74535: RANGER-4312: Add API to reset cache of role, user. And reset policy and tag cache by service id

2023-08-07 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74535/ --- Review request for ranger, Anand Nadar, Ankita Sinha, and madhan. Bugs:

Review Request 74505: RANGER-4302: Draft patch to add support for the GDS download API.

2023-07-05 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74505/ --- Review request for ranger and Madhan Neethiraj. Bugs:

Re: Review Request 74481: RANGER-4267: link resource-based services with gds-service

2023-06-19 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74481/#review225554 ---

Re: Review Request 74405: RANGER-4195:Exposing the Ranger REST API is used to fetch the health check status of Ranger Admin

2023-05-30 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74405/#review225492 ---

Re: Review Request 74399: RANGER-4191:Expose the Ranger REST API to fetch all the roles that groups belong to

2023-05-20 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74399/#review225476 ---

Review Request 74438: RANGER-4240: Optimize deletion of XXAuthSession while deleting user

2023-05-16 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74438/ --- Review request for ranger, Ankita Sinha and Madhan Neethiraj. Bugs:

Review Request 74298: RANGER-4023: UserStoreEnricher is not enabled if only mask conditon has attribute based expression

2023-02-07 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74298/ --- Review request for ranger, Ankita Sinha and Madhan Neethiraj. Bugs:

Re: Review Request 74200: RANGER-3966: fix to use user-roles from request context consitently

2022-11-15 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74200/#review224865 --- Ship it! Ship It! - Subhrat Chaudhary On Nov. 13, 2022,

Re: Review Request 74200: RANGER-3966: fix to use user-roles from request context consitently

2022-11-14 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74200/#review224863 --- request.getUserRoles() is getting called in

Re: Review Request 74187: RANGER-3956: updated commons-text library version to 1.10.0

2022-11-01 Thread Subhrat Chaudhary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74187/#review224850 --- In know-agent/pom.xml, following dependency is duplicated