has bothered to
review it!
https://reviews.apache.org/r/57421/
- Colm O hEigeartaigh
On April 21, 2017, 12:04 a.m., Sailaja Polavarapu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
> On April 21, 2017, 7:58 a.m., Colm O hEigeartaigh wrote:
> > Hi, I have already raised a review request for this, but no-one has
> > bothered to review it!
> >
> > https://reviews.apache.org/r/57421/
I've merged a fix for 57421 after a review by Don. So this
0.7
- Colm O hEigeartaigh
On April 21, 2017, 12:08 a.m., Sailaja Polavarapu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58598/#review172605
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 21, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58602/#review172610
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 21, 2017
for the "if
is_unix" block. It should work for windows as well. Same goes for
dba_script.py. There is also some trailing whitespace after the
"RANGER_ADMIN_CONF" definition in both python files that could be fixed.
- Colm O hEigeartaigh
On April 19, 2017, 10:40 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58476/#review172622
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 20, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58633/#review172765
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 21, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58630/#review172766
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 21, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58647/#review172769
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 22, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58655/#review172770
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 24, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58529/#review172771
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 24, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57987/#review172772
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 21, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58663/#review172779
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 24, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58662/#review172902
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 24, 2017
-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java:108
- Colm O hEigeartaigh
On April 25, 2017, 6:29 a.m., bhavik patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
Could we just not log
the user + host information inside the file?
- Colm O hEigeartaigh
On April 24, 2017, 9:01 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58229/#review172906
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 25, 2017
> On April 25, 2017, 9:56 a.m., Colm O hEigeartaigh wrote:
> > I'm a bit unsure about changing the name of the log file. Could we just not
> > log the user + host information inside the file?
>
> pengjianhua wrote:
> The user can not directly determine follo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58730/#review173035
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 26, 2017
rted to 0.7.x as well IMO.
- Colm O hEigeartaigh
On April 26, 2017, 11:02 a.m., bhavik patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&g
to me,
but it might have some backwards compatibility issues.
Please give some feedback on the review request either way.
Thanks,
Colm.
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
_TYPE_NONE)) {
+ ret.setMaskType(null);
+ }
+ }
- Colm O hEigeartaigh
On April 26, 2017, 11:14 p.m., Abhay Kulk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58734/#review173171
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 27, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58781/#review173175
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 27, 2017
()) {
+ LOG.debug("maskTypeDef-to-add:[" +
maskTypeDef + "]");
+ }
+ }
+
Much better to instead put the if statement outside the for loop.
- Colm O hEigeartaigh
On April 21, 2017, 9:23 p.m.,
,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58791/#review173304
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 27, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58787/#review173307
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 28, 2017
combined using &&:
if (LOG.isDebugEnabled()) {
if (ret.getIsAccessDetermined() &&
ret.getIsAuditedDetermined()) {
if(ret.getIsAccessDetermined()) {
if (StringUtils.equalsIgnoreCase(ret.getMaskType(),
RangerPolicy.MASK_TYPE_NO
r "tls" in this
configuration tag, as it's not obvious it refers to SSL configuration:
"ranger.enabled.Protocols.defaultvalue"
- Colm O hEigeartaigh
On May 2, 2017, 6:42 a.m., bhavik patel wrote:
>
> ---
> T
ad the policies with no
credentials with curl? Are we looking at a security issue here?
Colm.
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
tomatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58660/
> ---
>
> (Updated April 24, 2017, 9:01 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58915/#review173713
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 2, 2017, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58932/#review173749
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 2, 2017, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58959/#review173751
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 3, 2017, 11
he infra team…
>
>
>
> Just intrigued 😉
>
> Thanks
>
> Nigel.
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>
>
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58660/#review173921
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 4, 2017, 5
statement.
- Colm O hEigeartaigh
On May 3, 2017, 8:10 p.m., Madhavi Amirneni wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58982/#review173926
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 4, 2017, 6
Hi devs,
I have 7 review requests forlornly waiting for a review...please try to
pick up some of them if you have some spare cycles.
Thanks!
Colm.
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58745/#review174150
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 4, 2017, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58745/#review174151
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 4, 2017, 6
~" as documented here
please?
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=55151244
- Colm O hEigeartaigh
On May 4, 2017, 6:27 p.m., Anna Shaverdian wrote:
>
> ---
> This is an automatically generated e-ma
n't appear to be part of
the NPE issue.
- Colm O hEigeartaigh
On May 9, 2017, 9:24 a.m., Ankita Sinha wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59007/#review174288
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 8, 2017, 8
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59086/#review174293
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 9, 2017, 9
/
Changes: https://reviews.apache.org/r/58559/diff/1-2/
Testing
---
Verified the hive/hdfs distributions have the same libs.
Thanks,
Colm O hEigeartaigh
/service/TestRangerServiceServiceBase.java
216c3384
Diff: https://reviews.apache.org/r/58231/diff/2/
Changes: https://reviews.apache.org/r/58231/diff/1-2/
Testing
---
Thanks,
Colm O hEigeartaigh
. The end "fi"
is not aligned with "then". I also think the "do" should be underneath the
"for" as per the other examples in the file.
Have you installed a plugin with this change to make sure it works correctly?
- Colm O hEigeartaigh
On M
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58693/#review174323
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 25, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59079/#review174429
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 10, 2017, 8
in = new FileInputStream(propFile)) {
installProperties.load(in);
} catch (IOException ex) {
..
}
- Colm O hEigeartaigh
On April 26, 2017, 9:34 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail.
dd9459a8
Diff: https://reviews.apache.org/r/59138/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
Why not just have them in agents-common and refer to them in the admin module?
- Colm O hEigeartaigh
On May 10, 2017, 1:44 p.m., bhavik patel wrote:
>
> ---
> This is an automatically generated e-
uot; private? I think the
change could be simplified to:
try (FileInputStream in = new FileInputStream(propFile)) {
installProperties.load(in);
} catch (...)
in.close() will be called automatically.
- Colm O hEigeartaigh
On May 10, 2017, 1:22 p.m., Qi
rounded brackets
like I mentioned in my last comment, e.g.:
try (FileInputStream ...)
- Colm O hEigeartaigh
On May 11, 2017, 2:55 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59121/#review174613
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 10, 2017, 3
"Module Details" is
fine, as the page lists the module name + then user/group permissions. Could
you resubmit a patch with just the first change?
- Colm O hEigeartaigh
On March 23, 2017, 8:32 a.m., Haihui Xu wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58732/#review174624
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 11, 2017, 9
-rl "XAAUDIT.DB.PASSWORD" *
agents-common/scripts/enable-agent.sh
hbase-agent/scripts/install.sh
hdfs-agent/scripts/install.sh
hive-agent/scripts/install.sh
knox-agent/scripts/install.sh
plugin-kms/scripts/enable-kms-plugin.sh
storm-agent/scripts/install.sh
- Colm O hEigeartaigh
On May 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59221/#review174810
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 12, 2017, 1
wnload
> should
> be used for download and will be restricted to valid plugins as you pointed
> out. /service/plugins/policies will need to be protected by two way SSL and
> exists for backward compatibility.
>
> Thanks,
> Vel
>
> From: Colm O hEigeartaigh
> Reply-To:
oth future
migration.
Diffs
-
plugin-kafka/pom.xml 3ef7eb98
plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java
f68a1641
Diff: https://reviews.apache.org/r/59275/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> ---
>
> (Updated May 13, 2017, 7:14 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Si
horization/kafka/authorizer/KafkaRangerAuthorizerTest.java
f68a1641
plugin-kafka/src/test/resources/kafka-policies.json d1609864
Diff: https://reviews.apache.org/r/59275/diff/2/
Changes: https://reviews.apache.org/r/59275/diff/1-2/
Testing
---
Thanks,
Colm O hEigeartaigh
test patch still has the
"Permissions Details" change in it.
When you are submitting a patch, please use " git format-patch -n HEAD~" as per:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=55151244
- Colm O hEigeartaigh
On May 16, 20
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175228
---
Why is the iteration count now "17"?
- Colm O hEigear
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59332/#review175229
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 17, 2017, 8
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59327/#review175230
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 17, 2017, 1
; in
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js.
By the way you can just update the diff rather than add files to the review
request.
- Colm O hEigeartaigh
On May 17, 2017, 8:35 a.m., Haihui Xu wrote:
>
> --
> On May 17, 2017, 11:12 a.m., Colm O hEigeartaigh wrote:
> > Why is the iteration count now "17"?
>
> bhavik patel wrote:
> For previous version this iteration count was 17 so to support backwards
> compatibility we have kept this count as 17, once the up
> On May 17, 2017, 11:12 a.m., Colm O hEigeartaigh wrote:
> > Why is the iteration count now "17"?
>
> bhavik patel wrote:
> For previous version this iteration count was 17 so to support backwards
> compatibility we have kept this count as 17, once the up
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57868/#review175245
---
Please create the patch using "git format-patch..."
/diff/1/
Testing
---
Tested that the KMS dist has the same jars as before.
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57868/#review175362
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 18, 2017, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58728/#review175363
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 26, 2017
/jira/browse/RANGER-1588
Repository: ranger
Description
---
The Storm test config has way too many unneeded properties defined.
Diffs
-
storm-agent/src/test/resources/storm.yaml a3069663
Diff: https://reviews.apache.org/r/59363/diff/1/
Testing
---
Thanks,
Colm O
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59370/#review175382
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 18, 2017, 2
://reviews.apache.org/r/59363/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59388/#review175478
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 19, 2017, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59390/#review175479
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 19, 2017, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58697/#review175480
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 28, 2017
ts when they run
> service. They hope that ranger also has the ability to dynamically change the
> pid path at startup.
> We should meet this need by minor modifications without affecting the
> current function and logic.
>
> Colm O hEigeartaigh wrote:
> I think it wo
/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java
5227d8c3
Diff: https://reviews.apache.org/r/59395/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
/HBaseRangerAuthorizationTest.java
2a46709a
Diff: https://reviews.apache.org/r/59399/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote:
> > Ship It!
Are the concerns I raised above addressed in the latest patch?
- Colm
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59
> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote:
> > Ship It!
>
> Colm O hEigeartaigh wrote:
> Are the concerns I raised above addressed in the latest patch?
>
> Velmurugan Periasamy wrote:
> yes Colm, I see they are addressed.
Hi Vel, I still see a
> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote:
> > Ship It!
>
> Colm O hEigeartaigh wrote:
> Are the concerns I raised above addressed in the latest patch?
>
> Velmurugan Periasamy wrote:
> yes Colm, I see they are addressed.
>
> Colm O hE
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175523
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 19, 2017, 1
---
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59433/#review175616
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 22, 2017, 3
isting Resource".
- Colm O hEigeartaigh
On May 22, 2017, 6:48 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
fix -
"alteast" -> "at least"
- Colm O hEigeartaigh
On May 22, 2017, 6:47 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
ginal code logic."
is a bit unnecessary. After the patch is applied it might confuse someone
looking at the code.
- Colm O hEigeartaigh
On May 22, 2017, 7:49 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59435/#review175620
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 22, 2017, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59432/#review175632
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 22, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59447/#review175633
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 22, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59392/#review175634
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 22, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59486/#review175773
---
Could you describe why they are invalid?
- Colm O hEigeartaigh
201 - 300 of 1156 matches
Mail list logo
