Re: Review Request 58957: Provide keyadmin user with privileges to read ranger kms audits

2017-05-03 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58957/#review173855 --- Ship it! Ship It! - Velmurugan Periasamy On May 3, 2017, 12

Re: Review Request 58982: RANGER-1557 : Add Nifi as default in supported component list

2017-05-04 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58982/#review173956 --- Ship it! Ship It! - Velmurugan Periasamy On May 4, 2017, 6

Re: Review Request 58921: Ranger-1552: Ranger usersync or ranger kms not able to communicate to ranger admin and no exception or error seen in the ranger user sync or kms logs.

2017-05-04 Thread Velmurugan Periasamy
g performed? - Velmurugan Periasamy On May 4, 2017, 6 p.m., Madhavi Amirneni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 58915: RANGER-1500 : Add support to exclude/disable SSL protocols

2017-05-05 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58915/#review174024 --- Ship it! Ship It! - Velmurugan Periasamy On May 5, 2017, 6

Re: Review Request 58658: RANGER-1513:Add Support for S3 authorization in Ranger Hive Plugin

2017-05-05 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58658/#review174059 --- Ship it! Ship It! - Velmurugan Periasamy On May 4, 2017, 5

Re: Review Request 59021: Code improvement to follow best practices.

2017-05-05 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59021/#review174061 --- Ship it! Ship It! - Velmurugan Periasamy On May 5, 2017, 11

Re: Review Request 59041: RANGER-1561:Good coding practice in Ranger recommended by static code analysis

2017-05-07 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59041/#review174138 --- Ship it! Ship It! - Velmurugan Periasamy On May 7, 2017, 10

Re: JIRA Contributor permission requested

2017-05-08 Thread Velmurugan Periasamy
Hi Nigel: I have added you as a contributor. Thank you, Vel From: Nigel L Jones Reply-To: "dev@ranger.apache.org" Date: Monday, May 8, 2017 at 6:48 AM To: "dev@ranger.apache.org" Subject: JIRA Contributor permission requested Hi, Could someone grant me contributor permission for JIRA p

Re: Review Request 58972: RANGER-1554: Upgrade springframework version in Ranger to 3.2.10.Release -- ranger-0.7 branch

2017-05-09 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58972/#review174314 --- Ship it! Ship It! - Velmurugan Periasamy On May 3, 2017, 8

Re: Review Request 59086: HDFS test connection is failing due to null pointer exception

2017-05-09 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59086/#review174315 --- Ship it! Ship It! - Velmurugan Periasamy On May 9, 2017, 9

Re: Review Request 59172: RANGER-1571 : Code Improvement To Follow Best Practices

2017-05-11 Thread Velmurugan Periasamy
/ranger/plugin/client/HadoopConfigHolder.java Line 34 (original), 34 (patched) <https://reviews.apache.org/r/59172/#comment247859> Remove this unused import. This will create a PMD violation. - Velmurugan Periasamy On May 11, 2017, 10:57 a.m., bhavik patel

Re: Review Request 59143: RANGER-1571 : Code Improvement To Follow Best Practices

2017-05-11 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59143/#review174757 --- Ship it! Ship It! - Velmurugan Periasamy On May 11, 2017

Re: Review Request 59227: RANGER-1576: Show attribute values to tags column in audit log

2017-05-12 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59227/#review174782 --- Ship it! Ship It! - Velmurugan Periasamy On May 12, 2017

Re: Authorization for policy downloads

2017-05-12 Thread Velmurugan Periasamy
Hi Colm: In kerberized environments, /service/plugins/secure/policies/download should be used for download and will be restricted to valid plugins as you pointed out. /service/plugins/policies will need to be protected by two way SSL and exists for backward compatibility. Thanks, Vel From: Colm

Re: Review Request 59245: RANGER-1577:Update Ranger-WASB servicedefinition to remove Execute permission and disallow policies with a trailing slash

2017-05-12 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59245/#review174879 --- Ship it! Ship It! - Velmurugan Periasamy On May 12, 2017

Re: Review Request 59255: Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install a

2017-05-13 Thread Velmurugan Periasamy
(patched) <https://reviews.apache.org/r/59255/#comment248132> Users can set RANGER_PID_DIR_PATH if they don't want to use default path. So what is the need for an additional variable? - Velmurugan Periasamy On May 13, 2017, 7:14 a.m., pengji

Re: Review Request 59272: WASB component : policy edit page is not opening.

2017-05-15 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59272/#review174950 --- Ship it! Ship It! - Velmurugan Periasamy On May 15, 2017, 2

Re: Please assign me to Ranger-1584

2017-05-18 Thread Velmurugan Periasamy
Hi Yujie: I have added you as contributor and assigned this JIRA to you. Thank you, Vel From: Yujie Li Reply-To: "dev@ranger.apache.org" Date: Thursday, May 18, 2017 at 4:04 PM To: "dev@ranger.apache.org" Subject: Please assign me to Ranger-1584 Hello, I opened a Jira here: https://is

Re: Review Request 59398: RANGER-1583 : Test connections are failing for plugins after upgrade

2017-05-19 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59398/#review175505 --- Ship it! Ship It! - Velmurugan Periasamy On May 19, 2017, 1

Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade

2017-05-19 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59335/#review175508 --- Ship it! Ship It! - Velmurugan Periasamy On May 19, 2017, 1

Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade

2017-05-19 Thread Velmurugan Periasamy
> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote: > > Ship It! > > Colm O hEigeartaigh wrote: > Are the concerns I raised above addressed in the latest patch? yes Colm, I see they are addressed. - Velmurugan

Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade

2017-05-19 Thread Velmurugan Periasamy
> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote: > > Ship It! > > Colm O hEigeartaigh wrote: > Are the concerns I raised above addressed in the latest patch? > > Velmurugan Periasamy wrote: > yes Colm, I see they are addressed. > > Colm O hE

Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade

2017-05-19 Thread Velmurugan Periasamy
> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote: > > Ship It! > > Colm O hEigeartaigh wrote: > Are the concerns I raised above addressed in the latest patch? > > Velmurugan Periasamy wrote: > yes Colm, I see they are addressed. > > Colm O hE

Re: Review Request 59479: RangerUI: Include / Exclude toggle not working for same level resources.

2017-05-23 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59479/#review175780 --- Ship it! Ship It! - Velmurugan Periasamy On May 23, 2017, 6

Re: Review Request 59487: Ranger service check failed on SLES11.3 cluster with sslv3 alert handshake failure

2017-05-23 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59487/#review175787 --- Ship it! Ship It! - Velmurugan Periasamy On May 23, 2017, 1

Re: Review Request 59603: RANGER-1612 : When servicedef is accessed, one of the properties "enableDenyAndExceptionsInPolicies" is returned as "false" if there is no value set for it.

2017-05-26 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59603/#review176189 --- Ship it! Ship It! - Velmurugan Periasamy On May 26, 2017

Re: Review Request 59631: RANGER-1622 - Error installing Knox plugin using KNOX_HOME

2017-05-31 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59631/#review176573 --- Ship it! Ship It! - Velmurugan Periasamy On May 29, 2017, 4

[VOTE] Release Apache Ranger 0.7.1 - release candidate 1 (dev group vote)

2017-06-01 Thread Velmurugan Periasamy
Hello Rangers: Apache Ranger 0.7.1 release candidate #1 is now available for a vote within dev community. Links to release artifacts are given below. Could you please review and vote? The vote will be open for at least 72 hours or until necessary number of votes are reached. [ ] +1 approve [

[RESULT] [VOTE] Release Apache Ranger 0.7.1 - release candidate 1 (dev group vote)

2017-06-06 Thread Velmurugan Periasamy
member(s): +1 Colm O hEigeartaigh +1 Gautam Borad +1 Madhanmohan Neethiraj +1 Ramesh Mani +1 Selvamohan Neethiraj +1 Velmurugan Periasamy Five +1 votes from the following non-PPMC member(s): +1 Abhay Kulkarni +1 Nitin Galave +1 Qiang Zhang +1 Sailaja Polavarapu +1 Srikanth Venkat Zero -1 votes: I

Re: svn commit: r19914 - in /release/ranger/0.7.1: ./ apache-ranger-0.7.1.tar.gz apache-ranger-0.7.1.tar.gz.asc apache-ranger-0.7.1.tar.gz.mds

2017-06-07 Thread Velmurugan Periasamy
Thanks Colm. I have removed 0.7.0 > On Jun 7, 2017, at 12:36 PM, Colm O hEigeartaigh wrote: > > Hi Vel, > > Don't forget to remove the "0.7.0" release from the dist as well (we should > only ever have the most recent branch release on the main dist server). > > Colm. > > On Wed, Jun 7, 2017

CVE update - fixed in Apache Ranger 0.7.1

2017-06-07 Thread Velmurugan Periasamy
. - Thank you, Velmurugan Periasamy

Re: Maven artifacts for 0.7.1

2017-06-08 Thread Velmurugan Periasamy
Colm: I have published it according to the steps listed here - https://cwiki.apache.org/confluence/display/RANGER/Publishing+Apache+Ranger+ artifacts+to+Maven+Central Thanks, Vel From: Colm O hEigeartaigh Reply-To: "dev@ranger.apache.org" , "cohei...@apache.org" Date: Thursday, June 8, 201

Re: Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls

2017-06-13 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60034/#review177727 --- Ship it! Ship It! - Velmurugan Periasamy On June 13, 2017

Re: Review Request 60080: Policies listed on 2nd page and on wards of Policy Landing page don't reflect any edits on them.

2017-06-14 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60080/#review177891 --- Ship it! Ship It! - Velmurugan Periasamy On June 14, 2017

Re: Review Request 58947: Ranger UI : Audit Menu-> Admin tab diff view pop-up does not come up.

2017-06-14 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58947/#review177892 --- Ship it! Ship It! - Velmurugan Periasamy On June 9, 2017, 2

Re: Review Request 58946: Ranger UI : Audit Menu-> Admin tab diff view pop-up does not come up.

2017-06-14 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58946/#review177893 --- Ship it! Ship It! - Velmurugan Periasamy On June 9, 2017, 3

Re: Review Request 60192: Proxying Ranger UI does not work with Ranger-KnoxSSO

2017-06-19 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60192/#review178219 --- Ship it! Ship It! - Velmurugan Periasamy On June 19, 2017

Re: Review Request 60195: Proxying Ranger UI does not work with Ranger-KnoxSSO

2017-06-19 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60195/#review178227 --- Ship it! Ship It! - Velmurugan Periasamy On June 19, 2017

Re: Could not setup range-admin 0.7.2, key was too long error

2017-06-19 Thread Velmurugan Periasamy
Hello Chaoran: This seems to be related to Mysql config. Try setting the below before running install script as mentioned here - https://stackoverflow.com/questions/8746207/1071-specified-key-was-too-long- max-key-length-is-1000-bytes SET @@global.innodb_large_prefix = 1; I am adding Ranger dev

Re: Could not setup range-admin 0.7.2, key was too long error

2017-06-20 Thread Velmurugan Periasamy
_large_prefix' What's the schema of the table i need to set for ranger-admin-0.7.1? It seems the stack overflow link is more of a general question of Specified key was too long; max key length is 1000 bytes. Do i need to modify the setup.sh script of ranger-admin-0.7.1 in order to achieve

Re: Review Request 60385: Ranger KMS should validate key name before importing into DB

2017-07-09 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60385/#review180007 --- Ship it! Ship It! - Velmurugan Periasamy On June 23, 2017

Re: Review Request 60144: RANGER-1638. Improve the password validation from Ranger API

2017-07-09 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60144/#review180008 --- Ship it! Ship It! - Velmurugan Periasamy On June 23, 2017

Re: Review Request 60706: Export Policy not working when Knox proxy is Enabled.

2017-07-09 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60706/#review180005 --- Ship it! Ship It! - Velmurugan Periasamy On July 7, 2017, 1

Re: Review Request 60043: Ranger KMS should validate key name before importing into DB

2017-07-09 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/#review180006 --- Ship it! Ship It! - Velmurugan Periasamy On June 22, 2017

Re: Review Request 60421: RANGER-1491 : Automatically map group of external users to Administrator Role

2017-07-09 Thread Velmurugan Periasamy
ed) <https://reviews.apache.org/r/60421/#comment255009> To be consistent, add prefix "ranger.usersync" to this new property - Velmurugan Periasamy On June 26, 2017, 8:01 a.m., bhavik patel wrote: > > --- > This

Re: Review Request 60733: RANGER-1681:Now ranger's kerberos configuration item relies directly on the configuration of the hadoop component. When the HDFS opens other functions such as HA, the test co

2017-07-10 Thread Velmurugan Periasamy
hbase-site.xml as required) and symlink them into ranger config folder. My suggestion is to not include this patch. - Velmurugan Periasamy On July 10, 2017, 7:02 a.m., pengjianhua wrote: > > --- > This is an automatically g

Re: Review Request 60746: RANGER-1683 - Fix the failing Kerberos tests on Jenkins

2017-07-10 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60746/#review180051 --- Ship it! Ship It! - Velmurugan Periasamy On July 10, 2017

Re: Review Request 60781: RANGER-1689:Add support for defining recursive policies for WASB service def

2017-07-11 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60781/#review180244 --- Ship it! Ship It! - Velmurugan Periasamy On July 11, 2017

Re: Review Request 60421: RANGER-1491 : Automatically map group of external users to Administrator Role

2017-07-18 Thread Velmurugan Periasamy
does not apply Checking patch unixauthservice/scripts/templates/ranger-ugsync-template.xml... Hunk #1 succeeded at 209 (offset 4 lines). - Velmurugan Periasamy On July 11, 2017, 5:52 a.m., bhavik patel wrote: > > --- > This i

Re: Review Request 61071: RANGER-1674 : IMPORT START audit is not appearing on audit page

2017-08-17 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61071/#review183119 --- Ship it! Ship It! - Velmurugan Periasamy On July 24, 2017

Re: Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

2017-08-21 Thread Velmurugan Periasamy
/RoleBaseUserSearchUtil.java Lines 48 (patched) <https://reviews.apache.org/r/61553/#comment259428> Add a unit test for this class? - Velmurugan Periasamy On Aug. 16, 2017, 11:49 a.m., Fatima Khan wrote: > > --- > This is a

Re: Review Request 61008: RANGER-1632: Fixed issue where Users are not sync'd when sAMAccountName is different than CN associated with groups

2017-08-21 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61008/#review183417 --- Ship it! Ship It! - Velmurugan Periasamy On July 20, 2017

Re: Review Request 61591: RANGER-1717 : User with "KEYADMIN" role is not able to see "Audit => Admin" logs

2017-08-21 Thread Velmurugan Periasamy
/XTrxLogService.java Line 33 (original), 33 (patched) <https://reviews.apache.org/r/61591/#comment259431> This patch does not apply to master branch. Please check and update the patch. - Velmurugan Periasamy On Aug. 11, 2017, 8:34 a.m., bhavik patel

Re: Review Request 61555: RANGER-1726 : Users are not getting deleted when Knox proxy is Enabled.

2017-08-21 Thread Velmurugan Periasamy
is done. security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java Lines 1076 (patched) <https://reviews.apache.org/r/61555/#comment259432> Minor change - no plural needed. it can be deleteSingleUserByUserName. - Velmurugan Periasamy On Aug. 10, 2017, 1:28 p.m., Nikhil P

Re: Review Request 61782: Similar to RANGER-1541, the assignment logic is inconsistent for the value of the RANGER_ADMIN_HOME variable in changeusernameutil.py and changepasswordutil.py. It will cause

2017-08-21 Thread Velmurugan Periasamy
), 34 (patched) <https://reviews.apache.org/r/61782/#comment259435> Can you please confirm this is tested on both linux and windows after the patch? - Velmurugan Periasamy On Aug. 21, 2017, 2:05 p.m., Qiang Zhang wrote: > > --

Re: Review Request 61025: Good coding practice in Ranger recommended by static code analysis

2017-08-21 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61025/#review183423 --- Ship it! Ship It! - Velmurugan Periasamy On July 21, 2017

Re: Review Request 61421: RANGER-1724: On Report listing page for masking/row filter policies show only mask/row filter conditions.

2017-08-21 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61421/#review183424 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 21, 2017

Re: Review Request 61778: RANGER-1676: Policy Details popup from Access audit page not displaying details of masking policy.

2017-08-21 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61778/#review183425 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 21, 2017

Re: Review Request 61776: RANGER-1724: On Report listing page for masking/row filter policies show only mask/row filter conditions.

2017-08-21 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61776/#review183426 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 21, 2017

Re: Review Request 61779: RANGER-1676: Policy Details popup from Access audit page not displaying details of masking policy.

2017-08-21 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61779/#review183427 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 21, 2017

Re: Review Request 61591: RANGER-1717 : User with "KEYADMIN" role is not able to see "Audit => Admin" logs

2017-08-23 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61591/#review183683 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 22, 2017

Re: Review Request 61555: RANGER-1726 : Users are not getting deleted when Knox proxy is Enabled.

2017-08-23 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61555/#review183682 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 22, 2017

Re: Review Request 61845: RANGER-1748 : User is unable to update existing policy while importing policy from file

2017-08-23 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61845/#review183684 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 23, 2017

Re: Review Request 61848: RANGER-1748 : User is unable to update existing policy while importing policy from file

2017-08-23 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61848/#review183685 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 23, 2017

Re: Review Request 61685: RANGER-1717 : User with "KEYADMIN" role is not able to see "Audit => Admin" logs

2017-08-23 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61685/#review183686 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 16, 2017

Re: Review Request 61782: Similar to RANGER-1541, the assignment logic is inconsistent for the value of the RANGER_ADMIN_HOME variable in changeusernameutil.py and changepasswordutil.py. It will cause

2017-08-23 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61782/#review183687 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 21, 2017

Re: Review Request 61909: RANGER-1752 When "dfs.nameservices" configures multiple nameservice id and then test hdfs connection, verifying "dfs.client.failover.proxy.provider.[dfs.nameservices]" is inc

2017-08-25 Thread Velmurugan Periasamy
eature working fine. - Velmurugan Periasamy On Aug. 25, 2017, 3:09 a.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 61909: RANGER-1752 When "dfs.nameservices" configures multiple nameservice id and then test hdfs connection, verifying "dfs.client.failover.proxy.provider.[dfs.nameservices]" is inc

2017-08-28 Thread Velmurugan Periasamy
> On Aug. 25, 2017, 7:44 p.m., Velmurugan Periasamy wrote: > > hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java > > Line 289 (original), 289 (patched) > > <https://reviews.apache.org/r/61909/diff/1/?file=1803391#file1803391line289> >

Re: Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

2017-08-28 Thread Velmurugan Periasamy
[ERROR] /Users/vperiasamy/git/tlp-ranger/ranger-0.7/ranger/security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBaseUserSearchUtil.java:[48,9] error: cannot find symbol ``` - Velmurugan Periasamy On Aug. 24, 2017, 4:31 a.m., Fatima Khan

Re: Review Request 62023: RANGER-1735: Support representing nested group memberships in Ranger Admin

2017-09-07 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62023/#review184867 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 7, 2017

Re: Review Request 62172: RANGER-1735: Support representing nested group memberships in Ranger Admin --ranger-0.7 branch

2017-09-07 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62172/#review184888 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 7, 2017

Re: Review Request 62074: RANGER-1765 : Add unique key constraint in x_group and x_group_users table

2017-09-07 Thread Velmurugan Periasamy
error: security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql: patch does not apply Checking patch security-admin/db/sqlserver/patches/028-add-unique-constraint-on-table-x_group.sql... ``` - Velmurugan Periasamy On Sept. 5, 2017, 6:24 a.m., bhavik patel w

Re: Review Request 62074: RANGER-1765 : Add unique key constraint in x_group and x_group_users table

2017-09-08 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62074/#review185000 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 8, 2017

Re: Review Request 62181: RANGER-1765 : Add unique key constraint in x_group and x_group_users table

2017-09-08 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62181/#review185001 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 8, 2017

Re: Review Request 62029: In Nifi default policy is getting created with policyitem without any user/group but permission is set for the same

2017-09-08 Thread Velmurugan Periasamy
/ranger/biz/ServiceDBStore.java Lines 2544 (patched) <https://reviews.apache.org/r/62029/#comment261236> Wouldn't it be helpful to log this at WARN level? - Velmurugan Periasamy On Sept. 1, 2017, 2 p.m., Nikhil P wrote: > > -

Re: Review Request 62078: Update NiFi service def and handle upgrade scenario.

2017-09-08 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62078/#review185006 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 8, 2017

Re: Review Request 62080: Update NiFi service def and handle upgrade scenario.

2017-09-08 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62080/#review185007 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 8, 2017

Re: Hive Plugin on Hive Resource of url and Permissions of read and write on Ranger 0.7.0 version.

2017-09-11 Thread Velmurugan Periasamy
Hello: URL resource is applicable for only S3. I am adding Ranger dev list. Could you please post questions to dev@ranger.apache.org? Thank you, Velmurugan Periasamy > On Sep 11, 2017, at 4:34 AM, lilisong(宋丽丽) wrote: > > Hello,Eveyone! > > I have some problems ab

Re: Request to make me contributor in Apache Ranger

2017-09-12 Thread Velmurugan Periasamy
I have added you as contributor. Welcome. From: "wang.yua...@zte.com.cn" Reply-To: "dev@ranger.apache.org" Date: Tuesday, September 12, 2017 at 2:22 AM To: "dev@ranger.apache.org" Subject: Request to make me contributor in Apache Ranger hi: My ID is wangyuan,please add My ID . Regard

Re: Review Request 62325: The logical of the policy details for Ranger Hive Plugin is error.

2017-09-14 Thread Velmurugan Periasamy
/PermissionList.js Lines 818 (patched) <https://reviews.apache.org/r/62325/#comment261728> It would be better to seek a generic solution. - Velmurugan Periasamy On Sept. 14, 2017, 10:41 a.m., pengjianhua wrote: > > --- > This is a

Re: Review Request 62313: RANGER-1647: Allow Ranger policy conditions to use tag attributes and values in Ranger -- ranger0.7 branch

2017-09-14 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62313/#review185416 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 13, 2017

Re: Review Request 62328: RANGER-1682: Clicking on export service after session timeout gets stuck indefinitely.

2017-09-14 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62328/#review185418 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 14, 2017

Re: Review Request 62374: RANGER-1786: Need warning on external user role change.

2017-09-18 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62374/#review185562 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 18, 2017

Re: Review Request 62375: RANGER-1787: User has to fill up all the allow and deny conditions items to create a knox policy.

2017-09-18 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62375/#review185563 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 18, 2017

Re: Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

2017-09-18 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61553/#review185568 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 15, 2017

Re: Review Request 62024: RANGER-1756: Handle role related restrictions for users having User role.

2017-09-20 Thread Velmurugan Periasamy
EST.java:357) at org.apache.ranger.rest.TestXUserREST.test24searchXUsers(TestXUserREST.java:517) ``` - Velmurugan Periasamy On Sept. 20, 2017, 10:25 a.m., Nitin Galave wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 62024: RANGER-1756: Handle role related restrictions for users having User role.

2017-09-26 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62024/#review186269 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 25, 2017

Re: Review Request 62538: Good coding practice in Ranger recommended by static code analysis

2017-09-26 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62538/#review186271 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 26, 2017

Re: Review Request 62519: RANGER-1800: Usersync fails to update users and groups during incremental sync with nested groups and group first search enabled

2017-09-26 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62519/#review186314 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 22, 2017

Re: Review Request 62555: RANGER-1801: group user mapping updates to ranger admin fail when the mapping is already existed in ranger DB

2017-09-26 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62555/#review186329 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 26, 2017

Re: Review Request 62567: RANGER-1727 : Ranger allows user to change an external user's password with 'null' old password

2017-09-27 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62567/#review186417 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 26, 2017

Re: Review Request 62024: RANGER-1756: Handle role related restrictions for users having User role.

2017-09-27 Thread Velmurugan Periasamy
/hadoop/security/SecureClientLogin.java Line 74 (original), 74 (patched) <https://reviews.apache.org/r/62024/#comment262976> Fix PMD violation - Avoid unused local variable - Velmurugan Periasamy On Sept. 27, 2017, 11:27 a.m., Nitin Galave

Re: Review Request 62436: RANGER-1779 : last resource gets duplicated during update policy if policy is created through public api rest call

2017-09-27 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62436/#review186462 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 27, 2017

Re: Review Request 62437: RANGER-1779 : last resource gets duplicated during update policy if policy is created through public api rest call

2017-09-27 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62437/#review186463 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 27, 2017

Re: Review Request 62717: RANGER-1820: Duplicate entries should be deleted before creation of unique index on x_group and x_group_users table

2017-10-02 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62717/#review186849 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 30, 2017

Re: Review Request 62714: RANGER-1819: Not able to delete group that is having special character(ampersand) from ranger admin.

2017-10-02 Thread Velmurugan Periasamy
sed methods don't have to change. - Velmurugan Periasamy On Sept. 30, 2017, 11:26 a.m., Nitin Galave wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 62713: RANGER 1818: Good coding practice in Ranger recommended by static code analysis

2017-10-02 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62713/#review186852 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 30, 2017

Re: Review Request 62495: RANGER-1797:Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.81.

2017-10-04 Thread Velmurugan Periasamy
min and SSL/Kerberos for Ranger KMS - Velmurugan Periasamy On Sept. 22, 2017, 8:35 a.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 62841: RANGER-1826: Import of bulk policies is causing OutOfMemoryError and Apparent Deadlock

2017-10-09 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62841/#review187492 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 10, 2017

Re: Review Request 62724: RANGER-1822 - Remove ssoEnabled accessors in RangerSSOAuthenticationFilter

2017-10-10 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62724/#review187609 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 2, 2017, 2

<    1   2   3   4   5   6   7   8   9   10   >