Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68268/ --- (Updated Aug. 8, 2018, 10:36 p.m.) Review request for sentry, Arjun Mishra, kal

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68268/ --- (Updated Aug. 8, 2018, 10:10 p.m.) Review request for sentry, Arjun Mishra, kal

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

> On Aug. 8, 2018, 7:25 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Lines 1577 (patched) > > > > > > should this

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

> On Aug. 8, 2018, 9:12 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java > > Lines 169 (patched) > > > > > > This function c

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

> On Aug. 8, 2018, 7:25 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Line 1396 (original), 1336 (patched) > > > > > >

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

> On Aug. 8, 2018, 3:46 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Line 1619 (original), 1571 (patched) > >

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

> On Aug. 8, 2018, 3:46 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Lines 1503 (patched) > > > > > > Can

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68268/ --- (Updated Aug. 8, 2018, 2:29 p.m.) Review request for sentry, Arjun Mishra, kaly

Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68268/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. Bu

Re: Review Request 68249: SENTRY-2255: alter table set owner command can be executed only by user with proper privilege

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68249/#review206955 --- Looks good. - Sergio Pena On Aug. 7, 2018, 2:14 a.m., Na Li wro

Re: Review Request 68028: SENTRY-2316: Rename any 'entity' word for 'principal' to be consistent with Hive principal name and type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68028/#review206884 --- Ship it! Thanks Arjun. The change looks good. I built it and te

Re: Review Request 67888: SENTRY-2308: Create privilege on table has no use case

> On July 12, 2018, 2:49 p.m., Arjun Mishra wrote: > > Sergio, I think this method "checkAllowedGrantPrivileges()" can be > > incorporated in method "analyzePrivilegeListDef()" where we are currently > > checking for similar imperssible grants like only select on column and so > > on. I need

Re: Review Request 67888: SENTRY-2308: Create privilege on table has no use case

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67888/ --- (Updated July 13, 2018, 6:45 p.m.) Review request for sentry and Arjun Mishra.

Re: Review Request 67888: SENTRY-2308: Create privilege on table has no use case

> On July 12, 2018, 2:53 p.m., Arjun Mishra wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Line 550 (original), 558 (patched) > > >

Re: Review Request 67912: SENTRY-2310: Sentry is not be able to fetch full update subsequently, when there is HMS restart in the snapshot process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67912/#review206062 --- Fix it, then Ship it! The patch looks good. I'd like to see a b

Re: Review Request 67899: SENTRY-2299: NPE In Sentry HDFS Sync Plugin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67899/#review206033 --- Ship it! Ship It! - Sergio Pena On July 12, 2018, 9:14 p.m.,

Review Request 67888: SENTRY-2308: Create privilege on table has no use case

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67888/ --- Review request for sentry and Arjun Mishra. Bugs: sentry-2308 https://issue

Re: Review Request 67879: SENTRY-2309: Add relevant full snapshot timeline messages to std.out

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67879/#review205975 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Re: Review Request 67803: SENTRY-2247: Add e2e tests to verify owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67803/#review205743 --- Ship it! Ship It! - Sergio Pena On July 3, 2018, 9:20 p.m.,

Re: Review Request 67774: SENTRY-2289: Tests in TestHDFSIntegrationAdvanced fail from time to time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67774/#review205585 --- Ship it! Ship It! - Sergio Pena On June 28, 2018, 9:41 p.m.,

Review Request 67790: SENTRY-2294: Add requestorUsername to client.notifyHmsEvent() method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67790/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. Bu

Review Request 67771: SENTRY-2285: Add a profile '-Pdist' to package Sentry binaries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67771/ --- Review request for sentry, Colm O hEigeartaigh and kalyan kumar kalvagadda. Bug

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

> On June 27, 2018, 6:15 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 4729 (patched) > > > > > > I thin

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

> On June 27, 2018, 6:15 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 4729 (patched) > > > > > > I thin

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67759/ --- (Updated June 27, 2018, 7:33 p.m.) Review request for sentry, Arjun Mishra, kal

Re: Review Request 67749: SENTRY-2280: The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67749/#review205465 --- Ship it! Ship It! - Sergio Pena On June 27, 2018, 7:13 p.m.,

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

> On June 27, 2018, 5 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java > > Lines 311 (patched) > > > > > > Sergio, mayb

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

> On June 27, 2018, 5:43 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java > > Lines 312 (patched) > > > > > > Also we c

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

> On June 27, 2018, 6:13 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryPrivilegesResponse.java > > Lines 59 (patched) > > > > > >

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

> On June 27, 2018, 6:15 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 4729 (patched) > > > > > > I thin

Re: Review Request 67749: SENTRY-2280: The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67749/#review205451 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER task for Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67745/#review205450 --- Ship it! Ship It! - Sergio Pena On June 27, 2018, 4:30 p.m.,

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67759/ --- (Updated June 27, 2018, 4:49 p.m.) Review request for sentry, Arjun Mishra, kal

Re: Review Request 67646: SENTRY-2272: Fix the sentry store logic for listing user privileges

> On June 27, 2018, 1:08 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 232-234 (patched) > > >

Re: Review Request 67747: SENTRY-2282: Remove hive-authzv2 binding and tests modules completely

> On June 27, 2018, 3:18 p.m., Na Li wrote: > > was the hive-authz copied from hive-authzv2? If not, it is better to save > > hive-authzv2 in a backup branch just in case, and then remove it. All the hive-authzv2 is already on hive-authz. The copy on on branch-2 too, so there is no need to kee

Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67759/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. Bu

Re: Review Request 67747: SENTRY-2282: Remove hive-authzv2 binding and tests modules completely

> On June 27, 2018, 12:55 p.m., kalyan kumar kalvagadda wrote: > > Did you make sure to see of these tests can be moved to sentry-binding-hive? Yes, I did. There are no new tests, so it is safely to remove. - Sergio --- This is an autom

Re: Review Request 67646: SENTRY-2272: Fix the sentry store logic for listing user privileges

> On June 27, 2018, 1:08 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 230 (patched) > > > > >

Re: Review Request 67749: SENTRY-2280: The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67749/#review205392 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Review Request 67747: SENTRY-2282: Remove hive-authzv2 binding and tests modules completely

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67747/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. Bu

Re: Review Request 67746: SENTRY-2281: list_privileges_by_user() fails with a JDODetachedFieldAccessException

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67746/#review205382 --- Ship it! Ship It! - Sergio Pena On June 26, 2018, 5:02 p.m.,

Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER task for Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67745/#review205372 --- Ship it! Ship It! - Sergio Pena On June 26, 2018, 2:55 p.m.,

Re: Review Request 67218: SENTRY-2238: Explicitly set Database on SentryHivePrivilegeObjectDesc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67218/#review205369 --- Ship it! Ship It! - Sergio Pena On June 26, 2018, 12:18 a.m.

Re: Review Request 67539: SENTRY-2264: It is possible to elevate privileges from DROP using alter table rename

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67539/#review205368 --- Ship it! Ship It! - Sergio Pena On June 26, 2018, 4:36 a.m.,

Re: Review Request 67648: SENTRY-2251: Update user privileges based on changes to authorizables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67648/#review205246 --- Ship it! Ship It! - Sergio Pena On June 21, 2018, 9:28 p.m.,

Re: Review Request 67649: SENTRY-2274: Grant and revoke owner privileges based on HMS updates(server-side)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67649/#review205209 --- Ship it! Ship It! - Sergio Pena On June 21, 2018, 5:42 p.m.,

Re: Review Request 67646: SENTRY-2272: Fix the sentry store logic for listing user privileges

> On June 20, 2018, 4:04 p.m., Arjun Mishra wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 235 (patched) > > > > > > Shou

Re: Review Request 67690: SENTRY-2231: Fix URI check on List Privileges by Provider in SentryStore

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67690/#review205181 --- Ship it! Looks good. I see this same filter is used on getMSent

Re: Review Request 67692: SENTRY-2199: Bump Hive version from 2.3.2 to 2.3.3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67692/#review205179 --- Ship it! Ship It! - Sergio Pena On June 21, 2018, 3:47 p.m.,

Re: Review Request 67648: SENTRY-2251: Update user privileges based on changes to authorizables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67648/#review205088 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/#review205035 --- Ship it! Ship It! - Sergio Pena On June 19, 2018, 7:46 p.m.,

Re: Review Request 67648: SENTRY-2251: Update user privileges based on changes to authorizables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67648/#review205034 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 67649: SENTRY-2274: Grant and revoke owner privileges based on HMS updates(server-side)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67649/#review205033 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 67650: SENTRY-2275: Grant and revoke owner privileges based on HMS updates(client-side)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67650/#review205030 --- Ship it! Ship It! - Sergio Pena On June 19, 2018, 9:11 p.m.,

Re: Review Request 67652: SENTRY-2271: Wrong message seen when db upgrade failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67652/#review205029 --- Ship it! Ship It! - Sergio Pena On June 19, 2018, 9:52 p.m.,

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/#review205021 --- It looks good. Thanks. - Sergio Pena On June 19, 2018, 7:46 p.m

Re: Review Request 67650: SENTRY-2275: Grant and revoke owner privileges based on HMS updates(client-side)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67650/#review205019 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Re: Review Request 67648: SENTRY-2251: Update user privileges based on changes to authorizables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67648/#review205014 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 67652: SENTRY-2271: Wrong message seen when db upgrade failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67652/#review205004 --- Ship it! Ship It! - Sergio Pena On June 19, 2018, 4:25 p.m.,

Review Request 67646: SENTRY-2272: Fix the sentry store logic for listing user privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67646/ --- Review request for sentry, Arjun Mishra and kalyan kumar kalvagadda. Bugs: sent

Review Request 67637: SENTRY-2265: Translate owner privilege in sentry binding for authorization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67637/ --- Review request for sentry and kalyan kumar kalvagadda. Bugs: sentry-2265 ht

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/#review204955 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Re: Review Request 67560: SENTRY-2241: Extend the Sync Listener to pass owner information to sentry server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67560/#review204935 --- I think we should start thinking on splitting this patch into two,

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/#review204880 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/#review204851 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Review Request 67588: SENTRY-2270: Illegal privileges on columns can be granted on Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67588/ --- Review request for sentry, Arjun Mishra and kalyan kumar kalvagadda. Bugs: sent

Re: Review Request 67560: SENTRY-2241: Extend the Sync Listener to pass owner information to sentry server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67560/#review204720 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Re: Review Request 67539: SENTRY-2264: It is possible to elevate privileges from DROP using alter table rename

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67539/#review204713 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Re: Review Request 67555: SENTRY-2267: Listing user privileges fails because roleName field is required on Thrift

> On June 12, 2018, 6:58 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java > > Lines 270 (patched) > > > > > >

Review Request 67555: SENTRY-2267: Listing user privileges fails because roleName field is required on Thrift

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67555/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. Bu

Re: Review Request 67527: SENTRY-2262: Sentry client is not compatible when connecting to Sentry 2.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67527/ --- (Updated June 12, 2018, 4:27 p.m.) Review request for sentry and Na Li. Bugs:

Re: Review Request 67528: SENTRY-2056: Display test-patch.py output on the standard console to see progress on Jenkins

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67528/#review204600 --- Ship it! Ship It! - Sergio Pena On June 11, 2018, 4:18 p.m.,

Re: Review Request 67452: SENTRY-2257: Implement Sentry store API to update owner privilege on a authorizable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67452/#review204552 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 67218: SENTRY-2238: Add support for DATABASE in show grant on command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67218/#review204545 --- I noticed that there are test cases for SHOW GRANT ROLE ON DATABAS

Review Request 67527: SENTRY-2262: Sentry client is not compatible when connecting to Sentry 2.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67527/ --- Review request for sentry and Na Li. Bugs: SENTRY-2262 https://issues.apach

Re: Review Request 67506: SENTRY-2260: Update HDFS ACL's based on owner privileges.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67506/#review204543 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Re: Review Request 67481: SENTRY-2259: SQL CONSTRAINT name for user privilege is too long for Oracle 11.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67481/#review204462 --- Ship it! Ship It! - Sergio Pena On June 7, 2018, 8:40 p.m.,

Re: Review Request 67447: SENTRY-2162: Retrieve and list user privileges for authorization

> On June 6, 2018, 6:57 p.m., kalyan kumar kalvagadda wrote: > > sentry-service/sentry-service-api/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyServiceClientDefaultImpl.java > > Lines 43 (patched) > >

Re: Review Request 67442: SENTRY-2258: Remove user when it is not associated with other objects

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67442/#review204405 --- Ship it! Ship It! - Sergio Pena On June 5, 2018, 9:17 p.m.,

Re: Review Request 67447: SENTRY-2162: Retrieve and list user privileges for authorization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67447/ --- (Updated June 6, 2018, 5:22 p.m.) Review request for sentry, kalyan kumar kalva

Re: Review Request 67400: SENTRY-2245: Remove privileges that do not associate with a role or a user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67400/#review204394 --- Ship it! Ship It! - Sergio Pena On June 5, 2018, 9:58 p.m.,

Re: Review Request 67402: SENTRY-2244: Alter sentry role or user at granting privilege can avoid extra query to database

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67402/#review204348 --- Ship it! Ship It! - Sergio Pena On June 4, 2018, 3:29 a.m.,

Re: Review Request 67452: SENTRY-2257: Implement Sentry store API to update owner privilege on a authorizable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67452/#review204340 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 67440: SENTRY-2158: Update notification handler to update privileges to user

> On June 4, 2018, 9:33 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/NotificationHandler.java > > Lines 74 (patched) > > > > > > I'm concerned about

Re: Review Request 67400: SENTRY-2245: Remove privileges that do not associate with a role or a user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67400/#review204333 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Review Request 67447: SENTRY-2162: Retrieve and list user privileges for authorization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67447/ --- Review request for sentry, kalyan kumar kalvagadda and Na Li. Bugs: SENTRY-2162

Re: Review Request 67440: SENTRY-2158: Update notification handler to update privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67440/#review204278 --- sentry-service/sentry-service-api/src/main/java/org/apache/sentry

Re: Review Request 67419: SENTRY-2256: Make thrift API changes to get user privileges from Sentry

> On June 4, 2018, 5:02 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Lines 840 (patched) > > > > > > should you pu

Re: Review Request 67419: SENTRY-2256: Make thrift API changes to get user privileges from Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67419/ --- (Updated June 4, 2018, 5:08 p.m.) Review request for sentry, kalyan kumar kalva

Re: Review Request 67419: SENTRY-2256: Make thrift API changes to get user privileges from Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67419/ --- (Updated June 4, 2018, 4:09 p.m.) Review request for sentry, kalyan kumar kalva

Re: Review Request 67419: SENTRY-2256: Make thrift API changes to get user privileges from Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67419/ --- (Updated June 4, 2018, 4:08 p.m.) Review request for sentry, kalyan kumar kalva

Re: Review Request 67400: SENTRY-2245: Remove privileges that do not associate with a role or a user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67400/#review204203 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 67419: SENTRY-2256: Make thrift API changes to get user privileges from Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67419/ --- (Updated June 1, 2018, 8:50 p.m.) Review request for sentry, kalyan kumar kalva

Review Request 67419: SENTRY-2256: Make thrift API changes to get user privileges from Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67419/ --- Review request for sentry, kalyan kumar kalvagadda and Na Li. Bugs: SENTRY-2256

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/#review204197 --- Ship it! Ship It! - Sergio Pena On June 1, 2018, 6:13 p.m.,

Re: Review Request 67402: SENTRY-2244: alterSentryRoleGrantPrivilegeCore can avoid extra query to Database

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67402/#review204152 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 67402: SENTRY-2244: alterSentryRoleGrantPrivilegeCore can avoid extra query to Database

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67402/#review204151 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 67293: SENTRY-2243: Extend the thrift definition for policy service to learn owner information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67293/#review204051 --- Ship it! Ship It! - Sergio Pena On May 29, 2018, 8:32 p.m.,

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67093/#review203983 --- Ship it! All changes look good. I see several of them are just

Re: Review Request 67293: SENTRY-2243: Extend the thrift definition for policy service to learn owner information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67293/#review203899 --- sentry-service/sentry-service-api/src/main/resources/sentry_polic

<    1   2   3   4   >