Re: Review Request 67646: SENTRY-2272: Fix the sentry store logic for listing user privileges

> On June 27, 2018, 1:08 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 230 (patched) > > > >

Re: Review Request 67646: SENTRY-2272: Fix the sentry store logic for listing user privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67646/#review205426 ---

Re: Review Request 67747: SENTRY-2282: Remove hive-authzv2 binding and tests modules completely

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67747/#review205425 --- Did you make sure to see of these tests can be moved to

Re: Review Request 67749: SENTRY-2280: The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67749/#review205423 ---

Re: Review Request 67749: SENTRY-2280: The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67749/#review205391 --- Fix it.

Re: Review Request 67539: SENTRY-2264: It is possible to elevate privileges from DROP using alter table rename

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67539/#review205315 --- Sentry should be able to differenciate if the just table rename

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67658/#review205297 --- Ship it! Ship It! - kalyan kumar kalvagadda On June 22,

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

> On June 25, 2018, 4:23 p.m., Fahd Siddiqui wrote: > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDBUpdateForwarder.java > > Line 52 (original), 52 (patched) > > > > > > It did cause

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67658/#review205290 ---

Re: Review Request 67180: SENTRY-2235: Add hive tests to verify column privileges for views

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67180/#review205287 ---

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67658/#review205240 --- Ship it! Looks Good. - kalyan kumar kalvagadda On June 22,

Re: Review Request 67695: SENTRY-2277: Add to SentryStore testURI test case testing with multiple URI privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67695/#review205212 --- Arjun, Can you explian what was wrong with old test case? -

Re: Review Request 67648: SENTRY-2251: Update user privileges based on changes to authorizables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67648/ --- (Updated June 21, 2018, 9:28 p.m.) Review request for sentry, Arjun Mishra, Na

Re: Review Request 67690: SENTRY-2231: Fix URI check on List Privileges by Provider in SentryStore

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67690/#review205206 --- Code change looks good. API "getMSentryPrivileges" which is been

Re: Review Request 67691: SENTRY-2209: Incorrect class in SentryHdfsMetricsUtil.java

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67691/#review205201 --- Ship it! Looks Good. - kalyan kumar kalvagadda On June 21,

Re: Review Request 67649: SENTRY-2274: Grant and revoke owner privileges based on HMS updates(server-side)

> On June 19, 2018, 10:38 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Lines 1453 (patched) > > > > > >

Re: Review Request 67649: SENTRY-2274: Grant and revoke owner privileges based on HMS updates(server-side)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67649/ --- (Updated June 21, 2018, 5:42 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67648: SENTRY-2251: Update user privileges based on changes to authorizables

> On June 20, 2018, 2:12 p.m., Arjun Mishra wrote: > > Looks good. Have asked for some clarification. I responded to them. - kalyan kumar --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

> On June 20, 2018, 4:32 p.m., kalyan kumar kalvagadda wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java > > Lines 57-81 (patched) > >

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67658/#review205095 ---

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67658/#review205093 --- Fix it

Re: Review Request 67649: SENTRY-2274: Grant and revoke owner privileges based on HMS updates(server-side)

> On June 19, 2018, 10:38 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Lines 1386 (patched) > > > > > >

Re: Review Request 67648: SENTRY-2251: Update user privileges based on changes to authorizables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67648/ --- (Updated June 20, 2018, 1:27 p.m.) Review request for sentry, Arjun Mishra, Na

Re: Review Request 67648: SENTRY-2251: Update user privileges based on changes to authorizables

> On June 19, 2018, 6:47 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 797 (patched) > > > > > > Why

Re: Review Request 67648: SENTRY-2251: Update user privileges based on changes to authorizables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67648/ --- (Updated June 19, 2018, 10:22 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 67650: SENTRY-2275: Grant and revoke owner privileges based on HMS updates(client-side)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67650/ --- (Updated June 19, 2018, 9:11 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67637: SENTRY-2265: Translate owner privilege in sentry binding for authorization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67637/#review205009 --- Ship it! Looks good. - kalyan kumar kalvagadda On June 18,

Re: Review Request 67650: SENTRY-2241: Extend the Sync Listener to pass owner information to sentry server.(client side)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67650/ --- (Updated June 19, 2018, 4:13 p.m.) Review request for sentry, Na Li and Sergio

Review Request 67650: SENTRY-2241: Extend the Sync Listener to pass owner information to sentry server.(client side)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67650/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2241

Review Request 67649: SENTRY-2241: Extend the Sync Listener to pass owner information to sentry server.(server side)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67649/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2241

Re: Review Request 67560: SENTRY-2241: Extend the Sync Listener to pass owner information to sentry server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67560/ --- (Updated June 19, 2018, 3:43 p.m.) Review request for sentry, Arjun Mishra, Na

Review Request 67648: SENTRY-2251: Update user privileges based on changes to authorizables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67648/ --- Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. Bugs:

Re: Review Request 67560: SENTRY-2241: Extend the Sync Listener to pass owner information to sentry server.

> On June 13, 2018, 7:51 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 101-109 (patched) > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/#review204870 ---

Re: Review Request 67560: SENTRY-2241: Extend the Sync Listener to pass owner information to sentry server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67560/ --- (Updated June 15, 2018, 8:41 p.m.) Review request for sentry, Arjun Mishra, Na

Review Request 67560: SENTRY-2241: Extend the Sync Listener to pass owner information to sentry server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67560/ --- Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. Repository:

Re: Review Request 67539: SENTRY-2264: It is possible to elevate privileges from DROP using alter table rename

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67539/#review204605 ---

Re: Review Request 67506: SENTRY-2260: Update HDFS ACL's based on owner privileges.

> On June 11, 2018, 2:57 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermDeltaRetriever.java > > Lines 70-74 (patched) > > > > > > I don't feel necessary to do

Review Request 67528: SENTRY-2056: Display test-patch.py output on the standard console to see progress on Jenkins

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67528/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2056

Re: Review Request 67452: SENTRY-2257: Implement Sentry store API to update owner privilege on a authorizable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67452/ --- (Updated June 11, 2018, 3:41 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67477: SENTRY-2252: Normalize the Sentry store API's to handle both user/role privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67477/ --- (Updated June 8, 2018, 8:12 p.m.) Review request for sentry, Na Li and Sergio

Review Request 67506: SENTRY-2260: Update HDFS ACL's based on owner privileges.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67506/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2260

Re: Review Request 66336: SENTRY-2190: Have verbose debug logs in CounterWait class

> On March 29, 2018, 8:41 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java > > Lines 191 (patched) > > > > > > can you put the

Re: Review Request 67481: SENTRY-2259: SQL CONSTRAINT name for user privilege is too long for Oracle 11.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67481/#review204466 --- Ship it! Ship It! - kalyan kumar kalvagadda On June 7,

Re: Review Request 67452: SENTRY-2257: Implement Sentry store API to update owner privilege on a authorizable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67452/ --- (Updated June 7, 2018, 8:51 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67452: SENTRY-2257: Implement Sentry store API to update owner privilege on a authorizable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67452/ --- (Updated June 7, 2018, 4:54 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67452: SENTRY-2257: Implement Sentry store API to update owner privilege on a authorizable

> On June 6, 2018, 7:26 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 3004 (patched) > > > > > > You can

Re: Review Request 67452: SENTRY-2257: Implement Sentry store API to update owner privilege on a authorizable

> On June 6, 2018, 7:41 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 1978 (patched) > > > > > > it seems

Re: Review Request 67452: SENTRY-2257: Implement Sentry store API to update owner privilege on a authorizable

> On June 6, 2018, 7:42 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 2002 (patched) > > > > > > YOu want

Re: Review Request 67442: SENTRY-2258: Remove user when it is not associated with other objects

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67442/#review204414 --- Ship it! Look good. - kalyan kumar kalvagadda On June 5,

Re: Review Request 65866: SENTRY-2146: Add better error handling to ResourceAuthorizationProvider and improve logging in related classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65866/#review204413 --- I understand that we are trying to improve logging but adding

Re: Review Request 67447: SENTRY-2162: Retrieve and list user privileges for authorization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67447/#review204411 ---

Re: Review Request 67452: SENTRY-2257: Implement Sentry store API to update owner privilege on a authorizable

> On June 5, 2018, 7:40 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 865 (patched) > > > > > > There

Re: Review Request 67452: SENTRY-2257: Implement Sentry store API to update owner privilege on a authorizable

> On June 5, 2018, 8:16 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 865 (patched) > > > > > > Is the function

Re: Review Request 67402: SENTRY-2244: Alter sentry role or user at granting privilege can avoid extra query to database

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67402/#review204407 --- Ship it! Looks good. - kalyan kumar kalvagadda On June 4,

Review Request 67477: SENTRY-2252: Normalize the Sentry store API's to handle both user/role privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67477/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2252

Re: Review Request 67452: SENTRY-2257: Implement Sentry store API to update owner privilege on a authorizable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67452/ --- (Updated June 6, 2018, 4:01 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67402: SENTRY-2244: Alter sentry role or user at granting privilege can avoid extra query to database

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67402/#review204350 ---

Re: Review Request 67452: SENTRY-2257: Implement Sentry store API to update owner privilege on a authorizable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67452/ --- (Updated June 5, 2018, 7:34 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67447: SENTRY-2162: Retrieve and list user privileges for authorization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67447/#review204335 --- Code change looks good. Please add unit tests.

Re: Review Request 67400: SENTRY-2245: Remove privileges that do not associate with a role or a user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67400/#review204329 --- Ship it! Ship It! - kalyan kumar kalvagadda On June 4,

Re: Review Request 67452: SENTRY-2257: Implement Sentry store API to update owner privilege on a authorizable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67452/ --- (Updated June 5, 2018, 6:11 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67442: SENTRY-2258: Remove user when it is not associated with other objects

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67442/#review204326 ---

Review Request 67452: SENTRY-2257: Implement Sentry store API to update owner privilege on a authorizable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67452/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2257

Re: Review Request 67440: SENTRY-2158: Update notification handler to update privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67440/#review204283 --- I'm fine with the changes. - kalyan kumar kalvagadda On June

Re: Review Request 67400: SENTRY-2245: Remove privileges that do not associate with a role or a user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67400/#review204136 ---

Re: Review Request 67293: SENTRY-2243: Extend the thrift definition for policy service to learn owner information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67293/ --- (Updated May 31, 2018, 12:11 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67325: SENTRY-2246: Construct owner privilege (TSentryPrivilege)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67325/ --- (Updated May 29, 2018, 8:37 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67325: SENTRY-2246: Construct owner privilege (TSentryPrivilege)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67325/ --- (Updated May 29, 2018, 6:29 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67293: SENTRY-2243: Extend the thrift definition for policy service to learn owner information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67293/ --- (Updated May 29, 2018, 6:16 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67325: SENTRY-2246: Construct owner privilege (TSentryPrivilege)

> On May 25, 2018, 9:15 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Lines 1267 (patched) > > > > > > it should be

Review Request 67325: SENTRY-2246: Construct owner privilege (TSentryPrivilege)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67325/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2246

Re: Review Request 67293: SENTRY-2243: Extend the thrift definition for policy service to learn owner information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67293/ --- (Updated May 24, 2018, 11:18 p.m.) Review request for sentry, Na Li and Sergio

Review Request 67293: SENTRY-2243: Extend the thrift definition for policy service to learn owner information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67293/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY--2243

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203598 ---

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On May 18, 2018, 1:30 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > > Line 192 (original), 201-213 (patched) > >

Re: Review Request 65768: SENTRY-2144: Table Rename Cross Database should update permission correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65768/#review203456 --- Ship it! Looks Good. - kalyan kumar kalvagadda On May 18,

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/#review203413 --- General question? Who is authorized to perform this operation? Is

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203329 ---

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203327 --- In general note can't you seperate patches for below? 1.Add

Review Request 67180: SENTRY-2235: Add hive tests to verify column privileges for views

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67180/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2235

Re: Review Request 67131: SENTRY-2174: Sentry authorization provider should now generate ACL for users

> On May 16, 2018, 3:52 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Lines 278 (patched) > > > > > > Is it abnormal for this to

Re: Review Request 67131: SENTRY-2174: Sentry authorization provider should now generate ACL for users

> On May 16, 2018, 3:52 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Lines 245 (patched) > > > > > > should you check the type if

Re: Review Request 67131: SENTRY-2174: Sentry authorization provider should now generate ACL for users

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67131/ --- (Updated May 15, 2018, 11:45 p.m.) Review request for sentry, Arjun Mishra, Na

Review Request 67131: SENTRY-2174: Sentry authorization provider should now generate ACL for users

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67131/ --- Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. Bugs:

Re: Review Request 67072: SENTRY-2228: Improve on how to handle unsupported Hive commands

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67072/#review203118 ---

Review Request 67091: SENTRY-2218: Sentry-plug-in should have API's to handle grant/revoke privileges to users.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67091/ --- Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. Bugs:

Re: Review Request 67087: SENTRY-2171: Permission full snapshot should include owner privileges

> On May 11, 2018, 4:29 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 2529 (original), 2529 (patched) > > > > > >

Review Request 67087: SENTRY-2171: Permission full snapshot should include owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67087/ --- Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. Bugs:

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202875 ---

Re: Review Request 67046: SENTRY-2226: Support Hive operation ALTER TABLE EXCHANGE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67046/#review202873 --- Ship it! Fix it and push it. - kalyan kumar kalvagadda On

Re: Review Request 67046: SENTRY-2226: Support Hive operation ALTER TABLE EXCHANGE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67046/#review202872 ---

Re: Review Request 67006: SENTRY-2173: Extend PrivilegeInfo to hold user privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67006/ --- (Updated May 9, 2018, 7:13 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67006: SENTRY-2173: Extend PrivilegeInfo to hold user privileges

> On May 8, 2018, 8:57 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Line 31 (original), 33 (patched) > > > > > > Can you add comment

Re: Review Request 67006: SENTRY-2173: Extend PrivilegeInfo to hold user privileges

> On May 8, 2018, 7:52 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Line 27 (original), 29 (patched) > > > > > > I think we

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

> On May 4, 2018, 8:21 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/resources/011-SENTRY-2154.derby.sql > > Lines 24-44 (patched) > > > > > > Lina, Is the the user privileges

Review Request 67006: SENTRY-2173: Extend PrivilegeInfo to hold user privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67006/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2173

Review Request 67002: SENTRY-2216: Extend the thrift definition for policy service to handle user privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67002/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2216

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/#review202475 ---

Re: Review Request 66837: SENTRY-2170: Update the Sentry-HDFS thrift for user level privileges.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66837/ --- (Updated May 2, 2018, 7:15 p.m.) Review request for sentry, Na Li and Sergio

<    1   2   3   4   5   >