Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-05 Thread zhangli...@apache.org
Thank you for all participants, the vote had finished successfully, I will send a new email to statistics the vote result. -- Liang Zhang (John) Apache ShardingSphere & Dubbo Willem Jiang 于2020年1月6日周一 上午8:56写道: > +1 (binding) > > I checked > Download links are valid, git tag

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-05 Thread Willem Jiang
+1 (binding) I checked Download links are valid, git tag is OK. The kits have incubating in the name. Checksums and PGP signatures are valid. DISCLAIMER is included. LICENSE and NOTICE files are good. No binary file in the source kit. I can build the kits from source kit. Willem Jiang Twitter:

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-04 Thread guangyuan wang
Hi +1 approve. I have checked the following items: [+] Download links are valid. [+] Checksums and PGP signatures are valid. [+] DISCLAIMER is included. [+] Source code artifacts have correct names matching the current release. [+] LICENSE and NOTICE files are correct for each

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-02 Thread Craig Russell
Hi, +1 (IPMC) can be carried over to general incubator release vote I checked: [x] incubating in names. [x] Download links are valid. [x] Checksums and PGP signatures are valid (I checked src) [x] DISCLAIMER is included. [x] Source code artifacts have correct names matching the current

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-02 Thread Zhang Yonglun
+1 Checked: Download links are valid. PGP checked. DISCLAIMER is included. LICENSE and NOTICE files are correct for each ShardingSphere repo. All files have license headers if necessary. mvn install succeed. -- Zhang Yonglun Apache ShardingSphere Juan Pan 于2020年1月2日周四 下午6:44写道: > +1, it is

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-02 Thread Juan Pan
+1, it is ok for me My check list, Download links are valid. Checksums and PGP signatures are valid. DISCLAIMER is included. LICENSE and NOTICE files are correct for each ShardingSphere repo. All files have license headers if necessary. Install source files successfully. Juan Pan (Trista)

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-01 Thread Sheng Wu
Got it. +1 binding Checked 1. Incubating in names 2. Compiling pass. 3. GPG checked 4. sha512 exist 5. LICENSE and NOTICE exist. Good luck and glad to see the stable release will be available soon Sheng Wu 吴晟 Twitter, wusheng1108 zhangli...@apache.org 于2020年1月2日周四 下午12:38写道: > Sorry, I can

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-01 Thread zhangli...@apache.org
Sorry, I can not find the old secret key, so we can not reuse the old public key for now. The only way is use the current key to check the gpg signature. Please reimport the `KEYS` file to validate the signature for now. It is unnecessary to re-release version. How about continue to vote on this

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-01 Thread Juan Pan
Thanks for your explanation, Willem. Let me make it clear, my concern is that a public key ever signed for one release, and now this key is compromised, and although this key is in KEYS file, it could not work well. Therefore we could not use it for verify the integrity of old release in [1]

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-01 Thread Willem Jiang
No, I don't think using the KEYS file can keep good track of the public key, it doesn't support the revoke operation. It's better to use the public Key server to host the public key and we can know if the key is revoked or not. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Thu, Jan 2,

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-01 Thread Juan Pan
That means once one key was used for one release, it could not be deleted from KEYS files anymore no matter it is great on or not, right? Juan Pan (Trista) Senior DBA & PPMC of Apache ShardingSphere(Incubating) E-mail: panj...@apache.org On 01/2/2020 12:00,Willem

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-01 Thread zhangli...@apache.org
Sure, 2 same usernames will make the checker confuse. I prefer to re-release again for round 3 and just make sure one release manager only have a single gpg signature. -- Liang Zhang (John) Apache ShardingSphere & Dubbo Juan Pan 于2020年1月2日周四 上午11:12写道: > Very appreciated

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-01 Thread Willem Jiang
If the private key is compromised[1] or if we cannot find the private key, we should revoke the public KEY[2]. Please keep your private key in a safe place. [1]https://www.thesslstore.com/blog/heres-what-happens-when-your-private-key-gets-compromised/

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-01 Thread Juan Pan
Very appreciated Sheng, make sense. Juan Pan (Trista) Senior DBA & PPMC of Apache ShardingSphere(Incubating) E-mail: panj...@apache.org On 01/2/2020 11:09,Sheng Wu wrote: Yes, because the verification is introduced on the official website, download page, right? If

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-01 Thread Sheng Wu
Yes, because the verification is introduced on the official website, download page, right? If we delete it, users will fail when we do the verification. Sheng Wu 吴晟 Twitter, wusheng1108 Juan Pan 于2020年1月2日周四 上午11:03写道: > Hi Sheng, > > > Thanks for your correction. > Just confirm, the key

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-01 Thread Juan Pan
Hi Sheng, Thanks for your correction. Just confirm, the key point is that the old key for 4.0.0-RC1 release which passed the release vote but exists in our release list now could not be deleted, right? In other words, only one certain release exists, the key used for which must exist?

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-01 Thread Sheng Wu
You can't simply delete the old one. Because ShardingSphere has existing release based on that KEY :) We could still continue in this way, but it should not be recommended if your old key is still available. Sheng Wu 吴晟 Twitter, wusheng1108 Juan Pan 于2020年1月2日周四 上午10:18写道: > Hi Liang, > > >

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-01 Thread Juan Pan
Hi Liang, If you plan not to use the old one any more, deleting is is an alternative to avoid confusion. If so, it is necessary to delete it in KEYS file and public key servers, IMO. Juan Pan (Trista) Senior DBA & PPMC of Apache ShardingSphere(Incubating) E-mail:

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-01 Thread zhangli...@apache.org
> A question, why you have two pgp keys in the KEYS file? I change a computer, the 1st one is for the 4.0.0-RC1, the 4th one is for this version. Do you think we could remove the 1st one? because I will never use that gpp key again, but do we need to keep it to make the 4.0.0-RC1 can be validate?

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2020-01-01 Thread Sheng Wu
Hi Liang Zhang A question, why you have two pgp keys in the KEYS file? Sheng Wu 吴晟 Twitter, wusheng1108 zhangli...@apache.org 于2019年12月30日周一 下午9:44写道: > Hello ShardingSphere Community, > > This is a call for vote to release Apache ShardingSphere (Incubating) > version 4.0.0 > > Release

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2019-12-31 Thread zhaojun
+1 I have checked: [OK] Download links are valid. [OK] Checksums and PGP signatures are valid. [OK] DISCLAIMER is included. [OK] Source code artifacts have correct names matching the current release. [OK] All files have license headers if necessary. [OK] No compiled archives bundled in source

Re:[VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2019-12-31 Thread Zonglei Dong
+1 The checklist: [ OK ] Download links are valid. [ OK ] Checksums and PGP signatures are valid. [ OK ] DISCLAIMER is included. [ OK ] Source code artifacts have correct names matching the current release. [ OK ] All files have license headers if necessary. [ OK ] No compiled archives bundled

Re:[VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2019-12-30 Thread sunbufu
+1 I have checked the following items. Checklist for reference: [v] Download links are valid. [v] Checksums and PGP signatures are valid. [v] DISCLAIMER is included. [v] Source code artifacts have correct names matching the current release. — Haisheng Sun (sunbufu) Apache

Re:[VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 round 2

2019-12-30 Thread Sion Yang
+1 I checked the LICENSE, NOTICE, Checksums, PGP signatures and installing source code. No problem happened. -- Yi Yang(Sion) Apache ShardingSphere At 2019-12-30 21:43:37, "zhangli...@apache.org" wrote: >Hello ShardingSphere Community, > >This is a call for vote to release Apache

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0

2019-12-26 Thread Juan Pan
Hi Willem, Your reply is what i am waiting for, however could give me more details about this issue? My Max OS is 10.13.6 (17G3025) now, is it needed to update my Max OS to higher version? Juan Pan (Trista) Senior DBA & PPMC of Apache ShardingSphere(Incubating)

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0

2019-12-26 Thread zhangli...@apache.org
OK, we received 2 issues, one for Xcode, one for issue#3770. So we just cancel this release and will release round 2 soon. -- Liang Zhang (John) Apache ShardingSphere & Dubbo Willem Jiang 于2019年12月26日周四 下午9:38写道: > Did you just upgrade your Mac OSX? > I think you need to

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0

2019-12-26 Thread Willem Jiang
Did you just upgrade your Mac OSX? I think you need to install the right version of Xcode to fix the issue. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Tue, Dec 24, 2019 at 2:25 PM Juan Pan wrote: > > Hi > > > LICENSE, NOTICE, Checksums and PGP signatures have no problems, however

Re:[VOTE] Release Apache ShardingSphere (Incubating) 4.0.0

2019-12-26 Thread Raigor Jiang
I am agree with Sion Yang. On 12/26/2019 18:40,Sion Yang wrote: Sorry, I want to change my vote to -1. I think issue#3770[1] should be fixed and included in 4.0.0 release. ML[2] 4.0.0 stable version release plan also discusses the issue. [1]

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0

2019-12-24 Thread avalon566
+1 approve [x] Download links are valid. [x] Checksums and PGP signatures are valid. [x] DISCLAIMER is included. [x] Source code artifacts have correct names matching the current release. [x] LICENSE and NOTICE files are correct for each ShardingSphere repo. [x] All files have license

Re:[VOTE] Release Apache ShardingSphere (Incubating) 4.0.0

2019-12-24 Thread Sion Yang
+1I checked the LICENSE, NOTICE, Checksums, PGP signatures and installing source code.No problem happened. Checklist: [x] Download links are valid. [x] Checksums and PGP signatures are valid. [x] DISCLAIMER is included. [x] Source code artifacts have correct names matching the current release.

Re:[VOTE] Release Apache ShardingSphere (Incubating) 4.0.0

2019-12-23 Thread Juan Pan
Hi LICENSE, NOTICE, Checksums and PGP signatures have no problems, however when i installed this release, some exceptions threw up as follows. Does anyone run into this similar situation? - xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory

Re:[VOTE] Release Apache ShardingSphere (Incubating) 4.0.0

2019-12-23 Thread sushixiang
Approve all checklist. [+1] Download links are valid. [+1] Checksums and PGP signatures are valid. [+1] DISCLAIMER is included. [+1] Source code artifacts have correct names matching the current release. [+1] LICENSE and NOTICE files are correct for each ShardingSphere repo. [+1] All files

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-17 Thread Juan Pan
Hi Craig, Very appreciated your checking and voting which help this release move ahead. Juan Pan panj...@apache.org Juan Pan(Trista), Apache ShardingSphere On 11/18/2019 15:01,Craig Russell wrote: +1 I checked: [ x] Download links are valid. [x ] Checksums and PGP signatures are valid.

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-17 Thread Craig Russell
+1 I checked: [ x] Download links are valid. [x ] Checksums and PGP signatures are valid. [ x] DISCLAIMER is included. [ x] Source code artifacts have correct names matching the current release. [x ] Built mvn clean install from source Craig > On Nov 11, 2019, at 2:40 AM, Juan Pan wrote:

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-17 Thread Juan Pan
Thanks Craig, Waiting for your good or bad news. :) Juan Pan panj...@apache.org Juan Pan(Trista), Apache ShardingSphere On 11/18/2019 11:07,Craig Russell wrote: The problem was using --recv-keys with the KEYS file instead of the correct option --import wrote: Craig I think that may be

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-17 Thread Craig Russell
The problem was using --recv-keys with the KEYS file instead of the correct option --import On Nov 17, 2019, at 6:52 PM, Sheng Wu wrote: > > Craig > > I think that may be caused by Juan used to regenerate the KEY from last > round, right? Juan. > I manually re-import in every time recheck

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-17 Thread Sheng Wu
Craig I think that may be caused by Juan used to regenerate the KEY from last round, right? Juan. I manually re-import in every time recheck your new round. That should be the reason. Sheng Wu 吴晟 Twitter, wusheng1108 Juan Pan 于2019年11月18日周一 上午10:24写道: > Hi Craig, > > > Thanks for your reply

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-17 Thread Juan Pan
Hi Craig, Thanks for your reply and checking. Firstly, PGP PUBLIC KEY BLOCK of key ID C8ADAD3A which exists in `KEYS-FILE`[1] is correct. Secondly, key ID C8ADAD3A is not https://keyserver.pgp.com/, for there is no search result of my email, i.e panj...@apache.org . How about trying

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-17 Thread Sheng Wu
Hi Craig I just tried to re-download and re-import the file https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS. My GPG Keychain App shows nothing changed from last import. Sheng Wu 吴晟 Twitter, wusheng1108 Craig Russell 于2019年11月18日周一 上午9:40写道: > Hi Sheng, > > My

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-17 Thread Craig Russell
Hi Sheng, My understanding is that downloading from the keys server is only done if the public key is not available locally. Does the KEYS file that you imported from match the KEYS-2 file that I imported from below? Craig > On Nov 17, 2019, at 5:21 PM, Sheng Wu wrote: > > Hi Craig > > I

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-17 Thread Zonglei Dong
+1 I checked list: [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] All files have license

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-14 Thread Juan Pan
Thanks Willem, Mentor' vote gives us more confidence. Although 72 hours passed, i would like to give other mentors and PPMCs more time to check. Please notice, next Monday in Beijing time is the deadline for this vote, i plead your check and vote, so that we can move ahead well in incubator

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-14 Thread Willem Jiang
+1. (binding) Checked the release candidate of source and binary, the signatures and sha are OK. License and Notice file looks good to me. DISCLAIMER are in the kits. There is on binary files in the source release kit. The release kits has incubating in the name . Can build the binary from source

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-13 Thread linzesi
+1, I check the following [X] Download links are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] No compiled archives bundled in source archive. On 11/14/2019

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-13 Thread zhangli...@apache.org
Same thing for sunbufu. As a committer, please check all items from check list and make sure every thing is ok. Please do not just leave a word without voting. Thank you. -- Liang Zhang (John) Apache ShardingSphere & Dubbo Sheng Wu 于2019年11月14日周四 上午10:00写道: > Guangyuan Wang

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-13 Thread Sheng Wu
Guangyuan Wang Please notice, as a committer, even your vote is PPMC(counted) vote for release, but you should write which steps you have run with the +1. The mail you posted looks like a copy of Chen QingYang. As a committer and on the way toward PPMC, you should learn the ASF requirement for

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-13 Thread guangyuan wang
> +1, >Looks good to me. > I checked: > > [X] Download links are valid. > [X] Checksums and PGP signatures are valid. > [X] DISCLAIMER is included. > [X] Source code artifacts have correct names matching the current release. > [X] LICENSE and NOTICE files are correct for each ShardingSphere repo.

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-12 Thread Chen QingYang
+1, I checked: [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] All files have license

Re:[VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-12 Thread sunbufu
LGTM. +1, I checked: [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] All files have

Re:[VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-12 Thread duhongjun
+1, I checked: [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] All files have license

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-12 Thread zhangli...@apache.org
Yes, there are milestone info in the release notes[1], just search MILESTONE to find them. [1] https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md -- Liang Zhang (John) Apache ShardingSphere & Dubbo Sheng Wu 于2019年11月13日周三 上午11:52写道: > I guess so,

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-12 Thread Sheng Wu
I guess so, but my point is, you didn't mention it in changelog file. >From my understanding, all information should be hosted in ASF INFRA, which excludes the GitHub milestone list as an optional one. And most important is, a milestone could be changed after your release. Sheng Wu 吴晟 Apache

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-12 Thread Juan Pan
Yep, there are many issues fixed and features developed, some of which are trivial. Based on that, we’d like to summarize, thus it seems to `ignore` some change log, does anyone have some suggestions? Juan Pan panj...@apache.org Juan Pan(Trista), Apache ShardingSphere On 11/13/2019

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-12 Thread zhangli...@apache.org
The release notes has all change logs in milestone[1] which in the end of each release version, because change logs in milestone is too big, so we just summary some important issues. [1] https://github.com/apache/incubator-shardingsphere/milestone/8 -- Liang Zhang (John) Apache

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-12 Thread Sheng Wu
+1 The issues mentioned before have been fixed. asc sign checked and based on apache mail. NOTICE, LICENSE, and DISCLAIMER exist. sha512 is there compiling works A tiny issue, The changelog seems to ignore many fixes and code changes. Such as bugfix #3401[1] never shows up in a changelog. The

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-11 Thread zhangli...@apache.org
I checked the basic functions for binary release too. -- Liang Zhang (John) Apache ShardingSphere & Dubbo Zhang Yonglun 于2019年11月12日周二 下午2:42写道: > +1, > > I checked: > > [X] Download links are valid. > [X] Checksums and PGP signatures are valid. > [X] DISCLAIMER is included.

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-11 Thread Zhang Yonglun
+1, I checked: [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] All files have license

Re:[VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-11 Thread Juan Pan
Hi Brian, This thread is for checking and voting for Release 4.0.0-RC3, you need to go through the check list and cast your vote. Notice: 4.0.0-RC3 has not been released until now. Did the exception you mentioned happen when you did checking? Juan Pan panj...@apache.org Juan Pan(Trista),

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-11 Thread zhaojun
+1, I checked: [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] All files have license

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 4

2019-11-11 Thread zhangli...@apache.org
+1, I checked: [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] All files have license

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 3

2019-11-08 Thread Zhang Yonglun
Test > > > assertInitDataSource(org.apache.shardingsphere.route.time.mysql.MySQLTimeServiceTest) > Time elapsed: 0.512 s <<< FAILURE!" > > -邮件原件- > 发件人: Zhang Yonglun [mailto:zhangyong...@apache.org] > 发送时间: 2019年11月8日 14:27 > 收件人: dev > 主题: R

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 3

2019-11-07 Thread Juan Pan
ng Yonglun [mailto:zhangyong...@apache.org] 发送时间: 2019年11月8日 14:27 收件人: dev 主题: Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 3 OS: Windows7 JDK: 1.8.0_162" mvn install or run the single test case MySQLTimeServiceTest can cause that failure. Juan Pan 于2019年11月8日周

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 3

2019-11-07 Thread Sheng Wu
eServiceTest) > Time elapsed: 0.512 s <<< FAILURE!" > > -邮件原件- > 发件人: Zhang Yonglun [mailto:zhangyong...@apache.org] > 发送时间: 2019年11月8日 14:27 > 收件人: dev > 主题: Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 3 > > OS: Windows7 >

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 3

2019-11-07 Thread Juan Pan
t;< FAILURE! - in org.apache.shardingsphere.route.time.mysql.MySQLTimeServiceTest assertInitDataSource(org.apache.shardingsphere.route.time.mysql.MySQLTimeServiceTest) Time elapsed: 0.512 s <<< FAILURE!" -邮件原件- 发件人: Zhang Yonglun [mailto:zhangyong...@apache.org] 发送时间: 2019年11月8日 14:27 收件人: dev 主

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 3

2019-11-07 Thread Sheng Wu
iceTest) > Time elapsed: 0.512 s <<< FAILURE!" > > -邮件原件- > 发件人: Zhang Yonglun [mailto:zhangyong...@apache.org] > 发送时间: 2019年11月8日 14:27 > 收件人: dev > 主题: Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 3 > > OS: Windows7 > > JDK:

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 3

2019-11-07 Thread linzesi
I rechecked and found that the remote branch was not updated last time. I encountered this error after the update the branch. OS: Windows10 JDK: 1.8.0_221" Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.545 s <<< FAILURE! - in

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 3

2019-11-07 Thread Zhang Yonglun
OS: Windows7 JDK: 1.8.0_162" mvn install or run the single test case MySQLTimeServiceTest can cause that failure. Juan Pan 于2019年11月8日周五 下午1:41写道: > Hi Yonglun, > > > Thanks for your feedback. Actually, the exception you mentioned didn’t > happened to me, either i run `MySQLTimeServiceTest`

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 3

2019-11-07 Thread Juan Pan
Hi Yonglun, Thanks for your feedback. Actually, the exception you mentioned didn’t happened to me, either i run `MySQLTimeServiceTest` separately or installed the whole project. Can you provide more details about your runtime environment or test procedure? Juan Pan panj...@apache.org

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 3

2019-11-07 Thread Zhang Yonglun
I have installed the source code and a unit test failed: [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.shardingsphere.route.time.mysql.MySQLTimeServiceTest [ERROR] Tests

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 3

2019-11-07 Thread linzesi
+1. checked list: [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] All files have license

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 3

2019-11-07 Thread ????
+1. checked list: [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] All files have license

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 3

2019-11-07 Thread zhangli...@apache.org
+1. I checked: [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. [X] All files have license

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 2

2019-11-05 Thread Sheng Wu
Good to know. I think we should ask the release manager to recheck before release vote mail, in order to avoid the confusion. Sheng Wu 吴晟 Apache SkyWalking Apache Incubator Apache ShardingSphere, ECharts, DolphinScheduler podlings Zipkin Twitter, wusheng1108 Juan Pan 于2019年11月5日周二 下午6:28写道:

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 2

2019-11-05 Thread Juan Pan
Hi, sorry for that. `node` package is excluded to solve the problem of oversized source package in ROUND 1. Therefore you got that exception. `source-distribution.xml` will be modified again for this correction. Consequently, I am sorry to tell the community that ROUND 3 is coming soon,

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 2

2019-11-05 Thread zhangli...@apache.org
Because we exclude the folder of node js, and we have same package name is same name unfortunately. We will fix this issue soon. -- Liang Zhang (John) Apache ShardingSphere & Dubbo Juan Pan 于2019年11月5日周二 下午5:54写道: > Thanks, i will review it now. > > > Juan Pan > > >

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 2

2019-11-05 Thread Juan Pan
Thanks, i will review it now. Juan Pan panj...@apache.org Juan Pan(Trista), Apache ShardingSphere On 11/5/2019 17:32,Sheng Wu wrote: Sorry, still -1. The source code compiles failures. [*ERROR*] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 2

2019-11-05 Thread Sheng Wu
Sorry, still -1. The source code compiles failures. > [*ERROR*] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile *(default-compile)* on project sharding-orchestration-core: *Compilation failure*: Compilation failure: [*ERROR*]

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3

2019-10-31 Thread Juan Pan
Hi Liang, I am appreciated your prompt issue fix. It seems building and signing the source code package have to be done one more time, so i am sorry to inform other mentors and PPMCs that this release vote is suspended, after all problem solved, i will start a new round of release vote

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3

2019-10-31 Thread Juan Pan
Hi Sheng, Thanks for your sound advices. I will review the problems you mentioned. Juan Pan panj...@apache.org Juan Pan(Trista), Apache ShardingSphere On 10/31/2019 19:17, Sheng Wu wrote: One addition question, Why our changelog[1] so simple? The answer must be NO, and big NO. From the

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3

2019-10-31 Thread zhangli...@apache.org
Release notes issue and source release issue have fixed at https://github.com/apache/incubator-shardingsphere/pull/3428 After merge, we can release for round 2. -- Liang Zhang (John) Apache ShardingSphere & Dubbo Sheng Wu 于2019年10月31日周四 下午7:17写道: > One addition question, >

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3

2019-10-31 Thread Sheng Wu
One addition question, Why our changelog[1] so simple? The answer must be NO, and big NO. From the GitHub release page[2], 499 commit difference between current and last release, but get just 5 lines of the update? I think that is not the purpose of the release changelog. [1]

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3

2019-10-31 Thread Sheng Wu
Pan Juan -1 (binding from PPMC or IPMC perspective) Sorry to say so. You are shipping all UI dependency in the src tar. Is this really necessary? And if so, what is the meaning of source release of UI? Do you notice, your source tar is nearly 200M? It is mostly caused by UI frontend. Another

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3

2019-10-30 Thread Juan Pan
Hi Liang, Thanks for your kind reminders. What you mentioned has been fixed already, and IMP other mentors and PPMCs can continue to go through checklist and cast your vote. Sorry for the inconvenience. Regards, Trista Juan Pan panj...@apache.org Juan Pan(Trista), Apache

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3

2019-10-30 Thread zhangli...@apache.org
-1. The release's signature validation is fail, and please make sure the public KEYS has already import to [1]. Because of problem of signature validation, the status of close the maven release is failed. We need to release it again. [1]

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3

2019-10-30 Thread zhangli...@apache.org
Hi Zonglei Dong, You can not only reply+1. Before vote, please make sure you check all checklist and check on the item you checked. -- Liang Zhang (John) Apache ShardingSphere & Dubbo 董。 <598363...@qq.com> 于2019年10月31日周四 上午10:55写道: > Look forward to ShardingSphere 4.0.0-RC3's

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-21 Thread Willem Jiang
Thanks for the information. I will post my +1 on IPMC mailing list. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Aug 21, 2019 at 1:08 PM Zhang Yonglun wrote: > > Hi, > > Thanks for Willem and Sheng's reminder. I have put the wrong link of Maven > 2 staging repository. > > The link

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Zhang Yonglun
Hi, Thanks for Willem and Sheng's reminder. I have put the wrong link of Maven 2 staging repository. The link is updated to: Maven 2 staging repository: https://repository.apache.org/content/repositories/orgapacheshardingsphere-1022/org/apache/shardingsphere/ We have updated the release

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Zhang Yonglun
Hi Craig, We have updated the release doc[1] to fix the two problems you mentioned so that we can use correct mail template the next time. 1. Use PPMC member instead of binding while community instead of non-binding in the vote result announcement. 2. Add note to invite all mentors to vote

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Sheng Wu
One question Why does not your staging repo include number? > Maven 2 staging repository: > https://repository.apache.org/content/repositories/staging/org/apache/shardingsphere/ There should be a link related to each release process. Please check, if so, I think you just missed deleting old

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Willem Jiang
Sorry, I was traveling last two days and just missed the vote. I just had a quick check of the release kit, most of them are OK but for the staging repo[1] I found there is a RC1 version beside RC2, which means if we do the release in Maven repo, we will publish the RC1 and RC2 version at the same

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Craig Russell
Hi, I'd like to suggest that when a release vote does not get all mentors to vote, we should ping them so the IPMC vote is just a formality. This results in a lot less stress on everyone in the incubator community. If mentors respond that they are just too busy right now, we should accept that

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Craig Russell
Hi, We should not use "binding" as a term when referring to votes of PPMC members. Binding has a specific meaning in Apache that for release votes means IPMC. Better to use "6 PPMC member +1 votes" and "1 community +1 vote". You can refer to "mentor" votes as "binding" but it's better just to

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-20 Thread Zhang Yonglun
The vote to release Apache ShardingSphere (Incubating) 4.0.0-RC2 has passed. 6 binding +1 votes: Liang Zhang Juan Pan Craig L Russell (mentor) Yi Yang Hao Cao Von Gosling (mentor) 1 non-binding +1 vote: Haisheng Sun Gosling Von 于2019年8月20日周二 上午11:28写道: > > Thanks for your prompt reply. > >

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-19 Thread Gosling Von
Thanks for your prompt reply. +1 (mentor) Best Regards, Von Gosling > On Aug 20, 2019, at 11:20 AM, Zhang Yonglun wrote: > > Hi, > > The release files you mentioned are from the NOTICE file of the Netty > project. > > Gosling Von 于2019年8月19日周一 下午5:44写道: > >> Hi, >> >> According to the

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-19 Thread Zhang Yonglun
Hi, The release files you mentioned are from the NOTICE file of the Netty project. Gosling Von 于2019年8月19日周一 下午5:44写道: > Hi, > > According to the checklist, everything looks very good. I focused on the > notice file, one question was raised about some of its statements. You > could look at >

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-19 Thread Gosling Von
Hi, According to the checklist, everything looks very good. I focused on the notice file, one question was raised about some of its statements. You could look at apache-shardingsphere-incubating-4.0.0-RC2-sharding-proxy-bin. I did not find we packaged release files including such as Apache

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-19 Thread Hao Cao
+1 The following checking items have been done. [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere

Re:[VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-18 Thread sunbufu
+1 The following checking items have been done. [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere

Re:[VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-18 Thread Sion Yang
+1 The following checking items have been done. [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each ShardingSphere

Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC2 [ROUND 4]

2019-08-18 Thread Craig Russell
+1 (mentor) The following checking items have been done. [X] Download links are valid. [X] Checksums and PGP signatures are valid. [X] DISCLAIMER is included. [X] Source code artifacts have correct names matching the current release. [X] LICENSE and NOTICE files are correct for each

  1   2   >