[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2433 ---

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-28 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r177594095 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/ILocalAssignmentsBackend.java --- @@ -26,7 +26,7 @@ /** * Interface for storing

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-28 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r177711557 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java --- @@ -42,16 +42,44 @@ public interface IStormClusterState {

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-28 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r177712003 --- Diff: storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java --- @@ -299,6 +299,8 @@ private Scope calculateScope(Map

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-13 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r174188374 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java --- @@ -233,23 +249,11 @@ * @return the id of the topology or

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-10 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173615818 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java --- @@ -234,6 +295,60 @@ public void launchDaemon() {

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-10 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173615676 --- Diff: storm-client/src/jvm/org/apache/storm/utils/SupervisorClient.java --- @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173232562 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4215,7 +4474,48 @@ public boolean isTopologyNameAllowed(String name)

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173232056 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java --- @@ -234,6 +295,60 @@ public void launchDaemon() {

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173219240 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -319,14 +344,17 @@ private static StormBase make(TopologyStatus

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173220578 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -293,14 +268,15 @@ public synchronized void run() {

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173216785 --- Diff: storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java --- @@ -295,7 +295,11 @@ private Scope calculateScope(Map

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173218011 --- Diff: storm-client/src/jvm/org/apache/storm/utils/SupervisorClient.java --- @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173213537 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java --- @@ -233,23 +249,11 @@ * @return the id of the topology or null

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173217779 --- Diff: storm-client/src/jvm/org/apache/storm/utils/SupervisorClient.java --- @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173213078 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java --- @@ -94,6 +108,8 @@ @Deprecated List

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173207181 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/InMemoryAssignmentBackend.java --- @@ -0,0 +1,152 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173214066 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java --- @@ -745,6 +828,7 @@ public void disconnect() {

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173210647 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/InMemoryAssignmentBackend.java --- @@ -0,0 +1,152 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173213324 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java --- @@ -233,23 +249,11 @@ * @return the id of the topology or null

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173215759 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -392,6 +401,30 @@ public void establishLogSettingCallback() {

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173215187 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -392,6 +401,30 @@ public void establishLogSettingCallback() {

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173212518 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java --- @@ -44,6 +44,16 @@ Assignment assignmentInfo(String

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173217461 --- Diff: storm-client/src/jvm/org/apache/storm/utils/SupervisorClient.java --- @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173215685 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -392,6 +401,30 @@ public void establishLogSettingCallback() {

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173211013 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/ILocalAssignmentsBackend.java --- @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173202043 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/ILocalAssignmentsBackend.java --- @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173201619 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/ILocalAssignmentsBackend.java --- @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173179815 --- Diff: conf/defaults.yaml --- @@ -182,7 +195,7 @@ worker.log.level.reset.poll.secs: 30 # control how many worker receiver threads we need per

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173177188 --- Diff: conf/defaults.yaml --- @@ -182,7 +195,7 @@ worker.log.level.reset.poll.secs: 30 # control how many worker receiver threads we need per worker

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-07 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173046065 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/AssignmentDistributionService.java --- @@ -0,0 +1,312 @@ +/** + * Licensed to the

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-07 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173043037 --- Diff: storm-client/src/storm.thrift --- @@ -477,12 +477,13 @@ struct SupervisorInfo { 1: required i64 time_secs; 2: required string

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-07 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r173042840 --- Diff: conf/defaults.yaml --- @@ -182,7 +195,7 @@ worker.log.level.reset.poll.secs: 30 # control how many worker receiver threads we need per

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-07 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r17361 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/AssignmentDistributionService.java --- @@ -0,0 +1,312 @@ +/** + * Licensed to the

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-07 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r172979050 --- Diff: storm-client/src/jvm/org/apache/storm/Config.java --- @@ -991,6 +991,31 @@ @isPositiveNumber public static final String

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-07 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r172945323 --- Diff: storm-client/src/storm.thrift --- @@ -477,12 +477,13 @@ struct SupervisorInfo { 1: required i64 time_secs; 2: required string

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-03-07 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r172934007 --- Diff: conf/defaults.yaml --- @@ -182,7 +195,7 @@ worker.log.level.reset.poll.secs: 30 # control how many worker receiver threads we need per worker

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-01-23 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r163215412 --- Diff: storm-client/src/storm.thrift --- @@ -836,3 +848,33 @@ exception HBAuthorizationException { exception HBExecutionException { 1:

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-01-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r162322607 --- Diff: storm-client/src/storm.thrift --- @@ -836,3 +848,33 @@ exception HBAuthorizationException { exception HBExecutionException { 1:

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2018-01-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r162322012 --- Diff: storm-client/src/storm.thrift --- @@ -836,3 +848,33 @@ exception HBAuthorizationException { exception HBExecutionException { 1:

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158768637 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4121,7 +4236,43 @@ public boolean isTopologyNameAllowed(String

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158768477 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -1733,13 +1825,24 @@ private TopologyResources

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158768248 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/TimeOutWorkerHeartbeatsRecoveryStrategy.java --- @@ -0,0 +1,86 @@ +/** + * Licensed

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158768126 --- Diff: conf/defaults.yaml --- @@ -162,6 +168,13 @@ supervisor.memory.capacity.mb: 4096.0 # for single threaded bolts supervisor.cpu.capacity:

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158758661 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/LocalAssignmentsBackendFactory.java --- @@ -0,0 +1,48 @@ +/** + * Licensed to the

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158758510 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/LocalAssignmentsBackendFactory.java --- @@ -0,0 +1,48 @@ +/** + * Licensed to the

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158758374 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/LocalAssignmentsBackendFactory.java --- @@ -0,0 +1,48 @@ +/** + * Licensed to the

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158742516 --- Diff: conf/defaults.yaml --- @@ -162,6 +168,13 @@ supervisor.memory.capacity.mb: 4096.0 # for single threaded bolts

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158737793 --- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj --- @@ -792,15 +795,18 @@ (bind _ (log-message "ass1, t76, pre beat: " (pr-str

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158737618 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/LocalAssignmentsBackendFactory.java --- @@ -0,0 +1,48 @@ +/** + * Licensed to the

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158714573 --- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj --- @@ -792,15 +795,18 @@ (bind _ (log-message "ass1, t76, pre beat: " (pr-str

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158714261 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/LocalAssignmentsBackendFactory.java --- @@ -0,0 +1,48 @@ +/** + * Licensed to the

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158714076 --- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj --- @@ -792,15 +795,18 @@ (bind _ (log-message "ass1, t76, pre beat: " (pr-str

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158713978 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/InMemoryAssignmentBackend.java --- @@ -0,0 +1,152 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158705496 --- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj --- @@ -792,15 +795,18 @@ (bind _ (log-message "ass1, t76, pre beat: " (pr-str

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158705083 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/LocalAssignmentsBackendFactory.java --- @@ -0,0 +1,48 @@ +/** + * Licensed to the

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158706034 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/TimeOutWorkerHeartbeatsRecoveryStrategy.java --- @@ -0,0 +1,86 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158705506 --- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj --- @@ -792,15 +795,18 @@ (bind _ (log-message "ass1, t76, pre beat: " (pr-str

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158705607 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4121,7 +4236,43 @@ public boolean isTopologyNameAllowed(String

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158705200 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java --- @@ -147,21 +153,52 @@ protected void

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158704904 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/InMemoryAssignmentBackend.java --- @@ -0,0 +1,152 @@ +/** + * Licensed to the

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-26 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158688366 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -69,10 +65,8 @@ public

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-25 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r158669343 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/ReadClusterState.java --- @@ -69,10 +65,8 @@ public

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-12-03 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r154558915 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -231,7 +183,15 @@ @VisibleForTesting public

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-29 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r153778405 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/TimeOutWorkerHeartbeatsRecoveryStrategy.java --- @@ -0,0 +1,86 @@ +/** + * Licensed

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-29 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r153774053 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java --- @@ -228,6 +257,51 @@ private void launchDaemon() {

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-28 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r153705766 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/TimeOutWorkerHeartbeatsRecoveryStrategy.java --- @@ -0,0 +1,86 @@ +/** + * Licensed

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-27 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r153401446 --- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java --- @@ -1589,18 +1570,16 @@ public static ComponentPageInfo aggCompExecsStats(

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-25 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r153055623 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java --- @@ -43,13 +44,15 @@ private static Logger LOG =

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-25 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r153055629 --- Diff: storm-client/src/jvm/org/apache/storm/Config.java --- @@ -1293,6 +1318,44 @@ @isPositiveNumber public static final String

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-24 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r153037892 --- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java --- @@ -1589,18 +1570,16 @@ public static ComponentPageInfo aggCompExecsStats(

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-24 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r153036973 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java --- @@ -43,13 +44,15 @@ private static Logger LOG =

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-24 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r153037176 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java --- @@ -147,21 +153,52 @@ protected void

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-24 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r153036746 --- Diff: storm-client/src/jvm/org/apache/storm/Config.java --- @@ -1293,6 +1318,44 @@ @isPositiveNumber public static final String

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152903549 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/LeaderListenerCallback.java --- @@ -0,0 +1,213 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152899531 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/AssignmentDistributionService.java --- @@ -0,0 +1,280 @@ +/** + * Licensed to the

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152897992 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/timer/SynchronizeAssignments.java --- @@ -0,0 +1,133 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152895920 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java --- @@ -30,29 +32,36 @@ import

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152902065 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/TimeOutWorkerHeartbeatsRecoveryStrategy.java --- @@ -0,0 +1,86 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152901995 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/TimeOutWorkerHeartbeatsRecoveryStrategy.java --- @@ -0,0 +1,86 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152902020 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/TimeOutWorkerHeartbeatsRecoveryStrategy.java --- @@ -0,0 +1,86 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152902340 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/TimeOutWorkerHeartbeatsRecoveryStrategy.java --- @@ -0,0 +1,86 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152901980 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/TimeOutWorkerHeartbeatsRecoveryStrategy.java --- @@ -0,0 +1,86 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152897458 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/timer/ReportWorkerHeartbeats.java --- @@ -0,0 +1,119 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152902125 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/TimeOutWorkerHeartbeatsRecoveryStrategy.java --- @@ -0,0 +1,86 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152900152 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/LeaderListenerCallback.java --- @@ -0,0 +1,213 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152900918 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/LeaderListenerCallback.java --- @@ -0,0 +1,213 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152903015 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/timer/SynchronizeAssignments.java --- @@ -0,0 +1,133 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152897261 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/timer/ReportWorkerHeartbeats.java --- @@ -0,0 +1,119 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152902232 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/TimeOutWorkerHeartbeatsRecoveryStrategy.java --- @@ -0,0 +1,86 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152902841 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/WorkerHeartbeatsRecoveryStrategyFactory.java --- @@ -0,0 +1,44 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152897084 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/timer/ReportWorkerHeartbeats.java --- @@ -0,0 +1,119 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152902376 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/TimeOutWorkerHeartbeatsRecoveryStrategy.java --- @@ -0,0 +1,86 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152897808 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/timer/SynchronizeAssignments.java --- @@ -0,0 +1,133 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152898161 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/timer/SynchronizeAssignments.java --- @@ -0,0 +1,133 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152903034 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/AssignmentDistributionService.java --- @@ -0,0 +1,280 @@ +/** + * Licensed to the

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152902522 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/TimeOutWorkerHeartbeatsRecoveryStrategy.java --- @@ -0,0 +1,86 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152896015 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java --- @@ -219,6 +246,8 @@ private void launchDaemon() {

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152898026 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/timer/SynchronizeAssignments.java --- @@ -0,0 +1,133 @@ +/** + *

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

2017-11-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r152896601 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java --- @@ -228,6 +257,51 @@ private void launchDaemon() {

  1   2   >