[GitHub] govind-menon opened a new pull request #8: Adds Govind Menon to list of committers plus changing Oath to Verizon…

2019-01-29 Thread GitBox
govind-menon opened a new pull request #8: Adds Govind Menon to list of committers plus changing Oath to Verizon… URL: https://github.com/apache/storm-site/pull/8 … Media This is an automated message from the Apache Git Servi

[GitHub] asfgit merged pull request #8: Adds Govind Menon to list of committers plus changing Oath to Verizon…

2019-01-29 Thread GitBox
asfgit merged pull request #8: Adds Govind Menon to list of committers plus changing Oath to Verizon… URL: https://github.com/apache/storm-site/pull/8 This is an automated message from the Apache Git Service. To respond to t

[GitHub] govind-menon commented on issue #8: Adds Govind Menon to list of committers plus changing Oath to Verizon…

2019-01-29 Thread GitBox
govind-menon commented on issue #8: Adds Govind Menon to list of committers plus changing Oath to Verizon… URL: https://github.com/apache/storm-site/pull/8#issuecomment-458721340 I forgot about the 24 hr waiting period - please feel free to revert this -

[GitHub] HeartSaVioR commented on issue #8: Adds Govind Menon to list of committers plus changing Oath to Verizon…

2019-01-29 Thread GitBox
HeartSaVioR commented on issue #8: Adds Govind Menon to list of committers plus changing Oath to Verizon… URL: https://github.com/apache/storm-site/pull/8#issuecomment-458721666 Non-code change doesn't have 24hr waiting period so I think it's OK. ---

[GitHub] cthistle opened a new pull request #2954: STORM-3331: Testing JIRA to GitHub PR linking

2019-02-05 Thread GitBox
cthistle opened a new pull request #2954: STORM-3331: Testing JIRA to GitHub PR linking URL: https://github.com/apache/storm/pull/2954 Please do not merge, I'll clean this up after fixing. This is an automated message from th

[GitHub] cthistle closed pull request #2954: STORM-3331: Testing JIRA to GitHub PR linking

2019-02-05 Thread GitBox
cthistle closed pull request #2954: STORM-3331: Testing JIRA to GitHub PR linking URL: https://github.com/apache/storm/pull/2954 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] d2r commented on a change in pull request #2930: STORM-3274: Migrates storm CLI to using argparse making documentation…

2019-02-05 Thread GitBox
d2r commented on a change in pull request #2930: STORM-3274: Migrates storm CLI to using argparse making documentation… URL: https://github.com/apache/storm/pull/2930#discussion_r253919526 ## File path: bin/storm.py ## @@ -296,787 +251,1090 @@ def exec_storm_class(klass, j

[GitHub] d2r commented on a change in pull request #2930: STORM-3274: Migrates storm CLI to using argparse making documentation…

2019-02-05 Thread GitBox
d2r commented on a change in pull request #2930: STORM-3274: Migrates storm CLI to using argparse making documentation… URL: https://github.com/apache/storm/pull/2930#discussion_r253919880 ## File path: bin/storm.py ## @@ -296,787 +251,1090 @@ def exec_storm_class(klass, j

[GitHub] d2r commented on a change in pull request #2930: STORM-3274: Migrates storm CLI to using argparse making documentation…

2019-02-05 Thread GitBox
d2r commented on a change in pull request #2930: STORM-3274: Migrates storm CLI to using argparse making documentation… URL: https://github.com/apache/storm/pull/2930#discussion_r253920421 ## File path: bin/storm.py ## @@ -296,787 +251,1090 @@ def exec_storm_class(klass, j

[GitHub] srdo opened a new pull request #2955: STORM-3332: Test INFRA-17791

2019-02-05 Thread GitBox
srdo opened a new pull request #2955: STORM-3332: Test INFRA-17791 URL: https://github.com/apache/storm/pull/2955 Please ignore This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] d2r commented on a change in pull request #2930: STORM-3274: Migrates storm CLI to using argparse making documentation…

2019-02-05 Thread GitBox
d2r commented on a change in pull request #2930: STORM-3274: Migrates storm CLI to using argparse making documentation… URL: https://github.com/apache/storm/pull/2930#discussion_r253920643 ## File path: bin/storm.py ## @@ -296,787 +251,1090 @@ def exec_storm_class(klass, j

[GitHub] d2r commented on a change in pull request #2930: STORM-3274: Migrates storm CLI to using argparse making documentation…

2019-02-05 Thread GitBox
d2r commented on a change in pull request #2930: STORM-3274: Migrates storm CLI to using argparse making documentation… URL: https://github.com/apache/storm/pull/2930#discussion_r253921047 ## File path: bin/storm.py ## @@ -156,49 +95,92 @@ def get_classpath(extrajars, daem

[GitHub] srdo closed pull request #2955: STORM-3332: Test INFRA-17791

2019-02-05 Thread GitBox
srdo closed pull request #2955: STORM-3332: Test INFRA-17791 URL: https://github.com/apache/storm/pull/2955 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] kishorvpatil commented on a change in pull request #2930: STORM-3274: Migrates storm CLI to using argparse making documentation…

2019-02-05 Thread GitBox
kishorvpatil commented on a change in pull request #2930: STORM-3274: Migrates storm CLI to using argparse making documentation… URL: https://github.com/apache/storm/pull/2930#discussion_r253941770 ## File path: bin/storm.py ## @@ -234,60 +228,21 @@ def resolve_dependencie

[GitHub] HeartSaVioR commented on a change in pull request #2950: STORM-3327: Use UTF-8 for URL encoding in storm-webapp

2019-02-06 Thread GitBox
HeartSaVioR commented on a change in pull request #2950: STORM-3327: Use UTF-8 for URL encoding in storm-webapp URL: https://github.com/apache/storm/pull/2950#discussion_r254291713 ## File path: storm-client/src/jvm/org/apache/storm/utils/Utils.java ## @@ -246,7 +248,11 @@

[GitHub] HeartSaVioR commented on a change in pull request #2950: STORM-3327: Use UTF-8 for URL encoding in storm-webapp

2019-02-06 Thread GitBox
HeartSaVioR commented on a change in pull request #2950: STORM-3327: Use UTF-8 for URL encoding in storm-webapp URL: https://github.com/apache/storm/pull/2950#discussion_r254292569 ## File path: storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ## @@ -13

[GitHub] srdo commented on a change in pull request #2950: STORM-3327: Use UTF-8 for URL encoding in storm-webapp

2019-02-06 Thread GitBox
srdo commented on a change in pull request #2950: STORM-3327: Use UTF-8 for URL encoding in storm-webapp URL: https://github.com/apache/storm/pull/2950#discussion_r254386329 ## File path: storm-client/src/jvm/org/apache/storm/utils/Utils.java ## @@ -246,7 +248,11 @@ replac

[GitHub] srdo commented on a change in pull request #2950: STORM-3327: Use UTF-8 for URL encoding in storm-webapp

2019-02-06 Thread GitBox
srdo commented on a change in pull request #2950: STORM-3327: Use UTF-8 for URL encoding in storm-webapp URL: https://github.com/apache/storm/pull/2950#discussion_r254386275 ## File path: storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ## @@ -1312,21 +

[GitHub] asfgit merged pull request #2948: STORM-3325: Move storm-webapp to Server module on travis, instead of Externals

2019-02-06 Thread GitBox
asfgit merged pull request #2948: STORM-3325: Move storm-webapp to Server module on travis, instead of Externals URL: https://github.com/apache/storm/pull/2948 This is an automated message from the Apache Git Service. To res

[GitHub] asfgit merged pull request #2949: STORM-3326: Fix FakeMetricConsumer leaking internal lists from getTas…

2019-02-06 Thread GitBox
asfgit merged pull request #2949: STORM-3326: Fix FakeMetricConsumer leaking internal lists from getTas… URL: https://github.com/apache/storm/pull/2949 This is an automated message from the Apache Git Service. To respond to

[GitHub] srdo commented on issue #2956: STORM-3333 provide kafka classes for storm-kafka-monitor

2019-02-06 Thread GitBox
srdo commented on issue #2956: STORM- provide kafka classes for storm-kafka-monitor URL: https://github.com/apache/storm/pull/2956#issuecomment-461135299 +1 This is an automated message from the Apache Git Service. To res

[GitHub] asfgit merged pull request #2930: STORM-3274: Migrates storm CLI to using argparse making documentation…

2019-02-06 Thread GitBox
asfgit merged pull request #2930: STORM-3274: Migrates storm CLI to using argparse making documentation… URL: https://github.com/apache/storm/pull/2930 This is an automated message from the Apache Git Service. To respond to

[GitHub] HeartSaVioR commented on a change in pull request #2950: STORM-3327: Use UTF-8 for URL encoding in storm-webapp

2019-02-06 Thread GitBox
HeartSaVioR commented on a change in pull request #2950: STORM-3327: Use UTF-8 for URL encoding in storm-webapp URL: https://github.com/apache/storm/pull/2950#discussion_r254526989 ## File path: storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ## @@ -13

[GitHub] srdo commented on issue #2939: STORM-3315: Upgrade to Kryo 4

2019-02-07 Thread GitBox
srdo commented on issue #2939: STORM-3315: Upgrade to Kryo 4 URL: https://github.com/apache/storm/pull/2939#issuecomment-461429176 I think making an automated test for this would be a big hassle. The test would need to download Storm 1.2.2 (or some other version using Kryo 3), and set it u

[GitHub] HeartSaVioR commented on issue #2939: STORM-3315: Upgrade to Kryo 4

2019-02-07 Thread GitBox
HeartSaVioR commented on issue #2939: STORM-3315: Upgrade to Kryo 4 URL: https://github.com/apache/storm/pull/2939#issuecomment-461435320 Sorry I think I wasn't clear enough. What I meant was serializing TreeMap to simulate SO issue referred in STORM-3315 instead of checking compatibility w

[GitHub] srdo commented on issue #2939: STORM-3315: Upgrade to Kryo 4

2019-02-07 Thread GitBox
srdo commented on issue #2939: STORM-3315: Upgrade to Kryo 4 URL: https://github.com/apache/storm/pull/2939#issuecomment-461450189 Sorry, I misunderstood. I don't think we should add a test in Storm. It doesn't sound like the issue has anything to do with Kryo's configuration, but wa

[GitHub] HeartSaVioR commented on issue #2939: STORM-3315: Upgrade to Kryo 4

2019-02-07 Thread GitBox
HeartSaVioR commented on issue #2939: STORM-3315: Upgrade to Kryo 4 URL: https://github.com/apache/storm/pull/2939#issuecomment-461457670 OK. I don't have strong voice on adding (possibly redundant) test. Just would like to confirm upgrading Kyro version would resolve the ask on SO, becaus

[GitHub] srdo commented on issue #2939: STORM-3315: Upgrade to Kryo 4

2019-02-07 Thread GitBox
srdo commented on issue #2939: STORM-3315: Upgrade to Kryo 4 URL: https://github.com/apache/storm/pull/2939#issuecomment-461515009 I can't reproduce the issue based on the description in the Kryo issue. Storm seems to serialize the example fine even with Kryo 3.0.3. Maybe we can get

[GitHub] agresch commented on issue #2951: STORM-3328 Allow overriding function name for BasicDRPCTopology

2019-02-07 Thread GitBox
agresch commented on issue #2951: STORM-3328 Allow overriding function name for BasicDRPCTopology URL: https://github.com/apache/storm/pull/2951#issuecomment-461558637 can this be merged? This is an automated message from

[GitHub] HeartSaVioR commented on a change in pull request #2936: STORM-3312: Upgrade Guava to latest version where possible

2019-02-07 Thread GitBox
HeartSaVioR commented on a change in pull request #2936: STORM-3312: Upgrade Guava to latest version where possible URL: https://github.com/apache/storm/pull/2936#discussion_r254871458 ## File path: examples/storm-hbase-examples/pom.xml ## @@ -26,6 +26,11 @@ s

[GitHub] srdo commented on a change in pull request #2936: STORM-3312: Upgrade Guava to latest version where possible

2019-02-07 Thread GitBox
srdo commented on a change in pull request #2936: STORM-3312: Upgrade Guava to latest version where possible URL: https://github.com/apache/storm/pull/2936#discussion_r254886038 ## File path: examples/storm-hbase-examples/pom.xml ## @@ -26,6 +26,11 @@ storm-hb

[GitHub] srdo commented on issue #2936: STORM-3312: Upgrade Guava to latest version where possible

2019-02-07 Thread GitBox
srdo commented on issue #2936: STORM-3312: Upgrade Guava to latest version where possible URL: https://github.com/apache/storm/pull/2936#issuecomment-461612152 Yes, let's wait. 2.0.0 is big enough already :) This is an automa

[GitHub] asfgit merged pull request #2956: STORM-3333 provide kafka classes for storm-kafka-monitor

2019-02-08 Thread GitBox
asfgit merged pull request #2956: STORM- provide kafka classes for storm-kafka-monitor URL: https://github.com/apache/storm/pull/2956 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] kishorvpatil merged pull request #2951: STORM-3328 Allow overriding function name for BasicDRPCTopology

2019-02-08 Thread GitBox
kishorvpatil merged pull request #2951: STORM-3328 Allow overriding function name for BasicDRPCTopology URL: https://github.com/apache/storm/pull/2951 This is an automated message from the Apache Git Service. To respond to t

[GitHub] agresch opened a new pull request #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-08 Thread GitBox
agresch opened a new pull request #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957 This is based on a couple of internal PRs @govind-menon committed to our older version of storm. ---

[GitHub] srdo commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-09 Thread GitBox
srdo commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#discussion_r255291976 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java ##

[GitHub] srdo commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-09 Thread GitBox
srdo commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#discussion_r255291779 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java ##

[GitHub] srdo commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-09 Thread GitBox
srdo commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#discussion_r255294994 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java ##

[GitHub] agresch commented on issue #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-11 Thread GitBox
agresch commented on issue #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#issuecomment-462503941 @srdo - I made the changes you suggested. This is an automated mes

[GitHub] danny0405 commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-13 Thread GitBox
danny0405 commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#discussion_r256701489 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/DefaultScheduler.java ##

[GitHub] danny0405 removed a comment on issue #2723: [STORM-3112] Incremental scheduling supports

2019-02-13 Thread GitBox
danny0405 removed a comment on issue #2723: [STORM-3112] Incremental scheduling supports URL: https://github.com/apache/storm/pull/2723#issuecomment-403672588 @HeartSaVioR I have already attach the test data in the comment, also a test class `LargeAmountsOfTopologiesSchedulingTest.jav

[GitHub] srdo commented on issue #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-14 Thread GitBox
srdo commented on issue #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#issuecomment-463656866 @agresch Thanks, it looks great. I'm wondering if we can put the setup and cleanup in `@Before/@After` for many of the tests? Ideally

[GitHub] danny0405 commented on issue #2723: [STORM-3112] Incremental scheduling supports

2019-02-14 Thread GitBox
danny0405 commented on issue #2723: [STORM-3112] Incremental scheduling supports URL: https://github.com/apache/storm/pull/2723#issuecomment-463879798 @srdo @revans2 @HeartSaVioR Can you please review this for me ? It's so long time since the patch we proposed, i will very appreciate it if

[GitHub] asfgit merged pull request #2953: STORM-3330: Migrate some of storm-webapp to Files API and reduce use …

2019-02-16 Thread GitBox
asfgit merged pull request #2953: STORM-3330: Migrate some of storm-webapp to Files API and reduce use … URL: https://github.com/apache/storm/pull/2953 This is an automated message from the Apache Git Service. To respond to

[GitHub] asfgit merged pull request #2950: STORM-3327: Use UTF-8 for URL encoding in storm-webapp

2019-02-16 Thread GitBox
asfgit merged pull request #2950: STORM-3327: Use UTF-8 for URL encoding in storm-webapp URL: https://github.com/apache/storm/pull/2950 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] agresch commented on issue #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-18 Thread GitBox
agresch commented on issue #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#issuecomment-46490 somehow missed some test files, more changes to come... This is an

[GitHub] MichealShin opened a new pull request #2958: STORM-3341: DRPCSpout should check before connecting to DrpcServer

2019-02-19 Thread GitBox
MichealShin opened a new pull request #2958: STORM-3341: DRPCSpout should check before connecting to DrpcServer URL: https://github.com/apache/storm/pull/2958 Now DRPCSpout always try to connect all Drpc Servers in the method 'open'. If one Drpc server shut down, the topology will restart

[GitHub] agresch commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-19 Thread GitBox
agresch commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#discussion_r258250859 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/DefaultScheduler.java ## @@

[GitHub] agresch commented on issue #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-19 Thread GitBox
agresch commented on issue #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#issuecomment-465330907 @srdo - please look at the latest couple commits for the test cleanup.

[GitHub] kishorvpatil commented on issue #2958: STORM-3341: DRPCSpout should check before connecting to DrpcServer

2019-02-19 Thread GitBox
kishorvpatil commented on issue #2958: STORM-3341: DRPCSpout should check before connecting to DrpcServer URL: https://github.com/apache/storm/pull/2958#issuecomment-465335550 If any one DRPC daemon out of n is down/unavailable during opening of Spout, the DRPCSpout would not serve any req

[GitHub] srdo commented on issue #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-20 Thread GitBox
srdo commented on issue #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#issuecomment-465467654 +1, thanks for addressing comments. This is an automated message from

[GitHub] srdo opened a new pull request #2959: STORM-3342: Add license-maven-plugin configuration, and describe how …

2019-02-20 Thread GitBox
srdo opened a new pull request #2959: STORM-3342: Add license-maven-plugin configuration, and describe how … URL: https://github.com/apache/storm/pull/2959 …to use it https://jira.apache.org/jira/browse/STORM-3342 The plugin is set to fail if a dependency is added without a li

[GitHub] Ethanlm commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-20 Thread GitBox
Ethanlm commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#discussion_r258515801 ## File path: storm-server/src/test/java/org/apache/storm/scheduler/blacklist/TestBlacklistScheduler.java

[GitHub] Ethanlm commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-20 Thread GitBox
Ethanlm commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#discussion_r258516472 ## File path: storm-server/src/test/java/org/apache/storm/scheduler/resource/TestResourceAwareScheduler.j

[GitHub] Ethanlm commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-20 Thread GitBox
Ethanlm commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#discussion_r258518059 ## File path: storm-server/src/test/java/org/apache/storm/scheduler/resource/TestResourceAwareScheduler.j

[GitHub] Ethanlm commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-20 Thread GitBox
Ethanlm commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#discussion_r258521986 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/Constr

[GitHub] Ethanlm commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-20 Thread GitBox
Ethanlm commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#discussion_r258521986 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/Constr

[GitHub] agresch commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-20 Thread GitBox
agresch commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#discussion_r258549982 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/Constr

[GitHub] Ethanlm commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-20 Thread GitBox
Ethanlm commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#discussion_r258518059 ## File path: storm-server/src/test/java/org/apache/storm/scheduler/resource/TestResourceAwareScheduler.j

[GitHub] Ethanlm commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-20 Thread GitBox
Ethanlm commented on a change in pull request #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#discussion_r258562172 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/Constr

[GitHub] agresch commented on issue #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-20 Thread GitBox
agresch commented on issue #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#issuecomment-465659029 @Ethanlm - please check again. Thanks. This is an automated messa

[GitHub] srdo commented on issue #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-20 Thread GitBox
srdo commented on issue #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#issuecomment-465715994 @agresch Thank you for your patience. Please squash to one commit, and I'll merge. --

[GitHub] agresch commented on issue #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-20 Thread GitBox
agresch commented on issue #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957#issuecomment-465739510 @srdo - squashed This is an automated message from the Apache Git

[GitHub] asfgit merged pull request #2957: STORM-3335 allow timing out when scheduling a topology

2019-02-21 Thread GitBox
asfgit merged pull request #2957: STORM-3335 allow timing out when scheduling a topology URL: https://github.com/apache/storm/pull/2957 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] srdo opened a new pull request #2960: STORM-3343: Fix flaky JCQueue test

2019-02-21 Thread GitBox
srdo opened a new pull request #2960: STORM-3343: Fix flaky JCQueue test URL: https://github.com/apache/storm/pull/2960 https://jira.apache.org/jira/browse/STORM-3343 This is an automated message from the Apache Git Service. T

[GitHub] HeartSaVioR commented on a change in pull request #2936: STORM-3312: Upgrade Guava to latest version where possible

2019-02-21 Thread GitBox
HeartSaVioR commented on a change in pull request #2936: STORM-3312: Upgrade Guava to latest version where possible URL: https://github.com/apache/storm/pull/2936#discussion_r258947749 ## File path: examples/storm-hbase-examples/pom.xml ## @@ -26,6 +26,11 @@ s

[GitHub] agresch opened a new pull request #2961: STORM-3344 prevent blacklist scheduler runtime exeception removing fr…

2019-02-22 Thread GitBox
agresch opened a new pull request #2961: STORM-3344 prevent blacklist scheduler runtime exeception removing fr… URL: https://github.com/apache/storm/pull/2961 …om set This is an automated message from the Apache Git Service.

[GitHub] HeartSaVioR opened a new pull request #2962: [MINOR] Update repository URLs from http to https

2019-02-25 Thread GitBox
HeartSaVioR opened a new pull request #2962: [MINOR] Update repository URLs from http to https URL: https://github.com/apache/storm/pull/2962 Confirmed modified URLs also exist. This is an automated message from the Apache Gi

[GitHub] HeartSaVioR opened a new pull request #2963: [MINOR] Update release verify script - 'sha' to 'sha512'

2019-02-25 Thread GitBox
HeartSaVioR opened a new pull request #2963: [MINOR] Update release verify script - 'sha' to 'sha512' URL: https://github.com/apache/storm/pull/2963 Apache Storm's release process has changed to use sha512 instead of sha, but it is not reflected to release verify script. This patch applies

[GitHub] srdo commented on issue #2963: [MINOR] Update release verify script - 'sha' to 'sha512'

2019-02-26 Thread GitBox
srdo commented on issue #2963: [MINOR] Update release verify script - 'sha' to 'sha512' URL: https://github.com/apache/storm/pull/2963#issuecomment-467360180 +1 This is an automated message from the Apache Git Service. To res

[GitHub] asfgit merged pull request #2962: [MINOR] Update repository URLs from http to https

2019-02-26 Thread GitBox
asfgit merged pull request #2962: [MINOR] Update repository URLs from http to https URL: https://github.com/apache/storm/pull/2962 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] asfgit merged pull request #2963: [MINOR] Update release verify script - 'sha' to 'sha512'

2019-02-26 Thread GitBox
asfgit merged pull request #2963: [MINOR] Update release verify script - 'sha' to 'sha512' URL: https://github.com/apache/storm/pull/2963 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] asfgit merged pull request #2962: [MINOR] Update repository URLs from http to https

2019-02-26 Thread GitBox
asfgit merged pull request #2962: [MINOR] Update repository URLs from http to https URL: https://github.com/apache/storm/pull/2962 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] asfgit merged pull request #2963: [MINOR] Update release verify script - 'sha' to 'sha512'

2019-02-26 Thread GitBox
asfgit merged pull request #2963: [MINOR] Update release verify script - 'sha' to 'sha512' URL: https://github.com/apache/storm/pull/2963 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] HeartSaVioR merged pull request #2959: STORM-3342: Add license-maven-plugin configuration, and describe how …

2019-02-26 Thread GitBox
HeartSaVioR merged pull request #2959: STORM-3342: Add license-maven-plugin configuration, and describe how … URL: https://github.com/apache/storm/pull/2959 This is an automated message from the Apache Git Service. To respon

[GitHub] HeartSaVioR merged pull request #2959: STORM-3342: Add license-maven-plugin configuration, and describe how …

2019-02-26 Thread GitBox
HeartSaVioR merged pull request #2959: STORM-3342: Add license-maven-plugin configuration, and describe how … URL: https://github.com/apache/storm/pull/2959 This is an automated message from the Apache Git Service. To respon

[GitHub] HeartSaVioR commented on a change in pull request #2945: STORM-3321: Fix race in LocalCluster regarding Nimbus leadership, red…

2019-02-26 Thread GitBox
HeartSaVioR commented on a change in pull request #2945: STORM-3321: Fix race in LocalCluster regarding Nimbus leadership, red… URL: https://github.com/apache/storm/pull/2945#discussion_r260449850 ## File path: storm-server/src/main/java/org/apache/storm/LocalCluster.java #

[GitHub] HeartSaVioR commented on a change in pull request #2945: STORM-3321: Fix race in LocalCluster regarding Nimbus leadership, red…

2019-02-26 Thread GitBox
HeartSaVioR commented on a change in pull request #2945: STORM-3321: Fix race in LocalCluster regarding Nimbus leadership, red… URL: https://github.com/apache/storm/pull/2945#discussion_r260450781 ## File path: storm-server/src/main/java/org/apache/storm/LocalCluster.java #

[GitHub] HeartSaVioR commented on a change in pull request #2945: STORM-3321: Fix race in LocalCluster regarding Nimbus leadership, red…

2019-02-26 Thread GitBox
HeartSaVioR commented on a change in pull request #2945: STORM-3321: Fix race in LocalCluster regarding Nimbus leadership, red… URL: https://github.com/apache/storm/pull/2945#discussion_r260451686 ## File path: storm-client/src/jvm/org/apache/storm/nimbus/ILeaderElector.java ##

[GitHub] asfgit merged pull request #2960: STORM-3343: Fix flaky JCQueue test

2019-02-26 Thread GitBox
asfgit merged pull request #2960: STORM-3343: Fix flaky JCQueue test URL: https://github.com/apache/storm/pull/2960 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] asfgit merged pull request #2944: STORM-3320: Ensure executors start when worker connections are ready

2019-02-26 Thread GitBox
asfgit merged pull request #2944: STORM-3320: Ensure executors start when worker connections are ready URL: https://github.com/apache/storm/pull/2944 This is an automated message from the Apache Git Service. To respond to th

[GitHub] srdo commented on a change in pull request #2945: STORM-3321: Fix race in LocalCluster regarding Nimbus leadership, red…

2019-02-27 Thread GitBox
srdo commented on a change in pull request #2945: STORM-3321: Fix race in LocalCluster regarding Nimbus leadership, red… URL: https://github.com/apache/storm/pull/2945#discussion_r260636940 ## File path: storm-client/src/jvm/org/apache/storm/nimbus/ILeaderElector.java ## @

[GitHub] srdo commented on a change in pull request #2945: STORM-3321: Fix race in LocalCluster regarding Nimbus leadership, red…

2019-02-27 Thread GitBox
srdo commented on a change in pull request #2945: STORM-3321: Fix race in LocalCluster regarding Nimbus leadership, red… URL: https://github.com/apache/storm/pull/2945#discussion_r260638021 ## File path: storm-server/src/main/java/org/apache/storm/LocalCluster.java ## @@ -

[GitHub] srdo commented on a change in pull request #2945: STORM-3321: Fix race in LocalCluster regarding Nimbus leadership, red…

2019-02-27 Thread GitBox
srdo commented on a change in pull request #2945: STORM-3321: Fix race in LocalCluster regarding Nimbus leadership, red… URL: https://github.com/apache/storm/pull/2945#discussion_r260638213 ## File path: storm-server/src/main/java/org/apache/storm/LocalCluster.java ## @@ -

[GitHub] agresch commented on issue #2961: STORM-3344 prevent blacklist scheduler runtime exeception removing fr…

2019-02-27 Thread GitBox
agresch commented on issue #2961: STORM-3344 prevent blacklist scheduler runtime exeception removing fr… URL: https://github.com/apache/storm/pull/2961#issuecomment-467884209 @HeartSaVioR - I've added a unit test that would have triggered the nimbus restart ---

[GitHub] srdo opened a new pull request #2964: STORM-3347: Don't use maven-exec-plugin in storm-starter

2019-02-27 Thread GitBox
srdo opened a new pull request #2964: STORM-3347: Don't use maven-exec-plugin in storm-starter URL: https://github.com/apache/storm/pull/2964 https://jira.apache.org/jira/browse/STORM-3347 This is an automated message from th

[GitHub] OjhaVivek opened a new pull request #2965: Issue fix - incorrect kafka spout lag error message for newer kafka s…

2019-02-28 Thread GitBox
OjhaVivek opened a new pull request #2965: Issue fix - incorrect kafka spout lag error message for newer kafka s… URL: https://github.com/apache/storm/pull/2965 …pout version but null group id config. See this for more details - https://jira.apache.org/jira/browse/STORM-3348 ---

[GitHub] srdo commented on issue #2965: STORM-3348 incorrect kafka spout lag error message for newer kafka s…

2019-02-28 Thread GitBox
srdo commented on issue #2965: STORM-3348 incorrect kafka spout lag error message for newer kafka s… URL: https://github.com/apache/storm/pull/2965#issuecomment-468431122 Thanks. Looks good. This should go on master as well. Could you raise another PR against master? -

[GitHub] OjhaVivek opened a new pull request #2966: STORM-3348 Incorrect message when group id is not provided as kafka s…

2019-03-01 Thread GitBox
OjhaVivek opened a new pull request #2966: STORM-3348 Incorrect message when group id is not provided as kafka s… URL: https://github.com/apache/storm/pull/2966 …pout config on storm UI See this for more details - https://jira.apache.org/jira/browse/STORM-3348 --

[GitHub] OjhaVivek commented on issue #2965: STORM-3348 incorrect kafka spout lag error message for newer kafka s…

2019-03-01 Thread GitBox
OjhaVivek commented on issue #2965: STORM-3348 incorrect kafka spout lag error message for newer kafka s… URL: https://github.com/apache/storm/pull/2965#issuecomment-468667713 > Thanks. Looks good. This should go on master as well. Could you raise another PR against master? Have rai

[GitHub] OjhaVivek edited a comment on issue #2965: STORM-3348 incorrect kafka spout lag error message for newer kafka s…

2019-03-01 Thread GitBox
OjhaVivek edited a comment on issue #2965: STORM-3348 incorrect kafka spout lag error message for newer kafka s… URL: https://github.com/apache/storm/pull/2965#issuecomment-468667713 > Thanks. Looks good. This should go on master as well. Could you raise another PR against master? H

[GitHub] [storm] srdo opened a new pull request #2967: STORM-3349: Upgrade Hadoop, Hive, HDFS, HBase to latest compatible ve…

2019-03-04 Thread GitBox
srdo opened a new pull request #2967: STORM-3349: Upgrade Hadoop, Hive, HDFS, HBase to latest compatible ve… URL: https://github.com/apache/storm/pull/2967 …rsions https://jira.apache.org/jira/browse/STORM-3349 Testing is limited to the unit tests. I went by the compatibility

[GitHub] [storm] srdo commented on issue #2966: STORM-3348 Incorrect message when group id is not provided as kafka s…

2019-03-05 Thread GitBox
srdo commented on issue #2966: STORM-3348 Incorrect message when group id is not provided as kafka s… URL: https://github.com/apache/storm/pull/2966#issuecomment-469609955 +1. The test failure is unrelated. This is an automat

[GitHub] [storm] srdo commented on issue #2965: STORM-3348 incorrect kafka spout lag error message for newer kafka s…

2019-03-05 Thread GitBox
srdo commented on issue #2965: STORM-3348 incorrect kafka spout lag error message for newer kafka s… URL: https://github.com/apache/storm/pull/2965#issuecomment-469610300 +1 This is an automated message from the Apache Git Se

[GitHub] [storm] asfgit merged pull request #2966: STORM-3348 Incorrect message when group id is not provided as kafka s…

2019-03-05 Thread GitBox
asfgit merged pull request #2966: STORM-3348 Incorrect message when group id is not provided as kafka s… URL: https://github.com/apache/storm/pull/2966 This is an automated message from the Apache Git Service. To respond to

[GitHub] [storm] asfgit merged pull request #2965: STORM-3348 incorrect kafka spout lag error message for newer kafka s…

2019-03-05 Thread GitBox
asfgit merged pull request #2965: STORM-3348 incorrect kafka spout lag error message for newer kafka s… URL: https://github.com/apache/storm/pull/2965 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [storm] srdo commented on issue #2966: STORM-3348 Incorrect message when group id is not provided as kafka s…

2019-03-05 Thread GitBox
srdo commented on issue #2966: STORM-3348 Incorrect message when group id is not provided as kafka s… URL: https://github.com/apache/storm/pull/2966#issuecomment-469612606 JIRA is unstable for me right now. I'll mark the issue resolved later. Thanks for the fix @OjhaVivek. ---

[GitHub] [storm] srdo opened a new pull request #2968: STORM-3350: Upgrade Jackson, ActiveMQ, commons-collections, commons-c…

2019-03-05 Thread GitBox
srdo opened a new pull request #2968: STORM-3350: Upgrade Jackson, ActiveMQ, commons-collections, commons-c… URL: https://github.com/apache/storm/pull/2968 …ompress and require newest Maven https://issues.apache.org/jira/browse/STORM-3350

[GitHub] [storm] srdo commented on issue #2968: STORM-3350: Upgrade Jackson, ActiveMQ, commons-collections, commons-c…

2019-03-05 Thread GitBox
srdo commented on issue #2968: STORM-3350: Upgrade Jackson, ActiveMQ, commons-collections, commons-c… URL: https://github.com/apache/storm/pull/2968#issuecomment-469650891 Reverted change to required Maven version, Travis only has Maven 3.5.2. I'll see if we can update it in a separate PR.

[GitHub] [storm] srdo commented on issue #2968: STORM-3350: Upgrade Jackson, ActiveMQ, commons-collections, commons-c…

2019-03-05 Thread GitBox
srdo commented on issue #2968: STORM-3350: Upgrade Jackson, ActiveMQ, commons-collections, commons-c… URL: https://github.com/apache/storm/pull/2968#issuecomment-469659216 Test failure looks like integration test flakiness. T

  1   2   3   4   5   6   7   8   9   10   >