Re: svn commit: r1302126 - in /tomcat/jk/trunk/native: common/jk_shm.c iis/jk_isapi_plugin.c

2012-03-18 Thread Konstantin Kolinko
() == ERROR_ALREADY_EXISTS) { @@ -199,11 +209,11 @@ int jk_shm_open(const char *fname, size_ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

Re: Taglibs-all Jenkins build

2012-03-18 Thread Konstantin Kolinko
2012/3/19 Jeremy Boynes jboy...@apache.org: On Mar 18, 2012, at 3:33 PM, Jeremy Boynes wrote: On Mar 18, 2012, at 10:42 AM, Konstantin Kolinko wrote: 2012/3/18 Jeremy Boynes jboy...@apache.org: Since this release, I've updated the parent pom to move all the site information into the site

Re: svn commit: r1301284 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/ webapps/examples/WEB-INF/ webapps/examples/WEB-INF/classes/websocket/ webapps/examples/WEB-INF/classes/websocket/chat/ webapps/exa

2012-03-18 Thread Konstantin Kolinko
, but there is no such file. Also webapps/docs/web-socket-howto.xml has not been copied to Tomcat 7. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

Re: svn commit: r1302359 - in /tomcat/trunk: bin/ conf/ java/javax/servlet/jsp/resources/ java/javax/servlet/resources/

2012-03-19 Thread Konstantin Kolinko
unexpanded keyword, and I would expect $Id$ there, not $Id:$. 2. displaying it with an svn client svn cat http://svn.apache.org/repos/asf/tomcat/trunk/bin/catalina.bat will show expanded keyword. Best regards, Konstantin Kolinko

Re: svn commit: r1302359 - in /tomcat/trunk: bin/ conf/ java/javax/servlet/jsp/resources/ java/javax/servlet/resources/

2012-03-19 Thread Konstantin Kolinko
2012/3/19 Konstantin Kolinko knst.koli...@gmail.com: 2012/3/19 Mark Thomas ma...@apache.org: On 19/03/2012 10:25, ma...@apache.org wrote: Author: markt Date: Mon Mar 19 10:25:25 2012 New Revision: 1302359 URL: http://svn.apache.org/viewvc?rev=1302359view=rev Log: Correct some svn keyword

Re: svn commit: r1242101 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/StandardServer.java java/org/apache/catalina/util/ExtensionValidator.java webapps/docs/changelog.xml

2012-03-20 Thread Konstantin Kolinko
that the extension validator checks the JARs in +        the shared and common class loaders for extensions. (markt) +      /fix     /changelog   /subsection   subsection name=Coyote Best regards, Konstantin Kolinko - To unsubscribe, e

Re: svn commit: r1302948 - in /tomcat/trunk/modules/jdbc-pool/src: main/java/org/apache/tomcat/jdbc/pool/ main/java/org/apache/tomcat/jdbc/pool/jmx/ test/java/org/apache/tomcat/jdbc/test/

2012-03-20 Thread Konstantin Kolinko
(); +    } There is no need in the above clone() method. It has the same access level (protected) as super one. I see that PoolProperties is written as implements Cloneable. In such case the clone method is usually redeclared as public one. + + +  } Best regards, Konstantin Kolinko

Re: svn commit: r1303096 - in /tomcat/trunk/modules/jdbc-pool: doc/jdbc-pool.xml src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java

2012-03-20 Thread Konstantin Kolinko
checkstyle issues with trailing spaces and imports formatting. Modified:     tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml     tomcat/trunk/modules/jdbc- pool/src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java Best regards, Konstantin Kolinko

Re: [debug] ( javajni.c:195 ) Invalid RuntimeLib should be a warning or error?

2012-03-20 Thread Konstantin Kolinko
(preferable) so that server admins know right off the bat that they’ve done something wrong. The service wrapper is not part of Tomcat project. It is procrun from Apache Commons Daemon. If you want to file an issue, you should do it there. http://commons.apache.org/daemon/ Best regards, Konstantin

Re: svn commit: r1303082 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException.java

2012-03-21 Thread Konstantin Kolinko
/trunk/modules/jdbc- pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException. java Author: kkolinko Date: Tue Mar 20 18:39:28 2012 New Revision: 1303082 URL: http://svn.apache.org/viewvc?rev=1303082view=rev Log: svn:eol-style = native (...) Best regards, Konstantin Kolinko

Re: svn commit: r1303587 - in /tomcat/trunk/test/org/apache/catalina/tribes: ./ group/ group/interceptors/ test/channel/

2012-03-21 Thread Konstantin Kolinko
, after adding the domain is added. +        TesterUtil.addRandomDomain(channels);     }     public void sendMessages(long delay, long sleep) throws Exception { The rest of changed files seem to be OK. Best regards, Konstantin Kolinko

Re: svn commit: r1304011 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2012-03-22 Thread Konstantin Kolinko
();                             break; Comparing (1) and (2), both are terminating the loop, but the (2)nd block has selector.close() call and (1)st does not have the call. I suspect that both should have the close() call. Best regards, Konstantin Kolinko

Re: svn commit: r1300154 [1/2] - in /tomcat/trunk: ./ java/org/apache/coyote/ java/org/apache/tomcat/util/http/parser/ test/org/apache/tomcat/util/http/parser/

2012-03-22 Thread Konstantin Kolinko
asked. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1304261 - /tomcat/tc7.0.x/trunk/

2012-03-23 Thread Konstantin Kolinko
will cause changes to be ignored if you re-run the merge). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: AJP13: response message with container remote user

2012-03-23 Thread Konstantin Kolinko
2012/3/23 issa.goris...@ext.ec.europa.eu: Hi All, I have several web applications running on distinct tomcat instances. Apache httpd is in front of all the tomcat instances, running as a reverse proxy. Authentication is realized at the container side. Access log files are active on the

Re: svn commit: r1300154 [1/2] - in /tomcat/trunk: ./ java/org/apache/coyote/ java/org/apache/tomcat/util/http/parser/ test/org/apache/tomcat/util/http/parser/

2012-03-23 Thread Konstantin Kolinko
2012/3/23 Mark Thomas ma...@apache.org: On 23/03/2012 01:41, Konstantin Kolinko wrote: 2012/3/13  ma...@apache.org: Author: markt Date: Tue Mar 13 14:39:24 2012 New Revision: 1300154 1)  It seems that quoted text handling (IN_QUOTED_TEXT TOKEN construct) is slightly wrong in its handling

Re: AJP13: response message with container remote user

2012-03-23 Thread Konstantin Kolinko
message.instead of inventing a new message type and marshalling it over the wire. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

Re: svn commit: r1304011 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2012-03-23 Thread Konstantin Kolinko
2012/3/23 Konstantin Kolinko knst.koli...@gmail.com: 2012/3/22  ma...@apache.org: URL: http://svn.apache.org/viewvc?rev=1304011view=rev Comparing (1) and (2),  both are terminating the loop, but the (2)nd block has selector.close() call and (1)st does not have the call. I suspect that both

Re: Move to svnpubsub Was: svn commit: r1305109 [1/6] - ...

2012-03-25 Thread Konstantin Kolinko
the import. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Refresh JK httpd-2.4.x binaries [VOTE] ?

2012-03-26 Thread Konstantin Kolinko
two more votes. +1 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [site] svn up problems

2012-03-26 Thread Konstantin Kolinko
cleanup svn up Svn complains because the old directory is unversioned one. IIRC there is also possible to do svn up --force, but I have not used it. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr

Re: [ANN] Apache Tomcat Connectors 1.2.35 released

2012-03-26 Thread Konstantin Kolinko
the site on p.a.o nearly in parallel during the last minutes. Will log out now. I was there too. Have a nice day! Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

Re: Time for 7.0.27

2012-03-27 Thread Konstantin Kolinko
. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1305931 - in /tomcat/trunk/modules/jdbc-pool: doc/ src/main/java/org/apache/tomcat/jdbc/pool/ src/main/java/org/apache/tomcat/jdbc/pool/jmx/

2012-03-28 Thread Konstantin Kolinko
wait() etc. call immediately when they are called. When the actual interruption happens the exception is created and the flag is cleared.) To propagate the interruption state the code would be if (propagate) { Thread.currentThread().interrupt(); } Best regards, Konstantin Kolinko

Re: MaxQueueSize for Executor and Tomcat 6

2012-03-28 Thread Konstantin Kolinko
. Instructions are at [1], but probably you already know them. If the issue does not get devs' attention, feel free to ping on dev@ list. [1] http://tomcat.apache.org/bugreport.html#How_to_submit_patches_and_enhancement_requests Best regards, Konstantin Kolinko

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-03-28 Thread Konstantin Kolinko
copy of this message in GMail. [1] http://markmail.org/message/uimbvh5sf33it65l [2] http://mail-archives.apache.org/mod_mbox/tomcat-dev/201203.mbox/%3C20120328160023.225BFC00A0%40aegis.apache.org%3E Best regards, Konstantin Kolinko

Re: Two performance problems (found during myfaces testing)

2012-03-28 Thread Konstantin Kolinko
2012/3/9 Konstantin Kolinko knst.koli...@gmail.com: 2012/3/9 Martin Koci martin.kocicak.k...@gmail.com: Hi, we did  performance tests in myfaces core project recently and we found two performance problems in tomcat (7.0.26): 1) javax.el.ExpressionFactory.newInstance() does not cache

Re: svn commit: r1306869 - /tomcat/taglibs/trunks/

2012-03-29 Thread Konstantin Kolinko
When this out directory is created? It is not target as usually in Maven, not output as in Tomcat sources. Where it comes from? Just wondering. 2012/3/29 ol...@apache.org: Author: olamy Date: Thu Mar 29 13:50:31 2012 New Revision: 1306869 URL:

Re: AccessLogValve enhancement

2012-03-29 Thread Konstantin Kolinko
and they are not created unless necessary. The date format is configurable. E.g. it is possible to use it to generate different directories for different dates. IIRC JRE's java.util.logging.FileHandler can be configured to keep n old files, but it uses different naming scheme. Best regards, Konstantin

Re: svn commit: r1306869 - /tomcat/taglibs/trunks/

2012-03-29 Thread Konstantin Kolinko
ol...@apache.org: intellij create that. 2012/3/29 Konstantin Kolinko knst.koli...@gmail.com: When this out directory is created? It is not target as usually in Maven, not output as in Tomcat sources. Where it comes from? Just wondering. 2012/3/29  ol...@apache.org: Author: olamy Date

Re: Time for 7.0.27

2012-03-30 Thread Konstantin Kolinko
2012/3/28 Konstantin Kolinko knst.koli...@gmail.com: 2012/3/27 Mark Thomas ma...@apache.org: The 7.0.x change log is looking long again and with the only open TC7 bugs in NEEDINFO state, I am going to start the process of rolling the 7.0.27 release. I'm not going to tag 7.0.27 until I've

Re: svn commit: r1307514 - in /tomcat/tc7.0.x/trunk: ./ java/javax/el/ResourceBundleELResolver.java test/javax/el/TestResourceBundleELResolver.java webapps/docs/changelog.xml

2012-03-30 Thread Konstantin Kolinko
/ --  Merged /tomcat/trunk:r1307511-1307512 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

Re: svn commit: r1307872 - in /tomcat/site/trunk: README.txt build.properties.default build.xml

2012-03-31 Thread Konstantin Kolinko
components). It is possible to combine a+b. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1307872 - in /tomcat/site/trunk: README.txt build.properties.default build.xml

2012-03-31 Thread Konstantin Kolinko
operation. 2. Delete WEB-INF subdirectories, like it was done http://svn.apache.org/viewvc?rev=1307893view=rev Those WEB-INF subdirectories are needed when documentation is run as a web application on Tomcat, but are not needed when it is published through Apache HTTPD. Best regards, Konstantin Kolinko

Re: svn commit: r1308581 - in /tomcat/site/trunk: docs/resources.html xdocs/resources.xml

2012-04-02 Thread Konstantin Kolinko
; rel=nofollowApache Tomcat 7 Essentials/a/b, by Tanuj Kharebr/ +      iPackt Publishing (03/2012)/i Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail

Re: [VOTE] Release Apache Tomcat 7.0.27

2012-04-03 Thread Konstantin Kolinko
as 7.0.27 Stable Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.27

2012-04-03 Thread Konstantin Kolinko
that working copy. At that time it should be served correctly. [1] http://subversion.apache.org/faq.html#website-auto-update Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java

2012-04-04 Thread Konstantin Kolinko
to stick to the current convention of 80 chars. It is not a hard convention (we do not enforce it through checkstyle), but something to follow. There should be several previous discussions on this topic in the archives... Best regards, Konstantin Kolinko

Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java

2012-04-04 Thread Konstantin Kolinko
also have this description of our coding style: http://tomcat.apache.org/getinvolved.html#Coding_Conventions Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e

Re: svn commit: r1309734 - in /tomcat/trunk: java/org/apache/catalina/startup/UserConfig.java webapps/docs/config/listeners.xml

2012-04-05 Thread Konstantin Kolinko
, home)));         } @@ -348,6 +403,26 @@ public final class UserConfig     } Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

Re: svn commit: r1310541 - in /tomcat/trunk/test/javax: el/TestCompositeELResolver.java servlet/jsp/TestPageContext.java

2012-04-06 Thread Konstantin Kolinko
=org.apache.catalina.startup.SimpleHttpClient.CRLF/ property name=excludes value=org.junit.Assert.*/ /module Best regards, Konstantin Kolinko Modified:    tomcat/trunk/test/javax/el/TestCompositeELResolver.java    tomcat/trunk/test/javax/servlet/jsp/TestPageContext.java Modified: tomcat/trunk

Re: svn commit: r1310541 - in /tomcat/trunk/test/javax: el/TestCompositeELResolver.java servlet/jsp/TestPageContext.java

2012-04-06 Thread Konstantin Kolinko
2012/4/7 Mark Thomas ma...@apache.org: On 06/04/2012 22:16, Konstantin Kolinko wrote: 2012/4/6  ma...@apache.org: Author: markt Date: Fri Apr  6 18:44:19 2012 New Revision: 1310541 URL: http://svn.apache.org/viewvc?rev=1310541view=rev Log: Don't use static imports ? 1. I would say

Re: svn commit: r1310541 - in /tomcat/trunk/test/javax: el/TestCompositeELResolver.java servlet/jsp/TestPageContext.java

2012-04-06 Thread Konstantin Kolinko
2012/4/7 Konstantin Kolinko knst.koli...@gmail.com: 2012/4/7 Mark Thomas ma...@apache.org: On 06/04/2012 22:16, Konstantin Kolinko wrote: 2012/4/6  ma...@apache.org: Author: markt Date: Fri Apr  6 18:44:19 2012 New Revision: 1310541 URL: http://svn.apache.org/viewvc?rev=1310541view=rev

Re: svn commit: r1312006 - in /tomcat/trunk/java/org/apache/catalina/core: AprLifecycleListener.java LocalStrings.properties LocalStrings_es.properties

2012-04-10 Thread Konstantin Kolinko
it were more understandable that it is part of Tomcat-Native). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1325196 - in /tomcat/maven-plugin/trunk: (...)

2012-04-12 Thread Konstantin Kolinko
. There is if missing in Tomcat 6 and the second invocation inside of try{} was not removed. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

Re: working websocket-client in java

2012-04-12 Thread Konstantin Kolinko
. There was a fix fix bug53021/bug: Correct WebSocket protocol version detection. (pero) /fix 2. Debugging Tomcat: http://wiki.apache.org/tomcat/FAQ/Developing#Debugging Best regards, Konstantin Kolinko

Re: Welcome file list in web.xml treats index.jsp different from other filenames

2012-04-13 Thread Konstantin Kolinko
fragments, as specified in the Servlet 3.0 Rev.a specification. If current behaviour contradicts with specification, please cite what point in merging algorithm is not followed. Best regards, Konstantin Kolinko - To unsubscribe, e

Re: CometConnectionManagerValve combined with SimpleTcpCluster

2012-04-13 Thread Konstantin Kolinko
. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1325908 - /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java

2012-04-13 Thread Konstantin Kolinko
the opposite. It should be s/prior/since/ and s/is filtering/is filtered/. If no then I'd note explicitly that Since 2.0 you can no longer use ${}.      *      * @parameter expression=${maven.tomcat.contextFile}      */ Best regards, Konstantin Kolinko

Re: svn commit: r1325908 - /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java

2012-04-13 Thread Konstantin Kolinko
2012/4/14 Konstantin Kolinko knst.koli...@gmail.com: 2012/4/13  ol...@apache.org: Author: olamy Date: Fri Apr 13 19:12:47 2012 New Revision: 1325908 URL: http://svn.apache.org/viewvc?rev=1325908view=rev Log: document new filtering on context file Modified:     tomcat/maven-plugin/trunk

Re: svn commit: r1326941 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/ha/session/ java/org/apache/catalina/tribes/tipis/ webapps/docs/

2012-04-18 Thread Konstantin Kolinko
MSG_ACCESS: return MSG_ACCESS;                 default : return UNKNOWN;             }         } Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

Re: Welcome file list in web.xml treats index.jsp different from other filenames

2012-04-20 Thread Konstantin Kolinko
), but I am not sure that it is a well-defined behaviour. I'd be nice to have this clarified from the specification team (elsewhere). 3. According to chapter 8.1.6 (page #64, 86/230) of the same spec, welcome file list defaults to contain index.htm(l) and index.jsp. Best regards, Konstantin Kolinko

Re: svn commit: r1326941 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/ha/session/ java/org/apache/catalina/tribes/tipis/ webapps/docs/

2012-04-20 Thread Konstantin Kolinko
2012/4/19 Keiichi Fujino kfuj...@apache.org: 2012/4/19 Konstantin Kolinko knst.koli...@gmail.com: What happens if repl variable is true because of complete being true? Shouldn't it be    if (diff (isDirty || complete)) ? I do not quite understand the code, but it seems that omitting

Re: Resolving reference to commons-io-*[0-9T].jar file in a property

2012-04-20 Thread Konstantin Kolinko
target on Gump today and will do the same for tomcat-trunk-validate tomorrow, to remove hard-coded checkstyle version number there. Just warning dev@ in advance in case it breaks. Best regards, Konstantin Kolinko

Re: asp file and session creation

2012-04-20 Thread Konstantin Kolinko
? I am ready to do the development, maybe someone is working on this already ? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

Re: How to configure maxParameterCount

2012-04-25 Thread Konstantin Kolinko
. The default value is 1, too large for me. I need to set it to 1000. How to configure it? That is a question for the users@ list. 1. read Configuration reference part of Documentation 2. edit Connector attributes in server.xml 3. restart Tomcat What is the problem? Best regards, Konstantin Kolinko

Re: Duplicate String values

2012-04-28 Thread Konstantin Kolinko
should be already interned by JVM. So instead of String.intern() it should be possible to call class.getName(). :/ I am OK with your proposal, but I do not expect much savings from getting rid of those duplicates. Does YouKit show some estimates? Best regards, Konstantin Kolinko

Re: svn commit: r1331833 - in /tomcat/maven-plugin/trunk: tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java tomcat7-war-runner/src/main/java/org/ap

2012-04-29 Thread Konstantin Kolinko
= runtimeProperties.getProperty( WARS_KEY ); +                populateWebAppWarPerContext( wars ); +            }         }         // create tomcat various paths Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev

Re: SpdyProxyProtocol class using AJP constants

2012-05-12 Thread Konstantin Kolinko
2012/5/12 Costin Manolache cos...@gmail.com: On Sat, May 12, 2012 at 8:08 AM, Konstantin Kolinko knst.koli...@gmail.comwrote: Hi! The SpdyProxyProtocol class (exists in trunk only)  uses ajp.Constants class:        setSoLinger(Constants.DEFAULT_CONNECTION_LINGER);        setSoTimeout

Re: svn commit: r1336516 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/AbstractEndpoint.java webapps/docs/changelog.xml

2012-05-12 Thread Konstantin Kolinko
. +    public long getConnectionCount() { +        if (connectionLimitLatch != null) { +            return connectionLimitLatch.getCount(); +        } +        return -1; +    } + Best regards, Konstantin Kolinko - To unsubscribe

Re: svn commit: r1337643 - /tomcat/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java

2012-05-12 Thread Konstantin Kolinko
is the cause of an issue if it is just a generic error 500. Maybe just throw a ServletException and let the ErrorReportValve to handle the rest? Well, just blatantly casting to RequestFacade will do effectively the same. +        }     } Best regards, Konstantin Kolinko

Re: svn commit: r1337741 - /tomcat/trunk/webapps/examples/WEB-INF/classes/RequestInfoExample.java

2012-05-13 Thread Konstantin Kolinko
in r1337745. snoop.jsp already filters all values, so it is for consistency as well. Best regards, Konstantin Kolinko Modified:     tomcat/trunk/webapps/examples/WEB-INF/classes/RequestInfoExample.java Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/RequestInfoExample.java URL: http

Re: svn commit: r1335546 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ConnectionState.java

2012-05-14 Thread Konstantin Kolinko
() is called. Should we include this change into 7.0.x? It looks OK, but I have not tested. The svn:externals value in 7.0.x has not been updated yet. Best regards, Konstantin Kolinko Modified:     tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor

Re: tomcat deploywar context.xml

2012-05-21 Thread Konstantin Kolinko
, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1342010 - in /tomcat/native/branches/1.1.x: ./ native/src/poll.c

2012-05-24 Thread Konstantin Kolinko
used sizeof(apr_time_t). +    TCN_CHECK_ALLOCATED(tps-socket_last_active);     tps-nelts  = 0;     tps-nalloc = size;     tps-pool   = p; -    tps-max_ttl = J2T(ttl); +    tps-default_timeout = J2T(ttl); (...) Best regards, Konstantin Kolinko

Re: svn commit: r1342010 - in /tomcat/native/branches/1.1.x: ./ native/src/poll.c

2012-05-24 Thread Konstantin Kolinko
2012/5/24 Konstantin Kolinko knst.koli...@gmail.com: 2012/5/24  ma...@apache.org: Author: markt Date: Wed May 23 20:07:46 2012 New Revision: 1342010 URL: http://svn.apache.org/viewvc?rev=1342010view=rev Log: Renames to make code clearer socket_ttl - socket_last_active max_ttl

Re: svn commit: r1340932 - /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java

2012-05-24 Thread Konstantin Kolinko
between the 150 and 151. Best regards, Konstantin Kolinko Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org

Re: svn commit: r1340918 - /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java

2012-05-24 Thread Konstantin Kolinko
by classifier. I think the comment can be simply removed, as what happens is visible from the code. Best regards, Konstantin Kolinko                         Artifact artifact = -                            artifactFactory.createArtifact( dependency.getGroupId(), dependency.getArtifactId

Re: mod_jk trying to connect to 0.0.0.0

2012-05-24 Thread Konstantin Kolinko
his machine's lookup-service. (OT) That is just how nslookup works. It queries DNS server and does not care about hosts file. Simple ping localhost would be more informative. Best regards, Konstantin Kolinko - To unsubscribe

Re: svn commit: r1341370 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2012-05-24 Thread Konstantin Kolinko
to perform the calculation. Calculation of host's default config path belongs to the host. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

Re: svn commit: r1340215 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2012-05-24 Thread Konstantin Kolinko
from debugging. I will remove the Date object Fixed by http://svn.apache.org/viewvc?view=revisionrevision=1342468 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

Re: [GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2012-05-27 Thread Konstantin Kolinko
-beanutils-gump-25052012.xml into the classpath instead of commons-beanutils-25052012.jar, but it does not change much because that jar does not exist. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr

Re: svn commit: r1343079 - in /tomcat/jk/trunk/native/common: jk_ajp_common.c jk_status.c

2012-05-28 Thread Konstantin Kolinko
, was it supposed to be aw-addr_sequence = aw-s-addr_sequence; ? (I do not really understand it. Just thinking of symmetry and comparing it with the two lines just above the if(), [[[ ++aw-s-h.sequence; aw-sequence = aw-s-h.sequence; ]]] ) Best regards, Konstantin Kolinko     }     if (locked

Re: svn commit: r1343301 - /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java

2012-05-28 Thread Konstantin Kolinko
to allow absolute paths here. E.g. if one wants to move it to the system temporary directory, or to a RAM drive. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands

Re: svn commit: r1342473 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/Http11NioProcessor.java java/org/apache/tomcat/util/net/NioEndpoint.java

2012-05-30 Thread Konstantin Kolinko
of processSendfile() method in NioEndpoint that will ignore one of its parameters and call the correct one. It feels waste, but it is not much to code. Thank you for review. Best regards, Konstantin Kolinko -Original Message- From: kkoli...@apache.org [mailto:kkoli...@apache.org] Sent: Thursday

Re: svn commit: r678 - in /release/tomcat/tomcat-connectors/jk: README.html binaries/windows/README.html

2012-05-31 Thread Konstantin Kolinko
/binaries/windows/README.html ??? What happened to uploads? I don't see .svn for jk (and native) subdirs You forgot to execute svn add before committing? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr

Re: svn commit: r1345021 - in /tomcat/tc7.0.x/trunk: ./ build.xml test/webapp-3.0/bug53257/index.jsp

2012-06-01 Thread Konstantin Kolinko
-pool         exclude name=.*/**/ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

JIRA configuration for MTOMCAT - attachments not allowed?

2012-06-01 Thread Konstantin Kolinko
://issues.apache.org/jira/browse/MTOMCAT-100 https://issues.apache.org/jira/browse/DAEMON-245 Is this issue (configure MTOMCAT to allow attachments) something that we can fix by ourselves, before escalating to infra? Best regards, Konstantin Kolinko

StuckThreadDetectionValve proposal in Tomcat 6 - GitHub link is dead

2012-06-03 Thread Konstantin Kolinko
people.apache.org would have the same effect. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1345367 - in /tomcat/trunk/java/org/apache/catalina: core/ startup/ util/

2012-06-03 Thread Konstantin Kolinko
() ? getSetterFieldName() ? This method creates field name from the name of a setter method. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1345580 - in /tomcat/trunk/java/org/apache/catalina/deploy: LocalStrings.properties NamingResources.java

2012-06-03 Thread Konstantin Kolinko
that there is always common type among injection targets? Can there be two disjoint interfaces A and B, which are both implemented by a resource, so assignment to A or B should succeed, but getInjectionTargetType() will result in a failure? Best regards, Konstantin Kolinko

Re: svn commit: r1344267 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/AbstractHttp11Processor.java test/org/apache/coyote/http11/TestAbstractHttp11Processor.java webapps/docs/changelog

2012-06-04 Thread Konstantin Kolinko
be resp.setHeader(..) in this test servlet here. +resp.flushBuffer(); +resp.getWriter().write(OK); +resp.flushBuffer(); +} +} Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev

Re: svn commit: r1344253 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/ajp/AjpAprProcessor.java webapps/docs/changelog.xml

2012-06-04 Thread Konstantin Kolinko
));             }             outputBuffer.clear(); Looks good. Backport to 6.0? AjpNioProcessor#output(byte[], int, int) seems to have the same issue. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: svn commit: r1335700 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ webapps/docs/

2012-06-04 Thread Konstantin Kolinko
+                request.getMappingData().recycle(); +                mapRequired = true; I think it also needs version = null; here. The version variable is modified in the mapping loop. +            }         }         // Possible redirect Best regards, Konstantin Kolinko

Re: svn commit: r1335700 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ webapps/docs/

2012-06-04 Thread Konstantin Kolinko
2012/6/4 Mark Thomas ma...@apache.org: On 04/06/2012 07:55, Konstantin Kolinko wrote: 2012/5/8  ma...@apache.org: Author: markt Date: Tue May  8 19:07:09 2012 New Revision: 1335700 URL: http://svn.apache.org/viewvc?rev=1335700view=rev Log: It appears that pausing requests for a Context

Tomcat 7 code policy (was: Re: svn commit: r1345848)

2012-06-04 Thread Konstantin Kolinko
and evaluating the feature, and we might well lose a year- without proper testing of the feature. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

Re: Tomcat 7 code policy (was: Re: svn commit: r1345848)

2012-06-04 Thread Konstantin Kolinko
2012/6/5 Konstantin Kolinko knst.koli...@gmail.com: For that reason, I'd like us to be more conscious about our commits on v7 and start looking at v7 as bug fixes and stabilization as the primary drivers for commits. Stabilization usually means that we stop fixing bugs in stable version

Re: svn commit: r1345580 - in /tomcat/trunk/java/org/apache/catalina/deploy: LocalStrings.properties NamingResources.java

2012-06-04 Thread Konstantin Kolinko
2012/6/4 Mark Thomas ma...@apache.org: On 03/06/2012 23:58, Mark Thomas wrote: Konstantin Kolinko knst.koli...@gmail.com wrote: Does something guarantee that there is always common type among injection targets? Can there be two disjoint interfaces A and B, which are both implemented

Re: svn commit: r1341370 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2012-06-04 Thread Konstantin Kolinko
free to re-fix. Re: r1343153, r1343155 Looks good. Thank you. Best regards, Konstantin Kolinko 2012/5/25 Konstantin Kolinko knst.koli...@gmail.com: 2012/5/22  kfuj...@apache.org: Author: kfujino Date: Tue May 22 09:27:00 2012 New Revision: 1341370 URL: http://svn.apache.org/viewvc?rev

Re: svn commit: r1344253 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/ajp/AjpAprProcessor.java webapps/docs/changelog.xml

2012-06-05 Thread Konstantin Kolinko
2012/6/4 Mark Thomas ma...@apache.org: On 04/06/2012 07:41, Konstantin Kolinko wrote: 2012/5/30  ma...@apache.org: Author: markt Date: Wed May 30 13:35:55 2012 New Revision: 1344253 URL: http://svn.apache.org/viewvc?rev=1344253view=rev Log: Fix https://issues.apache.org/bugzilla

Re: svn commit: r1346510 - in /tomcat/trunk: java/org/apache/catalina/core/StandardContext.java java/org/apache/tomcat/util/http/mapper/Mapper.java test/org/apache/tomcat/util/http/mapper/TestMapperCo

2012-06-05 Thread Konstantin Kolinko
Added:     tomcat/trunk/test/org/apache/tomcat/util/http/mapper/TestMapperContextRoot.java svn:eol-style is missing Modified:    tomcat/trunk/java/org/apache/catalina/core/StandardContext.java    tomcat/trunk/java/org/apache/tomcat/util/http/mapper/Mapper.java Best regards, Konstantin Kolinko

Re: svn commit: r1346510 - in /tomcat/trunk: java/org/apache/catalina/core/StandardContext.java java/org/apache/tomcat/util/http/mapper/Mapper.java test/org/apache/tomcat/util/http/mapper/TestMapperCo

2012-06-05 Thread Konstantin Kolinko
); +            if (pass) { +                resp.getWriter().write(OK); +            } else { +                resp.getWriter().write(FAIL); +            } +        } +    } +} Best regards, Konstantin Kolinko - To unsubscribe, e

Re: svn commit: r1346596 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-06-05 Thread Konstantin Kolinko
that is why they are not visible in this proposal. If you are saying about backporting r1346519 to 7.0, I'll do it. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

Re: svn commit: r1346638 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ant/antlib.xml

2012-06-05 Thread Konstantin Kolinko
, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1346638 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ant/antlib.xml

2012-06-05 Thread Konstantin Kolinko
2012/6/6 Mark Thomas ma...@apache.org: On 05/06/2012 23:42, Konstantin Kolinko wrote: 2012/6/6  ma...@apache.org: Author: markt Date: Tue Jun  5 22:38:53 2012 New Revision: 1346638 URL: http://svn.apache.org/viewvc?rev=1346638view=rev Log: Remove unused file Removed:    tomcat/tc7.0.x

Re: Problem updating TC site

2012-06-06 Thread Konstantin Kolinko
2012) https://twitter.com/infrabot/statuses/155072112128831488 So the last time you used svn client on p.a.o should have been before that date. BTW, you can see the same certificate if you open https://svn.apache.org/repos/asf/ in a web browser Best regards, Konstantin Kolinko

Re: svn commit: r1346864 - /tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoMessage.java

2012-06-06 Thread Konstantin Kolinko
this will be useful. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1347087 - in /tomcat/trunk: java/org/apache/naming/resources/BaseDirContext.java test/org/apache/naming/resources/TestNamingContext.java webapps/docs/config/context.xml

2012-06-06 Thread Konstantin Kolinko
, because directory already exists. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: tcnative documentation is broken on tomcat.apache.org

2012-06-07 Thread Konstantin Kolinko
? Apparently it was built from native/trunk, instead of native/branches/1.1.x I'll take care of it. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

Re: tcnative documentation is broken on tomcat.apache.org

2012-06-07 Thread Konstantin Kolinko
2012/6/8 Konstantin Kolinko knst.koli...@gmail.com: 2012/6/8 Christopher Schultz ch...@christopherschultz.net: All, http://tomcat.apache.org/native-doc/ It says that tcnative 2.0.0 has been released, has no date, and links to non-existent files. Same thing with http://tomcat.apache.org

<    5   6   7   8   9   10   11   12   13   14   >