Re: CNCF Landscape

2018-07-01 Thread yuhang xiu
+1 good way to publicize dubbo 2018-07-02 10:13 GMT+08:00 Huxing Zhang : > Hi All, > > At LC3 last month I have talked with the guys from the CNCF about > Dubbo to be part of the CNCF landscape[1]. I got that everyone can > propose it by sending a pull request. > > There are many Apache projects

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]

2018-07-26 Thread yuhang xiu
+1 approve Look nice :) 2018-07-26 17:48 GMT+08:00 Jun Liu : > Hello Dubbo Community, > > This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3. > > The release candidates (RC1): > https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3 > > Git tag for the release

Re: Optimize init LoadBalance in cluster invokers

2018-07-25 Thread yuhang xiu
Ok. Thx :) 2018-07-25 17:30 GMT+08:00 Ian Luo : > cool, we will take a look, and let's discuss on that PR. > > Thanks, > -Ian. > > On Mon, Jul 23, 2018 at 3:34 PM yuhang xiu wrote: > > > Hi community, > > > > I sent a new pr[1] to optimi

Re: [Discuss] Prepare for release of dubbo-2.6.3

2018-07-25 Thread yuhang xiu
Agree +1. I meet a problem with this. I send a pr to 2.6.x (dubbo package) . And also, these code need to push to master (apache package). Then I try to compare 2.6.x and master, the file will display is a new file to master (because of the different package name). If changed, this problem can be

Re: Proposal for deprecated o.a.d.c.extension.Activate#before and #after

2018-08-06 Thread yuhang xiu
+1 As far as I know, very few people use them.And this is a more edge feature 2018-08-06 11:21 GMT+08:00 Yong Zhu : > hi, community > > I've checked the whole source code, these two methods haven't be used. > Instead, #order is used more frequent. > > More important, use these two properties for

Re: Proposal for moving dubbo-rpc-xxx dubbo-serialization-xxx dubbo-remoting-xxx and dubbo-registry-xxx to dubbo ecosystem

2018-08-17 Thread yuhang xiu
Deep agree with this proposal :) Jerrick Zhu 于2018年8月17日周五 下午1:39写道: > I agree with keeping the following modules: > * dubbo-registry-multicast, > * dubbo-rpc-injvm, > * dubbo-serialization-fastjson > * dubbo-serialization-jdk > > They're useful for new users and develop experience. > > On Fri,

[DISCUSS]A new Dubbo ascii logo is wanted

2018-08-21 Thread yuhang xiu
Hello, community, Dubbo's current terminal LOGO is like this: ▄ ████▄ ▀█▄ ▀█▄▄██▄ ███ ▀███ ██████████████████ ██████ ██████ ██████████████████ ██████ ██████ ██████ ▄███▄▄▄██▀

Re: [DISCUSS]A new Dubbo ascii logo is wanted

2018-08-21 Thread yuhang xiu
> -Ian. > > On Wed, Aug 22, 2018 at 12:16 PM yuhang xiu wrote: > > > Hello, community, > >

Re: [DISCUSS]A new Dubbo ascii logo is wanted

2018-08-22 Thread yuhang xiu
>>___ __ __ ______ >> / _ \ / / / / / _ ) / _ ) / __ \ >> / // // /_/ / / _ | / _ |/ /_/ / >> // \/ // // \/ >> >> standard >> >> _ _ ___ >> | _ \ | | | | | __

Re: [ANN] Welcome new committer, carryxyh

2018-08-29 Thread yuhang xiu
Hi community, My name is Yuhang Xiu. I am currently working as a senior JAVA engineer at Netease. I am very happy to be a committer of dubbo to maintain dubbo with everyone. I will do my best to promote Dubbo, solve the issue and submit new features. I will also follow the Apache way of doing

Re: Re: Dubbo new rpc protocol - http2

2018-08-29 Thread yuhang xiu
Nice work for dubbo's multi-language support! I will help to check the demo and code. 秦金卫 于2018年8月29日周三 下午5:42写道: > wonderful.a blog post for how to use may be a nice way to new users. > At 2018-08-29 16:05:58, "Ian Luo" wrote: > >great, I will take a look. > > > >On Wed, Aug 29, 2018 at 2:17

Re: [DISCUSS]A new Dubbo ascii logo is wanted

2018-08-27 Thread yuhang xiu
8 at 3:51 PM Ian Luo wrote: > > > Hi Community, > > > > Pls. come to https://github.com/apache/incubator-dubbo/issues/2332 to > > vote your favorite Dubbo ascii art. > > > > Thanks, > > -Ian. > > > > > > On Wed, Aug 22, 2018 at 3:29 PM yu

Re: [DISCUSS]A new Dubbo ascii logo is wanted

2018-08-27 Thread yuhang xiu
Ok. I will update it soon. Jerrick Zhu 于2018年8月28日周二 上午11:39写道: > On Mon, Aug 27, 2018 at 7:05 PM yuhang xiu wrote: > > > Hi community, > > After a few days of voting[1], the top three LOGOs were: small slant, big > > and standard. > > Among them, small slant won

Re: [Discuss]Suggestion for solve issues more quickly and effectively

2018-07-21 Thread yuhang xiu
Seems it difficult to solve.. Maybe directly @ committers? 2018-07-20 16:00 GMT+08:00 Huxing Zhang : > Hi, > > On Thu, Jul 19, 2018 at 6:11 PM, yuhang xiu wrote: > > I think it is better. > > :) > > > > 2018-07-19 11:04 GMT+08:00 Yong Zhu : > > > &g

Optimize init LoadBalance in cluster invokers

2018-07-23 Thread yuhang xiu
Hi community, I sent a new pr[1] to optimize init LoadBalance in cluster invokers. The LoadBalance will init anyway now, but the AvailableCluster、AvailableClusterInvoker、BroadcastClusterInvoker do not need to init a LoadBalance because they will never use it. So the control of init LoadBalance

Re: [Discuss]Suggestion for solve issues more quickly and effectively

2018-07-23 Thread yuhang xiu
Agree ‘&’. Constantly try the best solution. :) 2018-07-23 16:52 GMT+08:00 Yong Zhu : > On Fri, Jul 20, 2018 at 4:01 PM Huxing Zhang wrote: > > > Hi, > > > > On Thu, Jul 19, 2018 at 6:11 PM, yuhang xiu wrote: > > > I think it is better. > > > :) &

Re: [Discuss]Suggestion for solve issues more quickly and effectively

2018-07-19 Thread yuhang xiu
I think it is better. :) 2018-07-19 11:04 GMT+08:00 Yong Zhu : > How about 'NEED-CLOSE' ? > > On Wed, Jul 18, 2018 at 6:38 PM yuhang xiu wrote: > > > I agree. > > But, is '&' too long to use ? How about a abbreviation > like > > & or sth? > > >

Re: [Discuss]Suggestion for solve issues more quickly and effectively

2018-07-18 Thread yuhang xiu
I agree. But, is '&' too long to use ? How about a abbreviation like & or sth? (Sorry about last mail..) 2018-07-18 18:37 GMT+08:00 yuhang xiu : > I agree. > But, is '&' too long to use ? How about a abbreviation > like & or > > 2018-07-18 18:22 GMT+08:00 Huxin

Re: Meet Dubbo

2018-09-04 Thread yuhang xiu
e, and I like this article :) > > +1 to put on website. > > > > > > 在 2018年9月4日,下午9:36,yuhang xiu 写道: > > > > > > Hi community, > > > > > > I recently wrote an article[1] about my growing up from Dubbo > beginners to > > > a Du

Re: Meet Dubbo

2018-09-04 Thread yuhang xiu
Hi, Thank you for reminding me, I will contact the maintenance staff to try to put the article on the dubbo website. :) Kun Song 于2018年9月4日周二 下午9:56写道: > I think you can post it on the Dubbo website, and I like this article :) > > > 在 2018年9月4日,下午9:36,yuhang xiu 写道: > >

Re: Meet Dubbo

2018-09-05 Thread yuhang xiu
Ok, I will do it soon. Thx! Huxing Zhang 于2018年9月5日周三 下午12:29写道: > On Wed, Sep 5, 2018 at 10:43 AM yuhang xiu wrote: > > > > Hi, > > Thank you for reminding me, I will contact the maintenance staff to try > to > > put the article on the dubbo website. :) > >

Re: Meet Dubbo

2018-09-05 Thread yuhang xiu
午2:42写道: > > > On Wed, Sep 5, 2018 at 2:40 PM yuhang xiu wrote: > > > > > Hi, > > > Ok, I will submit it to dubbo-website after adjustment.I will adjust > the > > > content of the article according to the latest version of dubbo, so > that

Re: Meet Dubbo

2018-09-05 Thread yuhang xiu
is project but I can't > > find > > > a good way to do it before reading this article. > > > Thanks for your sincere sharing. > > > > > > Jerrick Zhu 于2018年9月5日周三 下午2:42写道: > > > > > > > On Wed, Sep 5, 2018 at 2:40 PM yuhang xiu &g

Re: [Enhancement] Replace Random with ThreadLocalRandom

2018-09-04 Thread yuhang xiu
Hi, Good job! There is a similar pr here (using the netty version, copy code): https://github.com/apache/incubator-dubbo/pull/2439 I saw that you submitted a test example about performance. I think it is more recommended to use the jdk version if the gap is not large, so I closed the duplicate

Re: Dubbo demo should be removed

2018-09-05 Thread yuhang xiu
I personally prefer to keep the simple demo. As @Huxing said, it is very convenient to start dubbo with demo. Also agree with that we need to do some documentation updates. Zonghai Shang 于2018年9月5日周三 下午2:22写道: > Hi, Huxing Zhang > > > > Sometimes I find the demo code very useful when you are

Re: The effect of Provider async on the Consumer side

2018-09-09 Thread yuhang xiu
just need to remove method.async in ClusterUtil to solve this problem, and we don't need to modify the URL of the Provider registered in the registry. Huxing Zhang 于2018年9月7日周五 下午11:40写道: > Hi, > > On Wed, Sep 5, 2018 at 3:30 PM yuhang xiu wrote: > > > > Hi community, > >

Meet Dubbo

2018-09-04 Thread yuhang xiu
Hi community, I recently wrote an article[1] about my growing up from Dubbo beginners to a Dubbo Committer. The goal is to give some guidance to those who wish to participate in Dubbo. At the same time, I also took the opportunity to promote Dubbo and let more people deeply participate in Dubbo.

Re: Travis CI failed

2018-09-09 Thread yuhang xiu
Hi, I also checked the log just now and found no problems. I have restarted this task, I will observe the results after a while. YunKun Huang 于2018年9月10日周一 下午1:53写道: > Check this log, it says compile fail on dubbo-common module: > https://travis-ci.org/apache/incubator-dubbo/jobs/426109384 > >

Re: Meet Dubbo

2018-09-05 Thread yuhang xiu
ee you've written couples of articles about Dubbo source > analysis. Could u post them on the website? They're useful, and need to be > exposed. > > On Wed, Sep 5, 2018 at 2:22 PM yuhang xiu wrote: > > > Ok, I will do it soon. > > Thx! > > > > Huxing Zhang

The effect of Provider async on the Consumer side

2018-09-05 Thread yuhang xiu
Hi community, Recently I found a bug[1] in the issue list (submitted by the https://github.com/fingthinking user), which has been verified to be valid. The root cause of the problem is that the Provider registered the method.async to the registry and finally affected the Consumer side. The user

Re: [Proposal]Metadata(URL) problems Dubbo faces and possible solutions

2018-07-05 Thread yuhang xiu
Remove some unused info and use compression maybe better. Integrate other Config Center make operation and maintenance complex. It means that we should deploy a Config Center to use dubbo, not very suitable for me. 2018-07-05 13:48 GMT+08:00 jun liu : > Hello, community > > I have drafted a

Re: Requirements for upgrading the netty4 version

2018-07-04 Thread yuhang xiu
agree. 2018-07-04 17:56 GMT+08:00 Zonghai Shang : > Hi Dubbers! > > Because the `dubbo-rpc-http2` and `etcd3` registry modules have been > scheduled into the development plan, but will rely on the > `netty-http2-codec` feature provided by netty (not supported by netty > version 4.0.35). It is

Re: Local forced trigger mock does not take effect

2018-09-11 Thread yuhang xiu
Hi guys, I also encountered this confusion when I configured the mock in xml. Now it seems that the form of mock=force:return xxx can only be used when dynamically configured using the override protocol, which does not match the configuration of the xml. I think we need to do one of the

Re: [DISCUSS] A metric to measure the response time to issues/prs

2018-09-12 Thread yuhang xiu
Hi, Maintaining dubbo is not the main job of many people, so there may be a delay in processing the pr. In addition, I have a pr that has been placed for more than 30 days, but I don't want it to be merged as soon as possible, but I hope it will be reviewed and recognized by more people. As

Re: The effect of Provider async on the Consumer side

2018-09-11 Thread yuhang xiu
/issues/2321 Huxing Zhang 于2018年9月12日周三 上午9:46写道: > On Mon, Sep 10, 2018 at 10:10 AM yuhang xiu wrote: > > > > Hi Huxing, > > This is because there is a bug that causes them to be inconsistent. We > > removed the async attribute from the Provider in ClusterU

Re: Github Issue template

2018-06-29 Thread yuhang xiu
seems good to me. Maybe a new template just for questions? 2018-06-29 10:19 GMT+08:00 Huxing Zhang : > Hi All, > > I have updated the issue template, how does it look like? > > The current process: > > 1. click the "New issue button" > 2. choose the template > 3. fill in the template and submit

Re: New module for serialization test

2018-10-14 Thread yuhang xiu
Hi, all After @Yunkun Huang's pr[1], the current UT coverage is correct, please review pr[2] again. Thx for @Yunkun Huang and @Xin Wang's help for UT coverage. [1] https://github.com/apache/incubator-dubbo/pull/2643 [2] https://github.com/apache/incubator-dubbo/pull/2632 yuhang xiu 于2018年10月11日

A little thought about the offline meetup

2018-10-15 Thread yuhang xiu
社区,大家好 昨天阿里巴巴集团举行了一个小型的线下meetup,我有幸参与并且与Justin做了一些交流。今天我把我的一点点感想发送出来,希望对大家理解apache的宗旨有一些帮助。 我最大的感想就是apache的态度。我们可以认为apache是结果导向的,apache不对我们做任何要求,印象很深的一句话来自Justin是:大家认为apache有很多规则么?其实apache没有任何规则。apache要求的很简单,强大的社区,更多的贡献者,更大的影响力,更多人响应问题,稳定的版本迭代等等。

Re: A preformance issue And Optimizing RoundRobinLoadBalance

2018-10-16 Thread yuhang xiu
I made a simple review of your pr. 1. Unnecessary code moving. 2. Code style. 3. Using percent to calculate the result of select is unstable.

Re: Temporary Inactivity for Dubbo

2018-10-17 Thread yuhang xiu
Hello, huxing! I saw an issue you submitted on the issue list before, which is that user can't configure the forks for ForkingCluster in xml. I have submitted pr[1] to fix it, and I hope that you can review it after November 11. Looking forward to your coming back. :) [1]

Re: add swagger support to dubbo ops

2018-10-17 Thread yuhang xiu
Agree and expect ! Minxuan Zhuang 于2018年10月17日周三 下午5:13写道: > good advice, I've created one: > https://github.com/apache/incubator-dubbo-ops/issues/140 > > On Wed, Oct 17, 2018 at 4:52 PM Ian Luo wrote: > > > The swagger support is now in place. Minxuan and Ma, should we file one > > issue to

Re: Increase the schedule frequency of HeartbeatTask.

2018-10-18 Thread yuhang xiu
Hi, everyone I have already completed this work. Currently pr is here: https://github.com/apache/incubator-dubbo/pull/2658 Anyone willing to review it? Ian Luo 于2018年10月16日周二 下午2:38写道: > sounds great. > > On Tue, Oct 16, 2018 at 2:20 PM yuhang xiu wrote: > > > Hi, Ian! >

Re: Increase the schedule frequency of HeartbeatTask.

2018-10-16 Thread yuhang xiu
y for review? > > Thanks, > -Ian. > > On Thu, Oct 11, 2018 at 10:41 AM yuhang xiu wrote: > > > Hi, community > > > > I recently saw an issue[1] from @chickenlj about the frequency of > heartbeat > > detection. Due to the very low frequency of our heartbeat

Re: [ANN] Welcome new committer Jinkai Ma

2018-10-29 Thread yuhang xiu
Hi, jinkai Congratulations on your joining! Jun Liu 于2018年10月30日周二 上午11:15写道: > > > > On Oct 30, 2018, at 11:12 AM, Jun Liu wrote: > > > > Hi, Community, > > > > On behalf of the Dubbo PPMC, I am pleased to announce that Jinkai Ma, > whose github id is majinkai, has been voted in as a new

Re: [DISCUSS] should we include gson support in main trunk

2018-10-31 Thread yuhang xiu
Agree with u. The serialization method of json is also much slower than hessian and kryo, and the data is relatively large. We don't have to support all json serialization. But just put it into ecosystem. YunKun Huang 于2018年11月1日周四 上午10:17写道: > For same purpose I prefer to have only one

Re: [ANN] New PPMC member: Shang Zonghai

2018-11-01 Thread yuhang xiu
Congratulations! :) Huxing Zhang 于2018年11月1日周四 下午8:59写道: > Hi, Community, > > On behalf of the Dubbo PPMC, I am pleased to announce that Shang > Zonghai, aka yiji[1], has been voted in as a new Dubbo PPMC member. > > Please join me to say congratulations to him! > > [1]

Re: pull request #2647: [Dubbo-2578]Smooth Round Robin selection

2018-10-24 Thread yuhang xiu
ut the KEY. > Now the key is defined by Method (which can make method's invocation RR). > If we change it into by Service (which the method will not be RR if its > invocations just match a round) the memory issue may looked better. > > > So what do other guys think about? > > >

Re: pull request #2647: [Dubbo-2578]Smooth Round Robin selection

2018-10-24 Thread yuhang xiu
你好, 我个人认为我们应该在smooth和性能之间做一个取舍。我个人倾向于使用非smooth的方式,原因: 1.使用smooth需要增加线程开销或者增加内存开销,或者用锁来增加了性能开销,就像 @jason 说的那样。而本身负载均衡是一个很轻量的组件,我们是否有必要把他做的这么复杂? 2.我承认smooth的方式更好,但是如果我们把一个provider的权重设置为特定的值,那么说明他能承受相应的请求量,不管是N个请求同时进行还是分开进行。如果这个provider承受不住同时进行N个请求,我们需要做的应该是把他的权重调低。

Re: Optimize retry in failbackregistry.

2018-11-08 Thread yuhang xiu
/incubator-dubbo/pull/2763 Ian Luo 于2018年11月7日周三 下午5:58写道: > looks like it's worthy to try. I noticed that you tagged it with > 'first-good-issue'. Let's see if there's any volunteer. > > Regards, > -Ian. > > On Wed, Nov 7, 2018 at 5:27 PM yuhang xiu wrote: > > >

Optimize AbstractConfig toString method

2018-11-08 Thread yuhang xiu
Hi, community Today @code4wt submitted a pr[1] call to getObject for optimizing the abstractConfig toString method, which caused some error messages and unexpected results when debugging. He gave a detailed analysis of the recurring problem and the cause of the problem [2], I personally think

Re: dubbo使用中的疑问

2018-11-08 Thread yuhang xiu
> > > 另外由于method/service均可设置该属性,多个属性会叠加这个问题 > 我对着保持怀疑态度,晚点我会仔细check一下 我也对这个存疑,目前来看method的connections属性对整体的连接数影响我还没有发现。测试了一下发现method设置的connections不会起作用。 Zonghai Shang 于2018年11月9日周五 上午11:16写道: > Hi, > > > 另外由于method/service均可设置该属性,多个属性会叠加这个问题 > > 我对着保持怀疑态度,晚点我会仔细check一下 > > -yiji > > Zonghai

Re: Optimize retry in failbackregistry.

2018-11-11 Thread yuhang xiu
t; Hi, > > > > > > I think the `HashWhell` feature is very good. I read pr carefully and > > left > > > some suggestions, please take a look. > > > > > > -yiji > > > > > > yuhang xiu 于2018年11月9日周五 上午6:06写道: > > > > &g

Re: [ANN] Welcome new committer Zhenqiang Yi

2018-11-11 Thread yuhang xiu
Enjoy your trip to Dubbo! Congratulations!!! 大步流星 <835576...@qq.com> 于2018年11月12日周一 上午10:33写道: > Hi, all: > > > I am very honored and very happy to be part of the Dubbo family! ! My name > is Yi Zhenqiang, from Zhuzhou, Hunan. I joined Didi Hangzhou in May 2015. I > used Dubbo for the first

Re: Transfer wiki New Committer Guide to Official website

2018-11-16 Thread yuhang xiu
Hi, Agree with u. When I became a committer, I referenced the version of Xin Wang's blog [1] and asked him some questions. The new committer can also refer to this Chinese document for the time being. Of course, you can also email specific people.

Optimize retry in failbackregistry.

2018-11-07 Thread yuhang xiu
Hi, community Recently I will begin to optimize the retry process of FailbackRegistry. Currently our retry will start executing when the FailbackRegistry starts. We can completely retry it more regularly. At present, we have five collections that need to be checked regularly. Why not check

Re: [DISCUSS] solution for issue 2489

2018-11-07 Thread yuhang xiu
Hi, @jsen-joker, @zhonhaishang Since the pr has been merged, I will close the related issue[1] and the same pr[2]. [1]https://github.com/apache/incubator-dubbo/issues/2489 [2]https://github.com/apache/incubator-dubbo/pull/2527 Ian Luo 于2018年11月7日周三 下午2:37写道: > > > > Can we simply merge this

Re: Netty epoll support for dubbo

2018-11-05 Thread yuhang xiu
Hi, yiji I did some review under your pr. There is a problem I can't decide, about the transparent issue of the epoll attribute. Epoll performance is good, when we do not configure epoll on the Consumer side, if the Consumer is also using the Linux system and the Provider is configured with

Re: Meetup in Hangzhou

2018-11-13 Thread yuhang xiu
Very looking forward to the meetup in Hangzhou! I will definitely attend. Ian Luo 于2018年11月14日周三 下午1:44写道: > +1 with the proposal. Hangzhou is a city where Dubbo is popular. We should > throw a meetup here as soon as possible. > > -Ian. > > On Wed, Nov 14, 2018 at 11:48 AM Huxing Zhang wrote:

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.5 [RC1]

2018-11-15 Thread yuhang xiu
I am very sorry that I did not respond in time. I have checked the things on the release note and the corresponding issue and pr. I think there is no problem and I agree to release it. +1 for release. Jun Liu 于2018年11月15日周四 下午4:22写道: > +1. > > 1. Source release package: > * Hash and signature

Re: [ANN] Welcome new committer Victory Cao

2018-11-15 Thread yuhang xiu
congratulations! Jun Liu 于2018年11月15日周四 下午4:23写道: > Hi, Community, > > On behalf of the Dubbo PPMC, I am pleased to announce that Victory Cao, > whose github id is cvictory, has been voted in as a new Dubbo committer. > > Please join me to say congratulations to him! > > Victory, would you

Re: dubbo使用中的疑问

2018-11-09 Thread yuhang xiu
Hi I have submit a related issue[1] for discussing the connections setting on method. Looking forward to your opinions. [1]https://github.com/apache/incubator-dubbo/issues/2769 Ian Luo 于2018年11月9日周五 上午11:29写道: > google translation for yiji's reply: > > Dubbo default value will be reused to

Re: Fix disable provider does’t work.

2018-11-04 Thread yuhang xiu
Hi I add related issue which is listed in dubbo issue list in the comment. Seems like disable provider also has sth wrong when a provider is in group. Zonghai Shang 于2018年11月5日周一 上午11:15写道: > Hi, > > sure, done > > new issue: https://github.com/apache/incubator-dubbo-ops/issues/177 > > yiji >

New module for serialization test

2018-10-09 Thread yuhang xiu
Hi, community. Today I found that the unit testing of dubbo's serialization module has serious code duplication problems, mainly on several pojo classes, such as BigPerson, PersonInfo, and so on. These classes even appear in the dubbo-common module. I think this repeated POJO class is not

Re: New module for serialization test

2018-10-10 Thread yuhang xiu
t; And I recently encountered this problem when support Protobuf > > serialization: https://github.com/apache/incubator-dubbo/pull/2618 < > > https://github.com/apache/incubator-dubbo/pull/2618>. > > > > Looking forward it! > > > > > 在 2018年10月9日,下午

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.4 [RC1]

2018-09-27 Thread yuhang xiu
agree. I checked the release note[1] for 2.6.4 and it is OK. [1]https://github.com/apache/incubator-dubbo/issues/2305 Jerrick Zhu 于2018年9月27日周四 上午11:21写道: > On Wed, Sep 19, 2018 at 4:42 PM jun liu wrote: > > > +1 (binding) > > > > I have checked, > > * signatures and hashes are good > > *

Some questions about Spring3CompatibilityTest

2018-09-27 Thread yuhang xiu
I have some questions about the org.apache.dubbo.test.Spring3CompatibilityTest class. 1. This class will currently throw nullpointerexception 2. Is this class still in use today? Can I delete it? There is a related issue here: https://github.com/apache/incubator-dubbo/issues/2576

Increase the schedule frequency of HeartbeatTask.

2018-10-10 Thread yuhang xiu
Hi, community I recently saw an issue[1] from @chickenlj about the frequency of heartbeat detection. Due to the very low frequency of our heartbeat detection, some idle channels may not send heartbeats in time. I will start working on this issue in the near future, as follows: 1. Use

Re: New module for serialization test

2018-10-11 Thread yuhang xiu
://docs.codecov.io/docs yuhang xiu 于2018年10月10日周三 下午4:06写道: > Hi, jerrick > > At present, I don't think this universal test module is necessary. > > The reason is that in general, only the serialization module has more > requirements for the POJO class, and the test modules of other modul

Re: slow on pull request and issue

2018-12-29 Thread yuhang xiu
Hi, community I personally encountered problems similar to @beiwei. Before New Year's Day, I had a lot of work to do. There is not much time in the last week to solve problems in the community. My work will start to be easier next week, and I will fix it next week: 1. doc related pr @majinkai 2.

Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

2019-01-16 Thread yuhang xiu
awesome. Looking forward to dubbo 2.7. I just looked at the milestones of 2.7. It looks like there is no problem. Huxing Zhang 于2019年1月17日周四 上午10:42写道: > Hi All, > > I am seeing that all the issue has been cleaned for the 2.7.0 milestone. > It looks like all the things have been settled, I am

Re: Propose to add [End User Discussion] in Dubbo Guangzhou Meetup

2019-01-14 Thread yuhang xiu
Hi, I have participated in the meetup of hangzhou, we have a questioning session in the gap between each topic. When I participated in the meetup, many people were very active, and many people in each questioning session wanted to ask questions. But in general, in order to control the time of the

Re: Next steps of projects in Dubbo group

2019-01-14 Thread yuhang xiu
Agree. Awesome extension. Another thing, I noticed that @ningyu provides a dubbo-jmeter test tool, do we need to transfer it to ASF as well? https://github.com/dubbo/jmeter-plugins-dubbo Huxing Zhang 于2019年1月15日周二 上午10:12写道: > Hi, > > Recently I am doing the maven release process, I found the

Re: [Proposal] A proposal to use IdleStateHandler to replace using Timer to send HeartBeat.

2019-01-21 Thread yuhang xiu
Hi, jingfeng, I saw beiwei merge your pr, nice work! However, I think we still need to consider two things. Since we are using a shared timer, this timer will not be closed when a client is closed. In this case, we need to control our tasks without unlimited growth. My current practice is to

Re: Use longObjectMap to increase performance

2018-12-12 Thread yuhang xiu
2018年12月7日周五 上午11:15写道: > On Tue, Dec 4, 2018 at 9:43 PM Huxing Zhang wrote: > > > > Hi, > > > > On Tue, Dec 4, 2018 at 4:24 PM yuhang xiu wrote: > > > > > > Hi, community > > > At present, there are many Map type maps in dubbo. When > usi

Re: Re: Use longObjectMap to increase performance

2018-12-12 Thread yuhang xiu
need to > replace. > At 2018-12-13 10:22:20, "yuhang xiu" wrote: > >Hi, all > >Recently, @y1317427691 claimed this part of the work on github, he will > >start in the near future. > >According to my personal assumptions, we need to investigate the > &g

Re: About the comments coverage of the code

2018-12-18 Thread yuhang xiu
Hello, Dave. (2) Have any committers reached out to the users who had trouble with code > comments to confirm these efforts will meet their concerns? > I used to talk to them, but I forgot to ask them about what kind of docs are better. But don't worry, I still have their contact details. I

Re: About the comments coverage of the code

2018-12-17 Thread yuhang xiu
the code on the 2.6.x branch during the review. If the comments can be shared, we need to remind the submitter. Let them submit the comments to the 2.6.x branch as well. What do you think? yuhang xiu 于2018年12月11日周二 上午10:02写道: > Ok, huxing > I'd like take some time to do this. > > Huxing Zhan

Re: AccessLogFilter simple date format instance creation change PR

2018-12-27 Thread yuhang xiu
Hi, I simply checked your pr and I agree with you. I will review it. Nice work! Imteyaz Khan 于2018年12月27日周四 下午5:35写道: > Hi All, > I have raised a separate PR for the same issue 3026. > > https://github.com/apache/incubator-dubbo/pull/3080 > > As my old PR was containing may commits of others

Re: About the comments coverage of the code

2018-12-10 Thread yuhang xiu
Ok, huxing I'd like take some time to do this. Huxing Zhang 于2018年12月10日周一 下午11:43写道: > On Mon, Dec 10, 2018 at 7:14 PM yuhang xiu wrote: > > > > Hi, > > @zhuzi @shunyumaple > > You are welcome to claim a new job. > > > > We currently have a project, bu

Re: [Integration] Dubbo integrates with Nacos as a registry

2018-12-12 Thread yuhang xiu
Nice work, @khan I saw that you helped us to review a lot of PR, welcome you to make more contributions, I am looking forward to it. :) Imteyaz Khan 于2018年12月12日周三 下午4:00写道: > Sure, I will do that. > > Regards > Imteyaz > > On 12 Dec 2018 1:13 p.m., "Mercy" wrote: > > > Hi, Imteyaz, > > > >

Re: Telnet optimization suggest

2018-12-17 Thread yuhang xiu
Hi, about overloading, here is an issue to track: https://github.com/apache/incubator-dubbo/issues/2766 Regarding the group problem, it is currently impossible to execute a service under a specific group. This is a point that can be optimized. Would u have some ideas? yeling 于2018年12月17日周一

Re: Telnet optimization suggest

2018-12-17 Thread yuhang xiu
Welcome! Do u have some ideas about telnet? IMO, this way is very good: list: [1] listUser(Integer id) [2] listUser(String name) When we use invoke, we can do like this: invoke 1 params There has a line number or id or sth else with one invokable method. This can make this clear. 李振

Re: about issues-2425

2018-12-24 Thread yuhang xiu
Hello, yeling, I checked the code of the old version. Since the current retry process will execute failed.remove(invocation); anyway, this will cause our retry to be done only once. I think this is a bug in the current failback. I have given a few reviews about your pr. I need you to improve

Re: [DISCUSSION] Call for ideas and suggestions on v2.7.0 designs and implementations.

2018-12-24 Thread yuhang xiu
Hi, all I also found out that the master ci has failed. This caused some misunderstanding for me to deal with a pending pr[1]. After observing the log, I found that the issue[2] with @xin wang feedback is the same problem. Since the ci of the module of the cluster has passed and the code is well,

[DISCUSS] We need more advice about pr 2964

2018-12-25 Thread yuhang xiu
Hi, all Recently I found a pr about repairing issue 2881[1] submitted by @cvictory. Currently due to the merger of dubbox, dubbo has the ability to register classes to kryo(fst) at startup. In a distributed scenario, kryo's serialization approach can cause problems. @cvictory is currently

Re: [ANN] New PPMC member: Yuhang Xiu

2018-12-20 Thread yuhang xiu
Hi, Thank u all. :) Huxing Zhang 于2018年12月20日周四 下午4:49写道: > Congratulations! > > On Thu, Dec 20, 2018 at 4:37 PM Xin Wang wrote: > > > > Hi Community, > > > > On behalf of the Dubbo PPMC, I am pleased to announce that Yuhang Xiu[1] > > has b

Re: Repeated content in dubbo 2.6.4's internal content

2018-11-28 Thread yuhang xiu
t 3:47 PM Ian Luo wrote: > > > This issue is worthy a separated issue. I will file it. > > > > -Ian. > > > > On Wed, Nov 28, 2018 at 10:13 AM yuhang xiu wrote: > > > >> Hi, community > >> > >> Recently, a user commit a issue[1]

Use longObjectMap to increase performance

2018-12-04 Thread yuhang xiu
Hi, community At present, there are many Map type maps in dubbo. When using this kind of map, jdk performs automatic package. We can use longObjectMap(or intObjectMap or sth else) to replace these maps and add some performance. Similarly, I have opened an issue[1] to track the progress. Of

About the comments coverage of the code

2018-12-04 Thread yuhang xiu
Recently dubbo held an offline meetup. When discussing with many participants, many people have suggested that dubbo has very few comments. Comments are very important for us to understand the code. If our comments are few, it is very unfriendly for new developers. I created a new issue[1] to

Re: Wanted to assist dubbo community on issue #2884

2018-12-05 Thread yuhang xiu
very sorry. I have some work now, so I didn't respond to your email in time. I am very willing to help you with the completion of the comments. If you are a newbie, I suggest you start with a simple logic. Which parts of the logic are relatively simple? At present, I think that our filter-related

Re: Wanted to assist dubbo community on issue #2884

2018-12-05 Thread yuhang xiu
In addition, we strongly encourage open discussion. You can post your comments on a Filter directly here. There will be some people who know more about dubbo to review and discuss. Of course, any problem can be raised here. We will answer as soon as possible. yuhang xiu 于2018年12月5日周三 下午8:58写道

Re: New contributors for community

2018-12-07 Thread yuhang xiu
ote: I > has just talked to you in wechat yesterday .  yuhang xiu < > carry...@gmail.com> 于2018年12月7日周五 下午5:07写道: > they are my friends. I > didn't know you before, so there is no way to > contact you. > > But > welcome to dubbo. Next time I will distribute the issue d

Re: [DISCUSS] A robot for Dubbo to help the community collaboration

2018-12-06 Thread yuhang xiu
Great, this robot is very interesting. Netty also has a similar robot[1] that can control whether or not to perform unit tests (some pr can be judged that we won't accept them during the review phase), I think we can also try this. Another feature. It will leave a comment said: 'Can one of the

Re: Wanted to assist dubbo community on issue #2884

2018-12-05 Thread yuhang xiu
= > > Constants.CACHE_KEY) > > public class CacheFilter implements Filter { > > > > > > > > . > > > > } > > > > > > On Wed, Dec 5, 2018 at 8:20 PM Imteyaz Khan > wrote: > > > > > Just to make sure I h

Re: Wanted to assist dubbo community on issue #2884

2018-12-05 Thread yuhang xiu
2018 at 7:00 PM Imteyaz Khan > wrote: > > > Thanks a lot for the start, much appreciated. > > > > > > > > On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu wrote: > > > >> In addition, we strongly encourage open discussion. > >> You can post you

New contributors for community

2018-12-07 Thread yuhang xiu
社区的各位大家好。 前几天,我发送了一封邮件,关于我会分发一些issue给一些对dubbo有兴趣的新人,让他们参与到dubbo中,从而更好的建设整个社区。 在早些时候,我分发了四个issue给四个新人,他们分别是下面四个PR的作者: https://github.com/apache/incubator-dubbo/pull/2831 https://github.com/apache/incubator-dubbo/pull/2893 https://github.com/apache/incubator-dubbo/pull/2822

Re: New contributors for community

2018-12-07 Thread yuhang xiu
的各项社区活动。 > > 初来乍到,还有许多的知识向大家学习,还望以后的时间多多指教。~ > > > > > > -- Original -- > > From: yuhang xiu carry...@gmail.com > > Date: Fri,Dec 7,2018 4:49 PM > > To: dev dev@dubbo.apache.org > > Subject: Re: New contributors for community > > >

Re: New contributors for community

2018-12-07 Thread yuhang xiu
ute to the community too. > You can assign some issues to me . > > yuhang xiu 于2018年12月7日周五 下午4:49写道: > > > 社区的各位大家好。 > > > > 前几天,我发送了一封邮件,关于我会分发一些issue给一些对dubbo有兴趣的新人,让他们参与到dubbo中,从而更好的建设整个社区。 > > > > 在早些时候,我分发了四个issue给四个新人,他们分别是下面四个PR的作者: > > https://gi

Re: About the comments coverage of the code

2018-12-09 Thread yuhang xiu
very nice. If there is any progress, you can tell us here. 雷舜宇 于2018年12月10日周一 下午12:03写道: > I said that I am currently doing the service-completed comments completion > work. If there is a problem, I will exchange this on the mailing list. > > 田 小波 于2018年12月10日周一 上午10:03写道: > > > OK, I will

Re: About the comments coverage of the code

2018-12-10 Thread yuhang xiu
be done by multiple people, as long as there is no conflict. 竹子 于2018年12月10日周一 下午2:34写道: > 我现在正在补全dubboprotocal的注释 竹子 邮箱zhuzi.w...@gmail.com 签名由 网易邮箱大师 定制 On > 12/10/2018 14:28, yuhang xiu wrote: very nice. If there is any progress, > you can tell us here. 雷舜宇 于2018年12月10日周一 > 下午

  1   2   >