).
- Kirk Lund
On June 16, 2015, 11:18 p.m., William Markito wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35542
+1
Welcome Jun!
On Friday, June 12, 2015, jun aoki ja...@apache.org wrote:
Hi Geode community
My name is Jun Aoki and I work for Pivotal's Ambari project, and am super
excited to contribute to Geode!
I'd like to propose a few things about contribution process.
The Geode community should
Hi Jun,
Here's some info on Geode tests.
1) junit
These are unit tests involving mocks as well as end-to-end functional
tests. These are currently marked with @Category(UnitTest.class) or
@Category(IntegrationTest.class).
We need to encourage Geode developers to write a lot of more of the
1) System Rules for JUnit 4
I really like System Rules for JUnit 4. This library has been added to our
build on GitLabs develop but not in ASF git yet
http://stefanbirkner.github.io/system-rules/. This line resets all System
Properties changes you make in your tests:
@Rule
public final
According to https://wiki.apache.org/incubator/July2015, the podling report
is due today. I don't see where I'm supposed to submit it to though.
I'm not seeing any answers on
http://incubator.apache.org/guides/mentor.html#Sending+in+an+Incubation+Report
either.
Any pointers on where to send or
Yeah, the LocatorLauncher is intended to be an API for starting a
Locator in your local JVM or to use as the main when starting a new JVM.
You don't need to have a gemfire.properties file. You can programmatically
define all of your config options at runtime and either feed them in via
the
Geode
Geode is a data management platform that provides real-time, consistent
access
to data-intensive applications throughout widely distributed cloud
architectures.
Geode has been incubating since 2015-04-27.
Three most important issues to address in the move towards graduation:
1.
I just want to clarify that the reason we are planning to repackage is
because of this policy:
http://incubator.apache.org/guides/mentor.html#repackaging
...which states that repackaging is recommended, but not mandated. Is there
a different source that states that it's mandated?
-Kirk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36221/#review90591
---
Ship it!
Ship It!
- Kirk Lund
On July 6, 2015, 9:55 p.m., Dan
.
On Wed, Jul 1, 2015 at 4:20 PM, Kirk Lund kl...@pivotal.io wrote:
Geode
Geode is a data management platform that provides real-time,
consistent
access
to data-intensive applications throughout widely distributed cloud
architectures.
Geode has been
Yep, having 99% of the code in org.apache.geode pkgs with 1% in
com.gemstone.gemfire pkgs just to facilitate rolling upgrades seems like
something that would be reasonable to discuss on general@incubator.
On Thu, Jul 2, 2015 at 12:35 PM, Bruce Schuchardt bschucha...@pivotal.io
wrote:
Hey, if
I would think that github would be a better option for the Spark Geode
Connector. That way it's not tightly coupled to the Geode release cycle.
I don't see why it's desirable to bloat Geode with every single script,
tool, or connector that might interact with Geode.
Another reason to consider
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37400/#review95197
---
Ship it!
Ship It!
- Kirk Lund
On Aug. 12, 2015, 5:16 p.m
Check here to see if ASF already knows about it: http://status.apache.org/
If the problem isn't shown on that status page then report it in the ASF
infra hipchat: http://infra.chat/
-Kirk
On Wed, Aug 19, 2015 at 9:49 AM, Bruce Schuchardt bschucha...@pivotal.io
wrote:
I get the same error
I don't have any ideas about the cause without looking at the full
stack of RegionDestroyedException
and the rest of the logs. We haven't been seeing anything like this so I
would expect it to be a real bug that was committed.
It might be caused by race condition(s) in either the test or the
bbc2a5fa5f0bbcd00a8ab64451a2528a22d88bc0
Merge: 9efe74e 581702a
Author: Kirk Lund kl...@pivotal.io
Date: Wed Aug 19 16:09:21 2015 -0700
Merge branch 'feature/GEODE-213' into develop
commit 581702ac1d2a9debe8619680d09fa868b9ca8b05
Author: Kirk Lund kl...@pivotal.io
Date: Wed Aug 19 16:01:26 2015 -0700
-
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/web/controllers/WanCommandsControllerJUnitTest.java
fb39d8c
Diff: https://reviews.apache.org/r/37683/diff/
Testing
---
WanCommandsControllerJUnitTest
test
Thanks,
Kirk Lund
Thanks Mark!
On Fri, Aug 21, 2015 at 1:13 PM, Mark Bretl mbr...@pivotal.io wrote:
I will re-enable the nightly schedule.
--Mark
On Fri, Aug 21, 2015 at 1:11 PM, Kirk Lund kirk.l...@gmail.com wrote:
Hi,
We need to have the nightly build reenabled for Apache Geode incubating.
Who do
/logging/LoggingUnitTestSuite.java
cd39a9d
Diff: https://reviews.apache.org/r/37670/diff/
Testing (updated)
---
manual testing with gemfire-assembly/build/install/apache-geode/bin/gfsh
LoggingUnitTestSuite
LoggingIntegrationTestSuite
Thanks,
Kirk Lund
GEODE-47 has some comments but is still open (that's the correct state for
now).
The others appear to be mistakenly left open after committing fixes.
-Kirk
On Thu, Aug 20, 2015 at 8:49 PM, Anthony Baker aba...@pivotal.io wrote:
It looks like several JIRA issues have been fixed but are still
-mail. To reply, visit:
https://reviews.apache.org/r/36866/#review93375
---
On July 28, 2015, 9:27 p.m., Kirk Lund wrote:
---
This is an automatically generated e-mail. To reply, visit
/diff/
Testing
---
test, integrationTest, new TestSuites, rebuild open+closed
Thanks,
Kirk Lund
/#comment148074
Is it possible to use $JAVA_HOME here instead of hardcoding references to
/jdk1.8.0_51?
- Kirk Lund
On July 30, 2015, 8:52 p.m., William Markito wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36857/#review93301
---
Ship it!
Ship It!
- Kirk Lund
On July 27, 2015, 8:27 p.m., Mark
://reviews.apache.org/r/36866/diff/
Testing
---
test, integrationTest and targeted testing of TestSuites
Thanks,
Kirk Lund
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37143/#review94316
---
Ship it!
Ship It!
- Kirk Lund
On Aug. 5, 2015, 9:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36950/#review93916
---
Ship it!
Ship It!
- Kirk Lund
On July 31, 2015, 12:13 a.m
Lund
On Aug. 3, 2015, 7:58 p.m., Kirk Lund wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36957/
---
(Updated Aug. 3, 2015
,
Kirk Lund
: https://reviews.apache.org/r/36957/diff/
Testing
---
test, integrationTest, new TestSuites, rebuild open+closed
Thanks,
Kirk Lund
TestSuites, rebuild open+closed
Thanks,
Kirk Lund
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36963/#review94131
---
Ship it!
Ship It!
- Kirk Lund
On July 30, 2015, 11:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37148/#review94424
---
Ship it!
Ship It!
- Kirk Lund
On Aug. 5, 2015, 11:52 p.m
For spurious failures, the problematic tests are predominantly dunit tests
which are actually end-to-end tests involving 6 jvms. End-to-end tests are
notorious for having reliability issues. This is magnified by reusing jvms
from one test case to the next. Eventually, one of the 6 jvms hits a
I've created GEODE-218 Change distributedTest task to fork every 1 test
case for review and group discussion.
-Kirk
On Thu, Aug 13, 2015 at 5:29 PM, Kirk Lund kirk.l...@gmail.com wrote:
For spurious failures, the problematic tests are predominantly dunit tests
which are actually end-to-end
?
- Kirk Lund
On Aug. 10, 2015, 9:28 p.m., Darrel Schneider wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37321
/gemfire/internal/SharedLibrary.java
(line 112)
https://reviews.apache.org/r/37486/#comment150432
I would recommend fixing the indentation of this method. Also need to make
sure the assumption of compressed oops is not used when using Zing JVM.
- Kirk Lund
On Aug. 14, 2015, 5:22 p.m., Darrel
Did we ever move to Slack? I don't see any further mention of it. It
doesn't look like hipchat is being actively used for Geode anymore.
-Kirk
On Fri, Jul 17, 2015 at 11:26 AM, John Blum jb...@pivotal.io wrote:
+1 for moving to Slack
On Fri, Jul 17, 2015 at 11:13 AM, Bruce Schuchardt
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36802/#review93133
---
Ship it!
Ship It!
- Kirk Lund
On July 24, 2015, 11:54 p.m
, integrationTest and targeted testing of TestSuites
Thanks,
Kirk Lund
/gemfire/cache30/RegionTestCase.java
(line 3617)
https://reviews.apache.org/r/36695/#comment147062
Did you mean to leave the TODO here?
- Kirk Lund
On July 22, 2015, 4:36 p.m., Darrel Schneider wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36714/#review92822
---
Ship it!
Ship It!
- Kirk Lund
On July 23, 2015, 12:15 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36533/#review92819
---
Ship it!
Ship It!
- Kirk Lund
On July 16, 2015, 12:11 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36747/#review92926
---
Ship it!
Ship It!
- Kirk Lund
On July 23, 2015, 9:49 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36750/#review92956
---
Ship it!
Ship It!
- Kirk Lund
On July 24, 2015, 4:23 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36594/#review92925
---
Ship it!
Ship It!
- Kirk Lund
On July 23, 2015, 6:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36695/#review92927
---
Ship it!
Ship It!
- Kirk Lund
On July 22, 2015, 4:36 p.m
Does anyone know why the Apache Jenkins does not show details on test
failures?
Our internal Jenkins has a Test Result link with links for each test
failure that you can follow to see detailed info on the test. Apache
Jenkins doesn't have this and the only way I can see results is in Console
:29 AM, Kirk Lund kl...@pivotal.io wrote:
Looks like we have nightly build failures. I think this means we need
to
freeze all checkins and work to stabilize these test failures:
https://builds.apache.org/view/All/job/Geode-nightly/lastFailedBuild/console
Jenkins also ran out
the right thing but you are not able to
connect to the apache git server.
-Dan
On Mon, Jul 13, 2015 at 12:01 PM, Kirk Lund kl...@pivotal.io wrote:
I had no trouble doing git fetch and starting a feature branch, but now
that I'm ready to publish the feature branch and track it from another
2adb1588cce967c2a4149fa674d431871a3066fd
Author: Kirk Lund kl...@pivotal.io
Date: Mon Jul 13 11:44:21 2015 -0700
GEODE-94: Add typecast to prevent ambiguous method calls under JDK 8
Add typecast to Object for ambiguous logger arguments.
*$ git flow feature publish GEODE-94*
fatal: unable
That's good enough!
Thanks,
Kirk
On Mon, Jul 13, 2015 at 10:28 AM, Dan Smith dsm...@pivotal.io wrote:
On July 13, 2015, 4:30 p.m., Kirk Lund wrote:
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/InternalResourceManager.java,
line 62
https
for this as well as missing categories.
- Kirk Lund
On July 11, 2015, 12:26 a.m., Dan Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36416
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36395/#review91475
---
Ship it!
Ship It!
- Kirk Lund
On July 10, 2015, 5:11 p.m
-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/VIEW_ENFORCER.java
426b8b4
Diff: https://reviews.apache.org/r/36454/diff/
Testing
---
Run existing UnitTest, IntegrationTest, DistributedTest suites
Thanks,
Kirk Lund
Please join in and select a ticket from the 1st group to assign to
yourself. We need to make each of these tests more reliable. Please remove
any Thread sleep calls or other actions that can cause a test to
intermittently fail.
Filed with no assignee yet:
GEODE-140
This is from the old Ant build (which Geode doesn't use):
$build.sh run-management-tests -DuseHTTP=true
What's the counterpart in the Geode gradle build?
-Kirk
On Thu, Oct 22, 2015 at 11:55 AM, John Blum wrote:
>
>
And I don't
> > think there should be - if this is something that needs to be tested it
> > should be running in every nightly build, not just when you pass a
> special
> > flag.
> >
> > -Dan
> >
> > On Thu, Oct 22, 2015 at 12:12 PM, Kirk Lund <kl...@pivotal.i
On the third day of Geode Bug Squashathon (Wed) we had our 1st GREEN build
of DistributedTests this week! We had 11 volunteers fixing 4 tickets (12
more remained in progress by end of day). The UnitTests and
IntegrationTests remained green for us except for 1 failure in
IntegrationTests. We had
at 1:53 PM, Anthony Baker <aba...@pivotal.io> wrote:
> Can we apply the @Parameterized annotation here? Two code paths, one test
> (as the old saying goes…)
>
> Anthony
>
> > On Oct 22, 2015, at 1:46 PM, Kirk Lund <kl...@pivotal.io> wrote:
> >
> &
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/#review104108
---
Ship it!
Ship It!
- Kirk Lund
On Oct. 26, 2015, 11:04 p.m
ity/TestAccessControl.java
(line 3)
<https://reviews.apache.org/r/39585/#comment162464>
need to get rid of using hydra.Log
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestAuthenticator.java
(line 3)
<https://reviews.apache.org/r/39585/#comment162465&g
pache.org/r/39659/#comment162281>
indentation inside this block appears to be wrong
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/OnGroupsFunctionExecutionDUnitTest.java
(line 188)
<https://reviews.apache.org/r/39659/#comment162280>
indentation inside thi
We just finished our 4th day of Geode Bug Squashathon (Thurs) and we've had
another GREEN build of DistributedTests. We had 12 volunteers and committed
fixes for another 4 tickets. The UnitTest and IntegrationTest suites
remained green for us except for 2 failures in IntegrationTests which were
I think we need to settle on a formal Definition of Done (DOD) for Apache
Geode. Again, borrowing from Spring Data we could start with what they
define and add to it:
- Implemented according to specification in the ticket
- Unit tested
- Integration tested
- Reference documentation
Is there a standard that ASF follows for when a JIRA ticket changes status
to Resolved vs Closed?
If not, then I'd like recommend that we follow the process that Spring uses:
Ticket changes to Resolved when the fix/implementation is committed or
merged (to develop in our case). It then moves to
gement/ClientHealthStatsDUnitTest.java
(line 418)
<https://reviews.apache.org/r/39885/#comment163297>
Is this sleep needed? It's happening at the end of the test.
- Kirk Lund
On Nov. 3, 2015, 1:01 a.m., Darrel Sch
the root of the module dependency
> tree.
>
> When we refactor to break dependencies such that we *can* separate out an API
> module (both for client and server) we definitely should.
>
> IMO
>
>
> - Anthony
>
> On November 2nd, 2015, 9:57 p.m. UTC, Kirk Lund w
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39346/#review105093
---
Ship it!
Ship It!
- Kirk Lund
On Oct. 15, 2015, 5:42 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39362/#review105092
---
Ship it!
Ship It!
- Kirk Lund
On Oct. 15, 2015, 11:02 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39925/#review105090
---
Ship it!
Ship It!
- Kirk Lund
On Nov. 4, 2015, 12:49 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39921/#review105091
---
Ship it!
Ship It!
- Kirk Lund
On Nov. 3, 2015, 10:56 p.m
Nitin,
The JIRA tickets for CI failures do not have a common parent JIRA, but
here's a query to see what's still open:
project = GEODE AND status in (Open, "In Progress", Reopened) AND labels =
CI
There are currently 57 open CI tickets. We are not officially continuing
the Squashathon but
/build.gradle 1c17474
gemfire-rebalancer/build.gradle d87dd58
gemfire-web/build.gradle f0de25a
settings.gradle 4b2da7b
Diff: https://reviews.apache.org/r/39879/diff/
Testing
---
clean build and unit testing of the new annotation
Thanks,
Kirk Lund
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39877/#review104800
---
Ship it!
Ship It!
- Kirk Lund
On Nov. 2, 2015, 9:38 p.m., Mark
Reminder: next Clubhouse is tomorrow (Tues) morning 9AM PST!
Topic is: OQL Querying and Indexing in Geode
Be seeing you,
Kirk
-- Forwarded message --
From: Marie Nedich
Date: Fri, Oct 23, 2015 at 11:26 AM
Subject: Apache Geode Clubhouse: Tuesday, November 3
g/r/39879/#comment163050>
I think this change was added to the diff by latest down-merge of develop
HEAD to my branch. Let me know which is correct (testRuntime or provided).
- Kirk Lund
On Nov. 2, 2015, 9:57 p.m., Kirk Lund
2, 2015 at 12:44 PM, John Blum <jb...@pivotal.io> wrote:
> >
> >> +1
> >>
> >> On Mon, Nov 2, 2015 at 12:36 PM, Udo Kohlmeyer <ukohlme...@pivotal.io>
> >> wrote:
> >>
> >>> +1
> >>> On 3 Nov 2015 7:14 am, &
at 1:33 PM, William Markito <wmark...@pivotal.io>
> wrote:
> > >
> > > +1
> > >
> > > Just one question, what is snapshot build deployed ? Is it the same as
> > > snapshot build successfully completed ?
> > >
> > > On Mon, No
+1 for deleting it. Test looks worthless.
I'd be in favor of completely replacing the internationalization code in
Geode.
-Kirk
On Thu, Nov 5, 2015 at 11:43 AM, Dan Smith wrote:
> I don't see much purpose behind that test either. I'd be in favor of
> deleting it.
>
> -Dan
+1
On Thu, Nov 5, 2015 at 12:19 PM, Sai Boorlagadda
wrote:
> +1
>
> On Thu, Nov 5, 2015 at 12:17 PM, William Markito
> wrote:
>
> > +1
> >
> > On Thu, Nov 5, 2015 at 11:39 AM, Darrel Schneider >
> > wrote:
> >
> > > +1
> >
Does anyone know if it's possible to use regex in jira queries/filters?
-Kirk
We started off our week of Geode Bug Squashathon with 6 volunteers fixing
12 tickets (with 4 more in-progress). The UnitTests and IntegrationTests
are predominantly green. We had a number of failures caused by git timeouts
and we hit 2 intermittent failures in IntegrationTests for which we filed
Here's a filter that shows all CI tickets for Geode that are Open,
In-Progress or Reopened (excluding HDFS):
project = GEODE AND status in (Open, "In Progress", Reopened) AND labels =
CI AND labels != HDFS
The HDFS tests are disabled and HDFS should probably be moved to a feature
branch (ie,
, Oct 16, 2015 at 4:25 PM, Anthony Baker <aba...@pivotal.io> wrote:
> +1
>
> > On Oct 16, 2015, at 3:33 PM, Kirk Lund <kl...@pivotal.io> wrote:
> >
> > Here's a filter that shows all CI tickets for Geode that are Open,
> > In-Progress or Reopened (excluding
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39028/#review101671
---
Ship it!
Ship It!
- Kirk Lund
On Oct. 5, 2015, 11:18 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38866/#review101670
---
Ship it!
Ship It!
- Kirk Lund
On Sept. 29, 2015, 10:47 p.m
/TXExpiryJUnitTest.java (line
324)
<https://reviews.apache.org/r/39058/#comment159130>
I think I would move this if-else block inside the try { below
- Kirk Lund
On Oct. 6, 2015, 6:28 p.m., Darrel Schneider wrote:
>
> ---
> This is a
/TXExpiryJUnitTest.java (line 57)
<https://reviews.apache.org/r/39028/#comment159126>
I would keep this as an IntegrationTest
- Kirk Lund
On Oct. 5, 2015, 11:18 p.m., Darrel Schneider wrote:
>
> ---
> This is an automatically generated e
ne/gemfire/internal/logging/log4j/FastLoggerWithDefaultConfigJUnitTest.java
2e08500
Diff: https://reviews.apache.org/r/39290/diff/
Testing
---
precheckin-all
Thanks,
Kirk Lund
/
Testing
---
Unit tests:
./gradlew clean test
Thanks,
Kirk Lund
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37737/#review96435
---
Ship it!
Ship It!
- Kirk Lund
On Aug. 24, 2015, 11:23 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37702/#review97333
---
Ship it!
Ship It!
- Kirk Lund
On Aug. 22, 2015, 4:03 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38015/#review97332
---
Ship it!
Ship It!
- Kirk Lund
On Sept. 1, 2015, 8:36 p.m., Dan
+1 Looks good Swapnil!
On Mon, Aug 31, 2015 at 11:48 PM, Swapnil Bawaskar
wrote:
> Hi All,
> The following is a draft of the August report. Please provide any feedback
> you may have.
>
> Geode:
> Geode is a data management platform that provides real-time, consistent
>
+1
I like the idea of switching to fork=1 for a few months to focus on
stabilizing any dunit tests that fail without potential test pollution
causes. These failures are mostly like ones that involve race conditions.
Once we fix these, then we could change back to fork=30.
On Fri, Sep 4, 2015 at
0f7563b
gemfire-assembly/src/test/java/com/gemstone/gemfire/management/internal/AgentUtilJUnitTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/38133/diff/
Testing
---
integrationTest (AgentUtilJUnitTest is an IntegrationTest)
Thanks,
Kirk Lund
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38029/#review97796
---
Ship it!
Ship It!
- Kirk Lund
On Sept. 1, 2015, 11:46 p.m
eople won't
run in production with debug or trace.
- Kirk Lund
On Sept. 4, 2015, 8:50 p.m., Darrel Schneider wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
> On None, Kirk Lund wrote:
> > Ship It!
Ignore this. I meant to hit "Publish" instead of "Ship It!" (long week!)
- Kirk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.ap
1 - 100 of 570 matches
Mail list logo