Re: opinion poll, stale issues

2022-02-16 Thread Niklas Edmundsson
duals from reporting further issues. At least, I find such projects rude. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | ni...@

Re: module threads and mpm lifecycle

2022-02-23 Thread Niklas Edmundsson
7;s not elvis_leaving_building I'm happy ;) /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | ni...@acc.umu.se --- Gene Roddenberry showed us the future...Make It So! =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

mod_cache: Broken code?

2015-04-23 Thread Niklas Edmundsson
aning up the related code... It's easy to just remove the now redundant code, but is that the right way to do it or did the initial code have some function that's now gone missing? /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmund

Re: *Match, RewriteRule POLA violation?

2015-05-01 Thread Niklas Edmundsson
guess they can use and a suitable expr? /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | ni...@acc.umu.se --- I! finally! learned! to! punctuate! Kirk's! sentences! =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: TIL

2016-04-27 Thread Niklas Edmundsson
) bucket type, and pass a 0 length bucket of it on the brigade where appropriate... However, I don't know if the remove-empty-buckets logic here and there wrecks this method as well? /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson,

httpd and APR_HAS_XTHREAD_FILES

2016-05-16 Thread Niklas Edmundsson
Unix builds. However, I'm guessing that this is purely an APR bug in that case? /Nikke - confused now? -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.

Segfault in ssl_scache_init on reload

2016-10-08 Thread Niklas Edmundsson
d not initialize stapling cache. Exiting."); -8<-- /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | ni...@acc.umu.se --- FUBB -- Fouled Up Beyond Belief =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: Segfault in ssl_scache_init on reload

2016-10-10 Thread Niklas Edmundsson
On Sun, 9 Oct 2016, Ruediger Pluem wrote: On 10/08/2016 09:28 PM, Niklas Edmundsson wrote: Hi all. httpd 2.4.23, built from httpd-2.4.23.tar.bz2 and httpd-2.4.23-deps.tar.bz2 on Ubuntu 14.04.5 LTS (trusty). While fiddling with enabling https on ftp.acc.umu.se I stumbled on the following

Re: Memory usage in apache

2006-08-22 Thread Niklas Edmundsson
s might be what's biting you... /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- "...to boldly go where no mallard has gone before!" - Darkwing Duck =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: [PATCH] mod_disk_cache LFS-aware config

2006-08-22 Thread Niklas Edmundsson
On Thu, 22 Jun 2006, Niklas Edmundsson wrote: This patch makes it possible to configure mod_disk_cache to cache files that are larger than the LFS limit. While at it, I implemented error handling so it doesn't accept things like "CacheMinFileSize barf" anymore. Actual LFS s

Re: mod_cache responsibilities vs mod_xxx_cache provider responsibilities

2006-09-14 Thread Niklas Edmundsson
ow if there's any interest in this. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- Does the Little Mermaid wear an algebra? =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: mod_cache responsibilities vs mod_xxx_cache provider responsibilities

2006-09-14 Thread Niklas Edmundsson
On Thu, 14 Sep 2006, Graham Leggett wrote: Niklas Edmundsson wrote: Will it be possible to do away with "one file for headers and one file for body" in mod_disk_cache with this scheme? This definitely has lots of advantages - however HTTP/1.1 requires that it be possible to

[PATCH] (resend) mod_disk_cache LFS-aware config

2006-09-14 Thread Niklas Edmundsson
te patch once this is commited. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- "Ensign. How

Re: mod_cache responsibilities vs mod_xxx_cache provider responsibilities

2006-09-14 Thread Niklas Edmundsson
On Thu, 14 Sep 2006, Davi Arnaut wrote: On 14/09/2006, at 04:24, Niklas Edmundsson wrote: On Wed, 13 Sep 2006, Davi Arnaut wrote: I'm working on this. You may want to check my proposal at http://verdesmares.com/Apache/proposal.txt Will it be possible to do away with "one file f

Re: [PATCH] (resend) mod_disk_cache LFS-aware config

2006-09-14 Thread Niklas Edmundsson
On Thu, 14 Sep 2006, Graham Leggett wrote: On Thu, September 14, 2006 11:17 am, Niklas Edmundsson wrote: To facilitate the merging of our large mod_disk_cache fixup I will send small patches that fix various bugs so that they can be applied incrementally to trunk with relevant discussion

Re: mod_cache responsibilities vs mod_xxx_cache provider responsibilities

2006-09-14 Thread Niklas Edmundsson
directory structure should be strictly private to the cache. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- "You have learned much, young one." - Vader =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: [PATCH] (resend) mod_disk_cache LFS-aware config

2006-09-14 Thread Niklas Edmundsson
On Thu, 14 Sep 2006, Graham Leggett wrote: On Thu, September 14, 2006 2:41 pm, Niklas Edmundsson wrote: Yup. The situation seems to be complicated somewhat by Davi working on the cache-thingies, and doing more than just poking around in the mod_cache infrastructure... However, it seems that

Re: mod_cache responsibilities vs mod_xxx_cache provider responsibilities

2006-09-16 Thread Niklas Edmundsson
than RAM. Some bad design decisions in mod_disk_cache becomes really visible in this environment. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] -

Re: mod_cache responsibilities vs mod_xxx_cache provider responsibilities

2006-09-18 Thread Niklas Edmundsson
On Sun, 17 Sep 2006, Graham Leggett wrote: Niklas Edmundsson wrote: However, I don't see how you can do a lockless design with multiple files and an index that can do: * Clients read from the cache as files are being cached. * Only one session caches the same file. * Header/Body up

Re: mod_cache responsibilities vs mod_xxx_cache provider responsibilities

2006-09-20 Thread Niklas Edmundsson
On Mon, 18 Sep 2006, Brian Akins wrote: Niklas Edmundsson wrote: Extra tracking sounds unnecessary if you can do it in a way that doesn't need it. It's not "extra" it just adding some tracking. When an objects gets cached log (sql, db, whatever) that /blah/foo/b

Re: mod_cache responsibilities vs mod_xxx_cache provider responsibilities

2006-09-20 Thread Niklas Edmundsson
read every header. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- That's not a bug. It's supposed to do that. =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: mod_cache responsibilities vs mod_xxx_cache provider responsibilities

2006-09-20 Thread Niklas Edmundsson
On Wed, 20 Sep 2006, Brian Akins wrote: Niklas Edmundsson wrote: don't care about performance... Actually, cache on xfs mounted with atime doesn't seem to be a performance killer oddly enough... Our frontends had no problems surviving 1k requests/s during the latest mozilla-upda

Re: mod_cache responsibilities vs mod_xxx_cache provider responsibilities

2006-09-21 Thread Niklas Edmundsson
ine up for testing the smaller patches before submitting them. -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- The

[PATCH] mod_disk_cache working LFS (filecopy)

2006-09-26 Thread Niklas Edmundsson
from a 32bit machine with 1GB of memory using mod_disk_cache, and the md5sum is correct afterwards. The old behaviour was eating all the address space/memory and segfault. I'll attach the thing to bug #39380 as well. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [PATCH] mod_disk_cache working LFS (filecopy)

2006-09-26 Thread Niklas Edmundsson
of a couple of hundred GB which changes daily. By using caching frontends we can easily fill our available 2Gbit even though the backend can only do about 300-400Mbit. This is possible because of a cache hit rate of about 90%. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: [PATCH] mod_disk_cache working LFS (filecopy)

2006-09-26 Thread Niklas Edmundsson
7;ll be needing that kludge to get good behaviour in our caching-frontend-for-ftpserver-case ... /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] ---

Re: [PATCH] mod_disk_cache working LFS (filecopy)

2006-09-27 Thread Niklas Edmundsson
On Tue, 26 Sep 2006, Graham Leggett wrote: Niklas Edmundsson wrote: * Realising that a file is a file and can be copied as such, without reading the whole thing into memory first. * When a file is cached by copying, replace the brigade with a new one refering to the cached file so we

Re: svn commit: r450188 - /httpd/httpd/trunk/modules/cache/mod_disk_cache.c

2006-09-27 Thread Niklas Edmundsson
a single, complete, body so it should only be called once per request. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] ---

Re: svn commit: r450105 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h

2006-09-27 Thread Niklas Edmundsson
ome from people who knows all the deep magic in httpd and I know I'm not that person. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- "Only together can we turn him to the dark side of the Force." - Emperor =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: [PATCH] mod_disk_cache working LFS (filecopy)

2006-09-27 Thread Niklas Edmundsson
On Wed, 27 Sep 2006, Graham Leggett wrote: On Wed, September 27, 2006 11:07 am, Niklas Edmundsson wrote: In practice this isn't enough when dealing with large files, so in our production code (the hideously large jumbopatch) this is fixed by read-while-caching and spawning a thread to d

[PATCH] mod_cache: Don't log bogus errors

2006-09-27 Thread Niklas Edmundsson
occured and that an error web page has already been sent (documented in CHANGES of all places). The additional garbage in the error log doesn't make anyone happy... /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.u

Re: [PATCH] mod_disk_cache working LFS (filecopy)

2006-10-01 Thread Niklas Edmundsson
) /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- Excuse me, is that a toupee or do you have a tribble on your head =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: [PATCH] mod_disk_cache working LFS (filecopy)

2006-10-02 Thread Niklas Edmundsson
t;is this a file"-thingie anyway (at least I need it, but I might have missed some nifty feature in APR). /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.

Re: [PATCH] mod_disk_cache working LFS (filecopy)

2006-10-02 Thread Niklas Edmundsson
ay (at least I need it, but I might have missed some nifty feature in APR). You would just need to copy the remaining buckets (granted if there are no concurrency problems) and send then to a per-process thread pool. And when not having threads? /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: Coding style

2006-10-03 Thread Niklas Edmundsson
s likely to cause ugly linewraps when using functions_with_long_names(and, a, large, list, of, arguments) ... /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL P

[PATCH] sendfile_nonblocking broken in trunk

2006-10-04 Thread Niklas Edmundsson
bmitting mod_disk_cache patches. -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- My

Re: [PATCHES] mod_disk_cache read-while-caching

2006-10-08 Thread Niklas Edmundsson
On Thu, 5 Oct 2006, Niklas Edmundsson wrote: OK, here comes the latest two patches in the mod_disk_cache improvement parody. I'll attach these patches to bug #39380, but with less comments. I discovered a few misses, mostly not NULL:ing fd pointers when closing them, missing close/flush

[PATCH] mod_disk_cache background copy

2006-10-08 Thread Niklas Edmundsson
t sure would be more elegant :) /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- "It's funny how the Earth n

Re: [PATCH] mod_disk_cache background copy

2006-10-11 Thread Niklas Edmundsson
so and might lag quite a bit in replying to stuff. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- Huh? What? Am I on-line? =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: mod_disk_cache summarization

2006-10-24 Thread Niklas Edmundsson
ould probably be apprecieted. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- "All this will be for no

Re: mod_disk_cache summarization

2006-10-24 Thread Niklas Edmundsson
what makes me think that we should acknowledge that they exist and provide the relevant knobs where necessary. As it looks right now, those knobs tend to be more OS/filesystem specific, but that might change as this evolves. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: mod_disk_cache summarization

2006-10-24 Thread Niklas Edmundsson
o get mod_cache/mod_disk_cache even near a usable state simply won't happen... You can't both have "we want fixes in small incremental pieces" and "this thing sucks, make it perfect at once". /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h modules/cache/

2006-10-27 Thread Niklas Edmundsson
DFILE only tells you that APR has sendfile. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- My favorite c

Re: svn commit: r467655 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_cache.xml modules/cache/mod_cache.c modules/cache/mod_cache.h

2006-10-27 Thread Niklas Edmundsson
have served some purpose other than enabling a non-profit computer club building a FTP/HTTP server that actually works. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h modules/cache/

2006-10-27 Thread Niklas Edmundsson
usually go disk-bound without much help from the OS disk cache. Also, httpd seems to be faster delivering data by sendfile than delivering data from memory buckets. That's more of a performance bug in httpd though. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: mod_disk_cache summarization

2006-10-27 Thread Niklas Edmundsson
On Tue, 24 Oct 2006, Graham Leggett wrote: On Tue, October 24, 2006 2:48 pm, Niklas Edmundsson wrote: Perhaps this could be as simple as using ServerName and ServerAlias (unless the name of the site is part of the URL, which will happen in the forward proxy case) to reduce the cached URL to a

Re: mod_disk_cache summarization

2006-10-28 Thread Niklas Edmundsson
On Fri, 27 Oct 2006, Graham Leggett wrote: Niklas Edmundsson wrote: Different VHosts meaning different URLs/directories, pointing to the same files... Hmm... Two thoughts come into my head over this one. One way to approach this is to treat this as a general problem of how do we stop

Re: cache: the store_body interface

2006-10-31 Thread Niklas Edmundsson
with mmap, and since I wanted to be able to do read-while-caching I dropped the mmap-write-idea since the drawbacks was way larger than the benefits. YMMV /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se

Re: mod_disk_cache and mod_include bugs and suggestions

2007-01-15 Thread Niklas Edmundsson
to do and doesn't cache it. Have a look at mod_expires. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL

Re: mod_disk_cache and mod_include bugs and suggestions

2007-01-15 Thread Niklas Edmundsson
tory index generator, which also isn't cacheable for the same reasons SSI aren't. Modern httpd releases can work around this if you set IndexOptions TrackModified, look in the docs for more info and limitations. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: Solved: mod_disk_cache and mod_include bugs and suggestions

2007-01-17 Thread Niklas Edmundsson
ich is essentially the same as 2.2.4 if I remember correctly. As for your problems, I would recommend staying on 2.2.4 proper and look further into the issue of expired/last-modified headers. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Ni

mod_disk_cache jumbopatch - new revision

2007-01-17 Thread Niklas Edmundsson
progress on mod_ftp to be able to cache ftp too, all usable ftpd's we have seen uses chroot() which causes trouble when trying to wrap open() and friends to access files outside the chroot ;) /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas

Re: Solved: mod_disk_cache and mod_include bugs and suggestions

2007-01-17 Thread Niklas Edmundsson
380 ... /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- Preserve wildlife... pickle a sqirrel. =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: Solved: mod_disk_cache and mod_include bugs and suggestions

2007-01-17 Thread Niklas Edmundsson
ssues.apache.org/bugzilla/show_bug.cgi?id=39380 ... I think I will give it a spin, more to give you feedback on possible issues with SSI. Do that. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se

Re: Solved: mod_disk_cache and mod_include bugs and suggestions

2007-01-18 Thread Niklas Edmundsson
no clue on how to solve this with the current cache design, but I'm sure there are more clued people here when it comes to caching and dynamic content. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se |

Re: mod_cache+mod_rewrite behaviour

2007-01-23 Thread Niklas Edmundsson
since you don't have the mime type info then. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- C programmers don't have the BASIC instincts. =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: mod_cache+mod_rewrite behaviour

2007-01-23 Thread Niklas Edmundsson
On Tue, 23 Jan 2007, Brian Akins wrote: Niklas Edmundsson wrote: Since mod_cache runs as a quick handler, matching based on URL would probably be the easiest since you don't have the mime type info then. Maybe something like CacheEnable disk /special/path ignore_query Could add

mod_cache: save filter recalls body to non-empty brigade?

2007-01-24 Thread Niklas Edmundsson
brigade. Wouldn't it be more correct to empty the brigade before calling recall_body()? Or am I missing something? This is mod_cache in vanilla httpd 2.2.4 by the way. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,

Re: mod_cache: save filter recalls body to non-empty brigade?

2007-01-24 Thread Niklas Edmundsson
On Wed, 24 Jan 2007, Graham Leggett wrote: On Wed, January 24, 2007 2:15 pm, Niklas Edmundsson wrote: In mod_cache, recall_body() is called in the cache_save_filter() when revalidating an entity. However, if I have understood things correctly the brigade is already populated when the save

Re: mod_cache: save filter recalls body to non-empty brigade?

2007-01-25 Thread Niklas Edmundsson
the filter is named in, the one where recall_body stores the cached file is bb. I the case of a recalled body we pass bb down the chain not in. Ah, of course. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.u

Re: 3.0 - Proposed Goals

2007-02-14 Thread Niklas Edmundsson
made by those who hate to write it: the core programmers. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- "I should have done this a long time ago." - Picard =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: 3.0 - Proposed Goals

2007-02-14 Thread Niklas Edmundsson
On Wed, 14 Feb 2007, Nick Kew wrote: On Wed, 14 Feb 2007 15:41:38 +0100 (MET) Niklas Edmundsson <[EMAIL PROTECTED]> wrote: One problem here is that this kind of docco usually needs to be made by those who hate to write it: the core programmers. The core programmers use the core prog

Please backport mod_cache PR 41475 to 2.2.5 ...

2007-02-23 Thread Niklas Edmundsson
the mod_cache fixes in 2.2.5 so we don't have to keep track of them when upgrading... /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se |

Re: [RFC] Guide to writing output filters

2007-03-17 Thread Niklas Edmundsson
lued could have a go at the existing pages that says "this should be improved/updated/written" life would be bliss :) And yes, I know that writing documentation is a drag. However, in the long run it pays off. Really. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

mod_ftp, status and progress?

2007-03-23 Thread Niklas Edmundsson
hings like the mod_ftp/mod_cache interaction and the globbing mess really needs a Clued Httpd Developer sorting out the various odds and ends. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, A

Re: mod_ftp, status and progress?

2007-03-26 Thread Niklas Edmundsson
MUST work. I think this is being addressed. I'd fixed the traditional interfaces (PORT/PASV) but we need to hack together EPRT/EPSV support, yet. OK. This shouldn't be too hard, given that EPRT/EPSV doesn't differ too much from PORT/PASV. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: PATCH 19824 -- enhancement to mod_expires

2007-04-01 Thread Niklas Edmundsson
. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- Where will YOU be when your laxative starts working? =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

mod_cache: 304 on HEAD (bug 41230)

2007-04-11 Thread Niklas Edmundsson
hat we assume is the reason for a fair share of "it didn't work for a while"-bugreports when people are running apt-get update and whatnot. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, A

Re: mod_cache: 304 on HEAD (bug 41230)

2007-04-11 Thread Niklas Edmundsson
On Wed, 11 Apr 2007, Niklas Edmundsson wrote: Would the correct fix be to check for r->header_only in cache_select(), or are there even more funky stuff going on? You don't want the cached object to be removed just because you got a HEAD request when it really isn't stale but ju

[PATCH] mod_cache 304 on HEAD (bug 41230)

2007-04-13 Thread Niklas Edmundsson
On Wed, 11 Apr 2007, Niklas Edmundsson wrote: Looking a bit further, I think that something like this would actually be enough: I have now tested this patch, and it seems to solve the problem. This is on httpd-2.2.4 + patch for PR41475 + our mod_disk_cache patches. Without the patch a

Re: [PATCH] mod_cache 304 on HEAD (bug 41230)

2007-04-17 Thread Niklas Edmundsson
lean stuff up to improve readability, as long as the bug gets fixed I'm happy :) /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] ---

Re: [PATCH] mod_cache 304 on HEAD (bug 41230)

2007-04-17 Thread Niklas Edmundsson
emove_url anyway, even the mod_cache-code seems to get them confused... /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --

Re: mod_ftp, status and progress?

2007-04-26 Thread Niklas Edmundsson
gexes... Wouldn't apr_match_glob() be a better starting point? I don't really see the point of going via regexes... /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [

Re: mod_ftp, status and progress?

2007-04-26 Thread Niklas Edmundsson
rent mod_ftp globbing stuff is simply a mess. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- Reality is for people who can't handle Star Trek. =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: mod_ftp, status and progress?

2007-04-27 Thread Niklas Edmundsson
in 2.0.x seems a bit sub-optimal... /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- You're the security chief-shouldn't you be out securing something? =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

mod_ftp: [PATCH] Make REST work with large files

2007-04-27 Thread Niklas Edmundsson
it in the twisty maze of svn trees though. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- Fiddle: Fri

[PATCH] mod_cache: Don't follow NULL pointers.

2007-05-02 Thread Niklas Edmundsson
in httpd 2.2.5 since it segfaults your httpd even with valid headers... /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] -

Re: [PATCH] mod_cache: Don't follow NULL pointers.

2007-05-02 Thread Niklas Edmundsson
On Wed, 2 May 2007, Niklas Edmundsson wrote: We encountered the following bug: httpd segfaulted due to a client emitting "Cache-Control: max-age=216000, max-stale" which is a perfectly valid header. The segfault is caused by the fact that ap_cache_liststr() sets the value point

Re: mod_ftp, status and progress?

2007-05-02 Thread Niklas Edmundsson
- eager to give it a spin :) -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- You wanted to make it law. Make it a good one. - Picard =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: mod_ftp, status and progress?

2007-05-03 Thread Niklas Edmundsson
I right in guessing that making it play well with mod_cache would come more or less for free after the request-refactoring is done? /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se

Re: ftp glob/limits?

2007-05-15 Thread Niklas Edmundsson
vote would be "default to restrictive, a more relaxed behaviour must be explicitly configured". /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n

Any progress on PR41230 (HEAD issues on cached items)?

2007-05-17 Thread Niklas Edmundsson
. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- Don't hide your contempt of the contemptible! =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: Any progress on PR41230 (HEAD issues on cached items)?

2007-05-21 Thread Niklas Edmundsson
On Fri, 18 May 2007, Justin Erenkrantz wrote: On 5/17/07, Niklas Edmundsson <[EMAIL PROTECTED]> wrote: Has there been any progress on PR41230? I submitted a patch that at least seems to improve the situation that now seems to have seen some testing by others as well. As I have stated

mod_cache: Don't update when req max-age=0?

2007-05-21 Thread Niklas Edmundsson
der rewrite, and requests with max-age!=0 that can benefit from the header rewrite won't be affected by this change. Am I making sense? Have I missed something fundamental? /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundss

Re: mod_cache: Don't update when req max-age=0?

2007-05-21 Thread Niklas Edmundsson
acheControl is one of those, we use it on the offloaders that only serves large files that we know doesn't need the RFC behaviour. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admi

Re: mod_cache: Don't update when req max-age=0?

2007-05-22 Thread Niklas Edmundsson
On Mon, 21 May 2007, Roy T. Fielding wrote: On May 21, 2007, at 7:49 AM, Niklas Edmundsson wrote: Does anybody see a problem with changing mod_cache to not update the stored headers when the request has max-age=0, the body turns out not to be stale and the on-disk header hasn't expired?

Re: mod_cache: Don't update when req max-age=0?

2007-05-24 Thread Niklas Edmundsson
On Tue, 22 May 2007, Henrik Nordstrom wrote: tis 2007-05-22 klockan 11:40 +0200 skrev Niklas Edmundsson: -8<--- Does anybody see a problem with changing mod_cache to not update the stored headers when the request has max-age=0, the body turns out not to be stale and the

Re: mod_cache: Don't update when req max-age=0?

2007-05-24 Thread Niklas Edmundsson
object tend to be accessed with more-or-less the same max-age. So to store headers in the max-age=0 case just because it might be accessed by max-age!=0 makes no sense, since it's more likely that the next request to this object will have the same max-age. /Nikke -- -=-=-=-=-=-=

mod_disk_cache jumbopatch - 20070727 revision

2007-07-27 Thread Niklas Edmundsson
re really obsolete. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- We are AT&T of Borg, MCI will be assimilated =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

mod_limitipconn for httpd 2.2 and mod_cache

2007-07-27 Thread Niklas Edmundsson
is can be of use for others than us. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] ---

[PATCH]: mod_cache: don't store headers that will never be used

2007-07-29 Thread Niklas Edmundsson
NOT break anything. Patch is tested on httpd-2.2.4 and works as expected according to my tests. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL

Re: [PATCH]: mod_cache: don't store headers that will never be used

2007-07-30 Thread Niklas Edmundsson
same data in the cache except for the Expires header. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- * . . . . . <- Tribble Mother and Young =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: [PATCH]: mod_cache: don't store headers that will never be used

2007-07-30 Thread Niklas Edmundsson
hinks it is (*shiver*) then I guess there won't be any other options... /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- * . . . . . <- Tribble Mother and Young =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: [PATCH]: mod_cache: don't store headers that will never be used

2007-07-30 Thread Niklas Edmundsson
On Mon, 30 Jul 2007, Niklas Edmundsson wrote: However, if stuff is really depending on Date/Expires being what it thinks it is (*shiver*) then I guess there won't be any other options... Here's a version with a config directive, defaults to disabled. Thoughts

Re: [PATCH]: mod_cache: don't store headers that will never be used

2007-07-31 Thread Niklas Edmundsson
he "good" way be to accomplish this? /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- * <- Tr

Re: 1.3 bugs

2007-08-02 Thread Niklas Edmundsson
ost likely never submit a bug report again. This is especially true if the reporter had come up with a fix and produced a patch... /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se

Re: [PATCH]: mod_cache: don't store headers that will never be used

2007-08-08 Thread Niklas Edmundsson
On Tue, 31 Jul 2007, Niklas Edmundsson wrote: Any opinions on this? Here's a version with a config directive, defaults to disabled. Silly Q; a directive? Or a env var that can be scoped in interesting ways using mod_setenvif and/or mod_rewrite? Most of our proxy behavior overrides a

Re: CHANGES

2007-08-08 Thread Niklas Edmundsson
mplement this for the T&R Friday. I'm no committer or anything, but it sounds like the sane way to do it. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.

What's the "right" way to spawn a child in modules?

2006-04-27 Thread Niklas Edmundsson
ion is to spawn a child that does the copying letting the request be processed simultaneously. Is this doable? Would it be considered offensive to do apr_thread_create() if threads are available and fork() otherwise? Other ways to solve this? /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: What's the "right" way to spawn a child in modules?

2006-04-28 Thread Niklas Edmundsson
data to the client. /Nikke -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED] --- Go Ahead.. We're cleared for wierd. =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

  1   2   3   >