Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/186#discussion_r139798284
--- Diff: src/madpack/madpack.py ---
@@ -512,7 +512,9 @@ def _plpy_check(py_min_ver):
try:
_internal_run_query("C
GitHub user jingyimei opened a pull request:
https://github.com/apache/madlib/pull/186
Add error message for checking postgres install configuration
MADlib needs to be installed on a postgres with python extension. If
postgres is not configured with the `--with-python` option
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/178
Jenkins ok to test
---
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/178
Jenkins ok to test
---
Github user jingyimei commented on the issue:
https://github.com/apache/incubator-madlib/pull/175
@orhankislal
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user jingyimei opened a pull request:
https://github.com/apache/madlib/pull/178
Featur: Hit
JIRA:MADLIB-1124
Introducees a new module that computes the HITS scores of all nodes in a
directed graph.
Implements the HITS algorithm with normalization
(https
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/195#discussion_r151063100
--- Diff: src/ports/postgres/modules/graph/graph_utils.py_in ---
@@ -109,6 +110,85 @@ def validate_graph_coding(vertex_table, vertex_id,
edge_table
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/195#discussion_r151064800
--- Diff: src/ports/postgres/modules/graph/hits.py_in ---
@@ -95,234 +109,391 @@ def hits(schema_madlib, vertex_table, vertex_id,
edge_table, edge_args
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/195#discussion_r151061922
--- Diff: src/ports/postgres/modules/utilities/utilities.py_in ---
@@ -709,16 +709,35 @@ def _check_groups(tbl1, tbl2, grp_list):
return
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/211
@fmcquillan99 Yes, the version string is saved in Version.yml file and when
we make the release, we will change the version string from 1.13_dev to 1.13,
and cmake will directly get it from
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/211#discussion_r155683583
--- Diff: cmake/LinuxUtils.cmake ---
@@ -9,3 +9,14 @@ macro(rh_version OUT_VERSION)
set(${OUT_VERSION} "${OUT_VERSION}-NOT
GitHub user jingyimei opened a pull request:
https://github.com/apache/madlib/pull/211
Change madlib gppkg version string
This commit changes the naming convention for madlib gppkg,
after renaming, the format of madlib gppkg will look like:
madlib-1.13_dev-gp5-rhel6-x86_64
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/191#discussion_r146700914
--- Diff: src/ports/postgres/modules/knn/knn.py_in ---
@@ -160,20 +164,23 @@ def knn(schema_madlib, point_source,
point_column_name, point_id
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/191#discussion_r146700815
--- Diff: src/ports/postgres/modules/knn/knn.sql_in ---
@@ -96,19 +95,19 @@ in a column of type DOUBLE PRECISION[].
point_id
TEXT. Name
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/191#discussion_r146701746
--- Diff: src/ports/postgres/modules/knn/knn.sql_in ---
@@ -218,56 +215,57 @@ INSERT INTO knn_test_data VALUES
-# Run KNN for classification
GitHub user jingyimei opened a pull request:
https://github.com/apache/madlib/pull/273
Minibatch Preprocessing: fix dependent var with special character
JIRA:MADLIB-1237
Previously, minibatch processing would error out when the specified
dependent variable has special
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/274
Will handle those in another PR, closing this one.
---
Github user jingyimei closed the pull request at:
https://github.com/apache/madlib/pull/274
---
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/273
Will handle those in another PR, closing this one.
---
Github user jingyimei closed the pull request at:
https://github.com/apache/madlib/pull/273
---
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/274#discussion_r193503140
--- Diff: src/ports/postgres/modules/utilities/utilities.py_in ---
@@ -296,11 +305,24 @@ def py_list_to_sql_string(array, array_type=None,
long_format
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/274#discussion_r193525716
--- Diff: src/ports/postgres/modules/utilities/utilities.py_in ---
@@ -296,11 +305,24 @@ def py_list_to_sql_string(array, array_type=None,
long_format
GitHub user jingyimei opened a pull request:
https://github.com/apache/madlib/pull/285
Madpack: fix install/reinstall not giving proper error message
Previously, uninstalling or reinstalling on a database that does not have
MADlib already
installed fails as expected. However
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/232#discussion_r167717958
--- Diff: src/ports/postgres/modules/utilities/text_utilities.sql_in ---
@@ -74,175 +81,231 @@ tasks related to text.
Flag to indicate
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/232#discussion_r167709835
--- Diff: src/ports/postgres/modules/lda/lda.sql_in ---
@@ -182,324 +105,789 @@ lda_train( data_table,
\b Arguments
data_table
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/232#discussion_r167715245
--- Diff: src/ports/postgres/modules/utilities/text_utilities.sql_in ---
@@ -74,175 +81,231 @@ tasks related to text.
Flag to indicate
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/232#discussion_r167708065
--- Diff: src/ports/postgres/modules/lda/lda.sql_in ---
@@ -182,324 +105,789 @@ lda_train( data_table,
\b Arguments
data_table
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/232#discussion_r167708360
--- Diff: src/ports/postgres/modules/lda/lda.sql_in ---
@@ -182,324 +105,789 @@ lda_train( data_table,
\b Arguments
data_table
GitHub user jingyimei opened a pull request:
https://github.com/apache/madlib/pull/234
Create lower case column name in encode_categorical_variables()
JIRA:MADLIB-1202
The previous madlib.encode_categorical_variables() function generates
column name with some capital
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/222
Jekins OK to test
---
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/298
Jenkins OK to test
---
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/298#discussion_r205301880
--- Diff: doc/mainpage.dox.in ---
@@ -100,13 +86,14 @@ complete matrix stored as a distributed table.
@defgroup grp_matrix Matrix Operations
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/301#discussion_r205910952
--- Diff:
src/ports/postgres/modules/recursive_partitioning/test/decision_tree.sql_in ---
@@ -282,13 +283,16 @@ SELECT tree_train('dt_golf'::text
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/301#discussion_r205911065
--- Diff:
src/ports/postgres/modules/recursive_partitioning/test/decision_tree.sql_in ---
@@ -273,7 +274,7 @@ SELECT tree_train('dt_golf'::text
Github user jingyimei commented on the pull request:
https://github.com/apache/madlib/commit/1fe308c70d2c91fef508d29d81ed0e93da429eb6#commitcomment-29832374
In src/madpack/madpack.py:
In src/madpack/madpack.py on line 973:
Make sense.
---
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/294
The current master has another issue:
When you run
```
DROP TABLE IF EXISTS vertex, "EDGE";
CREATE TABLE vertex(
id INTEGER
);
CREATE TABLE "EDGE&qu
Github user jingyimei commented on the pull request:
https://github.com/apache/madlib/commit/1fe308c70d2c91fef508d29d81ed0e93da429eb6#commitcomment-29823247
In src/madpack/madpack.py:
In src/madpack/madpack.py on line 973:
Instead of versions do not mathch, it would be clearer
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/289#discussion_r201489373
--- Diff: src/modules/recursive_partitioning/DT_impl.hpp ---
@@ -1512,6 +1512,9 @@ DecisionTree::computeVariableImportance
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/289#discussion_r201501719
--- Diff:
src/ports/postgres/modules/recursive_partitioning/random_forest.py_in ---
@@ -1291,38 +1300,64 @@ def _create_group_table
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/289#discussion_r201462356
--- Diff:
src/ports/postgres/modules/recursive_partitioning/random_forest.py_in ---
@@ -616,23 +628,20 @@ def forest_train
GitHub user jingyimei opened a pull request:
https://github.com/apache/madlib/pull/256
Minibatch Preprocessing: change default buffer size formula for grouping
This commit changes the previous calculation formula for default buffer
size. Previously, we used num_rows_processed
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/265#discussion_r182843994
--- Diff: RELEASE_NOTES ---
@@ -9,6 +9,56 @@ commit history located at
https://github.com/apache/madlib/commits/master.
Current list of bugs
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/265
LGTM
---
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r177916814
--- Diff: src/ports/postgres/modules/graph/test/pagerank.sql_in ---
@@ -95,6 +101,49 @@ SELECT assert(relative_error(SUM(pagerank), 1) <
0.00
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r177899442
--- Diff: src/ports/postgres/modules/graph/pagerank.py_in ---
@@ -211,19 +261,30 @@ def pagerank(schema_madlib, vertex_table, vertex_id,
edge_table
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r177912288
--- Diff: src/ports/postgres/modules/graph/pagerank.py_in ---
@@ -527,14 +615,55 @@ def pagerank(schema_madlib, vertex_table, vertex_id,
edge_table
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r177897977
--- Diff: src/ports/postgres/modules/graph/pagerank.py_in ---
@@ -211,19 +261,30 @@ def pagerank(schema_madlib, vertex_table, vertex_id,
edge_table
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r177910146
--- Diff: src/ports/postgres/modules/graph/pagerank.py_in ---
@@ -211,19 +261,30 @@ def pagerank(schema_madlib, vertex_table, vertex_id,
edge_table
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r177916983
--- Diff: src/ports/postgres/modules/graph/test/pagerank.sql_in ---
@@ -95,6 +101,49 @@ SELECT assert(relative_error(SUM(pagerank), 1) <
0.00
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r177917620
--- Diff: src/ports/postgres/modules/graph/pagerank.sql_in ---
@@ -273,6 +278,48 @@ SELECT * FROM pagerank_out_summary ORDER BY user_id;
(2 rows
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r177915929
--- Diff: src/ports/postgres/modules/graph/test/pagerank.sql_in ---
@@ -66,7 +66,12 @@ SELECT pagerank(
'id',-- Vertix id
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r177893734
--- Diff: src/ports/postgres/modules/graph/pagerank.py_in ---
@@ -122,12 +158,13 @@ def pagerank(schema_madlib, vertex_table, vertex_id,
edge_table
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r177917195
--- Diff: src/ports/postgres/modules/graph/pagerank.py_in ---
@@ -149,25 +164,39 @@ def pagerank(schema_madlib, vertex_table, vertex_id,
edge_table
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r177914961
--- Diff: src/ports/postgres/modules/graph/pagerank.py_in ---
@@ -551,14 +680,16 @@ def pagerank_help(schema_madlib, message, **kwargs
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r177892625
--- Diff: src/ports/postgres/modules/graph/pagerank.py_in ---
@@ -44,29 +44,62 @@ from utilities.utilities import add_postfix
from utilities.utilities
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r177851780
--- Diff: src/ports/postgres/modules/graph/pagerank.py_in ---
@@ -44,29 +44,62 @@ from utilities.utilities import add_postfix
from utilities.utilities
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r177894976
--- Diff: src/ports/postgres/modules/graph/pagerank.py_in ---
@@ -211,19 +261,30 @@ def pagerank(schema_madlib, vertex_table, vertex_id,
edge_table
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r177915601
--- Diff: src/ports/postgres/modules/graph/pagerank.py_in ---
@@ -647,6 +778,26 @@ SELECT * FROM pagerank_out ORDER BY user_id, pagerank
DESC
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r177914251
--- Diff: src/ports/postgres/modules/graph/pagerank.py_in ---
@@ -149,25 +186,37 @@ def pagerank(schema_madlib, vertex_table, vertex_id,
edge_table
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r175631615
--- Diff: src/ports/postgres/modules/graph/pagerank.sql_in ---
@@ -273,6 +278,48 @@ SELECT * FROM pagerank_out_summary ORDER BY user_id;
(2 rows
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r175664342
--- Diff: src/ports/postgres/modules/graph/test/pagerank.sql_in ---
@@ -84,7 +89,8 @@ SELECT pagerank(
NULL,
NULL
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r175665727
--- Diff: src/ports/postgres/modules/graph/pagerank.sql_in ---
@@ -120,6 +121,10 @@ distribution per group. When this value is NULL, no
grouping is used
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r175627510
--- Diff: src/ports/postgres/modules/graph/pagerank.py_in ---
@@ -527,14 +562,63 @@ def pagerank(schema_madlib, vertex_table, vertex_id,
edge_table
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/244#discussion_r175663431
--- Diff: src/ports/postgres/modules/graph/pagerank.py_in ---
@@ -149,25 +164,39 @@ def pagerank(schema_madlib, vertex_table, vertex_id,
edge_table
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/240
We manually tested the bug fix by printing the step_size and step_size_init
for each iteration and then called mlp with all the possible policies.
step_size was updated as expected. +1
GitHub user jingyimei opened a pull request:
https://github.com/apache/madlib/pull/245
Reduce Install Check run time
To reduce the total run time of install check, we looked at the top 5
modules that take longest and modified install check test cases. See each
commit for details
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/241#discussion_r175957289
--- Diff:
src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in ---
@@ -0,0 +1,559 @@
+# coding=utf-8
+#
+# Licensed
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/325
> @orhankislal Since this is a really big change, could you please add more
info in the commit on why this change is necessary and the best available
solution?
+ 1
---
GitHub user jingyimei opened a pull request:
https://github.com/apache/madlib/pull/332
Update Dockerfile to use ubuntu 16.04
This commit adds a new dockerfile to bake postgres 10.5 on ubuntu
16.04. Also updates docker_start.sh and README to pull the new docker image
instead
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/332#discussion_r228394202
--- Diff: tool/docker/base/Dockerfile_ubuntu16_postgres10 ---
@@ -0,0 +1,108 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/332#discussion_r228394441
--- Diff: tool/docker/base/Dockerfile_ubuntu16_postgres10 ---
@@ -0,0 +1,108 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/337#discussion_r232721653
--- Diff: src/madpack/diff_udo.sql ---
@@ -0,0 +1,81
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/337#discussion_r231953942
--- Diff: src/madpack/create_changelist.py ---
@@ -237,6 +325,13 @@
print "Something went wrong! The changelist might be wrong/corr
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/337#discussion_r231972206
--- Diff: src/madpack/diff_udo.sql ---
@@ -0,0 +1,81
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/326#discussion_r221714858
--- Diff: src/ports/postgres/modules/pmml/test/pmml.ic.sql_in ---
@@ -0,0 +1,119
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/326#discussion_r221712133
--- Diff: methods/stemmer/src/pg_gp/test/porter_stemmer.sql_in ---
@@ -0,0 +1,38
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/325
@iyerr3
> I'm getting confused here, so maybe an example would help.
>
> My understanding of @orhankislal 's comment was that say `page_rank` and
`bfs` both use the s
GitHub user jingyimei opened a pull request:
https://github.com/apache/madlib/pull/323
Build: Add single quote while setting AppendOnly guc
Commit 3db98babe3326fb5e2cd16d0639a2bef264f4b04 added a context manager
for setting appendonly to false for all madlib modules. The commit
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/325
@iyerr3 The install-check schema is by module, and we may have multiple
files for one module.
For your proposed solution, what do you expect in the single source of
table creation? Do
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/343
Jenkins Ok to test
---
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/343
@hpandeycodeit Seems couple of dev check test cases failed in Jenkins
build. Can you please look into them and fix? Thanks!
---
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/343
@hpandeycodeit Can you please rebase this branch from master so that we can
do full test? Thanks!
---
82 matches
Mail list logo
