Review Request 25334: Fixed python egg proto imports.

2014-09-04 Thread Till Toenshoff
://reviews.apache.org/r/25334/diff/ Testing --- make check (OSX and linux) functional test by running build/src/examples/python/test-containerizer Thanks, Till Toenshoff

Re: The mesos.interface python egg

2014-09-04 Thread Till Toenshoff
Has someone been changing things relating to the new *mesos.interface* python egg on pypi? I don't seem to be able to install it anymore.. which is strange as it's listed as available on the pypi site. Here's some output: https://gist.github.com/tarnfeld/dcf936eb247c7bd5d2d1 I am getting

Re: Review Request 25334: Fixed python egg proto imports.

2014-09-05 Thread Till Toenshoff
--- On Sept. 4, 2014, 11:46 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334

Re: Review Request 25334: Fixed python egg proto imports.

2014-09-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/#review52331 --- On Sept. 4, 2014, 11:46 a.m., Till Toenshoff wrote

Re: Review Request 25334: Fixed python egg proto imports.

2014-09-05 Thread Till Toenshoff
of the mesos.interface Python egg generation. Diffs (updated) - src/Makefile.am 5526189 Diff: https://reviews.apache.org/r/25334/diff/ Testing --- make check (OSX and linux) functional test by running build/src/examples/python/test-containerizer Thanks, Till Toenshoff

Re: Review Request 22169: Added External Containerizer documentation.

2014-09-05 Thread Till Toenshoff
--- Thanks, Till Toenshoff

Re: [VOTE] Release Apache Mesos 0.20.1 (rc3)

2014-09-19 Thread Till Toenshoff
+1 make check on OSX 10.9.5, clang 3.5 (Xcode 6) -all tests passed On Sep 19, 2014, at 3:03 AM, Vinod Kone vinodk...@gmail.com wrote: +1 (binding) sudo make check on CentOS 5.5 w/ gcc-4.8.2 On Thu, Sep 18, 2014 at 4:05 PM, Adam Bordelon a...@mesosphere.io wrote: Hi all, Please vote

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-06 Thread Till Toenshoff
/26229/#comment95879 Did we decide on our auto use-cases yet? If I remember correctly, then we did definitely say that iterators are a perfect use case for auto and that Option/Try are an antipattern use case. - Till Toenshoff On Oct. 1, 2014, 2:12 p.m., Alexander Rukletsov wrote

Re: Review Request 26229: Expose poll interval from the reaper.

2014-10-06 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26229/#review55492 --- Ship it! Ship It! - Till Toenshoff On Oct. 1, 2014, 2:12 p.m

Re: Review Request 26352: Add --with-curl to libprocess since stout/net.hpp needs it.

2014-10-06 Thread Till Toenshoff
/26352/#comment95882 Is there a reason you are not adhering to that without_bundled_xxx scheme we are using for other bundled libraries? - Till Toenshoff On Oct. 5, 2014, 9:02 a.m., Michael Park wrote: --- This is an automatically

Re: Review Request 26352: Add --with-curl to libprocess since stout/net.hpp needs it.

2014-10-07 Thread Till Toenshoff
On Oct. 6, 2014, 1:30 p.m., Till Toenshoff wrote: 3rdparty/libprocess/configure.ac, line 99 https://reviews.apache.org/r/26352/diff/1/?file=714029#file714029line99 Is there a reason you are not adhering to that without_bundled_xxx scheme we are using for other bundled libraries

Re: Review Request 26508: Added --module flag for Mesos master.

2014-10-10 Thread Till Toenshoff
/#comment96461 Seems you should rephrase this towards path or adapt the protobuf within messages.proto to use file instead. - Till Toenshoff On Oct. 9, 2014, 11:19 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail

Re: Review Request 26508: Added --module flag for Mesos master.

2014-10-10 Thread Till Toenshoff
On Oct. 10, 2014, 1:17 p.m., Till Toenshoff wrote: src/master/flags.hpp, line 319 https://reviews.apache.org/r/26508/diff/4/?file=717127#file717127line319 Seems you should rephrase this towards path or adapt the protobuf within messages.proto to use file instead. Kapil Arya

Review Request 26571: Fixed ZooKeeper 3.4.5 OSX Yosemite build.

2014-10-10 Thread Till Toenshoff
it - I will update this accordingly. Diffs - 3rdparty/zookeeper-3.4.5.patch PRE-CREATION Diff: https://reviews.apache.org/r/26571/diff/ Testing --- make check (OSX 10.10 BETA5) Thanks, Till Toenshoff

Re: Review Request 26509: Added --module flag for Mesos slave.

2014-10-10 Thread Till Toenshoff
. - Till Toenshoff On Oct. 10, 2014, 10:04 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26509/ --- (Updated

Re: Review Request 26571: Fixed ZooKeeper 3.4.5 OSX Yosemite build.

2014-10-10 Thread Till Toenshoff
, visit: https://reviews.apache.org/r/26571/#review56234 --- On Oct. 10, 2014, 7:19 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 26588: Fixed small typo in master module flags description.

2014-10-10 Thread Till Toenshoff
Description --- see summary. Diffs - src/master/flags.hpp 44249f8 Diff: https://reviews.apache.org/r/26588/diff/ Testing --- Thanks, Till Toenshoff

Re: Review Request 26588: Fixed small typo in master module flags description.

2014-10-10 Thread Till Toenshoff
and Niklas Nielsen. Repository: mesos-git Description --- see summary. Diffs - src/master/flags.hpp 44249f8 Diff: https://reviews.apache.org/r/26588/diff/ Testing --- Thanks, Till Toenshoff

Re: Review Request 26509: Added --module flag for Mesos slave.

2014-10-12 Thread Till Toenshoff
On Oct. 10, 2014, 11:26 p.m., Till Toenshoff wrote: src/slave/main.cpp, line 117 https://reviews.apache.org/r/26509/diff/5/?file=717907#file717907line117 Not yours but this would trigger a glog warning as it has not yet been initialized. We should possibly check all runnables

Re: Review Request 26509: Added --module flag for Mesos slave.

2014-10-12 Thread Till Toenshoff
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26509/ --- (Updated Oct. 11, 2014, 1:25 a.m.) Review request for mesos, Niklas Nielsen and Till Toenshoff. Repository: mesos-git

Re: Review Request 26629: Replace cerr/exit with EXIT when parsing master flags.

2014-10-12 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26629/#review56361 --- Ship it! Ship It! - Till Toenshoff On Oct. 12, 2014, 8:11 p.m

Re: Review Request 26605: Cleanup right angle bracket in the code base.

2014-10-14 Thread Till Toenshoff
On Oct. 13, 2014, 9:17 a.m., Till Toenshoff wrote: Thanks for proposing this patch Evelina. Could you please split this into seperate patches for stout, libprocess and mesos itself? Evelina Dumitrescu wrote: What do you mean by three separate patches? I suppose three different

Large changes on the codebase due to MESOS-1872

2014-10-15 Thread Till Toenshoff
Hey Everyone, I would like to reach out to the developer community for making sure that we find a consensus on https://issues.apache.org/jira/browse/MESOS-1872 https://issues.apache.org/jira/browse/MESOS-1872 and other, entire code-base affecting changes. Evelina has bravely proposed three

Review Request 26775: Added module loading support for local clusters.

2014-10-15 Thread Till Toenshoff
- src/local/local.cpp 66de798 Diff: https://reviews.apache.org/r/26775/diff/ Testing --- make check functional check using upcoming module related patches. Thanks, Till Toenshoff

Re: Review Request 26571: Fixed ZooKeeper 3.4.5 OSX Yosemite build.

2014-10-16 Thread Till Toenshoff
://reviews.apache.org/r/26571/#review56380 --- On Oct. 10, 2014, 7:19 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 26571: Fixed ZooKeeper 3.4.5 OSX Yosemite build.

2014-10-16 Thread Till Toenshoff
PRE-CREATION Diff: https://reviews.apache.org/r/26571/diff/ Testing --- make check (OSX 10.10 BETA5) Thanks, Till Toenshoff

Re: Review Request 26789: Allow unloading a single module.

2014-10-16 Thread Till Toenshoff
the trap lingering in this, I feel it might be worth it. src/module/manager.cpp https://reviews.apache.org/r/26789/#comment97370 This sounds very temporarily almost like a TODO. - Till Toenshoff On Oct. 16, 2014, 3:12 p.m., Kapil Arya wrote

Review Request 26857: Added CRAM-MD5 Authenticator module.

2014-10-16 Thread Till Toenshoff
/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-16 Thread Till Toenshoff
/26859/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-16 Thread Till Toenshoff
Diff: https://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.

2014-10-16 Thread Till Toenshoff
/tests/crammd5_authenticator_tests.cpp PRE-CREATION src/tests/mesos.cpp 3dcb2ac src/tests/sasl_tests.cpp 30556fa src/tests/script.cpp 515e314 Diff: https://reviews.apache.org/r/26860/diff/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 26855: Added setup/teardown for module API tests.

2014-10-16 Thread Till Toenshoff
for me. src/tests/module_tests.hpp https://reviews.apache.org/r/26855/#comment97583 That wont work for OSX - you will need to do the same for DYLD_LIBRARY_PATH - Till Toenshoff On Oct. 17, 2014, 3:28 a.m., Kapil Arya wrote

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2462

2014-10-18 Thread Till Toenshoff
Assuming a false positive until advised otherwise. On Oct 18, 2014, at 4:04 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2462/changes Changes: [toenshoff]

Re: Review Request 26775: Added module loading support for local clusters.

2014-10-19 Thread Till Toenshoff
--- On Oct. 15, 2014, 9:07 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26775

Re: Review Request 26775: Added module loading support for local clusters.

2014-10-19 Thread Till Toenshoff
patches. Thanks, Till Toenshoff

Re: Review Request 26775: Added module loading support for local clusters.

2014-10-19 Thread Till Toenshoff
/local.cpp 66de798 Diff: https://reviews.apache.org/r/26775/diff/ Testing --- make check functional check using upcoming module related patches. Thanks, Till Toenshoff

Re: Review Request 26775: Added module loading support for local clusters.

2014-10-21 Thread Till Toenshoff
at all. Till Toenshoff wrote: I guess I was taking too much care here :) thanks - indeed, why not. Will you propose a RR fixing: module/manager.cpp - 206-209 and possibly others as well? // Check for possible duplicate module names. if (moduleBases.contains(moduleName

Re: Review Request 26857: Added CRAM-MD5 Authenticator module.

2014-10-21 Thread Till Toenshoff
-CREATION Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-21 Thread Till Toenshoff
://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 26775: Added module loading support for local clusters.

2014-10-21 Thread Till Toenshoff
/local.cpp 66de798 Diff: https://reviews.apache.org/r/26775/diff/ Testing --- make check functional check using upcoming module related patches. Thanks, Till Toenshoff

Re: Review Request 26797: Added --isolation flag for tests.

2014-10-23 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26797/#review58086 --- Ship it! Ship It! - Till Toenshoff On Oct. 22, 2014, 7:50 p.m

Re: Review Request 26775: Added module loading support for local clusters.

2014-10-23 Thread Till Toenshoff
support via slave and master flags (--modules). Diffs (updated) - src/local/local.cpp 2756d42 Diff: https://reviews.apache.org/r/26775/diff/ Testing --- make check functional check using upcoming module related patches. Thanks, Till Toenshoff

Re: Review Request 27116: Fix Libprocess benchmark OSX

2014-10-23 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27116/#review58167 --- Ship it! Ship It! - Till Toenshoff On Oct. 23, 2014, 11:17 p.m

Review Request 27122: Reorganized authentication implementation locations.

2014-10-23 Thread Till Toenshoff
/crammd5_authentication_tests.cpp PRE-CREATION src/tests/sasl_tests.cpp 30556fa Diff: https://reviews.apache.org/r/27122/diff/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 26857: Added CRAM-MD5 Authenticator module.

2014-10-23 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/#review57844 --- On Oct. 24, 2014, 1:28 a.m., Till Toenshoff wrote

Re: Review Request 26857: Added CRAM-MD5 Authenticator module.

2014-10-23 Thread Till Toenshoff
--- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 27122: Reorganized authentication implementation locations.

2014-10-23 Thread Till Toenshoff
Thanks, Till Toenshoff

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-23 Thread Till Toenshoff
/#review57763 --- On Oct. 21, 2014, 1:01 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-23 Thread Till Toenshoff
--- On Oct. 21, 2014, 1:01 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/ --- (Updated Oct. 21, 2014, 1

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-23 Thread Till Toenshoff
/authenticator.hpp PRE-CREATION src/tests/crammd5_authentication_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-23 Thread Till Toenshoff
PRE-CREATION src/tests/crammd5_authentication_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.

2014-10-23 Thread Till Toenshoff
-MD5 authenticator Thanks, Till Toenshoff

Re: Review Request 27122: Reorganized authentication implementation locations.

2014-10-25 Thread Till Toenshoff
/crammd5_authentication_tests.cpp PRE-CREATION src/tests/sasl_tests.cpp 30556fa Diff: https://reviews.apache.org/r/27122/diff/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 26857: Added CRAM-MD5 Authenticator module.

2014-10-25 Thread Till Toenshoff
/test_authenticator_module.cpp PRE-CREATION src/module/manager.cpp 1613e39 Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-25 Thread Till Toenshoff
/crammd5_authentication_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-25 Thread Till Toenshoff
: https://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.

2014-10-25 Thread Till Toenshoff
275554304 master.cpp:3865] Using default CRAM-MD5 authenticator Thanks, Till Toenshoff

Re: Review Request 27051: Added support for module-specific command-line parameters.

2014-10-27 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27051/#review58613 --- Ship it! Ship It! - Till Toenshoff On Oct. 27, 2014, 11:45 a.m

Re: Review Request 26857: Added CRAM-MD5 Authenticator module.

2014-10-28 Thread Till Toenshoff
/test_authenticator_module.cpp PRE-CREATION src/module/manager.cpp 7a6c884 Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-28 Thread Till Toenshoff
://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 27122: Reorganized authentication implementation locations.

2014-10-29 Thread Till Toenshoff
, visit: https://reviews.apache.org/r/27122/#review58910 --- On Oct. 25, 2014, 1:21 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 27122: Reorganized authentication implementation locations.

2014-10-29 Thread Till Toenshoff
src/slave/slave.cpp 96fb5f7 src/tests/cram_md5_authentication_tests.cpp PRE-CREATION src/tests/sasl_tests.cpp 30556fa Diff: https://reviews.apache.org/r/27122/diff/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 26857: Added CRAM-MD5 Authenticator module.

2014-10-29 Thread Till Toenshoff
, Till Toenshoff

Re: Review Request 26857: Added CRAM-MD5 Authenticator module.

2014-10-29 Thread Till Toenshoff
, visit: https://reviews.apache.org/r/26857/#review58909 --- On Oct. 29, 2014, 3:03 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 26857: Added CRAM-MD5 Authenticator module.

2014-10-29 Thread Till Toenshoff
/test_authenticator_module.cpp PRE-CREATION src/module/authenticator.hpp PRE-CREATION src/module/manager.cpp 7a6c884 Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-29 Thread Till Toenshoff
Diff: https://reviews.apache.org/r/26859/diff/ Testing (updated) --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-29 Thread Till Toenshoff
e-mail. To reply, visit: https://reviews.apache.org/r/26859/#review58924 --- On Oct. 29, 2014, 5:19 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-29 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/#review58921 --- On Oct. 29, 2014, 5:19 p.m., Till Toenshoff wrote

Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.

2014-10-29 Thread Till Toenshoff
275554304 master.cpp:3865] Using default CRAM-MD5 authenticator Thanks, Till Toenshoff

Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.

2014-10-29 Thread Till Toenshoff
default CRAM-MD5 authenticator Thanks, Till Toenshoff

Re: Review Request 26857: Added CRAM-MD5 Authenticator module.

2014-10-29 Thread Till Toenshoff
-CREATION src/module/authenticator.hpp PRE-CREATION src/module/manager.cpp 7a6c884 Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-29 Thread Till Toenshoff
: https://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 26857: Added CRAM-MD5 Authenticator module.

2014-10-29 Thread Till Toenshoff
point. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/#review59073 --- On Oct. 29, 2014, 6:51 p.m., Till Toenshoff wrote

Re: Review Request 27122: Reorganized authentication implementation locations.

2014-10-29 Thread Till Toenshoff
generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/#review59069 --- On Oct. 29, 2014, 1:43 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail

Re: Review Request 27122: Reorganized authentication implementation locations.

2014-10-29 Thread Till Toenshoff
/slave/slave.cpp 96fb5f7 src/tests/cram_md5_authentication_tests.cpp PRE-CREATION src/tests/sasl_tests.cpp 30556fa Diff: https://reviews.apache.org/r/27122/diff/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 26857: Added CRAM-MD5 Authenticator module.

2014-10-29 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/#review59073 --- On Oct. 29, 2014, 6:51 p.m., Till Toenshoff wrote

Re: Review Request 26857: Added CRAM-MD5 Authenticator module.

2014-10-29 Thread Till Toenshoff
. To reply, visit: https://reviews.apache.org/r/26857/#review59073 --- On Oct. 29, 2014, 6:51 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 26857: Added CRAM-MD5 Authenticator module.

2014-10-29 Thread Till Toenshoff
/test_authenticator_module.cpp PRE-CREATION src/module/authenticator.hpp PRE-CREATION src/module/manager.cpp 7a6c884 Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till

Re: Review Request 26857: Added CRAM-MD5 Test Authenticator module.

2014-10-29 Thread Till Toenshoff
) --- make check NOTE all four CRAM-MD5 test authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 27122: Reorganized authentication implementation locations.

2014-10-29 Thread Till Toenshoff
On Oct. 28, 2014, 11:37 p.m., Kapil Arya wrote: src/authentication/cram_md5/authenticator.hpp, lines 19-20 https://reviews.apache.org/r/27122/diff/2/?file=733314#file733314line19 s/CRAMMD5/AUTHENTICATION_CRAM_MD5/ ? Till Toenshoff wrote: I find the idea of reversing

Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.

2014-10-29 Thread Till Toenshoff
CRAM-MD5 authenticator Thanks, Till Toenshoff

Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.

2014-10-29 Thread Till Toenshoff
... - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26860/#review59125 --- On Oct. 30, 2014, 2:54 a.m., Till Toenshoff wrote

Review Request 27395: Fixed test namespace setter compilation exclusion on OSX.

2014-10-30 Thread Till Toenshoff
://issues.apache.org/jira/browse/MESOS-2015 Repository: mesos-git Description --- see summary Diffs - src/Makefile.am 374f284 Diff: https://reviews.apache.org/r/27395/diff/ Testing --- make check (on OSX) Thanks, Till Toenshoff

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-30 Thread Till Toenshoff
/cram_md5_authentication_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-30 Thread Till Toenshoff
/cram_md5_authentication_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.

2014-10-30 Thread Till Toenshoff
:3865] Using default CRAM-MD5 authenticator Thanks, Till Toenshoff

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-30 Thread Till Toenshoff
PRE-CREATION Diff: https://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-30 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/#review59108 --- On Oct. 30, 2014, 11:58 p.m., Till Toenshoff wrote

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

2014-10-31 Thread Till Toenshoff
/cram_md5_authentication_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all four CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff

Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.

2014-10-31 Thread Till Toenshoff
:3865] Using default CRAM-MD5 authenticator Thanks, Till Toenshoff

Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.

2014-10-31 Thread Till Toenshoff
default CRAM-MD5 authenticator Thanks, Till Toenshoff

Re: Review Request 27395: Fixed test namespace setter compilation exclusion on OSX.

2014-10-31 Thread Till Toenshoff
generated e-mail. To reply, visit: https://reviews.apache.org/r/27395/#review59388 --- On Oct. 30, 2014, 9:26 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail

Re: Review Request 26857: Added CRAM-MD5 Test Authenticator module.

2014-10-31 Thread Till Toenshoff
. Thanks, Till Toenshoff

Re: Review Request 27122: Reorganized authentication implementation locations.

2014-10-31 Thread Till Toenshoff
0fb8c7b src/scheduler/scheduler.cpp fb88a3e src/slave/slave.hpp eb5de73 src/slave/slave.cpp 96fb5f7 src/tests/cram_md5_authentication_tests.cpp PRE-CREATION src/tests/sasl_tests.cpp 30556fa Diff: https://reviews.apache.org/r/27122/diff/ Testing --- make check Thanks, Till

Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.

2014-10-31 Thread Till Toenshoff
a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26860/ --- (Updated Oct. 31, 2014, 11:18 a.m.) Review

Re: Review Request 27461: Change process reparent test to be recursive search for init

2014-10-31 Thread Till Toenshoff
://reviews.apache.org/r/27461/#comment100739 I think the following would be a bit easier on the eye, no? ```while (currentProcess.isSome() !currentProcess.get().zombie))``` - Till Toenshoff On Nov. 1, 2014, 2:52 a.m., Joris Van Remoortere wrote

Re: Review Request 27481: Updated Modules protobuf to simplify JSON parsing.

2014-11-03 Thread Till Toenshoff
to spot issues we saw with the earlier version of the libraries protobuf much quicker (documentation was not in sync with json-format). - Till Toenshoff On Nov. 2, 2014, 1:02 a.m., Kapil Arya wrote: --- This is an automatically

Re: Review Request 27453: First version of docs/modules.md.

2014-11-03 Thread Till Toenshoff
://reviews.apache.org/r/27453/#comment100997 This should be libraries docs/modules.md https://reviews.apache.org/r/27453/#comment100998 This should be parameters - Till Toenshoff On Nov. 4, 2014, 12:51 a.m., Kapil Arya wrote

Re: Review Request 27560: Updated --isolation help message for slave.

2014-11-03 Thread Till Toenshoff
/#comment101008 Not sure we need a capital I for isolator :) - Till Toenshoff On Nov. 4, 2014, 1:34 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27560

Re: Review Request 27560: Updated --isolation help message for slave.

2014-11-03 Thread Till Toenshoff
/#comment101012 Are we missing the default here? - Till Toenshoff On Nov. 4, 2014, 1:42 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27560

  1   2   3   4   5   6   7   8   >