eRangerAuthorizationTest.java
(line 686)
<https://reviews.apache.org/r/55659/#comment233988>
Instead of calling it "GroupPublic", it might be better to call
'NonQAGroup' - as this test is about policy for QA group.
- Madhan Neethiraj
On Jan. 18, 2017, 2:13 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55659/#review162679
---
Ship it!
Ship It!
- Madhan Neethiraj
On Jan. 23, 2017, 6:56
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55864/#review162842
---
Ship it!
Ship It!
- Madhan Neethiraj
On Jan. 23, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55860/#review162845
---
Ship it!
Ship It!
- Madhan Neethiraj
On Jan. 23, 2017, 10
:
public static boolean isServiceNotFoundError(String seviceName, String
exceptionMessage) {
}
- Madhan Neethiraj
On Jan. 25, 2017, 8:32 a.m., Abhay Kulkarni wrote:
>
> ---
> This
-
>
> (Updated Jan. 27, 2017, 10:49 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-1329
> https://issues.apache.org/jira/browse/RANGER-1329
>
>
> Repository: ranger
>
>
> Description
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56089/#review163622
---
Ship it!
Ship It!
- Madhan Neethiraj
On Jan. 30, 2017, 6:08
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56192/#review164306
---
Ship it!
Ship It!
- Madhan Neethiraj
On Feb. 4, 2017, 5:37
://reviews.apache.org/r/56571/#comment237703>
Is this method supposed to add certain configured users/groups to all
policy items in default policies? The implementation seems to do a lot more;
please review and simplify.
- Madhan Neethiraj
On Feb. 11, 20
pache/ranger/biz/ServiceDBStore.java (line
2161)
<https://reviews.apache.org/r/56640/#comment237948>
Instead of hardcoding resource names ("path" and "queue") and delimiters
(".", "/"), consider reading thes
compliance or
minor improvements. Instead, I would recommend such updates be done when source
files are changed to address a bug or enhancement. This would help minimize the
chances of a new bug getting introduced in massive updates.
- Madhan Neethiraj
On Feb. 21, 2017, 3:49 p.m., Zsombor
ine
2202)
<https://reviews.apache.org/r/56640/#comment238235>
line #2202 can be:
for (RangerPolicy policy : policies) {
...
}
workList does not seen necessary.
- Madhan Neethiraj
On Feb. 21, 2017, 10:11 p.m., Abhay Kulka
ache/ranger/plugin/service/RangerBaseService.java
(line 142)
<https://reviews.apache.org/r/56571/#comment238241>
Consider moving line #142 inside createDefaultPolicyItem() method - as the
method has access to 'service' config, from which the userList is derived.
- Madhan Neethir
foreach (policy)
foreach(matcher)
...
- Madhan Neethiraj
On Feb. 22, 2017, 11:37 p.m., Abhay Kulkarni wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
Similar refactoring for getRowFilterExpression() as well.
- Madhan Neethiraj
On Feb. 27, 2017, 11:22 p.m., Abhay Kulkarni wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57114/#review167002
---
Ship it!
Ship It!
- Madhan Neethiraj
On Feb. 28, 2017, 1:55
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57438/#review168578
---
Ship it!
Ship It!
- Madhan Neethiraj
On March 9, 2017, 1:44
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57668/#review169070
---
Ship it!
Ship It!
- Madhan Neethiraj
On March 15, 2017, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57849/#review169739
---
Ship it!
Ship It!
- Madhan Neethiraj
On March 22, 2017, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57977/#review170238
---
Ship it!
Ship It!
- Madhan Neethiraj
On March 27, 2017, 10
java/org/apache/ranger/biz/ServiceDBStore.java
Lines 2524 (patched)
<https://reviews.apache.org/r/58034/#comment243760>
Consider excluding user names like {OWNER}, {USER} from here.
- Madhan Neethiraj
On March 31, 2017, 7:31 p.m., Abhay Kulkarni wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58115/#review170897
---
Ship it!
Ship It!
- Madhan Neethiraj
On March 31, 2017, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58632/#review173089
---
Ship it!
Ship It!
- Madhan Neethiraj
On April 21, 2017, 9
ugh #928 should be replaced with:
if
(tagEvalResult.getIsAuditedDetermined() &&
tagEvalResult.getIsAccessDetermined()) {
break;
}
- Madhan Neethiraj
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57441/#review173099
---
Ship it!
Ship It!
- Madhan Neethiraj
On March 9, 2017, 2:28
uators(tags, tagPolicyRepository,
tagPolicyRepository.getDataMaskPolicyEvaluators());
Same applies for getDataMaskOrRowFilterEvaluators() as well.
Also, consider moving these methods to RangerPolicyRepository:
getDataMaskPolicyEvaluators(Set tags)
getRowFilterPolicyEvaluators(Set tags)
- Madh
would have to be added to allow URL
access; else it might break existing deployments. Please review.
One option to consider is to fallback on FileSystem access check when there
is no Ranger Hive policy to grant the necessary access.
- Madhan Neethiraj
On April 30, 2017, 9:37 a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58912/#review173614
---
Ship it!
Ship It!
- Madhan Neethiraj
On May 2, 2017, 3:26
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58658/#review174057
---
Ship it!
Ship It!
- Madhan Neethiraj
On May 4, 2017, 5:10
/policyengine/RangerPolicyEngineImpl.java
Lines 198 (patched)
<https://reviews.apache.org/r/59247/#comment248084>
Consider moving this to "default" case above.
- Madhan Neethiraj
On May 12, 2017, 10:41 p.m., Abhay Kulkarni wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59247/#review174872
---
Ship it!
Ship It!
- Madhan Neethiraj
On May 12, 2017, 11:54
fter all formats have been tried,
in getAsDate(String value). Else this might generate excessive, unnecessary
warning messages.
- Madhan Neethiraj
On May 15, 2017, 9:25 p.m., Abhay Kulkarni wrote:
>
> ---
> This is an automatica
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59296/#review175199
---
Ship it!
Ship It!
- Madhan Neethiraj
On May 16, 2017, 9:17
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59296/#review175318
---
Ship it!
Ship It!
- Madhan Neethiraj
On May 17, 2017, 9:33
sorted by descending order of the format string length?
- Madhan Neethiraj
On May 18, 2017, 1:35 a.m., Abhay Kulkarni wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59296/#review175385
---
Ship it!
Ship It!
- Madhan Neethiraj
On May 18, 2017, 2:55
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58498/#review175392
---
Ship it!
Ship It!
- Madhan Neethiraj
On April 18, 2017, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59431/#review175604
---
Ship it!
Ship It!
- Madhan Neethiraj
On May 22, 2017, 2:07
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59469/#review175727
---
Ship it!
Ship It!
- Madhan Neethiraj
On May 22, 2017, 11:12
All,
I notice a number of recent patches address trivial issues like white space,
spelling mistakes (one patch just changed a single letter in a label). And few
other patches update a large number of files for trivial/non-functional changes
– like whitespaces. I strongly suggest we refrain f
d
> maybe
> > be consolidated a bit more. I will encourage future review requests that
> > have a very trivial spelling fix to hold on to the fix for a while, so
> that
> > we can fix multiple spelling fixes etc. at the same time.
> >
> >
ltiple spelling fixes etc. at the same time.
Colm.
On Wed, May 24, 2017 at 7:27 AM, Madhan Neethiraj ＜mad...@apache.org＞ wrote:
＞ All,
＞
＞
＞
＞ I notice a number of recent patches address trivial issues like white
＞ space, spelling mistakes (one patch just changed a single letter in a
＞ label). And f
o redo RANGER-1589 to ensure that build works in
environments that don't have python2 executable as well.
- Madhan Neethiraj
On May 26, 2017, 3:36 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59606/#review176220
---
Ship it!
Ship It!
- Madhan Neethiraj
On May 26, 2017, 10:57
/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
Lines 820 (patched)
<https://reviews.apache.org/r/58154/#comment249932>
This block should either be moved up, before line #815 or updated to
replace 'tagEvalResult' with 'result'.
- Madhan Neethiraj
On April
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58219/#review176563
---
Ship it!
Ship It!
- Madhan Neethiraj
On April 21, 2017, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59729/#review176739
---
Ship it!
Ship It!
- Madhan Neethiraj
On June 1, 2017, 9:04
+1 (binding).
Thanks,
Madhan
On 6/1/17, 8:08 AM, "Velmurugan Periasamy" wrote:
Hello Rangers:
Apache Ranger 0.7.1 release candidate #1 is now available for a vote within
dev community. Links to release artifacts are given below. Could you please
review and vote?
The v
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59807/#review176948
---
Ship it!
Ship It!
- Madhan Neethiraj
On June 5, 2017, 5:17
Colm, Bhavik, Zsombor, Abhay,
As recent updaters of TestServiceREST.java, can you please review the following
issues flagged by Coverity scan?
Thanks,
Madhan
On 6/11/17, 1:12 AM, "scan-ad...@coverity.com" wrote:
Hi,
Please find the latest report on new defect(s) introduced
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/#review177663
---
Ship it!
Ship It!
- Madhan Neethiraj
On June 12, 2017, 12
/service-defs/ranger-servicedef-tag.json
Lines 75 (patched)
<https://reviews.apache.org/r/60140/#comment251861>
Consider using a shorter name, like 'expression' - as this will be used in
policy UI.
- Madhan Neethiraj
On June 15, 2017, 11:21 p.m., Sailaja
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60167/#review178139
---
Ship it!
Ship It!
- Madhan Neethiraj
On June 16, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60286/#review178542
---
Ship it!
Ship It!
- Madhan Neethiraj
On June 21, 2017, 8:14
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60140/#review178727
---
Ship it!
Ship It!
- Madhan Neethiraj
On June 22, 2017, 6:02
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60402/#review178818
---
Ship it!
Ship It!
- Madhan Neethiraj
On June 23, 2017, 10
Fatima,
Done. Welcome to Apache Ranger community!
Thanks,
Madhan
On 6/23/17, 6:11 AM, "Fatima Khan" wrote:
Rangers:
As I have been involved in the Apache Ranger project for a while now, Can
you please add me as a contributor to the project ?
*Thanks & Reg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60256/#review178909
---
Ship it!
Ship It!
- Madhan Neethiraj
On June 21, 2017, 12
Nikhil,
Done. Thanks for your contributions and welcome to Apache Ranger community!
Madhan
On 6/27/17, 2:12 AM, "NIKHIL PURBHE" wrote:
Rangers,
As I have been involved in the Apache Ranger project for a while now, Can
you please add me as a contributor to the project.
+1
Thanks,
Madhan
On 7/16/17, 11:08 PM, "Don Bosco Durai" wrote:
+1
Selva, thanks for putting this together.
Regards
Bosco
On 7/16/17, 11:06 PM, "Selvamohan Neethiraj" wrote:
All:
Attached is the board report for the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60908/#review180700
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 17, 2017, 1:21
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61013/#review181300
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 20, 2017, 11
ched)
<https://reviews.apache.org/r/60949/#comment256848>
Consider moving this to earlier point, @ line #134 - to ensure that the log
captures the total time spent in the authorizer. Similarly for other authorizer
calls as well.
- Madhan Neethiraj
On July 19, 2017, 12:57 a.m., Ab
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60949/#review181466
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 25, 2017, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61199/#review181711
---
Ship it!
Ship It!
- Madhan Neethiraj
On July 28, 2017, 6:31
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61678/#review183056
---
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 16, 2017, 3:06
Rohit,
Currently, Ranger requires an entire resource-hierarchy to be specified in a
policy. It doesn’t allow policies that stop at a higher-level resource in a
hierarchy. This is one of the often-asked enhancements to Ranger policy model.
Can you please file a JIRA with details of your use-case
pful to look into the cause for the 10%
overhead you notice and try to improve policy execution, where feasible,
instead of going for caching the results.
- Madhan Neethiraj
On Aug. 23, 2017, 6:39 p.m., Qiang Zhang wrote:
>
> ---
&
> On Aug. 25, 2017, 6:31 a.m., Madhan Neethiraj wrote:
> > hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
> > Line 333 (original), 337 (patched)
> > <https://reviews.apache.org/r/61843/diff/1/?file=1802180#file1802180li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61836/#review183826
---
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 23, 2017, 3:07
statement outside synchronized block here may not
improve performance much.
- Madhan Neethiraj
On Aug. 22, 2017, 3:14 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
remove this class and instead use
RangerDefaultAuditHandler set in line #135. With this, you don't need to pass
auditHandler argument in isAccessAllowed() call - line #89.
- Madhan Neethiraj
On Aug. 8, 2017, 2:08 a.m., Qiang Zhang wrote:
>
> --
planning to add plugin
implementation as well?
- Madhan Neethiraj
On July 25, 2017, 6:42 p.m., Anandsagar Kothapalli wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61519/#review184168
---
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 30, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59604/#review184282
---
Ship it!
Ship It!
- Madhan Neethiraj
On May 26, 2017, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62010/#review184283
---
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 31, 2017, 7:22
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62208/#review185058
---
Ship it!
Ship It!
- Madhan Neethiraj
On Sept. 11, 2017, 2
ountOfTaggedResources != 0L)
To:
if (countOfTaggedResources > 0L)
- Madhan Neethiraj
On Sept. 21, 2017, 11:11 p.m., Abhay Kulkarni wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63085/#review188498
---
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 18, 2017, 1:03
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63225/#review188995
---
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 23, 2017, 9:45
/tagsync/source/atlas/AtlasTagSource.java
Lines 174 (patched)
<https://reviews.apache.org/r/62947/#comment266552>
It will be useful to include notification type in the warning log.
- Madhan Neethiraj
On Oct. 12, 2017, 7:27 p.m., Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63686/#review190548
---
Ship it!
Ship It!
- Madhan Neethiraj
On Nov. 8, 2017, 11:16
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63708/#review190679
---
Ship it!
Ship It!
- Madhan Neethiraj
On Nov. 9, 2017, 10:41
mit-app' access as well
- other option is to have 'impliedGrants' interpretted only by UI and have
policy engine ignore it. In this case, when 'admin-queue' is selected in the
UI, 'submit-app' will automatically be selected - but the user will be able to
de-s
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63738/#review190769
---
Ship it!
Ship It!
- Madhan Neethiraj
On Nov. 10, 2017, 6:49
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63929/#review191415
---
Ship it!
Ship It!
- Madhan Neethiraj
On Nov. 17, 2017, 11
that tags successfully download with Atlas V2 REST APIs.
Thanks,
Madhan Neethiraj
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64042/#review191771
---
On Nov. 23, 2017, 12:52 a.m., Madhan Neethiraj wrote:
>
> --
APIs.
Thanks,
Madhan Neethiraj
have any
> > attributes set whereas superClassification has selected attributes set(line
> > 527). Will it affect how getRangerTag() works? (line 544)?
>
> Madhan Neethiraj wrote:
> Not sure I understand the comment. When a classification has attributes
> (#513), some/
hanks,
Madhan Neethiraj
/tagsync/source/atlasrest/AtlasRESTUtil.java
00a101e7
Diff: https://reviews.apache.org/r/64042/diff/4/
Changes: https://reviews.apache.org/r/64042/diff/3-4/
Testing
---
Verified that tags successfully download with Atlas V2 REST APIs.
Thanks,
Madhan Neethiraj
change from org.codehaus.jackson =>
com.fasterxml.jackson.
- Madhan Neethiraj
On Nov. 30, 2017, 12:52 a.m., Abhay Kulkarni wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
ERMINED;
} else {
ret = result.getIsAllowed() ? AuthzStatus.ALLOW : AuthzStatus.DENY;
}
- Madhan Neethiraj
On Dec. 2, 2017, 1:25 a.m., Abhay Kulkarni wrote:
>
> ---
> This is an automatically generated
> On Dec. 5, 2017, 9:44 p.m., Madhan Neethiraj wrote:
> > hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java
> > Lines 452 (patched)
> > <https://reviews.apache.org/r/64228/diff/2/?file=1906576#file1906576line467>
> >
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64228/#review192956
---
Ship it!
Ship It!
- Madhan Neethiraj
On Dec. 5, 2017, 11:45
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/RangerAtlasHdfsEntity.java
Lines 25 (patched)
<https://reviews.apache.org/r/64189/#comment271544>
Consider marking the members as final.
- Madhan Neethiraj
O
assificationType.getAttribute(tagAttributeName);
if (attribute != null) {
ret = attribute.getTypeName();
}
}
- Madhan Neethiraj
On Dec. 7, 2017, 1:37 a.m., Abhay Kulkarni wrote:
>
> ---
> Thi
/tagsync/source/atlasrest/AtlasRESTTagSource.java
Line 180 (original), 208 (patched)
<https://reviews.apache.org/r/64189/#comment271757>
"Info" ==> "Debug". Also in line #210 below.
- Madhan Neethiraj
On Dec. 8, 2017, 1:
t;
> (Updated Dec. 14, 2017, 7:59 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Sailaja Polavarapu, and
> Velmurugan Periasamy.
>
>
> Bugs: RANGER-1931
> https://issues.apache.org/jira/browse/RANGER-1931
>
>
> Repository: ranger
>
>
1 - 100 of 3181 matches
Mail list logo
