Re: Review Request 62983: SENTRY-1986: Fix NPE on createGrantTask from SentryHiveAuthorizationTaskFactoryImpl.java

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62983/#review188145 ---

Re: Review Request 62979: SENTRY-1985: Sentry should log in stdout when it is ready to serve requests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62979/#review188143 --- Ship it! Ship It! - kalyan kumar kalvagadda On Oct. 16,

Re: Review Request 62951: SENTRY-1231: Sentry doesn't secure index location uri, when do "CREATE INDEX LOCATION ''/uri"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62951/#review188149 ---

Re: Review Request 63047: SENTRY-1994: Bump Shiro dependency version to 1.4.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63047/#review188302 --- Ship it! Ship It! - kalyan kumar kalvagadda On Oct. 16,

Re: Review Request 63069: SENTRY-1996 - Rename Sqoop SentryAuthorizationHander

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63069/#review188299 --- Fix it, then Ship it! Please adddress the commit comment and

Re: Review Request 62902: SENTRY-1978: Move the hive-authz2 grant/revoke implementation into the sentry-binding-hive module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62902/#review188197 --- Ship it! Segio, I'm good with the changes. It's just

Re: Review Request 62950: SENTRY-1981: Bump codehale metrics version to latest 3.0.2 version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62950/#review187864 --- Ship it! Ship It! - kalyan kumar kalvagadda On Oct. 12,

Re: Review Request 62992: SENTRY-1990: Use same hadoop.version to hadoop-aws dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62992/#review188133 --- Ship it! Ship It! - kalyan kumar kalvagadda On Oct. 13,

Review Request 63178: SENTRY-1989: Bump Kafka version from 0.9 to 0.11

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63178/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-1989

Re: Review Request 63185: SENTRY-2013 - Align the SentryGenericServiceClient and SentryPolicyServiceClient a bit more closely

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63185/#review188994 --- Ship it! Looks good to me. There is a kafka test failure which

Re: Review Request 51445: SENTRY-1453: Enable passing sentry client cache configs from kafka conf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51445/#review188587 --- Ship it! Ship It! - kalyan kumar kalvagadda On Aug. 30,

Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63160/#review188735 --- I'm fine with bumping up the jetty version but the only concern

Review Request 64097: SENTRY-2072: log4j2 dependencies brought by Hive 2 are causing conflicts with Sentry log4j

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64097/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2072

Re: Review Request 63974: SENTRY-2062: Support the new Hive 2.3.2 DbNotificationListener

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63974/#review191762 --- Ship it! Looks good. - kalyan kumar kalvagadda On Nov. 21,

Re: Review Request 63985: SENTRY-2056: Display test-patch.py output on the standard console to see progress on Jenkins

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63985/#review191744 --- || visible in terminal || visible in file || existing

Re: Review Request 63985: SENTRY-2056: Display test-patch.py output on the standard console to see progress on Jenkins

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63985/#review191746 --- Ship it! looks good - kalyan kumar kalvagadda On Nov. 22,

Review Request 64220: SENTRY-2080: Stop distributing jars with GPL and LGPL licenses only

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64220/ --- Review request for sentry, Brian Towles and Colm O hEigeartaigh. Bugs:

Re: Review Request 64230: SENTRY-2082: Exclude javax.servlet-3.0.0.v201112011016.jar from Sentry dist

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64230/#review192424 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 30,

Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64241/ --- Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O

Re: Review Request 64179: SENTRY-2079: Sentry HA leader monitor does not work due to a mix of curator versions in the classpath

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64179/#review192434 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 29,

Re: Review Request 64097: SENTRY-2072: log4j2 dependencies brought by Hive 2 are causing conflicts with Sentry log4j

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64097/ --- (Updated Nov. 27, 2017, 11:22 p.m.) Review request for sentry and Sergio Pena.

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64241/ --- (Updated Dec. 1, 2017, 8:50 p.m.) Review request for sentry, Alexander

Re: Review Request 64317: SENTRY-2085: Keep sentry exceptions contained within Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64317/#review194177 ---

Re: Review Request 63896: SENTRY-2052: Reduce TestSentryStore time by setting transaction retries to 1 and other refactors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63896/#review191364 ---

Re: Review Request 63925: SENTRY-1640: Implement HMS Notification barrier on the HMS plugin side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63925/#review191394 --- Fix it, then Ship it! please fix the minor comment and push

Re: Review Request 63928: SENTRY-2054: Unit tests must create temporary files under the Maven target directory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63928/#review191438 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 17,

Re: Review Request 63762: [solr] SENTRY-2042 Support file based Sentry provider for Solr plugin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63762/#review190951 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 13,

Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2034

Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/ --- (Updated Nov. 21, 2017, 12:27 a.m.) Review request for sentry, Na Li and

Review Request 63996: SENTRY-2059: Fix the tests to use transaction listeners for handling HMS Notifications.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63996/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2059

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/#review191615 ---

Re: Review Request 63878: [SENTRY-1480] Solr/Sentry permissions migration tool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63878/#review191657 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 21,

Re: Review Request 63878: [SENTRY-1480] Solr/Sentry permissions migration tool

> On Nov. 16, 2017, 10 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/PermissionsMigrationToolCommon.java > > Lines 236 (patched) > >

Re: Review Request 63974: SENTRY-2062: Support the new Hive 2.3.2 DbNotificationListener

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63974/#review191686 --- Code looks good overall. I have some questions/clarifications

Re: Review Request 63856: SENTRY-2048: Bump Hive version to 2.3.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63856/#review191252 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 16,

Re: Review Request 63886: SENTRY-2047: isTableEmptyCore method in SentryStore has references to MAuthzPathsMapping when it should be generic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63886/#review191272 --- Ship it! make sure that tests pass. - kalyan kumar kalvagadda

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63250/#review189823 --- These are my comments in initial pass. I'm still reviewing the

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/#review189827 --- Your description here is not in-line with the comments in jira.

Review Request 63335: SENTRY-2018: Remove SentryMetastorePostEventListener and SentryMetastorePostEventListenerBase classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63335/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2018

Re: Review Request 63488: SENTRY-2029: Unit test fails consistently for org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeCleanupOnDrop

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63488/#review190027 --- Ship it! Look's like adeeper issue. please proceed with the

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/#review189849 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 1,

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

> On Nov. 1, 2017, 8:42 p.m., kalyan kumar kalvagadda wrote: > > sentry-core/sentry-core-model-solr/src/main/java/org/apache/sentry/core/model/solr/Admin.java > > Lines 26 (patched) > > > > > > Here name Admin

Re: Review Request 63509: SENTRY-2028: Avoid datanucleus to create/update database schema

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63509/ --- (Updated Nov. 3, 2017, 10:52 p.m.) Review request for sentry, Alexander

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63250/#review190068 --- There are couple of missing pieces 1. AuditLogger does not

Re: Review Request 63488: SENTRY-2029: Unit test fails consistently for org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeCleanupOnDrop

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63488/#review189956 --- Let's not revert it the change. let's try to figure the root

Review Request 63509: SENTRY-2028: Avoid datanucleus to create/update database schema

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63509/ --- Review request for sentry, Alexander Kolbasov, Brian Towles, Na Li, and Sergio

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63250/#review190372 --- Ship it! Plesae address the one last comment that I have and

Re: Review Request 63646: SENTRY-2035: Metrics should move to destination atomically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63646/#review190382 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 7,

Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63647/#review190589 --- What is the issue we are observing when this id is not set? -

Re: Review Request 63335: SENTRY-2018: Remove SentryMetastorePostEventListener and SentryMetastorePostEventListenerBase classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63335/ --- (Updated Nov. 9, 2017, 2:58 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

> On Nov. 1, 2017, 8:42 p.m., kalyan kumar kalvagadda wrote: > > sentry-core/sentry-core-model-solr/src/main/java/org/apache/sentry/core/model/solr/Admin.java > > Lines 26 (patched) > > > > > > Here name Admin

Re: Review Request 63619: SENTRY-2033: Fix TestDbPrivilegeCleanupOnDrop to use SentryMetastorePostEventListenerNotificationLog

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63619/ --- (Updated Nov. 7, 2017, 6:17 p.m.) Review request for sentry, Alexander

Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/ --- (Updated Dec. 5, 2017, 9:09 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/#review191548 ---

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

> On Dec. 1, 2017, 3:58 p.m., Colm O hEigeartaigh wrote: > > Is there a way to exclude the Apache licensed jars from the LICENSE.txt? > > Is it possible to remove the Stax-API bit for GPL? There are two sections, > > one GPL and one CDDL. > > You could also change the root LICENSE.txt in our

Re: Review Request 64392: SENTRY-2092: Drop Role log message shows Creating role

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64392/#review193061 --- Ship it! Ship It! - kalyan kumar kalvagadda On Dec. 6,

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64241/ --- (Updated Dec. 1, 2017, 6:16 p.m.) Review request for sentry, Alexander

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64241/ --- (Updated Dec. 1, 2017, 5:27 p.m.) Review request for sentry, Alexander

Review Request 64273: SENTRY-2084: Exclude javax.jms:jms from sentry distribution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64273/ --- Review request for sentry, Alexander Kolbasov and Sergio Pena. Bugs:

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64241/ --- (Updated Dec. 1, 2017, 11:12 p.m.) Review request for sentry, Alexander

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

> On Dec. 1, 2017, 10:28 p.m., Alexander Kolbasov wrote: > > LICENSE.txt > > Line 214 (original) > > > > > > Should theLICENSE.txt include copyrights as well or not? Looks like you > > are removing some copyrights.

Review Request 63308: SENTRY-2020: Fix testConsumeCycleWithInsufficientPrivileges test failure in kafka e2e tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63308/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2020

Review Request 63309: SENTRY-2017: Fix Sentry e2e tests to use SentryMetastorePostEventListenerNotificationLog

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63309/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2017

Re: Review Request 63433: SENTRY-2026: Bump Hadoop version from 2.7.2 to 2.7.4

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63433/#review189759 --- Ship it! Ship It! - kalyan kumar kalvagadda On Oct. 30,

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/#review202475 ---

Re: Review Request 67006: SENTRY-2173: Extend PrivilegeInfo to hold user privileges

> On May 8, 2018, 7:52 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Line 27 (original), 29 (patched) > > > > > > I think we

Re: Review Request 67006: SENTRY-2173: Extend PrivilegeInfo to hold user privileges

> On May 8, 2018, 8:57 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Line 31 (original), 33 (patched) > > > > > > Can you add comment

Re: Review Request 67006: SENTRY-2173: Extend PrivilegeInfo to hold user privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67006/ --- (Updated May 9, 2018, 7:13 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 66792: SENTRY-1949: Old full snapshots are never cleaned up

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66792/#review202073 ---

Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/#review202069 --- Lina, This index might not be needed for every database. we need

Re: Review Request 67046: SENTRY-2226: Support Hive operation ALTER TABLE EXCHANGE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67046/#review202873 --- Ship it! Fix it and push it. - kalyan kumar kalvagadda On

Re: Review Request 67046: SENTRY-2226: Support Hive operation ALTER TABLE EXCHANGE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67046/#review202872 ---

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202875 ---

Review Request 67087: SENTRY-2171: Permission full snapshot should include owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67087/ --- Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. Bugs:

Re: Review Request 67087: SENTRY-2171: Permission full snapshot should include owner privileges

> On May 11, 2018, 4:29 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 2529 (original), 2529 (patched) > > > > > >

Review Request 67091: SENTRY-2218: Sentry-plug-in should have API's to handle grant/revoke privileges to users.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67091/ --- Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. Bugs:

Review Request 67002: SENTRY-2216: Extend the thrift definition for policy service to handle user privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67002/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2216

Review Request 67006: SENTRY-2173: Extend PrivilegeInfo to hold user privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67006/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2173

Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

> On May 4, 2018, 8:21 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/resources/011-SENTRY-2154.derby.sql > > Lines 24-44 (patched) > > > > > > Lina, Is the the user privileges

Re: Review Request 67072: SENTRY-2228: Improve on how to handle unsupported Hive commands

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67072/#review203118 ---

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203327 --- In general note can't you seperate patches for below? 1.Add

Review Request 67180: SENTRY-2235: Add hive tests to verify column privileges for views

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67180/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2235

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203329 ---

Review Request 67131: SENTRY-2174: Sentry authorization provider should now generate ACL for users

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67131/ --- Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. Bugs:

Re: Review Request 67131: SENTRY-2174: Sentry authorization provider should now generate ACL for users

> On May 16, 2018, 3:52 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Lines 278 (patched) > > > > > > Is it abnormal for this to

Re: Review Request 67131: SENTRY-2174: Sentry authorization provider should now generate ACL for users

> On May 16, 2018, 3:52 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Lines 245 (patched) > > > > > > should you check the type if

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On May 18, 2018, 1:30 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > > Line 192 (original), 201-213 (patched) > >

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203598 ---

Review Request 67325: SENTRY-2246: Construct owner privilege (TSentryPrivilege)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67325/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2246

Review Request 67293: SENTRY-2243: Extend the thrift definition for policy service to learn owner information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67293/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY--2243

Re: Review Request 67293: SENTRY-2243: Extend the thrift definition for policy service to learn owner information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67293/ --- (Updated May 24, 2018, 11:18 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/#review203413 --- General question? Who is authorized to perform this operation? Is

Re: Review Request 67131: SENTRY-2174: Sentry authorization provider should now generate ACL for users

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67131/ --- (Updated May 15, 2018, 11:45 p.m.) Review request for sentry, Arjun Mishra, Na

Re: Review Request 65768: SENTRY-2144: Table Rename Cross Database should update permission correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65768/#review203456 --- Ship it! Looks Good. - kalyan kumar kalvagadda On May 18,

Review Request 67506: SENTRY-2260: Update HDFS ACL's based on owner privileges.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67506/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2260

Re: Review Request 66336: SENTRY-2190: Have verbose debug logs in CounterWait class

> On March 29, 2018, 8:41 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java > > Lines 191 (patched) > > > > > > can you put the

Re: Review Request 67477: SENTRY-2252: Normalize the Sentry store API's to handle both user/role privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67477/ --- (Updated June 8, 2018, 8:12 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67452: SENTRY-2257: Implement Sentry store API to update owner privilege on a authorizable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67452/ --- (Updated June 7, 2018, 4:54 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67452: SENTRY-2257: Implement Sentry store API to update owner privilege on a authorizable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67452/ --- (Updated June 7, 2018, 8:51 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67481: SENTRY-2259: SQL CONSTRAINT name for user privilege is too long for Oracle 11.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67481/#review204466 --- Ship it! Ship It! - kalyan kumar kalvagadda On June 7,

  1   2   3   4   5   >