Github user uddhavarote commented on the issue:
https://github.com/apache/storm/pull/2790
Hey, thanks for this update. Without this update, one would end up
(re)writing a bolt like KafkaBolt with similar functionality but different
`OnCompletion` function, like I am doing currently
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208967428
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2915,22 @@ public void launchServer() throws Exception {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208967564
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208970103
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2807,16 +2897,15 @@ public void launchServer() throws Exception {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208970052
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208975129
--- Diff: storm-client/src/jvm/org/apache/storm/scheduler/WorkerSlot.java
---
@@ -39,6 +42,11 @@ public String getId() {
return getNodeId() + ":"
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208976776
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208966535
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2915,22 @@ public void launchServer() throws Exception {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208968113
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208968787
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2807,16 +2897,15 @@ public void launchServer() throws Exception {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208971197
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2915,22 @@ public void launchServer() throws Exception {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208965327
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2915,22 @@ public void launchServer() throws Exception {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208968475
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu() {
Cluster
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208982864
--- Diff: storm-client/src/jvm/org/apache/storm/scheduler/WorkerSlot.java
---
@@ -39,6 +42,11 @@ public String getId() {
return getNodeId()
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2790
@uddhavarote I wasn't sure if anyone needed the ability to emit new tuples
after writing to Kafka, because you can still do further processing by adding
another topology (or a new spout to your current
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208970512
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2915,22 @@ public void launchServer() throws Exception {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208972356
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209094640
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209097770
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -71,6 +78,10 @@
public
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209004673
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209016305
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4723,4 +4754,192 @@ public IScheduler getForcedScheduler() {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209005776
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209023115
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209022892
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208987578
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208965124
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208987159
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208984273
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2871,16 +2897,15 @@ public void launchServer() throws Exception {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208988762
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208991078
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208965019
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2918,6 +2943,10 @@ public void launchServer() throws Exception {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209007420
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4723,4 +4754,192 @@ public IScheduler getForcedScheduler() {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208986783
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208986545
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208997165
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208998511
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209095253
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209097464
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
---
@@ -61,18 +63,21 @@
import
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209097286
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -251,10 +257,18 @@
private static final Meter
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209096098
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -235,7 +258,7 @@ FileFilter
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209097038
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandlerTest.java
---
@@ -627,6 +627,7 @@ public void
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209099125
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209100932
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209096605
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogFileDownloader.java
---
@@ -18,12 +18,20 @@
package
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209098259
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -62,6 +64,14 @@
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209098407
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209028432
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2871,16 +2897,15 @@ public void launchServer() throws Exception {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209030437
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209031413
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2890,22 @@ public void launchServer() throws Exception {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209037023
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2057,13 @@ private int fragmentedCpu() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209041653
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4723,4 +4754,192 @@ public IScheduler getForcedScheduler() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209044589
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu() {
Cluster
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209029163
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209034728
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209036572
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -223,8 +246,8 @@ void cleanupEmptyTopoDirectory(File
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209045056
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu() {
Cluster
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209029068
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209029787
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4723,4 +4754,192 @@ public IScheduler getForcedScheduler() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209037387
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/DirectoryCleaner.java
---
@@ -186,7 +192,22 @@ private boolean
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209039163
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2890,22 @@ public void launchServer() throws Exception {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209039674
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2918,6 +2943,10 @@ public void launchServer() throws Exception {
GitHub user govind-menon opened a pull request:
https://github.com/apache/storm/pull/2799
STORM-3183: Fix for visualization on Storm API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/govind-menon/storm STORM-3183
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209042043
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2918,6 +2943,10 @@ public void launchServer() throws Exception {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209048016
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209095662
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -253,12 +276,11 @@ private long
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209098067
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/ExceptionMeters.java
---
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2754
Some important changes have been made to address nits you guys have,
especially on metrics for scheduler. @srdo @Ethanlm
---
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209066631
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -267,8 +267,8 @@
private static final Histogram
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209067011
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2891,33 +2884,26 @@ public void launchServer() throws Exception {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209070836
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2891,33 +2884,26 @@ public void launchServer() throws Exception {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209059400
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209064682
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu() {
Cluster
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209068547
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2891,33 +2884,26 @@ public void launchServer() throws Exception {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209048376
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
---
@@ -193,24 +198,23 @@ public Response
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209078867
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -71,6 +78,10 @@
public class
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209078282
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -251,10 +257,18 @@
private static final Meter
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209078742
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
---
@@ -61,18 +63,21 @@
import
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209072290
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209047681
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209079798
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -62,6 +64,14 @@
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209077210
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209065332
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -71,6 +78,11 @@
public class
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209074521
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -253,12 +276,11 @@ private long
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209079357
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/ExceptionMeters.java
---
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209077587
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandlerTest.java
---
@@ -627,6 +627,7 @@ public void
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209071814
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209075463
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -235,7 +258,7 @@ FileFilter mkFileFilterForLogCleanup(long
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209076140
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogFileDownloader.java
---
@@ -18,12 +18,20 @@
package
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209075962
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -223,8 +246,8 @@ void cleanupEmptyTopoDirectory(File dir)
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209069385
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209046204
--- Diff:
storm-server/src/test/java/org/apache/storm/metric/StormMetricsRegistryTest.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209081264
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu() {
Cluster
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209082396
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209083160
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209083886
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209084882
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler() {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209087810
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209088518
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209092338
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209092525
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
100 matches
Mail list logo
