Memory leak in AcitveMQ RA when using failover transport w/ JMS XA Sessions

2019-09-12 Thread Jonathan S. Fisher
We've been running TomEE with the JMS patches in prod for a few weeks. It's nice to have working global transactions! Unfortunately after sending a couple thousand messages, the servers would OOME. Turns out this is a known issue: https://issues.apache.org/jira/browse/AMQ-6391 We use the failover

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
Hi To assist with the review - here are the library changes from 8.0.0-M3: https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/DIFF.txt To save you clicking, here's the content: apache-tomee 8.0.0 webprofile ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko] ADD geronimo

Re: Installation and service documentation

2019-09-12 Thread Cesar Hernandez
+1 thanks Jonathan for the PR and updated information. El mié., 11 sept. 2019 a las 8:30, Jonathan Gallimore (< jonathan.gallim...@gmail.com>) escribió: > Hi All > > I recently updated our Windows .exe files with commons-daemon 1.2.1 > binaries, which address a regression here: > https://issues.a

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Cesar Hernandez
Thanks for the update, Jonathan. +1 El jue., 12 sept. 2019 a las 8:09, Jonathan Gallimore (< jonathan.gallim...@gmail.com>) escribió: > Hi > > To assist with the review - here are the library changes from 8.0.0-M3: > > > https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/DIFF.t

Re: Hi HackDay Comunidad Hispana JUGs

2019-09-12 Thread Cesar Hernandez
@Carlos I assigned the Jiras to you and reviewed the ones containing open's PR's, thanks much! btw, for https://issues.apache.org/jira/browse/TOMEE-2669, since the PR was merged 5 day's ago, I updated the JIRA fix version to 8.0.0-final, for the other ones what would be the version? 8.0.1? For http

Re: Hi HackDay Comunidad Hispana JUGs

2019-09-12 Thread Carlos Chacín
Thanks Cesar, > other ones what would be the version? 8.0.1? I'll let that to your criteria > For https://issues.apache.org/jira/browse/TOMEE-2681 and https://issues.apache.org/jira/browse/TOMEE-2682, do you have an open PR's? Not open PRs for those 2 but I'm planning to send those this week t

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
I've spent some time reviewing: * Build looks ok * Libraries added and licenses look ok * Upgraded a production application to this RC running on Java 11 - looks good * Getting a RAT report has proved to be a pain. Running RAT standalone produces this report: https://gist.github.com/jgallimore/be3

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Emerson Castañeda
I am getting this error during the build [ERROR] Failed to execute goal on project openejb-core: Could not resolve dependencies for project org.apache.tomee:openejb-core:jar:8.0.0: The following artifacts could not be resolved: org.apache.tomee:openejb-itests-app:jar:8.0.0, org.apache.openejb.ite

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
Hi Emerson! Thanks for taking the time to review this! I assume you're building from the source zip? I'll test it on a clean box. You won't see the 8.0.0 artifacts on Maven central until the release passes, but there are available in the staging repository - https://repository.apache.org/content/r

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread David Blevins
> On Sep 12, 2019, at 7:09 AM, Jonathan Gallimore > wrote: > > ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko] > ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko] > ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko] Befor the reroll, do a quick check to see if any of the above are alread

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
Will do! Thanks for pointer. Jon On Thu, Sep 12, 2019 at 7:39 PM David Blevins wrote: > > > On Sep 12, 2019, at 7:09 AM, Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > > > > ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko] > > ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
Hi Emerson, Can you try your build again, but without the -Pquick parameter? Thanks Jon On Thu, Sep 12, 2019 at 7:30 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Hi Emerson! > > Thanks for taking the time to review this! I assume you're building from > the source zip? I'll te

[GitHub] [tomee] emecas commented on a change in pull request #568: [TOMEE-2679] Translate MicroProfile Metrics Gauge Example to Spanish

2019-09-12 Thread GitBox
emecas commented on a change in pull request #568: [TOMEE-2679] Translate MicroProfile Metrics Gauge Example to Spanish URL: https://github.com/apache/tomee/pull/568#discussion_r323908078 ## File path: examples/mp-metrics-gauge/README_es.adoc ## @@ -0,0 +1,160 @@ += Métric

[GitHub] [tomee] asf-ci commented on issue #571: Fix release issues

2019-09-12 Thread GitBox
asf-ci commented on issue #571: Fix release issues URL: https://github.com/apache/tomee/pull/571#issuecomment-530968311 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [tomee] jgallimore opened a new pull request #571: Fix release issues

2019-09-12 Thread GitBox
jgallimore opened a new pull request #571: Fix release issues URL: https://github.com/apache/tomee/pull/571 * Add license headers to java and xml files This is an automated message from the Apache Git Service. To respond to th

[GitHub] [tomee] asf-ci commented on issue #571: Fix release issues

2019-09-12 Thread GitBox
asf-ci commented on issue #571: Fix release issues URL: https://github.com/apache/tomee/pull/571#issuecomment-530968315 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [tomee] asf-ci commented on issue #571: Fix release issues

2019-09-12 Thread GitBox
asf-ci commented on issue #571: Fix release issues URL: https://github.com/apache/tomee/pull/571#issuecomment-530968317 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
Hi David! Thanks for pointing this out. I've got the list of duplicate - I'd appreciate yours (and anyone else's) view on the conflicts below: Full set of duplicate classes is here: https://gist.github.com/jgallimore/9f653f4fa3aec515051f6cd76af7c48f Essentially we have the following conflicts:

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
Also, I'll take a look at openejb-client, but I'm not too sure what do with this conflict: javax/xml/ws/EndpointReference.class, javax/xml/ws/WebServiceFeature.class and javax/xml/ws/wsaddressing/W3CEndpointReference.class: - javaee-api-8.0-2.jar - openejb-client-8.0.0.jar Any thoughts? Jon On

[GitHub] [tomee] jgallimore merged pull request #571: Fix release issues

2019-09-12 Thread GitBox
jgallimore merged pull request #571: Fix release issues URL: https://github.com/apache/tomee/pull/571 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
Hi Emerson, My build on a clean VM worked here. For reference, I ran: mvn -Dsurefire.useFile=false -DdisableXmlReport=true -DuniqueVersion=false -ff -Dassemble -DskipTests -DfailIfNoTests=false clean install | tee build.log (note, no -Pquick) Cheers! Jon On Thu, Sep 12, 2019 at 7:30 PM Jonath

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread David Blevins
> On Sep 12, 2019, at 1:03 PM, Jonathan Gallimore > wrote: > > Also, I'll take a look at openejb-client, but I'm not too sure what do with > this conflict: > > javax/xml/ws/EndpointReference.class, javax/xml/ws/WebServiceFeature.class > and javax/xml/ws/wsaddressing/W3CEndpointReference.class:

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Emerson Castañeda
Hi Jon Thank you for your reply I am building directly from the repo on the tag (tomee-8.0.0) I have re-run the build removing -Pquick Now the process is going further, right now, (49/322) and going, it usually takes about 25 minutes, I'm not sure why it is too long. Thanks Emerson On Thu,

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
-Pquick skips quite a lot of stuff, including examples. In your case, it was also skipping the itests module, and Maven isn't able to get those from Maven central (yet). The command I ran here, with a clean ~/.m2/repository took 58 minutes. Jon On Thu, Sep 12, 2019 at 9:24 PM Emerson Castañeda w

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
Here's the same analysis on TomEE 7.0.6: javax.activation: - lib/activation-1.1.jar - lib/javaee-api-7.0-1.jar javax.xml.stream: - lib/stax-api-1.0-2.jar - lib/javaee-api-7.0-1.jar javax/xml/ws/EndpointReference.class, javax/xml/ws/WebServiceFeature.class and javax/xml/ws/wsaddressing/W3CEndpoin

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread David Blevins
Had a longer response but the planet started boarding and now I have to start again on cell :) Agree with all your removals. Note on Jakarta activation 1.2, we’ll want to eventually switch to Geronimo Activation 1.2 when we get that ready. We need to update the LICENSE and NOTICE files of each d

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread David Blevins
Plane, but planet works too — although a slight exaggeration :) On Thu, Sep 12, 2019 at 1:53 PM David Blevins wrote: > Had a longer response but the planet started boarding and now I have to > start again on cell :) > > Agree with all your removals. Note on Jakarta activation 1.2, we’ll want >

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
Awesome, thanks for the detail. I'm working on the PR now. I post updates here as I have them. Intention is to have take 2 rolled by the end of the evening. Have a safe flight! Jon On Thu, Sep 12, 2019 at 9:55 PM David Blevins wrote: > Plane, but planet works too — although a slight exaggerati

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
If anyone knows how to exclude jakarta.activation-api in the new bom module, I'd sure appreciate the help. I'd expect jakarta.activation jakarta.activation-api to work, but it seems like no matter where I exclude it, it keeps popping up. Jon On Thu

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread David Blevins
If you find it too difficult a plan b could be to hack the Setup (or whatever it’s called) java code that turns the war files into the assembly. I.e. add a line to delete it. On Thu, Sep 12, 2019 at 3:46 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > If anyone knows how to exclud

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
That's a good suggestion, thank you. Must admit, I'm surprised. I thought the whole bom thing was meant to make this easier. I must be missing something. Jon On Fri, Sep 13, 2019 at 12:00 AM David Blevins wrote: > If you find it too difficult a plan b could be to hack the Setup (or > whatever i

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread David Jencks
I haven’t tried anything like this in years, but I think there’s a maven dependency plugin command that produces a graph; grepping this for the problem child may show all the paths to it. Hope this might help... David Jencks Sent from my iPhone > On Sep 12, 2019, at 4:07 PM, Jonathan Gallimor

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread David Blevins
Somewhere in here: - https://github.com/apache/tomee/blob/master/tomee/apache-tomee/src/main/groovy/commands/SetupCommand.groovy#L58 Hello from SFO baggage claim in route to CodeOne! :) On Thu, Sep 12, 2019 at 4:00 PM David Blevins wrote: > If you find it too difficult a plan b could be to hac

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
Tried that, right next to where swizzle-stream is removed - get this - it didn't work. Also tried the installer - same. I fear my sanity is leaving me... Jon On Fri, Sep 13, 2019 at 12:19 AM David Blevins wrote: > Somewhere in here: > > - > > https://github.com/apache/tomee/blob/master/tomee/ap

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
I appreciate it. Been hacking away with mvn dependency:tree for what feels like ages now. Adding the on that bom pom.xml seems to make no difference. Adding the exclusion to everywhere the bom was referenced in the whole project, and it still shows up in the tree. :-O Jon On Fri, Sep 13, 2019 at

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
Ok, got further. Hopefully now just update the license file, and then roll the release. Jon On Fri, Sep 13, 2019 at 12:23 AM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Tried that, right next to where swizzle-stream is removed - get this - it > didn't work. Also tried the install

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread David Blevins
Do tell the mystical secret that lead to the exclusions aligning for our binaries most divine. On Thu, Sep 12, 2019 at 4:31 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Ok, got further. Hopefully now just update the license file, and then roll > the release. > > Jon > > On Fri,

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
I added a: deleteWithRetry(file: paths.findTomEELibJar('jakarta.activation-api')) to the SetupCommand.groovy. Turns out that works better than: deleteWithRetry(file: paths.findOpenEJBWebJar('jakarta.activation-api')) I'm quite tired :) Jon On Fri, Sep 13, 2019 at 12:47 AM Dav

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
I've added ECL 1, referencing ECJ, and EPL 2, referencing Jakarta Activation, Jakarta XML Bind API, Jakarta XML SOAP API. Does that sound right? Jon On Thu, Sep 12, 2019 at 9:54 PM David Blevins wrote: > Had a longer response but the planet started boarding and now I have to > start again on ce

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread David Blevins
We excluded the soap jar, right? On Thu, Sep 12, 2019 at 4:52 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > I've added ECL 1, referencing ECJ, and EPL 2, referencing Jakarta > Activation, Jakarta XML Bind API, Jakarta XML SOAP API. Does that sound > right? > > Jon > > On Thu, Sep

[CANCELLED][VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
Hi All, I'm cancelling this vote and re-rolling. I'll call another vote once I have new binaries staged for review. Thanks Jon On Wed, Sep 11, 2019 at 11:54 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Hi All, > > Here's a first attempt at roll of a TomEE 8.0.0. Please can yo

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
Yes. Here's the full set from the plus binary: FastInfoset-1.2.16.jar activemq-broker-5.15.10.jar activemq-client-5.15.10.jar activemq-jdbc-store-5.15.10.jar activemq-kahadb-store-5.15.10.jar activemq-openwire-legacy-5.15.10.jar activemq-protobuf-1.1.jar activemq-ra-5.15.10.jar batchee-jbatch-0.5

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
Just noticed the openejb-standalone server doesn't boot. Should we even include this? Jon On Fri, Sep 13, 2019 at 1:04 AM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Yes. Here's the full set from the plus binary: > > > FastInfoset-1.2.16.jar > activemq-broker-5.15.10.jar > active

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread David Blevins
I’m fine if we don’t. Ok for it to go to maven central, but that and the webapp dists should probably be omitted from the downloads dir and page. We definitely discussed and agreed to yank the webapps. It will take work to get them out of the build, till then we should just stop promoting them.

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

2019-09-12 Thread Jonathan Gallimore
Agreed. Thanks for that. Rolling now! On Fri, Sep 13, 2019 at 1:14 AM David Blevins wrote: > I’m fine if we don’t. Ok for it to go to maven central, but that and the > webapp dists should probably be omitted from the downloads dir and page. > > We definitely discussed and agreed to yank the weba

[VOTE] Release Apache TomEE 8.0.0 (take 2)

2019-09-12 Thread Jonathan Gallimore
Hi All, Here's a second attempt at roll of a TomEE 8.0.0. Please can you take a careful look, review, test and provide feedback. Maven Repo: https://repository.apache.org/content/repositories/orgapachetomee-1146 Binaries &

Re: [VOTE] Release Apache TomEE 8.0.0 (take 2)

2019-09-12 Thread Daniel Dias Dos Santos
+1 -- *Daniel Dias dos Santos* Java Developer SouJava & JCP Member GitHub: https://github.com/Daniel-Dos Linkedin: www.linkedin.com/in/danieldiasjava Twitter: http://twitter.com/danieldiasjava Em qui, 12 de set de 2019 às 22:09, Jonathan Gallimore < jonathan.gallim...@gmail.com> escreveu: > Hi