Re: Call for comment: #5390 Many To Many signals

2010-01-08 Thread 夏恺
Hi, First thing first, I shall explain why this have something to do with admin. Django's admin save m2m relationship in ModelAdmin's change_view method. After some tracing, you would find that the m2m relationship is saved using ModelForm's save_m2m method, which calls a method named

Re: Is a partial translation acceptable?

2010-01-08 Thread Russell Keith-Magee
On Sat, Jan 9, 2010 at 8:23 AM, Jeff Balogh wrote: > How do you guys feel about getting an incomplete translation for some > locales?  We might want to support some locales that Django doesn't > have yet, but I'm trying not to overload our localizers with all the > strings in

Re: Call for comment: #5390 Many To Many signals

2010-01-08 Thread Russell Keith-Magee
On Sat, Jan 9, 2010 at 9:47 AM, Xia Kai(夏恺) wrote: > Hi all, > > IMHO this patch would still make django issue illogical signals in admin. > frans and I have pointed out that the __set__ method in the > ManyRelatedObjectsDescriptor is flawed[1-2], which is used by admin. It

Re: Call for comment: #5390 Many To Many signals

2010-01-08 Thread 夏恺
Hi all, IMHO this patch would still make django issue illogical signals in admin. frans and I have pointed out that the __set__ method in the ManyRelatedObjectsDescriptor is flawed[1-2], which is used by admin. The __set__ method would save a many-to-many relationship by clearing all

Is a partial translation acceptable?

2010-01-08 Thread Jeff Balogh
How do you guys feel about getting an incomplete translation for some locales? We might want to support some locales that Django doesn't have yet, but I'm trying not to overload our localizers with all the strings in Django (they're already sick of us). I thought that something like

Re: Porting Django to Python 3

2010-01-08 Thread Russell Keith-Magee
On Sat, Jan 9, 2010 at 2:25 AM, Dave wrote: > Hello everyone, > > My name is Dave Weber, and I'm a student at the University of Toronto, > studying Computer Science. For one of our undergraduate courses led by > Greg Wilson (http://www.cs.utoronto.ca/~gvwilson/), myself and a

Re: Porting Django to Python 3

2010-01-08 Thread VernonCole
Dave: Wonderful! I am presently working on a project to get adodbapi (http://sourceforge.net/projects/adodbapi) working in django. That may be important to you since it is one of few db interfaces which has a working python 3 version for Windows. Keep in touch. -- Vernon Cole On Jan 8, 11:25 

Re: Requesting help - validation on inlineformset_factory instance with invalid data in email field hanging application.

2010-01-08 Thread Rebekah
Thanks Karen and Robert, you both rock! I put in the patch and it's fixed :) On Jan 8, 1:53 pm, Karen Tracey wrote: > On Fri, Jan 8, 2010 at 1:42 PM, Rebekah wrote: > > I've searched but don't seem to see anyone else experiencing this > > issue.  I think

Re: Porting Django to Python 3

2010-01-08 Thread Jerome Leclanche
Best of luck in your port. On that note, I'm hoping when the 3k port will be officially supported, it will not be backwards compatible. The core idea of 3k itself is the lack of backwards compatibility ... J. Leclanche / Adys On Fri, Jan 8, 2010 at 8:25 PM, Dave wrote: >

Re: Requesting help - validation on inlineformset_factory instance with invalid data in email field hanging application.

2010-01-08 Thread Karen Tracey
On Fri, Jan 8, 2010 at 1:42 PM, Rebekah wrote: > I've searched but don't seem to see anyone else experiencing this > issue. I think it must be a django bug, I just want to know is this a > known issue, and if so, if there is a patch already in the works. > > I have a view

Re: Requesting help - validation on inlineformset_factory instance with invalid data in email field hanging application.

2010-01-08 Thread Robert Eanes
Sounds like you are getting caught by this issue: http://www.djangoproject.com/weblog/2009/oct/09/security/ You should make sure you are using django 1.1.1 or 1.0.4, which have fixes for it. On Jan 8, 2010, at 1:42 PM, Rebekah wrote: > Hi, > > I've searched but don't seem to see anyone else

Requesting help - validation on inlineformset_factory instance with invalid data in email field hanging application.

2010-01-08 Thread Rebekah
Hi, I've searched but don't seem to see anyone else experiencing this issue. I think it must be a django bug, I just want to know is this a known issue, and if so, if there is a patch already in the works. I have a view which displays a form and inline formset for user and profile model data.

Porting Django to Python 3

2010-01-08 Thread Dave
Hello everyone, My name is Dave Weber, and I'm a student at the University of Toronto, studying Computer Science. For one of our undergraduate courses led by Greg Wilson (http://www.cs.utoronto.ca/~gvwilson/), myself and a group of 10 other computer science students will be trying to port Django

Re: Final call for feedback: Multi-db

2010-01-08 Thread Brett Hoerner
On Jan 7, 7:33 pm, Russell Keith-Magee wrote: > then my understanding of your proposal is that the only change is that > read-slave won't get created under the test setup. But doesn't that > mean that:: > >     MyModel.objects.using('read-slave').filter(...) > > will fall

Re: DB optimization docs

2010-01-08 Thread Christopher Petrilli
Luke, I wonder if it's the right place, but one thing I have noticed most people don't realize is that they need to run something to do pooling between Django and the DB. I run pgpool, even when there is only one of each since it does the connection pooling for you. This can be a HUGE win in many

Re: DB optimization docs

2010-01-08 Thread Luke Plant
On Friday 08 January 2010 14:12:56 Mat Clayton wrote: > As someone going through this pain right now, this would be very > helpful. > > Mat I don't know when I'll have more time to work on this, but I've committed the beginnings of draft of docs/topics/db/optimization.txt to my hg repos.

Re: Using Django with Jinja2 and TEMPLATE_DEBUG=True

2010-01-08 Thread Rick van Hattem
On Thursday 07 January 2010 01:35:50 Russell Keith-Magee wrote: > From a cursory inspection, I'm not sure there is much we can do with > (1) - there isn't a lot of detail on Exception that can be used for a > capability check, and the only attribute that is actually needed is > 'source' (albeit in

Re: Model validation incompatibility with existing Django idioms

2010-01-08 Thread Tobias McNulty
On Fri, Jan 8, 2010 at 4:03 AM, James Bennett wrote: > On Thu, Jan 7, 2010 at 10:40 AM, Honza Král wrote: > > ModelForm has a save() method that saves the model. It is reasonable > > to assume that if the form is valid, the save() method call should

Re: Model validation incompatibility with existing Django idioms

2010-01-08 Thread Tobias McNulty
On Fri, Jan 8, 2010 at 8:36 AM, Honza Král wrote: > I just hate the name save(commit=False) when it has nothing to do with > saving or committing, it just DOESN'T call save, it's imho misleading. > I understand why that is and how it came to be, I just don't like it. > I

Re: DB optimization docs

2010-01-08 Thread Russell Keith-Magee
On Fri, Jan 8, 2010 at 10:04 PM, Luke Plant wrote: > Hi all, > > I was prompted by this post: > > http://it.toolbox.com/blogs/database-soup/stuff-id-love-to-see-from- > django-36278 > > to add some notes about some DB access optimizations (essentially the > things I

Re: Call for comment: #5390 Many To Many signals

2010-01-08 Thread Russell Keith-Magee
On Fri, Jan 8, 2010 at 9:46 PM, Luke Plant wrote: > On Friday 08 January 2010 12:04:27 Russell Keith-Magee wrote: > >> Any feedback on this design? > > Just a few things: > > 1) In assessing performance impact, people need to be clear that there > is just one signal handler

Re: DB optimization docs

2010-01-08 Thread Mat Clayton
As someone going through this pain right now, this would be very helpful. Mat On Fri, Jan 8, 2010 at 2:04 PM, Luke Plant wrote: > Hi all, > > I was prompted by this post: > > http://it.toolbox.com/blogs/database-soup/stuff-id-love-to-see-from- >

DB optimization docs

2010-01-08 Thread Luke Plant
Hi all, I was prompted by this post: http://it.toolbox.com/blogs/database-soup/stuff-id-love-to-see-from- django-36278 to add some notes about some DB access optimizations (essentially the things I mentioned in my comment on that page), but then thought that even if I add them, people are

Re: Call for comment: #5390 Many To Many signals

2010-01-08 Thread Luke Plant
On Friday 08 January 2010 12:04:27 Russell Keith-Magee wrote: > Any feedback on this design? Just a few things: 1) In assessing performance impact, people need to be clear that there is just one signal handler for the whole project, like for the post_save signal etc. Adding a handler will

Re: Model validation incompatibility with existing Django idioms

2010-01-08 Thread Honza Král
On Fri, Jan 8, 2010 at 11:59 AM, koenb wrote: > > > On 8 jan, 10:03, James Bennett wrote: > >> Suppose I have a ModelForm and call save(commit=False) to get the >> instance so I can do some more work on it. I'm basically saying to >> Django "I

help needed: non-relational DB support

2010-01-08 Thread Waldemar Kornewald
Hi, our non-relational port has come to the point where we need to back-port the SQL layer to the query backend API (i.e., the new query_class()). We could need some help from Django developers who know the ORM internals really well. You can find a little introduction to the code here:

Call for comment: #5390 Many To Many signals

2010-01-08 Thread Russell Keith-Magee
Hi all, I've just uploaded a patch for #5390, which adds signals to many-to-many modifying operations. This is a ticket that was a low-priority accepted item for 1.1 (ORM-18), but got bumped due to time [1]. For some reason, it wasn't resubmitted for 1.2. The purpose of this post is twofold:

Re: Model validation incompatibility with existing Django idioms

2010-01-08 Thread koenb
On 8 jan, 10:03, James Bennett wrote: > Suppose I have a ModelForm and call save(commit=False) to get the > instance so I can do some more work on it. I'm basically saying to > Django "I don't think this object is ready to be saved yet, but I need > the object so I can

Re: Model validation incompatibility with existing Django idioms

2010-01-08 Thread James Bennett
On Thu, Jan 7, 2010 at 10:40 AM, Honza Král wrote: > ModelForm has a save() method that saves the model. It is reasonable > to assume that if the form is valid, the save() method call should > succeed, that's why the entire model is validated. Actually, I can see a strong

Re: custom signal fails silently, depending on import path (bug ?)

2010-01-08 Thread James Bennett
On Fri, Jan 8, 2010 at 1:41 AM, ssc wrote: > Has anyone ever come across this before ? Could not find anything > related in Trac, but I thought I better ask in here before I file a > bug... If you import a signal, using one particular path to specify the import, you