From: Jiewen Yao
We want to provide precise info in MemAttribTable
to both OS and SMM, and SMM only gets the info at EndOfDxe.
So we do not update RtCode entry in EndOfDxe.
The impact is that if 3rd part OPROM is runtime, it cannot be executed
at UEFI runtime phase.
Currently, we do not see
From: Jiewen Yao
So that the SMM can consume it to set page protection for
the UEFI runtime page with EFI_MEMORY_RO attribute.
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c | 36
From: Jiewen Yao
It treats the UEFI runtime page with EFI_MEMORY_RO attribute as
invalid SMM communication buffer.
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +
From: Jiewen Yao
It treats the UEFI runtime page with EFI_MEMORY_RO attribute as
invalid SMM communication buffer.
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
MdePkg/Library/SmmMemLib/SmmMemLib.c | 58 +++-
From: Jiewen Yao
It treats GCD untested memory as invalid SMM
communication buffer.
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
MdePkg/Library/SmmMemLib/SmmMemLib.c | 96 +++-
MdePkg/Library/SmmMemLib/SmmMemLib.inf |
From: Jiewen Yao
This patch series adds check for untested memory in GCD
and check EFI_RUNTIME_RO in UEFI mem attrib table.
The final result is:
1) untested memory is not present in SMM page table.
2) the PE code section of runtime service is not present
in SMM page table.
Jiewen Yao (6):
From: Jiewen Yao
It treats GCD untested memory as invalid SMM
communication buffer.
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 144
1 file changed, 120
Andrew,
Great, thank you.
That helps a lot.
Best
Sven
From: on behalf of Andrew Fish
Date: Wednesday, 18. July 2018 at 10:52 PM
To: Sven Auhagen
Cc: "edk2-devel@lists.01.org"
Subject: Re: [edk2] Boot Logo Questions
On Jul 17, 2018, at 11:01 PM, Sven Auhagen
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong
Zhu
Sent: Tuesday, July 17, 2018 10:29 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming
Subject: [edk2] [Patch V3] BaseTools: enable
Thanks Andrew and Marvin,
> You cannot explicitly influence the order of the calls, but implicitly via the
> dependency tree, which means you need to make SerialPortLib depend on your
> LibraryClass instance.
Looks this is difficult that I can force order on already available code.
> Worst
Thank you all for the great effort.
I have pushed this StandaloneMmPkg series with Achin's reviewed-by.
GIT HASH: 2cde4bbadc09a6822e1e653fc4ef46a7106bfe79..
da417eb8ed4bbaf149c31d197eb56fc8a5abbf68
Thank you
Yao Jiewen
> -Original Message-
> From: Sughosh Ganu
Hi Lazlo,
Thank you very much for the effort. We do have an emergency situation.
(1) Agree. Filed a bug (https://bugzilla.tianocore.org/show_bug.cgi?id=1039)
for it.
(2) I went through the code you mentioned. I think it won't cause problem
but it might miss protecting certain images
OK, thanks!
Thanks,
Fan
-Original Message-
From: Dong, Eric
Sent: Friday, July 20, 2018 9:39 AM
To: Chen, Farrah ; edk2-devel@lists.01.org
Cc: Wei, Danmei
Subject: RE: OVMF build fail
Hi Fan,
Below change fixed this issue, please sync to the latest code and build.
SHA-1:
Hi Fan,
Below change fixed this issue, please sync to the latest code and build.
SHA-1: 9b7242f5dec7649b878a4058f893103885520bf7
* UefiCpuPkg/MpInitLib: Fix VS2012 build failure
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi
Reviewed-by: Eric
Hi,
When I build OVMF with the latest commit:
a3fffb4f5e1535e8e542669925eed489fdce6b62
git clone https://github.com/tianocore/edk2.git
cd edk2
OvmfPkg/build.sh -a X64
Then the following error occurred:
.
Thanks Sughosh.
Reviewed-by: Achin Gupta
On Fri, Jul 13, 2018 at 08:35:29PM +0530, Sughosh Ganu wrote:
> From: Supreeth Venkatesh
>
> This patch adds a simple CPU driver that exports the
> EFI_MM_CONFIGURATION_PROTOCOL to allow registration of the Standalone
> MM Foundation entry point. It
Thanks Sughosh.
Reviewed-by: Achin Gupta
On Fri, Jul 13, 2018 at 08:35:28PM +0530, Sughosh Ganu wrote:
> From: Supreeth Venkatesh
>
> The Standalone MM environment runs in S-EL0 in AArch64 on ARM Standard
> Platforms and is initialised during the SEC phase. ARM Trusted firmware
> in EL3 is
Reviewed-by: Jordan Justen
On 2018-07-19 11:01:43, Laszlo Ersek wrote:
> XenPvBlkDxe doesn't reference gEfiDevicePathProtocolGuid; remove it from
> the INF file.
>
> Cc: Anthony Perard
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: Julien Grall
> Cc: Steven Shi
> Reported-by: Steven Shi
>
Hi Anthony,
(I'm seeing your v1 and v2 postings at the same time now:)
On 07/19/18 17:52, Anthony PERARD wrote:
> On Debian Jessie, this fail to build with:
>
> /build/UefiCpuPkg/Library/MpInitLib/Microcode.c: In function
> 'MicrocodeDetect':
>
Udit,
As Marvin points out the [LibraryClasses] section of the INF file are going to
imply the order of the library constructor calls in the AutoGen
Worst case you can demote FpgaInterfaceInit () from being a constructor to just
being a public library function that the other lib can call
Hey Udit,
You cannot explicitly influence the order of the calls, but implicitly via the
dependency tree, which means you need to make SerialPortLib depend on your
LibraryClass instance.
You did not mention which SerialPortLib instance you use, but probably you need
to execute
XenPvBlkDxe doesn't reference gEfiDevicePathProtocolGuid; remove it from
the INF file.
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Julien Grall
Cc: Steven Shi
Reported-by: Steven Shi
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1034
Contributed-under: TianoCore
This variable is only used in one function, make it local there.
Also when iterating on the variable, use dict.items() to get value
instead of re-looking up the value multiple times.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben
Hi Eric,
apologies about the delay.
On 07/18/18 14:59, Dong, Eric wrote:
> Hi Laszlo,
>
> I finally succeed to setup the OVMF platform which can verify the boot
> failure issue. But on my platform, if I use image build with below
> command (I assume it is used to enable SMM), the system can't
On Debian Jessie, this fail to build with:
/build/UefiCpuPkg/Library/MpInitLib/Microcode.c: In function 'MicrocodeDetect':
/build/UefiCpuPkg/Library/MpInitLib/Microcode.c:248:37: error: 'ProcessorFlags'
may be used uninitialized in this function [-Werror=maybe-uninitialized]
Marvin,
> Though to be honest, I am not sure why these PPIs are exposed by
> DxeIplPeim instead of a dedicated module or maybe even PeiCore itself, if
> it's the de facto standard.
When we were originally facing the issue one of the ideas was in fact to move
this to PeiCore. I don't recall why
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Zeng, Star
> Sent: Thursday, July 19, 2018 3:32 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Kinney, Michael D
>
> Subject: [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg
> FmpDxe: Return 0 when LSV check is not
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]
> On Behalf Of Star Zeng
> Sent: Thursday, July 19, 2018 3:19 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Zeng,
> Star
> Subject: [edk2]
Edk2 style doesn't initialize the local variable value in its declaration.
Could you update this patch to separately set ProcessorFlags value?
Thanks
Liming
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Anthony PERARD
> Sent: Thursday,
On Debian Jessie, this fail to build with:
/build/UefiCpuPkg/Library/MpInitLib/Microcode.c: In function 'MicrocodeDetect':
/build/UefiCpuPkg/Library/MpInitLib/Microcode.c:248:37: error: 'ProcessorFlags'
may be used uninitialized in this function [-Werror=maybe-uninitialized]
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Bi, Dandan
> Sent: Thursday, July 19, 2018 12:08 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Carsey, Jaben
> ; Ni, Ruiyu
> Subject: [patch] ShellPkg/Dp: Cumulate the perf data of "DB:Stop"
> Importance: High
>
> Currently
On 07/18/18 16:02, Ard Biesheuvel wrote:
> On 18 July 2018 at 21:52, Laszlo Ersek wrote:
>> None of the source files referenced by "AcpiPlatformDxe.inf" #include
>> "MdePkg/Include/Library/DxeServicesLib.h" or use interfaces declared
>> therein, so drop DxeServicesLib from [LibraryClasses].
>>
>>
On 07/18/18 07:19, Eric Dong wrote:
> Current function has low performance because it calls GetApicId
> many times.
>
> New logic call GetApicId once and base on this value to search
> the processor.
>
> V2 changes:
> Rollback V1 change which base on stack info to get AP index because
> this
On 07/18/18 04:35, Wang, Jian J wrote:
> Hi Laszlo,
>
>
> Regards,
> Jian
>
>
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Tuesday, July 17, 2018 10:37 PM
>> To: Wang, Jian J ; edk2-devel@lists.01.org
>> Cc: Dong, Eric ; Yao, Jiewen ;
>> Zeng, Star
Sure.
I will add the comments before commit it.
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Thursday, July 19, 2018 8:04 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Dong, Eric
Subject: Re: [edk2]
Hi Star,
On 07/19/18 12:36, Zeng, Star wrote:
> Hi Laszlo,
>
> Have you evaluated whether " #include " can be
> removed from *.h file or not since gEfiSimpleFileSystemProtocolGuid is
> removed from *.inf?
Yes, I did check for that.
I did not remove the #include directive of the
On 07/19/18 14:12, Eric Dong wrote:
> Remove the useless code error added by change
> 58942277bcbf41abda5f6e3a1c89d571105d5983.
>
> Cc: Laszlo Ersek
> Cc: Ruiyu Ni
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong
> ---
>
Cool. Thanks!
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, July 19, 2018 6:47 PM
> To: Yao, Jiewen
> Cc: edk2-devel-01 ; Zhang, Chao B
> ; Dong, Eric ; Carsey, Jaben
> ; Wu, Jiaxin ; Gao, Liming
> ; Kinney, Michael D ;
> Roman Bacik ; Ni, Ruiyu
On 07/19/18 11:07, Wang, Jian J wrote:
> Hi Laszlo,
>
> Do you have more comments? Or can you give a r-b?
Struggling with my workload, will try to come back to this soon.
Thanks
Laszlo
>> -Original Message-
>> From: Wang, Jian J
>> Sent: Wednesday, July 18, 2018 10:36 AM
>> To: Laszlo
Remove the useless code error added by change
58942277bcbf41abda5f6e3a1c89d571105d5983.
Cc: Laszlo Ersek
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 15 ---
1 file changed, 15
Hi Laszlo,
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Thursday, July 19, 2018 7:57 PM
> To: Dong, Eric ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu
> Subject: Re: [edk2] UefiCpuPkg/MpInitLib: Fix S3 resume hang issue.
Hi Dandan,
On 07/19/18 06:50, Dandan Bi wrote:
> Cc: Eric Dong
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi
> ---
> UefiCpuPkg/Library/MpInitLib/Microcode.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
Hi,
On 07/18/18 07:10, Eric Dong wrote:
> When resume from S3 and CPU loop mode is MWait mode,
> if driver calls APs to do task at EndOfPei point, the
> APs can't been wake up and bios hang at that point.
>
> The root cause is PiSmmCpuDxeSmm driver wakes up APs
> with HLT mode during S3 resume
On 07/19/18 01:10, Yao, Jiewen wrote:
> Thanks Laszlo.
>
> Would you please add one line comment on the FilePath, to describe if the
> FilePath is internal input or external input? As such the API consumer can
> know if caller’s responsibility to verify it or callee’s responsibility.
Good
On 07/19/18 02:07, Ard Biesheuvel wrote:
> On 19 July 2018 at 06:15, Carsey, Jaben wrote:
>> Reviewed-by: Jaben Carsey
>>
>> One question (do hold up push). Is there a reason to use the former over the
>> latter? I use latter and I see you use the former.
>>
>> ASSERT(EFI_ERROR (Status));
>>
Hi Laszlo,
Have you evaluated whether " #include " can be
removed from *.h file or not since gEfiSimpleFileSystemProtocolGuid is removed
from *.inf?
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, July 19, 2018 4:51 AM
To: edk2-devel-01
Current code return 1 when LSV check is not required,
but 1 LSV will make 0 Version capsule image update failed.
0 LSV is valid, this patch updates the code to return 0 when
LSV check is not required
We can see even the DEFAULT_LOWESTSUPPORTEDVERSION is 0.
Cc: Michael D Kinney
FmpDxeEntryPoint is used by both FmpDxe and FmpDxeLib.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c
Add more logic to filter invalid function parameter in MOR Control SMI handler
Cc: Long Qin
Cc: Yao Jiewen
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chao Zhang
Signed-off-by: Zhang, Chao B
---
SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 4
Hi Laszlo,
Do you have more comments? Or can you give a r-b?
Regards,
Jian
> -Original Message-
> From: Wang, Jian J
> Sent: Wednesday, July 18, 2018 10:36 AM
> To: Laszlo Ersek ; edk2-devel@lists.01.org
> Cc: Dong, Eric ; Yao, Jiewen ;
> Zeng, Star
> Subject: RE: [PATCH]
Hi Experts,
How I can change the order of initialization in Constructor list of autogen
file.
In my build system, if I look at
MdeModulePkg/Universal/PCD/Pei/Pcd/DEBUG/AutoGen.c
Below is function of Library Constructor List
VOID
EFIAPI
ProcessLibraryConstructorList (
IN
Currently DP tool will cumulate the performance data for
Driver Binding Support/Start, will count the number they
appears, and record the maximum/minimum time value...
Now add Driver Binding Stop performance data to the
cumulative data to keep consistency.
Cc: Liming Gao
Cc: Jaben Carsey
Cc:
Add an example case for the usage of
PERF_CALLBACK_BEGIN/PERF_CALLBACK_END
Cc: Liming Gao
Cc: Chao Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi
---
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4
SecurityPkg/Tcg/TcgPei/TcgPei.c | 5 +
Add an example case for the usage of
PERF_EVENT_SIGNAL_BEGIN/PERF_EVENT_SIGNAL_END
Cc: Liming Gao
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi
---
MdeModulePkg/Core/DxeIplPeim/DxeIpl.h | 3 ++-
MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
54 matches
Mail list logo
