Laszlo, many thanks for this.
Cc:ing some new(ish) maintainers.
/
Leif
On Wed, Oct 17, 2018 at 02:04:01PM +0200, Laszlo Ersek wrote:
> Hi Leif,
>
> On 10/16/18 04:28, Leif Lindholm wrote:
>
> > Laszlo: a few years ago, you also posted a _really_ useful email about
> &
e Ecosystem Development, Intel Software
> brian.richard...@intel.com<mailto:brian.richard...@intel.com> -- @intel_brian
> (Twitter & WeChat)
> https://software.intel.com/en-us/meet-the-developers/evangelists/team/brian-richardson
>
> From: Leif Lindholm
> Sent: Friday, October 1
Looks good functionality-wise, but is a bit of a handful to look at (and
not just because I'm code reviewing on a phone).
Could you do it with a couple of temp vars?
/
Leif
On Fri, 19 Oct 2018, 18:48 Ard Biesheuvel,
wrote:
> Commit 9dd8190e4995 ("Silicon/SynQuacer: tweak PCI I/O windows
Hi Brian,
I've started having a look at this, and have a few comments:
- There is no Readme.md at the top level, as set out in
https://github.com/tianocore/edk2-staging/blob/about/README
Mainly, this means I don't know who I should cc on any comments I have.
- There have been substantial
On Thu, Oct 18, 2018 at 02:43:37PM +0530, Sumit Garg wrote:
> On Thu, 18 Oct 2018 at 14:04, Leif Lindholm wrote:
> >
> > On Thu, Oct 18, 2018 at 12:59:32PM +0530, Sumit Garg wrote:
> > > > So, looking at the OpTee sources, TEE_UUID is defined as a struct, to
>
On Thu, Oct 18, 2018 at 12:59:32PM +0530, Sumit Garg wrote:
> > So, looking at the OpTee sources, TEE_UUID is defined as a struct, to
> > exactly the same layout as the EFI_GUID type (which is a typedef of
> > the GUID struct). Could we add a OPTEE_UUID typedef for the same
> > struct in
ned-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
> Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 5 -
> Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 2 ++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Platform/Socionext/DeveloperB
okeFunc
>
> Cc: Ard Biesheuvel
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Sumit Garg
> ---
> ArmPkg/Library/OpteeLib/OpteeLib.inf | 2 +
> ArmPkg/Include/Library/OpteeLib.h| 88 +
>
BinPkg/EnhancedFatDxe/Ebc/Fat.efi
> >> delete mode 100644 FatBinPkg/EnhancedFatDxe/Fat.inf
> >> delete mode 100644 FatBinPkg/EnhancedFatDxe/Ia32/Fat.efi
> >> delete mode 100644 FatBinPkg/EnhancedFatDxe/Ipf/Fat.efi
> >> delete mode 100644 FatBinPkg/En
On Mon, Oct 15, 2018 at 12:55:21PM +0800, Hao Wu wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1249
>
> We found potential dead codes within File.c during the code coverage test.
>
> After manual review, we think the below ones are positive reports:
>
> A. In function
On Sat, Oct 13, 2018 at 11:42:00PM +0200, Laszlo Ersek wrote:
> On 10/12/18 16:40, Sami Mujawar wrote:
> > Kvmtool is a virtual machine manager that enables hosting KVM
> > guests. ARM is working to enhance kvmtool support to enable
> > launching of KVM guest with UEFI support.
>
> Why is QEMU
Hi Eric,
1) Really happy to see the first SCT patch out for public review!
2) Could you go through Laszlo's excellent guide for contributions at
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers
?
Specifically the bits
Hi Fan,
This change has been reverted for now.
Please update to latest version of edk2.
Python3 migration will happen at some point, but not this abrupt.
Best Regards,
Leif
On Sat, Oct 13, 2018 at 01:17:05PM +, Chen, Farrah wrote:
> Hello,
>
> When we make edk2 "OvmfPkg/build.sh -a X64
n3 branch
> for the edk2 user evaluation.
This looks good to me, thanks!
Regards,
Leif
> Thanks
> Liming
> > -Original Message-
> > From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> > Sent: Sunday, October 14, 2018 4:40 AM
> > To: Zhu, Yonghong
> >
c9
>
> Best Regards,
> Zhu Yonghong
>
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Sunday, October 14, 2018 12:44 AM
> To: Zhu, Yonghong
> Cc: edk2-devel@lists.01.org; Leif Lindholm
> Subject: Re: [Patch] BaseTool
On Fri, Oct 12, 2018 at 03:40:05PM +0100, Sami Mujawar wrote:
> Some virtual machine managers like kvmtool emulate the MC146818
> RTC controller in the MMIO space so that architectures that do
> not support I/O Mapped I/O can use the RTC. This patch adds MMIO
> support to the RTC controller
el
> > Sent: Saturday, October 13, 2018 4:18 PM
> > To: edk2-devel-01 ; Gao, Liming
> > ; Laszlo Ersek ; Leif Lindholm
> > ; Kinney, Michael D ;
> > Zhu, Yonghong ;
> > stephano.cet...@linux.intel.com
> > Subject: [edk2] BaseTools/ buil
On Fri, Oct 12, 2018 at 06:07:01PM +0200, Laszlo Ersek wrote:
> On 10/12/18 15:27, Leif Lindholm wrote:
> > On Thu, Oct 11, 2018 at 10:43:57AM -0700, stephano wrote:
>
> >> Switching to Standard C Types
> >> -
> >> Both Shawn and
Hi Stephano,
Thanks for pulling this together.
Some comments below.
On Thu, Oct 11, 2018 at 10:43:57AM -0700, stephano wrote:
> Thank you all for a great set of meetings!
>
> This is an overview of the topics discussed and the tasks that were
> assigned. Please feel free to send me any
On Mon, Oct 08, 2018 at 03:20:27PM +0530, Sumit Garg wrote:
> On Fri, 5 Oct 2018 at 20:33, Leif Lindholm wrote:
> >
> > On Wed, Oct 03, 2018 at 11:33:01AM +0200, Ard Biesheuvel wrote:
> > > On 3 October 2018 at 09:43, Sumit Garg wrote:
> > > > Add following AP
On Tue, Aug 21, 2018 at 07:35:13PM +0800, Haojian Zhuang wrote:
> Add Designware USB 2.0 device driver that is used on HiKey platform.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Haojian Zhuang
&g
keFunc
> >
> > Cc: Ard Biesheuvel
> > Cc: Leif Lindholm
> > Cc: Michael D Kinney
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Sumit Garg
>
> Given the outcome of the GP discussion, I'm fine with this approach. Leif?
A
at 06:31:46PM +0800, Haojian Zhuang wrote:
> Add UsbSerialNumberLib. The Library could generate USB Serial Number
> that is used in USB device driver. And it could load/save the USB
> Serial Number into storage device.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Contrib
On Mon, Aug 20, 2018 at 06:31:25PM +0800, Haojian Zhuang wrote:
> Add Designware USB 3.0 device driver. It's focus on USB device
> functionality, not USB Host functionality. The USB driver is
> mainly used for Android Fastboot application.
>
> Cc: Leif Lindholm
>
On Mon, Aug 20, 2018 at 06:31:24PM +0800, Haojian Zhuang wrote:
> The protocol defines the callbacks that could be implemented in
> platform driver. DwUsb device driver needs these callbacks to
> implement USB device functionality.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
&
; create mode 100644 EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.dec
> create mode 100644 EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.h
> create mode 100644 EmbeddedPkg/Drivers/DwUsb3Dxe/DwUsb3Dxe.inf
> create mode 100644 EmbeddedPkg/Include/Protocol/DwUsb.h
+Peter
On Wed, Oct 03, 2018 at 04:59:54PM -0700, aaron.yo...@oracle.com wrote:
> I am suspecting that this patch to GRUB is the cause of a Buffer being
> re-transmitted before reaping the Buffer via SNP->GetStatus():
>
>
: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm
---
We'll need Reviewed-by: from both new maintainers.
Github write permissions need to be added separately.
Please add some documentation at the specified URL before
you import any code :)
Maintainers.txt | 5 +
1 file changed, 5
Hi Sumit,
On Fri, Sep 28, 2018 at 11:59:33AM +0530, Sumit Garg wrote:
> > > Please help to answer below query from Michael regarding licensing
> > > concerns for using Global Platform specs content in OP-TEE.
> >
> > This dates back to ~2014 before OP-TEE had been pushed as an open source
> >
Leif
> Is the asset at compile time?
>
> Jaben
>
> > On Sep 5, 2018, at 10:26 AM, Leif Lindholm wrote:
> >
> > Hi all,
> >
> > (This is partly a summary of discussions that have been held on IRC
> > and offline, with Alex Graf and Mike Kinney.
Hi all,
(This is partly a summary of discussions that have been held on IRC
and offline, with Alex Graf and Mike Kinney.)
The UEFI Shell, as produced by the contents of ShellPkg, is needed for
running the UEFI SCT. This has never been problematic before - but now
we are starting to run SCT on
siAcpiPlatformDxe";
> 4 Modify Signed-off-by and add Reviewed-by;
> 5 Modify other comments in v4;
>
> Code can also be found in github:
> https://github.com/hisilicon/OpenPlatformPkg.git
> branch: d06-platform-v5
For the series:
Reviewed-by: Leif Lindholm
Pushed as 1d331
thub:
> https://github.com/hisilicon/OpenPlatformPkg.git
> branch: d06-non-osi-v4
For the series:
Reviewed-by: Leif Lindholm
Pushed as 3ce657b0..572f1053.
> Ming Huang (2):
> Hisilicon: Add dec and header file
> Hisilicon/D06: Add binary modules
>
> Sil
On Fri, Aug 31, 2018 at 09:30:31PM +0200, Laszlo Ersek wrote:
> On 08/31/18 01:58, Henri Yandell wrote:
> > The CLA is missing an ‘or’ in section 3.
> >
> > See https://github.com/tianocore/edk2/pull/133/files for an example of the
> > specific text.
>
> could you please turn this report into a
Hi Ming,
Thanks for the quick turnaround. The difference since v4 is
substantial.
I think this is good to go - I spotted a couple of misplaced spaces
and such, bit I think I'll let them slip.
Will wait with pushing until Monday, when my head is hopefully a bit
clearer.
Have a great weekend,
Allright, we're getting close.
Please generate a v5 based on my comments for v4.
If that does not require changes to edk2-non-osi, there is no need to
generate a v5 of that.
_But_, one big overarching issue:
Every commit in the series needs to be buildable. For D03, D05 and D06.
There are many
On Fri, Aug 24, 2018 at 12:07:19AM +0800, Ming Huang wrote:
> Add M41T83RealTimeClockLib for RTC.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
> ---
> Platform/His
On Fri, Aug 24, 2018 at 12:07:20AM +0800, Ming Huang wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
> ---
> Platform/Hisilicon/D06/D06.dsc | 7 +++
> Platform/Hisilicon/D06/D06.fdf | 17 +
anoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
> ---
> Silicon/Hisilicon/HisiPkg.dec |
> 1 +
> Platform/Hisilicon/D06/D06.dsc |
> 5 +-
On Fri, Aug 24, 2018 at 12:07:41AM +0800, Ming Huang wrote:
> Select without SMMU iort while SMMU item is disable,
> Select with SMMU iort while SMMU item is enable.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
Reviewed-by
igned-off-by: Ming Huang
Reviewed-by: Leif Lindholm
> ---
> Platform/Hisilicon/D06/D06.dsc | 1 +
> Platform/Hisilicon/D06/D06.fdf | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc
> index fad6fcc
C FS chapter 1.8.2 design, add I2C
> Bus Exception handle function. It will Config SCL and SDA
> to GPIO, and set the reversal frequency of SCL to 10KHz.
>
> The implementation of functions is in edk2-non-osi.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed
Please update also subject and description to use "disable" and
"enable" instead of "close" and "open".
On Fri, Aug 24, 2018 at 12:07:38AM +0800, Ming Huang wrote:
> From: ZhenYao
>
> When BIOS booting, the power consumption is too high, so need close
> some clusters clock that don't work to
On Fri, Aug 24, 2018 at 12:07:37AM +0800, Ming Huang wrote:
> This module support updating the boot CPU firmware only.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
> Reviewed-by: Leif Lindholm
Ard also gave you a Reviewed-by for this pa
n see, this addresses all of my feedback:
Reviewed-by: Leif Lindholm
> ---
> Platform/Hisilicon/D06/D06.dsc | 1 +
> Platform/Hisilicon/D06/D06.fdf | 1 +
> Silicon/Hisilicon/Hi1620/Drivers/Apei/Apei.inf | 59 +++
> S
0xBFBA, 0x8FD9, 0x9FF8,
> + 0x6E17, 0x7E36, 0x4E55, 0x5E74, 0x2E93, 0x3EB2, 0x0ED1, 0x1EF0,
> +};
> +
> +EFI_STATUS
> +GetSfpSpeed (
> + UINT16 Socket,
> + UINT16 SfpNum,
> + UINT8* FiberSpeed
> + )
> +{
> + EFI_STATUS Status;
> + I2C_DEVICE SpdDev;
> +
Can you add Hi1620 to the subject line, so it's clear that this is a
D06-specific library?
With that
Reviewed-by: Leif Lindholm
/
Leif
On Fri, Aug 24, 2018 at 12:07:28AM +0800, Ming Huang wrote:
> From: Yang XinYi
>
> Add Setup Item "EnableGOP" for D06, This Item
re Contribution Agreement 1.1
> Signed-off-by: Ming Huang
> Reviewed-by: Leif Lindholm
Right, so I missed one bit on this last time around.
Could you leave changes to
Silicon/Hisilicon/Hi1620/Include/PlatformArch.h out here and just add
that in the initial d06 patch?
Then, could you move t
On Fri, Aug 24, 2018 at 12:07:13AM +0800, Ming Huang wrote:
> ARM_ACPI_HEADER is used by a unify module in HwPkg,
> so move some macro to PlatformArch.h for unify D0x.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
Reviewed-by: Leif Lin
ign-off in v4. Please address.
/
Leif
> Reviewed-by: Leif Lindholm
> ---
> Silicon/Hisilicon/Hi1610/Include/PlatformArch.h | 9 +++--
> Silicon/Hisilicon/Hi1616/Include/PlatformArch.h | 12
> 2 files changed, 19 insertions(+), 2 deletions(-)
>
> dif
On Fri, Aug 24, 2018 at 12:07:18AM +0800, Ming Huang wrote:
> Add several base head files and add several build
> files for D06.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
> Reviewed-by: Leif Lindholm
> ---
> Platfo
On 23 August 2018 at 17:07, Ming Huang wrote:
>
> This patch is relative to D06 SasDxe driver. The SasDxe set a
> variable to notice this libray. Here Wait for all disk ready
> for 15S at most.
>
> D06:
> For using straight-through hard disk backboard, some disk need
> 15 seconds to ready.
nt 1.1
> Signed-off-by: Ming Huang
> Reviewed-by: Leif Lindholm
This library is required to build
Silicon/Hisilicon/Drivers/PciPlatform/PciPlatform.inf, which exists in
D06.dsc from the original revision in:
Hisilicon/D06: Add several base file for D06
This breaks the build on every com
better way of dealing with this.
(But we don't, at the moment.)
/
Leif
> Contributed-under: TianoCore Contribution Agreement 1.1
> Cc: Ard Biesheuvel
> Cc: Leif Lindholm
> Signed-off-by: Chandni Cherukuri
> ---
> Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dbg2.aslc | 8 ++-
:49 AM, Ming wrote:
> >
> >
> > On 8/22/2018 5:11 AM, Leif Lindholm wrote:
> >> On Thu, Aug 16, 2018 at 08:12:35PM +0800, Ming Huang wrote:
> >>> If install SPCR table, KVM will not output while install or boot
> >>> some OS, like ubuntu, so add SPCR swit
On Thu, Aug 23, 2018 at 05:54:48PM +0800, Ming wrote:
> Hi Leif,
>
> How about this patch?
https://lists.01.org/pipermail/edk2-devel/2018-August/028823.html
/
Leif
> On 8/14/2018 4:08 PM, Ming Huang wrote:
> > If install SPCR table, KVM will not output while install or boot
> > some OS,
On Thu, Aug 23, 2018 at 03:39:57PM +0800, Ming wrote:
>
>
> On 8/22/2018 11:33 PM, Leif Lindholm wrote:
> > On Tue, Aug 14, 2018 at 04:08:55PM +0800, Ming Huang wrote:
> >> Add some Lpc macro to LpcLib.h for D06.
> >>
> >
> > Unaddress
On Thu, Aug 23, 2018 at 03:35:04PM +0800, Ming wrote:
> >> +BOOLEAN
> >> +BertAddGenericErrorData (
> >> + IN EFI_ACPI_6_0_BOOT_ERROR_RECORD_TABLE_HEADER *Bert,
> >> + IN EFI_CPER_SECTION_TYPE TypeOfErrorData,
> >> + IN VOID
Hi Sami,
On Tue, Aug 21, 2018 at 11:14:43AM +0100, Sami Mujawar wrote:
> Updated Redistributor base calculation to allow for the fact that
> GICv4 has 2 additional 64KB frames (for VLPI and a reserved frame).
> The code now tests the VLPIS bit in the GICR_TYPER register
Can you expand the name
Hi Ming,
I have finished reviewing v2/v3.
Please go ahead and start putting together and sending out a v4 of
both the edk2-platforms part and the edk2-non-osi part.
Regards,
Leif
On Tue, Aug 14, 2018 at 04:08:20PM +0800, Ming Huang wrote:
> The major features of this patchset include:
> 1 D06
So, on the whole, I am really not happy for any of these commands to
go into 18.08. I understand they may be handy for development, but I
do not understand why they make sense to upstream.
On Tue, Aug 14, 2018 at 04:09:02PM +0800, Ming Huang wrote:
> Add Hisilicon Oem Shell libraries for some
On Tue, Aug 14, 2018 at 04:08:56PM +0800, Ming Huang wrote:
> This module support updating the boot CPU firmware only.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
As I said on v1, I have no further comments on this.
Reviewed-by: Leif Li
Please correct the subject as per my prevoious comments on this.
On the whole, I think the enable/disable SMMU is a likely enough
scenario that we should probably have some core functionality for it
like for SPCR. For now I'm OK with this.
On Tue, Aug 14, 2018 at 04:09:00PM +0800, Ming Huang
On Wed, Aug 22, 2018 at 11:16:26PM +0800, Ming wrote:
>
>
> On 8/22/2018 10:27 PM, Leif Lindholm wrote:
> > On Tue, Aug 14, 2018 at 04:08:43PM +0800, Ming Huang wrote:
> >> Because I2C Port5 salve device connect under I2C extender
> >> (9545 device), it will c
On Wed, Aug 22, 2018 at 10:54:54PM +0800, Ming wrote:
>
>
> On 8/22/2018 5:49 PM, Leif Lindholm wrote:
> > On Tue, Aug 14, 2018 at 04:08:32PM +0800, Ming Huang wrote:
> >> Add PcdCoreCount to fix build issue while add binary components.
> >
> > This c
On Sat, Aug 18, 2018 at 02:20:49PM +0800, Ming wrote:
>
>
> 在 8/17/2018 8:23 PM, Leif Lindholm 写道:
> > Hi Ming,
> >
> > Please do not send new revisions while I'm still reviewing the
> > previous one. It is possible you inferred that I wanted this from some
&
nt 1.1
> Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
> ---
> Platform/Hisilicon/D06/D06.dsc
> | 1 +
>
> Silicon/Hisilicon/Hi1620/Library/Hi1620PciPlatformLib/Hi1620PciPlatformLib.inf
> | 30 +
On Tue, Aug 14, 2018 at 04:09:03PM +0800, Ming Huang wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
> ---
> Platform/Hisilicon/D03/D03.dsc | 2 +-
> Platform/Hisilicon/D05/D05.dsc | 2 +-
> Platform/His
On Tue, Aug 14, 2018 at 04:08:58PM +0800, Ming Huang wrote:
> During the period of I2c accessing, if the board is reset
> unexpectedly, and because the I2c client can not reset,
> the SDA will be always pull down, then it cause I2C bus
> Exception.
>
> Follow the Hi1620 I2C FS chapter 1.8.2
On Tue, Aug 14, 2018 at 04:08:57PM +0800, Ming Huang wrote:
> From: ZhenYao
>
> When BIOS booting, the power consumption is too high, so need close
> some clusters clock that don't work to reduce power consumption.
>
> The implementation of functions is in edk2-non-osi.
>
> Contributed-under:
On Tue, Aug 14, 2018 at 04:08:54PM +0800, Ming Huang wrote:
> From: Luqi Jiang
>
> This driver provide a means for the platform to
> convey error information to OSPM.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Luqi Jiang
> ---
> Platform/Hisilicon/D06/D06.dsc
om v1 have been addressed.
Reviewed-by: Leif Lindholm
/
Leif
> ---
> Platform/Hisilicon/D06/D06.dsc | 2 +-
> Platform/Hisilicon/D06/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 36 ++
> Platform/Hisilicon/D06/Library/PciHostBridgeLib
On Tue, Aug 14, 2018 at 04:08:52PM +0800, Ming Huang wrote:
> This peim configuare SMMU,BSP,MN(Miscellaneous Node).
configuare still needs to change to
configures
With that change:
Reviewed-by: Leif Lindholm
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: M
0x79,0,0,0},
> + {0xFF,0xFF,0xFF,1},
> + {0xC1,0,0,2},
> + {0xF9,0,0,3},
> + {0xFF,0xFF,0xFF,4},
> + {0x11,0,0,5},
> + {0x31,0,0,6},
> + {0x21,0,0,7}
> +};
> +
> +VOID
> +GetPciDidVid (
> + REPORT_PCIEDIDVID2BMC *
On Tue, Aug 14, 2018 at 04:08:50PM +0800, Ming Huang wrote:
> This Driver provide Get/Set Mac function.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
> ---
> Platform/His
Responding to v3 since that contains some of the things still problematic
in v2.
On 16 August 2018 at 13:12, Ming Huang wrote:
>
> OemNicLib provide nic related api like GetMac,SetMac.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
> ---
>
On Tue, Aug 14, 2018 at 04:08:48PM +0800, Ming Huang wrote:
> From: Heyi Guo
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Heyi Guo
Replace Heyi's Signed-off-by with your own.
Then
Reviewed-by: Leif Lindholm
> ---
> Platform/Hisilic
he set.
Please address throughout v4.
I have no further comment on this patch, so with that change:
Reviewed-by: Leif Lindholm
> ---
> Silicon/Hisilicon/Hi1620/Pptt/Pptt.inf | 48 ++
> Silicon/Hisilicon/Hi1620/Pptt/Pptt.h | 68 +++
> Silicon/Hisilicon/Hi1620/Pptt/Pp
On Tue, Aug 14, 2018 at 04:08:46PM +0800, Ming Huang wrote:
> From: Yang XinYi
>
> Add Setup Item "EnableGOP" for D06, This Item only takes
> effect on VGA device SM750.
Feedback on v1 was:
What is SM750? Please add more detail to commit message.
Please address.
Rest of patch is fine.
/
code that is
being modified - not the platform you are doing it for. Drop D06,
mention I2CLib.
All of these patches should go in before the first D06 one.
With those changes:
Reviewed-by: Leif Lindholm
> ---
> Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 9 -
> 1 file changed,
ER_PORT_HNS) {
> +// This is a empirical value for I2C delay. MemoryFance is no need
> here.
MemoryFance ->
MemoryFence
(You may want to search and replace that on the whole set.)
With that:
Reviewed-by: Leif Lindholm
/
Leif
> +I2C_Delay (1000);
&g
/I2CLib/I2CLib.c | 18 --
> 1 file changed, 12 insertions(+), 6 deletions(-)
Please change subject line to:
Silicon/Hisilicon: Fix I2CLib enable fail issue
and reorder it before the first D06 patch.
With that:
Reviewed-by: Leif Lindholm
> diff --git a/Silicon/Hisilicon/Library/I2CLib/I2CL
bution Agreement 1.1
> Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
> ---
> Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> | 2 ++
> Silicon/Hisilicon/Include/Library/IpmiCmdLib.h
> | 16 ++
On Tue, Aug 14, 2018 at 04:08:38PM +0800, Ming Huang wrote:
> From: Yang XinYi
>
> This library is added for oem setup menu item.
> Setup item include:
> 1 DDR option item;
> 2 BMC option item;
> 3 Ras option item;
> 4 Misc option item;
>
> Contributed-under: TianoCore Contribution Agreement
dback:
Reviewed-by: Leif Lindholm
(The only modification I asked for has been done.)
> ---
> Platform/Hisilicon/D06/D06.dsc |
> 1 +
> Platform/Hisilicon/D06/D06.fdf |
> 1 +
> Silicon/
r is to initialize the debug UART, not the serial
> console.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Heyi Guo
Reviewed-by: Leif Lindholm
> ---
> Platform/Hisilicon/D06/D06.dsc
> |
re Contribution Agreement 1.1
> Signed-off-by: Ming Huang
I told you you could have
Reviewed-by: Leif Lindholm
on this one.
Please add that to all patches where I say that on next submission.
(But also fix the spelling of Acpi in the subject please, I missed
that :)
/
Leif
> ---
>
(Commenting on the v3 patch since I know it supersedes the v2 patch.)
On Thu, Aug 16, 2018 at 08:12:10PM +0800, Ming Huang wrote:
> This patch is relative to D06 SasDxe driver. The SasDxe set a
> variable to notice this libray. Here Wait for all disk ready
> for 15S at most.
>
> D06:
> For using
On Tue, Aug 14, 2018 at 04:08:32PM +0800, Ming Huang wrote:
> Add PcdCoreCount to fix build issue while add binary components.
This commit message fails to describe what is being done, apart from a
single thing that should be a separate patch.
Pleas add a proper commit message describing which
On Tue, Aug 14, 2018 at 04:08:31PM +0800, Ming Huang wrote:
> Add M41T83RealTimeClockLib for RTC.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
> ---
> Platform/Hisilicon/D06/D06.dsc
> | 1 +
>
On Tue, Aug 14, 2018 at 04:08:30PM +0800, Ming Huang wrote:
> Add several base head files and add several build
> files for D06.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
All my comments have been addressed, so:
Reviewed-by
Err, that was 13, 14 and 17 in v3.
In v2, it's 20, 21, 24.
(I pushed the right patches, I just replied to the wrong email.)
On Tue, Aug 21, 2018 at 10:45:44PM +0100, Leif Lindholm wrote:
> Patches 13, 14 and 17/43 are just cleanup and refactoring of I2C
> library. It can (and shou
Patches 13, 14 and 17/43 are just cleanup and refactoring of I2C
library. It can (and should) go in before D06 support.
For the three patches:
Reviewed-by: Leif Lindholm
Pushed as 4e6af5fa1b..342330470f.
On Thu, Aug 16, 2018 at 08:12:20PM +0800, Ming Huang wrote:
> Modify spedd to Sp
On Thu, Aug 16, 2018 at 08:12:35PM +0800, Ming Huang wrote:
> If install SPCR table, KVM will not output while install or boot
> some OS, like ubuntu, so add SPCR switch setup item and set it
> disable by default.
This one was supposed to be replaced with
EmbeddedPkg/Drivers/ConsolePrefDxe,
On Tue, Aug 14, 2018 at 04:08:21PM +0800, Ming Huang wrote:
> This patch is to unify D0x. Add pGBL_INTERFACE struct define
> and remove useless interfece. Replace DMRC pGblData with pGblInterface;
interfece ->
interface
I will fix that up on commit.
Reviewed-by: Leif Lindholm
>
This one needs to be rebased onto the modified 3/43.
I have no other issues with it, so when you resubmit:
Reviewed-by: Leif Lindholm
On Tue, Aug 14, 2018 at 04:08:25PM +0800, Ming Huang wrote:
> From: Sun Yuanchen
>
> Move some RAS macros definition to PlatformArch.h for
>
On Thu, Aug 16, 2018 at 09:49:24AM +0800, Haojian Zhuang wrote:
> Fix the LDO9_VSET register definition in PMIC. LDO9 is used
> by Designware SD controller. Without this fix, SD controller
> fails to operate SD card since lack of right voltage setting.
>
> Cc: Leif Lindholm
>
On Thu, Aug 16, 2018 at 10:14:14AM +0800, Ming wrote:
> 在 8/15/2018 11:27 PM, Leif Lindholm 写道:
> > Thanks, this commit message is a lot better.
> >
> > My only concern with this patch is that the binaries are built with a
> > truly ancient toolchain. Is t
Thanks, this commit message is a lot better.
My only concern with this patch is that the binaries are built with a
truly ancient toolchain. Is there some particular reason for this?
/
Leif
On Tue, Aug 14, 2018 at 04:04:50PM +0800, Ming Huang wrote:
> Description per Module:
>
On Tue, Aug 14, 2018 at 04:04:51PM +0800, Ming Huang wrote:
> Add Hisilicon Oem Shell libraries for some commands,such as
> biosupdate, getmac, setmac, provision, acpistartos, brdinfo,
> sfpinfo.
>
> biosupdate example:
> ifconfig -s eth2 static 192.168.2.68 255.255.255.0 192.168.2.1
> biosupdate
501 - 600 of 2250 matches
Mail list logo
