Re: [edk2] [PATCH v2 4/4] Platform/Hisilicon/HiKey960: add skeleton of HiKey960

On Sat, Feb 10, 2018 at 01:31:07AM +0800, Haojian Zhuang wrote: > Add skeleton of HiKey960 platform. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Haojian Zhuang Reviewed-by: Leif Lindholm / Leif

Re: [edk2] [PATCH v2 2/4] Platform/Hisilicon/HiKey: use Hisilicon common file

On Sat, Feb 10, 2018 at 01:31:05AM +0800, Haojian Zhuang wrote: > Use common file Hisilicon.dsc.inc/Hisilicon.fdf.inc to reduce > redundant contents in both HiKey.dsc and HiKey.fdf. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Haojian Zhuang

Re: [edk2] [PATCH v2 1/4] Platform/Hisilicon/HiKey: include DxePcdLib for HiiDatabase

On Sat, Feb 10, 2018 at 01:31:04AM +0800, Haojian Zhuang wrote: > Include DxePcdLib for HiiDatabase. Otherwise, PlatformBootManager > can't be launched successfully. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Haojian Zhuang

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

On 12 February 2018 at 11:47, Haojian Zhuang wrote: >>From: Leif Lindholm >>Sent: Monday, February 12, 2018 11:45 AM >>To: Haojian Zhuang >>Cc: edk2-devel@lists.01.org; linaro-u...@lists.linaro.org; >>ard.sheu...@linaro.org;

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

On 12 February 2018 at 12:19, Haojian Zhuang wrote: >>From: Ard Biesheuvel >>Sent: Monday, February 12, 2018 12:05 PM >>To: Haojian Zhuang >>Cc: Leif Lindholm; edk2-devel@lists.01.org; heyi@linaro.org; >>ard.sheu...@linaro.org;

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

>From: Leif Lindholm >Sent: Monday, February 12, 2018 11:45 AM >To: Haojian Zhuang >Cc: edk2-devel@lists.01.org; linaro-u...@lists.linaro.org; >ard.sheu...@linaro.org; heyi@linaro.org >Subject: Re: [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

>From: Ard Biesheuvel >Sent: Monday, February 12, 2018 12:05 PM >To: Haojian Zhuang >Cc: Leif Lindholm; edk2-devel@lists.01.org; heyi@linaro.org; >ard.sheu...@linaro.org; linaro-u...@lists.linaro.org >Subject: Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out

[edk2] [PATCH v1 2/4] edk2-platforms:comcast: RDK secure boot Application

From: Kalyan Nagabhirava Application will get file path of PK key and KEK keys using rdk.conf file, once keys are available, application will enable secure boot and validates the signed kernel Image. Cc: Ard Biesheuvel

[edk2] [PATCH v1 3/4] edk2-platforms:comcast: RDK DRI Application

From: Kalyan Nagabhirava Application will Download platform code Image (kernel + DTB + rootfs) and writes into Flash partition. Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Moorthy

[edk2] [PATCH v1 0/4] edk2-platforms:Comcast:RDK Qemu platform for RDK UEFI application

Linaro and RDK are working on standardizing the boot process for RDK STB boxes using Uefi. Implmented couple of RDK UEFI apllications (secure boot and DRI) which are tested on RDK Qemu platform Kalyan Nagabhirava (4): edk2-platforms:comcast: RDK boot manager Library implementation

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

On Sat, Feb 10, 2018 at 01:31:06AM +0800, Haojian Zhuang wrote: > With the SerialPortLib and DebugLib, Dxe runtime driver can't > be executed well on HiKey. Serial logs are missing. "Can't be executed well"? Does this mean it crashes? > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

>From: Ard Biesheuvel >Sent: Monday, February 12, 2018 12:22 PM >To: Haojian Zhuang >Cc: Leif Lindholm; edk2-devel@lists.01.org; heyi@linaro.org; >linaro-u...@lists.linaro.org >Subject: Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime >lib from

[edk2] [PATCH v1 1/4] edk2-platforms:comcast: RDK boot manager Library implementation

From: Kalyan Nagabhirava Implemented features related to secure boot and DRI (downloading the image and storing on flash), library has utility of file read and write operations for fat flash partition, it reads file path and load the file content using

[edk2] [PATCH v1 4/4] edk2-platforms: created RDK Qemu platform for RDK UEFI applications

From: Kalyan Nagabhirava Linaro and RDK are working on standardizing the boot process for RDK STB boxes using Uefi. Implmented couple of RDK UEFI apllications (secure boot and DRI) which are tested on RDK Qemu platform Cc: Ard Biesheuvel

Re: [edk2] [PATCH 1/4] OvmfPkg: drop stale SafeBlockIoLib and SafeOpenProtocolLib resolutions

On 12 February 2018 at 13:45, Laszlo Ersek wrote: > These are listed under "ShellPkg/Application/Shell/Shell.inf", but they > have been commented out ever since commit 345a0c8fce38 ("OvmfPkg: Add > support for UEFI shell", 2011-06-26). No such lib classes exist in edk2. > > Cc:

[edk2] [PATCH 0/4] minuscule cleanups for Shell library resolutions

Repo: https://github.com/lersek/edk2.git Branch: shell_libs_cleanup Cc: Andrew Fish Cc: Ard Biesheuvel Cc: Eric Dong Cc: Jaben Carsey Cc: Jordan Justen Cc: Ruiyu Ni

[edk2] [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency

In commit 3a039a567a5f ("MdeModulePkg/UefiBootManagerLib: Remove the useless perf codes", 2018-02-12), the BmWriteBootToOsPerformanceData() function was removed. No TimerLib API calls are left, thus remove the TimerLib class dependency from "InternalBm.h" and "UefiBootManagerLib.inf" as well. Cc:

[edk2] [PATCH 1/4] OvmfPkg: drop stale SafeBlockIoLib and SafeOpenProtocolLib resolutions

These are listed under "ShellPkg/Application/Shell/Shell.inf", but they have been commented out ever since commit 345a0c8fce38 ("OvmfPkg: Add support for UEFI shell", 2011-06-26). No such lib classes exist in edk2. Cc: Ard Biesheuvel Cc: Jordan Justen

[edk2] [PATCH] ShellPkg/[hex]edit: use SimpleTextInEx to read console

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=682 Edit and HexEdit commands assume that SimpleTxtIn translates Ctrl+ key combinations into Unicode control characters (0x1-0x1A). Such translation does not seem to be required by the UEFI spec. Shell should not rely on implementation specific

[edk2] [PATCH] ShellPkg/[hex]edit: Fix wrongly use gST->ConIn as the console handle

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c | 2 +- ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c | 2 +-

[edk2] [PATCH 2/4] EmulatorPkg: drop stale SafeBlockIoLib and SafeOpenProtocolLib resolutions

These are listed under "ShellPkg/Application/Shell/Shell.inf", but they have been commented out ever since commit 3f2035e7a27a ("EmulatorPkg: Fix build break.", 2011-06-28). No such lib classes exist in edk2. Cc: Andrew Fish Cc: Jordan Justen

[edk2] [PATCH 4/4] ShellPkg: remove superfluous TimerLib resolution

TimerLib had to be resolved in commit 5ab97a64b51c ("ShellPkg/bcfg: Add Shell Spec 2.2 modification functionality", 2017-03-01) because: - the BCFG command started making calls to UefiBootManagerLib (EfiBootManagerVariableToLoadOption(), EfiBootManagerLoadOptionToVariable(),

Re: [edk2] [PATCH] ShellPkg/help: Fix "-?" may not show manual sometimes Shell core was enhanced to find the manual string in PE resource section. But the finding algorithm is too strict: If the manua

I think that is fine. I don’t think that there is a difference except the ShellCloseFile() is only available inside the shell, while the protocol API is available to applications that open the ShellProtocol. -Jaben > -Original Message- > From: Ni, Ruiyu > Sent: Sunday, February 11,

Re: [edk2] [PATCH 0/4] minuscule cleanups for Shell library resolutions

Reviewed-by: Jaben Carsey > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, February 12, 2018 5:45 AM > To: edk2-devel-01 > Cc: Andrew Fish ; Ard Biesheuvel >

Re: [edk2] [PATCH v2 0/2] NetworkPkg: Support the platform to configure HTTPS CipherList.

Hi Jiaxin, On 02/11/18 04:21, Wu, Jiaxin wrote: > Hi Laszlo, > > Can you help to report one Bugzilla for the new feature request? It's better > to describe the reason why we need support in Bugzilla. I've filed . Thank you for the patches!

Re: [edk2] [Patch 0/2] NetworkPkg: Support the platform to configure TLS CipherList.

On 02/11/18 03:33, Wu, Jiaxin wrote: > Hi Laszlo, > > Besides the compatibility consideration, we'd better *not* put > CipherList and CaCertificate into one variable. I didn't suggest to put them in the same variable -- I meant to put them in separate variables, just the two variables should

Re: [edk2] [PATCH] ShellPkg/[hex]edit: use SimpleTextInEx to read console

Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Monday, February 12, 2018 7:34 AM > To: edk2-devel@lists.01.org > Cc: Felix ; Carsey, Jaben > Subject: [PATCH] ShellPkg/[hex]edit: use SimpleTextInEx

Re: [edk2] [PATCH] ShellPkg/[hex]edit: Fix wrongly use gST->ConIn as the console handle

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Monday, February 12, 2018 7:34 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject:

Re: [edk2] [PATCH] ShellPkg/help: Fix "-?" may not show manual sometimes Shell core was enhanced to find the manual string in PE resource section. But the finding algorithm is too strict: If the manua

Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Sunday, February 11, 2018 7:18 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [PATCH] ShellPkg/help: Fix "-?" may not show manual sometimes > Shell

[edk2] how do I use RamDiskDxe?

Hi All, I'm trying to develop a tool for automated BIOS flashing from the EFI shell using IPMI serial over lan to drive it.  To accomplish this, my plan is to use a network booted EFI shell with a tftp client and a ramdisk to download the flash tools and ROM into as a workspace and then run

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017 1/2] Add support for SueCreek LED Drivers

Adds support for two ACPI entries for PCA9956 LED drivers for SueCreek DMIC board. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Teemu Rytkonen --- .../AcpiTablesPCAT/PlatformSsdt/PlatformSsdt.asl | 3 +

Re: [edk2] Poll: When to use OVMF and Nt32?

Thomas: I generally recommend NT32 when developing UEFI applications that don't have dependencies for any specific hardware design/architecture, and only rely on UEFI Boot Services. OVMF is running on virtualized hardware, so it's better for the following scenarios... * Testing boot to an

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017 2/2] Enable Turbo on CpuPower default configuration

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: tsrytkon --- .../Common/PlatformSettings/PlatformSetupDxe/CpuPower.vfi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [edk2] test message

On 02/07/18 17:17, Laszlo Ersek wrote: > On 02/07/18 15:35, Laszlo Ersek wrote: >> Hi All, >> >> my deepest apology for spamming the list with a test message. I have >> been having problems sending emails to the list, both with >> git-send-email (i.e. patches) and with Thunderbird (i.e. manually

[edk2] [PATCH] MdeModulePkg/ResetUtilityLib: Fix GCC build failure

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Dandan Bi --- MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [edk2] how do I use RamDiskDxe?

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Andrew Fish > Sent: Tuesday, February 13, 2018 8:40 AM > To: Rick Warner > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] how do I use RamDiskDxe? > > > > > On Feb 12, 2018, at 1:07 PM,

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017 1/2] Add support for SueCreek LED Drivers

Reviewed-by: zwei4 Thanks, David Wei Intel SSG/STO/UEFI BIOS -Original Message- From: Rytkonen, Teemu S Sent: Tuesday, February 13, 2018 5:32 AM To: edk2-devel@lists.01.org Cc: Wei, David ; Loeppert, Anthony

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017 2/2] Enable Turbo on CpuPower default configuration

Reviewed-by: zwei4 Thanks, David Wei Intel SSG/STO/UEFI BIOS -Original Message- From: Rytkonen, Teemu S Sent: Tuesday, February 13, 2018 5:41 AM To: edk2-devel@lists.01.org Cc: Wei, David ; Loeppert, Anthony

Re: [edk2] [PATCH v2 0/2] NetworkPkg: Support the platform to configure HTTPS CipherList.

Thanks Laszlo. If no other comments, I will commit this patch by the end of today. Best Regards! Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Tuesday, February 13, 2018 3:56 AM > To: Wu, Jiaxin

[edk2] [PATCH] MdePkg/BaseSafeIntLib: Fix VS IA32 NOOPT target build failure

The commit resolve the VS IA32 NOOPT target build failure for modules that use the BaseSafeIntLib. More specifically, corresponding BaseLib APIs should be used when performing shift & mulitiplication operations with signed/unsigned 64-bit operands. Cc: Michael D Kinney

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

On Tue, Feb 13, 2018 at 12:59:50AM +, Haojian Zhuang wrote: > On 02/13/2018 08:23 AM, Guo Heyi wrote: > > Hi Haojian, > > > > Dw8250SerialPortRuntimeLib actually depends on DW8250 hardware IP; if there > > isn't such device on Hikey, then you can't use this library instance indeed. > > > >

[edk2] [PATCH] MdeModulePkg/BmpSupportLib: Refine type cast for pointer subtraction

Since the pointer subtraction here is not performed by pointers to elements of the same array object. This might lead to potential issues, such behavior is undefined according to C11 standard. Refine the pointer subtraction expressions by casting each pointer to UINTN first and then perform the

Re: [edk2] [PATCH 4/4] ShellPkg: remove superfluous TimerLib resolution

On 2/12/2018 9:45 PM, Laszlo Ersek wrote: TimerLib had to be resolved in commit 5ab97a64b51c ("ShellPkg/bcfg: Add Shell Spec 2.2 modification functionality", 2017-03-01) because: - the BCFG command started making calls to UefiBootManagerLib (EfiBootManagerVariableToLoadOption(),

Re: [edk2] [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency

On 2/12/2018 9:45 PM, Laszlo Ersek wrote: In commit 3a039a567a5f ("MdeModulePkg/UefiBootManagerLib: Remove the useless perf codes", 2018-02-12), the BmWriteBootToOsPerformanceData() function was removed. No TimerLib API calls are left, thus remove the TimerLib class dependency from

Re: [edk2] [PATCH] MdeModulePkg/BmpSupportLib: Refine type cast for pointer subtraction

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Wu, Hao A Sent: Tuesday, February 13, 2018 10:28 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Kinney, Michael D ; Sean Brogan ;

Re: [edk2] Patch to fix EFIAPI definition

> On Feb 9, 2018, at 12:13 AM, Ruslan Nikolaev wrote: > > Sorry, I did not answer this question last time. It is basically may not be > very easy to change if you already have some assembly code which makes use of > a specific calling convention. Plus there may be

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

Hi Haojian, Dw8250SerialPortRuntimeLib actually depends on DW8250 hardware IP; if there isn't such device on Hikey, then you can't use this library instance indeed. But I think PeiDxeDebugLibReportStatusCode should be some common code, however it depends on ReportStatusCodeLib and Status Code

Re: [edk2] how do I use RamDiskDxe?

> On Feb 12, 2018, at 1:07 PM, Rick Warner wrote: > > Hi All, > > I'm trying to develop a tool for automated BIOS flashing from the EFI shell > using IPMI serial over lan to drive it. To accomplish this, my plan is to > use a network booted EFI shell with a tftp client

Re: [edk2] [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Monday, February 12, 2018 9:45 PM To: edk2-devel-01 Cc: Dong, Eric ; Carsey, Jaben ;

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

On 02/13/2018 08:23 AM, Guo Heyi wrote: > Hi Haojian, > > Dw8250SerialPortRuntimeLib actually depends on DW8250 hardware IP; if there > isn't such device on Hikey, then you can't use this library instance indeed. > > But I think PeiDxeDebugLibReportStatusCode should be some common code, however

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] SMBus Library.

Apollo Lake South Cluster SMBus executive code, which is common for PEI, DXE and SMM modules. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 Cc: Mang Guo --- .../PeiDxeSmmScSmbusCommonLib.inf | 35 ++

[edk2] [PATCH] MdeModulePkg/UsbMass: Fix hot-plug USB CDROM can't be recognized

In below calling stack: UsbBootIsUnitReady() UsbBootExecCmdWithRetry() UsbBootExecCmd() UsbBootRequestSense() When USB CDROM is hot-plugged, UsbBootRequestSense() retrieves sense key (6 = UnitAttention), additional sense code (29h = Power ON). But it wrongly maps such sense data to Device

Re: [edk2] [PATCH] MdeModulePkg/UsbMass: Fix hot-plug USB CDROM can't be recognized

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Tuesday, February 13, 2018 3:22 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star

Re: [edk2] [PATCH] MdeModulePkg/ResetUtilityLib: Fix GCC build failure

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Tuesday, February 13, 2018 11:03 AM To: edk2-devel@lists.01.org Cc: Bi, Dandan Subject: [edk2] [PATCH]

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] SMBus Host driver.

Add Apollo Lake SMBus host controller DXE driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 --- .../BroxtonSiPkg/SouthCluster/Smbus/Dxe/PchSmbus.h | 358 +++ .../SouthCluster/Smbus/Dxe/PchSmbusArp.c | 673