On 08/10/18 06:19, Eric Dong wrote:
> ACPI_CPU_DATA structure first introduced to save data in
> normal boot phase. Also this data will be used in S3 phase
> by one PEI driver. So in first phase, this data is been
> defined to use ACPI NVS memory type and must below 4G.
>
> Later in order to fix
On 08/10/18 06:19, Eric Dong wrote:
> V1 changes:
>> Current code logic can't confirm CpuS3DataDxe driver start before
>> CpuFeaturesDxe driver. So the assumption in CpuFeaturesDxe not valid.
>> Add implementation for AllocateAcpiCpuData function to remove this
>> assumption.
>
> V2 changes:
>>
On 08/10/18 06:19, Eric Dong wrote:
> Current implementation copies GDT/IDT at SmmReadyToLock point
> from ACPI NVS memory to Smram. Later at S3 resume phase, it restores
> memory saved in Smram to ACPI NVS. Driver can directly use GDT/IDT
> saved in Smram instead of restore the original ACPI NVS
On 08/10/18 06:19, Eric Dong wrote:
> Because CpuS3Data memory will be copy to smram at SmmReadyToLock point,
> the memory type no need to be ACPI NVS type, also the address not
> limit to below 4G.
>
> This change remove the limit of ACPI NVS memory type and below 4G.
>
> Pass OS boot and
Eric,
On 08/10/18 06:19, Eric Dong wrote:
> Because CpuS3Data memory will be copy to smram at SmmReadToLock point by
> PiSmmCpuDxeSmm driver,
> the memory type no need to be ACPI NVS type, also the address not limit to
> below 4G.
>
> This change remove the limit of ACPI NVS memory type and
On 08/10/18 03:43, Hao Wu wrote:
> The series will add RSB stuffing logics to avoid RSB underflow on return
> from SMM (rsm instruction).
>
> Cc: Jiewen Yao
> Cc: Eric Dong
> Cc: Laszlo Ersek
>
> Hao Wu (2):
> UefiCpuPkg/SmmCpuFeaturesLib: Add RSB stuffing before rsm instruction
>
On 08/10/18 18:12, Laszlo Ersek wrote:
> On 08/10/18 06:19, Eric Dong wrote:
>> Because CpuS3Data memory will be copy to smram at SmmReadyToLock point,
>> the memory type no need to be ACPI NVS type, also the address not
>> limit to below 4G.
>>
>> This change remove the limit of ACPI NVS memory
On 08/10/18 10:47, Zeng, Star wrote:
> I suggest merging this patch with
> https://lists.01.org/pipermail/edk2-devel/2018-August/027953.html to one
> patch.
> And remember to update the new patch's version.
There's another thing to remember please, when posting the new version
of the series:
On 08/10/18 06:19, Eric Dong wrote:
> Because PrepareApStartupVector() stores StackAddress to
> "mExchangeInfo->StackStart" (which has type (VOID*)), and because
> "UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.nasm" reads the latter with:
>
> add edi, StackStartAddressLocation
> add
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> shenglei
> Sent: Friday, August 10, 2018 2:11 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen
> Subject: [edk2] [PATCH] SignedCapsulePkg: Remove redundant
Hi Shenglei,
I know PrintLib is used by ParseConfigProfile.c that is included by
SystemFirmwareUpdateDxe.inf.
But could you evaluate whether DxeServicesLib could be removed from
SystemFirmwareUpdateDxe.inf or not?
Thanks,
Star
-Original Message-
From: edk2-devel
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 06/26] MdeModulePkg PciBusDxe: Remove redundant functions
The functions that are never called have been
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 10/26] MdeModulePkg XhciPei: Remove redundant functions
The functions that are never called have been
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 09/26] MdeModulePkg XhciDxe: Remove redundant functions
The functions that are never called have been
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 12/26] MdeModulePkg UfsPassThruDxe: Remove redundant functions
The functions that are never called have been
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 13/26] MdeModulePkg UsbBotPei: Remove redundant functions
The functions that are never called have been
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 15/26] MdeModulePkg UsbBusPei: Remove redundant functions
The functions that are never called have been
by design a platform need define a trusted console and only connect this
trusted console before endofdxe
thank you!
Yao, Jiewen
> 在 2018年8月10日，下午4:50，"heyi@linaro.org" 写道：
>
> Hi folks,
>
> The function Tcg2PhysicalPresenceLibProcessRequest in
> DxeTcg2PhysicalPresenceLib
> requires
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 16/26] MdeModulePkg Core/Dxe: Remove redundant functions
The functions that are never called have been
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 17/26] MdeModulePkg PiSmmCore: Remove redundant functions
The functions that are never called have been
It's used to create NonDiscoverableDevice in embedded platform. Since
there's no PCI bus.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
---
EmbeddedPkg/EmbeddedPkg.dec |
1 +
Changelog:
v1:
*Add NonDiscoverableDeviceDxe for embedded platform. Make DwMmcHcDxe driver
to support both eMMC and SD controller.
Haojian Zhuang (2):
EmbeddedPkg: add NonDiscoverableDeviceDxe driver
EmbeddedPkg: add DwMmcHcDxe driver
EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec
I suggest merging this patch with
https://lists.01.org/pipermail/edk2-devel/2018-August/027953.html to one patch.
And remember to update the new patch's version.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of shenglei
Sent:
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 08/26] MdeModulePkg UhciPei: Remove redundant functions
The functions that are never called have been
I agree with Hao. Reviewed-by: Star Zeng .
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Friday, August 10, 2018 10:58 AM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: RE: [edk2] [PATCH 11/26] MdeModulePkg UfsBlockIoPei: Remove redundant
Sorry, I meant 'called'.
-Original Message-
From: Zeng, Star
Sent: Thursday, August 9, 2018 6:24 PM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: RE: [PATCH 22/26] MdeModulePkg HiiDatabaseDxe: Remove a redundant
function
There is a typo in commit
Sorry, I meant 'called'.
-Original Message-
From: Zeng, Star
Sent: Thursday, August 9, 2018 6:10 PM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: RE: [PATCH 01/26] MdeModulePkg CapsuleApp: Remove a redundant function
There is a typo in commit log.
Add board specific code for AAEON UP2 board.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: David Wei
CC: Mike Wu
CC: Mang Guo
---
.../Board/UP2/BoardInitDxe/BoardInitDxe.c | 68 +++
.../Board/UP2/BoardInitDxe/BoardInitDxe.h | 37 ++
Enable DwMmcHcDxe driver on HiKey960 platform.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
---
Platform/Hisilicon/HiKey960/HiKey960.dsc | 8 ++
Platform/Hisilicon/HiKey960/HiKey960.fdf
Changelog:
v1:
* Enable eMMC/SD driver on HiKey.
* Enable SD driver on HiKey960.
Haojian Zhuang (3):
Silicon/Hi3660: fix LDO9_VSET register definition
Platform/HiKey960: enable SD controller
Platform/HiKey: enable SD/MMC controller on HiKey
Platform/Hisilicon/HiKey/HiKey.dsc
Replace DwEmmcDxe driver by DwMmcHcDxe driver on HiKey platform. Since
the new driver could work on both eMMC and SD controller.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
---
Platform/Hisilicon/HiKey/HiKey.dsc
Hi folks,
The function Tcg2PhysicalPresenceLibProcessRequest in DxeTcg2PhysicalPresenceLib
requires to be invoked after console is ready, and in the function it will call
VariableLockProtocol->RequestToLock(), while variable RequestToLock() requires
to be called before "End Of Dxe" event, or else
I suggest merging this patch to thread
https://lists.01.org/pipermail/edk2-devel/2018-August/028167.html.
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Friday, August 10, 2018 2:30 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH] MdeModulePkg:
I suggest merging this patch to thread
https://lists.01.org/pipermail/edk2-devel/2018-August/028167.html.
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Thursday, August 9, 2018 2:54 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH] MdeModulePkg
Fix the LDO9_VSET register definition in PMIC.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
---
Silicon/Hisilicon/Hi3660/Include/Hi3660.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 14/26] MdeModulePkg UsbBusDxe: Remove redundant functions
The functions that are never called have been
Sorry, I meant 'called'.
-Original Message-
From: Zeng, Star
Sent: Thursday, August 9, 2018 6:25 PM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: RE: [PATCH 21/26] MdeModulePkg TerminalDxe: Remove a redundant function
There is a typo in commit log.
I agree with Hao.
And there is a typo in commit log. 'calld' should be 'called'.
With the typo fixed, Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Friday, August 10, 2018 10:58 AM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
There is a typo in commit log. 'calld' should be 'called'.
With the typo fixed, Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 18/26]
I agree with Hao.
And there is a typo in commit log. 'calld' should be 'called'.
With the typo fixed, Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Friday, August 10, 2018 10:58 AM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Reviewed-by: Guo Mang
-Original Message-
From: Kinney, Michael D
Sent: Friday, August 10, 2018 9:28 AM
To: edk2-devel@lists.01.org
Cc: Wei, David; Guo, Mang
Subject: [Patch 0/4] Vlv2TbltDevicePkg: Add FmpDevicePkg support
Update Vlv2TbltDevicePkg to build UEFI capsules for system
Some comments including the redundant functions removed
before have been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c
after analysis the BuildOptionValue function, we found the if statement
IsFieldValueAnArray is redundant because ValueExpressionEx will handle
it.
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
---
BaseTools/Source/Python/Common/Expression.py
Two redundant library classes have been removed.
The redundant function "IsSystemFmp" has been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1067
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
.../SystemFirmwareCommonDxe.c
44 matches
Mail list logo
