Re: [edk2] [PATCH 2/5] MdePkg: Include Shell/ShellDynamicCommand/ShellParameters definitions

I don't want to lose the file history either. I thought git can auto-detect the copy/move of files. I will investigate further. Thanks/Ray > -Original Message- > From: Carsey, Jaben > Sent: Tuesday, October 18, 2016 2:02 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org >

[edk2] [patch] MdeModulePkg/Ufs: ensure the DBC field of UTP PRDT is dword-aligned

According to UFS Host Controller Spec(JESD223), the bits 1:0 of this DataByteCount field shall be 11b to indicate Dword granularity. But the size of UFS Request Sense Data Response defined in UFS Spec (JESD220C) is 18 which is not Dword aligned, we would have to round down to the multiple of 4 to

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Add a PCD to control if signaling first event.

Hi I am a little concern on this as well. If today, there is a POC require skipping PciEnumerationComplete. There might be the other POC tomorrow to skip ReadyToBoot Then another POC to skip EventExitBootServices. We will be exhausted to add POC to skip each separately. Can this POC handle all

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Add a PCD to control if signaling first event.

Hello Guo, FSP wrapper and Coreboot are bootloaders consuming FSP binary. FSP must get called Post PCI bus enumeration to do the required silicon initialization. Why do we need a PCD to skip it? Thanks, -Giri > -Original Message- > From: Dong, Guo > Sent: Monday, October 17, 2016 3:53

[edk2] [PATCH] IntelSiliconPkg: Fixed bug in IgdOpregion spec

Spec documents Mailbox3 - RM31 size as 0x45(69) instead of 0x46(70) Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h | 4 +++- 1 file

Re: [edk2] [PATCH] ArmPkg: Fix the GIC base address variables as 64-bit

Hello Ard, On Mon, Oct 17, 2016 at 06:09:00PM +0100, Ard Biesheuvel wrote: > On 17 October 2016 at 09:54, Dennis Chen wrote: > > Since ACPI spec defines the GIC base addresses (CPU interface, > > Distributor and Redistributor*GICv3 only*) as 64-bit, so we should > > define

Re: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 TransmitReceive()

Hi, Naveen I checked the code and found the IP4 stack is actually doesn't support classless IP address now, the main reason is in the NetLib interface NetGetIpClass() and NetIp4IsUnicast(). These 2 interfaces do not consider the netmask so it won't recognize a classless IP configuration.

Re: [edk2] [Patch] MdePkg BaseSynchronizationLib: Update InterlockedCompareExchange64.nasm

Reviewed-by: Jeff Fan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, Liming Sent: Tuesday, October 18, 2016 9:36 AM To: Laszlo Ersek; edk2-de...@ml01.01.org Subject: Re: [edk2] [Patch] MdePkg BaseSynchronizationLib:

Re: [edk2] [PATCH 52/52] BaseTools/VfrCompile/Pccts: Make assignment operator not returning void

Hi Hao, I have below comments: Case 1: In order to keep consistence, can you also change other cases which still initialized with '\0' mOptions.VfrFileName[0]= '\0'; mOptions.RecordListFile= NULL; mOptions.CreateRecordListFile = FALSE;

Re: [edk2] [Patch 2/3] BaseTools: Update PatchCheck to handle the two [] as prefix

Thanks for the comment, when I push the patch I will do the update. Best Regards, Zhu Yonghong -Original Message- From: Justen, Jordan L Sent: Tuesday, October 18, 2016 12:49 AM To: Zhu, Yonghong ; edk2-devel@lists.01.org Cc: Gao, Liming

Re: [edk2] [Patch 1/3] BaseTools: Update PatchCheck for max length of subject and message line

I will remove the blank line after 'Fixes:' when I push this patch. thanks for the comment. Best Regards, Zhu Yonghong -Original Message- From: Justen, Jordan L Sent: Tuesday, October 18, 2016 12:40 AM To: Zhu, Yonghong ; edk2-devel@lists.01.org Cc: Gao, Liming

[edk2] OvmfPkg: hang in SetInterruptState with git 245cda6641ade1f1013c2d5c9c838f2706636828

I've just built both OVMF _and_ Qemu from the latest git sources, so I don't know which is at fault - but I'm seeing a hang in: #0 0x7f9dc030 in SetInterruptState (InterruptState=104 'h') at /home/bcran/workspace/edk2/MdePkg/Library/BaseLib/Cpu.c:60 It's at line 60 when it calls

Re: [edk2] [PATCH] GPT Shell Application/Library

To the old question about license: I asked our people to check and was told that the license is compatible with our BSD and ok by Intel. To the technical content – I really like this idea of a shared library. That would be a great way to share code and not have as much duplicate. -Jaben

Re: [edk2] [PATCH] GPT Shell Application/Library

Hi Michael, I am absolutely agree with your proposal. In the gpt Shell library/application I had to “borrow” some stuff from PartitionDxe.c to not reinvent a wheel. If the PartitionDxe maintainer agrees to have a separate library available for everybody, I would move all the GPT-related

[edk2] [PATCH] CorebootPayloadPkg/PciHostBridgeLib: Fix the wrong PCI resource limit

The current PCI resource limit calculation in CorebootPayloadPkg PciHostBridgeLib is wrong. Adjusted it to match the PciHostBridge driver's expectation. Cc: Prince Agyeman Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Maurice Ma

Re: [edk2] [PATCH] ArmPkg: Fix the GIC base address variables as 64-bit

On 17 October 2016 at 09:54, Dennis Chen wrote: > Since ACPI spec defines the GIC base addresses (CPU interface, > Distributor and Redistributor*GICv3 only*) as 64-bit, so we should > define these corresponding base address variables as 64-bit instead of > 32-bit. This patch

Re: [edk2] Force reconnect children from within a DXE driver

On 10/17/16 18:05, Marcin Wojtas wrote: > Hi, > > Short introduction to the problem I'm facing with EDK2: I implemented > 'ifconfig' command extension allowing to change interface's MAC > address or reset it to the default value. For that I needed to add a > couple of helper functions in

Re: [edk2] [Patch 3/3] BaseTools: Update PatchCheck to report error for EFI_D_*

On 2016-10-17 01:28:38, Yonghong Zhu wrote: > In EDK2, DEBUG_* is recommended to be used instead of EFI_D_*. For new > code, they should use DEBUG_* macro. > > Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=145 > Remove blank line. I think you meant 143, not 145. Instead of looking for

Re: [edk2] [Patch 2/3] BaseTools: Update PatchCheck to handle the two [] as prefix

A small (not too important) suggestion for the patch subject might be: BaseTools/PatchCheck.py: Update to handle the two [] as prefix On 2016-10-17 01:28:37, Yonghong Zhu wrote: > The bug is that only remove the first [] when it does the char count, > however sometimes we use [edk2][patch] as

Re: [edk2] [Patch 1/3] BaseTools: Update PatchCheck for max length of subject and message line

On 2016-10-17 01:28:36, Yonghong Zhu wrote: > This patch update PatchCheck.py: > 1. The subject line of the commit message should be < 72 characters. > 2. The other lines of the commit message should be < 76 characters. > > Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=113 > Can you

Re: [edk2] [PATCH] GPT Shell Application/Library

Laszlo, We don't have a hard and fast rule about command names. The simple thing is that we may have a conflict in the future, but I don't see that as likely at this point. Your comment about _ was when a custom implementation wants to extend an existing defined command with a non-standard

Re: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg

Yao, How many closed source packages are going to be working against the trunk? Don't most of those platforms already have a copy of ShellPkg and therefore they wont care? -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yao,

Re: [edk2] [PATCH 1/5] ShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Friday, October 14, 2016 2:44 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Kinney, Michael

[edk2] Force reconnect children from within a DXE driver

Hi, Short introduction to the problem I'm facing with EDK2: I implemented 'ifconfig' command extension allowing to change interface's MAC address or reset it to the default value. For that I needed to add a couple of helper functions in DxeNetLib, which parse input string and one that calls

Re: [edk2] [RESEND PATCH 1/1] ArmPlatformPkg/ArmTrustZone: Add support for specifying Subregions to be disabled

On 17 October 2016 at 14:25, Leif Lindholm wrote: > On Mon, Oct 17, 2016 at 10:18:01AM +, Bhupesh Sharma wrote: >> Hi Ard, Leif, >> >> Any comments on this patch ? > > You didn't cc me before :) > > But more importantly, I don't really have any platform to test this

Re: [edk2] [PATCH] MdePkg/BaseLib: Remove the unnecessary '_' before library APIs in ASM/NASM

Reviewed-by: Liming Gao -Original Message- From: Wu, Hao A Sent: Monday, October 17, 2016 7:22 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Gao, Liming ; Kinney, Michael D Subject: [PATCH]

Re: [edk2] [RESEND PATCH 1/1] ArmPlatformPkg/ArmTrustZone: Add support for specifying Subregions to be disabled

On Mon, Oct 17, 2016 at 10:18:01AM +, Bhupesh Sharma wrote: > Hi Ard, Leif, > > Any comments on this patch ? You didn't cc me before :) But more importantly, I don't really have any platform to test this on, so I could use a Tested-by: from someone who does. Evan, do you? > > From: Bhupesh

[edk2] [PATCH] MdePkg/BaseLib: Remove the unnecessary '_' before library APIs in ASM/NASM

The leading underscore (i.e. '_') before the names of some BaseLib library API in ASM/NASM files is unnecessary. It will cause link error with GCC tool chains. Cc: Liming Gao Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement

[edk2] Which CSM supported MotherBoard should be used for development

Hi, Can any one help my select mother board? currently I am testing on asus h81-me but it looks like it has bug in its CSM. -- Regards Saqib Ahmed Khanzada ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] [RESEND PATCH 1/1] ArmPlatformPkg/ArmTrustZone: Add support for specifying Subregions to be disabled

Hi Ard, Leif, Any comments on this patch ? > From: Bhupesh Sharma [mailto:bhupesh.sha...@nxp.com] > Sent: Friday, October 14, 2016 4:40 PM > > ARM TZASC-380 IP provides a mechanism to split memory regions being > protected via it into eight equal-sized sub-regions, with a bit setting > allowing

Re: [edk2] [PATCH v2] MdeModulePkg/BootMaintenanceUi: Enhance the codes logic

On 10/17/16 11:07, Bi, Dandan wrote: > Hi Laszlo, > > Thank you very much for your comments! > I have split this patch into 5 independent patches with following subject : > [patch 1/5] MdeModulePkg/BMMUI: ... > [patch 2/5] MdeModulePkg/BMMUI: ... > [patch 3/5] MdeModulePkg/BMMUI: ... > [patch

Re: [edk2] [PATCH] ArmVirtPkg: Drop the nonsense ASSERT() statement

On 10/17/16 10:54, Dennis Chen wrote: > Since All the GIC base address variables now are 64-bit, given > that a UNIT64 var cannot exceed MAX_UNIT64, it doesn't make sense > to continue keep them in the codes, so this patch just simply drop > those ASSERT() statements as it should be. > >

Re: [edk2] Urgent help -UefiBootManagerLib and LegacyBootManagerLib issue

hi,Thank Laszlo and Andrew, here are my findings Below loop in LegacyBM.c iterate 16 times out which 2 times it return success and 14 times it return error code 3 *for (Index = 0; Index < HandleCount; Index++) { // // Start the thunk driver so that the legacy

[edk2] [Patch] BaseTools: Enhance tool to generate EFI_HII_IIBT_DUPLICATE image block

When *.IDF file contains multiple definitions of image which point to the same image, current build tool generates multiple image blocks which contain the same image content. This patch enhance tool to generate EFI_HII_IIBT_DUPLICATE image blocks for non-first images for such case, to save the HII

Re: [edk2] [PATCH] GPT Shell Application/Library

On 10/17/16 08:49, Vladimir Olovyannikov wrote: > Thank you Laszlo, > > Sorry, I missed the fields; it is my first contribution, I will add the > required lines, review the source according to your comments and will > resubmit the patch. > So do you think the command should be _gpt instead of

Re: [edk2] [PATCH] ArmPkg ArmVirtPkg: fix the GIC base address variables as 64-bit

On Mon, Oct 17, 2016 at 10:20:30AM +0100, Ard Biesheuvel wrote: > On 17 October 2016 at 09:33, Leif Lindholm wrote: > > On Mon, Oct 17, 2016 at 08:28:50AM +0100, Ard Biesheuvel wrote: > >> > diff --git a/ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c > >> >

Re: [edk2] [PATCH] ArmPkg ArmVirtPkg: fix the GIC base address variables as 64-bit

On 17 October 2016 at 09:33, Leif Lindholm wrote: > On Mon, Oct 17, 2016 at 08:28:50AM +0100, Ard Biesheuvel wrote: >> > diff --git a/ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c >> > b/ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c >> > index

Re: [edk2] [patch] NetworkPkg: Support bracketed IPv6 address during a redirection in iSCSI

Reviewed-by: Fu Siyuan siyuan...@intel.com > -Original Message- > From: Zhang, Lubo > Sent: Friday, October 14, 2016 2:45 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Wu, > Jiaxin > Subject: [patch]

Re: [edk2] [patch] NetworkPkg: Enhance the code in DNS driver.

Reviewed-by: Fu Siyuan siyuan...@intel.com > -Original Message- > From: Zhang, Lubo > Sent: Friday, October 14, 2016 2:54 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Wu, > Jiaxin > Subject: [patch]

Re: [edk2] [patch] NetworkPkg: Add dns support for pxe boot based on IPv6.

Reviewed-by: Fu Siyuan > -Original Message- > From: Zhang, Lubo > Sent: Friday, October 14, 2016 3:28 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Wu, > Jiaxin > Subject: [patch]

[edk2] [PATCH] ArmVirtPkg: Drop the nonsense ASSERT() statement

Since All the GIC base address variables now are 64-bit, given that a UNIT64 var cannot exceed MAX_UNIT64, it doesn't make sense to continue keep them in the codes, so this patch just simply drop those ASSERT() statements as it should be. Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH] ArmPkg: Fix the GIC base address variables as 64-bit

Since ACPI spec defines the GIC base addresses (CPU interface, Distributor and Redistributor*GICv3 only*) as 64-bit, so we should define these corresponding base address variables as 64-bit instead of 32-bit. This patch redefines them according to the ACPI spec. Contributed-under: TianoCore

[edk2] [patch 2/5] MdeModulePkg/BMMUI: Remove the incorrect and useless codes

When updating console page, the "ConsoleCheck" in BmmFakeNvData may maintain the old uncommitted data, we should not copy it to BmmOldFakeNVData. And in BootMaintRouteConfig function, when save data successfully, it will copy the BmmFakeNvData to the BmmOldFakeNVData. So we can delete the logic

[edk2] [patch 4/5] MdeModulePkg/BMMUI: Show "Change Boot/Driver order" page correctly

When user enter the "Change Boot Order" page, the BootOptionOrder in BmmFakeNvData may maintain some uncommitted data which are not saved in "BootOrder" Variable and BootOptionMenu. So we should not always get the BootOptionOrder through the function GetBootOrder, it will result in incorrect UI

[edk2] [patch 3/5] MdeModulePkg/BMMUI: Make the BmmFakeNvData and BmmOldFakeNVData consistent

In BootMaintRouteConfig function, it will compare the data in BmmFakeNvData and BmmOldFakeNVData to see whether there are some changes need to save. In current codes when discarding changes or removing the useless changes, it will update the related fields in BmmFakeNvData. But also need to update

[edk2] [patch 5/5] MdeModulePkg/BMMUI: Add error handling codes

The function which handles the "Boot", "BootOrder" ... may return failure. This patch adds the error handling codes. return the failure info to browser. Cc: Laszlo Ersek Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore

[edk2] [patch 1/5] MdeModulePkg/BMMUI: Update TerminalMenu and ConsoleMenu in callback

In current codes, When user does some change related to Console or Terminal, when saving data, it will update the content in TerminalMenu and ConsoleMenu in BootMaintRouteConfig function. This patch moves the update action to the BootMaintCallback function with EFI_BROWSER_ACTION_CHANGED type. The

Re: [edk2] [PATCH] ArmPkg ArmVirtPkg: fix the GIC base address variables as 64-bit

On Mon, Oct 17, 2016 at 08:28:50AM +0100, Ard Biesheuvel wrote: > > diff --git a/ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c > > b/ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c > > index 64afc4d..16683ef 100644 > > ---

[edk2] [Patch 2/3] BaseTools: Update PatchCheck to handle the two [] as prefix

The bug is that only remove the first [] when it does the char count, however sometimes we use [edk2][patch] as prefix, this patch fix this bug. Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=113 Cc: Liming Gao Cc: Jordan Justen

[edk2] [Patch 1/3] BaseTools: Update PatchCheck for max length of subject and message line

This patch update PatchCheck.py: 1. The subject line of the commit message should be < 72 characters. 2. The other lines of the commit message should be < 76 characters. Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=113 Cc: Liming Gao Cc: Jordan Justen

[edk2] [Patch 3/3] BaseTools: Update PatchCheck to report error for EFI_D_*

In EDK2, DEBUG_* is recommended to be used instead of EFI_D_*. For new code, they should use DEBUG_* macro. Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=145 Cc: Liming Gao Cc: Jordan Justen Contributed-under: TianoCore Contribution

[edk2] [Patch 0/3] BaseTools: PatchCheck to align with wiki and report error for EFI_D_*

These patches address the following 2 bugs: https://bugzilla.tianocore.org/show_bug.cgi?id=113 https://bugzilla.tianocore.org/show_bug.cgi?id=145 Cc: Liming Gao Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH 00/52] Resolve issues for C source codes in BaseTools

Hao, I have some comments for three patches. Others are good to me. Patch: BaseTools/TianoCompress: Avoid possible NULL pointer dereference Comment: Please free allocated buffer after error happens. Patch: BaseTools/C/Common: Fix parameter format mismatch in scanf functions Comment:

Re: [edk2] [PATCH] ArmPkg ArmVirtPkg: fix the GIC base address variables as 64-bit

Hello Ard, Thanks for the comments! I will split this patch into 2 and for ArmVirtPkg patch, we just need to simply drop the original ASSERT() since it's nonsensical any more. Thanks, Dennis On Mon, Oct 17, 2016 at 08:28:50AM +0100, Ard Biesheuvel wrote: > Hi Dennis, > > On 17 October 2016

Re: [edk2] [PATCH 1/1] MdePkg/IoLib: Add support for big-endian MMIO

On 17 October 2016 at 05:10, Kinney, Michael D wrote: > Bhupesh, > > It is also possible to add an ARM specific PCD to select endianness and update > MdePkg/Library/BaseIoLibIntrinsic/IoLibArm.c to use that PCD in > MmioRead/Write() > APIs in that file to support both

Re: [edk2] [PATCH] ArmPkg ArmVirtPkg: fix the GIC base address variables as 64-bit

Hi Dennis, On 17 October 2016 at 06:03, Dennis Chen wrote: > Since ACPI spec defines the GIC base addresses (CPU interface, > Distributor and Redistributor*GICv3 only*) as 64-bit, so we > should define these corresponding base address variables as 64-bit > instead of 32-bit.

Re: [edk2] [PATCH] GPT Shell Application/Library

Hi, wouldn't it be better to make a generic gpt parsing library which is independent of the shell so both the shell and PartitionDxe can use it? It may also be useful for other applications which need additional information like the gpt partition names. Thanks Michael On Mon, Oct 17, 2016 at

Re: [edk2] [PATCH] GPT Shell Application/Library

Thank you Laszlo, Sorry, I missed the fields; it is my first contribution, I will add the required lines, review the source according to your comments and will resubmit the patch. So do you think the command should be _gpt instead of gpt? I was following TFTP and SF commands as a template. Thank

Re: [edk2] [Patch] BaseTools: PatchCheck to align with wiki and report error for EFI_D_*

Sure, I will add this info. Yes, add this suggestion is good. Best Regards, Zhu Yonghong -Original Message- From: Justen, Jordan L Sent: Monday, October 17, 2016 1:56 PM To: Zhu, Yonghong ; edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu,

[edk2] [Patch] ShellPkg: update ping to use timer service instead of timer arch protocol .

This patch update the shell ping command to use timer service to calculate the RTT time, instead of using the timer arch protocol. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan Cc: Ni Ruiyu Cc: Ye Ting