On 08/02/18 15:05, Gao, Liming wrote:
> MdePkg provides the basic module type header file, such as PiPei.h,
> PiDxe.h, Uefi.h. PiPei.h and PiDxe.h will include the basic PI
> definition. They have included PiHob.h and PiFirmwareVolume.h.
> Because the module type header file is included into
On 08/02/18 18:42, Rafael Machado wrote:
> Thanks Andrew and Laszlo for the clarification and guidance.
>
> About Laszlo questions
>
>> Is the reboot automatic (from the platform firmware), or application /
>> user initiated?
> Yes. We just do some clean up, finish the events and "return
.
It's a general policy thing; all native binaries should be built with
the system-wide flags. Some of those flags will let the binaries detect
some buffer overflows automatically, for example, which is helpful even
if the utility is never installed / packaged, just used as a one-off
build tool.
for posting v2.
Cheers
Laszlo
>
> Thanks
> Liming
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Monday, July 30, 2018 10:14 PM
>> To: Ni, Ruiyu ; edk2-devel-01
>> Cc: Zhang, Chao B ; Dong, Eric
>> ; Carsey, J
On 08/02/18 14:39, Rafael Machado wrote:
> Hi everyone
>
> After some other tasks I am back to this case :)
>
> After some debug, we detected the moment where things start to go wrong,
> but I am not sure what may cause this.
>
> What we noticed is that the following assert is reached:
>
s will conflict with the colon before port
> number. To alleviate this conflict in URI, the IPv6 expressed HostName
> are enclosed in square brackets ([]). To record the real IPv6 HostName,
> square brackets should be stripped.
>
> Cc: Ye Ting
> Cc: Fu Siyuan
> Cc: Laszlo E
that's missing
for OVMF. Ricardo's answer will tell us if there's another issue.
Thanks
Laszlo
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, August 2, 2018 5:49 AM
> To: Ricardo Araújo ; Zhang, Chao B
> ; Marc-André Lureau
> Cc: edk2-devel@lists.01.org
>
On 08/01/18 19:49, edk2-li...@mc2research.org wrote:
> When including MdePkg/Include/Library/HobLib.h in my project I get errors
> indicating that the following types are undefined:
>
> * EFI_RESOURCE_TYPE, lines 206 and 231
> * EFI_RESOURCE_ATTRIBUTE_TYPE, lines 207 and 232
>
>
>
> A
On 08/01/18 19:50, Ricardo Araújo wrote:
> The commit I was referring to is:
> https://github.com/tianocore/edk2/commit/f15cb995bb3880b77e15afe6facd3da05e599a17
>
> Regards,
>
> Ricardo Araujo -
> www.lsd.ufcg.edu.br/~ricardo
>
> - Mensagem original -
> De: "Ricardo Araújo"
> Para:
flict in URI, the IPv6 expressed HostName
> are enclosed in square brackets ([]). To record the real IPv6 HostName,
> square brackets should be stripped.
>
> Cc: Ye Ting
> Cc: Fu Siyuan
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-of
On 07/30/18 03:54, Ni, Ruiyu wrote:
> On 7/27/2018 8:06 PM, Laszlo Ersek wrote:
>> On 07/27/18 11:28, Ni, Ruiyu wrote:
>>> On 7/19/2018 4:50 AM, Laszlo Ersek wrote:
>>>
>>>> + //
>>>> + // Traverse the device path nodes relative to the fil
On 07/27/18 11:28, Ni, Ruiyu wrote:
> On 7/19/2018 4:50 AM, Laszlo Ersek wrote:
>
>> + //
>> + // Traverse the device path nodes relative to the filesystem.
>> + //
>> + while (!IsDevicePathEnd (*FilePath)) {
>> + //
>> + // Keep local variab
On 07/26/18 03:57, shenglei wrote:
> Some redundant libraray classes and guides have been removed in inf files.
The typos in the commit message should please be corrected when the
patch is pushed:
- libraray -> library
- guides -> GUIDs (this was really confusing for a second)
Thanks!
Laszlo
>
uble "-c"
options.
This patch doesn't change behavior.
Cc: Liming Gao
Cc: Yonghong Zhu
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1540244
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek
---
BaseTools/Source/C/Makefiles/header.makefile | 4 ++--
1 fi
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1540244
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek
---
BaseTools/Source/C/Makefiles/header.makefile | 5 -
BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile | 5 -
BaseTools/Source/C/VfrCompile
ve to introduce BUILD_OPTFLAGS
separately, so that "VfrCompile/GNUmakefile" can continue using just this
flag.
This patch doesn't change behavior.
Cc: Liming Gao
Cc: Yonghong Zhu
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1540244
Contributed-under: TianoCore Contribution A
A_OPTFLAGS and EXTRA_LDFLAGS macros into the BaseTools build.
Cc: Liming Gao
Cc: Yonghong Zhu
Thanks
Laszlo
Laszlo Ersek (6):
BaseTools/footer.makefile: expand BUILD_CFLAGS last for C files too
BaseTools/header.makefile: remove "-c" from BUILD_CFLAGS
BaseTools/Source/C: split &qu
: https://bugzilla.redhat.com/show_bug.cgi?id=1540244
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek
---
BaseTools/Source/C/Makefiles/header.makefile | 3 +++
BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile | 6 +-
BaseTools/Source/C/VfrCompile/Pccts
DUSER_ZZSYN -DZZLEXBUFSIZE=65536
However these options made no difference for linking in the first place.
Cc: Liming Gao
Cc: Yonghong Zhu
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1540244
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek
: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek
---
BaseTools/Source/C/Makefiles/footer.makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/C/Makefiles/footer.makefile
b/BaseTools/Source/C/Makefiles/footer.makefile
index 0926aa964547
On 07/25/18 13:35, Dong, Eric wrote:
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Wednesday, July 25, 2018 6:14 PM
>> To: Dong, Eric ; edk2-devel@lists.01.org
>> Cc: Ni, Ruiyu
>> On 07/25/18 05:50, Dong, Eric wrote:
>>> But some AP may wak
On 07/25/18 14:12, Laszlo Ersek wrote:
> On 07/25/18 09:50, Eric Dong wrote:
>> This patch series include changes:
>> 1. StartAllAPs should not use disabled APs, this is required by UEFI spec.
>> 2. Refine the code to remove the redundant definitions.
>>
>> V
On 07/25/18 14:09, Dong, Eric wrote:
> Hi Laszlo,
>
>
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Wednesday, July 25, 2018 7:47 PM
>> To: Dong, Eric ; edk2-devel@lists.01.org
>> Cc: Ni, Ruiyu
>> Subject: R
rtions(+), 21 deletions(-)
>
I requested commit message updates for all three patches. With those
implemented, please add:
Reviewed-by: Laszlo Ersek
(No need to repost.)
Please give me some more time to regression-test this series as well.
Thanks!
Laszlo
___
p will not wake up
> the disabled APs, in other cases also need to include the
> disabled APs, such as CpuDxe driver start up and
> ChangeApLoopCallback function.
>
> Cc: Laszlo Ersek
> Cc: Ruiyu Ni
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric D
(3)? It's OK if you leave out my remarks in brackets [].
No need to repost just because of this, of course.
Thanks!
Laszlo
>
> Cc: Laszlo Ersek
> Cc: Ruiyu Ni
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong
> ---
> UefiCpuPkg/Library/M
Hi Eric,
On 07/25/18 09:50, Eric Dong wrote:
> Current CPU state definition include CpuStateIdle and CpuStateFinished.
> After investigation, current code can use CpuStateIdle to replace the
> CpuStateFinished. It will reduce the state number and easy for maintenance.
>
> Cc: Las
On 07/25/18 05:50, Dong, Eric wrote:
> Hi Laszlo,
>
> I have root cause this issue, the AP hangs in the procedure when
> PiSmmCpuDxeSmm driver start up trigged this issue.
>
> When PiSmmCpuDxeSmm driver start up, it will call StartAllAps to set
> memory attribute. In StartAllAps function, after
On 07/24/18 15:22, Ard Biesheuvel wrote:
> On 24 July 2018 at 15:21, Laszlo Ersek wrote:
>> The class name for the "PeiResourcePublicationLib" instance is just
>> "ResourcePublicationLib", not "PeiResourcePublicationLib". However, no
>>
On 07/18/18 22:50, Laszlo Ersek wrote:
> Replace the OpenFileByDevicePath() function with EfiOpenFileByDevicePath()
> from UefiLib, correcting the following issues:
>
> - imprecise comments on OpenFileByDevicePath(),
> - code duplication between this module and other modules,
>
On 07/18/18 22:50, Laszlo Ersek wrote:
> The EfiOpenFileByDevicePath() function centralizes functionality from
>
> - MdeModulePkg/Universal/Disk/RamDiskDxe
> - NetworkPkg/TlsAuthConfigDxe
> - SecurityPkg/VariableAuthenticated/SecureBootConfigDxe
> - ShellPkg/Library/UefiShel
ulien Grall
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek
---
Notes:
built on all six platforms:
ArmVirtQemu-AARCH64
ArmVirtQemu-ARM
ArmVirtQemuKernel-AARCH64
ArmVirtQemuKernel-ARM
ArmVirtXen-AARCH64
ArmVirtXen-ARM
ArmVirtPkg/ArmVirt
PciLib
> - PeiResourcePublicationLib
> + ResourcePublicationLib
>PeiServicesLib
>PeiServicesTablePointerLib
>PeimEntryPoint
>
[ler...@redhat.com: insert empty line between commit msg body and tags]
Reviewed-by: Laszlo Ersek
Pushed as commit 0ed73bcdcd80.
I notice t
On 07/24/18 14:05, Sivaraman Nainar wrote:
> Hello all,
>
> When an application tried to download the remote file over internet with the
> HTTP Get Request it getting failed. If we try via the Intranet then
> application downloads the target file.
>
> The remote file is available in the Apache
On 07/24/18 14:16, Marvin Häuser wrote:
> Hey Laszlo,
>
>> -Original Message-
>> (1) Please post patch sets using a cover letter message:
>>
>> git config format.coverletter true
>> git config format.numberedtrue
>> git config sendemail.chainreplyto false
>> git config
On 07/24/18 08:38, Gao, Liming wrote:
> To keep compatibility, I suggest to update MdeModulePkg PPI definition to
> include MdePkg one, then typedef structure name and define macro name for SMM
> one. MdePkg SMM protocol uses this way to refer to MM protocol.
I agree this is a better approach
Hi Marvin,
On 07/24/18 03:40, Marvin Häuser wrote:
> Update all references to the SMM PPIs from MdeModulePkg to rather use
> MdePkg's MM PPI declarations.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marvin Haeuser
> ---
> OvmfPkg/SmmAccess/SmmAccessPei.c | 90
Hi,
On 07/23/18 06:34, Liming Gao wrote:
> From: Dongao Guo
>
> ResourcePublicationLib class name is ResourcePublicationLib.
> INF and DSC files are updated to use the correct one.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao
> Signed-off-by: Dongao
BIST information
> +// Install SecPlatformInformation2 PPI
> //
> Status = PeiServicesInstallPpi ();
> ASSERT_EFI_ERROR(Status);
>
Looks good to me:
Reviewed-by: Laszlo Ersek
but Eric should decide.
Thanks
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
On 07/19/18 20:42, Jordan Justen wrote:
> Reviewed-by: Jordan Justen
Thank you, Jordan :) Pushed as commit 2aa4fb10a574.
Laszlo
> On 2018-07-19 11:01:43, Laszlo Ersek wrote:
>> XenPvBlkDxe doesn't reference gEfiDevicePathProtocolGuid; remove it from
>> the INF file.
>&g
On 07/20/18 08:53, Dong, Eric wrote:
>> -Original Message- From: Laszlo Ersek
>> [mailto:ler...@redhat.com]
>> Therefore, please upgrade the host to Fedora 26. In Fedora 26, QEMU
>> 2.9 is shipped:
>>
>> https://koji.fedoraproject.org/koji/buildinfo
Hi Anthony,
(I'm seeing your v1 and v2 postings at the same time now:)
On 07/19/18 17:52, Anthony PERARD wrote:
> On Debian Jessie, this fail to build with:
>
> /build/UefiCpuPkg/Library/MpInitLib/Microcode.c: In function
> 'MicrocodeDetect':
>
Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek
---
Notes:
Repo: https://github.com/lersek/edk2.git
Branch: xenpvblk_redundant_proto_tcbz1034
OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf | 1 -
1 file changed, 1 deletion(-)
diff --git a/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf
b/OvmfPkg
Hi Eric,
apologies about the delay.
On 07/18/18 14:59, Dong, Eric wrote:
> Hi Laszlo,
>
> I finally succeed to setup the OVMF platform which can verify the boot
> failure issue. But on my platform, if I use image build with below
> command (I assume it is used to enable SMM), the system can't
On 07/18/18 16:02, Ard Biesheuvel wrote:
> On 18 July 2018 at 21:52, Laszlo Ersek wrote:
>> None of the source files referenced by "AcpiPlatformDxe.inf" #include
>> "MdePkg/Include/Library/DxeServicesLib.h" or use interfaces declared
>> therein, so
to get AP index because
> this solution may return error AP index if stack buffer overflow.
>
> Cc: Ruiyu Ni
> Cc: Jeff Fan
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong
> ---
> UefiCpuPkg/Library/MpInitLib/MpLi
On 07/18/18 04:35, Wang, Jian J wrote:
> Hi Laszlo,
>
>
> Regards,
> Jian
>
>
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Tuesday, July 17, 2018 10:37 PM
>> To: Wang, Jian J ; edk2-devel@lists.01.org
&g
Thanks,
Laszlo
>
> Thanks,
> Star
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, July 19, 2018 4:51 AM
> To: edk2-devel-01
> Cc: Dong, Eric ; Wu, Jiaxin ; Ni,
> Ruiyu ; Fu, Siyuan ; Zeng, Star
>
> Subjec
On 07/19/18 14:12, Eric Dong wrote:
> Remove the useless code error added by change
> 58942277bcbf41abda5f6e3a1c89d571105d5983.
>
> Cc: Laszlo Ersek
> Cc: Ruiyu Ni
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong
> ---
> U
2018 10:36 AM
>> To: Laszlo Ersek ; edk2-devel@lists.01.org
>> Cc: Dong, Eric ; Yao, Jiewen ;
>> Zeng, Star
>> Subject: RE: [PATCH] UefiCpuPkg/CpuDxe: fix incorrect check of SMM mode
>>
>> Hi Laszlo,
>>
>>
>> Regards,
>> Jian
>>
Hi Dandan,
On 07/19/18 06:50, Dandan Bi wrote:
> Cc: Eric Dong
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi
> ---
> UefiCpuPkg/Library/MpInitLib/Microcode.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
unction,
> it check whether Cpu Loop mode is not HLT mode. If yes,
> CpuMpPei driver will set a flag to force BSP use INIT-SIPI
> -SIPI command to wake up the APs.
>
> Cc: Laszlo Ersek
> Cc: Ruiyu Ni
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-
> The question I have is: Where should the sanity check be?
At the moment: in the caller.
Thanks!
Laszlo
>
> thank you!
> Yao, Jiewen
>
>
>> 在 2018年7月19日，上午4:50，Laszlo Ersek 写道：
>>
>> The EfiOpenFileByDevicePath() function centralizes functionality from
>
On 07/19/18 02:07, Ard Biesheuvel wrote:
> On 19 July 2018 at 06:15, Carsey, Jaben wrote:
>> Reviewed-by: Jaben Carsey
>>
>> One question (do hold up push). Is there a reason to use the former over the
>> latter? I use latter and I see you use the former.
>>
>> ASSERT(EFI_ERROR (Status));
>>
Jiewen Yao
Cc: Roman Bacik
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1008
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek
---
SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf
| 1 -
SecurityPkg/V
gi?id=1008
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek
---
ShellPkg/Library/UefiShellLib/UefiShellLib.inf | 2 +-
ShellPkg/Include/Library/ShellLib.h| 2 --
ShellPkg/Library/UefiShellLib/UefiShellLib.c | 11 ---
3 files changed, 5 inserti
Zhang
Cc: Eric Dong
Cc: Jaben Carsey
Cc: Jiaxin Wu
Cc: Jiewen Yao
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Roman Bacik
Cc: Ruiyu Ni
Cc: Siyuan Fu
Cc: Star Zeng
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1008
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo
ik
Cc: Ruiyu Ni
Cc: Siyuan Fu
Cc: Star Zeng
Thanks,
Laszlo
Laszlo Ersek (6):
MdePkg/UefiLib: introduce EfiOpenFileByDevicePath()
MdeModulePkg/RamDiskDxe: replace OpenFileByDevicePath() with UefiLib
API
NetworkPkg/TlsAuthConfigDxe: replace OpenFileByDevicePath() with
UefiLib
sten
Cc: Steven Shi
Reported-by: Steven Shi
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1014
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek
---
Notes:
Repo: https://github.com/lersek/edk2.git
Branch: acpiplatform_redundant_tiano_1014
Ovm
On 07/17/18 18:38, Laszlo Ersek wrote:
> Hi Eric,
>
> On 07/16/18 05:08, Eric Dong wrote:
>> Use below three rules to optimize load uCode performance:
>> 1. Let BSP relocate uCode from flash to memory for better performance.
>> 2. BSP caches the CPU ID and address
Hi Eric,
On 07/16/18 05:08, Eric Dong wrote:
> Use below three rules to optimize load uCode performance:
> 1. Let BSP relocate uCode from flash to memory for better performance.
> 2. BSP caches the CPU ID and address of uCode so AP doesn’t need to look
>for the uCode again if the CPU ID is
mode",
2018-06-19).
How did you encounter / find this issue?
>
> Cc: Eric Dong
> Cc: Laszlo Ersek
> Cc: Jiewen Yao
> Cc: Star Zeng
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang
> ---
> UefiCpuPkg/CpuDxe/CpuPageTable.
On 07/17/18 12:02, Ni, Ruiyu wrote:
> On 7/16/2018 11:08 AM, Eric Dong wrote:
>> GetProcessorLocationByApicId (GetInitialApicId (), NULL, NULL,
>> );
>> + if (ThreadId != 0) {
>> + //
>> + // Skip loading microcode if it is not the first thread in one core.
>> + //
>> + return;
>> +
On 07/13/18 08:45, Ard Biesheuvel wrote:
> On 13 July 2018 at 01:41, Laszlo Ersek wrote:
>> Repo: https://github.com/lersek/edk2.git
>> Branch: armvirt_ipv6_bz1007
>>
>> Tested the "-D NETWORK_IP6_ENABLE" ArmVirtQemu build with PXEv4, PXEv6,
>>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1007
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek
---
ArmVirtPkg/ArmVirt.dsc.inc | 18 +++---
ArmVirtPkg/ArmVirtQemu.dsc | 13 -
ArmVirtPkg/
We already resolve a number of networking-related library classes in
ArmVirt.dsc.inc; follow suit with HttpLib.
Cc: Ard Biesheuvel
Cc: Julien Grall
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1007
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek
K, can you please push it for me as well? Thank
you.
Cc: Ard Biesheuvel
Cc: Julien Grall
Thanks
Laszlo
Laszlo Ersek (2):
ArmVirtPkg: unify HttpLib resolutions in "ArmVirt.dsc.inc"
ArmVirtPkg/ArmVirtQemu: enable the IPv6 stack
ArmVirtPkg/ArmVirt.dsc.inc | 21
On 07/12/18 23:59, Laszlo Ersek wrote:
> On 07/12/18 12:49, Eric Dong wrote:
>> Read uCode from memory has better performance than from flash.
>> But it needs extra effort to let BSP copy uCode from flash to
>> memory. Also BSP already enable cache in SEC phase, so it use
>
On 07/12/18 12:49, Eric Dong wrote:
> The SDM requires only one thread per core to load the
> microcode.
>
> This change enables this solution.
>
> Cc: Laszlo Ersek
> Cc: Ruiyu Ni
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong
On 07/12/18 12:49, Eric Dong wrote:
> Search uCode costs much time, if AP has same processor type
> with BSP, AP can use BSP saved uCode info to get better performance.
>
> This change enables this solution.
>
> Cc: Laszlo Ersek
> Cc: Ruiyu Ni
> Contributed-under
emory. After
> verification, if system has more than one processor, it will
> reduce some time if load uCode from memory.
>
> This change enable this optimization.
>
> Cc: Laszlo Ersek
> Cc: Ruiyu Ni
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by:
On 07/12/18 14:07, Yao, Jiewen wrote:
> thanks laszlo
> I like your idea to eliminate the code duplication and fix all the problem by
> adding a new api in uefi lib.
>
> If there is urgency to fix this specific issue, I have no problem on the
> enhancement.
>
> Reviewed by :
On 07/11/18 13:07, Eric Dong wrote:
> Use below three rules to optimize load uCode performance:
> 1. Let BSP relocate uCode from flash to memory for better performance.
> 2. BSP caches the CPU ID and address of uCode so AP doesn’t need to look
>for the uCode again if the CPU ID is same as
ear.)
> Also load uCode once can save some time.
>
> This change enables this solution.
>
> Cc: Laszlo Ersek
> Cc: Ruiyu Ni
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong
> ---
> UefiCpuPkg/Library/MpInitLib/Microcode.c | 9 +
On 07/11/18 13:07, Eric Dong wrote:
> Search uCode costs much time, if AP has same processor type
> with BSP, AP can use BSP saved uCode info to get better performance.
>
> This change enables this solution.
>
> Cc: Laszlo Ersek
> Cc: Ruiyu Ni
> Contributed-under
emory. After
> verification, if system has more than one processor, it will
> reduce some time if load uCode from memory.
>
> This change enable this optimization.
>
> Cc: Laszlo Ersek
> Cc: Ruiyu Ni
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed
On 07/11/18 18:06, Laszlo Ersek wrote:
> On 07/11/18 17:44, Roman Bacik wrote:
>> Hi Laszlo,
>>
>> Thank you very much for your review and help. I would prefer the option 2b.
>
> Great, thanks! Let's wait for the SecurityPkg maintainers then, to give
> their R-
On 07/11/18 19:10, Carsey, Jaben wrote:
>
>> -Original Message-
>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>> Laszlo Ersek
>> Sent: Wednesday, July 11, 2018 5:16 AM
>> To: rba...@gmail.com; edk2-devel@lists.01.org
>>
Hi Eric,
On 07/11/18 13:07, Eric Dong wrote:
> Use below three rules to optimize load uCode performance:
> 1. Let BSP relocate uCode from flash to memory for better performance.
> 2. BSP caches the CPU ID and address of uCode so AP doesn’t need to look
>for the uCode again if the CPU ID is
From my side, dependent on the pending commit message and patch
whitespace corrections (which I'm willing to implement myself, at push):
Reviewed-by: Laszlo Ersek
Thanks!
Laszlo
> Thanks,
>
> Roman
>
> On Wed, Jul 11, 2018 at 5:05 AM, Laszlo Ersek wrote:
>
>> Hi
On 07/11/18 15:01, Denis Plotnikov wrote:
> Hello!
>
> I'd like to ask whether it's a good idea or not to make the omfv
> discover the variable image size in the runtime.
Not a good idea.
> We have a setting in our product to use separate pflash images for OVMF
> code and variables parts in
en
>> Sent: Wednesday, July 11, 2018 3:45 PM
>> To: Dong, Eric ; Dong, Eric ;
>> Laszlo Ersek ; Fan Jeff ;
>> edk2-devel@lists.01.org
>> Cc: Ni, Ruiyu
>> Subject: RE: [edk2] 答复: [Patch] UefiCpuPkg/MpInitLib: Optimize get
>> processor number per
On 07/11/18 14:05, Laszlo Ersek wrote:
> - The OpenFileByDevicePath() function is duplicated in the following
> modules: "NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c", and
> "MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskFileExplorer.c". With the
> implicat
name starts on odd address, which is not a uint16
> aligned boundary: https://bugzilla.tianocore.org/show_bug.cgi?id=1003
>
> Cc: Chao Zhang
> Cc: Jiewen Yao
> Cc: Laszlo Ersek
> Cc: Vladimir Olovyannikov
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-of
Hello Sau Kae,
On 07/10/18 11:14, Tan, Sau Kae wrote:
> Hi All,
>
> May I know is armclang already supported in EDK2?
> Or only armcc is supported currently?
> Thanks.
Looking at "BaseTools/Conf/tools_def.template", the following toolchains appear
supported for both ARM and AARCH64:
- CLANG35
On 07/10/18 02:02, Laszlo Ersek wrote:
> On 07/10/18 00:11, Roman Bacik wrote:
>> +PathName = AllocateZeroPool (PathLength);
>> +CopyMem (PathName, ((FILEPATH_DEVICE_PATH*)*FilePath)->PathName,
>> PathLength);
>
> (3) I think it's not necessary to zer
> boundary: https://bugzilla.tianocore.org/show_bug.cgi?id=1003
>
> Cc: Chao Zhang
> Cc: Jiewen Yao
> Cc: Laszlo Ersek
> Cc: Vladimir Olovyannikov
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Roman Bacik
> ---
> .../SecureBootConfigFileExplorer
On 07/09/18 08:13, Dong, Eric wrote:
> Hi Laszlo,
>
> I have created https://bugzilla.tianocore.org/show_bug.cgi?id=1002 to request
> to add AsmReadEsp() / AsmReadRsp().
Much appreciated!
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
On 07/09/18 05:04, Dong, Eric wrote:
> Hi Laszlo,
>
>> -Original Message-----
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Thursday, July 5, 2018 9:04 PM
>> To: Fan Jeff ; Dong, Eric ;
>> edk2-devel@lists.01.org
>> Cc: Ni, Ruiyu
>
ark memory as MMIO for non SEV case
> b) do not adding EFI runtime mapping for SMM build
> c) clear C-bit when SEV is active for non SMM builds only
>
> Cc: Ard Biesheuvel
> Cc: Anthony Perard
> Cc: Julien Grall
> Cc: Justen Jordan L
> Cc: Laszlo Ersek
> Contribu
r SMM build
> c) clear C-bit when SEV is active for non SMM builds only
>
> Cc: Ard Biesheuvel
> Cc: Anthony Perard
> Cc: Julien Grall
> Cc: Justen Jordan L
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Brijesh Singh
&g
c: Justen Jordan L
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Brijesh Singh
> ---
> .../FvbServicesRuntimeDxe.inf | 1 +
> .../QemuFlashFvbServicesRuntimeDxe/FwBlockServiceDxe.c | 17
> ++
On 07/06/18 13:35, Laszlo Ersek wrote:
> On 07/05/18 21:12, Brijesh Singh wrote:
>> In the SMM build, only an SMM driver is using the address range hence we
>> do not need to expose the flash MMIO range in EFI runtime mapping.
>>
>> Cc: Ard Biesheuvel
>> Cc: An
On 07/05/18 21:12, Brijesh Singh wrote:
> In the SMM build, only an SMM driver is using the address range hence we
> do not need to expose the flash MMIO range in EFI runtime mapping.
>
> Cc: Ard Biesheuvel
> Cc: Anthony Perard
> Cc: Julien Grall
> Cc: Justen Jordan
ch IO addresses should
> be mapped as unencrypted. If memory region is not marked as MMIO then OS
> maps the range as encrypted.
>
> Cc: Ard Biesheuvel
> Cc: Anthony Perard
> Cc: Julien Grall
> Cc: Justen Jordan L
> Cc: Laszlo Ersek
> Contributed-under: TianoCo
Hi Brijesh,
On 07/05/18 16:05, Brijesh Singh wrote:
> [...]
I'll need some time before I can look at this -- meanwhile, can you
please repost the series with a dedicated cover letter email? If you
wish you can include a short summary description and v2/v3 etc updates
there; however, the main
On 07/05/18 15:04, Laszlo Ersek wrote:
> Hi Jeff,
>
> On 07/04/18 11:39, Fan Jeff wrote:
>> Eric,
>>
>> Current implementation does not call GetApicid() many times, Please correct
>> you commit message. Your fix is to improve the performance against the
>&g
esday, July 4, 2018 4:37:36 PM
> 收件人: edk2-devel@lists.01.org
> 抄送: Ruiyu Ni; Jeff Fan; Laszlo Ersek
> 主题: [Patch] UefiCpuPkg/MpInitLib: Optimize get processor number performance.
>
> Current function has low performance because it calls GetApicId
> many times.
>
> New lo
On 07/04/18 03:55, Ni, Ruiyu wrote:
> On 7/4/2018 9:50 AM, Ruiyu Ni wrote:
>> v4:
>> 1. adds missing PlatformBootManagerLib instances modification for
>> platform ArmPkg and ArmVirtPkg.
>> 2. Remove single quote in #1/9
>> 3. Wrap the long comments in #3/9
>>
>> Ruiyu Ni (9):
>>
On 07/04/18 03:50, Ruiyu Ni wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Julien Grall
> ---
> .../Library/PlatformBootManagerLib/PlatformBm.c| 62
>
1001 - 1100 of 5714 matches
Mail list logo
