Re: [edk2] [Patch 1/2] MdeModulePkg: Check received packet size before use it.

eems as if this bit is enabled for this PCD in OvmfPkg*.dsc. Ah perfect, thank you for putting this together for me! I did look at CoreFreePoolI(), but I missed the DEBUG_CLEAR_MEMORY() macro invocation. Thanks! Laszlo > > Thanks, > Sriram. > > -Original Message- >

Re: [edk2] [PATCH] MdeModulePkg: DxeUdpIoLib: fix non-empty payload path in UDP reception

lso very simple) with your R-b: 166a6552a829. Thanks! Laszlo > -Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Sunday, April 3, 2016 3:44 PM > To: edk2-devel-01 <edk2-de...@ml01.01.org> > Cc: Siyuan Fu <siyuan...@intel.com>; Jiaxin

Re: [edk2] [wave 3 PATCH 06/15] OvmfPkg: IndustryStandard: add definitions from the VirtIo 1.0 spec

On 04/05/16 09:03, Jordan Justen wrote: > On 2016-03-14 05:53:23, Laszlo Ersek wrote: >> These header files are intentionally minimal, and intentionally kept apart >> from the VirtIo 0.9.5 headers. >> >> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> >> Cc: J

Re: [edk2] [PATCH v2] Merge 2-clause BSD licensed FatPkg

; > Cc: Andrew Fish <af...@apple.com> > Cc: Leif Lindholm <leif.lindh...@arm.com> > Cc: Laszlo Ersek <ler...@redhat.com> > > * Dropped 3b073bba550e54ebdd6fbc13cb2cedc74757bac9 and >b36c76fc3dab6c4a8782406b53a2b5d1134ddfd0 FatPkg patches. > > * In

[edk2] [PATCH 0/2] OvmfPkg, ArmVirtPkg: disable PcdHiiOsRuntimeSupport

The patches say it all. Cc: Jordan Justen <jordan.l.jus...@intel.com> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> Thanks Laszlo Laszlo Ersek (2): OvmfPkg: disable PcdHiiOsRuntimeSupport ArmVirtPkg: disable PcdHiiOsRuntimeSupport ArmVirtPkg/ArmVirt.dsc.inc | 1 + OvmfPkg/Ovm

Re: [edk2] [Patch v2 0/3] HTTP Boot to RAM Disk

On 03/30/16 02:14, Ni, Ruiyu wrote: >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Tuesday, March 29, 2016 11:40 PM >> To: Ni, Ruiyu <ruiyu...@intel.com> >> Cc: edk2-de...@ml01.01.org; Justen, Jordan L <jordan.l.jus.

Re: [edk2] [PATCH] OvmfPkg: Add RAM disk support

On 03/22/16 01:13, Paulo Alcantara wrote: > Hi Jordan, > > On Mon, Mar 21, 2016 at 8:24 PM, Jordan Justen > <jordan.l.jus...@intel.com> wrote: >> On 2016-03-21 01:02:53, Laszlo Ersek wrote: >>> On 03/20/16 17:58, Paulo Alcantara wrote: >>>> This patch

Re: [edk2] [PATCH 00/62] Add FatPkg with 2-clause BSD license

On 03/30/16 03:10, Jordan Justen wrote: > I don't think sending all 62 patches will be useful (but, I can easily > send them out if requested). Instead, the patches are available at: > > web: https://github.com/jljusten/edk2/tree/fatpkg-open-source-v1 > > git:

Re: [edk2] Tianocore Community Update - March 30, 2016

On 03/30/16 04:40, Mangefeste, Tony wrote: > Good morning from Taipei! > > I'd like to take this opportunity to bring you all up to date one > several developments. > > This morning, I'll be giving a state of the Tianocore program to the > UEFI Plugfests. Please see the attached Roadmap update.

Re: [edk2] [PATCH 0/2] Ensure write-through behavior for Scsi & NvmE devices

st specifies DPO / FUA anyway. Thanks Laszlo > Thanks > Feng > > -Original Message- > From: Wu, Hao A > Sent: Wednesday, March 30, 2016 3:12 PM > To: Laszlo Ersek <ler...@redhat.com>; edk2-de...@ml01.01.org; Tian, Feng > <feng.t...@intel.com> > Cc: P

[edk2] [PATCH 1/2] OvmfPkg: disable PcdHiiOsRuntimeSupport

vel/7626>), which is why we can set it now to FALSE. Cc: Jordan Justen <jordan.l.jus...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- OvmfPkg/OvmfPkgIa32.dsc| 1 + OvmfPkg/OvmfPkgIa32X64.dsc | 1 + Ov

[edk2] [PATCH 2/2] ArmVirtPkg: disable PcdHiiOsRuntimeSupport

vel/7626>), which is why we can set it now to FALSE. Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- ArmVirtPkg/ArmVirt.dsc.inc | 1 + 1 file changed, 1 insertion(+) di

Re: [edk2] [Patch] Revert "TerminalDxe: select the UART's default receive FIFO depth"

as the default receive > FIFO depth. > > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Heyi Guo <heyi@linaro.org> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > MdeModulePkg/Universal/Conso

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 03/31/16 15:37, Michael Brown wrote: > On 31/03/16 11:13, Laszlo Ersek wrote: >> Which translates to the following response string: >> >> GUID===> hex number>&=&=&...&= >> >> In a nutshell, I think iPXE should: >> - reflect the GUID /

Re: [edk2] [PATCH 00/62] Add FatPkg with 2-clause BSD license

ort, because in the port, all UNI files use CRLF out of the box (beyond being encoded in UTF-8, and referencing the 2-clause BSDL as well). series Acked-by: Laszlo Ersek <ler...@redhat.com> Thanks! Laszlo > > Cc: Mark Doran <mark.do...@intel.com> > Cc: Andrew Fish <a

Re: [edk2] EDK2 Python issue with QEMU

On 03/31/16 16:09, Daryl McDaniel wrote: > OK. Let’s see how much, if any, of Python might be working. > > Try: > > python –h > python –V > python –E –S –c print “It’s alive.” > > If those three commands work, next try: > > python –E –S > > Sorry, but I have to ask this: > > Do you

Re: [edk2] Recommend platforms for doing Intel UEFI driver development

ual disk image again and again. Thanks Laszlo > > Thanks for the pointers, > > Patrick > > > From: Laszlo Ersek <ler...@redhat.com> > Sent: Thursday, March 31, 2016 12:34 PM > To: Mahan, Patrick > Cc: edk2-devel@lists.01.org; Alex

Re: [edk2] [PATCH 0/2] Ensure write-through behavior for Scsi & NvmE devices

On 03/28/16 05:38, Hao Wu wrote: > The patch series will ensure write-through behavior for the write commands > sent to Scsi (USB devices also included) and NvmE devices in the pre-boot > environment. > > Hao Wu (2): > MdeModulePkg NvmExpressDxe: Ensure write-through for NvmE write >

Re: [edk2] Using multiple SNP drivers on Shell

On 04/04/16 19:38, Bhupesh Sharma wrote: >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Monday, April 04, 2016 11:06 PM >> >> On 04/04/16 19:24, David Van Arnem wrote: >>> On 04/04/2016 03:17 AM, Laszlo Ersek wrote: >> >>>> The most re

Re: [edk2] Using multiple SNP drivers on Shell

On 04/04/16 19:24, David Van Arnem wrote: > On 04/04/2016 03:17 AM, Laszlo Ersek wrote: >> The most recent version (that I have) of the Shell Spec is 2.2. That >> version lists both "ping" and "ping6", and the synopsis for "ping" is: >> >

Re: [edk2] EDK2 Staging Proposal 3rd draft, final?

On 03/18/16 13:43, David Woodhouse wrote: > On Fri, 2016-03-18 at 13:30 +0100, Laszlo Ersek wrote: >> >> Our workflow should not be centered on github pull requests in any case, >> so I don't see the point in testing them out. > > Well, thanks for destroying the test I

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD

On 03/23/16 09:33, Ni, Ruiyu wrote: > Laszlo, > Since the patch below lets SerialDxe driver use the new introduced > PCD gEfiMdePkgTokenSpaceGuid.PcdUartDefaultReceiveFifoDepth. > Would you mind to revert the check in @ 31ae446b > --> MdeModulePkg: TerminalDxe: select the UART's default receive

Re: [edk2] [PATCH] OvmfPkg: Add RAM disk support

On 03/22/16 00:24, Jordan Justen wrote: > On 2016-03-21 01:02:53, Laszlo Ersek wrote: >> On 03/20/16 17:58, Paulo Alcantara wrote: >>> This patch adds RamDiskDxe driver to OVMF through a new introduced flag >>> "RAMDISK_SUPPORT_ENABLE" which is d

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 03/31/16 06:43, Michael Brown wrote: > On 31/03/16 02:17, Dong, Eric wrote: >>> Those sections of the UEFI spec are so badly written that I cannot begin >>> to guess what might count as either correct or incorrect. >>> >>> Could you please give a concrete example of what you think iPXE should

Re: [edk2] Recommend platforms for doing Intel UEFI driver development

On 03/31/16 20:52, Mahan, Patrick wrote: > I believe I have seen this mentioned here before, but I cannot find the > answer via google or gmane. But > there was a developer package that consisted of an Intel motherboard and > software that allowed you to > do UEFI Driver development. Not sure

Re: [edk2] [PATCH 1/2] ArmVirtPkg/VirtFdtDxe: make installation of FDT as config table option

(1) please replace the word "option" with "optional" in the subject On 03/31/16 13:20, Ard Biesheuvel wrote: > The arm64 kernel is hardwired to prefer DT over ACPI, unless 'acpi=force' > is passed on the kernel command line. The only other way to force the > kernel to use ACPI is not to pass an

Re: [edk2] [Patch v2] Revert "TerminalDxe: select the UART's default receive FIFO depth"

On 03/31/16 15:00, Ni, Ruiyu wrote: > Can I take this as the approval of check in? Yes. All three of us (Ard, Ryan, and myself) are okay with this patch. Please make sure you pick up my Acked-by and Ryan's Tested-by. Thanks! Laszlo > > Thanks, > Ray > >> 在 2016年3月31日，下午8

Re: [edk2] [Patch v2] Revert "TerminalDxe: select the UART's default receive FIFO depth"

as the default receive > FIFO depth. > > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Heyi Guo <heyi@linaro.org> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > MdeModulePkg/Universal/Conso

Re: [edk2] [PATCH 2/2] ArmVirtPkg/ArmVirtQemu: allow firmware to be built in ACPI-only mode

On 03/31/16 14:53, Ard Biesheuvel wrote: > On 31 March 2016 at 14:48, Laszlo Ersek <ler...@redhat.com> wrote: >> (4) for the subject of this patch, I would prefer something less >> sensational :), such as >> >> ArmVirtPkg/ArmVirtQemu: gate FDT config table install

Re: [edk2] [PATCH v4 1/9] ArmVirtPkg: implement ArmVirtPL031FdtClientLib

Boot You usually put PcdPureAcpiBoot in a [FeaturePcd] section separately (see again commit cd2178bb73b5, and patch 6/9). Not too important; you can fix it up before pushing the series, or maybe not at all (as you like). The code itself (that I snipped) correctly uses FeaturePcdGet(). Reviewed-by:

Re: [edk2] [PATCH v4a] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

L|ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.inf > + } >EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf > >MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf > Reviewed-by: Laszlo Ersek <ler...@redhat.com> ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v4a] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 04/13/16 17:13, Ard Biesheuvel wrote: > On 13 April 2016 at 17:07, Ard Biesheuvel wrote: >> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no >> longer have to rely on VirtFdtDxe to execute first and set the PL031 base >> address in a dynamic

Re: [edk2] [PATCH v3 8/9] ArmVirtPkg/ArmVirtXen: move from VirtFdtDxe to new XenioFdtDxe driver

->LocateProtocol (, NULL, > + (VOID **)); > + ASSERT_EFI_ERROR (Status); > + > + Status = FdtClient->FindCompatibleNodeReg (FdtClient, "xen,xen", > +(CONST VOID **), , ); Can you add error handling here? I think you can emit

Re: [edk2] [PATCH] ArmVirtPkg/RelocatableVirtHelper: use correct FindMemNode argument order

On 04/13/16 15:27, Ard Biesheuvel wrote: > On 13 April 2016 at 14:14, Laszlo Ersek <ler...@redhat.com> wrote: >> On 04/13/16 13:49, Ard Biesheuvel wrote: >>> Commit 03b6bed17ea6 ArmVirtPkg/XenRelocatablePlatformLib: rewrite DTB >>> memory node retrieval in

Re: [edk2] [PATCH v3 9/9] ArmVirtPkg/VirtFdtDxe: remove Xenio handling and rename to VirtioFdtDxe

; +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -300,7 +300,7 @@ [Components.common] ># ># Platform Driver ># > - ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf > + ArmVirtPkg/VirtioFdtDxe/VirtioFdtDxe.inf >ArmVirtPkg/FdtClientDxe/FdtClientDxe.inf >OvmfPkg/VirtioBlkDxe/VirtioBlk.inf >OvmfPkg/VirtioScsiDxe/VirtioScsi.inf > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.fdf > b/ArmVirtPkg/ArmVirtQemuKernel.fdf > index b8f66d2f472c..7c478340f9e7 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.fdf > +++ b/ArmVirtPkg/ArmVirtQemuKernel.fdf > @@ -125,7 +125,7 @@ [FV.FvMain] > >INF MdeModulePkg/Core/Dxe/DxeMain.inf >INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf > - INF ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf > + INF ArmVirtPkg/VirtioFdtDxe/VirtioFdtDxe.inf >INF ArmVirtPkg/FdtClientDxe/FdtClientDxe.inf > ># > Going over my requests (1) through (6) again, they are all one-liner changes. With them addressed: Reviewed-by: Laszlo Ersek <ler...@redhat.com> Thanks! Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v4 2/9] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 04/13/16 16:54, Ard Biesheuvel wrote: > On 13 April 2016 at 16:53, Laszlo Ersek <ler...@redhat.com> wrote: >> On 04/13/16 16:32, Ard Biesheuvel wrote: >>> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no >>> longer have to rely on Vi

Re: [edk2] [PATCH v3 1/9] ArmVirtPkg: implement ArmVirtPL031FdtClientLib

On 04/13/16 15:18, Ard Biesheuvel wrote: > On 13 April 2016 at 14:16, Laszlo Ersek <ler...@redhat.com> wrote: >> On 04/13/16 10:02, Ard Biesheuvel wrote: >>> This implements a library ArmVirtPL031FdtClientLib which is intended to >>> be incorporated into RealTim

Re: [edk2] [PATCH v4 2/9] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 04/13/16 16:32, Ard Biesheuvel wrote: > This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no > longer have to rely on VirtFdtDxe to execute first and set the PL031 base > address in a dynamic PCD. > > The only driver which [transitively] depends on this PcdPL031RtcBase

Re: [edk2] [PATCH v4a] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 04/13/16 17:17, Laszlo Ersek wrote: > On 04/13/16 17:07, Ard Biesheuvel wrote: >> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no >> longer have to rely on VirtFdtDxe to execute first and set the PL031 base >> address in a dynamic PCD. >&g

Re: [edk2] [PATCH v4a] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 04/13/16 17:34, Ard Biesheuvel wrote: > On 13 April 2016 at 17:29, Laszlo Ersek <ler...@redhat.com> wrote: >> On 04/13/16 17:17, Laszlo Ersek wrote: >>> On 04/13/16 17:07, Ard Biesheuvel wrote: >>>> This moves QEMU based platforms to ArmVirtPL031FdtClien

Re: [edk2] [Patch v2] BaseTools: fix the bug for [BuildOptions] of multiple workspace support

On 04/13/16 11:47, Yonghong Zhu wrote: > when enable Multiple workspace and there have other option(eg: -I) before > $(WORKSPACE), handleWsMacro cannot return correct which cause the > ArmVirtPkg build failure. > example: > [BuildOptions] > *_*_AARCH64_PLATFORM_FLAGS ==

Re: [edk2] [PATCH v2] Ensure write-through behavior for NVMe devices

On 04/14/16 03:13, Hao Wu wrote: > After further investigation of SCSI & NVMe specs, we found that: > > For SCSI devices, there is a 'DPOFUA' bit which is returned in the > DEVICE-SPECIFIC PARAMETER field in response to a MODE SENSE command. This > bit tells whether a SCSI device supports the DPO

Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: Allocate Reserved memory

Gary, On 04/14/16 10:16, Gary Lin wrote: > The memory space for the ramdisk was allocated by AllocatePool() which > allocates the memory in BootServiceData, and then the ramdisk would be > cleared after ExitBootService(). This commit changes the allocated area > to EfiReservedMemoryType so that

Re: [edk2] [Patch v3 02/23] OvmfPkg/PlatformPei: Add memory above 4GB as tested

compared the OVMF logs; there were practically no differences (definitely not in the area where I worried). The amount of RAM seen within the guest OSes was fine as well. For this patch: Tested-by: Laszlo Ersek <ler...@redhat.com> Reviewed-by: Laszlo Ersek <ler...@redhat.com> (2)

Re: [edk2] [PATCH] corrections to use of VA_LIST

On 04/25/16 18:23, Zenith432 wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Zenith432 > --- > MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 ++ > MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 6 -- >

Re: [edk2] [PATCH 00/12] Enhance SMM Communication by using fixed comm buffer.

On 04/25/16 17:17, Yao, Jiewen wrote: > Comments below: > >> -Original Message----- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Monday, April 25, 2016 6:50 PM >> To: Yao, Jiewen <jiewen@intel.com> >> Cc: edk2-de...@ml01.01.org

Re: [edk2] [Patch v3 01/23] MdeModulePkg/UefiBootManagerLib: Expose *GetLoadOptionBuffer() API

On 04/21/16 08:57, Ruiyu Ni wrote: > Expose EfiBootManagerGetLoadOptionBuffer() API. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: L

Re: [edk2] [PATCH] corrections to use of VA_LIST

First, please fix your mail user agent -- emails should be properly threaded. (For the archive: this was in response to <http://thread.gmane.org/gmane.comp.bios.edk2.devel/11175/focus=11177>.) On 04/25/16 20:24, Zenith432 wrote: > On 25/04/2016 08:03 PM, Laszlo Ersek wrote: >> Sec

Re: [edk2] [Patch v3 02/23] OvmfPkg/PlatformPei: Add memory above 4GB as tested

On 04/28/16 03:59, Ni, Ruiyu wrote: > > > Regards, > Ray > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Tuesday, April 26, 2016 5:27 AM >> To: Ni, Ruiyu <ruiyu...@intel.com> >> Cc: edk2-de...@ml01.

Re: [edk2] [PATCH 1/3] MdeModulePkg: PiDxeS3BootScriptLib: honor PcdAcpiS3Enable

e. I'll keep that in mind for any further library instances we might write. > That does not mean that you should add one in this case though... > > Reviewed-by: Jaben Carsey <jaben.car...@intel.com> Thank you! Laszlo >> -Original Message- >> From: Laszlo Ersek [

Re: [edk2] [Patch v3 04/23] OvmfPkg/QemuNewBootOrderLib: Build with UefiBootManagerLib

On 04/28/16 04:16, Ni, Ruiyu wrote: >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Tuesday, April 26, 2016 11:02 PM >> To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-de...@ml01.01.org >> Cc: Justen, Jordan L <jordan.l.

Re: [edk2] OVMF broken under Xen (in PCI initialisation)

On 04/28/16 07:08, Ni, Ruiyu wrote: Do you know whether Xen passes the PCI device resource information to firmware? >> >> I don't think so, no. >> >> But, given that the previous PciHostBridgeDxe driver was working on Xen, >> can we perhaps emulate that behavior in >>

Re: [edk2] [PATCH v3 2/2] OvmfPkg: Modify fdf files due to RamDiskDxe driver's adding ASL code

iles in OvmfPkg. > > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Hao Wu <hao.a...@intel.com> > --- > OvmfPkg/OvmfPkgIa32.fdf| 2 ++ > Ov

Re: [edk2] [PATCH v4 2/2] OvmfPkg: Modify FDF/DSC files for RamDiskDxe's adding NFIT report feature

> using ASL code which is put in a Secondary System Description Table (SSDT) > according to the ACPI 6.1 spec. > > Locating the SSDT requires modifying the [Rule.Common.DXE_DRIVER] field in > OVMF FDF files. > > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Jordan Juste

Re: [edk2] [Patch v4 00/23] Use MdeModulePkg/BDS in OVMF platform

On 04/29/16 09:00, Ruiyu Ni wrote: > The patch serials creates a flag USE_OLD_BDS and by default the value > of the flag is FALSE so that the new MdeModulePkg/BDS is used. > User can define USE_OLD_BDS as TRUE to force to use IntelFrameworkModulePkg > /BDS. > > The v3 adopts comments for v1 and

Re: [edk2] [PATCH] SecurityPkg: Reduce DEBUG verbosity in Tcg2Dxe

On 04/29/16 13:09, Derek Lin wrote: > Reduce several DEBUG messages verbosity from INFO to VERBOSE, so that will > not see debug message around each driver loading when TPM 2.0 part present. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Derek Lin

Re: [edk2] [Patch v3 14/23] OvmfPkg/PlatformBds: Remove unused local functions.

On 04/21/16 08:58, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > .../Library/Platfor

Re: [edk2] [Patch v3 15/23] OvmfPkg/PlatformBds: Change PlatformBdsConnectSequence()

yu...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) Please change the

Re: [edk2] [Patch v3 17/23] OvmfPkg/PlatformBds: Remove PlatformBdsGetDriverOption()

On 04/21/16 08:58, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > .../Library/Platfor

Re: [edk2] [Patch v3 19/23] OvmfPkg/PlatformBds: Remove unnecessary memory test

On 04/21/16 08:58, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > .../Library/Platfor

Re: [edk2] [Patch v3 16/23] OvmfPkg/PlatformBds: Use EfiBootManagerRefreshAllBootOption()

gned-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 11 +++ > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatf

Re: [edk2] [Patch v3 13/23] OvmfPkg/PlatformBds: Register boot options and hot keys.

d-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > .../Library/PlatformBootManagerLib/BdsPlatform.c | 71 > ++ > .../Library/PlatformBootManagerLib/BdsPlat

Re: [edk2] [Patch v3 12/23] OvmfPkg/PlatformBds: Do not launch Boot Manager Menu

On 04/21/16 08:58, Ruiyu Ni wrote: > MdeModulePkg/BDS doesn't launch UI (Boot Manager Menu) from platform > side. > The change removes the code which launches the UI and but still set > the boot timeout. I think the word "and" should be dropped. Reviewed-by: Laszlo Er

Re: [edk2] [PATCH] SecurityPkg/DxeImageVerificationLib: Add DEBUG messages for image verification failures

On 04/26/16 09:02, Cinnamon Shia wrote: > Add DEBUG messages in DxeImageerificationLib to help debug Secure Boot image > verification failures > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Cinnamon Shia > Reviewed-by: Samer EL-Haj-Mahmoud

Re: [edk2] [PATCH] SecuritPkg: DxeImageVerificationLib: Fix wrong verification logic in DBX & DBT

egards > Chao Zhang > > > -Original Message- > From: Mangefeste, Tony > Sent: Saturday, April 16, 2016 12:02 AM > To: Peter Jones; Dick Wilkins > Cc: edk2-de...@ml01.01.org; Kevin Davis; Laszlo Ersek; Zhang, Chao B; Long, > Qin > Subject: RE: [edk2] [PATC

Re: [edk2] A logic error in OvmfPkg\SataControllerDxe\SataController.c

On 04/26/16 09:28, Ni, Ruiyu wrote: > Adding Laszlo & Jordan, > It sounds like a trivial bug. Sigh. This is my mess, from commit bcab71413407e. Thanks for the report, I'll fix it up soon. :( Thanks Laszlo >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]

Re: [edk2] [PATCH] ArmPlatformPkg: implement CpuIo2 protocol driver specific for PCI

On 04/27/16 17:44, Leif Lindholm wrote: > On Wed, Apr 27, 2016 at 02:58:29PM +0200, Ard Biesheuvel wrote: >> The CpuIo2 protocol is required by the generic PciHostBridgeDxe driver, >> which relies on it to back its own I/O and MMIO operations. >> >> Since ARM has no native I/O port equivalent,

[edk2] [PATCH 3/3] OvmfPkg: PlatformBdsLib: lock down SMM regardless of S3

om> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c | 29 +++- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c

[edk2] [PATCH 0/3] OvmfPkg: tighten the SMM lockdown

The first patch (for MdeModulePkg) fixes a bug that is exposed (triggered) by the third patch. The second and third patches fix a security vulnerability in OVMF that I reported to the UEFI SRT more than three weeks ago: To: secur...@uefi.org, secal...@redhat.com [...] From: Laszlo Ersek <

[edk2] [PATCH 1/3] MdeModulePkg: PiDxeS3BootScriptLib: honor PcdAcpiS3Enable

.@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- MdeModulePkg/Library/PiDxeS3BootScriptLib/DxeS3BootScriptLib.inf | 1 + MdeModulePkg/Library/PiDxeS3BootScriptLib/BootScriptSave.c | 4 2 files changed, 5 i

[edk2] [PATCH 2/3] OvmfPkg: PlatformBdsLib: lock down SMM in PlatformBdsInit()

Jiewen Yao <jiewen@intel.com> Cc: Jordan Justen <jordan.l.jus...@intel.com> Cc: Ruiyu Ni <ruiyu...@intel.com> Cc: Star Zeng <star.z...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- OvmfPkg/Libr

Re: [edk2] [Patch v3 11/23] OvmfPkg/PlatformBds: Initialize console variables in *BeforeConsole()

erBeforeConsole() and removes the console > connection code. > It also removes unused functions: PlatformBdsNoConsoleAction() > and LockKeyboards(). > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jordan Juste

Re: [edk2] [Patch v3 03/23] OvmfPkg: Duplicate QemuBootOrderLib to QemuNewBootOrderLib

On 04/21/16 08:57, Ruiyu Ni wrote: > QemuNewBootOrderLib will be changed to work with MdeModulePkg/BDS. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: L

Re: [edk2] [PATCH] SecurityPkg/DxeImageVerificationLib: Add DEBUG messages for image verification failures

yStatus.) Thanks Laszlo > > Thanks, > Cinnamon Shia > > -----Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, April 26, 2016 7:10 PM > To: Shia, Cinnamon <cinnamon.s...@hpe.com>; edk2-de...@ml01.01.org > Cc: El-Haj-Mahmoud, Samer

[edk2] [PATCH 1/2] OvmfPkg: SataControllerDxe: SataControllerStop: remove useless null check

"ASSERT (SataPrivateData != NULL)" is just a few lines higher up. Cc: Jordan Justen <jordan.l.jus...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- OvmfPkg/SataControllerDxe/SataController.c | 20 ++

[edk2] [PATCH 0/2] OvmfPkg: fix use-after-free in SataControllerStop()

dan.l.jus...@intel.com> Cc: Ruiyu Ni <ruiyu...@intel.com> Laszlo Ersek (2): OvmfPkg: SataControllerDxe: SataControllerStop: remove useless null check OvmfPkg: SataControllerDxe: SataControllerStop: fix use after free OvmfPkg/SataControllerDxe/SataController.c | 37 +++---

[edk2] [PATCH 2/2] OvmfPkg: SataControllerDxe: SataControllerStop: fix use after free

-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- OvmfPkg/SataControllerDxe/SataController.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/OvmfPkg/SataControllerDxe/SataController.c b/OvmfPkg/Sata

Re: [edk2] [Patch v3 04/23] OvmfPkg/QemuNewBootOrderLib: Build with UefiBootManagerLib

t 1.0 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > .../Library/QemuNewBootOrderLib/QemuBootOrderLib.c | 134 > - > .../QemuNewBootOrderLib/Q

Re: [edk2] [Patch v3 06/23] OvmfPkg/PlatformBds: Rename INF file

On 04/21/16 08:57, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > .../PlatformBootMan

Re: [edk2] [PATCH v3] SecurityPkg/DxeImageVerificationLib: Add DEBUG messages for image verification failures

thers. But, I'm willing to give an: Acked-by: Laszlo Ersek <ler...@redhat.com> Also, I think Samer should re-review this patch (v3). Thanks! Laszlo > diff --git > a/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c > b/SecurityPkg/Library/DxeImageVerificationLib/

Re: [edk2] Questions on write access to edk2-staging

>> El-Haj-Mahmoud, >> Samer >> Sent: Tuesday, April 26, 2016 9:35 AM >> To: edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com>; >> Mangefeste, Tony <tony.mangefe...@intel.com>; Andrew Fish <af...@apple.com>; >> Laszlo >

Re: [edk2] Minor problems with dualboot VM. EFIVars?

On 04/27/16 11:52, Blank Field wrote: > And i've thought that efivars on a physical platform are located > somewhere in a separate chip on the motherboard. Why i've found it on > the ESP? Because your VM configuration is incorrect (you didn't configure two pflash chips, one for storing the UEFI

Re: [edk2] OVMF broken under Xen (in PCI initialisation)

On 04/27/16 11:50, Ni, Ruiyu wrote: > Copying Mike. > > Regards, > Ray > >> -Original Message- >> From: Ni, Ruiyu >> Sent: Wednesday, April 27, 2016 5:49 PM >> To: 'Gary Lin' <g...@suse.com> >> Cc: edk2-devel@lists.01.org; Xen Dev

Re: [edk2] Minor problems with dualboot VM. EFIVars?

On 04/27/16 12:43, Blank Field wrote: >> Because your VM configuration is incorrect (you didn't configure two >> pflash chips, one for storing the UEFI variables, another (r/o) for >> presenting the firmware binary). Hence OVMF fell back to the historical >> hack where it stored (some of) the UEFI

Re: [edk2] Minor problems with dualboot VM. EFIVars?

On 04/27/16 11:13, Laszlo Ersek wrote: > On 04/27/16 01:51, Blank Field wrote: >> Hi. I am attempting to rebuild my system with a host EFI bootloader, >> namely GRUB. >> I did a fresh install of F23(i've found that way easier than figuring >> out how to migrate to EFI)

Re: [edk2] [Patch v3 00/23] Use MdeModulePkg/BDS in OVMF platform

lessons learned here. Thanks Laszlo > On Wed, Apr 27, 2016 at 3:32 AM, Andrew Fish <af...@apple.com > <mailto:af...@apple.com>> wrote: > > > > On Apr 26, 2016, at 8:58 AM, Laszlo Ersek <ler...@redhat.com > <mailto:ler...@redhat.com>> wrote

Re: [edk2] Minor problems with dualboot VM. EFIVars?

On 04/27/16 01:51, Blank Field wrote: > Hi. I am attempting to rebuild my system with a host EFI bootloader, > namely GRUB. > I did a fresh install of F23(i've found that way easier than figuring > out how to migrate to EFI), turned off my CSM in host UEFI setup, got > my windows exVM booting in

Re: [edk2] [Patch v3 09/23] OvmfPkg/PlatformBds: link to UefiBootManagerLib

On 04/21/16 08:57, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > OvmfPkg/Library/

Re: [edk2] [Patch v3 10/23] OvmfPkg/PlatformBds: Use ConvertDevicePathToText in DevicePathLib

On 04/21/16 08:58, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > OvmfPkg/Library/

Re: [edk2] [Patch v3 08/23] OvmfPkg/PlatformBds: use EfiBootManagerUpdateConsoleVariable

i <ruiyu...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > .../Library/PlatformBootManagerLib/BdsPlatform.c | 32 > +++--- > 1 file changed, 16 insertions(+), 16 deletions(-) I se

Re: [edk2] [Patch v3 07/23] OvmfPkg/PlatformBds: Follow PlatformBootManagerLib interfaces

On 04/21/16 08:57, Ruiyu Ni wrote: > Change the function name to follow new library class > PlatformBootManagerLib interfaces. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jordan Justen <jordan.l.jus

Re: [edk2] [PATCH] ArmPlatformPkg: implement CpuIo2 protocol driver specific for PCI

On 04/27/16 14:58, Ard Biesheuvel wrote: > The CpuIo2 protocol is required by the generic PciHostBridgeDxe driver, > which relies on it to back its own I/O and MMIO operations. > > Since ARM has no native I/O port equivalent, such accesses can only originate > from PCI drivers, and the PCI I/O

Re: [edk2] [PATCH 00/12] Enhance SMM Communication by using fixed comm buffer.

o assume that VariableSmmRuntimeDxe conforms to the above requirement, without any modifications? Thanks Laszlo > Cc: "Gao, Liming" <liming@intel.com> > Cc: "Tian, Feng" <feng.t...@intel.com> > Cc: "Zeng, Star" <star.z...@intel.com> > Cc:

Re: [edk2] Csm16.bin(seabios) failed to work in OVMF.

On 04/23/16 08:39, wq...@aliyun.com wrote: > Hi everyone, > I build the Csm16.bin from source code of seabios-1.9.2.tar.gz . And copy > the Csm16.bin to OvmfPkg/Csm/Csm16/Csm16.bin , Build the OVMF_CODE.fd and > OVMF_VARS.fd with command build -D CSM_ENABLE. >Unfortunately, I test the

Re: [edk2] [Patch v3 23/23] OvmfPkg: Use MdeModulePkg/BDS

> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > OvmfPkg/OvmfPkgIa32.dsc| 45 ++-- > OvmfPkg/OvmfPkgIa32.fdf| 5 + > OvmfPkg/OvmfPkgIa32X64.dsc | 47 > +++

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: don't create bogus descriptor if no resources needed

On 04/28/16 17:51, Ard Biesheuvel wrote: > If the current PCI configuration requires no resources to be allocated at > all (i.e., unpopulated bus), the PCI enumeration code creates a single > ACPI_ADDRESS_SPACE_DESCRIPTOR memory descriptor with all fields cleared. > This is rejected by the

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: don't create bogus descriptor if no resources needed

On 04/28/16 18:09, Ard Biesheuvel wrote: > On 28 April 2016 at 18:06, Laszlo Ersek <ler...@redhat.com> wrote: >> On 04/28/16 17:51, Ard Biesheuvel wrote: >>> If the current PCI configuration requires no resources to be allocated at >>> all (i.e., unpopulated bus),

Re: [edk2] [Patch v3 22/23] OvmfPkg/PlatformBds: Remove unused C structures definitions.

On 04/21/16 08:58, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > .../Library/Platfor

Re: [edk2] [Patch v3 20/23] OvmfPkg/PlatformBds: Remove unused variables and function prototypes.

On 04/21/16 08:58, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > OvmfPkg/Library/Platfo

Re: [edk2] [Patch v3 21/23] OvmfPkg/PlatformBds: Add EnableQuietBoot and DisableQuietBoot

gned-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > .../Library/PlatformBootManagerLib/BdsPlatform.h | 33 + > .../PlatformBootManagerLib.inf | 3 + > Ov

<    10   11   12   13   14   15   16   17   18   19   >