There are VS2015 NOOPT IA32 build failure like below in IntelVTdDxe.
XXX.lib(XXX.obj) : error LNK2001: unresolved external symbol __allshl
XXX.lib(XXX.obj) : error LNK2001: unresolved external symbol __aullshr
This patch is to update Vtd.h to use UINT32 instead of UINT64 for
bitfields in structure
This patch is breaking the GCC build:
ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c:
In function 'GetImageNameFromHandle':
220:25: error: passing argument 3 of 'gBS->HandleProtocol' from
incompatible pointer type [-Werror]
220:25: note: expected 'void **' but argument is of type 'struct
Series Reviewed-by: Ye Ting
-Original Message-
From: Wu, Jiaxin
Sent: Wednesday, July 26, 2017 2:28 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin
Subject: [Patch 0/3] Support Ip4Config2/Ip6Config.SetData interface to clear
specific configuration
UEFI Spec 2.7
Add a new feature to UPT to support installing
multiple DIST packages in one time.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: hesschen
---
.../Source/Python/UPT/Core/DependencyRules.py | 18 -
.../Python/UPT/GenMetaFile/GenMetaFileMisc.py | 90 ++
On Wed, Aug 09, 2017 at 12:39:57PM -0700, Michael D Kinney wrote:
> The following commit moved the QuarkSocBinPkg from the root
> directory to the the Silicon/Intel directory.
>
> https://github.com/tianocore/edk2-non-osi/commit/182e85d04566800fe188de4b1c30a50533dd74b7
>
> The following updates a
From: Bin Wang
when the UI string is read from files, we don't need to add the extra
quotes. Otherwise, it will cause UI name has this extra quotes.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bin Wang
---
BaseTools/Source/Python/Gen
On 08/09/17 19:51, Andrew Fish wrote:
>
>> On Aug 9, 2017, at 10:33 AM, Laszlo Ersek wrote:
>>
>> On 08/09/17 17:45, Andrew Fish wrote:
>>>
On Aug 9, 2017, at 2:44 AM, Laszlo Ersek wrote:
CC Ard and Andrew
On 08/08/17 21:31, Paulo Alcantara wrote:
> By defining this
On 08/10/17 00:44, Brijesh Singh wrote:
>
>
> On 08/09/2017 05:38 PM, Laszlo Ersek wrote:
>> On 08/07/17 13:58, Brijesh Singh wrote:
>>> Currently, virtio drivers provides the system physical address to the
>>> device.
>>> However, some systems may feature an IOMMU that requires the drivers
>>> t
At a quick glance, the fix should probably be
diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c
b/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c
index 4d876bb108..26b785c563 100644
--- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c
+++ b/ShellPkg/Library/UefiShe
On 08/10/17 03:03, Andrew Fish wrote:
> It looks to me like if you Free pages, after you free pages you hit this
> DEBUG message.
>
>
> https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Dxe/Mem/Page.c#L790
>
> if (!(NewType == EfiConventionalMemory ? 1 : 0) ^ (Entry->Type =
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Thursday, August 3, 2017 5:00 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Andrew Fish
> ; Gao, Liming
> Subject: [edk2] [Patch V2
Andrew:
If this is a mtoc bug, I suggest to update GenFw to always correct it in the
generated EFI image. If so, the EFI image is always correct. There is no change
requirement in PeCoff library in MdePkg.
Thanks
Liming
From: af...@apple.com [mailto:af...@apple.com]
Sent: Tuesday, August 8, 20
Marvin:
I have no other comments. Reviewed-by: Liming Gao
Thanks
Liming
> -Original Message-
> From: Marvin Häuser [mailto:marvin.haeu...@outlook.com]
> Sent: Friday, August 4, 2017 3:52 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: [PATCH v3 1/2]
Reviewed-by: Liming Gao
> -Original Message-
> From: Zhu, Yonghong
> Sent: Thursday, August 3, 2017 5:00 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Kinney, Michael D
> ; Andrew Fish
> Subject: [Patch V2 4/4] MdePkg: Fix Xcode 9 Beta treating 32-bit left shift
> as undefined
>
Reviewed-by: Liming Gao
> -Original Message-
> From: Zhu, Yonghong
> Sent: Thursday, August 3, 2017 5:00 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Kinney, Michael D
> ; Fan, Jeff ; Andrew
> Fish
> Subject: [Patch V2 3/4] IntelFrameworkModulePkg: Fix Xcode 9 Beta treating
> 3
Reviewed-by: Ye Ting
-Original Message-
From: Wu, Jiaxin
Sent: Tuesday, August 08, 2017 3:25 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Bi, Dandan ; Wu, Jiaxin
Subject: [Patch] NetworkPkg/HttpBootDxe: Refine the coding style.
Cc: Ye Ting
Cc: Bi Dandan
Contributed-under: TianoCor
On Wed, Aug 09, 2017 at 06:39:23PM +0800, Jun Nie wrote:
> Add an android kernel loader that could load kernel from storage
> device.
> This android boot image BDS add addtitional cmdline/dtb/ramfs
> support besides kernel that is introduced by Android boot header.
>
> This patch is derived from H
Hi Jiaxin,
I think it might be better to use >= to reject other invalid value of HTTP
version. Any different opinion?
Thanks,
Ting
-Original Message-
From: Wu, Jiaxin
Sent: Wednesday, August 09, 2017 10:36 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Jin, Eric ; Wu, Jiaxin
Subject:
You've reworked this to be targeted for edk2-platforms, which is
excellent! However:
- Please update subject line to match.
- Please also cc edk2-devel@lists.01.org (since you are with Linaro,
it makes sense to still cc linaro-uefi)
To get the appropriate subject line for edk2-devel, as desribed
This patch is not integrated into edk2 trunk. Could you file this issue in
bugzillar (https://bugzilla.tianocore.org/) and attach this patch? We will add
it into edk2 trunk.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tomas
> Pilar (tpi
On Wed, Aug 09, 2017 at 10:12:37PM +0800, Jun Nie wrote:
> Runtime service is not supported yet.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jun Nie
> ---
> .../Zx6718RealTimeClockLib/Zx296718RealTimeClock.c | 376
> +
> .../Zx6718RealTimeClo
Thanks for the CC
On 08/10/17 15:04, Leif Lindholm wrote:
> You've reworked this to be targeted for edk2-platforms, which is
> excellent! However:
> - Please update subject line to match.
> - Please also cc edk2-devel@lists.01.org (since you are with Linaro,
> it makes sense to still cc linaro-u
On Wed, Aug 09, 2017 at 10:12:38PM +0800, Jun Nie wrote:
> Add boot manager lib and entries, including Android and Grub.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jun Nie
> ---
> .../Drivers/Zx296718EvbDxe/Zx296718EvbDxe.c| 105 ++
> .../Drivers/Zx2
On Wed, Aug 09, 2017 at 10:12:39PM +0800, Jun Nie wrote:
> Add platform build system files, including *.dsc *.fdf *.dec
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jun Nie
> ---
> Platform/Sanchip/Zx296718Evb/Zx296718Evb.dec | 33 ++
> Platform/Sanchip/Zx296718E
Just another thought.
On Wed, Aug 09, 2017 at 10:12:37PM +0800, Jun Nie wrote:
> diff --git
> a/Silicon/Sanchip/Library/Zx6718RealTimeClockLib/Zx296718RealTimeClock.h
> b/Silicon/Sanchip/Library/Zx6718RealTimeClockLib/Zx296718RealTimeClock.h
> new file mode 100644
> index 000..3b5a4d4
> ---
Reviewed by: Kelly Steele
-Original Message-
From: Kinney, Michael D
Sent: August 09, 2017 12:40
To: edk2-devel@lists.01.org
Cc: Leif Lindholm ; Steele, Kelly
; Gao, Liming
Subject: [Patch 0/2] Update Quark for edk2-non-osi changes
Update PACKAGES_PATH requirements Readme.md to match
Reviewed by: Kelly Steele
-Original Message-
From: Kinney, Michael D
Sent: August 09, 2017 12:40
To: edk2-devel@lists.01.org
Cc: Leif Lindholm ; Steele, Kelly
Subject: [Patch 2/2] QuarkPlatformPkg/Readme.md: edk2-non-osi directory layout
The following commit moved the QuarkSocBinPkg
Reviewed by: Kelly Steele
-Original Message-
From: Kinney, Michael D
Sent: August 09, 2017 12:40
To: edk2-devel@lists.01.org
Cc: Steele, Kelly ; Gao, Liming
Subject: [Patch 1/2] QuarkSocPkg/MemoryInit: Remove use of memset()/memcpy()
Map the use of memset() and memcpy() to the BaseMem
> On Aug 10, 2017, at 3:38 AM, Gao, Liming wrote:
>
> Andrew:
> If this is a mtoc bug, I suggest to update GenFw to always correct it in the
> generated EFI image. If so, the EFI image is always correct. There is no
> change requirement in PeCoff library in MdePkg.
>
Liming,
EFI supports l
On 2017-08-04 13:25:09, Laszlo Ersek wrote:
> >
> > I have another reason why going beyond 80 is not a good idea for code
> > that doesn't apply to normal reading. If you need ~120 columns visible
> > to view some lines, then most lines will end up having a lot of wasted
> > horizontal whitespace
Hi Laszlo,
On 08/09/2017 12:09 PM, Laszlo Ersek wrote:
[Snip]
+
+EFI_STATUS
+EFIAPI
+VirtioPciUnmapSharedBuffer (
+ VIRTIO_DEVICE_PROTOCOL*This,
+ VOID *Mapping
+ )
+{
+ return EFI_SUCCESS;
+}
(9) Please refresh the function signatures in both "VirtioPciDevice.
On 08/10/17 20:41, Brijesh Singh wrote:
> Hi Laszlo,
>
> On 08/09/2017 12:09 PM, Laszlo Ersek wrote:
> [Snip]
>
>>
>>> +
>>> +EFI_STATUS
>>> +EFIAPI
>>> +VirtioPciUnmapSharedBuffer (
>>> + VIRTIO_DEVICE_PROTOCOL*This,
>>> + VOID *Mapping
>>> + )
>>> +{
>>> + return EF
On 08/10/17 20:36, Jordan Justen wrote:
> On 2017-08-04 13:25:09, Laszlo Ersek wrote:
>>>
>>> I have another reason why going beyond 80 is not a good idea for code
>>> that doesn't apply to normal reading. If you need ~120 columns visible
>>> to view some lines, then most lines will end up having a
Also I forgot to mention the double page free was in the DXE Core LoadImage()
on an error path.
CoreLoadPeImage()
...
return EFI_SUCCESS;
Done:
//
// Free memory.
//
if (DstBufAlocated) {
CoreFreePages (Image->ImageContext.ImageAddress, Image->NumberOfPages);
}
...
CoreUnload
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jordan Justen
---
Maintainers.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 9d1b9fb941..a5e2e0af46 100644
--- a/
Although everyone is encouraged to review patches and add their
Reviewed-by reply for a patch, with the Package Reviewer role we
identify additional community members that will be Cc'd for patches
made to a package.
A distinction between a Package Maintainer and Reviewer is that
Maintainers will a
Add note that the Package Maintainer is responsible for reviewing and
pushing package changes to source control.
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jordan Justen
---
Maintainers.txt | 3 ++-
1 file chan
The gBS->CreateEvent expects a EFI_EVENT_NOTIFY function as the third
argument. The EFIAPI token is an important component of that prototype. Its
absence can cause unexpected issues on DEBUG systems built with GCC due to
ABI mismatches.
Both EslTcp4ConnectComplete and EslTcp6ConnectComplete did no
Looks good to me.
Daryl?
> -Original Message-
> From: Thomas Palmer [mailto:thomas.pal...@hpe.com]
> Sent: Thursday, August 10, 2017 3:35 PM
> To: edk2-devel@lists.01.org
> Cc: edk2-li...@mc2research.org; Carsey, Jaben ;
> joseph.shiffl...@hpe.com; Thomas Palmer
> Subject: [PATCH 1/1] St
I don't actually have a strong opinion that the number of maintainers
per package need to be kept at 2, and I'm not sure we have actually
codified that anywhere. But I also don't have any issues with any of
the changes suggested in this series.
So, in order to keep the noise down, for the series:
Series
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Justen, Jordan L
> Sent: Thursday, August 10, 2017 3:11 PM
> To: edk2-devel@lists.01.org
> Cc: Justen, Jordan L ; Andrew Fish
> ; Leif Lindholm ;
> Kinney, Michael D
> Subject: [PATCH 1/3] Maintainers.txt: List Tianocore
Series
Reviewed-by: Andrew Fish mailto:af...@apple.com>>
> On Aug 10, 2017, at 4:13 PM, Kinney, Michael D
> wrote:
>
> Series
>
> Reviewed-by: Michael D Kinney
>
>> -Original Message-
>> From: Justen, Jordan L
>> Sent: Thursday, August 10, 2017 3:11 PM
>> To: edk2-devel@lists.01.or
Hi,
(sorry for the late reply)
On 09/08/2017 22:11, Ni, Ruiyu wrote:
Regards,
Ray
-Original Message-
From: Paulo Alcantara [mailto:pca...@zytor.com]
Sent: Wednesday, August 9, 2017 10:01 PM
To: Ni, Ruiyu ; Zeng, Star ;
edk2-devel@lists.01.org
Cc: Dong, Eric ; Wu, Hao A ; Justen, Jo
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Thursday, August 10, 2017 3:18 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Yao, Jiewen
> Subject: [PATCH] IntelSiliconPkg: Fix VS2015 NOOPT IA32 build failure in
> IntelVTdDxe
>
> There are VS2015 N
Since Giri left Intel, we change 3 Intel*Pkg
maintainer.
Cc: Chasel Chiu
Cc: Amy Chan
Cc: Rangasai V Chaganty
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao
---
Maintainers.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Maintai
Reviewed-by: Michael D Kinney
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On
> Behalf Of Jiewen Yao
> Sent: Thursday, August 10, 2017 5:29 PM
> To: edk2-devel@lists.01.org
> Cc: Chan, Amy
> Subject: [edk2] [PATCH V2] Maintainers.txt: Change maintainer
Several users have recently reported boot failures with OVMF. The symptoms
are: blank screen and all VCPUs pegged at 100%. Alex Williamson has found
the commit (via bisection) that exposes the issue. In this patch I'll
attempt to analyze the symptoms and fix the root problem.
(1) "UefiCpuPkg/Libra
Patch #1 explains it all (grab a coffee first). For testing, it's likely
most robust to run
git clean -fdx
exit
in your terminal, before fetching & checking out my branch, and
rebuilding OVMF.
Repo: https://github.com/lersek/edk2.git
Branch: gcc7_lto
Cc: Alex Williamson
Cc: Ard Biesheuve
Reviewed-by: Rangasai V Chaganty
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney,
Michael D
Sent: Thursday, August 10, 2017 5:32 PM
To: Yao, Jiewen ; edk2-devel@lists.01.org; Kinney,
Michael D
Cc: Chan, Amy
Subject: Re: [edk2] [PATCH V2
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong
Zhu
Sent: Thursday, August 10, 2017 4:58 PM
To: edk2-devel@lists.01.org
Cc: Wang, BinX A ; Gao, Liming
Subject: [edk2] [Patch] BaseTo
v2:
* Refine the patch by changing the '==' to '>='.
Cc: Ye Ting
Cc: Jin Eric
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin
---
NetworkPkg/HttpDxe/HttpImpl.c | 4
1 file changed, 4 insertions(+)
diff --git a/NetworkPkg/HttpDxe/HttpImpl.c b/NetworkPkg/Ht
Two minor comments, others are good to me.
1. Could the code use (LastLba + 1 - EndGroupLba) instead of (LastLba -
EndGroupLba + 1)?
2. Could the code have the debug message "DEBUG ((EFI_D_ERROR,
"EmmcEraseBlocks(): Lba 0x%x BlkNo 0x%x Event %p with %r\n", Lba, BlockNum,
Token->Event, Status))
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Chen, Hesheng
Sent: Thursday, August 10, 2017 4:37 PM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong
Subject: [patch] BaseTools/UPT: Support Multiple Installation
Add a new feature to UPT to support install
Hi,
When I build ovmf with commit: 76c6f69ccadc7835c9616b077d9ff1b8e46fe49e, the
following error occurred:
git clone https://github.com/tianocore/edk2.git
cd edk2
OvmfPkg/build.sh -a X64
/home/fan/edk2/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.
From: Yanyan Zhang
Per DEC spec, multiple section tag use to separate, and it can
support Tab, so this patch fix the bug to use Tab.
::= {} {}
::= *
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yanyan Zhang
---
BaseTools/Source/Py
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=667
REF: https://lists.01.org/pipermail/edk2-devel/2017-August/013112.html
Star Zeng (2):
MdeModulePkg DxeCore: Fix double free pages on LoadImage failure path
MdeModulePkg DxeCore: Enhance "ConvertPages: Incompatible memory
types"
MdeM
When double free pages by FreePages() or allocate allocated pages by
AllocatePages() with AllocateAddress type, the code will print debug
message "ConvertPages: Incompatible memory types", but the debug
message is not very obvious for the error paths by FreePages() or
AllocatePages().
Refer https:
https://bugzilla.tianocore.org/show_bug.cgi?id=667
reported there is double free pages on LoadImage failure path.
CoreLoadPeImage()
...
return EFI_SUCCESS;
Done:
//
// Free memory.
//
if (DstBufAlocated) {
CoreFreePages (Image->ImageContext.ImageAddress, Image->NumberOfPages);
}
> -Original Message-
> From: Zeng, Star
> Sent: Friday, August 11, 2017 10:37 AM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Wu, Hao A; Ni, Ruiyu; Zeng, Star
> Subject: RE: [edk2] [PATCH v2] MdeModulePkg/EmmcDxe: Make sure no extra
> data is erased by EraseBlocks
>
> Two minor comments,
V3 changes:
Add debug messages for new return path when successfully erase the
specified blocks. Refine logic for calculating the size for writing
zeros to device.
V2 changes:
The Trim command is not supported on all eMMC devices. For those devices
that do not support such command, add codes to h
Andrew:
Edk2 Build system calls GenFw to generate EFI image in build phase. Even if
this image is not built into BIOS image, its EFI image will be generated by
GenFw. So, only if this EFI image is built from EDK2 project, it can be updated
by GenFw tool. You can see this step in build_rule.txt
Reviewed-by: Star Zeng
-Original Message-
From: Wu, Hao A
Sent: Friday, August 11, 2017 12:38 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Zeng, Star ; Ni, Ruiyu
Subject: [PATCH v3] MdeModulePkg/EmmcDxe: Make sure no extra data is erased by
EraseBlocks
V3 changes:
Add debug message
> On Aug 10, 2017, at 9:48 PM, Gao, Liming wrote:
>
> Andrew:
> Edk2 Build system calls GenFw to generate EFI image in build phase. Even if
> this image is not built into BIOS image, its EFI image will be generated by
> GenFw. So, only if this EFI image is built from EDK2 project, it can be
Hi Laszlo,
I'm trying to reproduce your boot failure with OVMF in my Ubuntu system, but
not succeed. My GCC was built from GCC main trunk code in 20170601, and my ld
linker is version 2.28. Could you try the ld 2.28 with your gcc-7.1 and check
whether it works in your side? Or, do you know wh
Hi Mike,
The patch 3 has some "Tab character used". Please fix it when you commit.
Others are good to me.
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Kinney, Michael D
Sent: Friday, August 04, 2017 1:30 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming
Andrew:
I get your point. I agree edk2 firmware to support old EFI image. And, I
review the change in BasePeCoffLib. But, I think it is unnecessary. Below is
the current logic. On the first loop, DebugEntry.Type is
EFI_IMAGE_DEBUG_TYPE_CODEVIEW, then will return. It doesn't enter into second
66 matches
Mail list logo
