Re: [edk2] [edk2-test][RFC PATCH 01/12] uefi-sct/SctPkg: sbbr: Add support to build SBBR v1.0 test cases.

On Tue, 2018-11-06 at 06:45 -0600, Leif Lindholm wrote: > Hi Sakar, > > Glad to see you guys already contributing to the newly(ish) open SCT. Indeed. > > I do have some comments on this patch - starting with: please cc the > maintainers. I have added Eric/Supreeth to this reply. We (me and Eric)

Re: [edk2] [PATCH edk2-staging 02/19] IntelUndiPkg: remove EOF markers

On 6/11/18 18:58, Ard Biesheuvel wrote: Remove the Ctrl-Z markers at the end of each file: these break the GCC build on Linux. Weird... Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daudé ---

[edk2] [PATCH edk2-staging 17/19] IntelUndiPkg/GigUndiDxe: move MSFT warning overrides to INF file

GCC chokes on the unknown MSVC specific #pragmas used for suppressing warnings, so remove them and use the INF BuildOptions section instead. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 2 +-

[edk2] [PATCH edk2-staging 15/19] IntelUndiPkg/GigUndiDxe: remove forward declaration of non-existent function

Remove the forward declaration of e1000_disable_ulp_lpt_lp (), which is never defined anywhere in the code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[edk2] [PATCH edk2-staging 18/19] IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 3 +++ IntelUndiPkg/GigUndiDxe/ComponentName.c | 2 ++ IntelUndiPkg/GigUndiDxe/ComponentName.h | 1 +

[edk2] [PATCH edk2-staging 19/19] IntelUndiPkg/GigUndiDxe: remove or reorganize unused variables

Drop variables that are assigned but never used, or move them into a conditional preprocessor block if the only references occur from such code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 2 --

[edk2] [PATCH edk2-staging 12/19] IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct pointer type

E1000MemCopy () takes UINT8 pointers not INT8 pointers, so cast the arguments to the correct type. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/e1000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2] [PATCH edk2-staging 04/19] IntelUndiPkg/GigUndiDxe: consistently use forward slashes as path separators

Replace backslashes in paths with forward slashes to be compatible with non-Windows OSes. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/Decode.c | 2 +- IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 14 +++---

[edk2] [PATCH edk2-staging 07/19] IntelUndiPkg/GigUndiDxe: create GCC alternatives for MSFT build options

Prefix the existing MSFT only build option overrides with MSFT: and create the GCC: counterparts so we can build this code with GCC as well. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 16 1

[edk2] [PATCH edk2-staging 05/19] IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration after type definition

Move the extern declaration of mBrandingTable[] after the definition of the type. This solves a build issue with GCC. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 6 +++--- 1 file changed, 3 insertions(+), 3

[edk2] [PATCH edk2-staging 08/19] IntelUndiPkg/GigUndiDxe: add missing VOID** cast

Unlike Visual Studio, GCC does not permit implicit conversion between a pointer-to-void-pointer and pointer to a typed pointer. So add the explicit casts where necessary. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/Hii.c | 8

[edk2] [PATCH edk2-staging 11/19] IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP token pasting

The ## CPP token pasting operator is used to paste *tokens*, which is not the same thing as pasting arbitrary macro arguments. Since a token cannot contain . or ) characters in the first place, using the ## operator here is wrong and unnecessary, so just remove it. Contributed-under: TianoCore

[edk2] [PATCH edk2-staging 16/19] IntelUndiPkg/GigUndiDxe: fix incorrect indentation

Silence a 'misleading indentation' GCC warning by fixing the incorrect indentation. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[edk2] [PATCH edk2-staging 14/19] IntelUndiPkg/GigUndiDxe: redefine UNREFERENCED_nPARAMETER macros for GCC

Use (VOID) casts to silence unreferenced parameter warnings on GCC. The existing macros generate 'statement with no effect' warnings instead, which does not really help. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH edk2-staging 13/19] IntelUndiPkg/GigUndiDxe: don't take address of cast expression

Taking the address of a cast expression is not permitted in C. Instead, take the address of the variable, and cast the pointer to the desired pointer type. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/e1000.c | 4 ++-- 1 file

Re: [edk2] [PATCH v2 5/5] OvmfPkg: simply use the Bochs interface for vmsvga

On 11/06/18 14:44, Philippe Mathieu-Daudé wrote: > On 6/11/18 14:36, Laszlo Ersek wrote: >> On 11/06/18 12:47, Laszlo Ersek wrote: >> >>> ... While we discuss this, I'll go ahead and push the first four >>> patches. The code being reverted is dead anyway. I'll report back about >>> the commit

Re: [edk2] [PATCH v3 1/1] ArmVirtPkg: Replace obsoleted network drivers from platform DSC/FDF.

On 6 November 2018 at 16:24, Laszlo Ersek wrote: > On 11/06/18 13:32, Ard Biesheuvel wrote: >> On 6 November 2018 at 02:24, Fu Siyuan wrote: >>> V3: >>> Remove duplicate library added in v2 patch, since ArmVirtPkg.dsc.inc >>> already have them. Just remove the if...end there is enough. >>> >>>

Re: [edk2] [edk2-test][RFC PATCH 04/12] uefi-sct/SctPkg: sbbr: Add Required UEFI Runtime Services tests.

On Tue, Nov 06, 2018 at 02:17:38PM +0530, Sakar Arora wrote: > Required UEFI Runtime Services Tests - SBBR v1.0 Appendix B > 1. EFI_GET_TIME > 2. EFI_SET_TIME > 3. EFI_GET_WAKEUP_TIME > 4. EFI_SET_WAKEUP_TIME > 5. EFI_GET_VARIABLE > 6. EFI_GET_NEXT_VARIABLE_NAME > 7. EFI_SET_VARIABLE > 8.

Re: [edk2] [edk2-test][RFC PATCH 07/12] uefi-sct/SctPkg: sbbr: Add test cases for SBBR v1.0 boot services

On Tue, Nov 06, 2018 at 02:17:41PM +0530, Sakar Arora wrote: > From: John Powell > > Tests SBBR requirements 3.4.1 and 3.4.4. > > Change-Id: I0dd625851db65d04d2a7572a2d6838951c8f7c67 > Signed-off-by: John Powell > --- > uefi-sct/SctPkg/CommonGenFramework.sh | 3 + >

Re: [edk2] [edk2-test][RFC PATCH 10/12] uefi-sct/SctPkg: sbbr: Corrected path to ArmBaseLib.inf in SBBR_SCT.dsc

On Tue, Nov 06, 2018 at 02:17:44PM +0530, Sakar Arora wrote: > From: Randy Jones > > Change-Id: I0fa236441ed8388d6c8a7fd185d46ec5a2dbe02d > --- > uefi-sct/SctPkg/UEFI/SBBR_SCT.dsc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/uefi-sct/SctPkg/UEFI/SBBR_SCT.dsc >

[edk2] [PATCH edk2-staging 02/19] IntelUndiPkg: remove EOF markers

Remove the Ctrl-Z markers at the end of each file: these break the GCC build on Linux. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 1 - IntelUndiPkg/GigUndiDxe/AdapterInformation.h | 1 -

[edk2] [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC

This series fixes the GigUndiDxe in the edk2-staging/Intel_UNDI branch at github.com/tianocore so it can be built with GCC on Linux for ARM and AARCH64 (as well as X64) Ard Biesheuvel (19): IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported architectures IntelUndiPkg: remove EOF

[edk2] [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast

UINT8 and CHAR8 are not the same underlying type on all architectures, so add an explicit cast where necessary. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/Hii.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[edk2] [PATCH edk2-staging 10/19] IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals

The Data4 member of the GUID/EFI_GUID struct type is an array of UINT8, so literals require two sets of { } braces. Add them where missing. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 4 ++--

[edk2] [PATCH edk2-staging 03/19] IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in filenames

Rename E1000.[ch] and E1000_osdep.[ch] to all lowercase, and replace all #include references with lowercase ones as well. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 2 +-

[edk2] [PATCH edk2-staging 01/19] IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported architectures

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/IntelOpenSourceUndiPkg.dsc | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc b/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc

Re: [edk2] [edk2-test][RFC PATCH 02/12] uefi-sct/SctPkg: sbbr: Add boot services test cases for SBBR v1.0

Hi Sakar, On Tue, Nov 06, 2018 at 02:17:36PM +0530, Sakar Arora wrote: > 1. Implements boot services tests defined in Appendix A of > > http://infocenter.arm.com/help/topic/com.arm.doc.den0044b/DEN0044B_Server_Base_Boot_Requirements.pdf > > 2. Fixes whitespace issues in

Re: [edk2] [edk2-test][RFC PATCH 08/12] uefi-sct/SctPkg: sbbr: UEFI Version Verification Test

On Tue, Nov 06, 2018 at 02:17:42PM +0530, Sakar Arora wrote: > From: Randy Jones > > Check if EFI Specification Version is 2.5 or greater. > > Change-Id: I7a602e52ac833f18dc791ca992f55e1f1996bc60 > Signed-off-by: Randy Jones > --- > uefi-sct/SctPkg/CommonGenFramework.sh | 3 + >

Re: [edk2] [PATCH edk2-staging 04/19] IntelUndiPkg/GigUndiDxe: consistently use forward slashes as path separators

On 6/11/18 18:58, Ard Biesheuvel wrote: Replace backslashes in paths with forward slashes to be compatible with non-Windows OSes. I thought the Windows format expected escaped backslashes... Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

Re: [edk2] [edk2-test][RFC PATCH 03/12] uefi-sct/SctPkg: sbbr: Add System Environment Configuration Test Cases

Hi Sakar, On Tue, Nov 06, 2018 at 02:17:37PM +0530, Sakar Arora wrote: > From: John Powell > > Add test cases for SBBR v1.0 requirements 3.3.1, 3.3.2, 3.3.3 and 3.3.4. > > Change-Id: I3801314af1ffabaa2d71cee76417c4277f5f5521 > Signed-off-by: John Powell > --- >

Re: [edk2] [edk2-test][RFC PATCH 12/12] uefi-sct/SctPkg: sbbr: Modify SBBR description file to add missing dependencies.

On Tue, Nov 06, 2018 at 02:17:46PM +0530, Sakar Arora wrote: > SBBR ImageServicesTest fails because it can't load its dependent > drivers. > Modify the description file to include all the dependecies and copy it > over to the dependency folder. > > Signed-off-by: Sakar Arora > Reported-by: Felix

Re: [edk2] [PATCH edk2-staging 03/19] IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in filenames

On 6/11/18 18:58, Ard Biesheuvel wrote: Rename E1000.[ch] and E1000_osdep.[ch] to all lowercase, and replace all #include references with lowercase ones as well. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daudé ---

Re: [edk2] [edk2-test][RFC PATCH 11/12] uefi-sct/SctPkg: sbbr: Bugfix for MemoryMap Check Test.

On Tue, Nov 06, 2018 at 02:17:45PM +0530, Sakar Arora wrote: > As per SBBR specification, "A UEFI runtime environment compliant with > SBBR must not be written with any assumption of an identity mapping > between virtual and physical memory maps." > > Test case implementation was failing the

Re: [edk2] [PATCH 2/2] MdeModulePkg/Core: fix ineffective guard page issue

Leif, Thanks for catching that. I'll re-generate the patch files. Regards, Jian > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, November 06, 2018 8:10 PM > To: Wang, Jian J > Cc: edk2-devel@lists.01.org; Ni, Ruiyu ; Yao, Jiewen > ; Zeng,

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Support FSP Dispatch mode

Hi Jiewen, No special reason in this patch. I'm verifying the change for switching to "if" instead of "#if", and will re-send a new patch later. Thanks! Chasel -Original Message- From: Yao, Jiewen Sent: Tuesday, November 6, 2018 7:38 PM To: Chiu, Chasel Cc: edk2-devel@lists.01.org;

[edk2] [PATCH v2 0/2] *fix ineffective guard page issue

>v2: re-generate the patch per Leif's comments REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1295 Cc: Star Zeng Cc: Jiewen Yao Cc: Ruiyu Ni Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jian J Wang Jian J Wang (2): MdeModulePkg/Core: fill

[edk2] [PATCH v2 2/2] MdeModulePkg/Core: fix ineffective guard page issue

> v2: re-generate this patch per Leif's comments. No logic changes. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1295 This issue originates from following patch which allows to enable paging if PcdImageProtectionPolicy and PcdDxeNxMemoryProtectionPolicy (in addition to PcdSetNxForStack)

[edk2] [PATCH v2 1/2] MdeModulePkg/Core: fill logic hole in MemoryProtectionCpuArchProtocolNotify

> v2: re-generate this patch per Leif's comments. No logic changes. At the end of of MemoryProtectionCpuArchProtocolNotify there's cleanup code to free resource. But at line 978, 994, 1005 the function returns directly. This patch use "goto" to replace "return" to make sure the resource is freed

Re: [edk2] [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast

Hi Ard, On 6/11/18 18:58, Ard Biesheuvel wrote: UINT8 and CHAR8 are not the same underlying type on all architectures, so add an explicit cast where necessary. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/GigUndiDxe/Hii.c | 2 +- 1

Re: [edk2] [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC

Hi Ard, Can you please add CC lines to the commit message for the developers that have contributed to the edk2-staging/Intel_UNDI branch? This would include: Cc: Maciej Rabeda Cc: Kamil Kacperski Cc: Pawel Orlowski Thanks, Mike > -Original Message- > From: Ard Biesheuvel

[edk2] [PATCH] MdePkg/BaseSynchronizationLib XCODE: fix InternalSync[De|In]crement

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1303 XCODE disassembly code of InternalSyncDecrement with today's code is: __asm__ __volatile__ ( "movl$1, %%eax \n\t" "lock \n\t" "xadd%%eax, %1 \n\t" "inc %%eax \n\t" : "=a" (Result),

Re: [edk2] [PATCH v3 1/1] ArmVirtPkg: Replace obsoleted network drivers from platform DSC/FDF.

Hi, Arb > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, November 7, 2018 12:39 AM > To: Laszlo Ersek > Cc: Fu, Siyuan ; edk2-devel@lists.01.org; Julien > Grall > Subject: Re: [PATCH v3 1/1] ArmVirtPkg: Replace obsoleted network drivers >

[edk2] Soft Feature Freeze has started since Nov.1 for dk2-stable201811

Hi, all https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning lists edk2-stable201811 tag planning. Now, we enter into Soft Feature Freeze phase. In this phase, the feature under review will not be allowed to be pushed. The patch review can continue without break. Here

Re: [edk2] [PATCH] UefiCpuPkg/CommonFeature: Skip locking when the feature is disabled

Hi Ray, I think we should add comments to mention that if the Lock bit is already set, driver can't disable it. So driver can directly return success if state is FALSE. With that comments, Reviewed-by: Eric Dong Thanks, Eric > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday,

[edk2] [PATCH v2] IntelFsp2WrapperPkg: Support FSP Dispatch mode

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1300 Provides PCD selection for FSP Wrapper to support Dispatch mode. Also PcdFspmBaseAddress should support Dynamic for recovery scenario (multiple FSP-M binary in flash) Test: Verified on internal platform and both API and DISPATCH

Re: [edk2] [PATCH v2 5/5] OvmfPkg: simply use the Bochs interface for vmsvga

On 2018-11-06 19:47, Laszlo Ersek wrote: I suggest the following: On 11/02/18 04:24, yuchenlin via edk2-devel wrote: From: yuchenlin BAR |std vga | vmsvga - 0| Framebuffer | I/O space 1| Reserved | Framebuffer 2| MMIO |

Re: [edk2] [PATCH v2 5/5] OvmfPkg: simply use the Bochs interface for vmsvga

On 2018-11-06 21:44, Philippe Mathieu-Daudé wrote: On 6/11/18 14:36, Laszlo Ersek wrote: On 11/06/18 12:47, Laszlo Ersek wrote: ... While we discuss this, I'll go ahead and push the first four patches. The code being reverted is dead anyway. I'll report back about the commit hashes.

Re: [edk2] [PATCH v2 0/2] *fix ineffective guard page issue

On 2018/11/7 8:53, Jian J Wang wrote: v2: re-generate the patch per Leif's comments REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1295 Cc: Star Zeng Cc: Jiewen Yao Cc: Ruiyu Ni Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jian J Wang

[edk2] [PATCH v3] OvmfPkg: simply use the Bochs interface for vmsvga

From: yuchenlin BAR |std vga | vmsvga - 0| Framebuffer | I/O space 1| Reserved | Framebuffer 2| MMIO | FIFO - We cannot recognize VMW SVGA as BOCHS because that would confuse the IsQxl setting in

Re: [edk2] [PATCH v2] IntelFsp2WrapperPkg: Support FSP Dispatch mode

Reviewed-by: jiewen@intel.com > -Original Message- > From: Chiu, Chasel > Sent: Wednesday, November 7, 2018 10:25 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Desimone, Nathaniel L > ; Chiu, Chasel > Subject: [PATCH v2] IntelFsp2WrapperPkg: Support FSP Dispatch mode > > REF:

[edk2] OVMF compile error

Hi, When we build OVMF with the latest commit: 328409ce8de7f318ee9c929b64302bd361cd1dbd, we met below error: OvmfPkg/build.sh -a X64 -n 8 ... OK make[1]: Leaving directory `/home/fan/edk2/BaseTools/Tests' make: Leaving directory `/home/fan/edk2/BaseTools' Running edk2

Re: [edk2] [PATCH v3 1/2] MdeModulePkg/Core: fill logic hole in MemoryProtectionCpuArchProtocolNotify

On Wed, Nov 07, 2018 at 03:12:47PM +0800, Jian J Wang wrote: > > v3: fixed one more memory leak in the same function and updated > > commit message accordingly. No objection to the content, but comments not intended to be committed should go in the cover letter or below the ---. A

Re: [edk2] OVMF compile error

On 2018-11-07 12:39, Chen, Farrah wrote: Hi, When we build OVMF with the latest commit: 328409ce8de7f318ee9c929b64302bd361cd1dbd, we met below error: OvmfPkg/build.sh -a X64 -n 8 ... OK make[1]: Leaving directory `/home/fan/edk2/BaseTools/Tests' make: Leaving

Re: [edk2] [PATCH v3 0/2] fix ineffective guard page issue

Reviewed-by: Star Zeng -Original Message- From: Wang, Jian J Sent: Wednesday, November 7, 2018 3:13 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Yao, Jiewen ; Ni, Ruiyu ; Leif Lindholm Subject: [PATCH v3 0/2] fix ineffective guard page issue >v3: found and fixed another memory

Re: [edk2] [edk2-test][Patch v2] uefi-sct/SctPkg:Add checkpoint of ReadKeyStrokeEx Toggle state

It is the patch v2 below. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Jin Sent: Wednesday, November 7, 2018 2:48 PM To: edk2-devel@lists.01.org Subject: [edk2] [edk2-test][Patch] uefi-sct/SctPkg:Add checkpoint of ReadKeyStrokeEx Toggle

Re: [edk2] [PATCH] SourceLevelDebugPkg/Readme.txt: Update UDK Debugger Tool & manual URL

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Wednesday, November 7, 2018 10:31 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ni, Ruiyu > Subject: [PATCH] SourceLevelDebugPkg/Readme.txt: Update UDK Debugger > Tool & manual URL > >

[edk2] [PATCH v3 1/2] MdeModulePkg/Core: fill logic hole in MemoryProtectionCpuArchProtocolNotify

> v3: fixed one more memory leak in the same function and updated > commit message accordingly. At the end of of MemoryProtectionCpuArchProtocolNotify there's cleanup code to free resource. But at line 978, 994, 1005 the function returns directly. This patch use "goto" to replace "return" to

[edk2] [PATCH v3 2/2] MdeModulePkg/Core: fix ineffective guard page issue

>v3: no change REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1295 This issue originates from following patch which allows to enable paging if PcdImageProtectionPolicy and PcdDxeNxMemoryProtectionPolicy (in addition to PcdSetNxForStack) are set to enable related features.

[edk2] [PATCH v3 0/2] fix ineffective guard page issue

>v3: found and fixed another memory leak REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1295 Cc: Star Zeng Cc: Jiewen Yao Cc: Ruiyu Ni Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jian J Wang Jian J Wang (2): MdeModulePkg/Core: fill logic

Re: [edk2] [PATCH edk2-staging 16/19] IntelUndiPkg/GigUndiDxe: fix incorrect indentation

On 6/11/18 18:58, Ard Biesheuvel wrote: Silence a 'misleading indentation' GCC warning by fixing the incorrect indentation. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé ---

Re: [edk2] [PATCH] UefiCpuPkg/SmmCpu: Block SMM read-out only when static paging is used

Good suggestion Laszlo. Current static paging will force: 1) only valid smm comm buffer is present. The OS memory is not present. 2) non smram is NX (no matter static or dynamic paging) 3) code region in Smm is RO (if pe image is page aligned) 4) data region in Smm is NX (if pe image is page

Re: [edk2] [PATCH edk2-staging 13/19] IntelUndiPkg/GigUndiDxe: don't take address of cast expression

On 6/11/18 18:58, Ard Biesheuvel wrote: Taking the address of a cast expression is not permitted in C. Instead, take the address of the variable, and cast the pointer to the desired pointer type. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC

On 6 November 2018 at 23:10, Kinney, Michael D wrote: > Hi Ard, > > Can you please add CC lines to the commit message > for the developers that have contributed to the > edk2-staging/Intel_UNDI branch? > > This would include: > > Cc: Maciej Rabeda Maciej was already on cc. I hope he can forward

Re: [edk2] [PATCH edk2-staging 10/19] IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals

On 6/11/18 18:58, Ard Biesheuvel wrote: The Data4 member of the GUID/EFI_GUID struct type is an array of UINT8, so literals require two sets of { } braces. Add them where missing. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Philippe

Re: [edk2] [PATCH edk2-staging 12/19] IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct pointer type

On 6/11/18 18:58, Ard Biesheuvel wrote: E1000MemCopy () takes UINT8 pointers not INT8 pointers, so cast the arguments to the correct type. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daudé ---

Re: [edk2] [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast

On 6 November 2018 at 21:31, Philippe Mathieu-Daudé wrote: > Hi Ard, > > On 6/11/18 18:58, Ard Biesheuvel wrote: >> >> UINT8 and CHAR8 are not the same underlying type on all architectures, >> so add an explicit cast where necessary. >> >> Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [edk2-test][RFC PATCH 07/12] uefi-sct/SctPkg: sbbr: Add test cases for SBBR v1.0 boot services

From: John Powell Tests SBBR requirements 3.4.1 and 3.4.4. Change-Id: I0dd625851db65d04d2a7572a2d6838951c8f7c67 Signed-off-by: John Powell --- uefi-sct/SctPkg/CommonGenFramework.sh | 3 + uefi-sct/SctPkg/Config/Data/Category.ini | 11 +-

[edk2] [edk2-test][RFC PATCH 09/12] uefi-sct/SctPkg: sbbr: UEFI SMBIOS Base Requirements

From: John Powell Tests that SMBIOS3 table is properly accessible from UEFI and that it is in the correct memory region. Change-Id: I113ead8183f02886e0facded0ed2ad4e213677d8 Signed-off-by: John Powell --- uefi-sct/SctPkg/CommonGenFramework.sh | 3 +

Re: [edk2] [PATCH v2 2/5] Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support"

On 11/02/18 04:23, yuchenlin via edk2-devel wrote: > From: yuchenlin > > This reverts commit c137d95081690d4877fbeb5f1856972e84ac32f2. > > The VMWare SVGA model now -- since commit 104bd1dc70 in QEMU -- > falls back to stdvga (that is, Bochs) if we don't setup VMWare SVGA > FIFO. > > To

[edk2] [edk2-test][RFC PATCH 06/12] uefi-sct/SctPkg: sbbr: Add test cases for SBBR v1.0 3.5.4 and 3.5.5

From: John Powell 3.5.4 tests ResetSystem runtime service functions. The PSCI portion of this requirement will be handled later or removed completely. 3.5.5 tests non-volatile variable persistence across resets. Signed-off-by: John Powell --- .../SBBRRuntimeServices/BlackBoxTest/Guid.c

[edk2] [edk2-test][RFC PATCH 08/12] uefi-sct/SctPkg: sbbr: UEFI Version Verification Test

From: Randy Jones Check if EFI Specification Version is 2.5 or greater. Change-Id: I7a602e52ac833f18dc791ca992f55e1f1996bc60 Signed-off-by: Randy Jones --- uefi-sct/SctPkg/CommonGenFramework.sh | 3 + .../BlackBoxTest/EfiSpecVerLvlBBTest.inf | 84 +

[edk2] [edk2-test][RFC PATCH 11/12] uefi-sct/SctPkg: sbbr: Bugfix for MemoryMap Check Test.

As per SBBR specification, "A UEFI runtime environment compliant with SBBR must not be written with any assumption of an identity mapping between virtual and physical memory maps." Test case implementation was failing the test, if it is not identity mapped, which is incorrect. Corrected test

Re: [edk2] [PATCH v2 1/2] Platform/Hisilicon: CRLF fixups for D05.dsc

On 5 November 2018 at 02:33, Fu Siyuan wrote: > From: Leif Lindholm > > Commit 1a13dfd37fe7 ("Hisilicon/D0x: Switch to generic PciHostBridge > driver") introduced some incorrect line endings, fix those here. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney >

[edk2] [PATCH] UefiCpuPkg/CommonFeature: Skip locking when the feature is disabled

Today's code unconditionally sets the IA32_FEATURE_CONTROL.Lock to 1 no matter the feature is enabled or not. The patch fixes this issue by only setting the Lock bit to 1 when the feature is enabled. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Eric Dong

[edk2] [edk2-test][RFC PATCH 12/12] uefi-sct/SctPkg: sbbr: Modify SBBR description file to add missing dependencies.

SBBR ImageServicesTest fails because it can't load its dependent drivers. Modify the description file to include all the dependecies and copy it over to the dependency folder. Signed-off-by: Sakar Arora Reported-by: Felix Poludov --- uefi-sct/SctPkg/CommonGenFramework.sh | 3 ++

[edk2] [PATCH] IntelFsp2WrapperPkg: Support FSP Dispatch mode

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1300 Provides PCD selection for FSP Wrapper to support Dispatch mode. Also PcdFspmBaseAddress should support Dynamic for recovery scenario (multiple FSP-M binary in flash) Test: Verified on internal platform and both API and DISPATCH

Re: [edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

On 31 October 2018 at 05:38, Zeng, Star wrote: > Good feedback. > > On 2018/10/30 20:50, Leif Lindholm wrote: >> >> On Tue, Oct 30, 2018 at 09:39:24AM -0300, Ard Biesheuvel wrote: >>> >>> (add back the list) >> >> >> Oi! Go back on holiday! >> >>> On 30 October 2018 at 09:07, Cohen, Eugene

Re: [edk2] [PATCH v2 3/5] Revert "OvmfPkg/QemuVideoDxe: Helper functions for unaligned port I/O."

On 11/02/18 04:24, yuchenlin via edk2-devel wrote: > From: yuchenlin > > This reverts commit 05a5379458725234de8a05780fcb5da2c12680e4. > > The VMWare SVGA display device implemented by Qemu (-vga vmware) uses > an I/O-type BAR which is laid out such that some register offsets are > not aligned

Re: [edk2] [PATCH v2 4/5] Revert "OvmfPkg: VMWare SVGA display device register definitions"

On 11/02/18 04:24, yuchenlin via edk2-devel wrote: > From: yuchenlin > > This reverts commit 9bcca53fe466cdff397578328d9d87d257aba493. > > We reverted VMWare SVGA driver. We don't need these definitions too. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: yuchenlin

[edk2] [edk2-test][RFC PATCH 03/12] uefi-sct/SctPkg: sbbr: Add System Environment Configuration Test Cases

From: John Powell Add test cases for SBBR v1.0 requirements 3.3.1, 3.3.2, 3.3.3 and 3.3.4. Change-Id: I3801314af1ffabaa2d71cee76417c4277f5f5521 Signed-off-by: John Powell --- uefi-sct/SctPkg/CommonGenFramework.sh | 3 + uefi-sct/SctPkg/Config/Data/Category.ini | 11

[edk2] [edk2-test][RFC PATCH 05/12] uefi-sct/SctPkg: sbbr: Add test cases for SBBR v1.0 Appendix C

From: John Powell GenericTest/RequiredUefiProtocols covers part of Appendix C and GenericTest/EfiCompliant covers the remaining requirements. This patch also fixes a few small formatting issues in CommonGenFramework.sh and SBBR_SCT.dsc Change-Id: I541d425dfcc630725ecb6f874fc396cdd151221e

[edk2] [edk2-test][RFC PATCH 10/12] uefi-sct/SctPkg: sbbr: Corrected path to ArmBaseLib.inf in SBBR_SCT.dsc

From: Randy Jones Change-Id: I0fa236441ed8388d6c8a7fd185d46ec5a2dbe02d --- uefi-sct/SctPkg/UEFI/SBBR_SCT.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uefi-sct/SctPkg/UEFI/SBBR_SCT.dsc b/uefi-sct/SctPkg/UEFI/SBBR_SCT.dsc index bf010c9..7076d11 100644 ---

[edk2] [edk2-test][RFC PATCH 02/12] uefi-sct/SctPkg: sbbr: Add boot services test cases for SBBR v1.0

1. Implements boot services tests defined in Appendix A of http://infocenter.arm.com/help/topic/com.arm.doc.den0044b/DEN0044B_Server_Base_Boot_Requirements.pdf 2. Fixes whitespace issues in SctPkg/CommonGenFramework.sh file. Change-Id: Idc7b6e471a4c4966d4ad55f39ea045775854c206 Signed-off-by:

[edk2] [edk2-test][RFC PATCH 01/12] uefi-sct/SctPkg: sbbr: Add support to build SBBR v1.0 test cases.

Provide a framework for building SBBR Test Cases using the existing UEFI-SCT Framework. Separate out build-scripts/install scripts to carve out SBBR test cases. To build SBBR SCT, ./build_sbbr.sh AARCH64 GCC Change-Id: I3d7612dbb42a4dc3bce40e4e9b351fd1f5f84dcd Signed-off-by: Sakar Arora ---

[edk2] [edk2-test][RFC PATCH 04/12] uefi-sct/SctPkg: sbbr: Add Required UEFI Runtime Services tests.

Required UEFI Runtime Services Tests - SBBR v1.0 Appendix B 1. EFI_GET_TIME 2. EFI_SET_TIME 3. EFI_GET_WAKEUP_TIME 4. EFI_SET_WAKEUP_TIME 5. EFI_GET_VARIABLE 6. EFI_GET_NEXT_VARIABLE_NAME 7. EFI_SET_VARIABLE 8. EFI_QUERY_VARIABLE_INFO 9. EFI_QUERY_CAPSULE_CAPABILITIES 10. EFI_UPDATE_CAPSULE 11.

[edk2] [edk2-test][PATCH] uefi-sct/SctPkg: Add script to automatically generate test file structure.

From: John Powell When new_test.py is run with no options, it asks the user a series of questions about the test they wish to create and then creates the test file structure, files, shell functions, and entries in build system configuration files. When run with the option -g or --guid, it just

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Support FSP Dispatch mode

hi chasel I think our guide is not to use #if, but use if() Is there any special reason in this patch? thank you! Yao, Jiewen > 在 2018年11月6日，下午5:22，Chiu, Chasel 写道： > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1300 > > Provides PCD selection for FSP Wrapper to support Dispatch >

Re: [edk2] How to build EDK2 project for ARM using LLVM tool chain

Hi Prem, On Sat, Nov 03, 2018 at 02:11:32PM +0530, Prem Kumar wrote: > Hi All, > Kindly provide your comments to build EDK2 project for ARM AARCH64/ARM > using LLVM tools chain under Windows environment. > > I've below tools, > - Visual Studio 2015 Visual Studio 2015 does not support AARCH64

Re: [edk2] [PATCH edk2-platforms 01/27] Platform/Microsoft: Add OpteeClientPkg dec

Hi Chris, On Tue, 6 Nov 2018 at 07:23, Chris Co wrote: > > Hi Sumit, > > > -Original Message- > > From: Sumit Garg > > > > Hi Chris, > > > > On Sat, 3 Nov 2018 at 05:25, Chris Co wrote: > > > > > > Hi Sumit, > > > > > > > -Original Message- > > > > From: Sumit Garg > > > > > >

Re: [edk2] [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg.

On Mon, Nov 05, 2018 at 11:12:20PM +0100, Laszlo Ersek wrote: > > Ming Huang (cc) has also had issues with this in his latest set (but > > not before). Can you guys work together to try to figure out what is > > going wrong? > > > > Can you start by testing with an older version of git? > > this

[edk2] [edk2-test][PATCH] uefi-sct/SctPkg: Framework: Enhanced Null Pointer Checks.

On some AARCH64 Platforms, after all the tests are completed there was a synchronous exception and it was found to be NULL pointer access issue. Add additional NULL Pointer checks to resolve the exception. Signed-off-by: Sakar Arora Reported-by: Chandni Cherukuri ---

Re: [edk2] [PATCH 2/2] MdeModulePkg/Core: fix ineffective guard page issue

On Sat, Nov 03, 2018 at 02:42:21PM +0800, Jian J Wang wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1295 > > This issue originates from following patch which allows to enable > paging if PcdImageProtectionPolicy and PcdDxeNxMemoryProtectionPolicy > (in addition to PcdSetNxForStack)

[edk2] TimerLib - usable library on X64?

Hi everyone, I'm trying to use TimerLib to precisely measure time elapsed between specific functions, and I'm having some issues trying to get it to work. On X64 platforms all I get is (depending on the TimerLib impl I use) either zeroes from QueryPerformanceCounter

Re: [edk2] [PATCH v2 5/5] OvmfPkg: simply use the Bochs interface for vmsvga

I suggest the following: On 11/02/18 04:24, yuchenlin via edk2-devel wrote: > From: yuchenlin > > BAR |std vga | vmsvga > - > 0| Framebuffer | I/O space > 1| Reserved | Framebuffer > 2| MMIO | FIFO > > Because of the PCI

Re: [edk2] [PATCH v3 1/1] ArmVirtPkg: Replace obsoleted network drivers from platform DSC/FDF.

On 6 November 2018 at 02:24, Fu Siyuan wrote: > V3: > Remove duplicate library added in v2 patch, since ArmVirtPkg.dsc.inc > already have them. Just remove the if...end there is enough. > > V2: > Add missing library instance for NetworkPkg iSCSI driver. > Please don't put the patch revision

[edk2] [edk2-test][PATCH] uefi-sct/SctPkg: Fix issues with EfiCompliant test

From: John Powell Fixed errors occurring when an unsupported protocol is under test, in several places a call to LocateProtocol was assumed to be successful and the results were used as such, which caused synchronous exceptions when the calls failed and the code tried to use NULL pointers.

Re: [edk2] [PATCH v2 3/3] OvmfPkg: Replace obsoleted network drivers from platform DSC/FDF.

On 5 November 2018 at 23:46, Laszlo Ersek wrote: > On 11/05/18 11:49, Fu Siyuan wrote: >> V2: >> Add missed library instance for NetworkPkg iSCSI driver. >> >> This patch replaces the MdeModulePkg TCP, PXE and iSCSI driver with those >> ones in NetworkPkg. These 3 drivers in MdeModulePkg are not

Re: [edk2] [PATCH v2 5/5] OvmfPkg: simply use the Bochs interface for vmsvga

On 11/06/18 12:47, Laszlo Ersek wrote: > ... While we discuss this, I'll go ahead and push the first four > patches. The code being reverted is dead anyway. I'll report back about > the commit hashes. Before pushing the first four patches, I regression-tested them as well. Using: Cirrus, stdvga,

Re: [edk2] [PATCH v1] NetworkPkg/TlsDxe: Fix failure to process multiple TLS records.

On 11/06/18 03:13, Wu, Jiaxin wrote: > Already share the info @ https://bugzilla.tianocore.org/show_bug.cgi?id=1290 Awesome, thanks! Laszlo >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Tuesday, November 6, 2018 2:33 AM >> To: Wu, Jiaxin ;

[edk2] [PATCH 0/2] Revert "EhciDxe/XhciDxe: Use common buffer for AsyncInterruptTransfer"

There is concern at the thread https://lists.01.org/pipermail/edk2-devel/2018-November/031951.html. And the time point is a little sensitive as it is near edk2-stable201811. Cc: Ruiyu Ni Cc: Hao Wu Cc: Jian J Wang Cc: Jiewen Yao Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under:

  1   2   >