Ard,
Regards,
Jian
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Friday, January 04, 2019 2:28 AM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel ; Laszlo Ersek
> ; Leif Lindholm ; Kinney,
> Michael D ; Gao, Liming ;
> Wang, Jian J ; Wu, Hao
Hi,
With a big delay caused by private and professional matters,
I finaly submit the second version of the GPIO support for
Marvell Armada SoCs. The rework was HUGE. The biggest change
is dropping custom GPIO protocol and start using the generic
EMBEDDED_GPIO with all its types. I think I
Reviewed-by: Wu Jiaxin
Thanks,
Jiaxin
> -Original Message-
> From: Li, Songpeng
> Sent: Wednesday, January 9, 2019 4:42 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ray ;
> Wu, Jiaxin
> Subject: [PATCH v1] ShellPkg/TftpDynamicCommand: Change file writing
> method in tftp
From: jinghua
This patch introduces a helper header that can be used by
multiple EMBEDDED_GPIO protocol producers (e.g. platform
driver or GPIO expanders). The drives are differentiated by
MV_GPIO_DRIVER_TYPE field of driver's MV_GPIO_DEVICE_PATH.
In order to ease selection of the desired GPIO
Marvell Armada 7k/8k-based platforms may use Pca95xx to extend
amount of the GPIO pins.
This patch introduces support for them. The new driver implements
a generic EMBEDDED_GPIO protocol.
In order to ease description of used PCA9XXX controllers
add a common enum type. It can be used e.g. in the
Hi Ashish,
This V4 version of the patch produces the expected size
results for platform and driver builds.
There are some very minor issues with some extra carriage
returns, but those can be handled by Liming when the patch
series is committed.
I may be good to have an additional BZ to use
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, January 9, 2019 11:19 PM
> To: Ni, Ray ; edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: Re: [edk2] [PATCH] Maintainers.txt:
This patch introduces new library callback (ArmadaSoCGpioGet ()),
which dynamically allocates and fills EmbeddedGpio's
GPIO_CONTROLLER structure with the SoC description of GPIO controllers.
Because the library header is indirectly used in many modules,
update all dependencies after including
This patch implements ArmadaBoarDescLib library for
Armada80x0McBin comunity board and introduces ArmadaBoardGpioGet
routine with per-board GPIO expander description.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
---
Hitherto I2c solution used same macros, defined in multiple
places. Move them to a new common header.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
Reviewed-by: Leif Lindholm
---
Silicon/Marvell/Drivers/I2c/MvEepromDxe/MvEepromDxe.h | 10 ---
Reviewed-by: Bob Feng
-Original Message-
From: Carsey, Jaben
Sent: Thursday, January 10, 2019 3:01 AM
To: edk2-devel@lists.01.org
Cc: Feng, Bob C ; Gao, Liming
Subject: [v2 1/1] BaseTools: fix imports
1 - Some of these imports are cascaded from another file. Import them locally.
2 -
Reviewed-by: Jian J Wang
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Friday, January 04, 2019 2:28 AM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel ; Laszlo Ersek
> ; Leif Lindholm ; Kinney,
> Michael D ; Gao, Liming ;
> Wang, Jian J ; Wu,
Ard,
Regards,
Jian
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Friday, January 04, 2019 2:28 AM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel ; Laszlo Ersek
> ; Leif Lindholm ; Kinney,
> Michael D ; Gao, Liming ;
> Wang, Jian J ; Wu, Hao A
This patch implements ArmadaBoarDescLib library for
Armada70x0Db comunity board and introduces ArmadaBoardGpioGet
routine with per-board GPIO expander description.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
---
Thanks Mike. Hope to see the patches merged soon. Please let me know if you
want me to file the BZ.
Hi Liming,
Please let me know if you need me to take care of anything in the patch before
you push it.
Hi Siyuan/Jiaxin,
I think you reviewed the changes in PATCH v2 which is same as in PATCH
This patch implements ArmadaBoarDescLib library for
Armada80x0Db comunity board and introduces ArmadaBoardGpioGet
routine with per-board GPIO expander description.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
Contributed-under: TianoCore Contribution
Marvell Armada 7k/8k SoCs comprise integrated GPIO controllers,
one in AP806 and two in each south bridge hardware blocks.
This patch introduces support for them. The new driver implements
a generic EMBEDDED_GPIO protocol.
In order to ease description of used GPIO pins and controllers
of the
To abstract the initialization required for non-discoverable devices,
which is often platform specific (e.g. enable GPIO-driven power supply),
introduce a NonDiscoverableInitLib for use by the NonDiscoverable code,
for which each platform can supply its own version.
Add XHCI power supply (so
Laszlo,
Regards,
Jian
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, January 08, 2019 11:38 PM
> To: Ard Biesheuvel ; edk2-devel@lists.01.org
> Cc: Leif Lindholm ; Kinney, Michael D
> ; Gao, Liming ; Wang,
> Jian J ; Wu, Hao A ; Jagadeesh
> Ujja ;
Reviewed-by: Jian J Wang
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Friday, January 04, 2019 2:28 AM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel ; Laszlo Ersek
> ; Leif Lindholm ; Kinney,
> Michael D ; Gao, Liming ;
> Wang, Jian J ;
Reviewed-by: Jian J Wang
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Friday, January 04, 2019 2:28 AM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel ; Laszlo Ersek
> ; Leif Lindholm ; Kinney,
> Michael D ; Gao, Liming ;
> Wang, Jian J ;
Forget the previous comment, multiple comments for usage are allowed in INF.
Reviewed-by: Jian J Wang
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wang,
> Jian J
> Sent: Thursday, January 10, 2019 9:42 AM
> To: Ard Biesheuvel ;
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1433
v2: Remove an unused variable.
Current logic of shell tftp download was writing file after tftp
download finished, when the file is large, it looks like the shell
tftp command hanged after download was finished. To improve
end-user
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1433
v2: Remove an unused variable.
Current logic of shell tftp download was writing file after tftp
download finished, when the file is large, it looks like the shell
tftp command hanged after download was finished. To improve
end-user
This patch extends library with GPIO devices per-board
description. Both embedded SoC controllers and
I2C IO expanders are supported. Add a helper routine
for obtaining information about the latter.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
---
Introduce new callback that can provide information
about GPIO SoC controllers, as well as on-board
I2C IO expanders. According ArmadaSoCDescLib
ArmadaBoardDescLib routines are used for
obtaining required data.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
Enable building new GPIO drivers before adding VBUS
pins handling. Update relevant boards .dsc files with
IO expander information.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
Reviewed-by: Leif Lindholm
---
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
Hi Ard,
Some feedback added inline.
On 2019/1/4 2:28, Ard Biesheuvel wrote:
From: Jagadeesh Ujja
SMM has been rebranded as MM, and can be implemented in traditional
mode or standalone mode, using the same prototype for the services
table. Expose this table via MmServicesTableLib, permitting
Hi Ard,
Some minor feedback added inline.
On 2019/1/4 2:28, Ard Biesheuvel wrote:
The definitions of the rebranded MM protocol stack were chosen such
that the existing SMM based core drivers can be reused. So let's
implement MmServicesTableLib based on gEfiMmBaseProtocolGuid, which
is simply
Hi everybody,
I meet a question,a special arg can make system blocked,follow is my steps.
1,go to uefi shell v2.2(uefi v2.70),run this application in QEMU-ovmf:
testapp.efi
2,the output is "index:0,string:FS0:\testapp.efi"
3,testapp.efi #abc.
4,the output is same as step 2. ///< I had read the
On 2019/1/10 9:41, Wang, Jian J wrote:
Ard,
Regards,
Jian
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Friday, January 04, 2019 2:28 AM
To: edk2-devel@lists.01.org
Cc: Ard Biesheuvel ; Laszlo Ersek
; Leif Lindholm ; Kinney,
Michael D ; Gao, Liming
Hi Ard,
Some minor feedback added inline.
On 2019/1/4 2:28, Ard Biesheuvel wrote:
In preparation of providing a standalone MM based FTW driver, move
the existing SMM driver to the new MM services table, and factor out
some pieces that are specific to the traditional driver, mainly
related to
On 2019/1/10 10:33, Wang, Jian J wrote:
Laszlo,
Regards,
Jian
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, January 08, 2019 11:38 PM
To: Ard Biesheuvel ; edk2-devel@lists.01.org
Cc: Leif Lindholm ; Kinney, Michael D
; Gao, Liming ; Wang,
Jian J ; Wu,
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, January 9, 2019 6:35 PM
> To: Dong, Eric
> Cc: Brian J. Johnson ; Yao, Jiewen
> ; Ni, Ray ; edk2-
> de...@lists.01.org; Kinney, Michael D
> Subject: Re: [edk2] [Patch 1/3]
Hi All,
I agree with providing the support like "FixedAtBuild PCD in INF". And we need
to modify or provide support in BaseTools to support this feature.
There are more use cases or flexibility to developer if we support Conditional
compilation support in INF.
As we're providing support in
Hi Ard,
Some minor feedback added inline.
On 2019/1/4 2:28, Ard Biesheuvel wrote:
In preparation of providing a standalone MM based variable runtime
driver, move the existing SMM driver to the new MM services table,
and factor out some pieces that are specific to the traditional
driver, mainly
Hi Ard,
Another minor feedback.
On 2019/1/10 14:47, Zeng, Star wrote:
Hi Ard,
Some minor feedback added inline.
On 2019/1/4 2:28, Ard Biesheuvel wrote:
Implement a new version of the fault tolerant write driver that can
be used in the context of a standalone MM implementation.
Hi Ard,
Some minor feedback added below.
With them handled, Reviewed-by: Sta Zeng .
On 2019/1/4 2:28, Ard Biesheuvel wrote:
Reuse most of the existing code to implement a variable runtime
driver that will be able to execute in the context of standalone
MM.
Contributed-under: TianoCore
Hi Ard,
Some minor feedback added inline.
On 2019/1/4 2:28, Ard Biesheuvel wrote:
Implement a new version of the fault tolerant write driver that can
be used in the context of a standalone MM implementation.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
Hi Ard,
Another minor feedback.
On 2019/1/10 14:14, Zeng, Star wrote:
Hi Ard,
Some minor feedback added inline.
On 2019/1/4 2:28, Ard Biesheuvel wrote:
The definitions of the rebranded MM protocol stack were chosen such
that the existing SMM based core drivers can be reused. So let's
On Thu, 10 Jan 2019 at 08:30, Zeng, Star wrote:
>
> Hi Ard,
>
> Another minor feedback.
>
> On 2019/1/10 14:47, Zeng, Star wrote:
> > Hi Ard,
> >
> > Some minor feedback added inline.
> >
> > On 2019/1/4 2:28, Ard Biesheuvel wrote:
> >> Implement a new version of the fault tolerant write driver
On 01/08/19 19:05, Carsey, Jaben wrote:
>
>
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Tuesday, January 08, 2019 9:26 AM
>> To: Carsey, Jaben ; Gao, Liming
>> ; Ni, Ray ; edk2-
>> de...@lists.01.org; leif.lindh...@linaro.org; af...@apple.com; Kinney,
On 01/09/19 11:28, Ard Biesheuvel wrote:
> On Wed, 9 Jan 2019 at 10:44, Laszlo Ersek wrote:
>> But, it's still not clear to me (without trying) whether I should
>> resolve MmServicesTableLib for DXE_SMM_DRIVER in addition to
>> SmmServicesTableLib, or in its place. I'd prefer not experimenting
On 01/09/19 10:59, Ruiyu Ni wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ray Ni
> Cc: Liming Gao
> ---
> Maintainers.txt | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
And I'll update my address book in Thunderbird :)
> diff
On Wed, 9 Jan 2019 at 14:56, Gao, Liming wrote:
>
> Ard:
> Now, the impact is to update platform DSC to include MmServicesTableLib
> library instance. This change is acceptable for me. I suggest your create one
> BZ for this patch set.
https://bugzilla.tianocore.org/show_bug.cgi?id=1442
>
Ard:
Now, the impact is to update platform DSC to include MmServicesTableLib
library instance. This change is acceptable for me. I suggest your create one
BZ for this patch set.
Besides, I can't apply for these patches in my machine. Could you share git
branch to me? Then, I can further
On 01/09/19 13:42, Gao, Liming wrote:
> Laszlo:
> INF Spec: FixedAtBuild (VOID*) PCD use in the [DEPEX] section has been
> added into INF spec git book
> (g...@github.com:tianocore-docs/edk2-InfSpecification.git). BZ
> https://bugzilla.tianocore.org/show_bug.cgi?id=444
> The change is in
Laszlo:
INF Spec: FixedAtBuild (VOID*) PCD use in the [DEPEX] section has been added
into INF spec git book
(g...@github.com:tianocore-docs/edk2-InfSpecification.git). BZ
https://bugzilla.tianocore.org/show_bug.cgi?id=444
The change is in INF spec trunk. New version INF spec will include
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1433
Current logic of shell tftp download was writing file after tftp
download finished, when the file is large, it looks like the shell
tftp command hanged after download was finished. To improve
end-user experience, the solution is using split
Hi Eric,
On 01/09/19 06:26, Dong, Eric wrote:
> Hi all,
>
> We got some feedback about this BZ. Someone think this timeout is valuable
> for the debug purpose, and oppose to remove it.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1419
>
> So I'm back to here and want to still use this
Hi Jaben,
I have a minor comment
In GenFds, The following code is duplicated within GenFds.py
+from re import compile
Thanks,
Bob
-Original Message-
From: Carsey, Jaben
Sent: Wednesday, January 9, 2019 7:00 AM
To: edk2-devel@lists.01.org
Cc: Feng, Bob C ; Gao, Liming
Subject: [Patch
On 01/03/19 19:28, Ard Biesheuvel wrote:
> This series proposed an alternative approach to the series sent out by
> Jagadeesh [0]. In particular, it gets rid of the InMm() calls and the
> special PCD, as well as some other if() conditionals.
>
> The primary difference is that this series defines
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ray Ni
Cc: Liming Gao
---
Maintainers.txt | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 7f2f9de79f..3b2676bc32 100644
--- a/Maintainers.txt
On Wed, 9 Jan 2019 at 10:44, Laszlo Ersek wrote:
>
> On 01/03/19 19:28, Ard Biesheuvel wrote:
> > This series proposed an alternative approach to the series sent out by
> > Jagadeesh [0]. In particular, it gets rid of the InMm() calls and the
> > special PCD, as well as some other if()
From: "Feng, Bob C"
https://bugzilla.tianocore.org/show_bug.cgi?id=1350
Remove IA64 support from BaseTools C code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng
Cc: Liming Gao
Cc: Jaben Carsey
---
BaseTools/Source/C/Common/BasePeCoff.c| 14 +-
From: "Feng, Bob C"
https://bugzilla.tianocore.org/show_bug.cgi?id=1350
Remove ECP support from BaseTools C code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng
Cc: Liming Gao
Cc: Jaben Carsey
---
BaseTools/Source/C/Include/IndustryStandard/pci22.h | 1 -
1
On 01/09/19 07:55, karunakarpoosapa...@dell.com wrote:
> Hi ALL,
>
>
>
> I've an idea regards "Adding conditional compilation support in INF files"
>
>
>
> Ides is like, we can condition check in INF file like below
>
>
>
> #if Condition1
>
>Protocol1
>
> #elif Condition2
>
>
Liming,
I think that the user should not need to set PYTHON3_ENABLE at all if they
manually set PYTHON_COMMAND.
-Jaben
> -Original Message-
> From: Gao, Liming
> Sent: Tuesday, January 08, 2019 4:43 PM
> To: Carsey, Jaben ; Laszlo Ersek
> ; Ni, Ray ; edk2-devel@lists.01.org;
>
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Feng, Bob C
> Sent: Tuesday, January 08, 2019 11:15 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming
> ; Carsey, Jaben
> Subject: [Patch 1/3 V2] BaseTools: Remove unused logic for EDKI
> Importance: High
>
> From:
Reviewed-by: Jaben Carsey
Note: in BaseTools/Source/C/EfiRom/EfiRom.h. it looks like you both delete and
add EBC.
> -Original Message-
> From: Feng, Bob C
> Sent: Wednesday, January 09, 2019 12:34 AM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming
> ; Carsey, Jaben
>
I did the work last year so I didn't do anything but the email this year...
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, January 08, 2019 5:18 PM
> To: Carsey, Jaben ; edk2-devel@lists.01.org
> Cc: Wang, Jian J ; Zeng, Star
> Subject: RE: [Patch v1 1/1] MdeModulePkg: fix
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Feng, Bob C
> Sent: Wednesday, January 09, 2019 12:35 AM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming
> ; Carsey, Jaben
> Subject: [Patch 3/3 V2] BaseTools: Remove unused ECP related code from C
> tools
>
1 - Some of these imports are cascaded from another file. Import them locally.
2 - Some of these imports are not used. Remove them.
3 - Some of these were missing the namespace used to import them.
These changes facilitate optimization of BaseTools:
An issue was seen in IScsiDxe in NetworkPkg where driver cleanup after
initialization failure was not done right. Bug 1428 was filed in this regard.
As per discussions with Mike, it was also discussed that having UEFILib
provide protocol uninstallation abstraction would help to avoid these
issues
Provided functions in UEFILib that abstract driver model protocol
uninstallation. This helps drivers to install and uninstall protocols
using a library to keep things seemless.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1429
Contributed-under: TianoCore Contribution Agreement 1.1
During cleanup in case of initialization failure, some driver
bindings are not installed. Using abstractions in UEFILib takes
care of it.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1428
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
On 01/09/19 16:04, Laszlo Ersek wrote:
> On 01/09/19 11:28, Ard Biesheuvel wrote:
>> In the mean time, the hunk below should suffice to complete your
>> regression testing.
I used:
> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> index 3f3533e5c163..908450eda174 100644
> ---
On Wed, 9 Jan 2019 at 22:46, Laszlo Ersek wrote:
>
> On 01/09/19 16:04, Laszlo Ersek wrote:
> > On 01/09/19 11:28, Ard Biesheuvel wrote:
> >> In the mean time, the hunk below should suffice to complete your
> >> regression testing.
>
> I used:
>
> > diff --git a/OvmfPkg/OvmfPkgIa32.dsc
68 matches
Mail list logo
