Re: [edk2] [PATCH 3/3] UefiCpuPkg/SecCore: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-12 Thread Laszlo Ersek
On 02/12/19 14:19, Chasel, Chiu wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1524 > > EFI_PEI_CORE_FV_LOCATION_PPI may be passed by platform > when PeiCore not in BFV so SecCore has to search PeiCore > either from the FV location provided by > EFI_PEI_CORE_FV_LOCATION_PPI or from

[edk2] 3rd Party Python Packages

2019-02-12 Thread Carsey, Jaben
Note: deviating from "RE: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function" Laszlo, Since I am working on some research related to this, I have a few follow up questions. If there is significant performance improvement, how would you feel about requiring a 3rd party package to be

Re: [edk2] [PATCH edk2-platforms v1 11/16] Hisilicon/D06: Add Setup Item "Support DPC"

2019-02-12 Thread Ming Huang
On 2/12/2019 3:46 AM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 09:34:31PM +0800, Ming Huang wrote: >> Add setup item "Support DPC" to enable or disable PCIe DPC >> (Downstream Port Containment). > > This patch also seems to disable the SRIOV configuration and delete a > lot of ports. Can

Re: [edk2] [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function

2019-02-12 Thread Ming Huang
On 2/12/2019 8:17 PM, Leif Lindholm wrote: > On Tue, Feb 12, 2019 at 08:07:52PM +0800, Ming Huang wrote: For D06 library, we use the same source code to support all Hi1620 projects, include product projects,so there are some modify for this, like support 3 sockets, 4

Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function

2019-02-12 Thread Gao, Liming
Laszlo: To install python3-distutils should resolve this issue. I expect BaseTools build functionality doesn't depend on the third party python lib. So, I suggest to check whether python3-distutils is the native python library. If it is native python library, why Ubuntu18 doesn't include it. I

Re: [edk2] [PATCH edk2-platforms v1 08/16] Hisilicon/D06: Change HCCS speed from 30G to 26G

2019-02-12 Thread Leif Lindholm
On Tue, Feb 12, 2019 at 10:45:05PM +0800, Ming Huang wrote: > > > On 2/12/2019 2:36 AM, Leif Lindholm wrote: > > On Fri, Feb 01, 2019 at 09:34:28PM +0800, Ming Huang wrote: > >> Follow chip team suggestion to change HCCS(Huawei Cache-Coherent > >> System) speed from 30G to 26G, this modification

Re: [edk2] [PATCH edk2-non-osi v1 5/7] Hisilicon/D06: Use new flash layout

2019-02-12 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 10:25:05PM +0800, Ming Huang wrote: > In new flash layout, BIOS fd change from offset 1M to 8M in 16M > spi flash. I think I covered all of the layout questions in the corresponding edk2-platforms patch. > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [PATCH edk2-platforms v1 05/16] Hisilicon/D06: Add more PCIe port INT-x support

2019-02-12 Thread Ming Huang
On 2/12/2019 1:05 AM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 09:34:25PM +0800, Ming Huang wrote: >> From: Jason Zhang >> >> Since NVMe riser width is 6*X4, need add the related >> port's INT-x support to match OS driver. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >>

Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function

2019-02-12 Thread Laszlo Ersek
On 02/12/19 14:33, Gao, Liming wrote: > Laszlo: > To install python3-distutils should resolve this issue. I expect BaseTools > build functionality doesn't depend on the third party python lib. I completely agree with your expectation, regarding *3rd party* python packages. We shouldn't expect

Re: [edk2] 3rd Party Python Packages

2019-02-12 Thread Laszlo Ersek
On 02/12/19 16:22, Carsey, Jaben wrote: > Note: deviating from "RE: [edk2] [Patch 0/3] BaseTools: Implement splitquoted > function" > > Laszlo, > > Since I am working on some research related to this, I have a few follow up > questions. > > If there is significant performance improvement, how

Re: [edk2] [PATCH edk2-non-osi v1 1/7] Hisilicon/D06: Optimize SAS driver for reducing boot time

2019-02-12 Thread Leif Lindholm
Change the subject line to: Hisilicon/D06: remove PCI enumeration dependency from SAS driver On Fri, Feb 01, 2019 at 10:25:01PM +0800, Ming Huang wrote: > SAS controller is always existed, so accessing SAS register don't > depend on PciBusDxe (pci enumeration). Modify SAS driver remove the >

Re: [edk2] [PATCH edk2-non-osi v1 4/7] Hisilicon/D06: Support PCIe local RAS

2019-02-12 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 10:25:04PM +0800, Ming Huang wrote: > Add some registers configuration in PcieRasInitDxe and add PCIe > local RAS interrupt handle in trusted firmware to support PCIe > local RAS. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang

[edk2] [PATCH 0/3] Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-12 Thread Chasel, Chiu
PI spec 1.7 section 6.3.9 has defined a PPI to support the scenario that PEI Foundation not in BFV. EFI_PEI_CORE_FV_LOCATION_PPI reports the FV which contains PEI Foundation and should be passed by SEC as part of PPI list. Otherwise PEI Foundation shall assume that it resides in BFV. Patch1: Add

[edk2] [PATCH 1/3] MdePkg: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-12 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1524 Add EFI_PEI_CORE_FV_LOCATION_PPI definition basing on PI spec 1.7, Section 6.3.9. This PPI can support the secnario that PEI Foundation not in BFV. Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH 3/3] UefiCpuPkg/SecCore: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-12 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1524 EFI_PEI_CORE_FV_LOCATION_PPI may be passed by platform when PeiCore not in BFV so SecCore has to search PeiCore either from the FV location provided by EFI_PEI_CORE_FV_LOCATION_PPI or from BFV. Test: Verified on internal platform and

[edk2] [PATCH 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-12 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1524 When shadowing PeiCore the EFI_PEI_CORE_FV_LOCATION_PPI should be checked to see if PeiCore not in BFV, otherwise just shadowing PeiCore from BFV. Test: Verified on internal platform and booting successfully. Cc: Jian J Wang Cc: Hao Wu

Re: [edk2] [PATCH edk2-platforms v1 03/16] Hisilicon/D06: Optimize SAS driver for reducing boot time

2019-02-12 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 09:34:23PM +0800, Ming Huang wrote: > SAS controller is always existed, so accessing SAS register don't > depend on PciBusDxe (pci enumeration). > Move the SAS module early in D06.fdf for dispatching SAS driver > early. This can avoid wait in BDS normally and reduce boot

Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function

2019-02-12 Thread Laszlo Ersek
On 02/04/19 20:12, Laszlo Ersek wrote: > On 02/03/19 06:55, Feng, Bob C wrote: >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1509 >> On some Linux environment, there may be no distutils.util >> library for python3 that will cause build tool crash. >> This patch implement

Re: [edk2] [PATCH edk2-platforms v1 10/16] Hisilicon/D06: Modify for M7 self-Adapte support

2019-02-12 Thread Ming Huang
On 2/12/2019 3:28 AM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 09:34:30PM +0800, Ming Huang wrote: >> As new M7(Cortex-M7) firmware support self-adapte, so do not >> need BIOS to implement some function, remove useless funtions >> and report CPU0/CPU1 Nic NCL offset to M7. > > I don't

Re: [edk2] [PATCH edk2-non-osi v1 7/7] Hisilicon/D06: Add Setup Item "Support DPC"

2019-02-12 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 10:25:07PM +0800, Ming Huang wrote: > Add setup item "Support DPC" to enable or disable PCIe DPC > (Downstream Port Containment). > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm > --- >

Re: [edk2] [PATCH edk2-platforms v1 10/16] Hisilicon/D06: Modify for M7 self-Adapte support

2019-02-12 Thread Leif Lindholm
On Tue, Feb 12, 2019 at 11:14:43PM +0800, Ming Huang wrote: > > > On 2/12/2019 3:28 AM, Leif Lindholm wrote: > > On Fri, Feb 01, 2019 at 09:34:30PM +0800, Ming Huang wrote: > >> As new M7(Cortex-M7) firmware support self-adapte, so do not > >> need BIOS to implement some function, remove useless

Re: [edk2] [PATCH edk2-non-osi v1 1/7] Hisilicon/D06: Optimize SAS driver for reducing boot time

2019-02-12 Thread Ming Huang
On 2/12/2019 11:20 PM, Leif Lindholm wrote: > Change the subject line to: > Hisilicon/D06: remove PCI enumeration dependency from SAS driver > > On Fri, Feb 01, 2019 at 10:25:01PM +0800, Ming Huang wrote: >> SAS controller is always existed, so accessing SAS register don't >> depend on

Re: [edk2] [PATCH edk2-platforms v1 11/16] Hisilicon/D06: Add Setup Item "Support DPC"

2019-02-12 Thread Leif Lindholm
On Tue, Feb 12, 2019 at 11:22:24PM +0800, Ming Huang wrote: > On 2/12/2019 3:46 AM, Leif Lindholm wrote: > > On Fri, Feb 01, 2019 at 09:34:31PM +0800, Ming Huang wrote: > >> Add setup item "Support DPC" to enable or disable PCIe DPC > >> (Downstream Port Containment). > > > > This patch also

[edk2] [PATCH edk2-non-osi v2 1/1] Platform/Socionext: uprev TF-A binary

2019-02-12 Thread Sumit Garg
Update TF-A to upstream v2.0 release + synquacer-spm changes (Commit: e86e202c2e4e). Also update OP-TEE to upstream v3.4.0 release (Commit: 406c609bbf08). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sumit Garg --- Changes in v2: Include synquacer-spm patches and some

Re: [edk2] [PATCH edk2-platforms v1 08/16] Hisilicon/D06: Change HCCS speed from 30G to 26G

2019-02-12 Thread Ming Huang
On 2/12/2019 2:36 AM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 09:34:28PM +0800, Ming Huang wrote: >> Follow chip team suggestion to change HCCS(Huawei Cache-Coherent >> System) speed from 30G to 26G, this modification can avoid some >> unstable stress issue. >> >> Contributed-under:

Re: [edk2] [PATCH edk2-platforms v1 04/16] Hisilicon/D06: Fix access variable fail issue

2019-02-12 Thread Leif Lindholm
On Fri, Feb 01, 2019 at 09:34:24PM +0800, Ming Huang wrote: > From: Jason Zhang > > BmcWdtEnable is a field of OemConfigData structure, need have > runtime service attribution if use it during exit boot service This sounds like a very shady thing to do. Which module is seeing issues, and what

Re: [edk2] [PATCH 1/1] EmbeddedPkg/Library: Add VirtualRealTimeClockLib

2019-02-12 Thread Leif Lindholm
On Mon, Feb 04, 2019 at 12:47:36PM +, Pete Batard wrote: > This is designed to be used on platforms where a a real RTC is not > available and relies on an RtcEpochSeconds variable having been set or, > if that is not the case, falls back to using the epoch embedded at > compilation time. > >

Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function

2019-02-12 Thread Laszlo Ersek
On 02/12/19 18:16, Philippe Mathieu-Daudé wrote: > On 2/12/19 3:02 PM, Laszlo Ersek wrote: >> On 02/12/19 14:33, Gao, Liming wrote: >>> Laszlo: >>> To install python3-distutils should resolve this issue. I expect BaseTools >>> build functionality doesn't depend on the third party python lib. >>

Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function

2019-02-12 Thread Philippe Mathieu-Daudé
On 2/12/19 3:02 PM, Laszlo Ersek wrote: > On 02/12/19 14:33, Gao, Liming wrote: >> Laszlo: >> To install python3-distutils should resolve this issue. I expect BaseTools >> build functionality doesn't depend on the third party python lib. > > I completely agree with your expectation, regarding

[edk2] [PATCH v3] MdeModulePkg/CapsuleApp: Fix memory leak issue.

2019-02-12 Thread Chen A Chen
This issue is caused by FileInfoBuffer variable. This is a pointer array and each elements also pointer to a memory buffer that is allocated and returned by AllocateCopyPool function. Cc: Jian J Wang Cc: Hao Wu Cc: Zhang Chao B Cc: Liming Gao Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH v3 07/10] OvmfPkg/README: Remove UNIXGCC

2019-02-12 Thread Laszlo Ersek
Hi, On 02/13/19 02:42, Shenglei Zhang wrote: > Remove UNIXGCC in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc > and OvmfPkgX64.dsc. > Remove content related to UNIXGCC in README. > https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc:

[edk2] [Patch 3/3] UefiCpuPkg/RegisterCpuFeaturesLib: Simplify PcdCpuFeaturesSupport.

2019-02-12 Thread Eric Dong
PcdCpuFeaturesSupport used to specify the platform policy about what CPU features this platform supports. This value is decide by platform owner, not by hardware. After this change, this PCD will be used in IsCpuFeatureSupported function only. Now RegisterCpuFeaturesLib use this PCD as an

[edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Remove useless functions.

2019-02-12 Thread Eric Dong
Remove useless APIs, simply the code logic. BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1375 Cc: Ray Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- .../Include/Library/RegisterCpuFeaturesLib.h | 34 ---

[edk2] [Patch 2/3] UefiCpuPkg/RegisterCpuFeaturesLib: Optimize PCD PcdCpuFeaturesUserConfiguration.

2019-02-12 Thread Eric Dong
In current implementation, PCD PcdCpuFeaturesUserConfiguration used as user enabled CPU features list. It is initialzied in platform driver and as an input for CpuFeatures driver. PCD PcdCpuFeaturesSetting used as an output for the final enabled CPU features list. For now,

[edk2] [Patch 0/3] Simplify CPU Features solution.

2019-02-12 Thread Eric Dong
Changes includes: 1. Optimize PCD PcdCpuFeaturesUserConfiguration 2. Limit useage of PcdCpuFeaturesSupport 3. Remove some useless APIs. Detail explanation please check each patch's introduction. Cc: Ray Ni Cc: Laszlo Ersek Eric Dong (3): UefiCpuPkg/RegisterCpuFeaturesLib: Remove useless

Re: [edk2] [PATCH 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-12 Thread Chiu, Chasel
No issue, I will remove UINT32 casting. Thanks! > -Original Message- > From: Wang, Jian J > Sent: Wednesday, February 13, 2019 9:14 AM > To: Chiu, Chasel ; edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ni, Ray ; Zeng, Star > ; Gao, Liming > Subject: RE: [PATCH 2/3] MdeModulePkg/PeiMain:

[edk2] [Patch edk2 Wiki] Add three features for edk2-stable201903

2019-02-12 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- EDK-II-Release-Planning.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md index f302be3..095da69 100644 ---

Re: [edk2] OVMF and TCP4, HTTP protocols

2019-02-12 Thread Laszlo Ersek
On 02/13/19 05:28, Rebecca Cran wrote: > On February 6, 2019 at 4:08:03 PM, Rebecca Cran via edk2-devel > (edk2-devel@lists.01.org ) wrote: >> >> Oh, that makes sense! Thanks, after disabling the existing code that was  >> opening SNP exclusively, things started

Re: [edk2] [PATCH edk2-platforms v1 09/16] Hisilicon/D06: Add PCI_OSC_SUPPORT

2019-02-12 Thread Ming Huang
On 2/12/2019 2:51 AM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 09:34:29PM +0800, Ming Huang wrote: >> Add PCI_OSC_SUPPORT for remaining host bridges to remove fail >> output in kernel: >> [ 103.478893] acpi PNP0A08:01: _OSC failed (AE_NOT_FOUND); >> >> Contributed-under: TianoCore

[edk2] [Patch edk2 wiki] Add new feature: WiFi Connection Manager for edk2-stable201903 in EDK-II-Release-Planning

2019-02-12 Thread Wang Fan
Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wang Fan --- EDK-II-Release-Planning.md | 1 + 1 file changed, 1 insertion(+) diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md index f302be3..eba2afe 100644 ---

Re: [edk2] [PATCH v3] MdeModulePkg/CapsuleApp: Fix memory leak issue.

2019-02-12 Thread Wu, Hao A
> -Original Message- > From: Chen, Chen A > Sent: Wednesday, February 13, 2019 8:53 AM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A; Wang, Jian J; Wu, Hao A; Zhang, Chao B; Gao, Liming > Subject: [PATCH v3] MdeModulePkg/CapsuleApp: Fix memory leak issue. > > This issue is caused by

Re: [edk2] [PATCH v5 edk2-platforms 00/22] Platform/RaspberryPi: Add Raspberry Pi 3 support

2019-02-12 Thread Jeremy Linton
the Hi, On 2/5/19 10:25 AM, Pete Batard wrote: Changes for v5: * Raspberry/Pi3 -> RaspberryPi/RPi3 * Remove VirtualRealTimeClockLib as well as BUILD_EPOCH macro (use the upcoming EmbeddedPkg Virtual RTC from EDK2 instead) * Use $(PLATFORM_NAME) where possible in .dsc and .fdf * Update

Re: [edk2] [PATCH edk2-platforms v1 15/16] Hisilicon/D06: Use CalculateCrc16 in BaseLib

2019-02-12 Thread Ming Huang
On 2/12/2019 4:52 AM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 10:29:06PM +0800, Ming Huang wrote: >> This patch is relative with "Add new API CalculateCrc16()" in edk2. > > The commit message should describe what the patch does. > I don't mind keeping the above line in, but we also need

[edk2] [PATCH] SecurityPkg/OpalPassword: Update strings on Opal Setup page

2019-02-12 Thread Maggie Chu
https://bugzilla.tianocore.org/show_bug.cgi?id=1506 Updated some descriptions on SETUP page to avoid user confusion. Currently it shows "1.0 UEFI Opal Driver", however it may be mislead user to think it is only for Opal drive but not for Pyrite drive. Contributed-under: TianoCore Contribution

Re: [edk2] [Patch 2/3] UefiCpuPkg/RegisterCpuFeaturesLib: Optimize PCD PcdCpuFeaturesUserConfiguration.

2019-02-12 Thread Laszlo Ersek
On 02/13/19 03:04, Eric Dong wrote: > In current implementation, PCD PcdCpuFeaturesUserConfiguration used as > user enabled CPU features list. It is initialzied in platform driver > and as an input for CpuFeatures driver. PCD PcdCpuFeaturesSetting used > as an output for the final enabled CPU

Re: [edk2] [PATCH edk2-platforms v1 12/16] Hisilicon/D06: Use new flash layout

2019-02-12 Thread Ming Huang
On 2/11/2019 10:54 PM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 09:34:32PM +0800, Ming Huang wrote: >> In new flash layout, BIOS fd change from offset 1M to 8M in 16M >> spi flash. > > This bit > >> Use the new CustomData.Fv which indicate the offset >> of fd and which flash area can be

Re: [edk2] [PATCH edk2-platforms v1 03/16] Hisilicon/D06: Optimize SAS driver for reducing boot time

2019-02-12 Thread Ming Huang
On 2/12/2019 11:12 PM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 09:34:23PM +0800, Ming Huang wrote: >> SAS controller is always existed, so accessing SAS register don't >> depend on PciBusDxe (pci enumeration). >> Move the SAS module early in D06.fdf for dispatching SAS driver >> early.

Re: [edk2] [PATCH v2 0/3] MdeModulePkg/PciBus: Fix a bug PPB MEM32 BAR isn't restored sometimes

2019-02-12 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ray Ni > Sent: Tuesday, February 12, 2019 5:48 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2 0/3] MdeModulePkg/PciBus: Fix a bug PPB MEM32 > BAR isn't restored sometimes > > REF:

Re: [edk2] [Patch 3/3] UefiCpuPkg/RegisterCpuFeaturesLib: Simplify PcdCpuFeaturesSupport.

2019-02-12 Thread Laszlo Ersek
On 02/13/19 03:04, Eric Dong wrote: > PcdCpuFeaturesSupport used to specify the platform policy about > what CPU features this platform supports. This value is decide by > platform owner, not by hardware. After this change, this PCD will > be used in IsCpuFeatureSupported function only. > > Now

Re: [edk2] OVMF and TCP4, HTTP protocols

2019-02-12 Thread Rebecca Cran via edk2-devel
On February 6, 2019 at 4:08:03 PM, Rebecca Cran via edk2-devel (edk2-devel@lists.01.org) wrote: Oh, that makes sense! Thanks, after disabling the existing code that was  opening SNP exclusively, things started working much better.  I have a follow-up question. After opening the

Re: [edk2] [PATCH edk2-platforms v1 10/16] Hisilicon/D06: Modify for M7 self-Adapte support

2019-02-12 Thread Ming Huang
On 2/12/2019 11:46 PM, Leif Lindholm wrote: > On Tue, Feb 12, 2019 at 11:14:43PM +0800, Ming Huang wrote: >> >> >> On 2/12/2019 3:28 AM, Leif Lindholm wrote: >>> On Fri, Feb 01, 2019 at 09:34:30PM +0800, Ming Huang wrote: As new M7(Cortex-M7) firmware support self-adapte, so do not

Re: [edk2] [PATCH 00/14] ArmVirtPkg: clean up set-but-unused PCDs

2019-02-12 Thread Laszlo Ersek
On 02/06/19 13:10, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: armvirt_pcd_clean > > (1) The procedure described below depends on: > > [edk2] [PATCH] > BaseTools/BuildReport: fix report for platforms/arches without struct PCDs > >

Re: [edk2] [PATCH edk2-platforms v1 01/16] Hisilicon/D0x: Remove SerdesLib

2019-02-12 Thread Ming Huang
On 2/11/2019 11:05 PM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 09:34:21PM +0800, Ming Huang wrote: >> SerdesLib is useless for SmbiosMiscDxe and D06, so remove it. > > Should it not then also delete #include from > Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c, >

[edk2] [PATCH 3/3] MdeModulePkg/SmmS3SaveStateDxe: Change function parameter types

2019-02-12 Thread Shenglei Zhang
Change parameter Opcode from UINT16 to UINTN in BootScriptWrite and BootScriptInsert. https://bugzilla.tianocore.org/show_bug.cgi?id=1517 Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH 2/3] MdeModulePkg/S3SaveStateDxe: Change function parameter types

2019-02-12 Thread Shenglei Zhang
Change parameter Opcode from UINT16 to UINTN in BootScriptWrite and BootScriptInsert. https://bugzilla.tianocore.org/show_bug.cgi?id=1517 Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH 1/3] MdePkg: Change structure parameter types

2019-02-12 Thread Shenglei Zhang
Change parameter Opcode from UINT16 to UINTN in EFI_S3_SAVE_STATE_WRITE and EFI_S3_SAVE_STATE_INSERT. https://bugzilla.tianocore.org/show_bug.cgi?id=1517 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH 0/3] Change parameters' type in MdePkg and MdeModulePkg

2019-02-12 Thread Shenglei Zhang
Change parameters' type according to the new spec PI 1.7. https://bugzilla.tianocore.org/show_bug.cgi?id=1517 Cc: Michael D Kinney Cc: Liming Gao Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Shenglei Zhang (3): MdePkg: Change structure parameter types MdeModulePkg/S3SaveStateDxe:

Re: [edk2] [PATCH] MdePkg/BaseLib: implement SpeculationBarrier() for ARM and AArch64

2019-02-12 Thread Ard Biesheuvel
On Tue, 12 Feb 2019 at 01:26, Gao, Liming wrote: > > Ard: > I agree your comments not to add PCD until there is the real problem. > Pushed as 1a35dd723bbf..c0959b4426b2 Thanks all > Thanks > Liming > >-Original Message- > >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] [PATCH v1 1/1] MdeModulePkg/NvmExpressDxe: Report StatusCode for device init failure

2019-02-12 Thread Ni, Ray
On 2/11/2019 3:57 PM, Hao Wu wrote: From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1408 According to the information of the above BZ-1408 and other platform owners, NVM Express devices are becoming more likely to be a critical part during the boot process. This commit

Re: [edk2] [PATCH v4 02/13] MdeModulePkg: Add definitions for EDKII PEI ATA PassThru PPI

2019-02-12 Thread Ni, Ray
On 2/11/2019 3:57 PM, Hao Wu wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the definitions for EDKII PEI ATA PassThru PPI. This PPI will provide services that allow ATA commands to be sent to ATA devices attached to an ATA controller in the PEI phase. More

Re: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Remove useless functions.

2019-02-12 Thread Laszlo Ersek
On 02/13/19 03:04, Eric Dong wrote: > Remove useless APIs, simply the code logic. s/simply/simplify/ > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1375 > > Cc: Ray Ni > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong > --- >

Re: [edk2] [PATCH 2/3] MdeModulePkg/PeiMain: Support EFI_PEI_CORE_FV_LOCATION_PPI

2019-02-12 Thread Wang, Jian J
Chasel, > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, February 12, 2019 9:20 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Zeng, Star ; Gao, Liming > ; Chiu, Chasel > Subject: [PATCH 2/3] MdeModulePkg/PeiMain: Support >

[edk2] [PATCH v3 09/10] BaseTools/tools_def.template: Remove DDK3790

2019-02-12 Thread Shenglei Zhang
DDK3790 is too old.There is no verification for it. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 v3:Reserve WINDDK_BIN32 and WINDDK_BIN64. Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH v3 04/10] BaseTools/tools_def.template: Remove VS2003 and VS2005

2019-02-12 Thread Shenglei Zhang
VS2003 and VS2005 are too old.There is no verification for them. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 v3:1.Instead of removing MS_VS_BIN, change MS_VS_BIN from VS2005_BIN to VS2008_BIN. 2.Instead of removing MS_VS_DLL, change MS_VS_DLL from VS2005_DLL to VS2008_DLL.

[edk2] [PATCH v3 06/10] BaseTools/tools_def.template: Remove UNIXGCC

2019-02-12 Thread Shenglei Zhang
UNIXGCC is too old.There is no verification for it. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Laszlo Ersek ---

[edk2] [PATCH v3 02/10] OptionRomPkg/ReadMe.txt: Remove CYGGCC

2019-02-12 Thread Shenglei Zhang
Remove CYGGCC in Build Validation. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Ray Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Laszlo Ersek --- OptionRomPkg/ReadMe.txt | 1 - 1 file changed, 1 deletion(-) diff --git

[edk2] [PATCH v3 01/10] BaseTools/tools_def.template: Remove CYGGCC

2019-02-12 Thread Shenglei Zhang
CYGGCC is too old.There is no verification for it. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- BaseTools/Conf/tools_def.template | 194

[edk2] [PATCH v3 03/10] BaseTools: Update MYTOOLS

2019-02-12 Thread Shenglei Zhang
Remove MYTOOLS in tools_def.template and change MYTOOLS to VS2015x86 in target.template. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH v3 05/10] OptionRomPkg/ReadMe.txt: Remove VS2005

2019-02-12 Thread Shenglei Zhang
Remove VS2005 in Build Validation. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Ray Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- OptionRomPkg/ReadMe.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/OptionRomPkg/ReadMe.txt

[edk2] [PATCH v3 07/10] OvmfPkg/README: Remove UNIXGCC

2019-02-12 Thread Shenglei Zhang
Remove UNIXGCC in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc and OvmfPkgX64.dsc. Remove content related to UNIXGCC in README. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Anthony Perard Cc: Julien Grall Contributed-under: TianoCore

[edk2] [PATCH v3 08/10] BaseTools/tools_def.template: Remove ELFGCC

2019-02-12 Thread Shenglei Zhang
ELFGCC is too old.There is no verification for it. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- BaseTools/Conf/tools_def.template | 80

[edk2] [PATCH v3 00/10] Remove unused tool chain configuration

2019-02-12 Thread Shenglei Zhang
VS2003, VS2005, DDK3790, UNIXGCC, ELFGCC, CYGCC and MYTOOLS are too old. There is no verification for them. So remove them from edk2/master. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 v2:1.Combine previous 05/10 and 06/10 to 05/10. 2.Add 10/10(Remove GCCLD). v3:1.Change order of

Re: [edk2] [PATCH v4 04/13] MdeModulePkg: Add GUID for LockBox to save storage dev to init in S3

2019-02-12 Thread Ni, Ray
Reviewed-by: Ray Ni -- Thanks, Ray ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v3 10/10] BaseTools/build_rule.template: Remove GCCLD

2019-02-12 Thread Shenglei Zhang
GCCLD will be unused when UNIXGCC, CYGGCC and ELFGCC are removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- BaseTools/Conf/build_rule.template | 33

Re: [edk2] [PATCH v4 12/13] OvmfPkg/LockBoxLib: Update the comments for API UpdateLockBox()

2019-02-12 Thread Ni, Ray
Reviewed-by: Ray Ni -- Thanks, Ray ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH edk2-platforms v1 04/16] Hisilicon/D06: Fix access variable fail issue

2019-02-12 Thread Ming Huang
On 2/12/2019 11:17 PM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 09:34:24PM +0800, Ming Huang wrote: >> From: Jason Zhang >> >> BmcWdtEnable is a field of OemConfigData structure, need have >> runtime service attribution if use it during exit boot service > > This sounds like a very

Re: [edk2] [PATCH edk2-platforms v1 06/16] Hisilicon/D06: Add OemGetCpuFreq to encapsulate difference

2019-02-12 Thread Ming Huang
On 2/12/2019 1:15 AM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 09:34:26PM +0800, Ming Huang wrote: >> From: xingjiang tang >> >> Implementation OemGetCpuFreq() to get cpu frequency from cpld to >> encapsulate project difference, for some projects don't support >> get cpu frequency by

Re: [edk2] [PATCH edk2-non-osi v1 3/7] Hisilicon/D06: Update Mbigen and gic RAS register

2019-02-12 Thread Ming Huang
On 2/12/2019 5:38 AM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 10:25:03PM +0800, Ming Huang wrote: >> As chip group suggestions, update Mbigen and gic RAS configuration >> flow. > > Update how? Add below flow: 1 Reset Mbigen; 2 Disable Mbigen clock; 3 Deassert reset Mbigen; 4 Enable

Re: [edk2] [PATCH edk2-non-osi v1 3/7] Hisilicon/D06: Update Mbigen and gic RAS register

2019-02-12 Thread Leif Lindholm
On Tue, Feb 12, 2019 at 07:42:55PM +0800, Ming Huang wrote: > > > On 2/12/2019 5:38 AM, Leif Lindholm wrote: > > On Fri, Feb 01, 2019 at 10:25:03PM +0800, Ming Huang wrote: > >> As chip group suggestions, update Mbigen and gic RAS configuration > >> flow. > > > > Update how? > > Add below

Re: [edk2] [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function

2019-02-12 Thread Ming Huang
On 2/12/2019 6:44 PM, Leif Lindholm wrote: > On Tue, Feb 12, 2019 at 04:05:50PM +0800, Ming Huang wrote: >> On 2/12/2019 5:36 AM, Leif Lindholm wrote: >>> On Fri, Feb 01, 2019 at 10:25:02PM +0800, Ming Huang wrote: As suggestion of community, 'AP' is a bit unfortunate to use in EDK2

Re: [edk2] [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function

2019-02-12 Thread Leif Lindholm
On Tue, Feb 12, 2019 at 08:07:52PM +0800, Ming Huang wrote: > >> For D06 library, we use the same source code to support all Hi1620 > >> projects, > >> include product projects,so there are some modify for this, like support > >> 3 sockets, 4 sockets and remove some useless functions. > > > > So

Re: [edk2] [PATCH edk2-non-osi v1 6/7] Hisilicon/D06: Fix numa node wrong issue

2019-02-12 Thread Ming Huang
On 2/11/2019 10:48 PM, Leif Lindholm wrote: > *bangs head on desk* > > That question I just asked as a reply to > ("Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot") > was meant to be a comment on this patch. > > So - was this change one that was meant to happen together with >

Re: [edk2] [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function

2019-02-12 Thread Ming Huang
On 2/12/2019 5:36 AM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 10:25:02PM +0800, Ming Huang wrote: >> As suggestion of community, 'AP' is a bit unfortunate to use in EDK2 >> context. PI specifies 'BSP' for Boot-strap Processor, as the one >> executing all of the EDK2 code. It then uses

[edk2] [PATCH v2 1/3] MdeModulePkg/PciBus: Change PCI_IO_DEVICE.RomSize to UINT32 type

2019-02-12 Thread Ray Ni
Per PCI Spec, the option ROM BAR is 32bit so the maximum option ROM size can be hold by UINT32 type. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ray Ni Cc: Hao Wu --- MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h | 4 ++--

[edk2] [PATCH v2 0/3] MdeModulePkg/PciBus: Fix a bug PPB MEM32 BAR isn't restored sometimes

2019-02-12 Thread Ray Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1505 v2: fixed all typos in PciBus driver. changed RomSize to UINT32 and added type cast to PPB MEM32 BAR Base/Length to avoid using RShiftU64(). Ray Ni (3): MdeModulePkg/PciBus: Change PCI_IO_DEVICE.RomSize to UINT32 type

[edk2] [PATCH v2 2/3] MdeModulePkg/PciBus: Correct typos

2019-02-12 Thread Ray Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ray Ni Cc: Hao Wu --- MdeModulePkg/Bus/Pci/PciBusDxe/PciCommand.c | 14 ++--- MdeModulePkg/Bus/Pci/PciBusDxe/PciCommand.h | 16 ++--- .../Bus/Pci/PciBusDxe/PciDeviceSupport.c | 14 ++---

[edk2] [PATCH v2 3/3] MdeModulePkg/PciBus: Fix a bug PPB MEM32 BAR isn't restored sometimes

2019-02-12 Thread Ray Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1505 When a device under PPB contains option ROM but doesn't require 32bit MMIO, ProgrameUpstreamBridgeForRom() cannot correctly restore the PPB MEM32 RANGE BAR. It causes the 32bit MMIO conflict which may cause system hangs in boot. The root

Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function

2019-02-12 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng, > Bob C > Sent: Sunday, February 3, 2019 1:55 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function > > BZ:

Re: [edk2] [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function

2019-02-12 Thread Leif Lindholm
On Tue, Feb 12, 2019 at 04:05:50PM +0800, Ming Huang wrote: > On 2/12/2019 5:36 AM, Leif Lindholm wrote: > > On Fri, Feb 01, 2019 at 10:25:02PM +0800, Ming Huang wrote: > >> As suggestion of community, 'AP' is a bit unfortunate to use in EDK2 > >> context. PI specifies 'BSP' for Boot-strap

Re: [edk2] [patch] MdeModulePkg/ReportStatusCodeLib: Avoid using AllocatePool if possible

2019-02-12 Thread Gao, Liming
Dandan: The last change in RuntimeDxeReportStatusCodeLib can be simplified. Other change is good. if (!mHaveExitedBootServices && (StatusCodeData != (EFI_STATUS_CODE_DATA *) StatusCodeBuffer)) { gBS->FreePool (StatusCodeData); } ==> if (StatusCodeData != (EFI_STATUS_CODE_DATA *)

Re: [edk2] [PATCH v2] MdeModulePkg/CapsuleApp: Fix memory leak issue.

2019-02-12 Thread Wu, Hao A
> -Original Message- > From: Chen, Chen A > Sent: Tuesday, February 12, 2019 3:56 PM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A; Wang, Jian J; Wu, Hao A; Zhang, Chao B; Gao, Liming > Subject: [PATCH v2] MdeModulePkg/CapsuleApp: Fix memory leak issue. > > This issue is caused by