DO NOT REPLY [Bug 45171] PNG files locked until JVM exits

2008-06-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45171 --- Comment #4 from Sean Griffin <[EMAIL PROTECTED]> 2008-06-10 12:37:20 PST --- I switched to JRE 1.6. No difference. I set ImageIO.setUseCache(false). No difference. Fortunately the problem is pretty consistent: FO file containin

DO NOT REPLY [Bug 45171] PNG files locked until JVM exits

2008-06-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45171 --- Comment #3 from Andreas L. Delmelle <[EMAIL PROTECTED]> 2008-06-10 09:39:59 PST --- (In reply to comment #2) > I'm running Sun JRE 1.5.0_12. I can try a 1.6 JRE to see if it makes a > difference. > > I tried clearing the image ca

DO NOT REPLY [Bug 45171] PNG files locked until JVM exits

2008-06-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45171 Sean Griffin <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEEDINFO|ASSIGNED ---

Re: Code Quality Metrics

2008-06-10 Thread Vincent Hennebert
Hi Max, Max Berger wrote: > Dear Fop-Devs, > > for the actual implementation, I think it would be a good idea to create > a second lib-directory (e.g. buildsupport, or buildlib), and add the > required libs there, so that we're all using the same tools. These libs > would only be needed during bu

Re: Code Quality Metrics

2008-06-10 Thread Max Berger
Dear Fop-Devs, for the actual implementation, I think it would be a good idea to create a second lib-directory (e.g. buildsupport, or buildlib), and add the required libs there, so that we're all using the same tools. These libs would only be needed during build, and not during deployment.

DO NOT REPLY [Bug 45171] PNG files locked until JVM exits

2008-06-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45171 Andreas L. Delmelle <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |NEEDINFO

Re: Code Quality Metrics

2008-06-10 Thread Andreas Delmelle
On Jun 10, 2008, at 12:26, Vincent Hennebert wrote: By all means, go for it. I second this. That can’t hurt, IMO, and this will probably be quite helpful (or scary, maybe ;-) ). Of course, just setting them up will not be enough. Their suggestions will also have to be followed. Given that th

Re: Code Quality Metrics

2008-06-10 Thread Vincent Hennebert
Hi Max, By all means, go for it. That can’t hurt, IMO, and this will probably be quite helpful (or scary, maybe ;-) ). Of course, just setting them up will not be enough. Their suggestions will also have to be followed. Given that there are already something like 18,000 checkstyle warnings in the

Re: List vs. LinkedList

2008-06-10 Thread Andreas Delmelle
On Jun 10, 2008, at 09:54, Max Berger wrote: as far as I can tell, there where two issues with my cleanups yesterday: Readablility and Performance. I've just submitted a patch which adds a "ListUtil" class, to make the code more readable again. I've replaced (hopefully) all occurrences of

Re: svn commit: r665793 [1/2] - in /xmlgraphics/fop/trunk/src: co degen/unicode/data/LineBreakPairTable.txt codegen/unicode/java/org/apache /fop/text/linebreak/GenerateLineBreakUtils.java java/org/apa

2008-06-10 Thread Andreas Delmelle
On Jun 10, 2008, at 01:18, Manuel Mall wrote: Just as a background. The reason LineBreakPairTable.txt had this 'funny' format is that it was a straight unmodified copy of the table from the UAX#14 specification. Just open the UAX#14 spec in a browser, select and copy the table, paste it int

Re: ElementListUtils vs. ListUtils

2008-06-10 Thread Vincent Hennebert
Hi Max, Max Berger wrote: > Dear Fop-devs, > > as I prepared the patch while being offline, I had not read the > suggestion to put the code I put in "ListUtil" into "ElementListUtils". > Just to be on the safe side: Should both classes be merged? Or is > "elementListUtil" specific to List ? Elem

Re: Switching to Java 1.5

2008-06-10 Thread Chris Bowditch
Max Berger wrote: Hi Max, Vincent, Am 09.06.2008 um 20:01 schrieb Vincent Hennebert: There’s a point that I’d like to further discuss: why wouldn’t we implement Retroweaver/Retrotranslator in the Trunk? If we go the cautious route, that is if we run the test suite on a 1.4 jvm after each i

ElementListUtils vs. ListUtils

2008-06-10 Thread Max Berger
Dear Fop-devs, as I prepared the patch while being offline, I had not read the suggestion to put the code I put in "ListUtil" into "ElementListUtils". Just to be on the safe side: Should both classes be merged? Or is "elementListUtil" specific to List ? Max

Re: Switching to Java 1.5

2008-06-10 Thread Max Berger
Vincent, Am 09.06.2008 um 20:01 schrieb Vincent Hennebert: There’s a point that I’d like to further discuss: why wouldn’t we implement Retroweaver/Retrotranslator in the Trunk? If we go the cautious route, that is if we run the test suite on a 1.4 jvm after each introduction of a 1.5 feature

Code Quality Metrics

2008-06-10 Thread Max Berger
Dear Fop-Devs, since this came up, here is a list of tools I use for software quality checking (and all them them can check for generic list types). All of them have Eclipse and maven plugins (and ant tasks, and ) Checkstyle: checkstyle.sf.net (already configured in fop, so nothing nee

List vs. LinkedList

2008-06-10 Thread Max Berger
Dear Fop-Devs, as far as I can tell, there where two issues with my cleanups yesterday: Readablility and Performance. I've just submitted a patch which adds a "ListUtil" class, to make the code more readable again. I've replaced (hopefully) all occurrences of size() - 1 with the call to t