On Jun 10, 2008, at 12:26, Vincent Hennebert wrote:
By all means, go for it.
I second this.
That can’t hurt, IMO, and this will probably be
quite helpful (or scary, maybe ;-) ).
Of course, just setting them up will not be enough. Their suggestions
will also have to be followed. Given that there are already something
like 18,000 checkstyle warnings in the current codebase...
On that note, I'm currently evaluating IntelliJ, which has some
really nice Code Inspection features. It warns about redundant
statements, for example: unnecessary casts, variable that are
assigned but never used, while-statements that don't loop...
You'd be surprised how many of these are scattered over the codebase.
Not really anyone's fault, just a result of many refactoring cycles
As you said, the result could turn out to be scary... :-)