Re: Code Style, was Re: PDF serialization

2001-07-19 Thread Tore Engvig
On Thu, 19 Jul 2001, Mark Lillywhite wrote: > >Sure. Monday the 23rd evening (GMT) is codeformatting day unless somebody > >protests. > > > Would it be possible to wait for a day or two before setting a firm > date? I hope to have my pipelining stuff completed today and I would > like to at lea

Re: Code Style, was Re: PDF serialization

2001-07-18 Thread Mark Lillywhite
> > >Sure. Monday the 23rd evening (GMT) is codeformatting day unless somebody >protests. > Would it be possible to wait for a day or two before setting a firm date? I hope to have my pipelining stuff completed today and I would like to at least get an opinion on their suitability for inclusion

Re: Code Style, was Re: PDF serialization

2001-07-18 Thread Tore Engvig
On Tue, 17 Jul 2001, Arved Sandstrom wrote: > Hi, Tore > > Well, how about _you_ set the day, since you're the volunteer? :-) Sure. Monday the 23rd evening (GMT) is codeformatting day unless somebody protests. Everyone who have some uncomitted code should commit it by then as the diffs in you

Re: Code Style, was Re: PDF serialization

2001-07-17 Thread Jeremias Maerki
May I suggest to put up a code convention section in involved.xml? I think a short notice with the most important rules (tabs to spaces, 4 spaces for tab etc.) will suffice. That will make it easier to encourage people to follow the conventions. Jeremias Märki mailto:[EMAIL PROTECTED] OUTLINE A

Re: Code Style, was Re: PDF serialization

2001-07-17 Thread Arved Sandstrom
At 11:25 PM 7/17/01 +0200, Tore Engvig wrote: [ SNIP ] >I guess we have to use codeformatters (eg astyle) before we check in our >code. > >I happend to grab a copy of jIndent while it still was free. jIndent does >more than just codeformatting, it parses the code and is able to change a >lot of th

Re: Code Style, was Re: PDF serialization

2001-07-17 Thread Tore Engvig
On Tue, 17 Jul 2001, Arved Sandstrom wrote: > We should, in theory, be able to use the cvswrappers mechanism (or module > options) to run a style tool on a file when it is committed (or in a number > of other cases). I can investigate this. I'd suggest that we divvy up the > existing code, and

Re: Code Style

2001-07-17 Thread Arved Sandstrom
At 12:09 PM 7/17/01 +0200, Keiron Liddle wrote: > >I think that would be better to do it all at once and use the wrappers. The >only problem is what style formatter to use. > >jstyle - has at least 3 bugs (one that will cause compile errors) >astyle - I think it's ok (but there was something I did

Re: Code Style

2001-07-17 Thread Keiron Liddle
On Tue, 17 Jul 2001 11:36:00 Arved Sandstrom wrote: > I should have said, _one_ of the text editors I use does that. :-) Using > another text editor I am as guilty as the next fellow (although I have to > > look more closely; the editor may be able to do the conversion). > > We should, in theo

Re: Code Style, was Re: PDF serialization

2001-07-17 Thread Arved Sandstrom
At 08:29 AM 7/17/01 +0200, Keiron Liddle wrote: >>From what I have seen so far we are never going to get a common code style. >I usually format the code but that doesn't mean it will stay that way and >there are a lot of files. eg. Arved committed in some of the Marker code >with tabs to replace t

Re: Code Style, was Re: PDF serialization

2001-07-16 Thread Keiron Liddle
On Tue, 17 Jul 2001 01:22:38 Arved Sandstrom wrote: > At 09:26 PM 7/16/01 +1000, Mark wrote: > > As an aside: is there a style guide for FOP code? I must say I find the > >style and layout very confusing and I'm happy to clean things up as I > go. > >At the moment I can't even work out what tab s

Re: Code Style, was Re: PDF serialization

2001-07-16 Thread Peter B. West
Arved Sandstrom wrote: > At 09:26 PM 7/16/01 +1000, Mark wrote: > >>As an aside: is there a style guide for FOP code? I must say I find the >>style and layout very confusing and I'm happy to clean things up as I go. >>At the moment I can't even work out what tab stop size people are using. >>(