[Freeciv-Dev] [bug #16413] Gold upkeep and Military unhappiness

2010-09-09 Thread David Fernandez
Follow-up Comment #15, bug #16413 (project freeciv): I confirm the new patch is working properly. Unfortunately, it does not solve AI bankrupts. It seems AI simply does not know to balance his economy with gold_upkeep_style != 0. Based on the behavior I see in my tests, I'd say AI set the

[Freeciv-Dev] [bug #16413] Gold upkeep and Military unhappiness

2010-09-09 Thread Matthias Pfafferodt
Follow-up Comment #16, bug #16413 (project freeciv): Now I understand the problem is not that AI can't disband units, the problem seems to be that AI do not take into account the support of units and buildings unless included in the gold balance per city (not verified, just a guess). I

[Freeciv-Dev] [bug #16644] 1: Saved game contains incomplete map data

2010-09-09 Thread Matthias Pfafferodt
Follow-up Comment #6, bug #16644 (project freeciv): However, I never found a way to reproduce bug #14944. Could someone ensure it doesn't revert the fix for it? I hope you could do this for me? I will check it. bug #14944 was about the change from an int representation of the

[Freeciv-Dev] [bug #16644] 1: Saved game contains incomplete map data

2010-09-09 Thread pepeto
Follow-up Comment #7, bug #16644 (project freeciv): You are right, there is probably the same problem there. ___ Reply to this item at: http://gna.org/bugs/?16644 ___ Message posté

[Freeciv-Dev] [bug #16644] 1: Saved game contains incomplete map data

2010-09-09 Thread pepeto
Follow-up Comment #8, bug #16644 (project freeciv): It is right in savegame2.c. Because we are sure dc_total is saved if fog of war is enabled. However, we could need the server to repair it if we need to test things about fog of war enabled/disabled. New version attached, but maybe not

[Freeciv-Dev] [patch #1942] refactor first portion of ai_airlift into find_neediest_airlift_city

2010-09-09 Thread pepeto
Follow-up Comment #1, patch #1942 (project freeciv): The patch looks correct, except for coding style: static struct city* find_neediest_airlift_city(const struct player *pplayer) { * '*' should be preceded of a space and not followed. Not documented yet (I will add this) but respected as an

[Freeciv-Dev] [patch #1882] Seljuk nation

2010-09-09 Thread Andrzej G.
Additional Item Attachment, patch #1882 (project freeciv): File name: seljuk.ruleset Size:1 KB ___ Reply to this item at: http://gna.org/patch/?1882 ___ Message sent

[Freeciv-Dev] [patch #1902] Apache nation

2010-09-09 Thread Andrzej G.
Follow-up Comment #5, patch #1902 (project freeciv): Now perhaps it should be fine. ___ Reply to this item at: http://gna.org/patch/?1902 ___ Message sent via/by Gna! http://gna.org/

[Freeciv-Dev] [bug #16665] update hit point calculation for killunhomed

2010-09-09 Thread pepeto
Update of bug #16665 (project freeciv): Planned Release: 2.2.3,2.3.0 = 2.2.4, 2.3.0 ___ Reply to this item at: http://gna.org/bugs/?16665 ___ Message posté

[Freeciv-Dev] [bug #15559] Client can't connect to its locally started server

2010-09-09 Thread pepeto
Follow-up Comment #19, bug #15559 (project freeciv): Is Marko around? ___ Reply to this item at: http://gna.org/bugs/?15559 ___ Message posté via/par Gna! http://gna.org/

[Freeciv-Dev] [patch #1943] Code style patch

2010-09-09 Thread m
URL: http://gna.org/patch/?1943 Summary: Code style patch Project: Freeciv Submitted by: akfaew Submitted on: Thursday 09/09/2010 at 16:28 Category: general Priority: 5 - Normal Status:

[Freeciv-Dev] [patch #1943] Code style patch

2010-09-09 Thread Daniel Markstedt
Update of patch #1943 (project freeciv): Status:None = In Progress ___ Reply to this item at: http://gna.org/patch/?1943 ___ Message sent

[Freeciv-Dev] [patch #1943] Code style patch

2010-09-09 Thread Daniel Markstedt
Update of patch #1943 (project freeciv): Status: In Progress = None ___ Reply to this item at: http://gna.org/patch/?1943 ___ Message sent

[Freeciv-Dev] [bug #15559] Client can't connect to its locally started server

2010-09-09 Thread Marko Lindqvist
Follow-up Comment #20, bug #15559 (project freeciv): I don't have time to check this before Sunday (and 2.2.3 release) Feel free to steal it from me. ___ Reply to this item at: http://gna.org/bugs/?15559

[Freeciv-Dev] [bug #16668] Per-topology client tileset preference

2010-09-09 Thread HanduMan
Follow-up Comment #1, bug #16668 (project freeciv): Good idea. Only I think the default tileset is being loaded already when the client is first started. So, which of the four defaults should be chosen at startup? Maybe the one that matches the topology choice saved in preferences? But to make

[Freeciv-Dev] [bug #15559] Client can't connect to its locally started server

2010-09-09 Thread pepeto
Follow-up Comment #21, bug #15559 (project freeciv): Unfortunately, I don't know enough about sockets to handle it. Someone else? ___ Reply to this item at: http://gna.org/bugs/?15559 ___

[Freeciv-Dev] [patch #1943] Code style patch

2010-09-09 Thread pepeto
Follow-up Comment #1, patch #1943 (project freeciv): I am not against. Unfortunately, if I remember correctly, we try to keep old code parts to apply patches between branches. So not sure it's correct to change the code to apply the current coding style. Coding style is used for the new code.

[Freeciv-Dev] [bug #16460] Win chance calculation doesn't take fortress into account

2010-09-09 Thread Jacob Nevins
Update of bug #16460 (project freeciv): Category:None = client Status: Ready For Test = Fixed Assigned to: cazfi = jtn Open/Closed:

[Freeciv-Dev] [bug #15347] Bad drawing and floating point exception with trade route line drawing in SDL client

2010-09-09 Thread Jacob Nevins
Follow-up Comment #20, bug #15347 (project freeciv): Christian, if you won't have time to commit this before the release, I'm happy to do it. I will do in the next couple of days if no-one gets there first. ___ Reply to this item at:

[Freeciv-Dev] Remaining work planned for 2.2.3

2010-09-09 Thread Jacob Nevins
There are a couple of open items left in the tracker with a Planned Release of 2.2.3: Bugs: #15347: Bad drawing and floating point exception with trade route line drawing in SDL client I'm happy with the functionality of the remaining patch, and will commit it if no-one else does or

[Freeciv-Dev] [bug #16177] Patch for a new nation: Acadian

2010-09-09 Thread J.M. Maalderink
Update of bug #16177 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #1938] Navajo nation

2010-09-09 Thread J.M. Maalderink
Update of patch #1938 (project freeciv): Status:None = In Progress Assigned to:None = mixcoatl ___ Follow-up Comment #1: There seems to be

[Freeciv-Dev] [patch #1942] refactor first portion of ai_airlift into find_neediest_airlift_city

2010-09-09 Thread James Spahlinger
Follow-up Comment #2, patch #1942 (project freeciv): Thanks for the input, consistant style is important. Both are easy enough to fix. - I changed my emacs code template for C functions to have a new line before that '{' brace. No clue why I missed that detail, the rest of the functions follow

[Freeciv-Dev] [patch #1929] Gothic nation

2010-09-09 Thread J.M. Maalderink
Follow-up Comment #7, patch #1929 (project freeciv): Using the symbols you suggested looks OK to me. The Vandalic symbol may become a problem if somebody makes a Vandal nation, but we can always look for an alternative then. The Greuthingi and Gepid nations are in binary, could you have a look

[Freeciv-Dev] [patch #1905] Elamite nation

2010-09-09 Thread J.M. Maalderink
Follow-up Comment #5, patch #1905 (project freeciv): Are you sure that's a Mesopotamian symbol? It looks like a fleur-de-lis to me, and Wikipedia claims it was first used by the Franks. ___ Reply to this item at:

[Freeciv-Dev] [patch #1912] Mazovian nation

2010-09-09 Thread J.M. Maalderink
Update of patch #1912 (project freeciv): Status: In Progress = Ready For Test ___ Reply to this item at: http://gna.org/patch/?1912 ___ Message sent

[Freeciv-Dev] [patch #1913] Greater Polish nation

2010-09-09 Thread J.M. Maalderink
Update of patch #1913 (project freeciv): Status: In Progress = Ready For Test ___ Reply to this item at: http://gna.org/patch/?1913 ___ Message sent

[Freeciv-Dev] [patch #1914] Improved P'urhepecha ruleset

2010-09-09 Thread J.M. Maalderink
Update of patch #1914 (project freeciv): Status: In Progress = Ready For Test ___ Reply to this item at: http://gna.org/patch/?1914 ___ Message sent

[Freeciv-Dev] [patch #1915] Namibian nation

2010-09-09 Thread J.M. Maalderink
Update of patch #1915 (project freeciv): Status: In Progress = Ready For Test ___ Reply to this item at: http://gna.org/patch/?1915 ___ Message sent

[Freeciv-Dev] [patch #1916] Zapotec nation

2010-09-09 Thread J.M. Maalderink
Update of patch #1916 (project freeciv): Status: In Progress = Ready For Test ___ Reply to this item at: http://gna.org/patch/?1916 ___ Message sent

[Freeciv-Dev] [patch #1917] Mixtec nation

2010-09-09 Thread J.M. Maalderink
Update of patch #1917 (project freeciv): Status: In Progress = Ready For Test ___ Reply to this item at: http://gna.org/patch/?1917 ___ Message sent

[Freeciv-Dev] [patch #1918] Otomí nation

2010-09-09 Thread J.M. Maalderink
Update of patch #1918 (project freeciv): Status: In Progress = Ready For Test ___ Reply to this item at: http://gna.org/patch/?1918 ___ Message sent

[Freeciv-Dev] [patch #1944] Kosovar nation

2010-09-09 Thread J.M. Maalderink
URL: http://gna.org/patch/?1944 Summary: Kosovar nation Project: Freeciv Submitted by: mixcoatl Submitted on: Friday 09/10/2010 at 04:55 Category: rulesets Priority: 5 - Normal Status:

[Freeciv-Dev] [patch #1945] Surinamese nation

2010-09-09 Thread J.M. Maalderink
URL: http://gna.org/patch/?1945 Summary: Surinamese nation Project: Freeciv Submitted by: mixcoatl Submitted on: Friday 09/10/2010 at 04:57 Category: rulesets Priority: 5 - Normal

[Freeciv-Dev] [patch #1946] Guanche nation

2010-09-09 Thread J.M. Maalderink
URL: http://gna.org/patch/?1946 Summary: Guanche nation Project: Freeciv Submitted by: mixcoatl Submitted on: Friday 09/10/2010 at 05:01 Category: rulesets Priority: 5 - Normal Status:

[Freeciv-Dev] [patch #1946] Guanche nation

2010-09-09 Thread J.M. Maalderink
Additional Item Attachment, patch #1946 (project freeciv): File name: guanche.rulesetSize:1 KB ___ Reply to this item at: http://gna.org/patch/?1946 ___ Message sent

[Freeciv-Dev] [patch #1947] Neapolitan nation

2010-09-09 Thread J.M. Maalderink
URL: http://gna.org/patch/?1947 Summary: Neapolitan nation Project: Freeciv Submitted by: mixcoatl Submitted on: Friday 09/10/2010 at 05:19 Category: rulesets Priority: 5 - Normal

[Freeciv-Dev] [patch #1350] Nations: Mordvin, Chechen, Bashkir, Abkhaz, Ossetian (Tatar, Paulista)

2010-09-09 Thread J.M. Maalderink
Follow-up Comment #13, patch #1350 (project freeciv): Translated Abkhazians and Ossetians in Abkhaz and Ossetic, respectively. (file #10279, file #10280) ___ Additional Item Attachment: File name: abkhaz.ruleset Size:2 KB

[Freeciv-Dev] [bug #16672] civilwar_nations for city names

2010-09-09 Thread J.M. Maalderink
URL: http://gna.org/bugs/?16672 Summary: civilwar_nations for city names Project: Freeciv Submitted by: mixcoatl Submitted on: Friday 09/10/2010 at 05:56 Category: general Severity: 2 - Minor