Follow-up Comment #36, patch #4830 (project freeciv):
Firstly, thanks for prepare my patch to state it was applied to Freeciv
code(trunk).
I also noticed there's first policy in experimental ruleset. Tnis policy is
called Personal Freedom. I must notice that by setting Personal Freedom at
the
Follow-up Comment #35, patch #4830 (project freeciv):
Original forum posts about this feature and possible uses: one
http://forum.freeciv.org/f/viewtopic.php?f=13t=311, two
http://forum.freeciv.org/f/viewtopic.php?f=13t=310, three
http://forum.freeciv.org/f/viewtopic.php?f=13t=419.
Update of patch #4830 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Update of patch #4830 (project freeciv):
Status: In Progress = Ready For Test
___
Follow-up Comment #28:
- Send player's real multipliers info only when INFO_FULL sent
- Removed multipliers from
Follow-up Comment #29, patch #4830 (project freeciv):
In multipliers.c: do multipliers, multiplier_count, and multiplier_used need
the static keyword? I had thought this was necessary for persistent
variables defined at file scope.
In handle_ruleset_multiplier(), is there a reason to use
Follow-up Comment #26, patch #4830 (project freeciv):
I'm making a new version of the patch (so I hope you don't update it just now,
to avoid duplicate work, and possibly work that cannot be merged).
Some notes already, for future submissions:
- Make sure that the patch compiles against the
Follow-up Comment #27, patch #4830 (project freeciv):
- Updated against svn
- Dropped diff_ignore changes
- Ruledit to save multipliers to governments.ruleset and not to separate
file.
Also saving of the helptext was missing
- In ruleset.c, merged multipliers loading to governments.ruleset
Update of patch #4830 (project freeciv):
Assigned to:None = cazfi
___
Reply to this item at:
http://gna.org/patch/?4830
___
Message sent
Update of patch #4830 (project freeciv):
Category:rulesets = general
___
Reply to this item at:
http://gna.org/patch/?4830
___
Message sent
Follow-up Comment #25, patch #4830 (project freeciv):
I already assigned the patch to myself, and will get to it as soon as I can.
___
Reply to this item at:
http://gna.org/patch/?4830
___
Follow-up Comment #21, patch #4830 (project freeciv):
- The idea of multipliers should extends to different part of Freeciv, so it's
not related only to governments
- Changes to diff.ignore are removed
- Weird changes to packets.def are removed
- ai/default/daieffects.c does multiply value of
Follow-up Comment #22, patch #4830 (project freeciv):
The idea of multipliers should extends to different part of
Freeciv, so it's not related only to governments
What the controls in gui then represent if not (governing) policies? If you
dislike adding them to governments.ruleset, maybe
Follow-up Comment #19, patch #4830 (project freeciv):
1. SDL client compiles
2.
- New rules should be saved to ruleset in tools/ruledit/rulesave.c
Saved to this file should be ruleset?
___
Reply to this item at:
Follow-up Comment #20, patch #4830 (project freeciv):
- I think these are mainly going to be related to governments, and you even
name the dialog currently as government modifiers. It would probably be
better to add them to governments.ruleset than to add completely new ruleset
file, especially
Follow-up Comment #17, patch #4830 (project freeciv):
Added savegame/loadgame functionality. Still there's no AI code, but I'm not
AI expert.
I think the patch is ready for inclusion.
(file #21272)
___
Additional Item Attachment:
File
Follow-up Comment #18, patch #4830 (project freeciv):
Still just scrolled through the code (I hope to test it in practice and have
more detailed look within a week)
- Do other clients even compile? You add function to client interface, but the
clients seem not to have even empty implementation
Follow-up Comment #15, patch #4830 (project freeciv):
Attached a version of lachu's file #21193 rebased to recent trunk (over patch
#4851, patch #4822, patch #4826) so I could play with it. No other changes.
(file #21235)
___
Additional
Follow-up Comment #16, patch #4830 (project freeciv):
A couple of comments on the substance (get_target_bonus_effects()):
* I think it would be useful to be able to have each step make less than 1.0
difference to a particular effect. A simple way to do this would be to scale
by 100; so if I want
Follow-up Comment #13, patch #4830 (project freeciv):
I think this is not yet ready for inclusion. There's missing save game and
load game facilities.
There's also AI code missing.
___
Reply to this item at:
http://gna.org/patch/?4830
Follow-up Comment #14, patch #4830 (project freeciv):
I have fixed all typos and changed what you tell is to change.
(file #21193)
___
Additional Item Attachment:
File name: multipliers.patch Size:36 KB
Follow-up Comment #11, patch #4830 (project freeciv):
Patch version, which adds multipliers to help dialog.
Setting two variables in ruleset_free(game.c) to zero is needed for cleanup
purposes. If we don't do that, then in special cases (for example ruleset was
loaded many times) we can't load
Follow-up Comment #12, patch #4830 (project freeciv):
On the global variables: I agree they are needed for cleanup purposes, but I
still think they should be scoped to multipliers.c. Consider adding helper
functions to game_ruleset_init() and game_ruleset_free() that operate on
static variables
Follow-up Comment #9, patch #4830 (project freeciv):
Thanks for the updates: this is lots cleaner and easier to work with.
Applies smoothly over r25244, and builds.
Naming:
Most of the rest of the codebase uses singular nouns for most purposes,
with plural nouns only used when specifically
Follow-up Comment #10, patch #4830 (project freeciv):
Oh, and I forgot, there probably ought be some way the ruleset author can
supply helptext for each multiplier, and a facility in client/helpdata.c to
parse that and display it in the online help.
Update of patch #4830 (project freeciv):
Summary: Multiplers to effects = Multipliers to effects
___
Reply to this item at:
http://gna.org/patch/?4830
___
Message sent
25 matches
Mail list logo
