[Freeciv-Dev] [patch #3879] Remove "negated" reqs{} field in favor of something semantically nicer

Follow-up Comment #1, patch #3879 (project freeciv): >or by changing the word used to be something positive. I agree. >Note that the introduction of nreqs uses an entirely different mechanism than that suggested in patch #3332 The mechanism was wrong and my original idea was confuse. My purpose wa

[Freeciv-Dev] [patch #3697] When city growth is blocked, AI shouldn't give any value to food surplus

Follow-up Comment #1, patch #3697 (project freeciv): Attached is a patch that seems to work for me. Note that the increase in appeal for the improvements is essential here: early revisions of the patch didn't include that, with the result that when the granary was full, the AI deprioritised food,

[Freeciv-Dev] [patch #3332] Negated requirements_vector

Follow-up Comment #4, patch #3332 (project freeciv): For completeness, although I am not in favor of nreqs{} support everywhere, I prepared a patch with similar effect (and entirely different implementation) as part of discussion in patch #3879. While I don't know I will be proposing that for inc

[Freeciv-Dev] [patch #3879] Remove "negated" reqs{} field in favor of something semantically nicer

URL: Summary: Remove "negated" reqs{} field in favor of something semantically nicer Project: Freeciv Submitted by: persia Submitted on: Wed 24 Apr 2013 09:52:01 AM JST Category: rulesets

[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts or crashes

Follow-up Comment #9, bug #19846 (project freeciv): Ubuntu and Debian historically diverge in libgtk update timing and history. Current revisions in releases: Debian Wheezy: 3.4.2 Debian Experimental: 3.8.0 Ubuntu Oneiric: 3.2.0 Ubuntu Precise:3.4.2 Ubuntu Quantal: 3.6.0 Ubuntu Raring: 3.6.4

[Freeciv-Dev] [patch #3863] Document gtk3-client unit selection dialog crash

Follow-up Comment #1, patch #3863 (project freeciv): - Reworded to make clear it's gtk+ bug, not freeciv bug observed with some gtk+ versions. - Added link to gtk+ bug ticket (file #17820) ___ Additional Item Attachment: File name: Gtk3C

[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts or crashes

Follow-up Comment #8, bug #19846 (project freeciv): gtk+ bug is now RESOLVED FIXED. That leaves us to figure out how to live with buggy versions. What distributions are affected? I know all too well that Debian Wheezy (to be released 4/5 May weekend) is. Probably recent Ubuntu versions are too (as

[Freeciv-Dev] [patch #3630] Add separate base owner information for tiles

Follow-up Comment #2, patch #3630 (project freeciv): - Set correct extras_owner when creating virtual tile (file #17819) ___ Additional Item Attachment: File name: BaseOwner-3.patch Size:11 KB ___

[Freeciv-Dev] [patch #3878] Buoys without border claiming

URL: Summary: Buoys without border claiming Project: Freeciv Submitted by: cazfi Submitted on: Wed 24 Apr 2013 01:24:27 AM EEST Category: rulesets Priority: 5 - Normal

[Freeciv-Dev] [patch #3873] Always claim created base

Follow-up Comment #1, patch #3873 (project freeciv): - Reclaim existing bases on tile only if owner changes - Set correct tile.extras_owner (file #17817) ___ Additional Item Attachment: File name: ClaimCreatedBase-2.patch Size:1 KB

[Freeciv-Dev] [patch #3872] Do not claim bases indirectly with terrain

Update of patch #3872 (project freeciv): Status: In Progress => Ready For Test ___ Follow-up Comment #1: - Converted more base claim iterations to call tile_claim_bases() instead - Actually set tile.e

[Freeciv-Dev] [bug #20634] "City size x, citizen count y" with alternating movement

Follow-up Comment #1, bug #20634 (project freeciv): This has actually happened with all the alternating movement autogames I've run since in S2_4, one or two every day, while there can go full week without me seeing any other error from any of the 10 other tests. As there's code to fix the situati

[Freeciv-Dev] [patch #3826] Allow bases on city tiles

Follow-up Comment #15, patch #3826 (project freeciv): My apologies. I suppose I'm used to significantly less mature projects, where a feature freeze tends to happen only immediately prior to release (but releases correspondingly tend to be buggier without the overlap). Attached is a patch with t

[Freeciv-Dev] [patch #3877] Explain Alien ruleset unit Rex name

URL: Summary: Explain Alien ruleset unit Rex name Project: Freeciv Submitted by: cazfi Submitted on: Tue 23 Apr 2013 11:21:14 PM EEST Category: rulesets Priority: 5 - Normal

[Freeciv-Dev] [patch #3826] Allow bases on city tiles

Follow-up Comment #14, patch #3826 (project freeciv): Shipping rulesets have no bases surviving in the cities, but if we are adding it as a feature for ruleset, it should work. Note that almost any ruleset where some base can exist in city is subject to "superior nation conquered city from weaker

[Freeciv-Dev] [patch #3721] Getting rid of move_type dependency on unitselect dialog

Follow-up Comment #5, patch #3721 (project freeciv): Oh, you were talking about server/client sync. Yes, even though client is single-threaded, and in that sense does a lot of things "atomically", user action can happen between any two packets from server. As for transport and cargo being in diffe

[Freeciv-Dev] [bug #20751] assertion 'normal_player_count() <= game.server.max_players' failed

Update of bug #20751 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [bug #20744] Recursive wipe_unit() saving drowning units from calling wipe_unit()

Update of bug #20744 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [patch #3721] Getting rid of move_type dependency on unitselect dialog

Follow-up Comment #4, patch #3721 (project freeciv): Not being thread safe isn't just about whether the client is multithreaded. The entire computational system (client+server) has at least two threads, and if I read unit_move() correctly, send_unit_info_to_onlookers() is called a few times befor

[Freeciv-Dev] [bug #20761] Illegal treaty lives forever

Follow-up Comment #2, bug #20761 (project freeciv): A simple solution would seem to be to iterate over open treaties at the beginning of players_iterate_alive{} in dai_diplomacy_actions() (near the "Try to make peace..." comment), closing any that are unacceptable to the player on whose behalf the

[Freeciv-Dev] [bug #20761] Illegal treaty lives forever

Follow-up Comment #1, bug #20761 (project freeciv): > it's probably bug that they end in such a situation even if tech > loss is involved That's probably caused by more general "Unaccepted treaty lives forever" -issue. As far as I can see treaty between AI players is never rejected or cancelled.

[Freeciv-Dev] [bug #20761] Illegal treaty lives forever

URL: Summary: Illegal treaty lives forever Project: Freeciv Submitted by: cazfi Submitted on: Tue 23 Apr 2013 12:17:42 PM EEST Category: ai Severity: 3 - Normal

[Freeciv-Dev] [bug #20753] "is_available" in nation rulesets does nothing

Update of bug #20753 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Follow-up Comment #3: > Is it possible to

[Freeciv-Dev] [patch #3861] Nations ruleset: replace warn_city_style with allowed_city_styles

Update of patch #3861 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #3860] Nations ruleset: allow terrain checking against explicit compatibility list

Update of patch #3860 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #3859] Nations ruleset: move government compatibility checking to nationlist.ruleset

Update of patch #3859 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #20752] Errors in nation rulesets cause spurious messages about lack of defined barbarians

Update of bug #20752 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at: