Re: [Freeciv-Dev] (PR#39984) server options setting and saving is weird
http://bugs.freeciv.org/Ticket/Display.html?id=39984 > On 1/5/08, William Allen Simpson <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=39984 > > > Madeline Book wrote: > > One use for the "Save Options Now" item (in the menu "Game" > > submenu "Options") is to save your local options (as well as CMA > > presets, shown report columns, etc.; > > ...). Furthermore, it is not automatic (i.e. whenever you > > close the dialog as you suggest) to prevent clobbering your > > existing civclientrc (e.g. when upgrading to a newer client version). > > > And how frequent is that? Frequent for developers, not so much for users. Anyway there are workarounds like using the environment variable FREECIV_OPT to specify a different file for saving/loading the civclientrc, so it is not that pressing an issue. > While testing, I swap between versions all the time, and the few changes > can be slightly annoying, but not critical. > > Anyway, you've stated a (previously undocumented) rationale, and it > conflicts with the reporter's desire that his options always be saved as > soon as he makes the changes. That's what we all needed to know > > So, here's a different idea: in addition to the Cancel and OK buttons on > the various options/settings dialogs, add a Save button. Yes, this is the approach we have take for the sundry setting dialogs in warclient (also "Reset" and "Apply" (but don't save) buttons for convenience). > I'm not good at GTK2 programming, but it looks relatively easy. Thankfully the API documentation for GTK2 is fairly useful, if the library in general can be somewhat tedious and idiosyncratic because of its c-level emulation of c++ features and adherence to design patterns over ease of use. Still easier than rolling your own GUI I suppose. :) ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39984) server options setting and saving is weird
http://bugs.freeciv.org/Ticket/Display.html?id=39984 > Madeline Book wrote: > One use for the "Save Options Now" item (in the menu "Game" > submenu "Options") is to save your local options (as well as CMA > presets, shown report columns, etc.; > ...). Furthermore, it is not automatic (i.e. whenever you > close the dialog as you suggest) to prevent clobbering your > existing civclientrc (e.g. when upgrading to a newer client version). > And how frequent is that? While testing, I swap between versions all the time, and the few changes can be slightly annoying, but not critical. Anyway, you've stated a (previously undocumented) rationale, and it conflicts with the reporter's desire that his options always be saved as soon as he makes the changes. That's what we all needed to know So, here's a different idea: in addition to the Cancel and OK buttons on the various options/settings dialogs, add a Save button. I'm not good at GTK2 programming, but it looks relatively easy. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39984) server options setting and saving is weird
http://bugs.freeciv.org/Ticket/Display.html?id=39984 >
On 1/4/08, William Allen Simpson <[EMAIL PROTECTED]> wrote:
>
>
> http://bugs.freeciv.org/Ticket/Display.html?id=39984 >
>
> As to the original report:
>
> # When I change the values from within the start screen, the old values
> are
> # used in the new game, instead of the new ones. This is a bug.
> #
> As I mentioned, this is because the server sends the old settings again,
> and
> wipes out the changes. I'm trying to figure out a work around, and the
> only
> solution that I see for 2.1 is to save the settings as the dialog is
> closed.
>
> The original designer(s) had two menu items: save options and save options
> on exit. That simply won't work here, as that menu isn't showing on the
> start screen! (Apparently, the start page is a recent addition.)
>
> It could be argued that the menus should be there on the start page. But
> many folks will depend on the save on exit, which won't work here.
Why is there save on exit? Why not just save on closing the dialog(s)?
>
> If there's no good reason, I'll remove these menu items, instead
>
One use for the "Save Options Now" item (in the menu "Game"
submenu "Options") is to save your local options (as well as CMA
presets, shown report columns, etc.; please look inside $HOME/
.civclientrc [or equivalent for your platform] to see just how much
other important information is saved there besides just the local
options [the relevant functions are {save,load}_options in client/
options.c]), after you have edited them to your liking. The "Save
Options on Exit" is there so that you don't have to do this manually
everytime you change these things. If you remove these items,
how do you propose that users go about saving these "settings",
conveniently? Furthermore, it is not automatic (i.e. whenever you
close the dialog as you suggest) to prevent clobbering your
existing civclientrc (e.g. when upgrading to a newer client version).
On 1/4/08, William Allen Simpson <[EMAIL PROTECTED]> wrote:
http://bugs.freeciv.org/Ticket/Display.html?id=39984 >As to the original report:# When I change the values from within the start screen, the old values are
# used in the new game, instead of the new ones. This is a bug.#As I mentioned, this is because the server sends the old settings again, andwipes out the changes. I'm trying to figure out a work around, and the only
solution that I see for 2.1 is to save the settings as the dialog is closed.The original designer(s) had two menu items: save options and save optionson exit. That simply won't work here, as that menu isn't showing on the
start screen! (Apparently, the start page is a recent addition.)It could be argued that the menus should be there on the start page. Butmany folks will depend on the save on exit, which won't work here.
Why is there save on exit? Why not just save on closing the dialog(s)?If there's no good reason, I'll remove these menu items, insteadOne use for the "Save Options Now" item (in the menu "Game"
submenu "Options") is to save your local options (as well as CMApresets, shown report columns, etc.; please look inside $HOME/.civclientrc [or equivalent for your platform] to see just how muchother important information is saved there besides just the local
options [the relevant functions are {save,load}_options in client/options.c]), after you have edited them to your liking. The "SaveOptions on Exit" is there so that you don't have to do this manually
everytime you change these things. If you remove these items,how do you propose that users go about saving these "settings",conveniently? Furthermore, it is not automatic (i.e. whenever youclose the dialog as you suggest) to prevent clobbering your
existing civclientrc (e.g. when upgrading to a newer client version).
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39984) server options setting and saving is weird
http://bugs.freeciv.org/Ticket/Display.html?id=39984 > As to the original report: # When I change the values from within the start screen, the old values are # used in the new game, instead of the new ones. This is a bug. # As I mentioned, this is because the server sends the old settings again, and wipes out the changes. I'm trying to figure out a work around, and the only solution that I see for 2.1 is to save the settings as the dialog is closed. The original designer(s) had two menu items: save options and save options on exit. That simply won't work here, as that menu isn't showing on the start screen! (Apparently, the start page is a recent addition.) It could be argued that the menus should be there on the start page. But many folks will depend on the save on exit, which won't work here. Why is there save on exit? Why not just save on closing the dialog(s)? If there's no good reason, I'll remove these menu items, instead ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39984) server options setting and saving is weird
http://bugs.freeciv.org/Ticket/Display.html?id=39984 > Hello, William Allen Simpson wrote on Dec 24, 16:10 (-0800): > Nope, it's everything settable in the GTK2 options, message options, and > server options dialogs under the Game menu. However, for the server, only > those changed from the default are saved. I have changed serveral server options, as I usually do, but only these two have been saved so far. > > savename > > shouldn't be saved, because I (at least) change the game name when I start a > > new game. saveturns can be useful to save in there. > > > So, there's no problem, as you always change the game name. For those of > us that just want to set it and forget it, this works, too! Except I forget to set it and it overwrites happily my previous game. Christian (and Happy Christmas to you all) -- Christian Knoke* * *http://cknoke.de * * * * * * * * * Ceterum censeo Microsoft esse dividendum. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39984) server options setting and saving is weird
http://bugs.freeciv.org/Ticket/Display.html?id=39984 > Christian Knoke wrote: > The file is .civclientrc, and saving game (=server) settings in it is > somewhat suprising. And it is only these two that are saved AFAICS. Yes, it's the settings that whomever running the client wants the server to use when running the game. Some folks like a GUI. Not everybody thinks that /read is a fine idea. Nope, it's everything settable in the GTK2 options, message options, and server options dialogs under the Game menu. However, for the server, only those changed from the default are saved. Eventually, I hope to unify the code and have everything only save the changes from defaults. This allows us to change defaults and have things actually change -- as opposed to the recent default change for fullscreen that requires folks to edit their rc file by hand to fix > savename > shouldn't be saved, because I (at least) change the game name when I start a > new game. saveturns can be useful to save in there. > So, there's no problem, as you always change the game name. For those of us that just want to set it and forget it, this works, too! > Start a new game, choose nation, change server options, *then* start game, > then go to server options in file menue, and you see that the value you've > previously set for the savename is not there. > Thanks, the problem may be it resends the rulesets and settings on start. I've already cut down sending rulesets from 3 to 2 times, and settings from 4 to 3 times. (PR#39578, PR#39579, PR#39956, PR#39960, and others) More will have to wait until further packet and game state restructuring. Sorry, but it's not my fault. If I hadn't had to spend so much time fixing serious UI bugs in 2.1, then 2.2 would be ready for beta. > On a remote server, I'm usually nor allowed to set save options > Please explain exactly the mechanism that the client "knows" it's talking to a remote server? And how this interacts with the auth.c system? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39984) server options setting and saving is weird
http://bugs.freeciv.org/Ticket/Display.html?id=39984 > Hello William, Du schriebst am 24. Dec um 09:22 Uhr: > > http://bugs.freeciv.org/Ticket/Display.html?id=39984 > > > Christian Knoke wrote: > > Starting a new game, I *can* set the saveturns and savename options. This is > > new and this is good. Previously, I had to do the settings just after game > > start, with a chance to forget it. > > > > These settings are saved. Freeciv is remembering the setting from a previous > > game. This is questionable. > > > There's no indicator anywhere that some "settings" are per game, and others > are permanent Maybe the entire mechanism needs to be divided? The file is .civclientrc, and saving game (=server) settings in it is somewhat suprising. And it is only these two that are saved AFAICS. savename shouldn't be saved, because I (at least) change the game name when I start a new game. saveturns can be useful to save in there. > > When I change the values from within the start screen, the old values are > > used in the new game, instead of the new ones. This is a bug. > > > Which old values? From the saved file? From a saved game? Defaults? Start a new game, choose nation, change server options, *then* start game, then go to server options in file menue, and you see that the value you've previously set for the savename is not there. > There's definitely a problem I've reported elsewhere that the settings > current values are sent in the settings messages, and also sent in the > game.info message. Any time you have something stored in two places, > there's some chance they will conflict > > That's a major packet re-design issue. I'm working on it for 2.2. > > > > When I log in to a remote server, these two settings are sent to the server, > > which usually reacts with an error message. The former is a bug, too. > > > There's no indicator anywhere that some "settings" are per server, or have > some level of access, so the client can only try and get an error message. On a remote server, I'm usually nor allowed to set save options > Again, a major packet and internal re-design issue. Maybe someday. Christian -- Christian Knoke* * *http://cknoke.de * * * * * * * * * Ceterum censeo Microsoft esse dividendum. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39984) server options setting and saving is weird
http://bugs.freeciv.org/Ticket/Display.html?id=39984 > Christian Knoke wrote: > Starting a new game, I *can* set the saveturns and savename options. This is > new and this is good. Previously, I had to do the settings just after game > start, with a chance to forget it. > > These settings are saved. Freeciv is remembering the setting from a previous > game. This is questionable. > There's no indicator anywhere that some "settings" are per game, and others are permanent Maybe the entire mechanism needs to be divided? As far as savename, I wish it would default to my username, but instead it's civgame. I'm using it to set my username, and so I liked the fact that it now stays the same between games. > When I change the values from within the start screen, the old values are > used in the new game, instead of the new ones. This is a bug. > Which old values? From the saved file? From a saved game? Defaults? There's definitely a problem I've reported elsewhere that the settings current values are sent in the settings messages, and also sent in the game.info message. Any time you have something stored in two places, there's some chance they will conflict That's a major packet re-design issue. I'm working on it for 2.2. > When I log in to a remote server, these two settings are sent to the server, > which usually reacts with an error message. The former is a bug, too. > There's no indicator anywhere that some "settings" are per server, or have some level of access, so the client can only try and get an error message. Again, a major packet and internal re-design issue. Maybe someday. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39984) server options setting and saving is weird
http://bugs.freeciv.org/Ticket/Display.html?id=39984 > Hello, S2.1 SVN 2007-12-24 GTK2 Starting a new game, I *can* set the saveturns and savename options. This is new and this is good. Previously, I had to do the settings just after game start, with a chance to forget it. These settings are saved. Freeciv is remembering the setting from a previous game. This is questionable. When I change the values from within the start screen, the old values are used in the new game, instead of the new ones. This is a bug. When I log in to a remote server, these two settings are sent to the server, which usually reacts with an error message. The former is a bug, too. Christian -- Christian Knoke* * *http://cknoke.de * * * * * * * * * Ceterum censeo Microsoft esse dividendum. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
