[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Update of patch #3901 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Follow-up Comment #16, patch #3901 (project freeciv): You are right. Patch attached. (file #20695) ___ Additional Item Attachment: File name: trunk_pf_native_get_MC_callbacks3.diff Size:22 KB

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Follow-up Comment #15, patch #3901 (project freeciv): My branch has (and so my patch should have): if (is_non_allied_unit_tile(target, param->owner) && ( (uclass_has_flag(param->uclass, UCF_ATTACK_NON_NATIVE) && !BV_ISSET(param->unit_flags, UTYF_ONLY_NATIVE_ATTACK))

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Follow-up Comment #14, patch #3901 (project freeciv): > In pf_able_to_attack(), I prefer checking flags before > nativity, but that's just (potentially useless) optimisation, > based on my speculative estimates of call costs. What to do you mean exactly?

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Follow-up Comment #13, patch #3901 (project freeciv): Wow! That definitely solves it, and matches the behaviour that seems to be encoded in unit_move_to_tile_test(). In pf_able_to_attack(), I prefer checking flags before nativity, but that's just (potentially useless) optimisation, based on my s

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Follow-up Comment #12, patch #3901 (project freeciv): > I want also to clarify that CodingStyle says that such > variables should be left uninitialized (added to CodingStyle in > patch #3603) Thanks you Marko, I didn't notice the changes to CodingStyle. Especially because I read mosly the wikia p

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Follow-up Comment #11, patch #3901 (project freeciv): > It is not needed as it is initialized when it is used (pcity = > tile_city(ptile)), the pointer is not used anywhere else. I want also to clarify that CodingStyle says that such variables should be left uninitialized (added to CodingStyle in

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Update of patch #3901 (project freeciv): Status: In Progress => Ready For Test ___ Follow-up Comment #10: New version matching my previous comment. (file #20690)

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Update of patch #3901 (project freeciv): Status: Ready For Test => In Progress ___ Follow-up Comment #9: Thanks for your arguments. For is_native_move(), I will check. I think it isn't at the right p

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Follow-up Comment #8, patch #3901 (project freeciv): Thanks again for the detailed review. How is move nativity checked before calling single_move_cost? Without calling is_native_move(), a unit may move between any two tiles that are native to that unit, even if the two tiles are only native bec

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Update of patch #3901 (project freeciv): Status:None => Ready For Test ___ Follow-up Comment #7: I finished to review your work. I attach a modified version of it: * do not limit single_move_c

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Follow-up Comment #6, patch #3901 (project freeciv): Rebased against r24826 (file #20614) ___ Additional Item Attachment: File name: native-get_MC-callbacks+rebase2.patch Size:20 KB ___

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Follow-up Comment #5, patch #3901 (project freeciv): Updated patch addressing identified issues from review. Overlap moves now have a separate cost function (set to param->move_rate, rather than SINGLE_MOVE to discourage attempting to land in two places in one turn). Overlap moves still consider

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Update of patch #3901 (project freeciv): Planned Release: => 2.6.0 ___ Follow-up Comment #4: After some discussion on IRC, pepeto and I concluded that the comment "/* Entering port or bomb

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Follow-up Comment #3, patch #3901 (project freeciv): The attached patch is rebased on r24748 and only checks whether a transport is present without orders, rather than checking if it has available capacity (similar logic to that in bug #21871, which patch is rendered unnecessary if this is applied

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Follow-up Comment #2, patch #3901 (project freeciv): Found an oddity testing with this: If a transport is full, units in the transport cannot disembark from it with client-side GoTo pathfinding if the transport is on a tile that is otherwise non-native to the disembarking unit. This seems to be a

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Follow-up Comment #1, patch #3901 (project freeciv): Rebased against r24699 (file #20392) ___ Additional Item Attachment: File name: native-get_MC-callbacks+rebase.patch Size:19 KB

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

Update of patch #3901 (project freeciv): Assigned to:None => pepeto ___ Reply to this item at: ___ Message pos

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

URL: Summary: Rewrite get_MC callbacks for complex nativity Project: Freeciv Submitted by: persia Submitted on: Wed 08 May 2013 05:09:33 PM JST Category: ai Priority: 5 - Normal