Re: [Freeciv-Dev] Patch tracker
2009/7/8 Daniel Markstedt : > > How about this for the definitions of bug and patch: > * A patch is an issue for which you have prepared a fix or is planning > to prepare a fix yourself. Typically used by regular contributors. > * A bug is an issue for which you do not have a fix and wish for > someone else to find one. Typically used by users. No, I think this is worse than obvious bug/feature division. Bug report should be always in bug tracker (and searchable there) and not depend on if I will have time to fix it myself or not. Votes seems to be 2-2 among all developers, and 1-1 among Maintainers. But as this is not so big deal for me, okay, let's use two trackers (assuming nobody else weights in at the last moment). - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Patch tracker
note to myself: remember to send emails also to the mailing list ... Am Wednesday 08 July 2009 20:50:19 schrieben Sie: > 2009/7/8 Matthias Pfafferodt : > >> Patch-for-bug vs. patch-for-new feature might seem clear to those involved for a time, so it'd probably would give similar results to simply set up tags/keywords that can be assigned by the maintainers to > >> sort the two types for later searches. (Assuming that, like on bugzilla, > >> it's possible to create/assign arbitrary tags.) > > > > You are right. At the moment there is one lonely patch waiting in the patches section. I don't know if anybody found the new nation. > First you were for using both trackers, but then you agreed on some > points of John's mail. Could you clarify which way you would vote at the moment. Sorry if it was not clear. I'm for the use of two different tracker (bugs / patches). But I see John's point that it will create confusion. At my first look on the new bug tracker at gna I also found it strange to find 'bugs' as well as 'patches' and interpreted it as said in my first mail: > I would like to see the split bugs <> patches into two trackers, there bugs includes crashes / errors (+ the patches to correct them) and patches > contains new features to freeciv. This way it would also be easier to check if a bug was reported before. After nothing was posted in the section 'patches' I started to use 'bug' for this. A clear text stating that should be reported into which tracker on top of the corresponding pages would be helpful. Matthias > Until we have agreed on something, I continue using current practice > of posting bug reports, bugfixes and feature patches all to the same tracker. > - ML -- Matthias Pfafferodt - http://www.mapfa.de Matthias.Pfafferodt mapfa.de ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Patch tracker
2009/7/8 Matthias Pfafferodt : >> Patch-for-bug vs. patch-for-new feature might seem clear to those >> involved for a time, so it'd probably would give similar results to >> simply set up tags/keywords that can be assigned by the maintainers to >> sort the two types for later searches. (Assuming that, like on bugzilla, >> it's possible to create/assign arbitrary tags.) > > You are right. At the moment there is one lonely patch waiting in the patches > section. I don't know if anybody found the new nation. First you were for using both trackers, but then you agreed on some points of John's mail. Could you clarify which way you would vote at the moment. Until we have agreed on something, I continue using current practice of posting bug reports, bugfixes and feature patches all to the same tracker. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Patch tracker
Daniel Markstedt wrote: > On Tue, Jul 7, 2009 at 11:41 PM, Marko Lindqvist wrote: >> 2009/7/8 John Keller : >>> Patch-for-bug vs. patch-for-new feature might seem clear to those >>> involved for a time, >> The fact it's sometimes hard to say if patch is new feature or bugfix >> (it's sometimes disputable if old behavior is a bug) is the reason I >> started posting all patches to just bugtracker - just like we used to >> do with RT. >> For example: If I would write a patch that would remove despotism >> penalty of -1 from tiles producing more than 2 food/shield/trade, I >> would of course send it to features tracker since there is no bug in >> current behavior. However, people are regularly filling bugreports >> about how they get only 2 food/shield/trade from some tile that should >> yield 3. They would check bugtracker, not feature tracker. >> >>> [...] > > In such a case I would give the bug duplicated status but leave it > open, and then add a reference to the patch. Users who experience the > bug will find the bug and can click through to the patch to see > current status. > > How about this for the definitions of bug and patch: > * A patch is an issue for which you have prepared a fix or is planning > to prepare a fix yourself. Typically used by regular contributors. > * A bug is an issue for which you do not have a fix and wish for > someone else to find one. Typically used by users. Well, I think the crux of the issue is that, if you have to define a policy, then there will always be people who ignore it or are unaware of it. I'm speaking from some very practical experience in a similar situation. :-) You guys certainly go ahead an implement whichever solution you prefer, I for one will be happy to follow it. But for your own sanity, I'd strongly recommend simply using a single reporting system and tagging patches yourselves as appropriate (like a bug triage team might do). Or even display instructions on the form telling the (patch/bug)-filer to add that tag at submittal time. That way, the very worst case is a patch that isn't tagged correctly instead of some patches languishing alone or your having to tell people to resubmit the patch on the other tracker ("other" being possible in either direction). - John ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Patch tracker
On Tue, Jul 7, 2009 at 11:41 PM, Marko Lindqvist wrote: > 2009/7/8 John Keller : >> >> Patch-for-bug vs. patch-for-new feature might seem clear to those >> involved for a time, > > The fact it's sometimes hard to say if patch is new feature or bugfix > (it's sometimes disputable if old behavior is a bug) is the reason I > started posting all patches to just bugtracker - just like we used to > do with RT. > For example: If I would write a patch that would remove despotism > penalty of -1 from tiles producing more than 2 food/shield/trade, I > would of course send it to features tracker since there is no bug in > current behavior. However, people are regularly filling bugreports > about how they get only 2 food/shield/trade from some tile that should > yield 3. They would check bugtracker, not feature tracker. > >> [...] > In such a case I would give the bug duplicated status but leave it open, and then add a reference to the patch. Users who experience the bug will find the bug and can click through to the patch to see current status. How about this for the definitions of bug and patch: * A patch is an issue for which you have prepared a fix or is planning to prepare a fix yourself. Typically used by regular contributors. * A bug is an issue for which you do not have a fix and wish for someone else to find one. Typically used by users. Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Patch tracker
> Patch-for-bug vs. patch-for-new feature might seem clear to those > involved for a time, so it'd probably would give similar results to > simply set up tags/keywords that can be assigned by the maintainers to > sort the two types for later searches. (Assuming that, like on bugzilla, > it's possible to create/assign arbitrary tags.) You are right. At the moment there is one lonely patch waiting in the patches section. I don't know if anybody found the new nation. Matthias > > Also, a related question: does the patch tracker work with the same Gna > account as the bug tracker? And send emails to this list? Wondering for > my own reference if the patch tracker does end up being the preferred way. > > - John > > ___ > Freeciv-dev mailing list > Freeciv-dev@gna.org > https://mail.gna.org/listinfo/freeciv-dev -- Matthias Pfafferodt - http://www.mapfa.de Matthias.Pfafferodt mapfa.de ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Patch tracker
2009/7/8 John Keller : > > Patch-for-bug vs. patch-for-new feature might seem clear to those > involved for a time, The fact it's sometimes hard to say if patch is new feature or bugfix (it's sometimes disputable if old behavior is a bug) is the reason I started posting all patches to just bugtracker - just like we used to do with RT. For example: If I would write a patch that would remove despotism penalty of -1 from tiles producing more than 2 food/shield/trade, I would of course send it to features tracker since there is no bug in current behavior. However, people are regularly filling bugreports about how they get only 2 food/shield/trade from some tile that should yield 3. They would check bugtracker, not feature tracker. > Also, a related question: does the patch tracker work with the same Gna > account as the bug tracker? And send emails to this list? Wondering for > my own reference if the patch tracker does end up being the preferred way. Yes, it seems to be identical to bugtracker, only using another database to store tickets in. Maintainers have same options to configure it as we have for bugtracker. I think I already set it to send mails to freeciv-dev some time ago just in case someone posts something there. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Patch tracker
Daniel Markstedt wrote: > I've noticed numerous bugs with the [patch] tags in the gna bug > tracker. Just though it'd mention, if you haven't noticed already, > that there's a separate patch tracker available at > https://gna.org/patch/?group=freeciv > > Do you think we'd use it, or shall I just close it? As hopeful patch contributor, and external rather than part of the maintainers group, I personally think that a single source would be more discoverable. Despite the administrative hassle this might create, it's more than likely that only people "in the know" will check the two separate sources (and even then, unlikely to actually use the right one - witness the bug reports that come straight to this mailing list). Patch-for-bug vs. patch-for-new feature might seem clear to those involved for a time, so it'd probably would give similar results to simply set up tags/keywords that can be assigned by the maintainers to sort the two types for later searches. (Assuming that, like on bugzilla, it's possible to create/assign arbitrary tags.) Also, a related question: does the patch tracker work with the same Gna account as the bug tracker? And send emails to this list? Wondering for my own reference if the patch tracker does end up being the preferred way. - John ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Patch tracker
> I've noticed numerous bugs with the [patch] tags in the gna bug > tracker. Just though it'd mention, if you haven't noticed already, > that there's a separate patch tracker available at > https://gna.org/patch/?group=freeciv > > Do you think we'd use it, or shall I just close it? I did noticed it but as it was not used I send all patches to the bug tracker. I would like to see the split bugs <> patches into two trackers, there bugs includes crashes / errors (+ the patches to correct them) and patches contains new features to freeciv. This way it would also be easier to check if a bug was reported before. Matthias > > Best, > > Daniel > > ___ > Freeciv-dev mailing list > Freeciv-dev@gna.org > https://mail.gna.org/listinfo/freeciv-dev > > -- Matthias Pfafferodt - http://www.mapfa.de Matthias.Pfafferodt mapfa.de ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] Patch tracker
I've noticed numerous bugs with the [patch] tags in the gna bug tracker. Just though it'd mention, if you haven't noticed already, that there's a separate patch tracker available at https://gna.org/patch/?group=freeciv Do you think we'd use it, or shall I just close it? Best, Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev