Re: [Freeipa-devel] [PATCH 0410] CI DNSSEC: fix zone delegation

On 29.1.2016 10:43, Martin Basti wrote: > > > On 25.01.2016 13:29, Martin Basti wrote: >> >> >> On 23.01.2016 10:34, Petr Spacek wrote: >>> On 22.1.2016 17:47, Martin Basti wrote: -# make BIND happy, and delegate zone which contains A record of master +# make BIND

Re: [Freeipa-devel] [PATCH 0013-0021] Coverity patches

On 29.01.2016 15:49, Stanislav Laznicka wrote: Reworded the commits so that they better reflect what's going on in those. On 01/29/2016 02:49 PM, Stanislav Laznicka wrote: Hello, I made some patches based on the Coverity report from 18.1.2016. Cheers, Standa NACK, see my previous

Re: [Freeipa-devel] [PATCH] extdom: Remove unused macro

On Fri, Jan 29, 2016 at 01:11:32PM +0100, Lukas Slebodnik wrote: > ehlo, > > Last usage of the macro SSSD_SYSDB_SID_STR was removed > in the commit 0ee8fe11aea9811c724182def3f50960d5dd87b3 > > LS ACK bye, Sumit -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0013-0021] Coverity patches

Reworded the commits so that they better reflect what's going on in those. On 01/29/2016 02:49 PM, Stanislav Laznicka wrote: Hello, I made some patches based on the Coverity report from 18.1.2016. Cheers, Standa From 56bfba733321388190cf6df0ec0dfab5fff15996 Mon Sep 17 00:00:00 2001 From:

Re: [Freeipa-devel] [PATCH 0013-0021] Coverity patches

On 29.01.2016 14:49, Stanislav Laznicka wrote: Hello, I made some patches based on the Coverity report from 18.1.2016. Cheers, Standa NACK *) please describe issue in commit message instead of #coverity number in all patches PATCH: Removing dead code LGTM PATCH: Wrong assert I'm not

Re: [Freeipa-devel] [PATCH 0030] Modernize mod_nss's cipher suites

py b/ipaserver/install/httpinstance.py index 3b46dce82cae017328c9555c543e78b64e642c89..44e0a7fe087ee2420e827c878b63010c7650989a 100644 --- a/ipaserver/install/httpinstance.py +++ b/ipaserver/install/httpinstance.py @@ -57,6 +57,19 @@ SELINUX_BOOLEAN_SETTINGS = dict( KDCPROXY_USER = 'kdcproxy' HTTPD_USER = co

[Freeipa-devel] [PATCH 0013-0021] Coverity patches

Hello, I made some patches based on the Coverity report from 18.1.2016. Cheers, Standa From 89a945cb78b324757636dbcaddabc2616d57bde2 Mon Sep 17 00:00:00 2001 From: Stanislav Laznicka Date: Fri, 29 Jan 2016 08:57:06 +0100 Subject: [PATCH 1/9] Removing dead code Coverity

Re: [Freeipa-devel] [PATCH 0030] Modernize mod_nss's cipher suites

On 29.01.2016 14:42, Christian Heimes wrote: On 2016-01-28 09:47, Martin Basti wrote: On 22.01.2016 12:32, Martin Kosek wrote: On 01/21/2016 04:21 PM, Christian Heimes wrote: The list of supported TLS cipher suites in /etc/httpd/conf.d/nss.conf has been modernized. Insecure or less secure

Re: [Freeipa-devel] [PATCH 2/3] ASN1: Fix warning Wpointer-to-int-cast

On 01/29/2016 12:48 PM, Lukas Slebodnik wrote: On (29/01/16 12:17), Martin Kosek wrote: On 01/29/2016 12:15 PM, Lukas Slebodnik wrote: ehlo, the first patch is very simple and it just suppress warning. The second patch is either bug or dead code. I fixed it as a bug. I'm not sure how to test

Re: [Freeipa-devel] [TEST][Patch 0020] Enabled recreation of test directory during ipa reinstallation

Hi, On 01/29/2016 01:44 PM, Martin Basti wrote: > > > On 29.01.2016 13:24, Oleg Fayans wrote: >> Hi Martin, >> >> On 01/29/2016 10:33 AM, Martin Basti wrote: >>> >>> On 21.01.2016 12:59, Oleg Fayans wrote: >>> Hello, >>> >>> 1) >>> I'm not sure if it is bug or it is related to this patch,

[Freeipa-devel] [PATCH] IPA-SAM: Fix build with samba 4.4

ehlo, attached patch shoudl fix build on fedora-24. It blocks static analysis scan. Even though it unblock build on fedora-24 the solution is not ideal. It's possible that some changes need to be done in samba side as well. (missing prototypes for trim_string, smb_xstrdup LS >From

Re: [Freeipa-devel] [PATCH 0411] upgrade: log to ipaupgrade.log if ipa is not installed

On 01/29/2016 10:48 AM, Martin Basti wrote: > Missing record in ipaupgrade.log that upgrade failed because IPA is not > installed, causes harder time to debugging upgrade from log. > > Patch attached. I am thinking that in these general catch-all clauses, it could be also useful to print the

Re: [Freeipa-devel] [PATCH 0410] CI DNSSEC: fix zone delegation

On 29.01.2016 11:10, Petr Spacek wrote: On 29.1.2016 10:43, Martin Basti wrote: On 25.01.2016 13:29, Martin Basti wrote: On 23.01.2016 10:34, Petr Spacek wrote: On 22.1.2016 17:47, Martin Basti wrote: -# make BIND happy, and delegate zone which contains A record of master +

[Freeipa-devel] [PATCH] extdom: Remove unused macro

ehlo, Last usage of the macro SSSD_SYSDB_SID_STR was removed in the commit 0ee8fe11aea9811c724182def3f50960d5dd87b3 LS >From 8f7818fb1efc1a224ddf7360d8c7bf6bd36da852 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Fri, 29 Jan 2016 13:08:07 +0100 Subject: [PATCH 4/4]

Re: [Freeipa-devel] [TEST][Patch 0020] Enabled recreation of test directory during ipa reinstallation

Hi Martin, On 01/29/2016 10:33 AM, Martin Basti wrote: > > > On 21.01.2016 12:59, Oleg Fayans wrote: >> >> > Hello, > > 1) > I'm not sure if it is bug or it is related to this patch, but there is > missing symetry in test_caless, I see there apply fixes but not > unapply_fixes test_caless is

Re: [Freeipa-devel] [PATCH 2/3] ASN1: Fix warning Wpointer-to-int-cast

On (29/01/16 13:06), Martin Babinsky wrote: >On 01/29/2016 12:48 PM, Lukas Slebodnik wrote: >>On (29/01/16 12:17), Martin Kosek wrote: >>>On 01/29/2016 12:15 PM, Lukas Slebodnik wrote: ehlo, the first patch is very simple and it just suppress warning. The second patch is either

Re: [Freeipa-devel] [TEST][Patch 0020] Enabled recreation of test directory during ipa reinstallation

On 29.01.2016 13:50, Oleg Fayans wrote: Hi, On 01/29/2016 01:44 PM, Martin Basti wrote: On 29.01.2016 13:24, Oleg Fayans wrote: Hi Martin, On 01/29/2016 10:33 AM, Martin Basti wrote: On 21.01.2016 12:59, Oleg Fayans wrote: Hello, 1) I'm not sure if it is bug or it is related to this

Re: [Freeipa-devel] [TEST][Patch 0021] Fixed recent replica installation issues in the lab

On 27.1.2016 11:16, Oleg Fayans wrote: > Sorry, trailing whitespace detected. This version passes lint > > On 01/27/2016 09:23 AM, Oleg Fayans wrote: >> > Hi, >> > >> > On 01/21/2016 04:41 PM, Petr Spacek wrote: >>> >> Hello, >>> >> >>> >> On 21.1.2016 13:42, Oleg Fayans wrote: >>>

Re: [Freeipa-devel] [PATCH] IPA-SAM: Fix build with samba 4.4

On (29/01/16 12:12), Lukas Slebodnik wrote: >ehlo, > >attached patch shoudl fix build on fedora-24. >It blocks static analysis scan. > >Even though it unblock build on fedora-24 >the solution is not ideal. It's possible that some changes >need to be done in samba side as well. >(missing prototypes

Re: [Freeipa-devel] [PATCH 2/3] ASN1: Fix warning Wpointer-to-int-cast

On (29/01/16 12:17), Martin Kosek wrote: >On 01/29/2016 12:15 PM, Lukas Slebodnik wrote: >> ehlo, >> >> the first patch is very simple and it just suppress warning. >> The second patch is either bug or dead code. I fixed it as a bug. >> I'm not sure how to test 2nd patch. >> >> LS > >Thanks. But

Re: [Freeipa-devel] [TEST][Patch 0020] Enabled recreation of test directory during ipa reinstallation

On 29.01.2016 13:24, Oleg Fayans wrote: Hi Martin, On 01/29/2016 10:33 AM, Martin Basti wrote: On 21.01.2016 12:59, Oleg Fayans wrote: Hello, 1) I'm not sure if it is bug or it is related to this patch, but there is missing symetry in test_caless, I see there apply fixes but not

[Freeipa-devel] [PATCH 2/3] ASN1: Fix warning Wpointer-to-int-cast

ehlo, the first patch is very simple and it just suppress warning. The second patch is either bug or dead code. I fixed it as a bug. I'm not sure how to test 2nd patch. LS >From 49b9cd2f037f52d5095acc0d05ee1684ebb6a121 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date:

Re: [Freeipa-devel] [PATCHES] 0761-0769 More Python3 fixes

Hi, On 27.1.2016 18:38, Petr Viktorin wrote: Hello, Here is a mixed bag of Python 3 fixes. They fix some tests, and they should enable you to use `python3 /usr/bin/ipa`. Patch 761: 1) The "invalid 'my_number': " bit comes from IPA itself, shouldn't we check at least that? Patch 762: 1)

Re: [Freeipa-devel] [PATCH 0410] CI DNSSEC: fix zone delegation

On 25.01.2016 13:29, Martin Basti wrote: On 23.01.2016 10:34, Petr Spacek wrote: On 22.1.2016 17:47, Martin Basti wrote: -# make BIND happy, and delegate zone which contains A record of master +# make BIND happy: add the glue record and delegate zone +args = [ +

Re: [Freeipa-devel] [PATCHES] 0761-0769 More Python3 fixes

On 29.1.2016 09:25, Jan Cholasta wrote: Hi, On 27.1.2016 18:38, Petr Viktorin wrote: Hello, Here is a mixed bag of Python 3 fixes. They fix some tests, and they should enable you to use `python3 /usr/bin/ipa`. Patch 761: 1) The "invalid 'my_number': " bit comes from IPA itself, shouldn't

Re: [Freeipa-devel] [PATCH] 0003 webui: Issue New Certificate dialogs validates data

On 01/28/2016 07:28 PM, Petr Vobornik wrote: Hi, there are few issues, NACK. 1. this patch uses tabs instead of spaces, previous was correct Fixed. 2. code which focuses first invalid field could be replaced by: widget_mod.focus_invalid(that); The old loop is replaced by this method.

Re: [Freeipa-devel] [PATCH 0126-0127] reset openldap client config to point to freshly promote replica

On 01/20/2016 09:40 AM, Martin Babinsky wrote: On 01/14/2016 05:29 PM, Martin Babinsky wrote: On 01/13/2016 05:59 PM, Rob Crittenden wrote: Martin Babinsky wrote: fixes https://fedorahosted.org/freeipa/ticket/5584 In order to ensure consistent behavior with ipa-client-install, I opted to

Re: [Freeipa-devel] [TEST][Patch 0020] Enabled recreation of test directory during ipa reinstallation

On 21.01.2016 12:59, Oleg Fayans wrote: Hello, 1) I'm not sure if it is bug or it is related to this patch, but there is missing symetry in test_caless, I see there apply fixes but not unapply_fixes ipatests/ipa-test-task:378:tasks.unapply_fixes(host)

[Freeipa-devel] [PATCH 0411] upgrade: log to ipaupgrade.log if ipa is not installed

Missing record in ipaupgrade.log that upgrade failed because IPA is not installed, causes harder time to debugging upgrade from log. Patch attached. From f457b0996fcc8d6a6e0bf95763a25b518e370501 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Wed, 27 Jan 2016 15:09:32

[Freeipa-devel] [TEST][Patch 0022] small refactoring in integration tests due to BZ 1303095

-- Oleg Fayans Quality Engineer FreeIPA team RedHat. From b866ff5336f742e170895b575df7a09419c2d731 Mon Sep 17 00:00:00 2001 From: Oleg Fayans Date: Fri, 29 Jan 2016 16:04:17 +0100 Subject: [PATCH] Moved NM configuration calls to the IntegrationTest base class Reconfiguring

Re: [Freeipa-devel] [PATCH] extdom: Remove unused macro

On 29.01.2016 14:56, Sumit Bose wrote: On Fri, Jan 29, 2016 at 01:11:32PM +0100, Lukas Slebodnik wrote: ehlo, Last usage of the macro SSSD_SYSDB_SID_STR was removed in the commit 0ee8fe11aea9811c724182def3f50960d5dd87b3 LS ACK bye, Sumit Pushed to master:

[Freeipa-devel] [PATCH 0412] CI tests: Do not set ip address for replica without installed IPA DNS in topology

Patch attached. Should fix test_installation for domain level 0 From d1a3796189cf2c34f0d4bdfcb1459dd436194170 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Fri, 15 Jan 2016 18:17:10 +0100 Subject: [PATCH] Tests: Do not set ip address for replica prepare without IPA DNS

Re: [Freeipa-devel] [PATCH] IPA-SAM: Fix build with samba 4.4

On Fri, 29 Jan 2016, Lukas Slebodnik wrote: On (29/01/16 12:12), Lukas Slebodnik wrote: ehlo, attached patch shoudl fix build on fedora-24. It blocks static analysis scan. Even though it unblock build on fedora-24 the solution is not ideal. It's possible that some changes need to be done in

Re: [Freeipa-devel] [PATCH 0126-0127] reset openldap client config to point to freshly promote replica

On 29.01.2016 09:01, Martin Babinsky wrote: On 01/20/2016 09:40 AM, Martin Babinsky wrote: On 01/14/2016 05:29 PM, Martin Babinsky wrote: On 01/13/2016 05:59 PM, Rob Crittenden wrote: Martin Babinsky wrote: fixes https://fedorahosted.org/freeipa/ticket/5584 In order to ensure consistent

Re: [Freeipa-devel] [PATCH] IPA-SAM: Fix build with samba 4.4

On (29/01/16 12:12), Lukas Slebodnik wrote: >ehlo, > >attached patch shoudl fix build on fedora-24. >It blocks static analysis scan. > >Even though it unblock build on fedora-24 >the solution is not ideal. It's possible that some changes >need to be done in samba side as well. >(missing prototypes