[Freeipa-devel] [PATCH] 198 Revert change causing failure in test automation

2012-08-22 Thread Petr Vobornik
Move of click handler in patch for #2834 causes failure of automation tests. This patch reverts the problematic part. It should not affect function of fix for #2834. https://fedorahosted.org/freeipa/ticket/3014 -- Petr Vobornik From 43db830f0a77186fa4affaa88a92cde897df1385 Mon Sep 17 00:00

[Freeipa-devel] [PATCH] 199 Permissions: select only applicable options on type change

2012-08-22 Thread Petr Vobornik
, this change is forgotten. https://fedorahosted.org/freeipa/ticket/2617 -- Petr Vobornik From 618494dc7494647679d1ef07c4c6179ceccce6c0 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Wed, 22 Aug 2012 14:03:20 +0200 Subject: [PATCH] Permissions: select only applicable options on type change

Re: [Freeipa-devel] [PATCH] 531-541 OTP UI

2014-02-21 Thread Petr Vobornik
On 10.2.2014 14:12, Petr Vobornik wrote: On 13.1.2014 17:09, Petr Vobornik wrote: Hi, these patches implements the OTP Web UI. Last 5 patches is the OTP UI. First 6 patches is a little refactoring/bug fixes needed for them. General password dialog is introduced to avoid another

Re: [Freeipa-devel] [PATCH]Extending user plugin with employeenumber field

2014-02-21 Thread Petr Vobornik
ployee within an organization' EQUALITY caseIgnoreMatch SUBSTR caseIgnoreSubstringsMatch SYNTAX 1.3.6.1.4.1.1466.115.121.1.15 SINGLE-VALUE ) -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 531-541 OTP UI

2014-02-24 Thread Petr Vobornik
would be better to fill the key and convert it to base32 string on a server. Nathaniel On Fri, 2014-02-21 at 15:24 +0100, Petr Vobornik wrote: On 10.2.2014 14:12, Petr Vobornik wrote: On 13.1.2014 17:09, Petr Vobornik wrote: Hi, these patches implements the OTP Web UI. Last 5 patche

Re: [Freeipa-devel] [PATCH] 531-541 OTP UI

2014-02-24 Thread Petr Vobornik
On 24.2.2014 15:31, Nathaniel McCallum wrote: On Mon, 2014-02-24 at 11:04 +0100, Petr Vobornik wrote: On 21.2.2014 20:00, Nathaniel McCallum wrote: Is it possible to do something more intelligent for the key and date fields in the add-token UI? Date fields are currently just a text box. Is

[Freeipa-devel] [PATCH] 544 webui: Focus expand/collapse link in batch_error dialog

2014-02-25 Thread Petr Vobornik
Dialog loses focus when the links are clicked making the dialog uncontrollable by keyboard. This patch focuses the link again after expanding/collapsing the error list. Thus keeping the focus in a dialog https://fedorahosted.org/freeipa/ticket/4097 -- Petr Vobornik From

[Freeipa-devel] [PATCH] 545 webui: Don't act on keyboard events which originated in, different dialog

2014-02-25 Thread Petr Vobornik
es the key 7. second dialog reacts to keyup event - which is by default confirmation mixin's confirm event 8. UNDESIRED behavior occurs Now confirmation mixin remembers which keys were pressed and released and reacts only to those which originated there. https://fedorahosted.org/freeipa/tic

[Freeipa-devel] [PATCH] 546 webui: expose krbprincipalexpiration

2014-02-25 Thread Petr Vobornik
Depends on tbabej's patches # 137, 138 and my 546. https://fedorahosted.org/freeipa/ticket/3306 -- Petr Vobornik From 7b4a35b811a8918adefa281e00ee06fad5f54064 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Wed, 15 Jan 2014 14:15:24 +0100 Subject: [PATCH] webui: expose krbprincipalexpir

[Freeipa-devel] [PATCH] 548 webui: change ipatokennotbefore and ipatokennotafter types to datetime

2014-02-25 Thread Petr Vobornik
Depends on tbabej's patches # 137, 140 and pvoborni's 546 and 531-541. https://fedorahosted.org/freeipa/ticket/3369 -- Petr Vobornik From 7a9d5636978b77a6e1119bc7e5724a811fcbf669 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Wed, 15 Jan 2014 14:19:41 +0100 Subject: [PATCH] web

[Freeipa-devel] [PATCH] 549 webui: use unique ids for checkboxes

2014-02-25 Thread Petr Vobornik
icking' as default check method. https://fedorahosted.org/freeipa/ticket/3904 -- Petr Vobornik From e64cbab0e4a3ef427e4f74e6f1183a9231dfb6c5 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Thu, 16 Jan 2014 13:54:03 +0100 Subject: [PATCH] webui: use unique ids for checkboxes Checkboxes have

Re: [Freeipa-devel] [PATCH] 531-541 OTP UI

2014-02-26 Thread Petr Vobornik
On 26.2.2014 01:55, Dmitri Pal wrote: On 02/24/2014 10:21 AM, Nathaniel McCallum wrote: On Mon, 2014-02-24 at 15:48 +0100, Petr Vobornik wrote: On 24.2.2014 15:31, Nathaniel McCallum wrote: On Mon, 2014-02-24 at 11:04 +0100, Petr Vobornik wrote: On 21.2.2014 20:00, Nathaniel McCallum wrote

Re: [Freeipa-devel] [PATCH] Too big font in input fields

2014-02-26 Thread Petr Vobornik
of jammed radios and labels. Martin, can we steal this CSS ticket and fix it with? input[type=radio], input[type=checkbox], .ui-widget input[type=radio], .ui-widget input[type=checkbox]{ margin-right: 5px; position: relative; top: 2px; } -- Petr Vobornik

Re: [Freeipa-devel] Is there RPC documentation?

2014-02-26 Thread Petr Vobornik
ct requests/responses in network tab. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 6 webui: Too big font in input fields

2014-02-27 Thread Petr Vobornik
On 26.2.2014 18:24, Adam Misnyovszki wrote: - Original Message - From: "Petr Vobornik" To: "Adam Misnyovszki" , freeipa-devel@redhat.com, "Martin Kosek" Sent: Wednesday, February 26, 2014 2:32:52 PM Subject: Re: [Freeipa-devel] [PATCH] Too big font in

Re: [Freeipa-devel] [PATCH] 531-541 OTP UI

2014-02-27 Thread Petr Vobornik
On 21.2.2014 15:24, Petr Vobornik wrote: On 10.2.2014 14:12, Petr Vobornik wrote: On 13.1.2014 17:09, Petr Vobornik wrote: Hi, these patches implements the OTP Web UI. Last 5 patches is the OTP UI. First 6 patches is a little refactoring/bug fixes needed for them. General password dialog is

Re: [Freeipa-devel] [PATCH] 531-541 OTP UI

2014-02-27 Thread Petr Vobornik
On 27.2.2014 16:51, Nathaniel McCallum wrote: On Thu, 2014-02-27 at 13:35 +0100, Petr Vobornik wrote: On 21.2.2014 15:24, Petr Vobornik wrote: On 10.2.2014 14:12, Petr Vobornik wrote: On 13.1.2014 17:09, Petr Vobornik wrote: Hi, these patches implements the OTP Web UI. Last 5 patches is

Re: [Freeipa-devel] Client-side command in the IPA framework

2014-02-28 Thread Petr Vobornik
third party products. Parsing on client would be understandable if there was some middle step which would require some action from user, i.e, pick only some tokens to import. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 546 webui: Datetime parsing and formatting

2014-03-06 Thread Petr Vobornik
On 6.3.2014 13:01, Misnyovszki Adam wrote: On Tue, 25 Feb 2014 18:05:28 +0100 Petr Vobornik wrote: prerequisite for patch 547, 548 depends on tbabej's datetime patch this patch implements: - output_formatter in field. It should be used in par with formatter. Formatter serves for datas

[Freeipa-devel] [PATCH] 550 webui-css: improve radio, checkbox keyboard support and color

2014-03-07 Thread Petr Vobornik
with overflow set. https://fedorahosted.org/freeipa/ticket/4217 -- Petr Vobornik From a554df223b33de5c7ede4838cef6e558170761ab Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Thu, 27 Feb 2014 18:21:05 +0100 Subject: [PATCH] webui-css: improve radio,checkbox keyboard support and color checkboxes

Re: [Freeipa-devel] [PATCH] 550 webui-css: improve radio, checkbox keyboard support and color

2014-03-13 Thread Petr Vobornik
On 7.3.2014 15:34, Petr Vobornik wrote: checkboxes and radio buttons: - do not change color on hover when disabled - are focusable and checkable by keyboard again. This uses a little trick where the real checkbox is hidden under the artificial checkbox. That way it has the same position

Re: [Freeipa-devel] [PATCH] BuildRequires: rhino in .spec file

2014-03-14 Thread Petr Vobornik
7.0-opnjdk no longer pulls rhino. Caused by: http://pkgs.fedoraproject.org/cgit/java-1.7.0-openjdk.git/commit/?id=63ecc0b8d60970f6d1d80f822cebf78441beb56a -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mail

Re: [Freeipa-devel] [PATCH] BuildRequires: rhino in .spec file

2014-03-14 Thread Petr Vobornik
On 14.3.2014 14:50, Petr Vobornik wrote: On 14.3.2014 14:20, Nalin Dahyabhai wrote: When I try to scratch build master using 'make srpm' and koji, the build log includes multiple errors like this: ../../util/make-ui.sh Error: Could not find or load

Re: [Freeipa-devel] [PATCH] 548 webui: change ipatokennotbefore and ipatokennotafter types to datetime

2014-03-14 Thread Petr Vobornik
On 25.2.2014 18:10, Petr Vobornik wrote: Depends on tbabej's patches # 137, 140 and pvoborni's 546 and 531-541. https://fedorahosted.org/freeipa/ticket/3369 Attaching rebased patch. -- Petr Vobornik From 5e3b639f5f7edd6d4539951e448e13666dc19795 Mon Sep 17 00:00:00 2001 From: Pet

Re: [Freeipa-devel] [PATCH] 550 webui-css: improve radio, checkbox keyboard support and color

2014-03-14 Thread Petr Vobornik
On 13.3.2014 16:55, Petr Vobornik wrote: On 7.3.2014 15:34, Petr Vobornik wrote: checkboxes and radio buttons: - do not change color on hover when disabled - are focusable and checkable by keyboard again. This uses a little trick where the real checkbox is hidden under the artificial

[Freeipa-devel] [PATCH] 558 webui: remove hover effect from disabled action button

2014-03-17 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/4256 -- Petr Vobornik From 3378be53351fb3521cb4b73b8b76c02703583463 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Mon, 17 Mar 2014 15:14:44 +0100 Subject: [PATCH] webui: remove hover effect from disabled action button https://fedorahosted.org/freeipa

Re: [Freeipa-devel] [PATCH] 558 webui: remove hover effect from disabled action button

2014-03-17 Thread Petr Vobornik
On 17.3.2014 15:16, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/4256 Petr3 found that the effect is still there when the button is focused. It's caused by another bug - https://fedorahosted.org/freeipa/ticket/4258 Disabled action buttons are focusable New revision o

Re: [Freeipa-devel] [PATCH] [DOC] login as another user in the WebUI

2014-03-19 Thread Petr Vobornik
t 3) kinit anotheruser 4) open web ui -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 560 webui: rename domNode to dom_node

2014-03-19 Thread Petr Vobornik
- unites domNode and dom_node usage to dom_node -- Petr Vobornik From da7c558e3e8a3086b57b844062421b71b657adf0 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Fri, 22 Nov 2013 10:22:15 +0100 Subject: [PATCH] webui: rename domNode to dom_node - unites domNode and dom_node usage to dom_node

[Freeipa-devel] [PATCH] 561 webui: make navigation module independent on app module

2014-03-19 Thread Petr Vobornik
ation boot classes. Navigation now depends on app_container. -- Petr Vobornik From 1c7459e8d5d0a3acd416db32b022ba73ad6b7d79 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Wed, 19 Mar 2014 15:29:58 +0100 Subject: [PATCH] webui: make navigation module independent on app module When some module use

[Freeipa-devel] [PATCH] 559 webui: update license information of used third party code

2014-03-19 Thread Petr Vobornik
ng of RCUE styles along with Bootstrap 2.0. - removal of jQuery BBQ plugin - removal of rhino enviroment for selenium which was used in old UI tests -- Petr Vobornik From 0782e0e71641af4df1f59f78a71853f9b09a8606 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Mon, 18 Nov 2013 14:49:37 +0100 Su

Re: [Freeipa-devel] [PATCH] 550 webui-css: improve radio, checkbox keyboard support and color

2014-03-20 Thread Petr Vobornik
On 19.3.2014 16:32, Misnyovszki Adam wrote: On Fri, 14 Mar 2014 18:39:14 +0100 Petr Vobornik wrote: On 13.3.2014 16:55, Petr Vobornik wrote: On 7.3.2014 15:34, Petr Vobornik wrote: checkboxes and radio buttons: - do not change color on hover when disabled - are focusable and checkable by

Re: [Freeipa-devel] [PATCH] 552-557 Permissions v2 Web UI

2014-03-20 Thread Petr Vobornik
On 19.3.2014 17:03, Misnyovszki Adam wrote: On Wed, 19 Mar 2014 10:52:10 +0100 Petr Viktorin wrote: On 03/18/2014 04:56 PM, Petr Vobornik wrote: On 18.3.2014 15:07, Petr Viktorin wrote: On 03/18/2014 01:09 PM, Petr Vobornik wrote: New revision for patch patch #557 attached. On 17.3.2014

Re: [Freeipa-devel] [PATCH] 559 webui: update license information of used third party code

2014-03-20 Thread Petr Vobornik
On 19.3.2014 16:19, Simo Sorce wrote: On Wed, 2014-03-19 at 16:02 +0100, Petr Vobornik wrote: I have some cleanup and refactoring patches which were created along with RCUE login effort. They are not that much connected so I'm sending them now (in 4 mails) to make the subsequent review sm

Re: [Freeipa-devel] [PATCH] [DOC] login as another user in the WebUI

2014-03-20 Thread Petr Vobornik
On 20.3.2014 00:03, Gabe Alford wrote: Thanks for the review. Here's an updated patch. Gabe ACK Pushed to master: befe9632c4636a151f5e4ed11a58e7e48ba8c877 On Wed, Mar 19, 2014 at 3:35 AM, Petr Vobornik wrote: On 19.3.2014 02:29, Gabe Alford wrote: All, Just added a couple of

[Freeipa-devel] [PATCH] 564 webui-ci: fix test_rebuild_membership_hosts on server without DNS

2014-03-21 Thread Petr Vobornik
Host adder dialog differs on installations with and without DNS. Previous test used values for adding hosts which were suitable only for IPA servers installed with DNS. -- Petr Vobornik From 9ca559347b4f233772b2179da725eb28bddbe4e2 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Fri, 21 Mar

Re: [Freeipa-devel] [PATCH 0038] Fix generation of invalid OTP URIs

2014-03-24 Thread Petr Vobornik
. Since this patch rotted a bit, attaching rebased version. IMO we should not push this patch. Wasn't it superseded by: https://git.fedorahosted.org/cgit/freeipa.git/commit/?id=21ff4f920e4ff7c1e2870024f007f067fc3cf6c8 ? -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 560 webui: rename domNode to dom_node

2014-03-25 Thread Petr Vobornik
On 20.3.2014 16:51, Misnyovszki Adam wrote: On Wed, 19 Mar 2014 16:02:12 +0100 Petr Vobornik wrote: - unites domNode and dom_node usage to dom_node Nack, install/ui/test/details_tests.js:236 install/ui/test/details_tests.js:242 only finds element, because context(ie domNode) is undefined

Re: [Freeipa-devel] [PATCH]Extending user plugin with employeenumber field

2014-03-25 Thread Petr Vobornik
On 21.3.2014 11:00, Misnyovszki Adam wrote: On Fri, 21 Mar 2014 10:13:55 +0100 Misnyovszki Adam wrote: On Fri, 21 Feb 2014 16:06:27 +0100 Petr Vobornik wrote: On 21.2.2014 15:45, Adam Misnyovszki wrote: Hi, According to http://tools.ietf.org/html/rfc2798 ipa client and web ui extended

Re: [Freeipa-devel] [PATCH] 560 webui: rename domNode to dom_node

2014-03-26 Thread Petr Vobornik
On 25.3.2014 16:26, Misnyovszki Adam wrote: On Tue, 25 Mar 2014 12:49:24 +0100 Petr Vobornik wrote: On 20.3.2014 16:51, Misnyovszki Adam wrote: On Wed, 19 Mar 2014 16:02:12 +0100 Petr Vobornik wrote: - unites domNode and dom_node usage to dom_node Nack, install/ui/test/details_tests.js

Re: [Freeipa-devel] [PATCH] 561 webui: make navigation module independent on app module

2014-03-27 Thread Petr Vobornik
On 26.3.2014 15:36, Misnyovszki Adam wrote: On Wed, 19 Mar 2014 16:02:19 +0100 Petr Vobornik wrote: When some module used 'freeipa/navigation' it pulled the entire Web UI because navigation depended on app. This patch splits the app into two modules: app and app_container. App spe

Re: [Freeipa-devel] [PATCH] 562-563 webui: move RPC code from IPA module to its own module

2014-03-27 Thread Petr Vobornik
On 27.3.2014 14:38, Misnyovszki Adam wrote: On Wed, 19 Mar 2014 16:02:29 +0100 Petr Vobornik wrote: depends on path #561(make navigation module independent on app module) [PATCH] 562 webui: move RPC code from IPA module to its own module - moves RPC code from ipa.js to it's own m

Re: [Freeipa-devel] [PATCH]Extending user plugin with employeenumber field

2014-03-28 Thread Petr Vobornik
: 0f626a9cc870ba0bdcc1322d765687b0e597c26c -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 584 migration: fix import of wsgiref.util

2014-03-31 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/4293 -- Petr Vobornik From dc4eaf9d622b4eac9fb3d942b23083bfb903be9a Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Tue, 1 Apr 2014 08:45:08 +0200 Subject: [PATCH] migration: fix import of wsgiref.util https://fedorahosted.org/freeipa/ticket/4293

Re: [Freeipa-devel] [PATCH] 565-568 webui: field and widget binding refactoring

2014-04-03 Thread Petr Vobornik
On 2.4.2014 17:57, Misnyovszki Adam wrote: On Thu, 27 Mar 2014 16:07:55 +0100 Petr Vobornik wrote: The last refactoring I did while implementing RCUE login or more precisely support for standalone facets which have forms but are not details facets. [PATCH] webui: field and widget binding

[Freeipa-devel] Changing RCUE to PatternFly

2014-04-03 Thread Petr Vobornik
fies upgrades). Our own LESS files don't use any new Less markup features so we are still able to compile it with current version of python-lesscpy. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 585 webui: fix OTP Token add regression

2014-04-15 Thread Petr Vobornik
Petr Vobornik From d047720e6f00a2579546b7f60716b5846df034c6 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Tue, 15 Apr 2014 09:47:21 +0200 Subject: [PATCH] webui: fix OTP Token add regression OTP Token add failed because of invalid function call. qr_widget doesn't contain `on_value_chang

Re: [Freeipa-devel] [PATCH] 569-583 New Login Screen

2014-04-15 Thread Petr Vobornik
On 15.4.2014 12:05, Misnyovszki Adam wrote: On Tue, 15 Apr 2014 09:39:54 +0200 Petr Vobornik wrote: On 11.4.2014 14:31, Misnyovszki Adam wrote: On Fri, 28 Mar 2014 14:04:13 +0100 Petr Vobornik wrote: Attached patches replace IPA.unauthorized dialog with new Login Screen. To make it

Re: [Freeipa-devel] [PATCH] 14 webui: select all checkbox remains selected after operation

2014-04-23 Thread Petr Vobornik
facet (group/external) (not tested). -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 15 webui doc: typo fixes in guides

2014-04-23 Thread Petr Vobornik
On 18.4.2014 14:41, Misnyovszki Adam wrote: Hi, $SUBJ tells everything. Thanks Adam ACK Pushed to master: 260c5bd10927d3e01202ed1cccbdf4463c98e8a5 -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com

[Freeipa-devel] [PATCH] webui: regression - enable fields on idrange type change (add)

2014-04-25 Thread Petr Vobornik
ID range adder dialog was not properly addressed in field binding refactoring. The usage of reset caused some weird loops. https://fedorahosted.org/freeipa/ticket/4326 -- Petr Vobornik From 9e9e72dc795156811662b5130ad58084a898974c Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Thu, 24 Apr

[Freeipa-devel] [PATCH] 587 webui-ci: adjust id range tests to new validator

2014-04-25 Thread Petr Vobornik
SSIA -- Petr Vobornik From 66410a435d641a90da7bc0f525d5e73e3a5c549d Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Thu, 24 Apr 2014 17:24:59 +0200 Subject: [PATCH] webui-ci: adjust id range tests to new validator --- ipatests/test_webui/task_range.py | 33

[Freeipa-devel] [PATCH] 588 webui: fix switching between multiple_choice_section choices

2014-04-25 Thread Petr Vobornik
hoice. https://fedorahosted.org/freeipa/ticket/4327 -- Petr Vobornik From e76604f82bacf23c51c4bc8821421aaa657ea0de Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Fri, 25 Apr 2014 19:15:52 +0200 Subject: [PATCH] webui: fix switching between multiple_choice_section choices - required indicator

Re: [Freeipa-devel] [PATCH] 14 webui: select all checkbox remains selected after operation

2014-04-29 Thread Petr Vobornik
On 24.4.2014 14:57, Misnyovszki Adam wrote: On Wed, 23 Apr 2014 16:57:35 +0200 Petr Vobornik wrote: On 18.4.2014 10:43, Misnyovszki Adam wrote: Hi, this patch fixes select_all checkbox issue, after any bulk modify or delete operation, the checkbox is deselected. https://fedorahosted.org

Re: [Freeipa-devel] [PATCH] webui: regression - enable fields on idrange type change (add)

2014-04-29 Thread Petr Vobornik
On 29.4.2014 16:25, Misnyovszki Adam wrote: On Fri, 25 Apr 2014 15:01:36 +0200 Petr Vobornik wrote: ID range adder dialog was not properly addressed in field binding refactoring. The usage of reset caused some weird loops. https://fedorahosted.org/freeipa/ticket/4326 tests with and

[Freeipa-devel] [PATCH] 589-590 webui-ci: save screenshot on test failure

2014-04-30 Thread Petr Vobornik
`screenshot_dir: /path/to/dir` to specify target directory otherwise screenshots are saved to current directory -- Petr Vobornik From 179c2dca196d211ef9454dae84e9cc7a0580af71 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Tue, 29 Apr 2014 09:16:24 +0200 Subject: [PATCH] webui-ci: decorate

[Freeipa-devel] [PATCH] 591 webui: add idnsSecInlineSigning option to DNS zone details facet

2014-04-30 Thread Petr Vobornik
Web UI part of pviktori-543 https://fedorahosted.org/freeipa/ticket/3801 -- Petr Vobornik From 2652953332ec5f5ee6f131a389168f5ee37099a5 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Wed, 30 Apr 2014 12:24:25 +0200 Subject: [PATCH] webui: add idnsSecInlineSigning option to DNS zone details

Re: [Freeipa-devel] [PATCH] 18 webui otptoken test data added

2014-04-30 Thread Petr Vobornik
ation of otptoken_get_records.json and otptoken_find_pkeys.json is enough). In general, it's OK to fake the data if there is some bug which causes errors and we know that it will be fixed. -- Petr Vobornik ___ Freeipa-devel mailing list Fre

Re: [Freeipa-devel] [PATCH] 587 webui-ci: adjust id range tests to new validator

2014-05-05 Thread Petr Vobornik
On 5.5.2014 14:05, Misnyovszki Adam wrote: On Fri, 25 Apr 2014 15:02:27 +0200 Petr Vobornik wrote: SSIA LGFM, integration tests for range now runs smoothly. ACK Thanks Adam Pushed to master: 7eff8ad7dc385070b600ddb2b2ba1f39835718b6 -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 588 webui: fix switching between multiple_choice_section choices

2014-05-05 Thread Petr Vobornik
On 5.5.2014 14:40, Misnyovszki Adam wrote: On Fri, 25 Apr 2014 19:24:35 +0200 Petr Vobornik wrote: - required indicators are not present for all sections except the last - validation has wrong color for the same sections There was only one layout for all choices. Layout should not be reused

Re: [Freeipa-devel] [PATCH] 18 webui otptoken test data added

2014-05-06 Thread Petr Vobornik
On 5.5.2014 16:39, Misnyovszki Adam wrote: On Wed, 30 Apr 2014 13:37:10 +0200 Petr Vobornik wrote: On 29.4.2014 16:30, Misnyovszki Adam wrote: On Fri, 25 Apr 2014 17:16:48 +0200 Misnyovszki Adam wrote: Hi, this patch adds some static test data for the webui otptoken part. Adam Attached

Re: [Freeipa-devel] [PATCH] 16-17 Attribute box in permission UI is too small

2014-05-06 Thread Petr Vobornik
ch to this widget by the context parameter ($node). It will also allow you to use simpler selector. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0001] Fixed typo in ipa_backup.py

2014-05-06 Thread Petr Vobornik
On 2.5.2014 17:20, Nathaniel McCallum wrote: ACK Nathaniel Pushed to master: 3f3c8eee24f98807ff8a95dd0f6a022b2b3a5bf5 -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0046] Fix a typo in the otptoken doc string

2014-05-06 Thread Petr Vobornik
s. https://www.redhat.com/archives/freeipa-devel/2014-May/msg00039.html Nathaniel Pushed to master: 797974b09fdd078c8ad645c217a464b69ce72f66 -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 629 webui: otptoken-adder dialog - remove obsolete comment

2014-05-06 Thread Petr Vobornik
No longer valid. HOTP tokens are also supported. -- Petr Vobornik From 4ca6c7527e27191339b65ea5fd3583a27129303e Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Tue, 6 May 2014 13:28:49 +0200 Subject: [PATCH] webui: otptoken-adder dialog - remove obsolete comment - hotp tokens are also

Re: [Freeipa-devel] [PATCH 0050] Fix typo in token UI javascript comment

2014-05-06 Thread Petr Vobornik
On 5.5.2014 19:25, Jan Cholasta wrote: On 5.5.2014 19:10, Nathaniel McCallum wrote: Attached. ACK. NACK, the comment is no longer valid and should be removed. New patch: http://www.redhat.com/archives/freeipa-devel/2014-May/msg00057.html -- Petr Vobornik

Re: [Freeipa-devel] [PATCH 0001] Fixed typo in ipa-test-task man page

2014-05-06 Thread Petr Vobornik
On 6.5.2014 12:49, Tomas Babej wrote: ACK. On 05/06/2014 11:05 AM, Thorsten Scherf wrote: Pushed to master: 7646cb8e580f11987c98f1ef81179aecf082eea9 -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com

Re: [Freeipa-devel] [PATCH 0001] Fixed various typos in ipa-client-install man page

2014-05-06 Thread Petr Vobornik
On 6.5.2014 12:49, Tomas Babej wrote: ACK. Pushed to master: 7cf683b3bc3f8afef6e52d2ff570f2bea77b7a5e -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0001] Adding verb to error message to make it less confusing

2014-05-06 Thread Petr Vobornik
. Pushed to master: d4e1b05484f41ef7a479861c07685dfe5ca1b73b -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] plugin registration refactoring for pwpolicy

2014-05-06 Thread Petr Vobornik
On 2.5.2014 17:19, Nathaniel McCallum wrote: On Fri, 2014-05-02 at 14:01 +0200, Misnyovszki Adam wrote: SSIA Thanks Adam Simple enough. ACK. Nathaniel Pushed to master: 2c08a16f8f52927332bd5fde31bc855b2d657afc -- Petr Vobornik ___ Freeipa-devel

Re: [Freeipa-devel] [PATCH 0052] Only specify the ipatokenuniqueid default in the add operation

2014-05-06 Thread Petr Vobornik
://fedorahosted.org/freeipa/ticket/4227 shouldn't removal of `autofill=True,` be enough? -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0052] Only specify the ipatokenuniqueid default in the add operation

2014-05-06 Thread Petr Vobornik
On 6.5.2014 17:13, Nathaniel McCallum wrote: On Tue, 2014-05-06 at 17:04 +0200, Petr Vobornik wrote: On 6.5.2014 16:51, Nathaniel McCallum wrote: Specifying the default in the LDAP Object causes the parameter to be specified for non-add operations. This is especially problematic when

Re: [Freeipa-devel] [PATCH] 629 webui: otptoken-adder dialog - remove obsolete comment

2014-05-07 Thread Petr Vobornik
On 6.5.2014 14:22, Misnyovszki Adam wrote: On Tue, 06 May 2014 13:34:28 +0200 Petr Vobornik wrote: No longer valid. HOTP tokens are also supported. ACK Pushed to master: c4d79eaf59a8bc50ca2e18d704b240e18d6d6e68 -- Petr Vobornik ___ Freeipa

[Freeipa-devel] [PATCH] 630 rpcserver: login_password datetime fix in expiration check

2014-05-07 Thread Petr Vobornik
krbpasswordexpiration conversion to number of second since epoch failed because now we get datetime object instead of string. https://fedorahosted.org/freeipa/ticket/4339 -- Petr Vobornik From e0c7e6525e3bb30050aae9440e698d84b5b7d7b1 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Wed, 7 May

Re: [Freeipa-devel] [PATCH 0048] Default the token owner to the person adding the token

2014-05-07 Thread Petr Vobornik
27;, cur_uid) if cur_uid != prev_uid: entry_attrs.setdefault('ipatokenprotected', True) Fixed (see also my new revision of patch 0049). Nathaniel I assume that this won't allow to create a token without an owner. Do we want to have this res

Re: [Freeipa-devel] [PATCH] 630 rpcserver: login_password datetime fix in expiration check

2014-05-07 Thread Petr Vobornik
On 7.5.2014 16:01, Tomas Babej wrote: On 05/07/2014 03:47 PM, Petr Vobornik wrote: krbpasswordexpiration conversion to number of second since epoch failed because now we get datetime object instead of string. https://fedorahosted.org/freeipa/ticket/4339 NACK, I don't think this i

Re: [Freeipa-devel] [PATCH] 584 migration: fix import of wsgiref.util

2014-05-07 Thread Petr Vobornik
On 7.5.2014 15:38, Tomas Babej wrote: On 04/01/2014 09:25 AM, Jan Pazdziora wrote: On Tue, Apr 01, 2014 at 08:47:25AM +0200, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/4293 -- Petr Vobornik From dc4eaf9d622b4eac9fb3d942b23083bfb903be9a Mon Sep 17 00:00:00 2001 From: Petr

Re: [Freeipa-devel] [PATCH] 630 rpcserver: login_password datetime fix in expiration check

2014-05-07 Thread Petr Vobornik
On 7.5.2014 16:30, Tomas Babej wrote: On 05/07/2014 04:26 PM, Petr Vobornik wrote: On 7.5.2014 16:01, Tomas Babej wrote: On 05/07/2014 03:47 PM, Petr Vobornik wrote: krbpasswordexpiration conversion to number of second since epoch failed because now we get datetime object instead of string

Re: [Freeipa-devel] [PATCH] 18 webui otptoken test data added

2014-05-07 Thread Petr Vobornik
On 7.5.2014 15:16, Misnyovszki Adam wrote: On Tue, 06 May 2014 10:29:32 +0200 Petr Vobornik wrote: On 5.5.2014 16:39, Misnyovszki Adam wrote: On Wed, 30 Apr 2014 13:37:10 +0200 Petr Vobornik wrote: On 29.4.2014 16:30, Misnyovszki Adam wrote: On Fri, 25 Apr 2014 17:16:48 +0200 Misnyovszki

Re: [Freeipa-devel] [PATCH] 22-23 webui tests extended by checking field disable property

2014-05-12 Thread Petr Vobornik
ature added * aa437329104d1660d518a5dd0d5961c76a56f380 webui tests: range test extended -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0001] Fixed typo in ipa-replica-manage man page

2014-05-12 Thread Petr Vobornik
ssage - Arghh. Friday fixes. :( Next try... Cheers, Thorsten -- Petr Vobornik From f425ed018a45edbeb8712c2f68f3b20487b04a80 Mon Sep 17 00:00:00 2001 From: Thorsten Scherf Date: Fri, 9 May 2014 15:21:10 +0200 Subject: [PATCH] Fixed typo in ipa-replica-manage man page --- install/tools/ma

Re: [Freeipa-devel] [PATCH] 589-590 webui-ci: save screenshot on test failure

2014-05-12 Thread Petr Vobornik
On 12.5.2014 18:13, Misnyovszki Adam wrote: On Wed, 30 Apr 2014 10:40:43 +0200 Petr Vobornik wrote: Very handy for debugging failures... New decorator: ui_driver.screenshot created. It should be applied on test methods. Screenshot is saved on each exception except SkipTest. Configuration

[Freeipa-devel] [PATCH] 631 webui: fix regression: enabled gid field on group add

2014-05-14 Thread Petr Vobornik
/ticket/4325 -- Petr Vobornik From e1305b80d99d03627128083737c43ede97d61a5b Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Thu, 24 Apr 2014 16:32:07 +0200 Subject: [PATCH] webui: fix regression: enabled gid field on group add GID field should be enabled by default since the default group is posix

Re: [Freeipa-devel] OTP Sync Client Design

2014-05-15 Thread Petr Vobornik
rver.login_password and change_password methods. Then it could be use from various UIs - main IPA Web UI, separate page, some CLI app... -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] OTP Sync Client Design

2014-05-15 Thread Petr Vobornik
ms they face and what we should address next. We probably should have a "Token owner guide" that would talk about these scenarios and help people to resolve them. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 632 webui: simplify self-service menu

2014-05-15 Thread Petr Vobornik
elf-service-menu-1level.png -- Petr Vobornik From a7fd9c19b8414f6264d9b325e362f1a1f12158cd Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Thu, 15 May 2014 15:44:29 +0200 Subject: [PATCH] webui: simplify self-service menu there is only one top level item -> no point of having this level. This

Re: [Freeipa-devel] [PATCH] 632 webui: simplify self-service menu

2014-05-16 Thread Petr Vobornik
ng new: * http://pvoborni.fedorapeople.org/images/self-service-menu-1level.png -- Petr Vobornik -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 592-628 Update to PatternFly

2014-05-19 Thread Petr Vobornik
On 12.5.2014 17:46, Misnyovszki Adam wrote: Hi, see my review notes below: On Mon, 05 May 2014 18:41:13 +0200 Petr Vobornik wrote: This patchset updates Bootstrap 2 based RCUE to Bootstrap 3 based PatternFly (v0.2.4) according to plan described at: http://www.redhat.com/archives/freeipa

[Freeipa-devel] [PATCH] 643 Increase Java stack size for Web UI build on aarch64

2014-05-21 Thread Petr Vobornik
Fixes build failure on aarch64: http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=2328356 Successful scratch build: http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=233 One patch is for upstream, second for fedora package. -- Petr Vobornik From

Re: [Freeipa-devel] [PATCH 0052] Only specify the ipatokenuniqueid default in the add operation

2014-05-22 Thread Petr Vobornik
+0200, Petr Vobornik wrote: On 6.5.2014 17:13, Nathaniel McCallum wrote: On Tue, 2014-05-06 at 17:04 +0200, Petr Vobornik wrote: On 6.5.2014 16:51, Nathaniel McCallum wrote: Specifying the default in the LDAP Object causes the parameter to be specified for non-add operations. This is especially

Re: [Freeipa-devel] OTP Sync Client Design

2014-05-26 Thread Petr Vobornik
here is no time and if we want the feature, combination of Martin's #1 and #2 would a sufficient solution. Both could be just an interface for the same logic. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 630 rpcserver: login_password datetime fix in expiration check

2014-05-26 Thread Petr Vobornik
On 22.5.2014 10:37, Tomas Babej wrote: On 05/07/2014 04:37 PM, Petr Vobornik wrote: On 7.5.2014 16:30, Tomas Babej wrote: On 05/07/2014 04:26 PM, Petr Vobornik wrote: On 7.5.2014 16:01, Tomas Babej wrote: On 05/07/2014 03:47 PM, Petr Vobornik wrote: krbpasswordexpiration conversion to

Re: [Freeipa-devel] [PATCH] 643 Increase Java stack size for Web UI build on aarch64

2014-05-26 Thread Petr Vobornik
On 21.5.2014 10:30, Alexander Bokovoy wrote: On Wed, 21 May 2014, Petr Vobornik wrote: Fixes build failure on aarch64: http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=2328356 Successful scratch build: http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=233 One patch is for

Re: [Freeipa-devel] [PATCH] 592-628 Update to PatternFly

2014-05-26 Thread Petr Vobornik
On 19.5.2014 14:58, Petr Vobornik wrote: On 12.5.2014 17:46, Misnyovszki Adam wrote: Hi, see my review notes below: On Mon, 05 May 2014 18:41:13 +0200 Petr Vobornik wrote: This patchset updates Bootstrap 2 based RCUE to Bootstrap 3 based PatternFly (v0.2.4) according to plan described at

[Freeipa-devel] [PATCH] 645 webui: display only dialogs which belong to current facet

2014-05-27 Thread Petr Vobornik
ogs, which are not global dialogs and did not originate from current facet, when switching facets. https://fedorahosted.org/freeipa/ticket/4348 -- Petr Vobornik From 3b01f6ddc98e2f769dd5e915ccd6d27fcf5f4886 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Tue, 20 May 2014 12:57:28 +0200 Subje

[Freeipa-devel] [PATCH] 646 webui: handle back button when unauthenticated

2014-05-27 Thread Petr Vobornik
switch to facet which requires authentication. https://fedorahosted.org/freeipa/ticket/4353 -- Petr Vobornik From 0fcf3b84d603ac1769ba9f8806dfa2a4b6ccfd0a Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Wed, 21 May 2014 10:07:19 +0200 Subject: [PATCH] webui: handle back button when

[Freeipa-devel] [PATCH] 647-651 [webui] Make utility section of navigation extensible

2014-05-27 Thread Petr Vobornik
patches fixes navigation/router to support custom URL path patterns. The usage of facet.create_hash(router) method in patch #649 is questionable. The WIP patch contains an example of a plugin which uses this functionality. -- Petr Vobornik From c7582a3fe8d26b51028e1da24642f2456ae0f7f4 Mon Sep 17

[Freeipa-devel] Should normal user see his krbt and password policies?

2014-05-27 Thread Petr Vobornik
an obvious bug: https://fedorahosted.org/freeipa/ticket/4354 The question is whether normal user should see this information or not. If yes, we should fix default permissions. If not, we should fix Web UI. -- Petr Vobornik ___ Freeipa-devel mailing

Re: [Freeipa-devel] Should normal user see his krbt and password policies?

2014-05-27 Thread Petr Vobornik
On 27.5.2014 14:28, Petr Vobornik wrote: Recent removal of global read-only ACI affects current self-service page. Now it displays error dialog with two errors: * None: password policy not found * an internal error has occurred They are results of: * pwpolicy-show --user=username * krbtpolicy

Re: [Freeipa-devel] [PATCH] 592-628 Update to PatternFly

2014-05-29 Thread Petr Vobornik
On 26.5.2014 17:08, Petr Vobornik wrote: On 19.5.2014 14:58, Petr Vobornik wrote: On 12.5.2014 17:46, Misnyovszki Adam wrote: Hi, see my review notes below: On Mon, 05 May 2014 18:41:13 +0200 Petr Vobornik wrote: This patchset updates Bootstrap 2 based RCUE to Bootstrap 3 based PatternFly

<    4   5   6   7   8   9   10   11   12   13   >