[Freeipa-devel] [PATCH] 1 Remove unnecessary BuildRequires

2011-02-08 Thread Jan Cholasta
Removed 2 unnecessary BuildRequires from freeipa.spec.in: * e2fsprogs-devel: obsoleted by libuuid-devel * libcap-devel: not needed to build the RPM diff --git a/freeipa.spec.in b/freeipa.spec.in index 9da5809..84c9e8c 100644 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -29,10 +29,8 @@

Re: [Freeipa-devel] [PATCH] 1 Remove unnecessary BuildRequires

2011-02-08 Thread Jan Cholasta
Fixing newbie mistake: included properly formated patch. It was tested in mock. Dne 8.2.2011 18:30, Jan Cholasta napsal(a): Removed 2 unnecessary BuildRequires from freeipa.spec.in: * e2fsprogs-devel: obsoleted by libuuid-devel * libcap-devel: not needed to build the RPM

[Freeipa-devel] [PATCH] 2 Fix handling of /etc/hosts

2011-02-15 Thread Jan Cholasta
Fixes handling of empty lines, erroneous lines and comments in /etc/hosts. https://fedorahosted.org/freeipa/ticket/971 Honza From 1313015b03fb9174a0d911cf81bf4968cb3f693f Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Tue, 15 Feb 2011 17:51:18 +0100 Subject: [PATCH] Fix

Re: [Freeipa-devel] [PATCH] 2 Fix handling of /etc/hosts

2011-02-15 Thread Jan Cholasta
D'oh! Fixed. Honza Dne 15.2.2011 18:14, Rob Crittenden napsal(a): Jan Cholasta wrote: Fixes handling of empty lines, erroneous lines and comments in /etc/hosts. https://fedorahosted.org/freeipa/ticket/971 nack. Would using line.rstrip() be better than the conditional checking explicitly

[Freeipa-devel] [PATCH] 4 Fix wording of error message

2011-03-28 Thread Jan Cholasta
Change the wording of the error message The IPA Server hostname cannot resolve to localhost to The IPA Server hostname must not resolve to localhost. https://fedorahosted.org/freeipa/ticket/1009 -- Jan Cholasta From 69084689247691fb9d7a89ea636e0273d3185e22 Mon Sep 17 00:00:00 2001 From: Jan

Re: [Freeipa-devel] [PATCH] 3 Add ability to specify netmask with IP addresses during installation

2011-03-29 Thread Jan Cholasta
Dne 28.3.2011 15:50, Adam Young napsal(a): On 03/28/2011 06:54 AM, Jan Cholasta wrote: This patch enables the user to specify netmask/prefix length with IP addresses (see http://packages.python.org/netaddr/netaddr.ip.IPNetwork-class.html) during installation for proper DNS reverse zone setup

Re: [Freeipa-devel] [PATCH] 3 Add ability to specify netmask with IP addresses during installation

2011-03-29 Thread Jan Cholasta
Sorry, forgot to attach the patch. -- Jan Cholasta From 0e859303c63b895efb82bd1fa4c09108baf18f43 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Tue, 29 Mar 2011 15:15:23 +0200 Subject: [PATCH] Add ability to specify netmask/prefix length with IP addresses during install

[Freeipa-devel] [PATCH] 5 Add note about ipa-dns-install to ipa-server-install man page

2011-03-29 Thread Jan Cholasta
Added the note so that users know that they can setup DNS at any time after ipa-server-install. https://fedorahosted.org/freeipa/ticket/1082 -- Jan Cholasta From d7d892db3af102b02d6af638e08d85bd51e7c4b6 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Tue, 29 Mar 2011 15

Re: [Freeipa-devel] [PATCH] 5 Add note about ipa-dns-install to ipa-server-install man page

2011-03-30 Thread Jan Cholasta
On 30.3.2011 01:01, David O'Brien wrote: Jan Cholasta wrote: Added the note so that users know that they can setup DNS at any time after ipa-server-install. https://fedorahosted.org/freeipa/ticket/1082

Re: [Freeipa-devel] [PATCH] 3 Add ability to specify netmask with IP addresses during installation

2011-03-30 Thread Jan Cholasta
On 29.3.2011 22:15, Rob Crittenden wrote: Jan Cholasta wrote: Sorry, forgot to attach the patch. Is this why you have some blind excepts? installutils._IPAddressWithPrefix('192.168.0.1/33') Traceback (most recent call last): File stdin, line 1, in module File ipaserver/install

[Freeipa-devel] [PATCH] 6 Add lint script for static code analysis

2011-04-07 Thread Jan Cholasta
This patch adds a script based on pylint for static code analysis during build. https://fedorahosted.org/freeipa/ticket/867 -- Jan Cholasta From 12e7ee4cd3b479c677fdbac10e99c223f1378da5 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Thu, 7 Apr 2011 16:49:05 +0200 Subject

[Freeipa-devel] [PATCH] Fix lint false positives

2011-04-07 Thread Jan Cholasta
Added changes to the code necesarry for removal of false positives reported by the lint script (see my previous patch). -- Jan Cholasta From c766cbccb463ced328a0f34f4f31f9f9cc70a0f7 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Thu, 7 Apr 2011 16:53:52 +0200 Subject

[Freeipa-devel] [PATCH] 8 Fix typo in ipa-server-install

2011-04-07 Thread Jan Cholasta
Fixed typo in ipa-server-install. -- Jan Cholasta From 07ff87e1015d896e413e87a8c6b233978323f2a8 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Thu, 7 Apr 2011 17:26:15 +0200 Subject: [PATCH] Fix typo in ipa-server-install. --- install/tools/ipa-server-install |2

[Freeipa-devel] [PATCH] 9 Fix unitialized variables

2011-04-11 Thread Jan Cholasta
Fixed unitialized variables in makeapi validate_api. -- Jan Cholasta From 9f7357597d1121b9128cfd467c4a8e48c06f9ef8 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Mon, 11 Apr 2011 14:41:10 +0200 Subject: [PATCH] Fix uninitialized variables. --- makeapi |7 +++ 1

[Freeipa-devel] [PATCH] 10 Fix double definition

2011-04-11 Thread Jan Cholasta
Fixed double definition of Command.output_for_cli. -- Jan Cholasta From 609a8de7a0b6139c6971645360831df505180910 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Mon, 11 Apr 2011 14:45:56 +0200 Subject: [PATCH] Fix double definition of output_for_cli. --- ipalib

[Freeipa-devel] [PATCH] 11 Fix unitialized attributes

2011-04-11 Thread Jan Cholasta
Fixed unitialized attributes in ipalib.aci.ACI, ipalib.parameters.Data, ipalib.text.LazyText, ipaserver.install.service.Service and ipaserver.rpcserver.WSGIExecutioner. -- Jan Cholasta From 4e6a5de5a1fbf308873f491b0a8e3c270f264ff6 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com

Re: [Freeipa-devel] [PATCH] 6 Add lint script for static code analysis

2011-04-11 Thread Jan Cholasta
On 7.4.2011 17:00, Jan Cholasta wrote: This patch adds a script based on pylint for static code analysis during build. https://fedorahosted.org/freeipa/ticket/867 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com

Re: [Freeipa-devel] [PATCH] 3 Add ability to specify netmask with IP addresses during installation

2011-04-13 Thread Jan Cholasta
On 11.4.2011 12:48, Jan Cholasta wrote: On 8.4.2011 16:26, Rob Crittenden wrote: Jan Cholasta wrote: On 29.3.2011 22:15, Rob Crittenden wrote: Jan Cholasta wrote: Sorry, forgot to attach the patch. Is this why you have some blind excepts? installutils._IPAddressWithPrefix('192.168.0.1/33

Re: [Freeipa-devel] [PATCH] 11 Fix unitialized attributes

2011-04-13 Thread Jan Cholasta
On 13.4.2011 13:04, Martin Kosek wrote: On Mon, 2011-04-11 at 15:07 +0200, Jan Cholasta wrote: Fixed unitialized attributes in ipalib.aci.ACI, ipalib.parameters.Data, ipalib.text.LazyText, ipaserver.install.service.Service and ipaserver.rpcserver.WSGIExecutioner. NACK. This patch breaks

Re: [Freeipa-devel] [PATCH] 11 Fix unitialized attributes

2011-04-14 Thread Jan Cholasta
On 13.4.2011 15:21, Jan Cholasta wrote: On 13.4.2011 13:04, Martin Kosek wrote: On Mon, 2011-04-11 at 15:07 +0200, Jan Cholasta wrote: Fixed unitialized attributes in ipalib.aci.ACI, ipalib.parameters.Data, ipalib.text.LazyText, ipaserver.install.service.Service

[Freeipa-devel] [PATCH] 12 Remove unused classes

2011-04-14 Thread Jan Cholasta
Removes unused classes NSPRConnection and NSPRHTTP from ipapython.nsslib. -- Jan Cholasta From 6f53c650bb88a316cf42db8e31631f11e4a1be4b Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Thu, 14 Apr 2011 13:00:36 +0200 Subject: [PATCH] Remove unused classes. Removed

[Freeipa-devel] [PATCH] 13 Final lint fixes

2011-04-14 Thread Jan Cholasta
Fixes additional false positives found in install/po/test_i18n.py and a missing import in ipa-nis-manage. This should be the last patch dealing with pylint-discovered issues. -- Jan Cholasta From 6937c6aa5966e4dfcd1586710b90c3118f76869d Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol

Re: [Freeipa-devel] [PATCH] 3 Add ability to specify netmask with IP addresses during installation

2011-04-21 Thread Jan Cholasta
On 20.4.2011 22:08, Rob Crittenden wrote: Jan Cholasta wrote: On 11.4.2011 12:48, Jan Cholasta wrote: On 8.4.2011 16:26, Rob Crittenden wrote: Jan Cholasta wrote: On 29.3.2011 22:15, Rob Crittenden wrote: Jan Cholasta wrote: Sorry, forgot to attach the patch. Is this why you have some

Re: [Freeipa-devel] [PATCH] 11 Fix unitialized attributes

2011-04-21 Thread Jan Cholasta
On 14.4.2011 12:58, Jan Cholasta wrote: On 13.4.2011 15:21, Jan Cholasta wrote: On 13.4.2011 13:04, Martin Kosek wrote: On Mon, 2011-04-11 at 15:07 +0200, Jan Cholasta wrote: Fixed unitialized attributes in ipalib.aci.ACI, ipalib.parameters.Data, ipalib.text.LazyText

Re: [Freeipa-devel] [PATCH] 11 Fix unitialized attributes

2011-04-21 Thread Jan Cholasta
On 21.4.2011 10:45, Martin Kosek wrote: On Thu, 2011-04-21 at 10:18 +0200, Jan Cholasta wrote: On 14.4.2011 12:58, Jan Cholasta wrote: On 13.4.2011 15:21, Jan Cholasta wrote: On 13.4.2011 13:04, Martin Kosek wrote: On Mon, 2011-04-11 at 15:07 +0200, Jan Cholasta wrote: Fixed unitialized

[Freeipa-devel] [PATCH] 14 Run lint during each build

2011-04-26 Thread Jan Cholasta
Automatically run the lint script during make rpms|client-rpms|srpms. -- Jan Cholasta From 2b7db6c086948bbfa63eef25fc0fe783eccc90c5 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Tue, 26 Apr 2011 13:39:39 +0200 Subject: [PATCH] Run lint during each build. ticket 1180

Re: [Freeipa-devel] [PATCH] 14 Run lint during each build

2011-04-27 Thread Jan Cholasta
On 26.4.2011 18:14, Martin Kosek wrote: On Tue, 2011-04-26 at 13:42 +0200, Jan Cholasta wrote: Automatically run the lint script during make rpms|client-rpms|srpms. NACK until ticket 1184 is resolved and pushed. Currently, pylint check fails when optional python packages (like python-rhsm

Re: [Freeipa-devel] [PATCH] 14 Run lint during each build

2011-04-27 Thread Jan Cholasta
On 27.4.2011 13:17, Martin Kosek wrote: On Wed, 2011-04-27 at 12:40 +0200, Jan Cholasta wrote: On 26.4.2011 18:14, Martin Kosek wrote: On Tue, 2011-04-26 at 13:42 +0200, Jan Cholasta wrote: Automatically run the lint script during make rpms|client-rpms|srpms. NACK until ticket 1184

Re: [Freeipa-devel] [PATCH] 14 Run lint during each build

2011-04-28 Thread Jan Cholasta
:13 AM, Jan Cholasta wrote: On 27.4.2011 13:17, Martin Kosek wrote: On Wed, 2011-04-27 at 12:40 +0200, Jan Cholasta wrote: On 26.4.2011 18:14, Martin Kosek wrote: On Tue, 2011-04-26 at 13:42 +0200, Jan Cholasta wrote: Automatically run the lint script during make rpms|client-rpms|srpms. NACK

[Freeipa-devel] [PATCH] 15 Report missing python packages

2011-04-28 Thread Jan Cholasta
Improved make-lint to report missing external python packages and fixed a few little bugs in it. I'd like to ask someone (preferably a native English speaker) to go through the new error messages (at the beginning and end of make-lint) and rephrase them if necessary. -- Jan Cholasta From

[Freeipa-devel] [PATCH] 16 Fixes for issues found by Coverity

2011-04-29 Thread Jan Cholasta
https://fedorahosted.org/freeipa/ticket/1166 https://fedorahosted.org/freeipa/ticket/1167 https://fedorahosted.org/freeipa/ticket/1168 https://fedorahosted.org/freeipa/ticket/1169 -- Jan Cholasta From 92e8887f257a30b48c1a8d313ec4a6d68e17012a Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol

[Freeipa-devel] [PATCH] 17 Fix regressions introduced by pylint false positive fixes

2011-05-05 Thread Jan Cholasta
https://fedorahosted.org/freeipa/ticket/1198 Honza -- Jan Cholasta From f09adc42237a15c2b517a1a34f47dc2952f41c08 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Thu, 5 May 2011 13:39:54 +0200 Subject: [PATCH] Fix regressions introduced by pylint false positive fixes

Re: [Freeipa-devel] [PATCH] 762 Let the framework be able to override the hostname

2011-05-10 Thread Jan Cholasta
everywhere, instead of socket.gethostname and similar. That would fix ticket 1035 too. -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-05-10 Thread Jan Cholasta
Split from patch 3. https://fedorahosted.org/freeipa/ticket/1212 Honza -- Jan Cholasta From 68dacbd0b4ada4c2f02570c167c34c299ceec57e Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Tue, 10 May 2011 19:23:31 +0200 Subject: [PATCH] Parse netmasks in IP addresses passed

Re: [Freeipa-devel] [PATCH] 3 Add ability to specify netmask with IP addresses during installation

2011-05-10 Thread Jan Cholasta
On 21.4.2011 09:36, Jan Cholasta wrote: On 20.4.2011 22:08, Rob Crittenden wrote: Jan Cholasta wrote: On 11.4.2011 12:48, Jan Cholasta wrote: On 8.4.2011 16:26, Rob Crittenden wrote: Jan Cholasta wrote: On 29.3.2011 22:15, Rob Crittenden wrote: Jan Cholasta wrote: Sorry, forgot to attach

[Freeipa-devel] [PATCH] 19 Do stricter checking of IP addressed passed to server install

2011-05-10 Thread Jan Cholasta
Split from patch 3, requires patch 18. https://fedorahosted.org/freeipa/ticket/1213 Honza -- Jan Cholasta From 3e218c2028e5769779aac1cfaae558ae7f047ef8 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Tue, 10 May 2011 19:35:31 +0200 Subject: [PATCH] Do stricter checking

Re: [Freeipa-devel] [PATCH] 762 Let the framework be able to override the hostname

2011-05-11 Thread Jan Cholasta
On 10.5.2011 15:51, Rob Crittenden wrote: Jan Cholasta wrote: On 1.4.2011 17:47, Rob Crittenden wrote: The hostname is passed in during the server installation. We should use this hostname for the resulting server as well. It was being discarded and we always used the system hostname value

Re: [Freeipa-devel] [PATCH] 762 Let the framework be able to override the hostname

2011-05-12 Thread Jan Cholasta
On 11.5.2011 22:58, Rob Crittenden wrote: Jan Cholasta wrote: On 10.5.2011 15:51, Rob Crittenden wrote: Jan Cholasta wrote: On 1.4.2011 17:47, Rob Crittenden wrote: The hostname is passed in during the server installation. We should use this hostname for the resulting server as well

Re: [Freeipa-devel] [PATCH] 3 Add ability to specify netmask with IP addresses during installation

2011-05-12 Thread Jan Cholasta
On 11.5.2011 15:58, Martin Kosek wrote: On Tue, 2011-05-10 at 20:10 +0200, Jan Cholasta wrote: On 21.4.2011 09:36, Jan Cholasta wrote: On 20.4.2011 22:08, Rob Crittenden wrote: Jan Cholasta wrote: On 11.4.2011 12:48, Jan Cholasta wrote: On 8.4.2011 16:26, Rob Crittenden wrote: Jan Cholasta

[Freeipa-devel] [PATCH] 20 Assume ipa help for plugins

2011-05-13 Thread Jan Cholasta
Show help for plugin when the user runs 'ipa plugin', instead of printing an error message about unknown command. https://fedorahosted.org/freeipa/ticket/914 Honza -- Jan Cholasta From e7aee9a1b6f08816a5d2b9ae40b80e3bfc594541 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com

Re: [Freeipa-devel] [PATCH] 19 Do stricter checking of IP addressed passed to server install

2011-05-16 Thread Jan Cholasta
On 16.5.2011 17:26, Martin Kosek wrote: On Tue, 2011-05-10 at 20:11 +0200, Jan Cholasta wrote: Split from patch 3, requires patch 18. https://fedorahosted.org/freeipa/ticket/1213 Honza I tested all patches (3.6, 18, 19), but I think some work still needs to be done: 1) What about adding

Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-05-20 Thread Jan Cholasta
On 10.5.2011 20:06, Jan Cholasta wrote: Parse netmasks in IP addresses passed to server install. ticket 1212 Patch updated. TODO: Write unit test for ipapython.ipautil.CheckedIPAddress TODO: Clean unreachable code paths off of ipa-server-install (?) TODO: Workarounds for netaddr bugs

Re: [Freeipa-devel] [PATCH] 19 Do stricter checking of IP addressed passed to server install

2011-05-20 Thread Jan Cholasta
On 18.5.2011 10:51, Martin Kosek wrote: On Mon, 2011-05-16 at 19:15 +0200, Jan Cholasta wrote: On 16.5.2011 17:26, Martin Kosek wrote: On Tue, 2011-05-10 at 20:11 +0200, Jan Cholasta wrote: Split from patch 3, requires patch 18. https://fedorahosted.org/freeipa/ticket/1213 Honza I tested

Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-05-23 Thread Jan Cholasta
On 22.5.2011 18:28, Jakub Hrozek wrote: On 05/20/2011 08:27 PM, Jan Cholasta wrote: TODO: Clean unreachable code paths off of ipa-server-install (?) In general I agree even though I don't know exactly what code you have in mind -- if the code is dead there's no reason to keep it. I've

Re: [Freeipa-devel] [PATCH] 19 Do stricter checking of IP addressed passed to server install

2011-05-24 Thread Jan Cholasta
On 24.5.2011 14:43, Martin Kosek wrote: On Fri, 2011-05-20 at 20:34 +0200, Jan Cholasta wrote: On 18.5.2011 10:51, Martin Kosek wrote: On Mon, 2011-05-16 at 19:15 +0200, Jan Cholasta wrote: On 16.5.2011 17:26, Martin Kosek wrote: On Tue, 2011-05-10 at 20:11 +0200, Jan Cholasta wrote: Split

Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-05-24 Thread Jan Cholasta
On 20.5.2011 20:27, Jan Cholasta wrote: On 10.5.2011 20:06, Jan Cholasta wrote: Parse netmasks in IP addresses passed to server install. ticket 1212 Patch updated. TODO: Write unit test for ipapython.ipautil.CheckedIPAddress TODO: Clean unreachable code paths off of ipa-server-install

Re: [Freeipa-devel] [PATCH] 19 Do stricter checking of IP addressed passed to server install

2011-05-24 Thread Jan Cholasta
On 24.5.2011 14:44, Jan Cholasta wrote: On 24.5.2011 14:43, Martin Kosek wrote: On Fri, 2011-05-20 at 20:34 +0200, Jan Cholasta wrote: On 18.5.2011 10:51, Martin Kosek wrote: On Mon, 2011-05-16 at 19:15 +0200, Jan Cholasta wrote: On 16.5.2011 17:26, Martin Kosek wrote: On Tue, 2011-05-10

Re: [Freeipa-devel] [PATCH] 069 Improve interactive mode for DNS plugin

2011-05-26 Thread Jan Cholasta
: new blank line at EOF. + warning: 4 lines add whitespace errors. Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-05-27 Thread Jan Cholasta
On 24.5.2011 15:38, Jan Cholasta wrote: On 20.5.2011 20:27, Jan Cholasta wrote: On 10.5.2011 20:06, Jan Cholasta wrote: Parse netmasks in IP addresses passed to server install. ticket 1212 Patch updated. TODO: Write unit test for ipapython.ipautil.CheckedIPAddress TODO: Clean unreachable

Re: [Freeipa-devel] [PATCH] 3 Add ability to specify netmask with IP addresses during installation

2011-05-27 Thread Jan Cholasta
On 20.5.2011 20:29, Jan Cholasta wrote: On 12.5.2011 14:47, Jan Cholasta wrote: Rewrote host.py so that it doesn't use get_reverse_zone from ipaserver.bindinstance (which fixes the pylint errors). Honza Patch updated. Requires patch 18.1. Another update, requires patch 18.3. Honza

Re: [Freeipa-devel] [PATCH] 19 Do stricter checking of IP addressed passed to server install

2011-05-27 Thread Jan Cholasta
On 25.5.2011 09:46, Martin Kosek wrote: On Tue, 2011-05-24 at 15:42 +0200, Jan Cholasta wrote: On 24.5.2011 14:44, Jan Cholasta wrote: On 24.5.2011 14:43, Martin Kosek wrote: On Fri, 2011-05-20 at 20:34 +0200, Jan Cholasta wrote: On 18.5.2011 10:51, Martin Kosek wrote: On Mon, 2011-05-16

Re: [Freeipa-devel] [PATCH] 789 improve label when prompting for members

2011-05-27 Thread Jan Cholasta
in nature, just affecting the CLI. ticket 1062 rob ACK, works as expected. Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-05-27 Thread Jan Cholasta
On 27.5.2011 18:59, Martin Kosek wrote: On Fri, 2011-05-27 at 16:47 +0200, Jan Cholasta wrote: On 24.5.2011 15:38, Jan Cholasta wrote: On 20.5.2011 20:27, Jan Cholasta wrote: On 10.5.2011 20:06, Jan Cholasta wrote: Parse netmasks in IP addresses passed to server install. ticket 1212 Patch

Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-06-06 Thread Jan Cholasta
On 2.6.2011 08:23, Jakub Hrozek wrote: On 06/02/2011 08:18 AM, Jakub Hrozek wrote: On 05/23/2011 08:00 AM, Jan Cholasta wrote: On 22.5.2011 18:28, Jakub Hrozek wrote: On 05/20/2011 08:27 PM, Jan Cholasta wrote: TODO: Clean unreachable code paths off of ipa-server-install (?) In general I

Re: [Freeipa-devel] [PATCH] 779 Require an imported certificate's issuer to match our issuer

2011-06-06 Thread Jan Cholasta
that the tests in make test have a chance to run. Similarly, the tests which use the test certificate created by make-testcert should be skipped if the certificate isn't available. Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel

Re: [Freeipa-devel] [PATCH] 779 Require an imported certificate's issuer to match our issuer

2011-06-07 Thread Jan Cholasta
On 6.6.2011 21:25, Rob Crittenden wrote: Jan Cholasta wrote: On 26.4.2011 22:52, Rob Crittenden wrote: The goal is to not import foreign certificates. This caused a bunch of tests to fail because we had a hardcoded server certificate. Instead a developer will need to run make-testcert

[Freeipa-devel] [PATCH] 21 Fix directory manager password validation in ipa-nis-manage

2011-06-08 Thread Jan Cholasta
https://fedorahosted.org/freeipa/ticket/1283 https://fedorahosted.org/freeipa/ticket/1284 Honza -- Jan Cholasta From 7567db4bedc08ce4d649f33d7d37af7970a32145 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Wed, 8 Jun 2011 14:39:50 +0200 Subject: [PATCH] Fix directory

Re: [Freeipa-devel] [PATCH] 785 data type of certificates

2011-06-08 Thread Jan Cholasta
'verify_cert_subject' Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 21 Fix directory manager password validation in ipa-nis-manage

2011-06-13 Thread Jan Cholasta
On 9.6.2011 14:50, Martin Kosek wrote: On Wed, 2011-06-08 at 15:21 +0200, Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/1283 https://fedorahosted.org/freeipa/ticket/1284 Honza Patch works fine, but I'd like to improve code quality a bit. Please don't call sys.exit() from

Re: [Freeipa-devel] [PATCH] 799 The IP address provided to ipa-server-install must be local

2011-06-14 Thread Jan Cholasta
stable branch nor in RHEL 6.1. But this should be OK since it is targeted for RHEL 6.2. Martin Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 22 Improve IP address handling in the host-add command

2011-06-14 Thread Jan Cholasta
Cholasta From 173366da60b85ba2ffc9b014d4207bf4dbfb66e2 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Tue, 14 Jun 2011 16:31:36 +0200 Subject: [PATCH] Improve IP address handling in the host-add command. IP addresses are more strictly checked. Netmasks can be specified

Re: [Freeipa-devel] [PATCH] 799 The IP address provided to ipa-server-install must be local

2011-06-16 Thread Jan Cholasta
/freeipa-devel Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 22 Improve IP address handling in the host-add command

2011-06-16 Thread Jan Cholasta
On 14.6.2011 20:54, Simo Sorce wrote: On Tue, 2011-06-14 at 14:26 -0400, Rob Crittenden wrote: Jan Cholasta wrote: This patch enables the user to specify netmasks in the --ip-address option of host-add. They're used for proper DNS reverse zone and PTR record creation. Also the IP addresses

Re: [Freeipa-devel] [PATCH] 779 Require an imported certificate's issuer to match our issuer

2011-06-16 Thread Jan Cholasta
On 14.6.2011 15:16, Rob Crittenden wrote: Jan Cholasta wrote: On 6.6.2011 21:25, Rob Crittenden wrote: Jan Cholasta wrote: On 26.4.2011 22:52, Rob Crittenden wrote: The goal is to not import foreign certificates. This caused a bunch of tests to fail because we had a hardcoded server

Re: [Freeipa-devel] [PATCH] 779 Require an imported certificate's issuer to match our issuer

2011-06-16 Thread Jan Cholasta
On 16.6.2011 15:12, Rob Crittenden wrote: Rob Crittenden wrote: Jan Cholasta wrote: On 14.6.2011 15:16, Rob Crittenden wrote: Jan Cholasta wrote: On 6.6.2011 21:25, Rob Crittenden wrote: Jan Cholasta wrote: On 26.4.2011 22:52, Rob Crittenden wrote: The goal is to not import foreign

Re: [Freeipa-devel] [PATCH] 22 Improve IP address handling in the host-add command

2011-06-20 Thread Jan Cholasta
On 16.6.2011 14:31, Jan Cholasta wrote: On 14.6.2011 20:54, Simo Sorce wrote: On Tue, 2011-06-14 at 14:26 -0400, Rob Crittenden wrote: Jan Cholasta wrote: This patch enables the user to specify netmasks in the --ip-address option of host-add. They're used for proper DNS reverse zone and PTR

[Freeipa-devel] [PATCH] 23 Add ability to specify DNS reverse zone name by IP network address

2011-06-21 Thread Jan Cholasta
This patch adds a new option name_from_ip to dnszone commands. Default value of idnsname is created from this option. Honza -- Jan Cholasta From d84375d986cf496337a31059c1dec8cf8b31fe59 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Tue, 21 Jun 2011 14:07:19 +0200

Re: [Freeipa-devel] [PATCH] 23 Add ability to specify DNS reverse zone name by IP network address

2011-06-21 Thread Jan Cholasta
On 21.6.2011 16:00, Dmitri Pal wrote: On 06/21/2011 08:15 AM, Jan Cholasta wrote: This patch adds a new option name_from_ip to dnszone commands. Default value of idnsname is created from this option. Honza ___ Freeipa-devel mailing list Freeipa

Re: [Freeipa-devel] [PATCH] 23 Add ability to specify DNS reverse zone name by IP network address

2011-06-21 Thread Jan Cholasta
On 21.6.2011 16:20, Martin Kosek wrote: On Tue, 2011-06-21 at 14:15 +0200, Jan Cholasta wrote: This patch adds a new option name_from_ip to dnszone commands. Default value of idnsname is created from this option. Honza One more comment - we don't want major API version change. This would

Re: [Freeipa-devel] [PATCH] 23 Add ability to specify DNS reverse zone name by IP network address

2011-06-21 Thread Jan Cholasta
On 21.6.2011 16:04, Adam Young wrote: On 06/21/2011 08:15 AM, Jan Cholasta wrote: This patch adds a new option name_from_ip to dnszone commands. Default value of idnsname is created from this option. Honza ___ Freeipa-devel mailing list Freeipa

Re: [Freeipa-devel] [PATCH] 785 data type of certificates

2011-06-22 Thread Jan Cholasta
On 8.6.2011 16:56, Rob Crittenden wrote: Jan Cholasta wrote: On 18.5.2011 17:21, Rob Crittenden wrote: Make data type of certificates more obvious/predictable internally. For the most part certificates will be treated as being in DER format. When we load a certificate we will generally accept

[Freeipa-devel] [PATCH] 24 Verify that the hostname is fully-qualified

2011-06-23 Thread Jan Cholasta
This patch makes ipactl fail if the hostname isn't fully-qualified. It also fixes ipa-server-install to fail gracefully in such case, instead of failing with unexpected error. https://fedorahosted.org/freeipa/ticket/1035 Honza -- Jan Cholasta From a73adeab91f294204ef8ca0d145320d7ef6aa172 Mon

Re: [Freeipa-devel] [PATCH] 23 Add ability to specify DNS reverse zone name by IP network address

2011-06-23 Thread Jan Cholasta
On 21.6.2011 14:15, Jan Cholasta wrote: This patch adds a new option name_from_ip to dnszone commands. Default value of idnsname is created from this option. Honza Fixed the API version number, added usage example to dns plugin help. https://fedorahosted.org/freeipa/ticket/1045 Honza

Re: [Freeipa-devel] [PATCH] 24 Verify that the hostname is fully-qualified

2011-06-24 Thread Jan Cholasta
On 23.6.2011 17:19, Martin Kosek wrote: On Thu, 2011-06-23 at 16:33 +0200, Jan Cholasta wrote: This patch makes ipactl fail if the hostname isn't fully-qualified. It also fixes ipa-server-install to fail gracefully in such case, instead of failing with unexpected error. https

[Freeipa-devel] [PATCH] 25 Update minimum required version of python-netaddr

2011-06-28 Thread Jan Cholasta
https://fedorahosted.org/freeipa/ticket/1288 Honza -- Jan Cholasta From 1738b9d1027218bc721e44c6f8edbe5aa68261ab Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Tue, 28 Jun 2011 11:15:26 +0200 Subject: [PATCH] Update minimum required version of python-netaddr. ticket 1288

[Freeipa-devel] [PATCH] 27 Replace the 'private' option in netgroup-find with, 'managed'

2011-06-28 Thread Jan Cholasta
This patch effectively renames the netgroup-find option 'private' to 'managed'. 'private' is kept in to maintain API compatibility, but hidden from the user. https://fedorahosted.org/freeipa/ticket/1120 Honza -- Jan Cholasta From b8bb02e4aea59438fcad0c77c78540416889b3b5 Mon Sep 17 00:00:00

Re: [Freeipa-devel] [PATCH] 23 Add ability to specify DNS reverse zone name by IP network address

2011-07-01 Thread Jan Cholasta
On 30.6.2011 22:54, Adam Young wrote: On 06/28/2011 02:08 PM, Rob Crittenden wrote: Jan Cholasta wrote: On 21.6.2011 14:15, Jan Cholasta wrote: This patch adds a new option name_from_ip to dnszone commands. Default value of idnsname is created from this option. Honza Fixed the API version

Re: [Freeipa-devel] [PATCH] 25 Update minimum required version of python-netaddr

2011-07-01 Thread Jan Cholasta
On 28.6.2011 16:14, Jakub Hrozek wrote: On 06/28/2011 08:52 AM, Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/1288 Honza I gather this is done in order to get rid of the try: except all hack in installer? This works fine with F15 and F16 in mind. However, if the specfile

Re: [Freeipa-devel] [PATCH] 4 (1) ipa-client-install complains about non-existing nss_ldap

2011-07-01 Thread Jan Cholasta
, as that's platform-specific. Wouldn't just rephrasing the warning message (as suggested in the ticket) be sufficient? Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 4 (1) ipa-client-install complains about non-existing nss_ldap

2011-07-01 Thread Jan Cholasta
On 1.7.2011 14:00, Alexander Bokovoy wrote: Hi, On 01.07.2011 14:54, Jan Cholasta wrote: On 1.7.2011 11:44, Alexander Bokovoy wrote: New version: forgot to import package_installed_name from ipautil. Previous version can be ignored. ipa-client-install should be usable on non-RH platforms

Re: [Freeipa-devel] [PATCH] 25 Update minimum required version of python-netaddr

2011-07-01 Thread Jan Cholasta
On 1.7.2011 16:34, Jakub Hrozek wrote: On 07/01/2011 06:35 AM, Jan Cholasta wrote: On 28.6.2011 16:14, Jakub Hrozek wrote: On 06/28/2011 08:52 AM, Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/1288 Honza I gather this is done in order to get rid of the try: except all hack

[Freeipa-devel] [PATCH] 28 Fix creation of reverse DNS zones

2011-07-12 Thread Jan Cholasta
of using the netmask part of the --ip-address option. The reverse zone name is printed to the user during the install. https://fedorahosted.org/freeipa/ticket/1398 Honza -- Jan Cholasta From 0c0a797c09102e5c9abd36629a2f66d7121e5a2f Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com

[Freeipa-devel] [PATCH] 29 Configure SSSD to store password if offline

2011-07-13 Thread Jan Cholasta
Enable the krb5_store_password_if_offline option in sssd.conf by default. To turn it off, use --no-krb5-offline-passwords option in ipa-client-install. https://fedorahosted.org/freeipa/ticket/1359 Honza -- Jan Cholasta From 7cd7a371fa85410f2dd22250ed9473a6a28ab71e Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH] 090 Remove sensitive information from logs

2011-07-13 Thread Jan Cholasta
On 12.7.2011 10:16, Martin Kosek wrote: When -w/--password option is passed to ipa-replica-install it is printed to ipareplica-install.log. Make sure that the value of this option is hidden. https://fedorahosted.org/freeipa/ticket/1378 ACK Honza -- Jan Cholasta

[Freeipa-devel] [PATCH] 30 Fix exit status of ipa-nis-manage-enable

2011-07-14 Thread Jan Cholasta
https://fedorahosted.org/freeipa/ticket/1247 Honza -- Jan Cholasta From d59876c8f55e42bb17ecb9a637f9a7a4478143f3 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Thu, 14 Jul 2011 09:07:41 +0200 Subject: [PATCH] Fix exit status of ipa-nis-manage enable. ticket 1247

Re: [Freeipa-devel] [PATCH] 23 Add ability to specify DNS reverse zone name by IP network address

2011-07-14 Thread Jan Cholasta
On 28.6.2011 20:08, Rob Crittenden wrote: Jan Cholasta wrote: On 21.6.2011 14:15, Jan Cholasta wrote: This patch adds a new option name_from_ip to dnszone commands. Default value of idnsname is created from this option. Honza Fixed the API version number, added usage example to dns plugin

Re: [Freeipa-devel] [PATCH] 809 entitle_register using uuid unsupported

2011-07-14 Thread Jan Cholasta
). This is supported in the REST API but not python-rhsm. I've filed an RFE to get this added but for now this is a way to not do major surgery to the API and still be at least somewhat user-friendly. https://fedorahosted.org/freeipa/ticket/1216 rob ACK Honza -- Jan Cholasta

Re: [Freeipa-devel] [PATCH] 825 add dogtag replication management

2011-07-15 Thread Jan Cholasta
for this? Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 825 add dogtag replication management

2011-07-15 Thread Jan Cholasta
On 15.7.2011 21:24, Rob Crittenden wrote: Rich Megginson wrote: On 07/15/2011 10:57 AM, Rob Crittenden wrote: Rich Megginson wrote: On 07/15/2011 08:01 AM, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2011-07-15 at 14:43 +0200, Jan Cholasta wrote: On 15.7.2011 05:42, Rob Crittenden

Re: [Freeipa-devel] [PATCH] 824 make more sensible nicknames

2011-07-18 Thread Jan Cholasta
it is to install with an external CA, then install a replica with a CA to be sure that works as well. Testing basic installs would be handy as well. rob ACK, everything seems to work fine. Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa

Re: [Freeipa-devel] [PATCH] 826 fix failing memberof tests

2011-07-18 Thread Jan Cholasta
On 15.7.2011 23:20, Rob Crittenden wrote: With the recent object_name/label changes some tests were failing that were expecting the old value which contained a space. This fixes them. rob ACK. Honza -- Jan Cholasta ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 096 Fix ipa-dns-install incorrect warning

2011-07-18 Thread Jan Cholasta
removes some redundant IP address checks from ipa-server-install, see attachment. Honza -- Jan Cholasta From 947708b36bdf6979e11850217a98738f01f896f0 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Mon, 18 Jul 2011 13:36:47 +0200 Subject: [PATCH] Clean up of IP address checks

Re: [Freeipa-devel] [PATCH] 088 Check IPA configuration in install tools

2011-07-18 Thread Jan Cholasta
/ipa-replica-prepare:68: [E0602, parse_options] Undefined variable 'config' Does anyone run make-lint before submitting a patch or during review at all? :( Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https

Re: [Freeipa-devel] [PATCH] 088 Check IPA configuration in install tools

2011-07-18 Thread Jan Cholasta
On 18.7.2011 15:00, Martin Kosek wrote: On Mon, 2011-07-18 at 14:35 +0200, Jan Cholasta wrote: On 18.7.2011 09:41, Martin Kosek wrote: On Fri, 2011-07-15 at 10:14 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2011-06-22 at 18:03 -0400, Rob Crittenden wrote: Martin Kosek wrote

[Freeipa-devel] [PATCH] 32 Don't delete NIS netgroup compat suffix on 'ipa-nis-manage disable'

2011-07-18 Thread Jan Cholasta
https://fedorahosted.org/freeipa/ticket/1469 Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 32 Don't delete NIS netgroup compat suffix on 'ipa-nis-manage disable'

2011-07-19 Thread Jan Cholasta
On 18.7.2011 18:48, Martin Kosek wrote: On Mon, 2011-07-18 at 17:16 +0200, Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/1469 Honza The patch is missing. Martin Is it? ...it is! Sorry. Honza -- Jan Cholasta From 7ec54681c9eeb89b60ee6d5a7d8c1611be0c4af3 Mon Sep 17 00:00

Re: [Freeipa-devel] [PATCH] 098 Fix sudorule-remove-user

2011-07-19 Thread Jan Cholasta
On 19.7.2011 10:48, Martin Kosek wrote: This is a follow up to JR's patch 36. --- Removed sudorule External User is displayed in the output when --all switch is used. https://fedorahosted.org/freeipa/ticket/1489 ACK. Honza -- Jan Cholasta

Re: [Freeipa-devel] [PATCH] 831 fix removing external netgroup hosts

2011-07-19 Thread Jan Cholasta
. IMO you should either use the result (as Martin did in patch 98) or remove the ldap.get_entry line altogether (please correct me if I'm missing something). Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https

Re: [Freeipa-devel] [PATCH] 831 fix removing external netgroup hosts

2011-07-19 Thread Jan Cholasta
On 19.7.2011 16:08, Rob Crittenden wrote: Jan Cholasta wrote: On 19.7.2011 15:34, Rob Crittenden wrote: When removing an external host member it was still showing in the return data as a member despite being removed properly. ticket https://fedorahosted.org/freeipa/ticket/1492 You store

Re: [Freeipa-devel] [PATCH] 067 Silence a compilation warning in ipa_kpasswd

2011-07-21 Thread Jan Cholasta
for indentation, but the rest of the file uses tabs. Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

  1   2   3   4   5   6   7   8   9   10   >