Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-13 Thread Hegel3DReloaded
On Monday, December 13th, 2021 at 12:17 PM, Dominik Vogt wrote: > On Mon, Dec 13, 2021 at 07:40:06AM +, Hegel3DReloaded wrote: > > > Yes, I fixed a leak at the cost of introducing a crash. > > > > I see. It is working now. May I close > > https://github.com/fvwmorg/fvwm3/issues/647 > >

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-13 Thread Dominik Vogt
On Mon, Dec 13, 2021 at 08:06:41AM +, Hegel3DReloaded wrote: > It appears that on "Restart" Front Panel ends up in the +0 +0, upper left > corner of the screen. It starts ok, it is placed at the bottom center > part, but something relocates it in the last moment. I remember we had this >

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-13 Thread Dominik Vogt
On Mon, Dec 13, 2021 at 07:40:06AM +, Hegel3DReloaded wrote: > On Monday, December 13th, 2021 at 2:14 AM, Dominik Vogt > wrote: > > On Mon, Dec 13, 2021 at 12:22:47AM +, Hegel3DReloaded wrote: > > > > Is this has something to do with intensive work you and Thomas did > > > couple weeks

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-13 Thread Hegel3DReloaded
On Monday, December 13th, 2021 at 2:51 AM, Dominik Vogt wrote: > I've committed a patch to master that truncates out of range sizes > and positions to the max/min values instead of rejecting them. Yes, it is ok now. > Is there anything else in your config that's out of range? The X > protocol

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-12 Thread Hegel3DReloaded
On Monday, December 13th, 2021 at 2:14 AM, Dominik Vogt wrote: > On Mon, Dec 13, 2021 at 12:22:47AM +, Hegel3DReloaded wrote: > > Is this has something to do with intensive work you and Thomas did > > couple weeks ago with new parser? > > Yes, I fixed a leak at the cost of introducing a

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-12 Thread Dominik Vogt
On Mon, Dec 13, 2021 at 12:32:53AM +, Hegel3DReloaded wrote: > On Monday, December 13th, 2021 at 1:18 AM, Dominik Vogt > wrote: > > On Mon, Dec 13, 2021 at 12:12:30AM +, Hegel3DReloaded wrote: > > > > "Move +32768p +32768p", > > > Side note: The maximum valid position is +32767p +32767p.

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-12 Thread Dominik Vogt
On Mon, Dec 13, 2021 at 12:22:47AM +, Hegel3DReloaded wrote: > > I'm not very happy with the "new" monitor handling code. It added > > potentially broken new parsing code all over the place. That > > should really be done in a single, well tested parser. At the > > moment we have a myriad of

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-12 Thread Hegel3DReloaded
On Monday, December 13th, 2021 at 1:12 AM, Dominik Vogt wrote: > On Sun, Dec 12, 2021 at 11:46:05PM +, Hegel3DReloaded wrote: > > Sorry to say, but I even didn't have a chance to start after trying to log > > in. > > It crashes badly. Something to do with malloc and pointers. > > Should be

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-12 Thread Dominik Vogt
On Mon, Dec 13, 2021 at 12:12:30AM +, Hegel3DReloaded wrote: > On Monday, December 13th, 2021 at 12:46 AM, Hegel3DReloaded > wrote: > > On Sunday, December 12th, 2021 at 12:40 PM, Dominik Vogt > > dominik.v...@gmx.de wrote: > > > > The dv/pager-noaspect should work now, but I've not tested

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-12 Thread Dominik Vogt
On Sun, Dec 12, 2021 at 11:46:05PM +, Hegel3DReloaded wrote: > On Sunday, December 12th, 2021 at 12:40 PM, Dominik Vogt > wrote: > > > On Sat, Dec 04, 2021 at 02:04:48PM +, Hegel3DReloaded wrote: > > >> Sounds ok. Which branch should I checkout to test this? > > > The dv/pager-noaspect

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-12 Thread Hegel3DReloaded
On Monday, December 13th, 2021 at 12:46 AM, Hegel3DReloaded wrote: > On Sunday, December 12th, 2021 at 12:40 PM, Dominik Vogt dominik.v...@gmx.de > wrote: > > The dv/pager-noaspect should work now, but I've not tested it with > > multiple monitors. I have found temporary workaround to comment

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-12 Thread Hegel3DReloaded
On Sunday, December 12th, 2021 at 12:40 PM, Dominik Vogt wrote: > On Sat, Dec 04, 2021 at 02:04:48PM +, Hegel3DReloaded wrote: >> Sounds ok. Which branch should I checkout to test this? > The dv/pager-noaspect should work now, but I've not tested it with > multiple monitors. Hi Dominik,

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-12 Thread Dominik Vogt
On Sat, Dec 04, 2021 at 02:04:48PM +, Hegel3DReloaded wrote: > On Sat, Dec 04, 2021 at 02:13:06PM +0100, Dominik Vogt wrote: > >> On Sat, Dec 04, 2021 at 02:03:46PM +0100, Dominik Vogt wrote: > > >> Maybe the scaling argument can be set to "auto" or something to > >> keep the desktopscale

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-04 Thread Dominik Vogt
On Sat, Dec 04, 2021 at 02:04:48PM +, Hegel3DReloaded wrote: > > Experimental patch attached (only initial size calculation; no > > live resizing yet). > > Sounds ok. Which branch should I checkout to test this? Try out dv/pager-noaspect. It contains more work to allow resizing the window

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-04 Thread Hegel3DReloaded
On Sat, Dec 04, 2021 at 02:13:06PM +0100, Dominik Vogt wrote: >> On Sat, Dec 04, 2021 at 02:03:46PM +0100, Dominik Vogt wrote: >> Maybe the scaling argument can be set to "auto" or something to >> keep the desktopscale within reasonable limits? (The example with >> desktopsize 50x1 earlkier in

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-04 Thread Dominik Vogt
On Sat, Dec 04, 2021 at 02:13:06PM +0100, Dominik Vogt wrote: > On Sat, Dec 04, 2021 at 02:03:46PM +0100, Dominik Vogt wrote: > > Maybe the scaling argument can be set to "auto" or something to > > keep the desktopscale within reasonable limits? (The example with > > desktopsize 50x1 earlkier in

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-04 Thread Dominik Vogt
On Sat, Dec 04, 2021 at 02:03:46PM +0100, Dominik Vogt wrote: > Maybe the scaling argument can be set to "auto" or something to > keep the desktopscale within reasonable limits? (The example with > desktopsize 50x1 earlkier in the discussion showed that the pager > currently does not have a

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-04 Thread Dominik Vogt
On Sat, Dec 04, 2021 at 11:14:09AM +, Hegel3DReloaded wrote: > On Saturday, December 4th, 2021 at 11:39 AM, Dominik Vogt > wrote: > > > Okay, that is a real problem. The pager definitely needs to react > > to changes of the desktop layout, be it by attaching or detaching > > monitors at run

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-04 Thread Hegel3DReloaded
On Saturday, December 4th, 2021 at 11:39 AM, Dominik Vogt wrote: > Okay, that is a real problem. The pager definitely needs to react > to changes of the desktop layout, be it by attaching or detaching > monitors at run time or by issuing the desktopsize command. > > The pager should fix that

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-04 Thread Dominik Vogt
On Sat, Dec 04, 2021 at 10:09:34AM +, Hegel3DReloaded wrote: > Yes, there are some cases, or rather there > will be them in FVWM3 when it will approach the point where resolution > change, or new monitor addition will not mandate fvwm restart to get things > in place. In this case, FvwmPager

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-04 Thread Dominik Vogt
I've committed two patches. 1) fac9eb945e442bebfb2612fed8edb68a9853a6ca Removes minimum size, base size and size increment hints from the pager. This change has not been disputed by anybody. 2) ff3afd31466f604ee5a3711486d1b1da2ee2b090 Also removes the aspect ratio hint. this patch could be

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-04 Thread Hegel3DReloaded
On Wednesday, December 1st, 2021 at 2:13 AM, Dominik Vogt wrote: > On Tue, Nov 30, 2021 at 02:51:49PM +, Hegel3DReloaded wrote: >> Maybe having ctrl+mouse-resize as I proposed above? > Okay, I can imagine rare cases when one wants to re-enforce a > multiple of the original aspect ratio,

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-11-30 Thread Dominik Vogt
On Tue, Nov 30, 2021 at 02:51:49PM +, Hegel3DReloaded wrote: > > The situation is: > > 1. It's implementation is more or less broken everywhere. => > > Nobody uses it. > > > 2. If the ratio is not close to 1, it's outright annoying or even > > unusable. Try this: > > > >

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-11-30 Thread Hegel3DReloaded
Hi all, On Tuesday, November 30th, 2021 at 2:57 PM, Dominik Vogt wrote: > Still, what is the benefit of having an aspect ratio set? For a non-swallowed floating FvwmPager, I think it makes a sense that screen aspect ratio is preserved in it's smaller representation. Like: 16:10, 16:9, 4:3 etc

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-11-30 Thread Dominik Vogt
On Mon, Nov 29, 2021 at 01:02:04PM -0700, Jaimos Skriletz wrote: > If you set a geometry, *FvwmButtons: Geometry 100x100, the aspect > ratio hints do not get set (as in the default-config), and you can > resize the window to be any size. Yes, but that doesn't help for the FvwmButtons panel. The

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-11-29 Thread Jaimos Skriletz
On Sat, Nov 27, 2021 at 4:11 PM Dominik Vogt wrote: > > On Sat, Nov 27, 2021 at 02:44:07PM -0700, Jaimos Skriletz wrote: > > > then FvwmButtons will resize to fit without preserving aspect ratio. > > FvwmButtons does honour the aspect ratio (see above). > If you set a geometry, *FvwmButtons:

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-11-27 Thread Dominik Vogt
On Sat, Nov 27, 2021 at 02:44:07PM -0700, Jaimos Skriletz wrote: > On Sat, Nov 27, 2021 at 1:59 PM Dominik Vogt wrote: > > > > From commit 601c5c294a6a48fd402fbfca02b62142796167eb > > > > >* Improved use of sizehints to set both minimum window size, and to > > > preserve aspect ratio

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-11-27 Thread Jaimos Skriletz
On Sat, Nov 27, 2021 at 2:44 PM Jaimos Skriletz wrote: > > This can currently be disabled by proving an initial Geometry (though > it needs to be bigger than some minimum size I recall like 100x100) > then FvwmButtons will resize to fit without preserving aspect ratio. > I think I made it seem

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-11-27 Thread Jaimos Skriletz
On Sat, Nov 27, 2021 at 1:59 PM Dominik Vogt wrote: > > From commit 601c5c294a6a48fd402fbfca02b62142796167eb > > >* Improved use of sizehints to set both minimum window size, and to > > preserve aspect ratio when resizing the pager. The aspect ratio is > > set to the initial size

FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-11-27 Thread Dominik Vogt
From commit 601c5c294a6a48fd402fbfca02b62142796167eb >* Improved use of sizehints to set both minimum window size, and to > preserve aspect ratio when resizing the pager. The aspect ratio is > set to the initial size of the window unless the user sets window > size with the