Build failed in Jenkins: master-simtrace2 » a1=default,a2=default,a3=default,osmocom-master-debian9 #203

2018-11-27 Thread jenkins
See -- [...truncated 168.05 KB...] 8 0 0 8 8 obj/owhw/dfu_boardver_adc.o 30

Change in osmo-ttcn3-hacks[master]: library/SS_Templates.ttcn: add SS_USSD_FACILITY_INVOKE templates

2018-11-27 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/11959 Change subject: library/SS_Templates.ttcn: add SS_USSD_FACILITY_INVOKE templates .. library/SS_Templates.ttcn: add SS_USSD_FACILITY_INVOKE

Change in osmo-ttcn3-hacks[master]: HLR_Tests.ttcn: introduce TC_mo_sss_reject

2018-11-27 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/11960 Change subject: HLR_Tests.ttcn: introduce TC_mo_sss_reject .. HLR_Tests.ttcn: introduce TC_mo_sss_reject As at the moment, OsmoHLR

Change in osmo-bsc[master]: cosmetic: bsc: timeslot_fsm: Clean uneeded scope brackets

2018-11-27 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11955 ) Change subject: cosmetic: bsc: timeslot_fsm: Clean uneeded scope brackets .. Patch Set 1: Code-Review+2 (1 comment) In my opinion, the

Change in python/osmo-python-tests[master]: ctrl: cosmetic cleanup

2018-11-27 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11930 ) Change subject: ctrl: cosmetic cleanup .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11930 To unsubscribe,

Change in python/osmo-python-tests[master]: osmo_ctrl.py: properly ignore out-of-order traps

2018-11-27 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11909 ) Change subject: osmo_ctrl.py: properly ignore out-of-order traps .. Patch Set 4: Code-Review+1 (1 comment) (leaving +2 to pespin)

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 5: (1 comment)

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 5: Code-Review-1 (3 comments) the idea is to first add

Change in osmo-bsc[master]: cosmetic: bsc: timeslot_fsm: Clean uneeded scope brackets

2018-11-27 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11955 ) Change subject: cosmetic: bsc: timeslot_fsm: Clean uneeded scope brackets .. Patch Set 1: Code-Review+1 -- To view, visit

Change in python/osmo-python-tests[master]: ctrl2cgi: fix deferred callbacks

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11953 ) Change subject: ctrl2cgi: fix deferred callbacks .. Patch Set 2: (1 comment)

Change in python/osmo-python-tests[master]: Move Trap class back to separate files

2018-11-27 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11952 ) Change subject: Move Trap class back to separate files .. Move Trap class back to separate files After further testing it turns out that

Change in python/osmo-python-tests[master]: Update trap helper

2018-11-27 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11951 ) Change subject: Update trap helper .. Update trap helper * add missing import * update docs * add helper functions Change-Id:

Change in python/osmo-python-tests[master]: ctrl2cgi: fix deferred callbacks

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11953 ) Change subject: ctrl2cgi: fix deferred callbacks .. Patch Set 2: (1 comment)

Change in python/osmo-python-tests[master]: Move Trap class back to separate files

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11952 ) Change subject: Move Trap class back to separate files .. Patch Set 2: Code-Review+2 -- To view, visit

Change in python/osmo-python-tests[master]: Update trap helper

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11951 ) Change subject: Update trap helper .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11951 To unsubscribe, or

Change in osmo-bsc[master]: bsc: timeslot_fsm: ts_is_pchan_switching: Set correct target pchan fo...

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11954 ) Change subject: bsc: timeslot_fsm: ts_is_pchan_switching: Set correct target pchan for IPA dynts .. Patch Set 3: >From here on I still

Change in osmo-bsc[master]: WIP: bsc: timeslot_fsm: Set TS state as unused instead of broken on P...

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11958 Change subject: WIP: bsc: timeslot_fsm: Set TS state as unused instead of broken on PDCH DEACT NACK .. WIP: bsc: timeslot_fsm: Set TS

Change in osmo-bsc[master]: bsc: trx_count_free_ts: Fix counting of GSM_PCHAN_PDCH

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11956 Change subject: bsc: trx_count_free_ts: Fix counting of GSM_PCHAN_PDCH .. bsc: trx_count_free_ts: Fix counting of GSM_PCHAN_PDCH PDCH

Change in osmo-bsc[master]: bsc: timeslot_fsm: ts_is_pchan_switching: Set correct target pchan fo...

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11954 Change subject: bsc: timeslot_fsm: ts_is_pchan_switching: Set correct target pchan for IPA dynts .. bsc: timeslot_fsm:

Change in python/osmo-python-tests[master]: ctrl2cgi: fix deferred callbacks

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11953 ) Change subject: ctrl2cgi: fix deferred callbacks .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11953 To unsubscribe, or for

Change in python/osmo-python-tests[master]: Move Trap class back to separate files

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11952 ) Change subject: Move Trap class back to separate files .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11952 To unsubscribe, or

Change in python/osmo-python-tests[master]: Update trap helper

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11951 ) Change subject: Update trap helper .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11951 To unsubscribe, or for help writing

Change in osmo-ttcn3-hacks[master]: bsc: Start the timer at the beginning of f_init

2018-11-27 Thread daniel
daniel has submitted this change and it was merged. ( https://gerrit.osmocom.org/11950 ) Change subject: bsc: Start the timer at the beginning of f_init .. bsc: Start the timer at the beginning of f_init This avoids a possible

Change in python/osmo-python-tests[master]: ctrl2cgi: fix deferred callbacks

2018-11-27 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11953 Change subject: ctrl2cgi: fix deferred callbacks .. ctrl2cgi: fix deferred callbacks Previously handle_reply() was marked as deferred callback unlike

Change in python/osmo-python-tests[master]: Update trap helper

2018-11-27 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11951 Change subject: Update trap helper .. Update trap helper * add missing import * update docs * add helper functions Change-Id:

Change in python/osmo-python-tests[master]: Move Trap class back to separate files

2018-11-27 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11952 Change subject: Move Trap class back to separate files .. Move Trap class back to separate files After further testing it turns out that Trap() have

Change in osmo-ttcn3-hacks[master]: bsc: Start the timer at the beginning of f_init

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11950 ) Change subject: bsc: Start the timer at the beginning of f_init .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: bsc: Start the timer at the beginning of f_init

2018-11-27 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/11950 ) Change subject: bsc: Start the timer at the beginning of f_init .. Patch Set 1: If the value of tguard is now too short for some of the tests

Change in osmo-ttcn3-hacks[master]: bsc: Start the timer at the beginning of f_init

2018-11-27 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/11950 Change subject: bsc: Start the timer at the beginning of f_init .. bsc: Start the timer at the beginning of f_init This avoids a possible

Change in osmo-ci[master]: jobs: master-builds: Disable deprecated cellmgr-ng failing to build

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11944 ) Change subject: jobs: master-builds: Disable deprecated cellmgr-ng failing to build .. jobs: master-builds: Disable deprecated

Change in osmo-ci[master]: jobs: master-builds: Disable deprecated cellmgr-ng failing to build

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11944 ) Change subject: jobs: master-builds: Disable deprecated cellmgr-ng failing to build .. Patch Set 2: Verified+1 -- To view, visit

Change in osmo-ci[master]: jobs: master-builds: Disable deprecated cellmgr-ng failing to build

2018-11-27 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11944 ) Change subject: jobs: master-builds: Disable deprecated cellmgr-ng failing to build .. Patch Set 2: -Verified -- To view, visit

Change in osmo-ci[master]: jobs: master-builds: Disable deprecated cellmgr-ng failing to build

2018-11-27 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11944 ) Change subject: jobs: master-builds: Disable deprecated cellmgr-ng failing to build .. Patch Set 2: Verified+1 Code-Review+2 -- To view,

Build failed in Jenkins: master-cellmgr-ng » a1=default,a2=default,a3=default,osmocom-master-debian9 #59

2018-11-27 Thread jenkins
See Changes: [Pau Espin Pedrol] contrib/jenkins.sh: Update script to fix several issues and use recent [Pau Espin Pedrol] tests: Fix build

Change in cellmgr-ng[master]: tests: Fix build of mtp_parse_test

2018-11-27 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11946 ) Change subject: tests: Fix build of mtp_parse_test .. tests: Fix build of mtp_parse_test Change-Id:

Change in cellmgr-ng[master]: vty: skip installing cmds now always installed by default

2018-11-27 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/4605 ) Change subject: vty: skip installing cmds now always installed by default .. vty: skip installing cmds now always installed by

Change in cellmgr-ng[master]: contrib/jenkins.sh: Update script to fix several issues and use recen...

2018-11-27 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11945 ) Change subject: contrib/jenkins.sh: Update script to fix several issues and use recent osmo-ci utils .. contrib/jenkins.sh: Update

Change in cellmgr-ng[master]: README: Add deprecation note

2018-11-27 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11947 ) Change subject: README: Add deprecation note .. README: Add deprecation note Change-Id: I0c6fe9d0c59110211f8cc2ac28ce93b885fd565d

Change in osmo-sysmon[master]: fix file descriptor leak in osysmon_file_read

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11943 ) Change subject: fix file descriptor leak in osysmon_file_read .. Patch Set 2: Code-Review+1 (2 comments) Just a minor thing though - can be merged

Change in osmo-sysmon[master]: fix file descriptor leak in osysmon_file_read

2018-11-27 Thread Stefan Sperling
Hello Max, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11943 to look at the new patch set (#2). Change subject: fix file descriptor leak in osysmon_file_read

Change in osmo-mgw[master]: add DLCX command statistics to osmo-mgw

2018-11-27 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11521 ) Change subject: add DLCX command statistics to osmo-mgw .. add DLCX command statistics to osmo-mgw Add a counter group for DLCX

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 5: > If we are otherwise happy with this time, Oops,

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 5: > - If needed, run upgrade commands. I think I would

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Stefan Sperling
Hello Pau Espin Pedrol, Vadim Yanitskiy, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11898 to look at the new patch set (#5). Change subject: add database schema versioning to the HLR database

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 4: > Patch Set 4: Code-Review-1 > Also, I think an

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 4: (1 comment)

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 4: (1 comment)

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 4: I found a way to check the existence of tables in the

Change in python/osmo-python-tests[master]: Re-apply changes to trap_helper.py

2018-11-27 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11948 ) Change subject: Re-apply changes to trap_helper.py .. Re-apply changes to trap_helper.py Due to changes getting out of sync, changes from

Change in osmo-bts[master]: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT

2018-11-27 Thread Pau Espin Pedrol
Hello Vadim Yanitskiy, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11932 to look at the new patch set (#3). Change subject: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT

Change in osmo-trx[master]: change scaling factor from .3 to .7 for lms sdr devices to improve th...

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11949 ) Change subject: change scaling factor from .3 to .7 for lms sdr devices to improve the signal slope .. Patch Set 1: (2 comments)

Change in osmo-bsc[master]: follow-up: logging tweak for Immediate Assignment

2018-11-27 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11942 ) Change subject: follow-up: logging tweak for Immediate Assignment .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-trx[master]: change scaling factor from .3 to .7 for lms sdr devices to improve th...

2018-11-27 Thread roh
roh has uploaded this change for review. ( https://gerrit.osmocom.org/11949 Change subject: change scaling factor from .3 to .7 for lms sdr devices to improve the signal slope .. change scaling factor from .3 to .7 for lms sdr

Change in osmo-bts[master]: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11932 ) Change subject: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT .. Patch Set 1: (1 comment)

Change in python/osmo-python-tests[master]: Re-apply changes to trap_helper.py

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11948 ) Change subject: Re-apply changes to trap_helper.py .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11948 To

Change in python/osmo-python-tests[master]: Re-apply changes to trap_helper.py

2018-11-27 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11948 Change subject: Re-apply changes to trap_helper.py .. Re-apply changes to trap_helper.py Due to changes getting out of sync, changes from

Change in cellmgr-ng[master]: vty: skip installing cmds now always installed by default

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/4605 ) Change subject: vty: skip installing cmds now always installed by default .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit

Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add function to skip TRAP messages .. Patch Set 3: > > if you'd receive an IPA message with len(payload) == 0

Change in osmo-bsc[master]: paging: Add VTY options to calculate T3113 timeout dynamically

2018-11-27 Thread Pau Espin Pedrol
Hello Stefan Sperling, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11654 to look at the new patch set (#5). Change subject: paging: Add VTY options to calculate T3113 timeout dynamically

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11728 ) Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. Patch Set 4: (1 comment)

Change in osmo-bsc[master]: paging: Add VTY options to calculate T3113 timeout dynamically

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11654 ) Change subject: paging: Add VTY options to calculate T3113 timeout dynamically .. Patch Set 3: (1 comment)

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11728 ) Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. Patch Set 4: On another note - most likely I'll need to add

Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add function to skip TRAP messages .. Patch Set 3: > if you'd receive an IPA message with len(payload) == 0 followed by an IPA

Change in cellmgr-ng[master]: contrib/jenkins.sh: Update script to fix several issues and use recen...

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11945 ) Change subject: contrib/jenkins.sh: Update script to fix several issues and use recent osmo-ci utils .. Patch Set 1: It's expected

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-27 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Move common Trap-related code into separate file The ctrl2cgi.py is

Change in cellmgr-ng[master]: README: Add deprecation note

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11947 Change subject: README: Add deprecation note .. README: Add deprecation note Change-Id: I0c6fe9d0c59110211f8cc2ac28ce93b885fd565d --- M

Change in cellmgr-ng[master]: contrib/jenkins.sh: Update script to fix several issues and use recen...

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11945 Change subject: contrib/jenkins.sh: Update script to fix several issues and use recent osmo-ci utils .. contrib/jenkins.sh: Update

Change in cellmgr-ng[master]: tests: Fix build of mtp_parse_test

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11946 Change subject: tests: Fix build of mtp_parse_test .. tests: Fix build of mtp_parse_test Change-Id:

Change in osmo-ci[master]: jobs: master-builds: Disable deprecated cellmgr-ng failing to build

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/11944 ) Change subject: jobs: master-builds: Disable deprecated cellmgr-ng failing to build .. jobs: master-builds: Disable deprecated cellmgr-ng

Change in osmo-ci[master]: jobs: master-builds: Disable deprecated cellmgr-ng failing to build

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11944 Change subject: jobs: master-builds: Disable deprecated cellmgr-ng failing to build .. jobs: master-builds: Disable deprecated

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 4: I'm fine with including this patch (although I don't

Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add function to skip TRAP messages .. Patch Set 2: (1 comment)

Change in osmo-mgw[master]: add DLCX command statistics to osmo-mgw

2018-11-27 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11521 ) Change subject: add DLCX command statistics to osmo-mgw .. Patch Set 5: pourquoi tu ne merge pas? waiting for the patch to acquire a

Build failed in Jenkins: master-cellmgr-ng » a1=default,a2=default,a3=default,osmocom-master-debian9 #58

2018-11-27 Thread jenkins
See -- [...truncated 172.26 KB...] config.status: executing libtool commands +

Change in osmo-sysmon[master]: fix file descriptor leak in osysmon_file_read

2018-11-27 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11943 ) Change subject: fix file descriptor leak in osysmon_file_read .. Patch Set 1: Code-Review+2 (1 comment) OK to merge the first fix, but

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Patch Set 3: Code-Review+2 Ah sorry I thought the trap_helper.py

Change in osmo-bsc[master]: follow-up: logging tweak for Immediate Assignment

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11942 ) Change subject: follow-up: logging tweak for Immediate Assignment .. Patch Set 1: (1 comment)

Change in osmo-msc[master]: libmsc/transaction.c: cosmetic: fix typo

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11941 ) Change subject: libmsc/transaction.c: cosmetic: fix typo .. libmsc/transaction.c: cosmetic: fix typo Change-Id:

Change in osmo-msc[master]: libmsc/transaction.c: cosmetic: fix typo

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11941 ) Change subject: libmsc/transaction.c: cosmetic: fix typo .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 4: After some talking: if there is no "proper" solution to

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11728 ) Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. Patch Set 4: (1 comment)

Change in osmo-sysmon[master]: fix file descriptor leak in osysmon_file_read

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11943 ) Change subject: fix file descriptor leak in osysmon_file_read .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/11943/1/osysmon_file.c

Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add function to skip TRAP messages .. Patch Set 2: (1 comment) Please elaborate - either complete function as you'd like to

Change in osmo-sysmon[master]: fix file descriptor leak in osysmon_file_read

2018-11-27 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11943 Change subject: fix file descriptor leak in osysmon_file_read .. fix file descriptor leak in osysmon_file_read Don't forget to close the

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Patch Set 3: We might want to bump the .deb version to match the python one - not

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Patch Set 3: > Did you try actually the script can be imported if installed in

Change in osmo-bsc[master]: send Immediate Assignment Reject only before Immediate Assignment

2018-11-27 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11940 ) Change subject: send Immediate Assignment Reject only before Immediate Assignment .. Patch Set 2: (1 comment) see

Change in osmo-bsc[master]: follow-up: logging tweak for Immediate Assignment

2018-11-27 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11942 Change subject: follow-up: logging tweak for Immediate Assignment .. follow-up: logging tweak for Immediate Assignment follow-up to

Change in libsmpp34[master]: fix use of partly initialized struct in tcp test

2018-11-27 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11854 ) Change subject: fix use of partly initialized struct in tcp test .. fix use of partly initialized struct in tcp test Properly

Change in openbsc[master]: bsc-nat: Enable octet-aligned when ensuring mode set

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/6598 ) Change subject: bsc-nat: Enable octet-aligned when ensuring mode set .. bsc-nat: Enable octet-aligned when ensuring mode set

Change in osmo-bts[master]: bts_model: Allow TS connect to be processed asynchronously

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11931 ) Change subject: bts_model: Allow TS connect to be processed asynchronously .. bts_model: Allow TS connect to be processed

Change in osmo-dev[master]: Add expect script: 'vty' for easy access to all vtys

2018-11-27 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/11811 ) Change subject: Add expect script: 'vty' for easy access to all vtys .. Patch Set 2: Thanks all for the reviews. I've been thinking more

Jenkins build is back to normal : master-osmo-trx » --with-sse,a2=default,a3=default,osmocom-master-debian9 #695

2018-11-27 Thread jenkins
See

Change in osmo-msc[master]: libmsc/transaction: introduce trans_find_by_sm_rp_mr()

2018-11-27 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11917 ) Change subject: libmsc/transaction: introduce trans_find_by_sm_rp_mr() .. Set Ready For Review -- To view, visit

Change in libosmocore[master]: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages

2018-11-27 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11069 ) Change subject: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages .. Set Ready For Review -- To view, visit

Change in libosmocore[master]: GSUP/SMS: introduce READY-FOR-SM message

2018-11-27 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11751 ) Change subject: GSUP/SMS: introduce READY-FOR-SM message .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11751 To

Change in osmo-msc[master]: libmsc/transaction.c: cosmetic: fix typo

2018-11-27 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/11941 Change subject: libmsc/transaction.c: cosmetic: fix typo .. libmsc/transaction.c: cosmetic: fix typo Change-Id: