Harald Welte has submitted this change and it was merged.
Change subject: osmux: Use correct log category DLMUX
..
osmux: Use correct log category DLMUX
Change-Id: I77f4593941207689f714d15304dcce40b21d4bd8
---
M src/osmux.c
1
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7143
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77f4593941207689f714d15304dcce40b21d4bd8
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: hodec2: log nr of neighbors in meas report
..
cosmetic: hodec2: log nr of neighbors in meas report
Rationale: explicitly indicate the case of
Harald Welte has submitted this change and it was merged.
Change subject: gsm48_parse_meas_rep(): set num_cell=0 if no neighbor cells are
reported
..
gsm48_parse_meas_rep(): set num_cell=0 if no neighbor cells are reported
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: typo in log: handover_decision2.c: 'measuements'
..
cosmetic: typo in log: handover_decision2.c: 'measuements'
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7150
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09ddfd5b09883ec0124fe485346d9ed26de454e8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7149
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie12210660a04f2d664ddc92e7ad7fc39ee474180
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7151
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a92a03feb7dbef2bb008016310ec243226a7c7a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1:
I didn't argue against the patch, I just argued against the claim that this was
new, unexpected or undefined ;)
--
To view, visit https://gerrit.osmocom.org/7121
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7121
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05ce33a4e42bc82b9ce5060e2f811033f5a1f8d8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1:
(3 comments)
In general, looks good.
Regarding to the $(top_builddir), this could be done
in a separate change...
https://gerrit.osmocom.org/#/c/7148/1/Transceiver52M/arm/Makefile.am
File Transceiver52M/arm/Makefile.am:
Line 12: libarch_la_LIBADD = ../common/libarch_common.la
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7146
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ff57ab14edc575904e8137929a0ef02c95e03af
Gerrit-PatchSet: 3
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1:
> It works as both the function caller and the function itself are in the same
> .c/.o file.
In this case the function caller is somewhere deep in libbsc, and it is calling
a function originally defined somewhere deep in libosmo-abis. We are putting
another definition that
Patch Set 1:
> Why do you need each of this?
> -Wno-error=deprecated -Wno-error=deprecated-declarations
> -Wno-error=cpp
it's all explained in the commit log as well as the ./configure --help
--
To view, visit https://gerrit.osmocom.org/7096
To unsubscribe, visit
Review at https://gerrit.osmocom.org/7151
cosmetic: typo in log: handover_decision2.c: 'measuements'
Change-Id: I8a92a03feb7dbef2bb008016310ec243226a7c7a
---
M src/libbsc/handover_decision_2.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Review at https://gerrit.osmocom.org/7149
gsm48_parse_meas_rep(): set num_cell=0 if no neighbor cells are reported
Set mr->num_cell to 0 if the bits reflect 0x7, which means that no neighbor
cell measurements are enclosed in the report.
The code in gsm48_parse_meas_rep() acknowledges that,
Review at https://gerrit.osmocom.org/7150
cosmetic: hodec2: log nr of neighbors in meas report
Rationale: explicitly indicate the case of zero neighbors.
Change-Id: I09ddfd5b09883ec0124fe485346d9ed26de454e8
---
M src/libbsc/handover_decision_2.c
1 file changed, 2 insertions(+), 1 deletion(-)
Harald Welte has submitted this change and it was merged.
Change subject: a_iface: fix BSSMAP reset handling
..
a_iface: fix BSSMAP reset handling
When osmo-msc restarts it looses all information about the BSC. The
BSC will
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7147
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d7575e5bec9edabcc832c754d19dc5ba489861a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: MSC_Tests: Add testcase TC_cr_before_reset
..
MSC_Tests: Add testcase TC_cr_before_reset
This testcase triggers a bug in the BSSMAP reset logic that
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6840
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fdcec5dbeaa0e21fd6a92568a623faa368239be
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7146
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ff57ab14edc575904e8137929a0ef02c95e03af
Gerrit-PatchSet: 3
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7148
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81bb4251d18fce978d27849b621b20f541caab0b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Makefile.am: Avoid using subdir if arch is not required
There's no need in going a level deeper if we already know nothing's
going to be done. This way we also get cleaner make outputs.
Reference:
Review at https://gerrit.osmocom.org/7148
Build Transceiver52M/common as an .la lib
Stop picking files from that directory on different places as it causes
dependency issues during make distclean/maintainer-clean.
Fixes: OS#3029
Change-Id: I81bb4251d18fce978d27849b621b20f541caab0b
---
M
Patch Set 2: Code-Review-1
--
To view, visit https://gerrit.osmocom.org/7146
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ff57ab14edc575904e8137929a0ef02c95e03af
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 3:
> Please make sure we have a test case for this in the BSC_Tests.ttcn
> suite. Sounds like an easy enough condition to test for?
There is now a TTCN3 test that triggers the bug. See #7147
--
To view, visit https://gerrit.osmocom.org/6840
To unsubscribe, visit
Review at https://gerrit.osmocom.org/7147
MSC_Tests: Add testcase TC_cr_before_reset
This testcase triggers a bug in the BSSMAP reset logic that tricks
the MSC into a deadlock situation. The bug can only be triggered on
a freshly started MSC, otherwise the testcase will not have any
effect at
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6230
to look at the new patch set (#6).
ms: Create a cumulative distribution function class
We are using the CDF to decide which percentage of the jobs
Patch Set 5:
> Thanks for moving the tests to the existing test system. It seems
> however the new test is not being run in jenkins. Running it
> locally (make check) in my PC actually shows it's missing exec
> permission on the file (I don't know why jenkins doesn't fail). you
> need to +x
Patch Set 5: Code-Review-1
Thanks for moving the tests to the existing test system. It seems however the
new test is not being run in jenkins. Running it locally (make check) in my PC
actually shows it's missing exec permission on the file (I don't know why
jenkins doesn't fail). you need to
Patch Set 6:
(1 comment)
https://gerrit.osmocom.org/#/c/6918/6/src/osmo_ms_driver/location_update_test.py
File src/osmo_ms_driver/location_update_test.py:
Line 115: ms.start(loop)
> Oh I now see what you were saying about the variables. This should be bette
Good point. That wasn't
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6918
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3277ed0f0f9ee734569bedd4752564eb68c9cfd
Gerrit-PatchSet: 7
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6917
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c6d742842d7f3e0a1858436ef3f8634d8c0582d
Gerrit-PatchSet: 7
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6917
to look at the new patch set (#7).
ms: Create a starter for virtphy and mobile application
In the long run we might not want to start the virtphy but
Neels Hofmeyr has submitted this change and it was merged.
Change subject: implement support for 3-digit MNC with leading zeros
..
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and
Patch Set 6: Code-Review+2
(2 comments)
https://gerrit.osmocom.org/#/c/6918/6/src/osmo_ms_driver/location_update_test.py
File src/osmo_ms_driver/location_update_test.py:
Line 115: ms.start(loop)
Oh I now see what you were saying about the variables. This should be better
called
Patch Set 6: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/6917/6/src/osmo_ms_driver/starter.py
File src/osmo_ms_driver/starter.py:
Line 58: import time
You forgot to fix this one.
Line 88:
You forgot to fix this one.
--
To view, visit
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6918
to look at the new patch set (#6).
ms: Add a first test to use all parts of the system
This is an interim solution but is bringing all parts together.
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6230
to look at the new patch set (#5).
ms: Create a cumulative distribution function class
We are using the CDF to decide which percentage of the jobs
Makefile.am: Avoid using subdir if arch is not required
There's no need in going a level deeper if we already know nothing's
going to be done. This way we also get cleaner make outputs.
Related: OS#3029
Change-Id: I3ff57ab14edc575904e8137929a0ef02c95e03af
---
M Transceiver52M/Makefile.am
M
Review at https://gerrit.osmocom.org/7146
Makefile.am: Avoid using subdir if arch is not required
There's no need in going a level deeper if we already know nothing's
going to be done. This way we also get cleaner make outputs.
Change-Id: I3ff57ab14edc575904e8137929a0ef02c95e03af
---
M
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/7021/4/jobs/osmo-gsm-tester.yml
File jobs/osmo-gsm-tester.yml:
Line 137: repo: osmo-gsm-tester_build-osmo-bsc
> it's used here. This is a macro using another macro.
ok I understand. Interesting to see that one can use macros,
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/7019/3/jobs/osmo-gsm-tester.yml
File jobs/osmo-gsm-tester.yml:
Line 66: - gsmtester_build_branch:
> Take a look at the macro gsmtester_build_branch.
ah, I get it now, so that macro is adding a string parameter to the job. Maybe
the
Patch Set 1:
(5 comments)
minor cosmetics...
https://gerrit.osmocom.org/#/c/7127/1/ansible/roles/gsm-tester-modems/tasks/main.yml
File ansible/roles/gsm-tester-modems/tasks/main.yml:
Line 2: # modems
USRP and UHD are not related to modems, it is about SDR based BTSes: the entire
UHD stuff
Patch Set 4:
(2 comments)
https://gerrit.osmocom.org/#/c/7021/4/jobs/osmo-gsm-tester.yml
File jobs/osmo-gsm-tester.yml:
Line 127: project: '{repo}'
> where is the {repo} coming from? IIUC the '- project:' section responsible
this is a macro. repo must be given, when calling this
Patch Set 4: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/7021/4/jobs/osmo-gsm-tester.yml
File jobs/osmo-gsm-tester.yml:
Line 127: project: '{repo}'
where is the {repo} coming from? IIUC the '- project:' section responsible for
these jobs doesn't define repos. Is it
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/7020/3/jobs/osmo-gsm-tester.yml
File jobs/osmo-gsm-tester.yml:
Line 105: - job:
this doesn't seem to use any of the above definitions, so it might be clearer
to have it in its own file? I find jjb's job template business
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/7019/3/jobs/osmo-gsm-tester.yml
File jobs/osmo-gsm-tester.yml:
Line 11: repo:
> (our other yml files call this "repos" -- I saw it was also called "repos"
I requested this change, reason is explained in older comments in this same
Patch Set 3: Code-Review+1
(3 comments)
some comments, none really important
https://gerrit.osmocom.org/#/c/7019/3/jobs/osmo-gsm-tester.yml
File jobs/osmo-gsm-tester.yml:
Line 11: repo:
(our other yml files call this "repos" -- I saw it was also called "repos" in
an earlier patch set.
Review at https://gerrit.osmocom.org/7145
osmocom-latest-packages.sh: Catch latest tags outside master branch
Some projects, like osmo-trx, may have tags created in a non-master
branch. Let's catch those too.
Tested with several osmocom repositories. The ones showing different
behaviour are
Patch Set 5: Verified-1
--
To view, visit https://gerrit.osmocom.org/5753
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40e9bf9438c0b400e4d29eb39ffae37207e34db6
Gerrit-PatchSet: 5
Gerrit-Project: osmo-bts
Gerrit-Branch: master
dexter has abandoned this change.
Change subject: Temporarily add V=1 for debugging build problem
..
Abandoned
debugging done
--
To view, visit https://gerrit.osmocom.org/7144
To unsubscribe, visit
Review at https://gerrit.osmocom.org/7144
Temporarily add V=1 for debugging build problem
Change-Id: I43c2763bd7741c1938138b4cde760fbf6902c20a
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/44/7144/1
Review at https://gerrit.osmocom.org/7143
osmux: Use correct log category DLMUX
Change-Id: I77f4593941207689f714d15304dcce40b21d4bd8
---
M src/osmux.c
1 file changed, 27 insertions(+), 27 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/43/7143/1
diff --git
Review at https://gerrit.osmocom.org/7142
introduce an osmo_fsm for gsm_subscriber_connection
In the current implementation of osmo-bsc, the subscriber connection is
not handled (very) statefully. However, there is some state keeping in the
code that handles the mgcp connection, but there are
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5753
to look at the new patch set (#5).
LC15: Fix missing fill frame and GSM 05.08 mandatory frame
It was discovered that the LC15 BTS does not send L2 fill frame
in case there is nothing
Patch Set 4: Verified-1
I've refactored the source code to fit the common Osmocom
code style, but have no opportunity to verify and test.
URGENT: please check everything before submitting!
--
To view, visit https://gerrit.osmocom.org/5753
To unsubscribe, visit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5753
to look at the new patch set (#4).
LC15: Fix missing fill frame and GSM 05.08 mandatory frame
It was discovered that the LC15 BTS does not send L2 fill frame
in case there is nothing
59 matches
Mail list logo
